#dev-contrib | Python | Page 125

vale ibex Aug 12, 2021, 10:04 AM

#

~2.8 is the same as >=2.8.0 <2.9

#

https://www.python.org/dev/peps/pep-0440/#compatible-release

brazen charm Aug 12, 2021, 10:10 AM

#

is ~ just poetry's version of ~= with a bit different semantics on the allowed versions? Seems easy to confuse things when both will be used in the same file

vale ibex Aug 12, 2021, 10:11 AM

#

So poetry's ~= is pep 440 ~=

#

but it also has ~

#

where ~2.8 is >=2.8.0 <2.9

#

for here, it's probably clearer to use ~=2.8.0

#

rather than mix ~ and ~= in the same file

brazen charm Aug 12, 2021, 10:14 AM

#

I think just the tilde requirements to lock in the minor version would make more sense for most of the deps? We can always run poetry update or watever so things don't break like this on unrelated changes

surreal veldt Aug 12, 2021, 10:14 AM

#

How does python get the docs for the docs command?

stable mountainBOT Aug 12, 2021, 10:14 AM

#

Command: docs

Look up documentation for Python symbols.

Source Code

Go to GitHub

vale ibex Aug 12, 2021, 10:15 AM

#

I think that is what would make sense

#

That also seems to be what numerlor is suggesting too

#

that is what you mean by tilda lock the minor version right?

#

~ is tilde

#

~=2.8.0 will mean the minor version is locked and we will just get the latest patch version on update

brazen charm Aug 12, 2021, 10:17 AM

#

I was thinking of just ~x.y which would also lock the minor, and applying that for all of the deps (or most if we can rely on the versioning on some)

vale ibex Aug 12, 2021, 10:18 AM

#

~x.y == ~=x.y.z as far as I can tell

#

and the current poetry file has all ~=

brazen charm Aug 12, 2021, 10:18 AM

#

the file has a mix of locking to major and minor with ~= which just makes things like this likely to come up in the future

vale ibex Aug 12, 2021, 10:18 AM

#

yea

brazen charm Aug 12, 2021, 10:20 AM

#

I'd say use ~= but I think it should be looked into in the projects, I recall flake8 also had a bump in an unrelated PR because of it which then needed to fix linting errors

#

looks like pep8-naming also got bumped, could be a new error

#

then force push

#

It's your own branch on a draft pr, if there's ever a good time to do a force push that is it

celest charm Aug 12, 2021, 10:37 AM

#

That's a terrible warning, Error/Exception at the end is often unnecessary noise

brazen charm Aug 12, 2021, 10:37 AM

#

It's better than leaving some typo in and having to introduce a new commit to fix it and things like that

celest charm Aug 12, 2021, 10:41 AM

#

raise EverythingIsOnFire
``` Hmm I wonder if `EverythingIsOnFire` is a string, list, socket, generic type alias or a Lark parser. ```py
raise EverythingIsOnFireError
``` oh dear, it's an exception, so clear now

celest charm Aug 12, 2021, 11:06 AM

#

I think we discuss flake 8 ignores with the core devs, not sure...

timid sentinel Aug 12, 2021, 11:17 AM

#

in sir-lancebot and bot we just chucked Error on the end when updating

green oriole Aug 12, 2021, 11:19 AM

#

Well

#

That's what we have been doing so far

#

I don't know if it would require a discussion among the core devs or not. I personally don't agree with this but not enough to go and discuss it.

#

Also do you know about precommit @clever wraith?

static canyon Aug 12, 2021, 1:06 PM

#

Can I get another review on bot#1742 please?

dusky shoreBOT Aug 12, 2021, 1:06 PM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser

surreal veldt Aug 12, 2021, 1:07 PM

#

the info for the docs command is stored in a database right

brazen charm Aug 12, 2021, 1:09 PM

#

Yes, the inventories are stored through the site api

short snow Aug 12, 2021, 1:09 PM

#

Tizzy you need to have patience, I have prs waiting from 2-3 months

mint nebula Aug 12, 2021, 1:56 PM

#

is bot#1540 reviewed?

dusky shoreBOT Aug 12, 2021, 1:56 PM

#

GitHub

IssueOpen If an edited message becomes a command, execute that command

vocal prairie Aug 12, 2021, 1:57 PM

#

Doesn't seem to have been approved/denied by a core dev yet, no.

green oriole Aug 12, 2021, 2:17 PM

#

mint nebula is bot#1540 reviewed?

I've answered, thanks!

mint nebula Aug 12, 2021, 2:18 PM

#

great.

#

thanks for answering.

surreal veldt Aug 12, 2021, 2:34 PM

#

for bot#447 , does anyone know the most efficient and reliable way to get the closest matches?

dusky shoreBOT Aug 12, 2021, 2:34 PM

#

GitHub

IssueOpen Support partial searches for documentation

viscid coral Aug 12, 2021, 2:36 PM

#

Yeah I think difflib is also better

surreal veldt Aug 12, 2021, 2:37 PM

#

i dont find it reliable

#

i got one, nvm

celest charm Aug 12, 2021, 2:50 PM

#

fuzzywuzzy is GPL

#

lemon_pensive

#

which is viral, and unfortunately bots don't wear masks

vocal prairie Aug 12, 2021, 2:52 PM

#

celest charm `fuzzywuzzy` is GPL

We switched to using rapidfuzz on the bot which is an MIT-licensed fork of fuzzywuzzy (from before it became GPL)

brazen charm Aug 12, 2021, 2:53 PM

#

not that it's needed, but would the bot being gpl affect anything in a meaningful way?

celest charm Aug 12, 2021, 2:55 PM

#

brazen charm not that it's needed, but would the bot being gpl affect anything in a meaningfu...

I believe we had some plans of extracting stuff from our repos into libraries

#

if I'm not mistaken

#

and if we make changes to these parts while we're GPLd, the libraries would have to be GPL, right?

#

but, well, it's not been tested in court ™️

brazen charm Aug 12, 2021, 2:57 PM

#

ah wasn't aware of that, that'd probably have to be gpl yes; although considering there aren't that many contribs if everyone okayed it, the extracted lib could use an another license

steel isle Aug 12, 2021, 3:16 PM

#

hmmmm

vale ibex Aug 12, 2021, 3:19 PM

#

Yea, we're aware of the issue, working on a fix

patent pivot Aug 12, 2021, 3:23 PM

#

https://status.pythondiscord.com/incident/107348

brisk brook Aug 12, 2021, 3:26 PM

#

😔 lemon_pensive lemon_angrysad 😢

fervent sage Aug 12, 2021, 3:26 PM

#

surreal veldt for bot#447 , does anyone know the most efficient and reliable way to get the cl...

textdistance.JaroWinkler()

viscid coral Aug 12, 2021, 3:35 PM

#

I have a question

#

The source command

#

The docs command*

#

Where does it get the info from?

#

I think someone said a website or some API, can I interact with that API for my bot?

fervent sage Aug 12, 2021, 3:37 PM

#

viscid coral The docs command*

!src d

stable mountainBOT Aug 12, 2021, 3:37 PM

#

Command: docs

Look up documentation for Python symbols.

Source Code

Go to GitHub

viscid coral Aug 12, 2021, 3:38 PM

#

I am not good enough with python and discord.py to understand this

#

It's like:
functions that leads to a functions that leads to a context manager that leads to another function that leads to a class and it's hard lol

dusty bay Aug 12, 2021, 3:41 PM

#

fervent sage `textdistance.JaroWinkler()`

+1, Jaro Winkler is most likely the best option. Should be able to do XXk+/s easily.

It really depends on what you’re trying to match also. 5+ words is a lot different than 1-4 words. You can average the scores of something like JW and smith waterman if you want, it really depends on the goal though

short snow Aug 12, 2021, 3:43 PM

#

There is surely lot of magic in there 🙃 simply put it gets the markdown from the objects source of a particular documentation, for example , https://docs.python.org/3/objects.inv for python, and then parses the markdown

#

That’s what I got right now, I am not familiar with that section

patent pivot Aug 12, 2021, 3:46 PM

#

patent pivot https://status.pythondiscord.com/incident/107348

problems should be resolved

brazen charm Aug 12, 2021, 3:51 PM

#

the tldr of docs would be that the inventory file maps the names you use for the command to the urls where they are located, and then the html in there is converted to discord markdown

surreal veldt Aug 12, 2021, 3:58 PM

#

fervent sage `textdistance.JaroWinkler()`

I'm not familiar with that, which module?

fervent sage Aug 12, 2021, 3:59 PM

#

textdistance

surreal veldt Aug 12, 2021, 4:00 PM

#

Is it better than rapidfuzzy

fervent sage Aug 12, 2021, 4:01 PM

#

I havent played with rapidfuzz, but if its a fork of fuzzywuzzy then yes

timid sentinel Aug 12, 2021, 4:07 PM

#

I think rapidfuzz is quite a bit faster than fuzzywuzzy. Haven't used textdistance before but it seems to focus on giving choices between a lot of different algorithms

gritty wind Aug 12, 2021, 4:07 PM

#

@echo narwhal please review my comments on your last two PRs before opening more

surreal veldt Aug 12, 2021, 4:08 PM

#

Yeah ill stay with rapid fuzzy then

#

Anyone got a good value or ideal one for the score_cutoff kwarg of rapidfuzzy process.extract function

timid sentinel Aug 12, 2021, 4:14 PM

#

depends what you want, i'd just play around with a few different values and see how they work out for you.

surreal veldt Aug 12, 2021, 4:19 PM

#

range -1 to 0 right

timid sentinel Aug 12, 2021, 4:23 PM

#

uhh, I thought it was 0 to 100

#

-1 to 0 seems like a weird range

surreal veldt Aug 12, 2021, 4:25 PM

#

Not sure too, though I'm looking at the docs and it says
score_cutoff (Any, optional) – Optional argument for a score threshold. When an edit distance is used this represents the maximum edit distance and matches with a distance <= score_cutoff are ignored. When a normalized edit distance is used this represents the minimal similarity and matches with a similarity >= score_cutoff are ignored. For edit distances this defaults to -1, while for normalized edit distances this defaults to 0.0, which deactivates this behaviour.
https://maxbachmann.github.io/RapidFuzz/process.html#extract

#

okay maybe it's 0 to hundred

#

For bot#447 if it were to get implemented can I get to which form it would be in? Like how the output of the feature would be? I was thinking if there is more than one result, it will add reactions and according to which one you react to it will edit the message accordingly.

dusky shoreBOT Aug 12, 2021, 4:35 PM

#

GitHub

IssueOpen Support partial searches for documentation

brazen charm Aug 12, 2021, 4:37 PM

#

I think that'd be better to ask on the issue so it can be discussed properly

surreal veldt Aug 12, 2021, 4:50 PM

#

Alright, done thank you

sturdy barn Aug 12, 2021, 4:53 PM

#

It would be nice to have some kind of indicator or countdown to when the channel will be closed due to inactivity

patent pivot Aug 12, 2021, 5:17 PM

#

hey

#

anyone want to test soemthing for me

#

https://prometheus.pythondiscord.com/ what happens when you browse here

brazen charm Aug 12, 2021, 5:18 PM

#

Access denied
This website is using a security service to protect itself from online attacks.

patent pivot Aug 12, 2021, 5:18 PM

#

okay neat

#

#

prometheus.pythondiscord.com & alertmanager.pythondiscord.com

#

maybe I should move our tooling to another domain some day

#

greenTick

#

hmmmm I don't like mtls

#

not for this anyway

#

firefox seems inconsitent

#

mtls rules

#

under firewall/ssl (client certs)

#

can someone see what it says now

#

epic

fervent sage Aug 12, 2021, 5:41 PM

#

Please contact @patent pivot if you experience any problems logging in.

I'm experiencing problems logging in, it wont let me log in angree

patent pivot Aug 12, 2021, 5:41 PM

#

lmfao

fervent sage Aug 12, 2021, 5:42 PM

#

https://tenor.com/view/let-me-in-eric-andre-wanna-come-in-gif-13730108

Tenor

patent pivot Aug 12, 2021, 5:42 PM

#

ok AM works

thorny obsidian Aug 12, 2021, 5:43 PM

#

=[

patent pivot Aug 12, 2021, 5:43 PM

#

shrekt

#

https://tenor.com/view/war-thunder-skill-problem-skill-issue-gif-21453710

Tenor

#

I can grant admins access though one sec

thorny obsidian Aug 12, 2021, 5:44 PM

#

lol it's fine. I can't even see stuff on sentry, so I'm used to devops being a blackbox

patent pivot Aug 12, 2021, 5:44 PM

#

but devops should be OPEN AND BEAUTIFUL

#

lol no open prom access

#

that's a bad idea

vale ibex Aug 12, 2021, 5:46 PM

#

thorny obsidian lol it's fine. I can't even see stuff on sentry, so I'm used to devops being a b...

devops is a black box

patent pivot Aug 12, 2021, 5:46 PM

#

lifecycle endpoint

#

lol

vale ibex Aug 12, 2021, 5:46 PM

#

that's how we do an hour with joe, we just ship him in his black box

thorny obsidian Aug 12, 2021, 5:46 PM

#

vale ibex devops is a black box

when are you going to officially join devops btw =P

vale ibex Aug 12, 2021, 5:46 PM

#

shrugR

patent pivot Aug 12, 2021, 5:46 PM

#

chris hi join my team?

vale ibex Aug 12, 2021, 5:47 PM

#

k

patent pivot Aug 12, 2021, 5:47 PM

#

ty

#

pleasure doing usinesss with you sir

vale ibex Aug 12, 2021, 5:47 PM

#

u 2

#

see you in 2 weeks for our 1 to 1

thorny obsidian Aug 12, 2021, 5:47 PM

#

yessss, now I can bother Chris when shit breaks

vale ibex Aug 12, 2021, 5:48 PM

#

as if you don't already

#

lmfao

patent pivot Aug 12, 2021, 5:48 PM

#

can you two see this https://prometheus.pythondiscord.com/graph?g0.expr=sum(node_disk_read_bytes_total) by (kubernetes_node)&g0.tab=0&g0.stacked=0&g0.show_exemplars=0&g0.range_input=1h

thorny obsidian Aug 12, 2021, 5:48 PM

#

Sometimes joe decides to "sleep" or "have a life" which is really rather rude. Now I can bother Chris and continue to not feel bad about it :D

vale ibex Aug 12, 2021, 5:48 PM

#

not without logging into github

patent pivot Aug 12, 2021, 5:48 PM

#

with logging in

thorny obsidian Aug 12, 2021, 5:48 PM

#

no access

patent pivot Aug 12, 2021, 5:48 PM

#

you'll be able to chriss because you're in the team now

#

wtf

#

.......

vale ibex Aug 12, 2021, 5:48 PM

#

I'm having problems

#

it needs my password

patent pivot Aug 12, 2021, 5:49 PM

#

oh wait. i didn't click save i didn't click save

vale ibex Aug 12, 2021, 5:49 PM

#

(I'm in btw

#

lol

patent pivot Aug 12, 2021, 5:49 PM

#

try now @thorny obsidian

thorny obsidian Aug 12, 2021, 5:49 PM

#

rooHacker I'm in

patent pivot Aug 12, 2021, 5:49 PM

#

they call me mr webscale

#

it's just a graph of disk reads

#

#

I'm doing alerts as code now so I don't have to deal with Grafana's hell

vale ibex Aug 12, 2021, 5:51 PM

#

patent pivot Aug 12, 2021, 5:51 PM

#

thanks chris

#

great to know gmail spam reports are used correctly

vale ibex Aug 12, 2021, 5:51 PM

#

lol

patent pivot Aug 12, 2021, 5:52 PM

#

fervent sage Aug 12, 2021, 5:53 PM

#

yes its in all your git commits

patent pivot Aug 12, 2021, 5:53 PM

#

yeah you tried to sign in lol

vale ibex Aug 12, 2021, 5:54 PM

#

arthur bow to me

#

oof

#

i fix btw @timid sentinel

radiant merlinBOT Aug 12, 2021, 5:55 PM

#

arthur ed [-GVhs] [-p string] [file]

Ed is the standard text editor.

fervent sage Aug 12, 2021, 5:55 PM

#

radiant merlin ``` arthur ed [-GVhs] [-p string] [file] Ed is the standard text editor. ```

lmao why the fuck is that a thing

radiant merlinBOT Aug 12, 2021, 5:55 PM

#

?

fervent sage Aug 12, 2021, 5:56 PM

#

arthur ed -GV -p "aaaaaa?" test.txt

radiant merlinBOT Aug 12, 2021, 5:56 PM

#

?

fervent sage Aug 12, 2021, 5:56 PM

#

understandable

#

have a great day you strange man

patent pivot Aug 12, 2021, 5:57 PM

#

Ed is the standard text editor.

#

I don't have any reference other than how kubectl does it

#

which just seems to be copying the jobspec from the cron and throwing it into a job

green oriole Aug 12, 2021, 5:59 PM

#

Time to buy an hour with Joe!

patent pivot Aug 12, 2021, 5:59 PM

#

lmfao

#

lol

#

no

green oriole Aug 12, 2021, 6:06 PM

#

I mean isn't one hour of training from devops daddy kind of makes you devops son

patent pivot Aug 12, 2021, 6:06 PM

#

lmfao

green oriole Aug 12, 2021, 6:08 PM

#

Also @patent pivot please rename <@&797752289771126784> to Kubernetes Daddy thank you Joe

patent pivot Aug 12, 2021, 6:09 PM

#

lol i intentionally avoided that bbecause then i get randos calling me it and I do a lil 🤨

green oriole Aug 12, 2021, 6:10 PM

#

Right

#

No, Chris warmed me

#

Let's move to ot 🥺

vale ibex Aug 12, 2021, 6:22 PM

#

@timid sentinel just FYI since you've already approved the PR. I've reworded the error from "Both members must have the lovefest role! You can get this by running the `{Client.prefix}lovefest sub` command." to ```
"This command can only be ran against members with the lovefest role! This role be can assigned by running {Client.prefix}lovefest sub in <#{Channels.community_bot_commands}>."

timid sentinel Aug 12, 2021, 6:23 PM

#

cool cool sounds good, do I need to press approve again for my review to count then?

vale ibex Aug 12, 2021, 6:23 PM

#

nah it's still good

timid sentinel Aug 12, 2021, 6:23 PM

#

idk how it works

#

ah cool

vale ibex Aug 12, 2021, 6:24 PM

#

Once you've approved the only way to remove the approval is if someone manually dismisses your review

#

We looked into automatically doing that if enough lines change, but don't think we turned it on

brisk brook Aug 12, 2021, 6:28 PM

#

vale ibex Once you've approved the only way to remove the approval is if someone manually ...

Or force push

green oriole Aug 12, 2021, 6:29 PM

#

vale ibex Once you've approved the only way to remove the approval is if someone manually ...

*or request changes

vale ibex Aug 12, 2021, 6:31 PM

#

brisk brook Or force push

I did force push?

#

that didn't remove the approval

vale ibex Aug 12, 2021, 6:31 PM

#

green oriole *or request changes

ok mr Akarys

green oriole Aug 12, 2021, 6:31 PM

#

abelok

vale ibex Aug 12, 2021, 6:32 PM

#

hotkey is proving useful

brisk brook Aug 12, 2021, 6:32 PM

#

vale ibex Aug 12, 2021, 6:32 PM

#

interesting

#

didn't do it for the one just now

green oriole Aug 12, 2021, 6:34 PM

#

Huh

#

I never seen that

fervent sage Aug 12, 2021, 7:51 PM

#

yes

green oriole Aug 12, 2021, 8:01 PM

#

!rule 69 42

stable mountainBOT Aug 12, 2021, 8:01 PM

#

:x: Invalid rule indices: 42, 69

green oriole Aug 12, 2021, 8:01 PM

#

Yeah, I guess

#

If you want to open a PR I won't stop you

timid sentinel Aug 12, 2021, 8:05 PM

#

Hm I think it's correct both ways, it's a list of invalid rule indices with one item

short snow Aug 12, 2021, 9:03 PM

#

don't expect someone to review it then

thorny obsidian Aug 12, 2021, 9:04 PM

#

this is going to be my only response

patent pivot Aug 12, 2021, 9:19 PM

#

✨ devops wins again
joe has added alerting
chugging in the wind ✨

#

#

lol

#

no promisses

#

I''ll put up manifests for this when i've written more alerts

#

no

#

lol

#

we are never having a "cleanup" PR like that again

#

it was a pretty awful experience for all involved

#

merge and reviewing

#

it was just not worth the effort whatsoever

#

yes, but not a flurry of 500 PRs lol

vocal wolf Aug 12, 2021, 9:35 PM

#

oh no not another cleanup

#

let's not do that

#

merge two branches and make a new PR?

thorny obsidian Aug 12, 2021, 9:38 PM

#

Again, I will refer you to the pins for our attitude on those mega "clean up" PRs

#

The grammar isn't such a huge deal and it'll be easier to fix as we naturally update/revisit those code portions

vocal wolf Aug 12, 2021, 9:45 PM

#

pypi belongs to the python bot because it's more of a utility for the language

gritty wind Aug 12, 2021, 10:24 PM

#

We work on https://forms.pydis.com

Python Discord Forms

Python Discord Forms is the surveying system for the Python Discord server.

#

Currently not open to external contributions, but the repos are open source under
python-discord/forms-frontend
python-discord/forms-backend

patent pivot Aug 12, 2021, 10:36 PM

#

okay i'm gonna push my alertmanager stuff

#

lol

gritty wind Aug 12, 2021, 10:36 PM

#

Soon™️

#

Not now though

patent pivot Aug 12, 2021, 10:37 PM

#

#

https://github.com/python-discord/kubernetes/pull/70

GitHub

Add AlertManager by jb3 · Pull Request #70 · python-discord/kuberne...

Add AlertManager
Add several alerts
Update Prometheus to point at Alertmanager

#

lol no i'm going to merge it now anyway

#

jut waiting for lint to run

#

okay

#

so

#

https://github.com/python-discord/kubernetes/blob/main/monitoring/alerts/alerts.d/cpu.yaml

GitHub

kubernetes/cpu.yaml at main · python-discord/kubernetes

Kubernetes manifests for Python Discord services. Contribute to python-discord/kubernetes development by creating an account on GitHub.

#

these are our alerts now

brisk brook Aug 12, 2021, 10:51 PM

#

gritty wind We work on https://forms.pydis.com

Please review my PR when you get the time to

gritty wind Aug 12, 2021, 10:58 PM

#

Yeah, it’s on my agenda for when I get my proper setup back

brisk brook Aug 12, 2021, 10:58 PM

#

Thank you 😅

patent pivot Aug 12, 2021, 11:01 PM

#

off topic

#

i'm joking i'm joking thank you thankk you

celest charm Aug 12, 2021, 11:42 PM

#

short snow Aug 13, 2021, 3:44 AM

#

https://github.com/python-discord/bot/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+author%3AShivansh-007 Would love to get some reviews thanks 😄

#

and https://github.com/python-discord/sir-lancebot/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+author%3AShivansh-007

#

@vocal wolf could you add the up for grabs for the wtf python pr, re:https://github.com/python-discord/sir-lancebot/pull/605#issuecomment-894634023

vocal wolf Aug 13, 2021, 3:46 AM

#

short snow <@!196664644113268736> could you add the up for grabs for the wtf python pr, re:...

ye

short snow Aug 13, 2021, 3:46 AM

#

cool thanks

vocal wolf Aug 13, 2021, 3:46 AM

#

np

tawdry vapor Aug 13, 2021, 3:50 AM

#

@vocal wolf @vale ibex Sorry for picking on you guys but I've noticed at least you two have used the backend area tag incorrectly on the bot e.g. https://github.com/python-discord/bot/pull/1661 and https://github.com/python-discord/bot/pull/1642

vocal wolf Aug 13, 2021, 3:52 AM

#

I thought the PR that I labeled would be internal functionality since there's a difference between if the user could or could not get DM'd

#

But I can also see how that may also not relate to internal functionality, since it's surface-level type stuff.

tawdry vapor Aug 13, 2021, 3:53 AM

#

Yeah it's technically internal, but by such a broad definition, we'd end up using that tag everywhere and it wouldn't have much meaning. It's not a particularly useful distinction here.

vocal wolf Aug 13, 2021, 3:53 AM

#

Agreed

tawdry vapor Aug 13, 2021, 3:54 AM

#

I like to use it in a more general sense of pertaining to something that's not user-facing at all or that is a very generic utility used by many things.

#

With a few exceptions, like I think the sync stuff is backend and we have some commands to control it, but that's not the main interface for it.

vocal wolf Aug 13, 2021, 3:54 AM

#

It wouldn't be frontend either, more just help channels and that's it

tawdry vapor Aug 13, 2021, 3:55 AM

#

I have mixed feelings about the frontend tag since it's kind of arbitrary what qualifies

vocal wolf Aug 13, 2021, 3:55 AM

#

I think it's usually for editing of messages/embeds, that's what I've mostly saw it for

tawdry vapor Aug 13, 2021, 3:56 AM

#

Same

vocal wolf Aug 13, 2021, 3:56 AM

#

not as in the bot editing an embed, but having a format of an embed be modified in the code so it continues to look different

tawdry vapor Aug 13, 2021, 3:57 AM

#

While you're here

#

Should I transfer all the tag issues to meta, since we agreed on that?

vocal wolf Aug 13, 2021, 3:57 AM

#

Yep, I don't see why not

tawdry vapor Aug 13, 2021, 3:59 AM

#

In retrospect this is much nicer than it first seems

#

Cause issues won't get lost in the 100s of bot issues

vocal wolf Aug 13, 2021, 4:00 AM

#

indeedingly

tawdry vapor Aug 13, 2021, 4:01 AM

#

Should something like this also be moved? https://github.com/python-discord/bot/issues/1703

vocal wolf Aug 13, 2021, 4:02 AM

#

Yes

#

@tough imp If you haven't seen the ping, bot#836 is ready for your review.

dusky shoreBOT Aug 13, 2021, 4:05 AM

#

GitHub

PROpen Tags cog unit tests and tags cog fixes

tawdry vapor Aug 13, 2021, 4:58 AM

#

@vocal wolf How do you think we should structure the issue templates considering a request can be to either add, remove, or revise something?

#

I think if there's a separate template for each action then it would be overwhelming

#

But unfortunately we cannot automatically add labels without separating them (https://github.com/github/feedback/discussions/4266).

vocal wolf Aug 13, 2021, 5:01 AM

#

tawdry vapor <@!196664644113268736> How do you think we should structure the issue templates ...

I'm going to have to think about this more

tawdry vapor Aug 13, 2021, 5:01 AM

#

Okay, for now I set up labels for what I think seems reasonable https://github.com/python-discord/meta/labels

#

Though I was thinking of breaking off a new "policy" label from "area: features"

#

I'm just gonna do that before I forget. Not like we have any open issues for it anyway.

surreal veldt Aug 13, 2021, 6:24 AM

#

Anyone on bo#447 ? The most recent comment

#

bot#447 *

dusky shoreBOT Aug 13, 2021, 6:24 AM

#

GitHub

IssueOpen Support partial searches for documentation

green oriole Aug 13, 2021, 6:35 AM

#

That sounds a bit like spring cleanup haha. I'll discuss it with the rest of the core devs and get back to you!

surreal veldt Aug 13, 2021, 7:20 AM

#

For Python bot, how is the documentations for the docs command stored? It is like there is a column for name and then content?

#

meaning if a symobl were to be indexed to one, would it just give the name and if it were to be indexed to two it would get the content? or how could it be split like that

viscid coral Aug 13, 2021, 7:26 AM

#

Maybe check the source?

#

!source docs

stable mountainBOT Aug 13, 2021, 7:26 AM

#

Command: docs

Look up documentation for Python symbols.

Source Code

Go to GitHub

surreal veldt Aug 13, 2021, 7:27 AM

#

uhhhh

#

i can't lol

#

on mobile

steel isle Aug 13, 2021, 7:33 AM

#

!d

surreal veldt Aug 13, 2021, 7:37 AM

#

okay so from what i saw,

self.base_urls
``` this is for the URL links of the docs

#

And py self.doc_symbols is for the content, is is correct?

steel isle Aug 13, 2021, 7:38 AM

#

where is DocCog Invoked

brazen charm Aug 13, 2021, 7:39 AM

#

you should only need self.doc_symbols for the parial search, it's a mapping of the names used to fetch the docs to their urls

green oriole Aug 13, 2021, 8:38 AM

#

green oriole That sounds a bit like spring cleanup haha. I'll discuss it with the rest of the...

Seems like Joe already rejected it, so nope

steel isle Aug 13, 2021, 8:41 AM

#

green oriole Seems like Joe already rejected it, so nope

you asked him to do a chore on his birthday lol

green oriole Aug 13, 2021, 8:44 AM

#

No he rejected that yesterday

steel isle Aug 13, 2021, 8:44 AM

#

you asked him to do a chore on the eve of his birthday lol

green oriole Aug 13, 2021, 8:48 AM

#

I didn't ask him anything

#

okay maybe I did

#

But still

patent pivot Aug 13, 2021, 9:11 AM

#

lol

surreal veldt Aug 13, 2021, 9:15 AM

#

can i ask a dpy question here regarding bot#477

dusky shoreBOT Aug 13, 2021, 9:15 AM

#

GitHub

IssueClosed Unhandled Docs exception

surreal veldt Aug 13, 2021, 9:16 AM

#

Wait sorry, bot#447

dusky shoreBOT Aug 13, 2021, 9:16 AM

#

GitHub

IssueOpen Support partial searches for documentation

fervent sage Aug 13, 2021, 9:16 AM

#

surreal veldt can i ask a dpy question here regarding bot#477

go for it

surreal veldt Aug 13, 2021, 9:18 AM

#

@bot.command()
async def py(ctx):
    buttons = {}
    for i in range(1, 3):
        buttons[f"{i}\N{COMBINING ENCLOSING KEYCAP}"] = i
    the_previous_page_number = 1
    the_current_page_number = 2
    embed = discord.Embed(title=f"Documentations found", description="", colour=discord.Colour.blurple())
    msg = await ctx.send(embed=embed)
    for button in buttons:
        await msg.add_reaction(button)
    while True:
        if the_current_page_number != the_previous_page_number:
            embed.title = f"Page {the_current_page_number}"
            embed.description=""
            #await msg.edit(embed=embed)
        try:
            reaction, user = await bot.wait_for("reaction_add", check=lambda reaction, user: user == ctx.author and reaction.emoji in buttons, timeout=10.0)
            await msg.edit(embed=embed)
        except asyncio.TimeoutError:
            return
        else:
            the_previous_page_number = the_current_page_number
            await msg.remove_reaction(reaction.emoji, ctx.author)
            the_current_page_number = buttons[reaction.emoji]

I have this right now, when I run the command it gives the embed and on the first reaction, it switches pages and changes the number but if i react the second time, i need to press the reaction twice for it to switch for some reason which I cannot figure out

fervent sage Aug 13, 2021, 9:19 AM

#

Hm, i'm sure there's already something in the bot that lets you do pagination

surreal veldt Aug 13, 2021, 9:19 AM

#

only the first one switches with one reaction press, and the 2nd 3rd forth etc take more than once

fervent sage Aug 13, 2021, 9:19 AM

#

ill see if i can find it

#

https://github.com/python-discord/bot/blob/main/bot/pagination.py

surreal veldt Aug 13, 2021, 9:21 AM

#

that seems long lol

#

and yeah that's one thing, in the one you sent

if reaction.emoji == LAST_EMOJI:

it checks each one individually where as when compared to mine i do not check each reaction indivudally

#

example

fervent sage Aug 13, 2021, 9:23 AM

#

well anyways, you should be importing that paginator for consistency and code reuse

surreal veldt Aug 13, 2021, 9:24 AM

#

alright

static canyon Aug 13, 2021, 9:26 AM

#

Can I just confirm that I responded to the review comments correctly here? I'm not sure why it created a separate review from me without the context of Mark's messages as well as the responses https://github.com/python-discord/bot/pull/1742

green oriole Aug 13, 2021, 9:30 AM

#

static canyon Can I just confirm that I responded to the review comments correctly here? I'm n...

Commentating on a review will create an embed saying you reviewed the PR, that's normal. It is how the github api works.

static canyon Aug 13, 2021, 9:30 AM

#

Right okay, thanks 👍

green oriole Aug 13, 2021, 9:31 AM

#

I actually blame the spell checker here, but thanks

fervent sage Aug 13, 2021, 9:40 AM

#

yooo github is gonna be secure-er

#

tbh i dont understand why people still use password auth for pushing with the convenience of having an rsa key

vale ibex Aug 13, 2021, 9:43 AM

#

 {% if thing %}
 ...
 {% elif other_thing %}
 ...
 {% else %}
 ...
 {% endif %}

vale ibex Aug 13, 2021, 9:44 AM

#

fervent sage tbh i dont understand why people still use password auth for pushing with the co...

yea lol, so much easier with ssh

short snow Aug 13, 2021, 9:49 AM

#

use gh cli for auth, simplest

#

and make git import the secrets from it

vale ibex Aug 13, 2021, 9:53 AM

#

I imagine so, since the if elif block evaluates before sending

surreal veldt Aug 13, 2021, 9:56 AM

#

fervent sage well anyways, you should be importing that paginator for consistency and code re...

sorry but do you know if menus is better than this?

vale ibex Aug 13, 2021, 9:56 AM

#

buttons would be preferred over emojis, yes

#

They just haven't been released yet

surreal veldt Aug 13, 2021, 9:57 AM

#

yeah i would, but v2 isn't stable yet

#

would buttons be implemented to @stable mountain in the future?

#

alright i guess i'll stick with menus instead of paginator for now

#

Should i just wait for buttons and then start development of bot#447 pikathink

dusky shoreBOT Aug 13, 2021, 10:01 AM

#

GitHub

IssueOpen Support partial searches for documentation

vale ibex Aug 13, 2021, 10:01 AM

#

you should implement it using the paginatior in the bot

#

when we update the bot to use buttons, we will change the paginator

#

So it'll just work

surreal veldt Aug 13, 2021, 10:03 AM

#

vale ibex you should implement it using the paginatior in the bot

You suggest pagination over menus?

vale ibex Aug 13, 2021, 10:03 AM

#

when you say menus what are you referring to?

#

context menus or buttons?

#

or something else?

surreal veldt Aug 13, 2021, 10:03 AM

#

https://github.com/Rapptz/discord-ext-menus

GitHub

GitHub - Rapptz/discord-ext-menus

Contribute to Rapptz/discord-ext-menus development by creating an account on GitHub.

vale ibex Aug 13, 2021, 10:04 AM

#

oh right, this

#

as far as I know on the menus ext, our paginator implements it

#

@fervent sage have you had interaction with this menu ext?

#

would you agree that our paginator does the same thing?

fervent sage Aug 13, 2021, 10:05 AM

#

yep

vale ibex Aug 13, 2021, 10:05 AM

#

Cool

#

So yea, @surreal veldt use our paginator class

#

it does the same thing, and will eventually be updated to use buttons (which are better than emojis)

surreal veldt Aug 13, 2021, 10:06 AM

#

Could I have the github source please

fervent sage Aug 13, 2021, 10:06 AM

#

fervent sage <https://github.com/python-discord/bot/blob/main/bot/pagination.py>

here

surreal veldt Aug 13, 2021, 10:06 AM

#

oh that's what you use, okay thank you

vale ibex Aug 13, 2021, 10:06 AM

#

yea

#

check out this cog for a simple implementation

#

!src sf

stable mountainBOT Aug 13, 2021, 10:06 AM

#

Command: snowflake

Get Discord snowflake creation time.

Source Code

Go to GitHub

short snow Aug 13, 2021, 10:07 AM

#

the pagination class is itself well dcoumented

surreal veldt Aug 13, 2021, 10:12 AM

#

okay welp that is a long pagination

short snow Aug 13, 2021, 10:12 AM

#

itertools.grouper

#

more itertools.grouper*

surreal veldt Aug 13, 2021, 10:13 AM

#

vale ibex So yea, <@!751814647346102303> use our paginator class

you want me to implement pythons class to my bot? because i'm going to be needing to test it and then there is going to be tons of code i will need to add

short snow Aug 13, 2021, 10:14 AM

#

did u go through the contribution guide? it says how to setup the bot (forking and cloning)

surreal veldt Aug 13, 2021, 10:15 AM

#

oh, no I haven't gone through it yet

short snow Aug 13, 2021, 10:16 AM

#

Just go through it once, would def help you out with working with bot

#

You would need site for working with docs command, so either setup the site locally or via docker

#

i had say docker since it is simpler and faster

surreal veldt Aug 13, 2021, 10:17 AM

#

Yeah....im not familiar with github tbh lol

vale ibex Aug 13, 2021, 10:19 AM

#

surreal veldt you want me to implement pythons class to my bot? because i'm going to be needin...

What do you mean? Are you not writing this in our bot?

short snow Aug 13, 2021, 10:19 AM

#

he was copying bits of the bot code into his and then running it if i understand correctly

vale ibex Aug 13, 2021, 10:19 AM

#

that's not gonna work very well lol

surreal veldt Aug 13, 2021, 10:19 AM

#

Well i was thinking to test it first

vale ibex Aug 13, 2021, 10:19 AM

#

I'd suggest you follow our contributing guide and get the bot setup

#

we can help you if you have any issues while doing so

surreal veldt Aug 13, 2021, 10:20 AM

#

Okay, I'll take a look at the guide when i have time

fervent sage Aug 13, 2021, 10:27 AM

#

well, assign sorted(...) to a variable, you use it 4 times

short snow Aug 13, 2021, 10:27 AM

#

are you splitting it into two?

fervent sage Aug 13, 2021, 10:27 AM

#

can you paste it here :P

vale ibex Aug 13, 2021, 10:28 AM

#

why do you need to sort the list when calcing the length?

#

yea, that looks better

#

you could also make a half_length var too

#

which does len(..)//2

short snow Aug 13, 2021, 10:30 AM

#

topics[::2], topics[1::2]

#

alternative

green oriole Aug 13, 2021, 10:30 AM

#

Do you have a GPG key at least, with gnupg started ?

short snow Aug 13, 2021, 10:31 AM

#

you need to add it to git also

#

see .gitconfig

#

do you see it

#

nope

#

not a secret

#

it was short

#

and secrets are stored in gitconfig

#

as far as i know

green oriole Aug 13, 2021, 10:33 AM

#

GPG is totally different from SSH

#

What are you trying to do?

#

SSH isn't for signing your commits

#

It is used to access the Git server

#

Try echo hello | gpg --sign

#

lol, is your shell broken

#

What if you try to start bash, do you get any warning?

patent pivot Aug 13, 2021, 11:10 AM

#

welcome Chris and Volcyy to devops team epic win

fervent sage Aug 13, 2021, 11:12 AM

#

joe teach me devops KEKW

#

oh that remind me im gonna set up minikube on a couple old PCs at my house and play with kubernetes

patent pivot Aug 13, 2021, 11:13 AM

#

hell yeah

cold moon Aug 13, 2021, 11:15 AM

#

Joe you should make paid DevOps course.

dim pelican Aug 13, 2021, 11:32 AM

#

I bookmarked this convo thread from Chris yesterday for this exact reason lol (I need to double check my SSH login set up too)

https://discordapp.com/channels/267624335836053506/635950537262759947/875068596273963118

vale ibex Aug 13, 2021, 11:46 AM

#

The blog post in the announcement explains it better than I did

#

it has photos and everything

dim pelican Aug 13, 2021, 11:50 AM

#

https://discordapp.com/channels/267624335836053506/765137969753096202/875674705611350036
For those like me who like to bookmark things

surreal veldt Aug 13, 2021, 11:50 AM

#

uh could someone help with "getting the bot setup" to write some code for it, I'm not really familiar with github and I can't seem to find this on the contributin guide

dim pelican Aug 13, 2021, 11:52 AM

#

One sec, I started sir-lancebot last week for the first time as well

#

For bot: https://pythondiscord.com/pages/guides/pydis-guides/contributing/bot/

For Sir-Lancebot:
https://pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/

For Site:
https://pythondiscord.com/pages/guides/pydis-guides/contributing/site/

surreal veldt Aug 13, 2021, 11:54 AM

#

oh oops i was apparently reading the wrong one Sadge

#

okay i forked it and for the development environment i'm kinda lost on what to do, I'm using visual studio code and have copied the HTTPS link

brazen charm Aug 13, 2021, 12:02 PM

#

do you have git installed?

surreal veldt Aug 13, 2021, 12:05 PM

#

yeah i just did that, also it asked Launch git bash, should this be selected?

brazen charm Aug 13, 2021, 12:09 PM

#

any of your terminals should work for the clone if you added git to path

surreal veldt Aug 13, 2021, 12:48 PM

#

I download git and then do git clone (https link) right?

fervent sage Aug 13, 2021, 12:50 PM

#

since github is apparently removing password auth for that kinda stuff, I'd set up ssh and then you clone with git clone git@github.com:author/repo.git

#

(ik public repos dont need auth to http clone, but good practice)

surreal veldt Aug 13, 2021, 12:51 PM

#

so now using https link is bad?

brazen charm Aug 13, 2021, 12:51 PM

#

you can use it

surreal veldt Aug 13, 2021, 12:52 PM

#

surreal veldt I download `git` and then do `git clone (https link)` right?

like this?

brazen charm Aug 13, 2021, 12:52 PM

#

yes

surreal veldt Aug 13, 2021, 12:59 PM

#

so once i clone it, i can open it on visual studio code?

#

okay nvm i got it

#

okay i'm a little confused i cloned the bot and opened it on visual studio code but there are going to be import errors ofc, and not so sure what to do now

gritty wind Aug 13, 2021, 1:41 PM

#

The getting started guide should walk you through setting up dependencies using poetry

#

You’ve done the “fork the project step”, keep going through the rest

#

https://pythondiscord.com/pages/guides/pydis-guides/contributing/bot/

#

(You’ll seriously struggle to get this done if you don’t follow the guide)

surreal veldt Aug 13, 2021, 2:23 PM

#

could someone help with the "install dependencies" part please (I'm not using pycharm)

short snow Aug 13, 2021, 2:26 PM

#

just do poetry install in your shell

surreal veldt Aug 13, 2021, 2:43 PM

#

the part i don't get is

Make sure you are in the root project directory. This directory will always have a file titled README.md.
Install project and development dependencies. Remember to also set up pre-commit hooks to ensure your pushed commits will never fail linting.

gritty wind Aug 13, 2021, 2:45 PM

#

The commands below that text are what you need to run basically

#

poetry install will do most of the work

#

It will also create a new virtual environment for your project

tough imp Aug 13, 2021, 2:46 PM

#

vocal wolf <@!144912469071101952> If you haven't seen the ping, bot#836 is ready for your r...

I'll try to take a look though I prob won't be available for a more involved review until late august or early sept

#

oh it's the tags tests

#

ye I'll try

clever wraith Aug 13, 2021, 4:32 PM

#

add a translator in python bot 🤔

gritty wind Aug 13, 2021, 4:34 PM

#

What do you have in mind with that?

celest charm Aug 13, 2021, 4:42 PM

#

Who even uses password auth, isn't it, like, super inconvenient?

#

it also means you don't have 2FA on your account, right?

green oriole Aug 13, 2021, 4:42 PM

#

It doesn't work with 2FA, yes

#

You can use a PAT instead of your password though, and still use http auth

molten perch Aug 13, 2021, 5:47 PM

#

Hey, is there a scenario when the jump_url does not exists? It seems a strange thing to check for whereas the code does not check for the other elements of the reminder dict.
https://github.com/python-discord/bot/blob/main/bot/exts/utils/reminders.py#L186
And https://github.com/python-discord/bot/blob/main/bot/exts/utils/reminders.py#L197

stable mountainBOT Aug 13, 2021, 5:47 PM

#

bot/exts/utils/reminders.py line 186

if reminder.get("jump_url"):  # keep backward compatibility```
`bot/exts/utils/reminders.py` line 197
```py
mentionable.mention for mentionable in self.get_mentionables(reminder["mentions"])```

vale ibex Aug 13, 2021, 5:54 PM

#

Not in the current db at least

#

it might have been backwards compatibility with an old version of site, that didn't return a jump_url, or for the period after that key was added

molten perch Aug 13, 2021, 5:56 PM

#

So, it wouldn't be a problem if I removed it, would it?

vale ibex Aug 13, 2021, 5:57 PM

#

I don't think so

#

@green oriole is on the git blame, so maybe he can remember 2 years ago as to why it was needed

molten perch Aug 13, 2021, 5:58 PM

#

Alright, I can somehow keep it in but it wouldn't be so consistent, I'm trying to reply to the original message instead of using a jump url.

vale ibex Aug 13, 2021, 5:59 PM

#

I don't think it would be an issue

#

It sounds like your change should include a change to the site api

#

probably add a new column called 'original message id' or similar

#

to store the message to reply to

celest charm Aug 13, 2021, 6:03 PM

#

green oriole You can use a PAT instead of your password though, and still use http auth

pat akarys emoji but I don't have nitro

molten perch Aug 13, 2021, 6:15 PM

#

vale ibex It sounds like your change should include a change to the site api

Yes, but for now, I settled with splitting the URL, and we'll change it later.
The reason I think it's better to have the URL although is because if something goes wrong with getting a partial message, we can always fall back to the good old jump url.

#

bot#1741

dusky shoreBOT Aug 13, 2021, 6:15 PM

#

GitHub

IssueOpen Reply to the original message where the reminder was invoked instead of using a jump url

vale ibex Aug 13, 2021, 6:16 PM

#

sounds good 👍

green oriole Aug 13, 2021, 6:29 PM

#

@vale ibex @molten perch yes, we still had this if case since when we added jump links we still had some reminders in the DB that didn't had any url.

I guess sir @vale ibex can now use his newly found power to check if we still have such a reminder :P

#

SELECT * FROM site_reminders WHERE jump_url = NULL or something

vale ibex Aug 13, 2021, 6:33 PM

#

I did lol

#

Look at the screenshot

green oriole Aug 13, 2021, 6:55 PM

#

Oh nice

#

Then we can safely remove it

molten perch Aug 13, 2021, 6:57 PM

#

Alright, then. I’ll remove it then, and push a pr 🙂

viscid coral Aug 13, 2021, 6:58 PM

#

@molten perch If you want me to review I am happy to help!

green oriole Aug 13, 2021, 8:39 PM

#

molten perch Alright, then. I’ll remove it then, and push a pr 🙂

Just for removing this if branch?

molten perch Aug 13, 2021, 8:39 PM

#

Yes.

#

I guess? 😂

#

It should work just fine without it.

green oriole Aug 13, 2021, 8:40 PM

#

I don't think we should be opening PRs for little stuff like that

#

Sure this is legacy code but it doesn't hurt anything

#

We can remove it when we have a PR touching the reminder code

molten perch Aug 13, 2021, 8:41 PM

#

Oh, It's a part of an issue.

#

Not, just that.

thorny obsidian Aug 13, 2021, 8:41 PM

#

Isn't the context of this is that it's part of an existing issue/PR for a feature?

molten perch Aug 13, 2021, 8:42 PM

#

dusky shore

Yes, it is! 🙂

thorny obsidian Aug 13, 2021, 8:42 PM

#

If it's part of a feature you're working on you can just include it in your PR for said feature. The commit can be used to describe the change being made. No need for a full blown separate PR

molten perch Aug 13, 2021, 8:43 PM

#

Yeah, I never wanted to open a separate PR in the first place 😄

green oriole Aug 13, 2021, 8:43 PM

#

Yes, let's combine it in one PR

#

Cool

brazen charm Aug 13, 2021, 8:44 PM

#

I have been thinking reminders could be allowed in all channels with the bot only sending the remainders in #bot-commands (if invoked from a non mod channel) which would be incompatible with the reply feature. Any thoughts on that or should I open an issue?

green oriole Aug 13, 2021, 8:44 PM

#

Please do open an issue! We'll discuss this, but I think it should be fine

vale ibex Aug 13, 2021, 8:46 PM

#

yea, I'd like that

#

sorta messes with the "reply to" idea slightly, but can be worked around

fallen patrol Aug 13, 2021, 8:47 PM

#

@molten perch is there a pr for the first change yet?

molten perch Aug 13, 2021, 8:48 PM

#

I'm just about to push it.

fallen patrol Aug 13, 2021, 8:48 PM

#

oh okay

#

cool

molten perch Aug 13, 2021, 8:48 PM

#

I'll open a draft then.

#

And then we can figure something out.

vale ibex Aug 13, 2021, 8:49 PM

#

nah no need for draft

#

we can add to your logic after it's merged

fallen patrol Aug 13, 2021, 8:49 PM

#

or review and add to it then lol

#

basically draft means that you are not done adding to your code

#

if its ready for review, don't draft it 😄

molten perch Aug 13, 2021, 8:50 PM

#

Yeah, I thought we were gonna modify it on the way once we discussed the details.

fallen patrol Aug 13, 2021, 8:50 PM

#

in that case I would still mark it ready for review

viscid coral Aug 13, 2021, 9:01 PM

#

brazen charm I have been thinking reminders could be allowed in all channels with the bot onl...

So you can invoke the remind command from anywhere and the output will be redirected to #bot-commands ? Than we shouldn't try to do reply to a message when a reminder is done really

molten perch Aug 13, 2021, 9:02 PM

#

Yeah, I'm not sure how we could find a workaround

#

I'll push my pr anways.

viscid coral Aug 13, 2021, 9:03 PM

#

We can find a workaround but not sure how good that would be

molten perch Aug 13, 2021, 9:04 PM

#

Well, I don't think so? Like replying: "Hey.. your reminder is in #bot-commands " That wouldn't look so good.

viscid coral Aug 13, 2021, 9:04 PM

#

Yeah, I think we should only restrict it to #bot-commands

#

I mean, it already is, not even to #sir-lancebot-playground

molten perch Aug 13, 2021, 9:05 PM

#

If it's more convenient to not restrict it to #bot-commands then we can trash this reply idea, it worked just fine before.

viscid coral Aug 13, 2021, 9:06 PM

#

Yeah but I also don't really get why to enable it in every channel

#

The reminder command does not seem so related to Python anyways

#

Why is it not in @dusky shore really?

tawdry vapor Aug 13, 2021, 9:13 PM

#

brazen charm I have been thinking reminders could be allowed in all channels with the bot onl...

If this suggestion goes through, it could still use a reply if the output is in the same channel (which will mostly be for staff then)

molten perch Aug 13, 2021, 9:15 PM

#

My solution would work perfectly fine, if the bot fails to reply it'll fall back to use jump_url and send it to whichever channel.

vocal prairie Aug 13, 2021, 9:22 PM

#

Bulma (or it's extensions) don't offer a way to make a modal, correct? If that's needed for the site, will we have to implement our own?

green oriole Aug 13, 2021, 9:23 PM

#

There is a modal class!

vocal prairie Aug 13, 2021, 9:23 PM

#

There is? Oh, I must have missed that, I'll take a look

green oriole Aug 13, 2021, 9:23 PM

#

https://bulma.io/documentation/components/modal/

Modal

Advanced multi-part components with lots of possibilities

vocal prairie Aug 13, 2021, 9:24 PM

#

tyty

surreal veldt Aug 13, 2021, 9:34 PM

#

uh regarding bot#447 i wanted to work on it, but i honestly don't have time for it now...

dusky shoreBOT Aug 13, 2021, 9:34 PM

#

GitHub

IssueOpen Support partial searches for documentation

viscid coral Aug 13, 2021, 9:37 PM

#

Why does the remind command in @stable mountain and not @dusky shore instead?

brazen charm Aug 13, 2021, 9:38 PM

#

it has to interact with the api

#

and I don't think it really suits lancebot anyway

viscid coral Aug 13, 2021, 9:38 PM

#

How does it suit Python bot

#

Python is for moderation and python-related commands, while lancebot is for fun commands right?

#

And remind command is a fun command which is not related to Python

green oriole Aug 13, 2021, 9:39 PM

#

I would say it is part of our core features

#

We use remind internally quite a lot

vocal prairie Aug 13, 2021, 9:40 PM

#

surreal veldt uh regarding bot#447 i wanted to work on it, but i honestly don't have time for ...

Feel free to comment there, and a staff member can unassign you

viscid coral Aug 13, 2021, 9:41 PM

#

green oriole We use remind internally quite a lot

For core developers and staff it might be helpful for moderation purposes, but for over 230,000 members it's a fun command really

green oriole Aug 13, 2021, 9:41 PM

#

No, I don't think it is

#

If all of our reminders were dropped, it would suck for our internal organization

thorny obsidian Aug 13, 2021, 9:42 PM

#

I think reminders is fine where it is

molten perch Aug 13, 2021, 9:50 PM

#

I managed to misspell "reminders", the thing that I'd been the most afraid of. lemon_sentimental

fallen patrol Aug 14, 2021, 12:23 AM

#

molten perch I managed to misspell "reminders", the thing that I'd been the most afraid of.<:...

I misspelled an important werd when I made a pull request to psf/black so don't be too hard on yourself

green oriole Aug 14, 2021, 3:21 PM

#

Cyan is used internally iirc

celest charm Aug 14, 2021, 5:04 PM

#

@dim pelican Just a tip: when writing commits, don't include line numbers and other stuff seen in the diff into the name. Git commits are named for people reading them as a list, so they should say something like "add an option to order extra sugar in a coffee order"

sinful knot Aug 14, 2021, 6:45 PM

#

How long does it usually take for a PR to get reviewed?

fervent sage Aug 14, 2021, 6:47 PM

#

sinful knot How long does it usually take for a PR to get reviewed?

not too long, which pr?

brazen charm Aug 14, 2021, 6:47 PM

#

really depends on the pr, don't expect immediate reviews though

sinful knot Aug 14, 2021, 6:47 PM

#

bot#1725

dusky shoreBOT Aug 14, 2021, 6:47 PM

#

GitHub

PROpen added escape markdown in PythonNews

sinful knot Aug 14, 2021, 6:48 PM

#

Nothing much

sinful knot Aug 14, 2021, 7:16 PM

#

Ping me if you reply

brisk brook Aug 14, 2021, 8:27 PM

#

sinful knot bot#1725

Ah that one, personally I'll just have to test it before continuing with approving it.

To make sure the regex works correctly and it is not failing to escape correctly.

sinful knot Aug 14, 2021, 8:30 PM

#

thanks as I said in the pr this is my first one so I just don't know how the whole system works

molten perch Aug 14, 2021, 8:40 PM

#

Hey! Sorry, but can somebody take a look at that PR? sir-lancebot#778
Two issues were put on halt, because they involved modifications in that Cog.

dusky shoreBOT Aug 14, 2021, 8:40 PM

#

GitHub

PROpen Merge automatic issue linking into the github cog

lunar hull Aug 14, 2021, 10:17 PM

#

Hello, I'm new here and would like to get involved in contributing. Any recommendation on where to get started / any projects that would be good for someone new?

vale ibex Aug 14, 2021, 10:18 PM

#

https://pythondiscord.com/pages/contributing/ should cover it!

Python Discord - Contributing

A guide to contributing to our open source projects.

lunar hull Aug 14, 2021, 10:18 PM

#

perfect, thanks!

vale ibex Aug 14, 2021, 10:18 PM

#

It should have all of the information you need

#

Check out the issues on the repos if you're looking for things to do 😄

molten perch Aug 14, 2021, 11:03 PM

#

Hey, does this issue (site#369) still persist? I just want to make sure, I don't know whether issues can "expire", or not! 🙂

dusky shoreBOT Aug 14, 2021, 11:03 PM

#

GitHub

IssueOpen User's role field needs to have a cascade delete

gritty wind Aug 14, 2021, 11:26 PM

#

They don’t have a hard expiration date

#

Though they may become irrelevant or stale

molten perch Aug 14, 2021, 11:28 PM

#

This one in particular does not seem to be solved, though.

gritty wind Aug 14, 2021, 11:30 PM

#

Perhaps if a good solution exists, it could be added. If it’s going to take too much effort, might make sense to save it for the rewrite

molten perch Aug 14, 2021, 11:33 PM

#

You mean the FastAPI implementation of the current API?

gritty wind Aug 14, 2021, 11:38 PM

#

Yeah

molten perch Aug 14, 2021, 11:44 PM

#

Oh, well. I think it might take some time, I believe I might have an easy solution for that issue! 😄

short snow Aug 15, 2021, 4:23 AM

#

why no participation in hacktoberfest lemon_pensive

thorny obsidian Aug 15, 2021, 4:31 AM

#

#dev-branding message

short snow Aug 15, 2021, 4:32 AM

#

Oh thanks

short snow Aug 15, 2021, 4:35 PM

#

@green oriole yeah it is waiting for a re-review.

green oriole Aug 15, 2021, 4:35 PM

#

Cool, thanks!

compact veldt Aug 15, 2021, 5:06 PM

#

I have had an idea of implementing an optional monkey-patch on stdin to allow standard input to work inside of snekbox. Giving it a new stdin argument.

Thoughts on if this would be a good addition to snekbox? It could allow for the !eval command to have an optional input.

green oriole Aug 15, 2021, 5:08 PM

#

I think it would be a good addition, but I'm sure how we can have a good UI with !eval. I feel like patching sys.stdin isn't an issue

compact veldt Aug 15, 2021, 5:10 PM

#

green oriole I think it would be a good addition, but I'm sure how we can have a good UI with...

Im also thinking of making the patch only apply if stdin is used. So we dont start making unexpected errors for those who dont explicitly use it.

#

Not 100% how i would do that yet. I have the stdin patch already made, i just need to figure out how it can be added to snekbox.

tawdry vapor Aug 15, 2021, 5:16 PM

#

Thoughts on if this would be a good addition to snekbox?
What are yours? What are your use cases for such feature?

compact veldt Aug 15, 2021, 5:19 PM

#

Primarily the possibility of allowing !eval in the python discord bot to take in optional input. This can be a great feature as you no longer have to avoid using input() in code examples. My current idea of how that could look would be:

!eval "Input one" "Input two" '''py ... '''

But i dont know what the best way that could be implemented for the least amount of misunderstanding.

brazen charm Aug 15, 2021, 5:20 PM

#

I can't really think of a good UX for it and you can always patch the stdin in the code passed to eval if input is required

green oriole Aug 15, 2021, 5:21 PM

#

compact veldt Not 100% how i would do that yet. I have the stdin patch already made, i just ne...

If we do that we would be piping stdin when creating the process

compact veldt Aug 15, 2021, 5:21 PM

#

brazen charm I can't really think of a good UX for it and you can always patch the stdin in t...

Yes. That is possible. But it can be very confusing if i try to show an example to someone, and i add a bunch of monkey patching code into the example.

compact veldt Aug 15, 2021, 5:23 PM

#

green oriole If we do that we would be piping stdin when creating the process

My current solution is a custom StringIO object. That gets set to builtins.stdin

#

But im not sure how we could set that custom StringIO object to stdin in snekbox. Or if thats the best way.

#

!e ```py
import io
import sys

class PrintingStringIO(io.StringIO):
def readline(self, size=None):
line = super(PrintingStringIO, self).readline(size)
print(line, end="")
return line

sys.stdin, _stdin = PrintingStringIO("Sofi\n"), sys.stdin

print("Your name is:", input("Whats your name? "))
```

stable mountainBOT Aug 15, 2021, 5:25 PM

#

@compact veldt :white_check_mark: Your eval job has completed with return code 0.

001 | Whats your name? Sofi
002 | Your name is: Sofi

compact veldt Aug 15, 2021, 5:26 PM

#

This is my current proof of concept.

#

Prints the stdin to where its expected to be seen if you ran the code yourself.

tawdry vapor Aug 15, 2021, 5:28 PM

#

I think it makes sense to add stdin input to the API (since it's a standalone project that others can use) but not necessarily to support using it with our Discord bot, cause the interface is kinda clunky on Discord.

#

If this was implemented then I'd rather have it be done on the API so it can just pipe output to the subprocess rather than having to inject code into the user's

compact veldt Aug 15, 2021, 5:30 PM

#

tawdry vapor If this was implemented then I'd rather have it be done on the API so it can jus...

Yes. This is what i would like as well. As it seems rather error prone to be injecting code like that.

tawdry vapor Aug 15, 2021, 5:30 PM

#

The nicest interface on discord may be to just have two code blocks: one for stdin and one for code.

compact veldt Aug 15, 2021, 5:32 PM

#

tawdry vapor The nicest interface on discord may be to just have two code blocks: one for std...

That could mess with the multiple '''py ...''' '''py ...''' usability. And I think it would be hard to understand if you are new to the bot.

tawdry vapor Aug 15, 2021, 5:33 PM

#

So we just just not allow multiple code blocks in one command if you want to specify stdin

compact veldt Aug 15, 2021, 5:34 PM

#

!e ```input
Sofi

```py
print("Your name is:", input("Whats your name? "))

#

So something like this?

tawdry vapor Aug 15, 2021, 5:36 PM

#

Yes

#

I think It would have to be a separate command to reduce confusion

timid sentinel Aug 15, 2021, 5:38 PM

#

Yeah agree with that ^. Something sort of fun would be to specify the codeblock language for the stdin codeblock as stdin, which will cause discord to ignore it, but that might just me more confusing 😅

compact veldt Aug 15, 2021, 5:39 PM

#

There could also be a check of the language used. Like i used '''input ...''' in the above example which could be a way to handle it as well.

compact veldt Aug 15, 2021, 5:39 PM

#

timid sentinel Yeah agree with that ^. Something sort of fun would be to specify the codeblock ...

Yeah. As then you need to know that you need to prefix it with input which is not super friendly.

timid sentinel Aug 15, 2021, 5:40 PM

#

and for other users it wouldn't be immediately obvious what is input and what is code

molten perch Aug 15, 2021, 5:55 PM

#

Sorry, I don't mean to just interrupt. But I believe it might solve the problem, if before actually eval.-ing the code, the bot would send a message, and the user would have to reply with the desired inputs provided that the code contains code that involves user input.

tawdry vapor Aug 15, 2021, 5:55 PM

#

Alternatively it could be a comment in the code that is parsed, but parsing adds complexity

molten perch Aug 15, 2021, 5:56 PM

#

Wouldn't say so, not a bit harder than the logic in the reminder 😄

brazen charm Aug 15, 2021, 5:58 PM

#

I didn't consider a subcommand, that could work nicely with two code blocks without interfering with the current codeblock handling

green oriole Aug 15, 2021, 5:58 PM

#

I was thinking about a subcommabd to set the stdin of your next eval

tawdry vapor Aug 15, 2021, 6:01 PM

#

I don't like the idea of saving state

compact veldt Aug 15, 2021, 6:05 PM

#

I found out i can probably use the subprocess.Popen's stdin.

viscid coral Aug 15, 2021, 6:15 PM

#

I know most developers are on vacation, but anyone might want to comment on bot#1717 ?

tawdry vapor Aug 15, 2021, 6:15 PM

#

compact veldt I found out i can probably use the `subprocess.Popen`'s `stdin`.

Are you gonna make a pr for this then?

viscid coral Aug 15, 2021, 6:15 PM

#

viscid coral I know most developers are on vacation, but anyone might want to comment on bot#...

bot#1717

dusky shoreBOT Aug 15, 2021, 6:15 PM

#

GitHub

IssueOpen Send message when help channel closed.

gritty wind Aug 15, 2021, 6:15 PM

#

If you make it a second command, you can specify in the help that arg 1 is input, art 2 is code

#

That’s something familiar to discord users

#

Combine that with the ignoring of non-codeblocks and you get
———

#

!eval-input

Input: all this text is ignored and exists to the benefit of readers

Sofi

Code: this is ignored too

print("Your name is:", input("Whats your name? "))

compact veldt Aug 15, 2021, 6:18 PM

#

tawdry vapor Are you gonna make a pr for this then?

Still fighting subprocess to figure out how to add it in properly.

brisk brook Aug 15, 2021, 6:26 PM

#

viscid coral bot#1717

I don't remember the full process, but you have not gotten any strong objections so if you would like to do this let someone know and they can assign you the issue.

I'll comment on the issue that I like it, so that we have that on record.

viscid coral Aug 15, 2021, 6:28 PM

#

Wdym do this?

brisk brook Aug 15, 2021, 6:28 PM

#

Would you like to make a PR that solves this?

viscid coral Aug 15, 2021, 6:29 PM

#

I can't

#

I mean, I don't know how

brisk brook Aug 15, 2021, 6:30 PM

#

viscid coral I mean, I don't know how

Don't worry about it

brisk brook Aug 15, 2021, 6:30 PM

#

viscid coral I can't

The question is would you like to try? If you get stuck just ask

viscid coral Aug 15, 2021, 6:31 PM

#

Yeah sure I can try

#

Should I open it now?

brisk brook Aug 15, 2021, 6:33 PM

#

viscid coral Should I open it now?

Open a pull request?

viscid coral Aug 15, 2021, 6:34 PM

#

Yeah

compact veldt Aug 15, 2021, 6:42 PM

#

compact veldt Still fighting subprocess to figure out how to add it in properly.

Bad news. This is the first time ever i have met a file object, and not file-like object. You are not able to pass in your own file-like objects. So using stdin in the original idea doesnt work ;-;

tawdry vapor Aug 15, 2021, 6:46 PM

#

compact veldt Bad news. This is the first time ever i have met a file object, and not file-lik...

Is .communicate() on the process handle not sufficient?

#

Does it block or something?

compact veldt Aug 15, 2021, 6:48 PM

#

Issue is that it doesnt print out the example input.

tawdry vapor Aug 15, 2021, 6:48 PM

#

Never mind communicate won't work here anyway

#

I would try writing directly to proc.stdin

compact veldt Aug 15, 2021, 6:49 PM

#

We can write to stdin just fine. But the issue is that it wont show in stdout.

#

Thats what the patch was supposed to do. It puts in the stdin section into the stdout. So it looks like you have written it in yourself.

tawdry vapor Aug 15, 2021, 6:50 PM

#

Oh i see

#

I don't see why that's a problem. This isn't meant to emulate a REPL or terminal, so one should not expect the output to contain the input (it's called _out_put after all)

compact veldt Aug 15, 2021, 6:51 PM

#

The idea was to allow:

Input: Sofi
You wrote: Sofi

#

But writing directly to stdin makes it to:

Input: You wrote: Sofi

brisk brook Aug 15, 2021, 6:53 PM

#

viscid coral Yeah

You can open a draft pull request, that way if you get stuck and want to show your code you can show the whole pull request.

I'll assign you to the issue, I don't think there's any more steps to be done before you can start working. I think we have fleshed out the idea

green oriole Aug 15, 2021, 6:55 PM

#

compact veldt But writing directly to stdin makes it to: ```py Input: You wrote: Sofi ```

Ah, that makes sense, and there is no way around it

compact veldt Aug 15, 2021, 6:56 PM

#

There might be other ways to do it. But i cant find out a good way right now

#

Like we can still swap out the input() function to a different one. But then other functions that rely on stdin will still break.

green oriole Aug 15, 2021, 6:57 PM

#

Well, printing it at the right place would require timing the input, which isn't possible

viscid coral Aug 15, 2021, 7:06 PM

#

brisk brook You can open a draft pull request, that way if you get stuck and want to show yo...

What is a draft PR?

compact veldt Aug 15, 2021, 7:07 PM

#

green oriole Well, printing it at the right place would require timing the input, which isn't...

We could also use a program to wrap the python call in. It would handle the input/output outside of python.

#

And we can just get the nice stdout with the input in the right places.

brazen charm Aug 15, 2021, 7:07 PM

#

viscid coral What is a draft PR?

you can open a draft pr on github which indicates it isn't read for review/to be merged yet

compact veldt Aug 15, 2021, 7:07 PM

#

Instead of messing with python.

green oriole Aug 15, 2021, 7:08 PM

#

Well, how do you place the stdin at the right place in the stdout? That's the whole issue

brisk brook Aug 15, 2021, 7:08 PM

#

viscid coral What is a draft PR?

When you open a pull request, there should be an option to "open it as draft". This has that grey icon and can't be merged until it is converted to an open one.

#

It's simply a clear way of saying "This isn't done"

viscid coral Aug 15, 2021, 7:10 PM

#

Oh ok

#

I need to show the solution right away?

compact veldt Aug 15, 2021, 7:11 PM

#

green oriole Well, how do you place the stdin at *the right place* in the stdout? That's the ...

The wrapping program, like inputter --input="Sofi\n" python3 ... and it would handle putting the input into the output we capture with subprocess.

viscid coral Aug 15, 2021, 7:11 PM

#

Or just open a PR and fork the project?

brazen charm Aug 15, 2021, 7:11 PM

#

how would that differentiate between stdout output from something like input and a normal output?

green oriole Aug 15, 2021, 7:12 PM

#

compact veldt The wrapping program, like `inputter --input="Sofi\n" python3 ...` and it would ...

Yes, but in your example you put the stdin after Input:. How would inputter know that it is where it should be put?

brazen charm Aug 15, 2021, 7:12 PM

#

you'd need to know when the proc is waiting on stdin which you can't really

green oriole Aug 15, 2021, 7:12 PM

#

The problem is the whole stdin is avaliable when the program is ran

#

You could look at when the process reads stdin

#

But that's waaayyy too complex

thorny obsidian Aug 15, 2021, 7:13 PM

#

viscid coral Or just open a PR and fork the project?

You're only able to open a PR if you have a fork with some type of difference/change. So fork, start making some changes and working on a thing, and if you'd like to get early feedback then a draft PR is helpful

brazen charm Aug 15, 2021, 7:14 PM

#

I think like mark said just not writing that seems like the best option to me, the input is already in the invoking message anyway and newlines can be added to the prompts to avoid having them all on one line

viscid coral Aug 15, 2021, 7:14 PM

#

But how can I open a PR from te fork?

compact veldt Aug 15, 2021, 7:14 PM

#

green oriole But that's waaayyy too complex

It shouldnt be too complex.

brazen charm Aug 15, 2021, 7:15 PM

#

viscid coral But how can I open a PR from te fork?

create a branch on it with your changes and github should prompt you

viscid coral Aug 15, 2021, 7:17 PM

#

Oh wait I have a repo from a PR I did a few time ago

green oriole Aug 15, 2021, 7:17 PM

#

compact veldt It shouldnt be too complex.

It is way too complex for the benefit it gives. It will probably break on a lot of edge cases, I don't think it is worth maintaining that.

tawdry vapor Aug 15, 2021, 7:20 PM

#

I'd say if you can do it, then go for it. Is this wrapper also in Python? Cause then we could just invoke it with -m wrappermodule

viscid coral Aug 15, 2021, 7:21 PM

#

viscid coral Oh wait I have a repo from a PR I did a few time ago

Maybe someone else can do it that knows github better(everyone)? I don't want to get some all the trouble of helping me and that I don't know English and discord.py or Python well

compact veldt Aug 15, 2021, 7:24 PM

#

green oriole It is way too complex for the benefit it gives. It will probably break on a lot ...

No im pretty tired after trying to make this work now. And i have ran out of ideas for how one could easily implement this

brisk brook Aug 15, 2021, 7:27 PM

#

viscid coral Maybe someone else can do it that knows github better(everyone)? I don't want to...

Are you having issues opening the draft pull request? It isn't the most important part, so start by creating a branch on your fork and opening your editor and poking at the bot. When you have something to commit, do that and you should see an option to open a pull request in the GitHub UI

thorny obsidian Aug 15, 2021, 7:29 PM

#

To briefly interrupt you wonderful folks, because I'd rather not manually delete 63 channels or come up with an int-e that I could fuck up to delete said 63 channels, could I get some help reviewing this? https://github.com/python-discord/bot/pull/1677

GitHub

Additional code jam management utilities by mbaruh · Pull Request #...

The purpose of this PR is for us to avoid manually searching the permissions of team channels, and dealing with user-based overwrites. This also allows us to quickly tell what team a participant be...

viscid coral Aug 15, 2021, 7:30 PM

#

brisk brook Are you having issues opening the draft pull request? It isn't the most importan...

I don't know how to use it with my editor and github? That is why I said I am not really good

brisk brook Aug 15, 2021, 7:34 PM

#

viscid coral I don't know how to use it with my editor and github? That is why I said I am no...

What editor do you use?

viscid coral Aug 15, 2021, 7:34 PM

#

VSCode

#

Why can't I do it from github itself maybe

brisk brook Aug 15, 2021, 7:35 PM

#

Do you have the repository cloned locally?

viscid coral Aug 15, 2021, 7:35 PM

#

Not that repo

#

Maybe someone else who knows dpy and github can do it

brisk brook Aug 15, 2021, 7:38 PM

#

We're happy to help you here, but if you no longer want to do it @green oriole (:pppp) can un-assign you

viscid coral Aug 15, 2021, 7:38 PM

#

Yeah sure I don't know how

tawdry vapor Aug 15, 2021, 8:04 PM

#

compact veldt No im pretty tired after trying to make this work now. And i have ran out of ide...

Can you share your patch? You said you had something but didn't know how to integrate it.

#

I might look into it more

compact veldt Aug 15, 2021, 8:14 PM

#

compact veldt !e ```py import io import sys class PrintingStringIO(io.StringIO): def read...

@tawdry vapor This is the one.

tawdry vapor Aug 15, 2021, 8:17 PM

#

Thanks

cold island Aug 15, 2021, 9:02 PM

#

@brisk brook I addressed the requested changes

brisk brook Aug 15, 2021, 9:02 PM

#

Perfect, I'll take another look

dusky shoreBOT Aug 15, 2021, 9:11 PM

#

GitHub

PROpen Edit on GitHub feature - and small changes

vocal wolf Aug 15, 2021, 9:13 PM

#

I think doublevcodes is back so they'll probably be able to finish this up. If you deleted your fork, you can just re-fork the repo on github.

#

whoops lol

#

I thought someone else owned that PR

#

I'm not really familiar with site, what seems to be the problem?

gritty wind Aug 15, 2021, 9:24 PM

#

Tbh, after reviewing the site a bit, the way URLs are managed is a bit of a nightmare to reverse navigate. Since each URL can dictate where it's HTML files lie, there is no clear structure. Instead, what we could do is inject the correct path into the metadata of each page when building/starting, that way it's just available, and the button can read it without calculating

cold island Aug 15, 2021, 9:27 PM

#

Thanks @brisk brook 👏

#

And @green oriole too

#

for reviewing

#

Another PR

#

#dev-log

#

sad

gritty wind Aug 15, 2021, 9:29 PM

#

Nah, the idea is it's all automated

#

What that could look like is:
in site.manage.main, we recursively pull all html files, look for a <head> element, and add our own tag which is just the path of the file

#

I bet there is a django template to do that, but I don't know django

#

Perhaps #web-development will know, but that's the gist of the idea

brisk brook Aug 15, 2021, 9:33 PM

#

https://github.com/python-discord/site/runs/3330718197?check_suite_focus=true

GitHub

Build software better, together

GitHub is where people build software. More than 65 million people use GitHub to discover, fork, and contribute to over 200 million projects.

#

Here is where it failed specifically ^

#

The tracebacks all go back to Django pretty much

#

Here's what you want to know I think: ```
Creating test database for alias 'default'...
........................./home/runner/work/site/site/.cache/py-user-base/lib/python3.9/site-packages/whitenoise/base.py:115: UserWarning: No directory at: /app/staticfiles/

...................................................../home/runner/work/site/site/.cache/py-user-base/lib/python3.9/site-packages/django/db/models/fields/init.py:1365: RuntimeWarning: DateTimeField Infraction.expires_at received a naive datetime (2021-08-15 02:36:09.794182) while time zone support is active.

gritty wind Aug 15, 2021, 9:36 PM

#

Do you not have testing set up locally?

brisk brook Aug 15, 2021, 9:37 PM

#

.....................................................................................Unable to parse the GitHub repository metadata from response!
.......Unable to parse the GitHub repository metadata from response!
Unable to parse the GitHub repository metadata from response!

.Internal Server Error: /pages/resources/reading/
django.urls.exceptions.NoReverseMatch: Reverse for 'resources' with arguments '('reading',)' not found. 1 pattern(s) tried: ['resources/list/$']

ERROR: test_redirects (pydis_site.apps.redirect.tests.RedirectTests) (original_path='pages/resources/<str:category>/', redirect_route='resources:resources', name='resources_resources_redirect', redirect_arguments=(), args=('reading',))
Should redirect to given route based on redirect rules.

django.urls.exceptions.NoReverseMatch: Reverse for 'resources' with arguments '('reading',)' not found. 1 pattern(s) tried: ['resources/list/$']

molten perch Aug 15, 2021, 9:48 PM

#

I believe the problem lies here:
https://github.com/python-discord/site/blob/main/pydis_site/apps/resources/urls.py
https://github.com/doublevcodes/site/blob/doublevcodes/smarter-resources/front-end/pydis_site/apps/resources/urls.py
You seem to be using an older(?) version of this file. (I'm not sure though, it seems so for me)

gritty wind Aug 15, 2021, 10:32 PM

#

Opened an issue on the site repo after realizing I can't actually run the unittests locally 🤡

#

I've contributed to the site before, surprised I never ran into problems

gritty wind Aug 15, 2021, 11:38 PM

#

@clever wraith I've come up with a terribly hacky solution

#

I'll try to integrate it into your branch right now, this has to be witnessed

#

where is the branch btw lol

#

ahhh

#

I can get it from the PR and push it to a new branch

#

But the PR itself will have to be closed and reopened

#

Let me

#

try to replace your branch with this first

#

In the meantime, hack has been pushed

#

https://github.com/python-discord/site/commit/054dd39dc55ef2020a3a36dda140ef1bd7b8e50a

#

@clever wraith can you give me permission to edit your fork?

#

HassanAbouelela

#

sweet, thanks

#

From my code, or from what I'm doing now?

#

Also, was this PR created from your main branch?

#

That makes it a little harder to fix haha

#

I can sort of explain what's happening:

Context processors get called whenever django is trying to render a template. I added one that adds a meta tag with the content being the link to the file. (Example: pydis_site\templates\home\index.html on the home page).
If you take the value from step 1, and combine it with https://github.com/python-discord/site/blob/main/, you'll get a URL to the file:
https://github.com/python-discord/site/blob/main/pydis_site\templates\home\index.html
The button can create this URL

#

If you are curious about step 1, that's where 90% of the meat of my changes are

#

Basically, it's magic, but if you're really curious, this is the function that calls path_processor:
https://github.com/django/django/blob/main/django/template/context.py#L244

I use inspect, to get the variables from that function (bind_template)

#

One of the variables that function sees is self.template. Self.template contains the path pydis_site\templates\home\index.html

#

haha, that's fair

#

I'm not sure if this PR will get accepted with my code

#

Lol what did you try

#

I see

#

Yeah...

#

Actually, now I'm realizing what I did won't work either

#

I'm linking to the HTML template, not the markdown content

#

Where is the button supposed to show up btw?

#

Ah, I see

#

It isn't on all pages yet

#

going to have to rethink my approach again though, not sure how these markdown templates work

slim widget Aug 16, 2021, 2:16 AM

#

Erm, @vocal wolf did you intend to request a review from me? I've not really been involved in bot development so far, but I'll give it a try 😄

vocal wolf Aug 16, 2021, 2:16 AM

#

Yes, it was intended

#

Thank you for any and all feedback to that PR!

slim widget Aug 16, 2021, 2:17 AM

#

👍

vocal wolf Aug 16, 2021, 2:29 AM

#

PR up for grabs - WTF Python command:

https://github.com/python-discord/sir-lancebot/pull/605

GitHub

Add WTF Python Command by Shivansh-007 · Pull Request #605 · python...

Relevant Issues
Closes #602
Description
Gets the fuzzy match of a search query, returns None if the ratio is below 90 else returns the fuzzy match. If the return is None, then we send our custom Er...

tawdry vapor Aug 16, 2021, 2:33 AM

#

Have you had a chance to think about the issue templates/forms for meta?

vocal wolf Aug 16, 2021, 2:33 AM

#

Oh right yes, I have had some time now. Last time we spoke I had a migraine, couldn't communicate very clearly.

#

I was about to ping you about the label stuff as well

#

I need to go back and review the conversation that we had previously

celest charm Aug 16, 2021, 2:54 AM

#

Nice license https://github.com/satwikkansal/wtfpython/blob/master/LICENSE

#

btw, didn't we drop fuzzywuzzy beacuse it's GPL?

#

on sir-lancebot

vocal wolf Aug 16, 2021, 2:59 AM

#

celest charm btw, didn't we drop `fuzzywuzzy` beacuse it's GPL?

yes

celest charm Aug 16, 2021, 3:00 AM

#

vocal wolf PR up for grabs - WTF Python command: https://github.com/python-discord/sir-lan...

then this will need to change

vocal wolf Aug 16, 2021, 3:00 AM

#

agreed

tawdry vapor Aug 16, 2021, 3:04 AM

#

celest charm Nice license <https://github.com/satwikkansal/wtfpython/blob/master/LICENSE>

That's a misleading license. I can't actually do what the fuck I want if what I want involves making changes without changing the name.

#

Never mind, that clause is about changing the license rather than the code it's applied to

celest charm Aug 16, 2021, 3:05 AM

#

yeah

#

            DO WHAT THE SHIT YOU WANT TO PUBLIC LICENSE
                    Version 1, August 2021

Copyright (C) 2021 fix error

Everyone is permitted to copy and distribute verbatim or modified
copies of this license document, and changing it is allowed as long
as the name is changed.

            DO WHAT THE SHIT YOU WANT TO PUBLIC LICENSE
  TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION

0. You just DO WHAT THE SHIT YOU WANT TO.
``` done

tawdry vapor Aug 16, 2021, 3:06 AM

#

I wonder what the difference is between this and public domain since this license seems to retain copy right, but is trying to grant permission to do anything

celest charm Aug 16, 2021, 3:06 AM

#

Public domain means you're making a contribution to humanity without asking back, WTFPL means you just could've give less fuck, I suppose

vocal wolf Aug 16, 2021, 3:08 AM

#

@tawdry vapor going back to our conversation starting at the link below, how would adding such things be overwhelming?

#dev-contrib message

tawdry vapor Aug 16, 2021, 3:09 AM

#

There are 4 areas and 3 types. That would mean 12 templates.

vocal wolf Aug 16, 2021, 3:09 AM

#

@vale ibex PR merged: #dev-log message

tawdry vapor Aug 16, 2021, 3:09 AM

#

Actually, 5 areas

vocal wolf Aug 16, 2021, 3:10 AM

#

tawdry vapor There are 4 areas and 3 types. That would mean 12 templates.

I can now see how that's overwhelming, I misunderstood the statement.

tawdry vapor Aug 16, 2021, 3:11 AM

#

If we just have 1 for each area, then the templates either have to be vague in their descriptions or they have to have elaborate descriptions that go like "if it's an addition, then... But if it's a removal, then ... Or if it's a revision then ...."

#

I don't have high hopes for GH offering a more powerful forms feature, where we can display components dynamically based on previous choices.

vocal wolf Aug 16, 2021, 3:13 AM

#

So we only want the 3 areas, being add, remove, and revise/enhance (whatever we call it), what are the types that we're talking about? By labels such as backend/frontend?

tawdry vapor Aug 16, 2021, 3:13 AM

#

Just look at the labels https://github.com/python-discord/meta/labels

vocal wolf Aug 16, 2021, 3:13 AM

#

ah those labels

tawdry vapor Aug 16, 2021, 3:15 AM

#

It doesn't necessarily have to be 5 * 3 templates. There could be a way to merge at least some of them without it being too vague

#

I don't know..,

vocal wolf Aug 16, 2021, 4:09 AM

#

@tawdry vapor I'm thinking of check boxes with somewhat-specific descriptions of when to use a certain type for some area, but that's probably not the best solution.

#

Hell, it's basically not a solution since what I've just said is a vague interpretation of what we need and discussed

#

Maybe it's because we don't have that many options here, either way we don't want 15 templates.

tawdry vapor Aug 16, 2021, 4:41 AM

#

I think we need to determine which combinations of areas and types will require unique fields and which can be generalised

#

For example, we can probably get away with a single template for tags, regardless of add/remove/revise

#

All it needs is a description and a justification

#

A description field is a bit awkward for removal, since all it needs to have is the name of the tag.

#

An example of a unique field would be the locations field for resources. That's only needed when adding a new resource.

green oriole Aug 16, 2021, 7:58 AM

#

tawdry vapor I wonder what the difference is between this and public domain since this licens...

CC0 limits liability for instance while WTFPL does not

green oriole Aug 16, 2021, 8:19 AM

#

.love @vale ibex

#

Seems about right

#

It is a bit weird that it doesn't keep the embed

vale ibex Aug 16, 2021, 8:20 AM

#

yea, there's a 7.5 delete_after on inchannel and inmonth checks

short snow Aug 16, 2021, 8:59 AM

#

i am getting this for some reason on poetry install, my enhance incidents branch was behind where we had pipenv so, i rebased it to upstream and i get this

short snow Aug 16, 2021, 9:19 AM

#

I hack fix for this is to change all the 3.5.* in poetry.lock to just 3.5, atleast for me

green oriole Aug 16, 2021, 9:29 AM

#

Is your Poetry up to date?

short snow Aug 16, 2021, 9:37 AM

#

yeah 1.2.0a2

green oriole Aug 16, 2021, 9:42 AM

#

No idea

short snow Aug 16, 2021, 9:51 AM

#

did i just mess up the lock file, i will just reset it to head~1

short snow Aug 16, 2021, 10:15 AM

#

https://github.com/python-discord/bot/pull/1446#discussion_r688997675 should i do this by checking if the channel can be viewed by helpers?

#

third point

green oriole Aug 16, 2021, 10:17 AM

#

short snow https://github.com/python-discord/bot/pull/1446#discussion_r688997675 should i d...

yes, if the role has read messages

short snow Aug 16, 2021, 10:21 AM

#

right and i didn't understand the second point, what is #message-change-log?

#

couldn't find it in the code anywhere

#

mod log channel?

#

but that's again only mod+ and not helpers

#

so i don't think we should show that then

green oriole Aug 16, 2021, 10:41 AM

#

#message-change-log is where we log edits and message deletion

vale ibex Aug 16, 2021, 10:44 AM

#

short snow mod log channel?

It's constants.Channels.message_log

short snow Aug 16, 2021, 10:51 AM

#

alright

short snow Aug 16, 2021, 10:51 AM

#

short snow but that's again only mod+ and not helpers

but what about this?

vale ibex Aug 16, 2021, 10:52 AM

#

Yea, that channel is mod only

short snow Aug 16, 2021, 10:52 AM

#

so should i just ignore those messages?

#

or find the links to them but not show the content

vale ibex Aug 16, 2021, 10:54 AM

#

possibly just linking to that message it enough

vocal prairie Aug 16, 2021, 11:22 AM

#

@patent pivot Not sure if you know already, but shipit disappeared in #dev-log. Not a big thing, just noticed it.

patent pivot Aug 16, 2021, 11:23 AM

#

vocal prairie <@!165023948638126080> Not sure if you know already, but <:shipit:82649237181340...

It never worked, bug on discord end

vocal prairie Aug 16, 2021, 11:24 AM

#

Ah okay

narrow stream Aug 16, 2021, 11:39 AM

#

Hi, how did you start contributing to other projects

#

How did you find the right one

viscid coral Aug 16, 2021, 11:39 AM

#

Wdym?

brisk brook Aug 16, 2021, 1:26 PM

#

Reviewing PRs is top-tier procrastination 😅

surreal veldt Aug 16, 2021, 3:39 PM

#

hey is anyone going to be checking out/working on bot#447 ?

dusky shoreBOT Aug 16, 2021, 3:39 PM

#

GitHub

IssueOpen Support partial searches for documentation

clever wraith Aug 16, 2021, 3:43 PM

#

finally back at contributing after 5 billion years

clever wraith Aug 16, 2021, 3:44 PM

#

patent pivot It never worked, bug on discord end

didn't you do something with cloudflare or something?

patent pivot Aug 16, 2021, 3:44 PM

#

clever wraith didn't you do something with cloudflare or something?

Yes — we rewrite the embeds to include the Discord emote but however Discord handles GitHub payloads doesn't support discord emotes

clever wraith Aug 16, 2021, 3:46 PM

#

Oh

fervent sage Aug 16, 2021, 4:04 PM

#

patent pivot Yes — we rewrite the embeds to include the Discord emote but however Discord han...

*except when it randomly does

patent pivot Aug 16, 2021, 4:05 PM

#

fervent sage *except when it randomly does

My belief is it works in comments but not reviews

brazen charm Aug 16, 2021, 4:06 PM

#

surreal veldt hey is anyone going to be checking out/working on bot#447 ?

Like I mentioned in the comment there I'm planning to look into it if nobody else does, just don't want to commit time to it at the moment

stable mountainBOT Aug 16, 2021, 4:36 PM

#

@green oriole

It has arrived!

Here's your reminder: Ask Sebastiaan if he is back from vacations
[Jump back to when you created the reminder](#dev-contrib message)

green oriole Aug 16, 2021, 4:38 PM

#

Hello @hardy gorge! I don't know if you are back in business yet, but if you are I have a question 😄 We would like to change the reminder.jump_url field in the database schema to instead be a message ID. What should we do? Should we wait for the FastAPI rewrite and open an issue there, change it now on the Django site, or some else?

short snow Aug 16, 2021, 4:39 PM

#

My opinions, reminders aren’t going to be transferred to api any time soon atleast not this month for sure as dB setup is remaining and we would need to review it. So I would say to implement it on django site

cold island Aug 16, 2021, 4:39 PM

#

How will you tell which channel it's from?

short snow Aug 16, 2021, 4:40 PM

#

Yeah wouldn’t you also need the channel ID if you are wanting to fetch the message and reply to it?

cold island Aug 16, 2021, 4:42 PM

#

Also from what I saw you wanted to have a fallback to the old behavior no?

molten perch Aug 16, 2021, 5:07 PM

#

It's not necessary to change the API, actually.. it's better if we won't. My solution falls back to the old behaviour when it can't find the original message
bot#1749

dusky shoreBOT Aug 16, 2021, 5:07 PM

#

GitHub

PROpen Update reminders to reply instead of using a jump url to the origin message

molten perch Aug 16, 2021, 5:08 PM

#

But the modifications of bot#1748 will probably render this idea useless. So :/

dusky shoreBOT Aug 16, 2021, 5:08 PM

#

GitHub

IssueOpen Allow reminders in all channels

patent pivot Aug 16, 2021, 6:16 PM

#

Yeah not sure why we need to change the API

#

The answer though is that we're not in a freeze for fastapi

molten perch Aug 16, 2021, 6:21 PM

#

(I would love to push the generated models to get the API going, btw. 😄 )

green oriole Aug 16, 2021, 6:23 PM

#

cold island How will you tell which channel it's from?

It is already a field

gritty wind Aug 16, 2021, 6:42 PM

#

You can also just

#

Pull the message ID from the jump link

green oriole Aug 16, 2021, 6:44 PM

#

Yes, but why saving the whole url, that's pointless

gritty wind Aug 16, 2021, 7:04 PM

#

dusky shore

Because .

molten perch Aug 16, 2021, 7:06 PM

#

gritty wind Pull the message ID from the jump link

That’s what happened 😄
If the bot can reply then it will, otherwise it uses the jump url.

gritty wind Aug 16, 2021, 7:07 PM

#

Also size wise

#

We don’t save/lose much

green oriole Aug 16, 2021, 7:08 PM

#

Yeah we remove reminders when they are deleted

molten perch Aug 16, 2021, 7:11 PM

#

But if you can use the reminder in every channel, and the bot sends the reminder into bot commands, then adding this reply feature is useless.

vale ibex Aug 16, 2021, 7:51 PM

#

@molten perch Adding log.trace(f"Deleting {matches[0]}") just before the if matches line output this for me ```
Deleting discord.com/api/weebhooks/876911370745040986/-uawyVt2XQgXE-u9Bx5d0SpL0szH896jDZlka6Ej_7Rwujw1XHU_FnYSvPQsAeSBxO-b

#

see how it's missing the protocol?

#

So the next line raised aiohttp.client_exceptions.InvalidURL

molten perch Aug 16, 2021, 7:52 PM

#

I do, I find it very strange. I've tested it out and it seemed to match the url.

vale ibex Aug 16, 2021, 7:52 PM

#

(i changed it to weebhooks before posting here so the bot doesn't zap it)

#

I wonder if it's because I tested with a canary link

#

lemme try without canary

#

It should work with both really

molten perch Aug 16, 2021, 7:53 PM

#

Can I do an eval here? With the code.
Just by testing the regEx?

vale ibex Aug 16, 2021, 7:53 PM

#

Sure

#

Yea, alright. It works if it's just https://discord.com/api/weebhooks/876916761482645544/KY0Wv1_JA_8O6Z4TqtcC9Sm3OuYjqCZDWdCcYySS92Jv99Zcyz25p5aOnrs7RbkTTWuv

#

But, if it's https://canary.discord.com/api/weebhooks/876916761482645544/KY0Wv1_JA_8O6Z4TqtcC9Sm3OuYjqCZDWdCcYySS92Jv99Zcyz25p5aOnrs7RbkTTWuv the https doesn't match

#

which makes sense looking at the regex

molten perch Aug 16, 2021, 7:56 PM

#

oh, alright then 😄
I was a bit confused.

vale ibex Aug 16, 2021, 7:57 PM

#

((?:https?:\/\/)?(?:ptb\.|canary\.)?discord(?:app)?\.com\/api\/webhooks\/\d+\/)\S+\/? should do the job

#

but there might be a better way, if anyone is lurking

molten perch Aug 16, 2021, 8:01 PM

#

It seems to be working with both types of link.

vale ibex Aug 16, 2021, 8:01 PM

#

Yea it should work, but there might be a more concise regex to do the job

#

I'm not the best at writing regex

molten perch Aug 16, 2021, 8:02 PM

#

I'm not sure whether regEx can be concise at all 😂
It was hell when doing NLP.

vale ibex Aug 16, 2021, 8:02 PM

#

Hah

#

well feel free to commit that and we'll see if anyone has suggestions in the PR

molten perch Aug 16, 2021, 8:03 PM

#

Alright, thank you! I didn't think of canary urls

clever wraith Aug 16, 2021, 9:30 PM

#

hey @vale ibex when you have time ive gotten back to .reverse and re-requested a view

stable mountainBOT Aug 16, 2021, 9:34 PM

#

@vale ibex, looks like you posted a Discord webhook URL. Therefore, your message has been removed, and your webhook has been deleted. You can re-create it if you wish to. If you believe this was a mistake, please let us know.

vale ibex Aug 16, 2021, 9:34 PM

#

Nice @molten perch 🎉

molten perch Aug 16, 2021, 9:34 PM

#

Yaay 🥳

clever wraith Aug 16, 2021, 9:36 PM

#

hell yeah

molten perch Aug 16, 2021, 9:37 PM

#

Hopefully it also deleted from Discord 😛

vale ibex Aug 16, 2021, 9:37 PM

#

hah yea it did

#

I made a new server just to be safe lol

green oriole Aug 16, 2021, 9:38 PM

#

Good job!

molten perch Aug 16, 2021, 9:38 PM

#

😃

clever wraith Aug 16, 2021, 9:40 PM

#

alright chris, resolved

brisk brook Aug 16, 2021, 9:42 PM

#

RE: https://github.com/python-discord/sir-lancebot/pull/760#discussion_r689875190

It's such a rule I try to live by

GitHub

Adds `.reverse` by Kronifer · Pull Request #760 · python-discord/si...

Relevant Issues
Closes #749

Description
Implemented the reverse command, which flips the users profile picture if no text is given, or the given text.
Images
Profile Reversal:

Text Reversal:

Did...

vale ibex Aug 16, 2021, 9:43 PM

#

hah yea, it definitely leads to nicer code to read

brisk brook Aug 16, 2021, 9:43 PM

#

Not to shit on someone's code, but here you can see a good example of where "filtering if-statements" make more sense

#

https://github.com/MattW-source/discord-wilfred/blob/master/commands/cosmetics.py

GitHub

discord-wilfred/cosmetics.py at master · MattW-source/discord-wilfred

Wilfred as seen in Varsity 4.0. Contribute to MattW-source/discord-wilfred development by creating an account on GitHub.

#

Specifically see this code https://github.com/MattW-source/discord-wilfred/blob/master/commands/cosmetics.py#L97-L108

stable mountainBOT Aug 16, 2021, 9:44 PM

#

commands/cosmetics.py lines 97 to 108

        if msg.content.upper() == "Y":
            if image_url is None:
                sql.execute_query("INSERT INTO cosmetics (cosmetic_name, cosmetic_rarity, cosmetic_description) VALUES ('%s', '%s', '%s')" % (title.replace("'", "''"), rarity, description.replace("'", "''")))
            else:
                sql.execute_query("INSERT INTO cosmetics (cosmetic_name, cosmetic_rarity, cosmetic_description, cosmetic_image_url) VALUES ('%s', '%s', '%s', '%s')" % (title.replace("'", "''"), rarity, description.replace("'", "''"), image_url.replace("'", "''")))
            await ctx.send("Cosmetic Created")
        else:
            await ctx.send("_Cancelled_")
    else:
        await ctx.send("**Error:** Permission Denied. This command requires permission rank `MANAGER`")
else:
    await ctx.send("**Error:** Invalid Usage")```

brisk brook Aug 16, 2021, 9:44 PM

#

You end up with these error cases at the end, that you don't know to what if-statement they map to

vale ibex Aug 16, 2021, 9:44 PM

#

eyes_zoom

brisk brook Aug 16, 2021, 9:45 PM

#

The only way to figure out would be the hide the code and expand it up again

#

To be fair, it starts simple right. You want the code to run if X right

#

But then you only want to continue if Y or Z and W.

#

So you end up like this, it's tough writing readable code 😔

clever wraith Aug 16, 2021, 9:49 PM

#

brisk brook RE: https://github.com/python-discord/sir-lancebot/pull/760#discussion_r68987519...

yeah im gonna try and keep on that

viscid coral Aug 16, 2021, 11:18 PM

#

Just a question, this issue: bot#1624 , seems to handle two commands ghost pings when an error happens right?

dusky shoreBOT Aug 16, 2021, 11:18 PM

#

GitHub

IssueClosed Do not delete !docs/!pypi invocation if it contains a ping

viscid coral Aug 16, 2021, 11:19 PM

#

And PR bot#1696

dusky shoreBOT Aug 16, 2021, 11:19 PM

#

GitHub

PRMerged Prevent ghost-pings in pypi command

gritty wind Aug 16, 2021, 11:19 PM

#

Yes

viscid coral Aug 16, 2021, 11:20 PM

#

But I see there is also this thing with eval command

#

I did !eval in #python-discussion (I thought you can do it there for example) with a user mention, and it was deleted

brazen charm Aug 16, 2021, 11:21 PM

#

pretty sure that is intentional for the redirect

viscid coral Aug 16, 2021, 11:21 PM

#

Yeah but the user was still ghost-pinged

brazen charm Aug 16, 2021, 11:21 PM

#

It's pinging the user who invoked the command immediately, while docs/pypi could have mentions of other users

viscid coral Aug 16, 2021, 11:22 PM

#

!eval

print('test')```
@brazen charm

stable mountainBOT Aug 16, 2021, 11:22 PM

#

@viscid coral :white_check_mark: Your eval job has completed with return code 0.

test

viscid coral Aug 16, 2021, 11:22 PM

#

Dammit

#

I just wanted to show

#

Sorry for ping btw lol

brazen charm Aug 16, 2021, 11:23 PM

#

ah right that'll delete the message too

#

I'd say it's worth it in this case with the likelyhood of it containing a mention and the size of messages usually passed to eval

gritty wind Aug 16, 2021, 11:23 PM

#

I think there's a fundamental difference between those two concepts. When you're pining someone with a tag, there isn't as much...

#

what Numerlor said

#

Though I wouldn't really care either way

#

Admins and mods already get a bunch of ghost pings, I just accept it as a reality of life

viscid coral Aug 16, 2021, 11:25 PM

#

It can still confuse other users, it'll delete the message pinged them and even in search history there won't be any result

#

I mean, there is not really anything bad about adding this

brazen charm Aug 16, 2021, 11:26 PM

#

I'd have to retain messages that are currently being purposefully filtered out from the high traffic channel

celest charm Aug 17, 2021, 12:52 AM

#

senpai noticed me lemon_hyperpleased

vocal wolf Aug 17, 2021, 1:06 AM

#

lol

celest charm Aug 17, 2021, 1:06 AM

#

Is there a way to leave a comment on some changes that are not in the diff?

#

I want to make a comment about this docstring

brazen charm Aug 17, 2021, 1:07 AM

#

only for a few lines around it afaik

celest charm Aug 17, 2021, 1:07 AM

#

lemon_pensive why

#

alright I'll approach it differently

celest charm Aug 17, 2021, 1:11 AM

#

celest charm I want to make a comment about this docstring

@short snow I think it's redundant to put explanations like "this is a dataclass" or "this is a class" in a class, Ideally it would be

@dataclass
class _QuizEntry:
    question: str
    answer: str  # comma-separater
``` alternatively, the comment is not needed if it's clear that `answer` has multiple values ```py
@dataclass
class _QuizEntry:
    question: str
    possible_answers: t.Set[str]

#

Another question: why is DynamicQuestionGen a class? seems a bit Java-y to me to be honest, you don't create instances of it, and it doesn't have any state

clever wraith Aug 17, 2021, 1:32 AM

#

when people have time, please look at sir-lancebot#760

dusky shoreBOT Aug 17, 2021, 1:32 AM

#

GitHub

PROpen Adds .reverse

celest charm Aug 17, 2021, 4:01 AM

#

@clever wraith not directly related to the PR, but

_EXECUTOR = ThreadPoolExecutor(10)

Why 10?
Are you sure that PIL releases the GIL on all the operations? How was that measured/checked?

torpid grotto Aug 17, 2021, 5:33 AM

#

There seems to be a bug right now where python bot responds when someone sends a message in #discord-bots

#

Or in any channel I guess

green oriole Aug 17, 2021, 5:39 AM

#

Yep yep, t'is solved now, sorry about that

dense bear Aug 17, 2021, 5:46 AM

#

What happened?

green oriole Aug 17, 2021, 5:49 AM

#

We tried to deploy a test bot that could only be used in 2 channels, except it sent a message when any other message was posted, because the onmessage handler was trying to process it, but the message wasn't in those two channels

short snow Aug 17, 2021, 5:53 AM

#

celest charm <@!736234578745884682> I think it's redundant to put explanations like "this is ...

agreed that could be done

short snow Aug 17, 2021, 5:54 AM

#

celest charm Another question: why is `DynamicQuestionGen` a class? seems a bit Java-y to me ...

I wanted to group all the dynamic question generator functions together, thought class would be the best,

celest charm Aug 17, 2021, 6:08 AM

#

short snow I wanted to group all the dynamic question generator functions together, thought...

I'd move them to a module if you want to group them together

#

like

- module.py
+ module/
+     __init__.py 
+     cog.py
+     submodule.py

slim widget Aug 17, 2021, 6:56 AM

#

Do I need to be assigned a PR in order to review it?

#

On either of the main bots, that is.

short snow Aug 17, 2021, 6:57 AM

#

Nope, assignment is like when you are working on the pr

#

and review requests are like when someone specific are requested to do a review, for example i did some crazy devops stuff then i would need joe's approval on the pr

#

so joe would be requested a review

short snow Aug 17, 2021, 6:58 AM

#

celest charm I'd move them to a module if you want to group them together

yeah i will do that

molten perch Aug 17, 2021, 9:58 AM

#

I checked out bot#1748 and modified my PR bot#1749 accordingly, so even if the bot replies to a reminder it'll still include a jump_url and if it can't reply, it falls back to just pinging and sending the original embed. This way reminders can be allowed in every channel. Is that fine? 😄

dusky shoreBOT Aug 17, 2021, 9:58 AM

#

GitHub

IssueOpen Allow reminders in all channels
PROpen Update reminders to reply instead of using a jump url to the origin message

celest charm Aug 17, 2021, 10:47 AM

#

@outer plaza

wrong channel, check out #❓｜how-to-get-help
we're not going to help you make a keylogger, please read our #rules

clever wraith Aug 17, 2021, 1:43 PM

#

celest charm <@456226577798135808> not directly related to the PR, but > `_EXECUTOR = ThreadP...

no idea, i chose that because i saw it used in 8bitify

fallen patrol Aug 17, 2021, 1:47 PM

#

@patent pivot does king Arthur have a custom paginator yet?

patent pivot Aug 17, 2021, 1:48 PM

#

no, it doesn't need one

#

yet

fallen patrol Aug 17, 2021, 1:49 PM

#

molten perch I checked out bot#1748 and modified my PR bot#1749 accordingly, so even if the b...

IMO this is better, because sometimes the replies just don't load since they aren't in the cache or get fetched. So always including the jump url is a good idea imo

fallen patrol Aug 17, 2021, 1:49 PM

#

patent pivot no, it doesn't need one

Ah lol. well, I can make a pr to add one once I have this one working (writing for a different bot so no loss to me if you don't want it)

#

Using discord buttons, too

patent pivot Aug 17, 2021, 1:52 PM

#

interesting, but there is no use for it right now

short snow Aug 17, 2021, 2:13 PM

#

@timid sentinel how about the most-read articles of the day before? we could also include the on this day?

timid sentinel Aug 17, 2021, 2:36 PM

#

short snow <@493839819168808962> how about the most-read articles of the day before? we cou...

ooh, that sounds interesting. I think that could work quite well.

short snow Aug 17, 2021, 2:53 PM

#

timid sentinel ooh, that sounds interesting. I think that could work quite well.

right, am a bit busy this week, I will try to get it up by the end of this week. Both of the comments should be resolved by this change :D

timid sentinel Aug 17, 2021, 3:23 PM

#

Nice, no rush 👍

clever wraith Aug 17, 2021, 3:38 PM

#

while i wait for a merge for 760, ill work on cowsay

patent pivot Aug 17, 2021, 3:44 PM

#

sure

fallen patrol Aug 17, 2021, 4:07 PM

#

Interactions are fun but I'm not a huge fan of the discord.ui.View class

molten perch Aug 17, 2021, 4:08 PM

#

I think it's pretty fair and straightforward, but dpy 2 is not stable just now 😄

#

https://discordpy.readthedocs.io/en/master/

thorny obsidian Aug 17, 2021, 4:09 PM

#

-_- for whatever reason the master docs isn't possible to get to without know the URL. It doesn't appear as a dropdown on the docs page.

fallen patrol Aug 17, 2021, 4:09 PM

#

molten perch I think it's pretty fair and straightforward, but dpy 2 is not stable just now �...

Ehhhh, I would consider it stable enough to use but a production bot probably shouldn't run it

thorny obsidian Aug 17, 2021, 4:09 PM

#

I complained about this bitterly last week

fallen patrol Aug 17, 2021, 4:10 PM

#

thorny obsidian -_- for whatever reason the `master` docs isn't possible to get to without know ...

Yeah, it's an option on read the docs hosting to hide a docs build

molten perch Aug 17, 2021, 4:10 PM

#

I'm not even sure how I found it 😄

vocal prairie Aug 17, 2021, 4:10 PM

#

Oh, I've been looking at latest in the dropdown

#

oops

thorny obsidian Aug 17, 2021, 4:10 PM

#

Yup nope, fucking d.py and their docs. One day they'll actually be good.

molten perch Aug 17, 2021, 4:10 PM

#

Oh, it was posted on the dpy server 😄

#

You might want to take a look at the examples in their repo it helped me a lot.
https://github.com/Rapptz/discord.py/tree/master/examples/views

vale ibex Aug 17, 2021, 4:17 PM

#

thorny obsidian -_- for whatever reason the `master` docs isn't possible to get to without know ...

you don't know every url?

#

never said I knew every url

#

kek

brisk brook Aug 17, 2021, 4:30 PM

#

fallen patrol Interactions are fun but I'm not a huge fan of the discord.ui.View class

Same ;-;