vale ibex Aug 11, 2021, 11:10 AM

#

it doesn't make a new channel object right?

static canyon Aug 11, 2021, 11:10 AM

#

Eh

#

https://sourcegraph.com/github.com/python-discord/bot/-/blob/bot/exts/help_channels/_channel.py?L158-L159

#

Only sometimes

vale ibex Aug 11, 2021, 11:10 AM

#

The issue is this call ```py
# We use d.py's method to ensure our request is processed by d.py's rate limit manager
await bot.instance.http.bulk_channel_update(category.guild.id, payload)

#

doesn't update the channel in cache with the changes

static canyon Aug 11, 2021, 11:11 AM

#

Can you not do channel.edit(position=x) instead? (which would return the new channel object)

vale ibex Aug 11, 2021, 11:11 AM

#

I think we did before

#

and this change was due to issues with that

#

from the doc string ```
To ensure "stable sorting", we use the bulk_channel_update endpoint and provide the current
positions of the other channels in the category as-is. This should make sure that the channel
really ends up at the bottom of the category.

#

I'm guessing that has a story behind it

static canyon Aug 11, 2021, 11:12 AM

#

Presumably some sort of bug with dpy

vale ibex Aug 11, 2021, 11:12 AM

#

new_raw_channel = await bot.instance.http.bulk_channel_update(category.guild.id, payload)
channel._update(channel.guild, new_raw_channel)

#

seems dirty

viscid coral Aug 11, 2021, 11:12 AM

#

Why not do channel.category again?

static canyon Aug 11, 2021, 11:13 AM

#

viscid coral Why not do channel.category again?

channel isn't updated in cache so has the category of before it was moved (In-Use help channels)

viscid coral Aug 11, 2021, 11:13 AM

#

Why isn't it updated?

static canyon Aug 11, 2021, 11:13 AM

#

Because we don't update it 🤷

viscid coral Aug 11, 2021, 11:13 AM

#

Doesn't dpy already does that?

vale ibex Aug 11, 2021, 11:14 AM

#

we call the http method of d.py directly

#

skipping the cache update

static canyon Aug 11, 2021, 11:14 AM

#

Gimme few minutes, gonna try look for something

brisk brook Aug 11, 2021, 11:14 AM

#

What are you talking about?

#

The .move method?

vale ibex Aug 11, 2021, 11:14 AM

#

It's probably just easier to do the same as what we have for available_category

#

for the dormant category

vale ibex Aug 11, 2021, 11:15 AM

#

brisk brook The `.move` method?

to move help channels we have a move_to_bottom function

#

which calls the http build edit endpoint directly

#

which skips updating the channel in cache

#

which led to my review comment on the pr in #dev-log

static canyon Aug 11, 2021, 11:16 AM

#

Doesn't changing the category automatically move it to the bottom?

viscid coral Aug 11, 2021, 11:16 AM

#

Pretty sure it does

#

So just channel.edit(category=CategoryChannel) no?

#

I am not really good in dpy stuff honestly

static canyon Aug 11, 2021, 11:18 AM

#

static canyon Doesn't changing the category automatically move it to the bottom?

Can you test this? @vale ibex

brazen charm Aug 11, 2021, 11:18 AM

#

the whole category moving was a mess so I don't think it's using that method for nothing

static canyon Aug 11, 2021, 11:20 AM

#

I personally don't see the issue with await channel.edit(category=dormant_category)

#

But then at that point we're getting the dormant_category object which kinda defeats the purpose of doing that in the first place

viscid coral Aug 11, 2021, 11:21 AM

#

Okay there is a problem

#

I tested it in my bot and it moved it to the top of the category

static canyon Aug 11, 2021, 11:24 AM

#

welp there goes that idea

#

What happens if you do position=-1 out of interest? @viscid coral

viscid coral Aug 11, 2021, 11:24 AM

#

It says it can't be under 0

#

I am trying somehting with len(category.channels)

static canyon Aug 11, 2021, 11:25 AM

#

Tbh this defeats the entire purpose

viscid coral Aug 11, 2021, 11:25 AM

#

But don't know if it's possible

static canyon Aug 11, 2021, 11:25 AM

#

The purpose of doing this was to not have to get the category object

viscid coral Aug 11, 2021, 11:26 AM

#

Yeah

brazen charm Aug 11, 2021, 11:26 AM

#

https://github.com/python-discord/bot/commit/b0c07a9e5212ce38c2237b0b1294c344602d5d6f

static canyon Aug 11, 2021, 11:26 AM

#

I can just try_get_channel(constants.Categories.help_dormant) or whatever it is and do .name

static canyon Aug 11, 2021, 11:27 AM

#

brazen charm <https://github.com/python-discord/bot/commit/b0c07a9e5212ce38c2237b0b1294c34460...

thank you 👍

vale ibex Aug 11, 2021, 11:28 AM

#

That's a beautiful commit

short snow Aug 11, 2021, 11:31 AM

#

very beautiful

static canyon Aug 11, 2021, 11:37 AM

#

Thanks Chrisjl 👍

brazen charm Aug 11, 2021, 11:39 AM

#

pass in --author="whatever", what do you need it for?

#

amend it with the flag set then, although I'm not sure what you mean with signing in as the author is just a normal field of the commit

static canyon Aug 11, 2021, 12:28 PM

#

bot#1736 doesn't seem to have closed even though bot#1738 was merged

dusky shoreBOT Aug 11, 2021, 12:28 PM

#

GitHub

IssueOpen Dynamically insert help categories into DORMANT_MSG
PRMerged Make DORMANT_MSG Dynamic

static canyon Aug 11, 2021, 12:29 PM

#

I suppose I should've done "Closes" or something rather than "Solves"

vale ibex Aug 11, 2021, 12:31 PM

#

yea, only these words work close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved

static canyon Aug 11, 2021, 12:31 PM

#

Right, makes sense. Thanks

gritty wind Aug 11, 2021, 12:31 PM

#

Fixed

static canyon Aug 11, 2021, 12:32 PM

#

gritty wind Fixed

Thanks 👍

vale ibex Aug 11, 2021, 12:32 PM

#

#help-donut message

#

the line break is annoying, but oh well

static canyon Aug 11, 2021, 12:34 PM

#

It already had a line break? Old message: #help-lollipop message

vale ibex Aug 11, 2021, 12:34 PM

#

yea, I guess its just the emoji being a part of it now makes it look off to me

#

since before the text was bold, so it seems part of the same thing

static canyon Aug 11, 2021, 12:36 PM

#

I'm not following

#

It's still bold

#

Or do you mean the emoji isn't bold?

vale ibex Aug 11, 2021, 12:37 PM

#

Since the emoji barely looks any different when it's bold or not, it doesn't look connected to the line below at a glance

#

whereas before you could tell the two parts of the category name were the same thing, since they were bold

#

I don't think it's a huge issue though

static canyon Aug 11, 2021, 12:38 PM

#

Right, yeah

#

There's not much we can do about that other than moving the entire name onto the next line, but then you'd have a weird gap

vale ibex Aug 11, 2021, 12:38 PM

#

I guess we could replace the spaces with non break space chars

#

in the category name

#

!charinfo

stable mountainBOT Aug 11, 2021, 12:39 PM

#

Missing required argument

characters

#

Command Help

!charinfo <characters>
Shows you information on up to 50 unicode characters.

static canyon Aug 11, 2021, 12:39 PM

#

Non break space chars? So forces it to not change line?

vale ibex Aug 11, 2021, 12:39 PM

#

!charinfo non-breaking space

stable mountainBOT Aug 11, 2021, 12:39 PM

#

Character Info

\u006e : LATIN SMALL LETTER N - n
\u006f : LATIN SMALL LETTER O - o
\u006e : LATIN SMALL LETTER N - n
\u002d : HYPHEN-MINUS - -
\u0062 : LATIN SMALL LETTER B - b
\u0072 : LATIN SMALL LETTER R - r
\u0065 : LATIN SMALL LETTER E - e
\u0061 : LATIN SMALL LETTER A - a
\u006b : LATIN SMALL LETTER K - k
\u0069 : LATIN SMALL LETTER I - i

Full Raw Text

\u006e\u006f\u006e\u002d\u0062\u0072\u0065\u0061\u006b\u0069\u006e\u0067\u0020\u0073\u0070\u0061\u0063\u0065

static canyon Aug 11, 2021, 12:39 PM

#

lol

vale ibex Aug 11, 2021, 12:39 PM

#

oh, the discord editor changes it

#

in client

static canyon Aug 11, 2021, 12:40 PM

#

!charinfo

stable mountainBOT Aug 11, 2021, 12:40 PM

#

Missing required argument

characters

#

Command Help

!charinfo <characters>
Shows you information on up to 50 unicode characters.

static canyon Aug 11, 2021, 12:40 PM

#

yeah

vale ibex Aug 11, 2021, 12:40 PM

#

\u00a0

static canyon Aug 11, 2021, 12:40 PM

#

If discord changes it would it even make a difference?

vale ibex Aug 11, 2021, 12:40 PM

#

i think it's a client side change in the text editor

#

I'll check with my bot

static canyon Aug 11, 2021, 12:40 PM

#

👍

#

If it does make a difference then I can PR that

vale ibex Aug 11, 2021, 12:46 PM

#

oh

#

there aren't spaces

#

it uses a \uff5c : FULLWIDTH VERTICAL LINE - ｜

#

which i guess is a line breaking char

stable mountainBOT Aug 11, 2021, 12:47 PM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

static canyon Aug 11, 2021, 12:48 PM

#

vale ibex which i guess is a line breaking char

Right, yeah. So it wouldn't work then

#

Also for bot#1739 do we just want like ```py
content = reminder['content']
if not content.endswith(("?", "!", ".")):
content += "."

send content

dusky shoreBOT Aug 11, 2021, 12:48 PM

#

GitHub

IssueOpen Nit: Reminders always have a "." added to the end even if already punctuated

short snow Aug 11, 2021, 12:48 PM

#

don't punctuate it imo

#

let it be what the user had kept originally

static canyon Aug 11, 2021, 12:50 PM

#

I mean at the moment we take the stance of punctuating it for them

#

Is that something we want to change?

#

If so we can just get rid of the "." in the string

cold island Aug 11, 2021, 1:00 PM

#

I'd rather just not add punctuation

dim pelican Aug 11, 2021, 1:05 PM

#

Silly question, how would one create a new branch? For example I recently wrote the Real Python Issue and PR, but I could not figure out how to create a branch from Sir-Lancebot (I made one on my local forked repo but is it possible to do the same for the main?)

patent pivot Aug 11, 2021, 1:05 PM

#

You don't make a branch on our copy of the repo, you PR from your repo to ours

dim pelican Aug 11, 2021, 1:06 PM

#

Sweet, so I followed the workflow I was supposed to 👍

patent pivot Aug 11, 2021, 1:06 PM

#

Branches get made on our repos when a staff member contribute, for regular contributors your changes come from the fork

#

yep

#

you can make a branch on your repo and PR to ours or you can PR directly from your main to our main

dim pelican Aug 11, 2021, 1:07 PM

#

Thanks joe!

static canyon Aug 11, 2021, 1:16 PM

#

cold island I'd rather just not add punctuation

Should I PR this then?

cold island Aug 11, 2021, 2:07 PM

#

static canyon Should I PR this then?

I guess.. not sure what others think

static canyon Aug 11, 2021, 2:11 PM

#

cold island I guess.. not sure what others think

I mean I agree with this personally (and so did Jason above). Is there a strong reason to add punctuation?

#

If there's no strong argument against I'll go for it

green oriole Aug 11, 2021, 2:54 PM

#

I'd just remove automatic punctuation

static canyon Aug 11, 2021, 2:59 PM

#

Yeah

#

I'll go ahead and do that 👍

green oriole Aug 11, 2021, 3:01 PM

#

Sounds good, thank you

static canyon Aug 11, 2021, 3:04 PM

#

Done, bot#1740

dusky shoreBOT Aug 11, 2021, 3:04 PM

#

GitHub

PROpen Remove added punctuation from reminder

static canyon Aug 11, 2021, 3:07 PM

#

If someone has time can they confirm/deny my comment I made on bot#1681? I think it's just a case of refactoring some old code that's redundant now but want to make sure before I change stuff

dusky shoreBOT Aug 11, 2021, 3:07 PM

#

GitHub

IssueOpen apply_infraction assumes the user will have a mention attribute

green oriole Aug 11, 2021, 3:12 PM

#

@static canyon about the discord.User converter won't fail, we are talking even if the user isn't in the guild, right?

static canyon Aug 11, 2021, 3:12 PM

#

green oriole <@442244135840382978> about the `discord.User` converter won't fail, we are talk...

Yes

#

Even if the user isn't in the server, it'll work (as of v1.6)

#

Which tbf makes sense since discord.User isn't guild-dependant

#

As long as it's a valid user id, it'll always fetch the user

green oriole Aug 11, 2021, 3:13 PM

#

Cool, cool

#

Yeah, in that case it sounds good 👍

static canyon Aug 11, 2021, 3:14 PM

#

Alright 👍

#

I'll start work on this

#

@green oriole do we want to keep redefining a Union for Union[discord.Member, discord.User] each time or use a variable from bot.converters?

green oriole Aug 11, 2021, 3:23 PM

#

Hmmmm

static canyon Aug 11, 2021, 3:23 PM

#

Currently we're doing a mixture of both so thought I'd ask

green oriole Aug 11, 2021, 3:24 PM

#

Probably a constant

static canyon Aug 11, 2021, 3:24 PM

#

Alright

#

Something like DiscordAccount = Union[discord.Member, discord.User]?

fervent sage Aug 11, 2021, 3:24 PM

#

if a user is fine for a function why do we even need member?

green oriole Aug 11, 2021, 3:24 PM

#

Yeah, sounds good

static canyon Aug 11, 2021, 3:24 PM

#

fervent sage if a user is fine for a function why do we even need member?

There may be cases where we need the guild? I'll look into it

viscid coral Aug 11, 2021, 3:24 PM

#

static canyon Something like `DiscordAccount = Union[discord.Member, discord.User]`?

Call it BaseUser lol

fervent sage Aug 11, 2021, 3:25 PM

#

in that case it would be logical to only use member, since user wouldnt have a guild

static canyon Aug 11, 2021, 3:25 PM

#

But you might still want to run even if they aren't in the guild

#

I'll look into it and see

fervent sage Aug 11, 2021, 3:25 PM

#

but if you have Member|User surely User will always suffice since its the lowerst common thing

static canyon Aug 11, 2021, 3:25 PM

#

It probably is redundant

green oriole Aug 11, 2021, 3:25 PM

#

We gate some features behind a member isintance check I think

static canyon Aug 11, 2021, 3:26 PM

#

This is gonna be painful to see if it's redundant or not because each file calls the Union something different lol

#

In fact, the only times .guild are joined where it's on a Member is on on_member_join so it should be fine

#

Since that's the only think a Member has that a User doesn't

#

Or I guess joined_at and nick / display_name

gritty wind Aug 11, 2021, 3:31 PM

#

What about performing guild operations such as bans and role applying

static canyon Aug 11, 2021, 3:31 PM

#

Okay I found a case where it might be an issue

#

async def create_user_embed(self, ctx: Context, user: FetchedMember) -> Embed:
        """Creates an embed containing information on the `user`."""
        on_server = bool(ctx.guild.get_member(user.id))
        ...
        if on_server and user.nick:
            name = f"{user.nick} ({name})"

        ...

        if on_server:
            joined = discord_timestamp(user.joined_at, TimestampFormats.RELATIVE)
            ...
        ...```here different things are done depending on whether it's a Member or User

gritty wind Aug 11, 2021, 3:33 PM

#

Cache a concern?

static canyon Aug 11, 2021, 3:33 PM

#

So this is an example where we need user: Union[discord.Member, discord.User] @fervent sage

static canyon Aug 11, 2021, 3:34 PM

#

gritty wind Cache a concern?

What do you mean?

gritty wind Aug 11, 2021, 3:34 PM

#

Can we end up in a situation where we don’t get a member object for someone who is actually on server

static canyon Aug 11, 2021, 3:34 PM

#

No

#

The MemberConverter will fetch_member, which always get the Member, even if not in cache

gritty wind Aug 11, 2021, 3:34 PM

#

I also feel like I’m missing context here, why is this refractor happening?

static canyon Aug 11, 2021, 3:35 PM

#

gritty wind I also feel like I’m missing context here, why is this refractor happening?

There was a change in V1.6 of dpy (fetches discord.User from id even if not in server) which makes some of our converters redundant, so I'm removing them

viscid coral Aug 11, 2021, 3:35 PM

#

bot#1681 I think?

dusky shoreBOT Aug 11, 2021, 3:35 PM

#

GitHub

IssueOpen apply_infraction assumes the user will have a mention attribute

viscid coral Aug 11, 2021, 3:35 PM

#

static canyon There was a change in V1.6 of dpy (fetches `discord.User` from id even if not in...

What converter for example?

static canyon Aug 11, 2021, 3:37 PM

#

viscid coral What converter for example?

E.g. https://github.com/python-discord/bot/blob/main/bot/converters.py#L483-L492

stable mountainBOT Aug 11, 2021, 3:37 PM

#

bot/converters.py lines 483 to 492

class FetchedUser(UserConverter):
    """
    Converts to a `discord.User` or, if it fails, a `discord.Object`.

    Unlike the default `UserConverter`, which only does lookups via the global user cache, this
    converter attempts to fetch the user via an API call to Discord when the using the cache is
    unsuccessful.

    If the fetch also fails and the error doesn't imply the user doesn't exist, then a
    `discord.Object` is returned via the `user_proxy` converter.```

static canyon Aug 11, 2021, 3:37 PM

#

That fetches from API but UserConverter will automatically do it

viscid coral Aug 11, 2021, 3:39 PM

#

Oh yeah

static canyon Aug 11, 2021, 3:39 PM

#

Can I please get reviews on bot#1740 by the way? It's literally just removing a "." that we decided we don't want

dusky shoreBOT Aug 11, 2021, 3:39 PM

#

GitHub

PROpen Remove added punctuation from reminder

viscid coral Aug 11, 2021, 3:41 PM

#

I'll do it now for bot#1740

#

Sad green check mark, without the green lmfao

fervent sage Aug 11, 2021, 3:49 PM

#

static canyon Can I please get reviews on bot#1740 by the way? It's literally just removing a ...

done :P

static canyon Aug 11, 2021, 3:54 PM

#

fervent sage done :P

thank you 😄

#

Probably the hardest review for you yet :p

#

https://github.com/python-discord/bot/tree/main/bot/exts/moderation/infraction/management.py#L204

GitHub

bot/management.py at main · python-discord/bot

The community bot for the Python Discord community - bot/management.py at main · python-discord/bot

#

Am I able to change query: t.Union[UserMention, Snowflake, str]) to query: FetchedMember here? @green oriole

green oriole Aug 11, 2021, 4:00 PM

#

.... Excellent question

static canyon Aug 11, 2021, 4:00 PM

#

Ah wait no

green oriole Aug 11, 2021, 4:00 PM

#

We still want string search

static canyon Aug 11, 2021, 4:00 PM

#

Yeah

#

So t.Union[FetchedMember, str] I guess

green oriole Aug 11, 2021, 4:00 PM

#

So FetchedMember | str

#

Yup

viscid coral Aug 11, 2021, 4:03 PM

#

btw

green oriole Aug 11, 2021, 4:03 PM

#

What should I be looking at?

viscid coral Aug 11, 2021, 4:04 PM

#

There is no . at the end it's good lol

green oriole Aug 11, 2021, 4:06 PM

#

Oh nice

molten perch Aug 11, 2021, 4:18 PM

#

Btw. Instead of linking to the original message where the reminder was invoked, can't we just reply to the original message? 🙂

viscid coral Aug 11, 2021, 4:20 PM

#

We do have the message jump url, and to get the message object would mean we will have to make an API call

#

I feel like I am wrong

green oriole Aug 11, 2021, 4:21 PM

#

That sounds doable. I feel like a partial message is enough for replies, isn't it?

#

One api call is nothing either way

#

!source remind

stable mountainBOT Aug 11, 2021, 4:21 PM

#

Command: remind

Commands for managing your reminders.

Source Code

Go to GitHub

green oriole Aug 11, 2021, 4:22 PM

#

Yeah we guarantee to be in the same channel

#

Do you wanna open an issue for this @molten perch?

viscid coral Aug 11, 2021, 4:23 PM

#

!d discord.TextChannel.get_partial_message right?

stable mountainBOT Aug 11, 2021, 4:23 PM

#

discord.TextChannel.get\_partial\_message


get_partial_message(message_id)```
Creates a [`PartialMessage`](https://discordpy.readthedocs.io/en/stable/api.html#discord.PartialMessage "discord.PartialMessage") from the message ID.

This is useful if you want to work with a message and only have its ID without doing an unnecessary API call.

New in version 1.6.

molten perch Aug 11, 2021, 4:23 PM

#

green oriole Do you wanna open an issue for this <@263957159807549450>?

Yeah, sure! 😄

viscid coral Aug 11, 2021, 4:24 PM

#

Why not a PR with the solution right away?

molten perch Aug 11, 2021, 4:24 PM

#

I feel like that's not the convention 😄

green oriole Aug 11, 2021, 4:24 PM

#

viscid coral Why not a PR with the solution right away?

It is easier to keep track who is doing what

viscid coral Aug 11, 2021, 4:24 PM

#

Oh ok

#

There is ont problem tho

#

If you do discord.TextChannel.get_partial_message(1), it'll really create a PartialMessage, and if you try to reference it, it'll error

green oriole Aug 11, 2021, 4:27 PM

#

Yes, we need the right try/except in case the message has been deleted

molten perch Aug 11, 2021, 4:27 PM

#

So here

        reminder = await self.bot.api_client.post(
            'bot/reminders',
            json={
                'author': ctx.author.id,
                'channel_id': ctx.message.channel.id,
                'jump_url': ctx.message.jump_url,
                'content': content,
                'expiration': expiration.isoformat(),
                'mentions': mention_ids,
            }
        )```
Instead of sending the jump_url, send the message_id? I feel like that should work, and the channel ID is already there.

viscid coral Aug 11, 2021, 4:28 PM

#

Get the channel using Bot.get_channel, and than get_partial_message

green oriole Aug 11, 2021, 4:28 PM

#

Yeah, I guess we can change that but we need to update the site toooooo.. and I'm not sure if we should

#

I'd have to ask Sebastiaan but he is on vacations for now

#

You can get a partial channel too iirc

viscid coral Aug 11, 2021, 4:29 PM

#

green oriole You can get a partial channel too iirc

I don't think that exists

green oriole Aug 11, 2021, 4:29 PM

#

Let's put that on an halt until we know if we can modify the site schema to be a message ID instead. Or we continue to use the jump url but that sounds a bit silly.

molten perch Aug 11, 2021, 4:30 PM

#

~~I guess.. a message ID can qualify as a "jump_url"~~ I agree.

#

But I'll open the issue anyways, so that I won't forget it.

viscid coral Aug 11, 2021, 4:31 PM

#

viscid coral If you do discord.TextChannel.get_partial_message(1), it'll really create a Part...

Ok, I'll comment that there as well

molten perch Aug 11, 2021, 4:35 PM

#

bot#1741
Here it is.

dusky shoreBOT Aug 11, 2021, 4:35 PM

#

GitHub

IssueOpen Reply to the original message where the reminder was invoked instead of using a jump url

green oriole Aug 11, 2021, 4:36 PM

#

!remind 5d Ask Sebastiaan if he is back from vacations

stable mountainBOT Aug 11, 2021, 4:36 PM

#

Okay.

Your reminder will arrive <t:1629131778:R>!

static canyon Aug 11, 2021, 4:41 PM

#

@green oriole FetchedMember = Union[discord.Member, discord.User] do you think this is a good enough converter name? I'm wondering since it's not strictly a Member that it's fetching. Thought maybe like DiscordAccount of something but that seemed weird. NIR suggested BaseUser earlier which may be good

viscid coral Aug 11, 2021, 4:42 PM

#

I suggested BaseUser because it's the parent class( I think this is what it's called) of User and Member

green oriole Aug 11, 2021, 4:42 PM

#

If it was just me I'd call it MemberOrUser haha

static canyon Aug 11, 2021, 4:42 PM

#

lol

viscid coral Aug 11, 2021, 4:43 PM

#

class Member(BaseUser):```
That means the `Member` parent class is `BaseUser` right?

static canyon Aug 11, 2021, 4:43 PM

#

Yeah

#

Parent/base class

viscid coral Aug 11, 2021, 4:43 PM

#

Yeah ok thanks

#

So that is why I suggested it

static canyon Aug 11, 2021, 4:43 PM

#

viscid coral ```py class Member(BaseUser):``` That means the `Member` parent class is `BaseUs...

>>> discord.Member.__bases__
(<class 'discord.abc.Messageable'>, <class 'discord.abc.User'>)
```base is more pythonic since that's the dunder, not `__parents__`

viscid coral Aug 11, 2021, 4:44 PM

#

Ohh ok

static canyon Aug 11, 2021, 4:44 PM

#

So in dpy it's actually Member(User) and then User(BaseUser) I believe

viscid coral Aug 11, 2021, 4:44 PM

#

Yeah I just checked the docs

#

The source*

static canyon Aug 11, 2021, 4:45 PM

#

I mean I'm surprisingly tempted by MemberOrUser lol

viscid coral Aug 11, 2021, 4:45 PM

#

It subclasses Messageable and _UserTag

viscid coral Aug 11, 2021, 4:45 PM

#

static canyon I mean I'm surprisingly tempted by `MemberOrUser` lol

lol sounds ok amazing ig

static canyon Aug 11, 2021, 4:46 PM

#

Maybe wait for someone else's feedback

celest charm Aug 11, 2021, 4:47 PM

#

@static canyon If Member is a subclass of User, then Union[Member, User] is the same as User

#

right?

static canyon Aug 11, 2021, 4:48 PM

#

celest charm <@!442244135840382978> If `Member` is a subclass of `User`, then `Union[Member, ...

Nope

celest charm Aug 11, 2021, 4:48 PM

#

wait, there are two different User classes?

static canyon Aug 11, 2021, 4:48 PM

#

What you're thinking of would be Union[User, Member]

#

A Member will match Member, but User won't

#

Member will match User
User will NOT match Member

celest charm Aug 11, 2021, 4:48 PM

#

Union[User, Member] is the same as Union[User, Member]

#

wait... I'm misunderstanding a bit

static canyon Aug 11, 2021, 4:49 PM

#

static canyon `Member` will match `User` `User` will NOT match `Member`

TLDR; this

viscid coral Aug 11, 2021, 4:49 PM

#

celest charm `Union[User, Member]` is the same as `Union[User, Member]`

What?

static canyon Aug 11, 2021, 4:49 PM

#

It's like doing Union[float, int]

celest charm Aug 11, 2021, 4:49 PM

#

I didn't realize you were talking about converters, sorry

static canyon Aug 11, 2021, 4:49 PM

#

All floats are integers, but not all integers are floats

#

So it works

green oriole Aug 11, 2021, 4:50 PM

#

Yeah, that's a d.py thing

#

For typing User is enough

celest charm Aug 11, 2021, 4:50 PM

#

yeah I'm already used to d.py being weird

static canyon Aug 11, 2021, 4:50 PM

#

Oh right

#

~~I learnt typehints through dpy so didn't realise that~~

viscid coral Aug 11, 2021, 4:50 PM

#

Lol everyone here is a Moderator the entire chat is orange

static canyon Aug 11, 2021, 4:50 PM

#

celest charm I didn't realize you were talking about converters, sorry

What do you think a good name would be though?

viscid coral Aug 11, 2021, 4:51 PM

#

static canyon ~~I learnt typehints through dpy so didn't realise that~~

lol, I learnt Python through dpy

celest charm Aug 11, 2021, 4:51 PM

#

static canyon What do you think a good name would be though?

UserOrMember

viscid coral Aug 11, 2021, 4:51 PM

#

lol

celest charm Aug 11, 2021, 4:51 PM

#

I mean... it's the most clear and unambiguous way

static canyon Aug 11, 2021, 4:51 PM

#

Yeah

viscid coral Aug 11, 2021, 4:51 PM

#

static canyon I mean I'm surprisingly tempted by `MemberOrUser` lol

@celest charm lmfao

static canyon Aug 11, 2021, 4:51 PM

#

I like it too to be honest

celest charm Aug 11, 2021, 4:51 PM

#

this is not an English writing class

static canyon Aug 11, 2021, 4:52 PM

#

MemberOrUser though since tries to convert to Member first

celest charm Aug 11, 2021, 4:52 PM

#

if you name your class FuckingMess and it's the most descriptive name, then you're good to go

static canyon Aug 11, 2021, 4:52 PM

#

rofl

celest charm Aug 11, 2021, 4:52 PM

#

static canyon MemberOrUser though since tries to convert to Member first

right
I'd also add a comment about it not being redundant to just User because it's confusing

static canyon Aug 11, 2021, 4:53 PM

#

celest charm right I'd also add a comment about it not being redundant to just `User` because...

Alright 👍

#

I'm gonna go with MemberOrUser, thanks everyone

celest charm Aug 11, 2021, 4:53 PM

#

MemberOrUser ^

static canyon Aug 11, 2021, 4:53 PM

#

Yeah

green oriole Aug 11, 2021, 4:53 PM

#

Since it is in converters.py it should make sense I think, but a comment doesn't hurt

static canyon Aug 11, 2021, 4:53 PM

#

~~time to rename all the stuff that I literally just renamed~~

green oriole Aug 11, 2021, 4:53 PM

#

Well at least your IDE can do the work now

static canyon Aug 11, 2021, 4:54 PM

#

Erm

celest charm Aug 11, 2021, 4:54 PM

#

yeah, most editors have a rename function

static canyon Aug 11, 2021, 4:54 PM

#

~~Definitely not editing from GitHub website~~

celest charm Aug 11, 2021, 4:54 PM

#

lemon_cut

green oriole Aug 11, 2021, 4:54 PM

#

lemon_eyes

static canyon Aug 11, 2021, 4:54 PM

#

rofl

green oriole Aug 11, 2021, 4:54 PM

#

The poor commit history

celest charm Aug 11, 2021, 4:54 PM

#

yeah, testing is for losers

#

YOLO

static canyon Aug 11, 2021, 4:54 PM

#

Linting + Chris has always done the testing for me xD

green oriole Aug 11, 2021, 4:54 PM

#

Smh

celest charm Aug 11, 2021, 4:55 PM

#

do you need to spin up docker to run tests?

#

also, what's our test coverage?

static canyon Aug 11, 2021, 4:56 PM

#

Time to make 57 rename commits ducky_bike

celest charm Aug 11, 2021, 4:56 PM

#

AAAAAAAaaaaaaaaaaaaaa

green oriole Aug 11, 2021, 4:56 PM

#

celest charm also, what's our test coverage?

50 some

#

Are you in the github codespaces preview Tizzy lol

static canyon Aug 11, 2021, 4:58 PM

#

https://github.com/python-discord/bot/edit/remove-redundant-converters/bot/exts/moderation/infraction/_utils.py

#

As an example

#

Literally just doing it on GitHub because I can't remember how to do git

green oriole Aug 11, 2021, 4:58 PM

#

lol

#

Need help?

#

Get help!

dim pelican Aug 11, 2021, 4:58 PM

#

He gits it

static canyon Aug 11, 2021, 4:59 PM

#

I got dinner first but I'll @ you when I get back if that's okay lol

#

I will try and do in IDE for the 57 edits because otherwise the commit history is going to die lemon_cut

static canyon Aug 11, 2021, 5:23 PM

#

@green oriole are you free?

green oriole Aug 11, 2021, 5:25 PM

#

Hmmmmmmmm

#

Maybe, let's try

#

Do you have the repo cloned yet?

static canyon Aug 11, 2021, 5:27 PM

#

Nope

#

git clone url but I don't know how to do a specific branch @green oriole

green oriole Aug 11, 2021, 5:28 PM

#

Yes, you need to clone the whole repository

#

When you have the repository you work inside of branches

#

You have many branch per local repo

static canyon Aug 11, 2021, 5:28 PM

#

Right okay

#

So the url would be GitHub.com/python-discord/bot?

viscid coral Aug 11, 2021, 5:28 PM

#

This seem weird... Wasn't it just edited before?

green oriole Aug 11, 2021, 5:29 PM

#

static canyon So the url would be `GitHub.com/python-discord/bot`?

Yes, I think you need the https schema though

viscid coral Aug 11, 2021, 5:29 PM

#

Like this

green oriole Aug 11, 2021, 5:29 PM

#

viscid coral This seem weird... Wasn't it just edited before?

I think it happened because discord returned an error, so it felt back on using a second message

vale ibex Aug 11, 2021, 5:30 PM

#

Do you have an ssh key setup tizzy?

static canyon Aug 11, 2021, 5:30 PM

#

vale ibex Do you have an ssh key setup tizzy?

Nope

static canyon Aug 11, 2021, 5:30 PM

#

green oriole Yes, I think you need the https schema though

Done 👍

vale ibex Aug 11, 2021, 5:30 PM

#

Ah alright, only mention it as it's easier to use ssh (no need for a password every time)

static canyon Aug 11, 2021, 5:30 PM

#

How would I do that? @vale ibex

vale ibex Aug 11, 2021, 5:30 PM

#

What os?

green oriole Aug 11, 2021, 5:30 PM

#

I think password auth is disabled now

static canyon Aug 11, 2021, 5:30 PM

#

Win10

vale ibex Aug 11, 2021, 5:31 PM

#

open terminal

#

and run ssh-keygen

green oriole Aug 11, 2021, 5:31 PM

#

Well, seems like Chris is handling it

vale ibex Aug 11, 2021, 5:31 PM

#

and accept all the defaults

green oriole Aug 11, 2021, 5:31 PM

#

The defaults suck though

thorny obsidian Aug 11, 2021, 5:31 PM

#

vale ibex Ah alright, only mention it as it's easier to use ssh (no need for a password ev...

PAT or bust tbh

vale ibex Aug 11, 2021, 5:32 PM

#

I've never used PAT actually lol

static canyon Aug 11, 2021, 5:32 PM

#

vale ibex and accept all the defaults

Done

vale ibex Aug 11, 2021, 5:33 PM

#

cat out ~/.ssh/id_rsa.pub

viscid coral Aug 11, 2021, 5:33 PM

#

What is ssh? What are you even talking about lol

vale ibex Aug 11, 2021, 5:33 PM

#

and goto https://github.com/settings/keys

static canyon Aug 11, 2021, 5:33 PM

#

vale ibex cat out `~/.ssh/id_rsa.pub`

cat is linux I don't know windows equiv

vale ibex Aug 11, 2021, 5:33 PM

#

cat works on powershell too

#

or are you on cmd?

wise oriole Aug 11, 2021, 5:33 PM

#

works on cmd also

static canyon Aug 11, 2021, 5:33 PM

#

vale ibex or are you on cmd?

yeah

#

old one

vale ibex Aug 11, 2021, 5:34 PM

#

use type

static canyon Aug 11, 2021, 5:34 PM

#

vale ibex Aug 11, 2021, 5:34 PM

#

vale ibex and goto <https://github.com/settings/keys>

once you're here click New ssh key and paste in the whole ssh key

#

try type C:\Users\tizzy\.ssh\id_rsa.pub

#

maybe cmd doesn't like ~ for home

static canyon Aug 11, 2021, 5:35 PM

#

Yep, that works

vale ibex Aug 11, 2021, 5:35 PM

#

vale ibex once you're here click New ssh key and paste in the *whole* ssh key

.

#

Once that's done you can click the code button on the repo and choose the ssh tab

static canyon Aug 11, 2021, 5:35 PM

#

Including the @tizzy-DEVICE_NAME?

vale ibex Aug 11, 2021, 5:36 PM

#

yup

thorny obsidian Aug 11, 2021, 5:36 PM

#

static canyon

why not use powershell?

static canyon Aug 11, 2021, 5:36 PM

#

Because I opened command prompt first 🤷

vale ibex Aug 11, 2021, 5:36 PM

#

you're public key shouldlook like ```
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQDBYx/b++w2CpKyhSl0mY9lL6c093ghb5eD0uNPkgQTa5cCIaYy73q0w3uTmqoIDuaQk3eHVu0Jk2DvUH16u9f5jLXrMIAbeiQv6giPqyGdulqqJ4LsMCXT8xIV1myTpkXwlzJs6R48byOiupALTkO47MUGFMT+dUsKKSYQqZxdXr5EPxYLM0iziYuIvu2D8wF5Hc9HmL86/E6ScxO4iGGEq452k38hH7appQ9BIJDhDKnsxMm/povO7EBwm9q45b7ifnbiDKO+G041hYwpWx78b+ryUrvHoDv9jUjAHc2HDnN95fbXvbYPKRg2naf1A4Ra+4CKywE3sc/u3oZ9UJUHB3fEXir/MgviztrbSkxhMFwWckxEt6l6H3y71HQx0rFXnzYSuj1T647ntxZBeZZUnHw6DkKYbovLzXiOL4wMr9Xq/9tr7kGxEoKgvTYwk69Win8cQfncXyWfacV3311GNOPx6SCFYnWCVNODyPb+s8R8L+6GfGGRy0V8mEwSJu0= chris@DESKTOP-FEC9JN0

#

(it's fine to share public keys, that's the point)

#

Do not share id_rsa though

#

that's your private key

static canyon Aug 11, 2021, 5:37 PM

#

aight

vale ibex Aug 11, 2021, 5:37 PM

#

id_rsa=private id_rsa.pub=public

#

ok once it's all in git, you should be able to clone it with ssh

static canyon Aug 11, 2021, 5:37 PM

#

vale ibex ok once it's all in git, you should be able to clone it with ssh

It gives me git@github.com:python-discord/bot.git

vale ibex Aug 11, 2021, 5:38 PM

#

yup

static canyon Aug 11, 2021, 5:38 PM

#

What do I do with that?

vale ibex Aug 11, 2021, 5:38 PM

#

git clone git@github.com:python-discord/bot.git

static canyon Aug 11, 2021, 5:39 PM

#

vale ibex Aug 11, 2021, 5:39 PM

#

type yes and enter

#

you'll need to do that as it's the first time you've connected to github using ssh

static canyon Aug 11, 2021, 5:39 PM

#

vale ibex you'll need to do that as it's the first time you've connected to github using s...

Right yeah, fair enough

#

vale ibex Aug 11, 2021, 5:39 PM

#

cool

#

you should have a bot/ folder in that dir now

static canyon Aug 11, 2021, 5:39 PM

#

Yep

vale ibex Aug 11, 2021, 5:39 PM

#

nice

#

all that's left to do is set your git name and email

#

git config --global user.name "Mona Lisa"
git config --global user.email "email@example.com"

viscid coral Aug 11, 2021, 5:40 PM

#

Mona Lisa lol

vale ibex Aug 11, 2021, 5:40 PM

#

there is a private email addr you can use via github if you don't want to use your personal one

#

see https://docs.github.com/en/github/setting-up-and-managing-your-github-user-account/managing-email-preferences/setting-your-commit-email-address

#

I know a lot of people recommend git kraken for managing things locally

#

it's seems a lot more approachable than the command line

#

@thorny obsidian was a strong advocate for that 😛

static canyon Aug 11, 2021, 5:43 PM

#

vale ibex ``` git config --global user.name "Mona Lisa" git config --global user.email "em...

Done 👍

thorny obsidian Aug 11, 2021, 5:43 PM

#

:D GitKraken is fantastic for dealing with repos, especially with the student github pack thing

viscid coral Aug 11, 2021, 5:43 PM

#

lol github doesn't believe the I am a student

vale ibex Aug 11, 2021, 5:43 PM

#

static canyon Done 👍

do you have a prefered IDE/editor?

static canyon Aug 11, 2021, 5:44 PM

#

I generally use PyCharm

#

So I guess that

vale ibex Aug 11, 2021, 5:44 PM

#

sure, someone else might need to take over here, I don't use pycharm

#

probably best to stick with what you know rather than change now

static canyon Aug 11, 2021, 5:45 PM

#

I mean I've used loads of stuff

vale ibex Aug 11, 2021, 5:45 PM

#

it seems like jetbrains have a nice guide for it acutally

#

https://www.jetbrains.com/help/pycharm/using-git-integration.html

green oriole Aug 11, 2021, 5:45 PM

#

vale ibex you're public key shouldlook like ``` ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQDBYx...

key leak

vale ibex Aug 11, 2021, 5:45 PM

#

you can probably skip a few steps since we've already done it

vale ibex Aug 11, 2021, 5:46 PM

#

green oriole *key leak*

yea, it's a leak, definitely don't put it in your allowed hosts and give me the ip addr

static canyon Aug 11, 2021, 5:49 PM

#

Wait I've downloaded the repo but I want my branch @vale ibex

#

I've already created the branch and edited stuff from GitHub website

vale ibex Aug 11, 2021, 5:50 PM

#

static canyon Wait I've downloaded the repo but I want my branch <@!126811506632294400>

you should be able to check it out

#

https://www.jetbrains.com/help/pycharm/manage-branches.html

green oriole Aug 11, 2021, 5:50 PM

#

@vale ibex sounds good => ssh.akarys.me

vale ibex Aug 11, 2021, 5:50 PM

#

you'll find it under remote branches

viscid coral Aug 11, 2021, 5:53 PM

#

Can anyone review bot#1717 ? I opened it a week ago, just looking for opinion

dusky shoreBOT Aug 11, 2021, 5:53 PM

#

GitHub

IssueOpen Send message when help channel closed.

static canyon Aug 11, 2021, 5:53 PM

#

That seems to have worked

#

Thank you very much 👍

green oriole Aug 11, 2021, 5:55 PM

#

I'm surprised Chris didn't try to ssh yet lol

vale ibex Aug 11, 2021, 5:56 PM

#

I did, it timed out lol

#

PS C:\Users\Chris> ssh root@ssh.akarys.me
PS C:\Users\Chris> ssh chris@ssh.akarys.me
PS C:\Users\Chris> ssh ssh.akarys.me
PS C:\Users\Chris> ssh akarys@ssh.akarys.me
PS C:\Users\Chris>

green oriole Aug 11, 2021, 5:56 PM

#

lol

#

Now try to open the url in your browser

fallen patrol Aug 11, 2021, 5:57 PM

#

vale ibex sure, someone else might need to take over here, I don't use pycharm

what do you use?

static canyon Aug 11, 2021, 5:57 PM

#

I think I can PR my thing now actually

vale ibex Aug 11, 2021, 5:57 PM

#

vsc

vale ibex Aug 11, 2021, 5:57 PM

#

green oriole Now try to open the url in your browser

sadge

green oriole Aug 11, 2021, 5:57 PM

#

Hehe

static canyon Aug 11, 2021, 6:00 PM

#

GitHub web be like

#

Lovely commit history

vale ibex Aug 11, 2021, 6:00 PM

#

lol probably want to squash that

static canyon Aug 11, 2021, 6:00 PM

#

No clue how

green oriole Aug 11, 2021, 6:00 PM

#

Someone wrote a page on this

#

He writes okay stuff at best though

#

I don't like him

vale ibex Aug 11, 2021, 6:02 PM

#

lol

#

wasn't it you

#

https://www.notion.so/pythondiscord/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa

#

yes, yes it was

green oriole Aug 11, 2021, 6:02 PM

#

I wouldn't speak like that of everyone but Akarys

fallen patrol Aug 11, 2021, 6:03 PM

#

vale ibex <https://www.notion.so/pythondiscord/Squashing-a-Pull-Request-191e8efa2fbb4d7284...

damn why is this not public, the title seems great

green oriole Aug 11, 2021, 6:03 PM

#

Hmmmm

#

Let me check nobody else contributed to the page

#

And obviously Chris just edited it

vale ibex Aug 11, 2021, 6:04 PM

#

lmfao

#

we tend not to make pages public, since it leaks contributors emails

#

but only me and AK have edited it, so if Ak is alright with it then we can make this one public

fallen patrol Aug 11, 2021, 6:05 PM

#

commit messages are great 10/10 Tizzy
(You can change the commit message at the bottom of the github pages before commiting them)
((I used to do this for a long while))

vale ibex Aug 11, 2021, 6:05 PM

#

lol actually, Ak leaks his email in the page itself anyway

green oriole Aug 11, 2021, 6:05 PM

#

Yeah I'm fine with it

vale ibex Aug 11, 2021, 6:05 PM

#

kek

green oriole Aug 11, 2021, 6:05 PM

#

My email is public on github lol

fallen patrol Aug 11, 2021, 6:05 PM

#

yeah ak uses his email-- ^

static canyon Aug 11, 2021, 6:05 PM

#

fallen patrol commit messages are great 10/10 Tizzy (You can change the commit message at the...

I did change them lol

fallen patrol Aug 11, 2021, 6:05 PM

#

oh.

static canyon Aug 11, 2021, 6:05 PM

#

A commit message just highlights what you did, in the imperative mood (which is what those do)

vale ibex Aug 11, 2021, 6:05 PM

#

it be public

viscid coral Aug 11, 2021, 6:06 PM

#

viscid coral Can anyone review bot#1717 ? I opened it a week ago, just looking for opinion

?

fallen patrol Aug 11, 2021, 6:06 PM

#

wait that's actually a useful guide @green oriole

green oriole Aug 11, 2021, 6:07 PM

#

I would like y'all to take half a second to appreciate that I found the image of an industrial press to use as the page cover. Thank you.

green oriole Aug 11, 2021, 6:07 PM

#

fallen patrol wait that's actually a useful guide <@!407110650217627658>

Thank you! akarys_heart

fallen patrol Aug 11, 2021, 6:07 PM

#

i thought it was just gonna be press the squash merge button 😂

vale ibex Aug 11, 2021, 6:07 PM

#

you sound surprised lol

fallen patrol Aug 11, 2021, 6:07 PM

#

I am lol

vale ibex Aug 11, 2021, 6:07 PM

#

Ak is a verified Python speaker now

green oriole Aug 11, 2021, 6:07 PM

#

lol

#

Yeah I actually make non shitposting content

vale ibex Aug 11, 2021, 6:08 PM

#

need to balance it out somehow lol

fallen patrol Aug 11, 2021, 6:08 PM

#

makes sense

vale ibex Aug 11, 2021, 6:08 PM

#

viscid coral ?

I'm not ignoring you, I just don't have strong feelings either way. (Others may be the same)

cosmic moat Aug 11, 2021, 6:08 PM

#

hey guys, i have an old version of sir lancebot on my fork that uses pipenv and running pipenv run start gives socket.gaierror: [Errno -2] Name or service not known, any ideas? i have all of the env vars properly setup

vale ibex Aug 11, 2021, 6:09 PM

#

could you paste some more of the error?

fallen patrol Aug 11, 2021, 6:09 PM

#

easiest solution is to update lance and then try to fix it

vale ibex Aug 11, 2021, 6:09 PM

#

specifically what it's trying to connect to

#

you also have the option to rebase your fork

#

but you will likely be in merge conflict hell

fallen patrol Aug 11, 2021, 6:09 PM

#

or just go to github and press fetch from upstream 😏

viscid coral Aug 11, 2021, 6:10 PM

#

vale ibex I'm not ignoring you, I just don't have strong feelings either way. (Others may ...

Oh ok, thanks. Should I just close the issue due to inactivity?

fallen patrol Aug 11, 2021, 6:10 PM

#

ah yes

#

hm

#

uh

fallen patrol Aug 11, 2021, 6:11 PM

#

fallen patrol ah yes

oops wait that wasn't in response to you @viscid coral

viscid coral Aug 11, 2021, 6:11 PM

#

Got my hopes up.. jk lol I knew it wasn't for me

green oriole Aug 11, 2021, 6:13 PM

#

Most core devs are on vacations right now - including me - and not able to review much. I would just wait for a bit :)

viscid coral Aug 11, 2021, 6:14 PM

#

Ok, thank you!

static canyon Aug 11, 2021, 6:19 PM

#

I'm very confused by this linting error https://github.com/python-discord/bot/pull/1742/checks?check_run_id=3304029440

#

@vale ibex are you able to assist?

vocal wolf Aug 11, 2021, 6:21 PM

#

failed unit tests

#

try running the tests locally to see exactly what's going on

static canyon Aug 11, 2021, 6:22 PM

#

vocal wolf try running the tests locally to see exactly what's going on

How do I do that?

vocal wolf Aug 11, 2021, 6:23 PM

#

I think it's poetry run task test?

static canyon Aug 11, 2021, 6:23 PM

#

It's doing something

#

Holy sh*t lol

vocal wolf Aug 11, 2021, 6:24 PM

#

@static canyon here's how to do test stuff https://github.com/python-discord/bot/blob/main/tests/README.md#tools

vocal wolf Aug 11, 2021, 6:25 PM

#

static canyon Holy sh*t lol

well you did change a bunch of files, and a bunch of stuff within those files

static canyon Aug 11, 2021, 6:25 PM

#

Most of them are KeyError: 'token'

#

So... how do I fix that? @vocal wolf

vocal wolf Aug 11, 2021, 6:26 PM

#

uhhhhhh

#

I haven't had that error before, and I don't have access to my dev environment rn because am on windows

static canyon Aug 11, 2021, 6:27 PM

#

I'd say like 90% of the errors are that

brazen charm Aug 11, 2021, 6:28 PM

#

you need the env set up with a bot token, a dummy val should work

static canyon Aug 11, 2021, 6:29 PM

#

How would I set a dummy env?

vocal wolf Aug 11, 2021, 6:29 PM

#

oh that token, I thought you said 'token' as a placeholder for a different error, such as a class name.

dim pelican Aug 11, 2021, 6:30 PM

#

This is what I followed to get a local Sir-Lancebot running prior to contributing the Real Python search: https://pythondiscord.com/pages/guides/pydis-guides/contributing/bot/

Python Discord - Contributing to Bot

A guide to setting up and configuring Bot.

brazen charm Aug 11, 2021, 6:31 PM

#

static canyon How would I set a dummy env?

BOT_TOKEN needs to exist in your .env or as a normal env var so the config can grab it; you can set it to whatever like (even an empty val) but it must exist

static canyon Aug 11, 2021, 6:31 PM

#

Would setting it as a system env var work?

dim pelican Aug 11, 2021, 6:31 PM

#

~~The difference between Sir and Bot are the .env variables and the tests? (for the setup)~~ Nevermind there is a decent amount of differences

brazen charm Aug 11, 2021, 6:32 PM

#

maybe worth looking into what tests depend on configuration like that, but then again for local dev you'd have everything set up in most cases

fallen patrol Aug 11, 2021, 6:32 PM

#

vocal wolf <@!442244135840382978> here's how to do test stuff https://github.com/python-dis...

[Poetry Project](/pyproject.toml)
uhhhhh, its pyproject not poetry project.
(its a pep to be pyproject.toml)

brazen charm Aug 11, 2021, 6:33 PM

#

static canyon Would setting it as a system env var work?

I believe it should, you can also try replacing bot: token: ... with the value in your config.yml

static canyon Aug 11, 2021, 6:35 PM

#

brazen charm I believe it should, you can also try replacing `bot: token: ...` with the value...

This worked, thanks

#

FAILED tests/bot/exts/moderation/infraction/test_utils.py::TestPostInfraction::test_first_fail_second_success_user_post_infraction - TypeError: Subscripted generics cannot be used with...
FAILED tests/bot/exts/moderation/infraction/test_utils.py::TestPostInfraction::test_normal_post_infraction - TypeError: Subscripted generics cannot be used with class and instance checks
FAILED tests/bot/exts/moderation/infraction/test_utils.py::TestPostInfraction::test_unknown_error_post_infraction - TypeError: Subscripted generics cannot be used with class and instan...
FAILED tests/bot/exts/moderation/infraction/test_utils.py::TestPostInfraction::test_user_not_found_none_post_infraction - TypeError: Subscripted generics cannot be used with class and ...
```now got this (same error 4 times)

#

Example full error: https://paste.pythondiscord.com/avajuqosiy.rb?noredirect

green oriole Aug 11, 2021, 6:39 PM

#

Looks like an actual error due to to the new typing alias

brazen charm Aug 11, 2021, 6:40 PM

#

you changed a tuple passed to isinstance into a generic which can't be used with it https://github.com/python-discord/bot/blob/33c86445cb13713e58d5c3d56d5c204517f2998d/bot/exts/moderation/infraction/_utils.py#L82

stable mountainBOT Aug 11, 2021, 6:40 PM

#

bot/exts/moderation/infraction/_utils.py line 82

if isinstance(user, MemberOrUser) and user.bot:```

static canyon Aug 11, 2021, 6:40 PM

#

Right

#

Really the test should be edited then surely?

brazen charm Aug 11, 2021, 6:41 PM

#

that isn't from a test

static canyon Aug 11, 2021, 6:41 PM

#

Huh

#

It is?

#

tests\bot\exts\moderation\infraction\test_utils.py:358: this is a test dir

#

nvm

#

>>> import typing
>>> isinstance(3, typing.Union[float, int])
Traceback (most recent call last):
  File "<pyshell#1>", line 1, in <module>
    isinstance(3, typing.Union[float, int])
  File "C:\Users\tizzy\AppData\Local\Programs\Python\Python39\lib\typing.py", line 703, in __instancecheck__
    return self.__subclasscheck__(type(obj))
  File "C:\Users\tizzy\AppData\Local\Programs\Python\Python39\lib\typing.py", line 706, in __subclasscheck__
    raise TypeError("Subscripted generics cannot be used with"
TypeError: Subscripted generics cannot be used with class and instance checks```this is the issue

#

You can't do isinstance like that

brazen charm Aug 11, 2021, 6:43 PM

#

Yes, that's why it was using a tuple before

#

this is the same line on main https://github.com/python-discord/bot/blob/65d0afac77d33b4de57fbfb4a7d664817377e59e/bot/exts/moderation/infraction/_utils.py#L86

stable mountainBOT Aug 11, 2021, 6:44 PM

#

bot/exts/moderation/infraction/_utils.py line 86

if isinstance(user, (discord.Member, discord.User)) and user.bot:```

static canyon Aug 11, 2021, 6:45 PM

#

I needpy isinstance(user, MemberOrUser.__args__)

#

Or should I just revert?

brazen charm Aug 11, 2021, 6:45 PM

#

Why was it changed in the first place?

static canyon Aug 11, 2021, 6:45 PM

#

I just thought it was redundant

brazen charm Aug 11, 2021, 6:45 PM

#

That seems like the best option

static canyon Aug 11, 2021, 6:45 PM

#

brazen charm That seems like the best option

Which one?

celest charm Aug 11, 2021, 6:45 PM

#

stable mountain `bot/exts/moderation/infraction/_utils.py` line 86 ```py if isinstance(user, (di...

wait, isn't discord.Member a subclass of discord.User?

brazen charm Aug 11, 2021, 6:46 PM

#

reverting it

static canyon Aug 11, 2021, 6:46 PM

#

celest charm wait, isn't `discord.Member` a subclass of `discord.User`?

True

celest charm Aug 11, 2021, 6:46 PM

#

static canyon ```py >>> import typing >>> isinstance(3, typing.Union[float, int]) Traceback (m...

it's possible in Python 3.10 lemon_hyperpleased

static canyon Aug 11, 2021, 6:46 PM

#

I guess we can just isinstance(discord.User)

celest charm Aug 11, 2021, 6:46 PM

#

static canyon True

in which case, discord.User should be the same, right?

#

wait, where is discord.User defined?..

static canyon Aug 11, 2021, 6:47 PM

#

It's not

#

I removed the import lol

#

It was from discord import User I think

celest charm Aug 11, 2021, 6:48 PM

#

I mean, in discord's source code

#

because they do a bunch of from ... import * in __init__

brazen charm Aug 11, 2021, 6:48 PM

#

user.py

static canyon Aug 11, 2021, 6:48 PM

#

discord.user.User

celest charm Aug 11, 2021, 6:49 PM

#

so User is actually a dict?

static canyon Aug 11, 2021, 6:49 PM

#

class

celest charm Aug 11, 2021, 6:49 PM

#

it's inherited from TypedDict

static canyon Aug 11, 2021, 6:49 PM

#

It inherits a whole load of stuff

celest charm Aug 11, 2021, 6:49 PM

#

No, only another TypedDict

#

https://github.com/Rapptz/discord.py/blob/master/discord/types/user.py#L39

stable mountainBOT Aug 11, 2021, 6:49 PM

#

discord/types/user.py line 39

class User(PartialUser, total=False):```

static canyon Aug 11, 2021, 6:49 PM

#

PartialUser

celest charm Aug 11, 2021, 6:49 PM

#

https://github.com/Rapptz/discord.py/blob/master/discord/types/user.py#L29

stable mountainBOT Aug 11, 2021, 6:49 PM

#

discord/types/user.py line 29

class PartialUser(TypedDict):```

celest charm Aug 11, 2021, 6:50 PM

#

that means it's a TypedDict, right pithink

static canyon Aug 11, 2021, 6:50 PM

#

Do we want isinstance(user, (discord.Member, discord.User)) for clarity or just isinstance(user, discord.User) for simplicity?

brazen charm Aug 11, 2021, 6:50 PM

#

mind that we're using the 462ba84809f43349296c44cbe6468f631a00edab rev, not master

celest charm Aug 11, 2021, 6:51 PM

#

ohh

brazen charm Aug 11, 2021, 6:51 PM

#

(or at least something around it but that's the tag for the version the bot uses)

static canyon Aug 11, 2021, 6:51 PM

#

static canyon Do we want `isinstance(user, (discord.Member, discord.User))` for clarity or jus...

^

celest charm Aug 11, 2021, 6:52 PM

#

wait @static canyon, Member doesn't inherit from User

#

I lied to you

#

https://github.com/Rapptz/discord.py/blob/462ba84809f43349296c44cbe6468f631a00edab/discord/member.py#L159

stable mountainBOT Aug 11, 2021, 6:52 PM

#

discord/member.py line 159

class Member(discord.abc.Messageable, _BaseUser):```

celest charm Aug 11, 2021, 6:52 PM

#

right?

static canyon Aug 11, 2021, 6:52 PM

#

Sec

#

https://github.com/Rapptz/discord.py/blob/master/discord/user.py#L342

stable mountainBOT Aug 11, 2021, 6:53 PM

#

discord/user.py line 342

class User(BaseUser, discord.abc.Messageable):```

static canyon Aug 11, 2021, 6:53 PM

#

User inherits BaseUser which inherits _UserTag

#

Member inherits _UserTag

#

in main

brazen charm Aug 11, 2021, 6:54 PM

#

it looks like you'd have to use the User abc if you only wanted a single type in the isinstance, I think it'd be best to just leave the line alone

celest charm Aug 11, 2021, 6:54 PM

#

yeah let's just do the simple thing

fallen patrol Aug 11, 2021, 6:54 PM

#

@vale ibex btw you have conflicts on https://github.com/python-discord/kubernetes/pull/65 before anyone reviews it 🙂

static canyon Aug 11, 2021, 6:55 PM

#

celest charm yeah let's just do the simple thing

Ah yeah, isinstance(user, MemberOrUser.__args__)

#

lol

celest charm Aug 11, 2021, 6:55 PM

#

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

static canyon Aug 11, 2021, 6:55 PM

#

lol

celest charm Aug 11, 2021, 6:55 PM

#

lemon_cut

fallen patrol Aug 11, 2021, 6:56 PM

#

celest charm AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA...

*aaaaAAAA

static canyon Aug 11, 2021, 6:56 PM

#

Do we care about lint warnings? (things like deprecations etc.)

brazen charm Aug 11, 2021, 6:57 PM

#

the ones from running the project's flake8, don't think there's anything for deprecations there

static canyon Aug 11, 2021, 6:58 PM

#

https://paste.pythondiscord.com/dacugowevu.sql first one is deprecation from the poetry run task test @brazen charm

brazen charm Aug 11, 2021, 6:58 PM

#

yeah ignore that it's not even from our code, the testing suite probably emits all warnings

static canyon Aug 11, 2021, 6:59 PM

#

Right, okay

#

Hopefully it passes linting this time lol

#

Can I get reviews on bot#1742 please lemon_happy

dusky shoreBOT Aug 11, 2021, 7:02 PM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser

viscid coral Aug 11, 2021, 7:05 PM

#

I can review but what message should I do?

#

Or just leave it blank if possible?

vocal prairie Aug 11, 2021, 7:07 PM

#

viscid coral I can review but what message should I do?

If you're not familiar with reviewing, you may want to take a look at this: https://pythondiscord.com/pages/guides/pydis-guides/code-reviews-primer/

Python Discord - Code Reviews: A Primer

An introduction and guide to the world of code reviews!

vernal prawn Aug 11, 2021, 7:07 PM

#

hi everyone

vocal prairie Aug 11, 2021, 7:07 PM

#

But in general, you don't always need an approval/denial message, you're just expected to look over the code

vernal prawn Aug 11, 2021, 7:07 PM

#

do yo know how to user mongo wth django frame

vocal prairie Aug 11, 2021, 7:07 PM

#

vernal prawn do yo know how to user mongo wth django frame

You may want to ask that in #web-development, as this channel is for Python Discord projects.

vale ibex Aug 11, 2021, 7:17 PM

#

fallen patrol <@!126811506632294400> btw you have conflicts on https://github.com/python-disco...

Ah lol, that might be able to be closed tbh cc @patent pivot @fervent sage

patent pivot Aug 11, 2021, 7:18 PM

#

oh yeah that's fine to close

#

@vale ibex hello i'm going to merge the manifests for threadbot

fervent sage Aug 11, 2021, 7:19 PM

#

oh also joe, my pure asgi service mmLol

patent pivot Aug 11, 2021, 7:19 PM

#

vco PR me manifests mmLul

fervent sage Aug 11, 2021, 7:19 PM

#

idk how to k8s lol

#

but I'll try

patent pivot Aug 11, 2021, 7:20 PM

#

lmfao

vale ibex Aug 11, 2021, 7:20 PM

#

patent pivot <@!126811506632294400> hello i'm going to merge the manifests for threadbot

Cool, I'll enable the depoly stage in threadbot when I'm back tonight

#

(or someone else can uncomment it out if you want your name on the repo)

fallen patrol Aug 11, 2021, 7:20 PM

#

@brisk belfry

fallen patrol Aug 11, 2021, 7:21 PM

#

vale ibex (or someone else can uncomment it out if you want your name on the repo)

you said the magic words

#

wait I don't have push so nvm

#

darnit

vale ibex Aug 11, 2021, 7:21 PM

#

Lol Yea you can fork tho

#

And PR

patent pivot Aug 11, 2021, 7:21 PM

#

greenTick

fallen patrol Aug 11, 2021, 7:21 PM

#

~~joe will do it before i do it~~

patent pivot Aug 11, 2021, 7:22 PM

#

i can just apply it from my laptop lol

#

just waiting for linting to passss

fervent sage Aug 11, 2021, 7:22 PM

#

hi yes what is 750m cpu?

#

i dont understand the resources section lol

patent pivot Aug 11, 2021, 7:23 PM

#

750 millicores

fervent sage Aug 11, 2021, 7:23 PM

#

ah

patent pivot Aug 11, 2021, 7:23 PM

#

1000m is 1 CPU core

fervent sage Aug 11, 2021, 7:23 PM

#

75% of a core

patent pivot Aug 11, 2021, 7:23 PM

#

your service probably needs

#

10

#

lol

#

greenTick

#

@brisk belfry

#

yooooooooo chris bad programmmer #EpicFail

fervent sage Aug 11, 2021, 7:24 PM

#

ok how many things are wrong with this? mmLol

patent pivot Aug 11, 2021, 7:24 PM

#

lgtm

#

needs svc & ingress

fervent sage Aug 11, 2021, 7:24 PM

#

time to steal from quackstack mmLol

#

omg joe

#

the tls error page for quackstack is... yea

#

thats great

vale ibex Aug 11, 2021, 7:25 PM

#

patent pivot yooooooooo chris bad programmmer #EpicFail

LOL what

#

Oh, yea lmfao

#

Dockerignore

fervent sage Aug 11, 2021, 7:26 PM

#

uh joe, my thing exposes port 8000, how do i tell k8s ingress that's the case?

#

oh is it targetPort in svc

patent pivot Aug 11, 2021, 7:28 PM

#

yea

fervent sage Aug 11, 2021, 7:31 PM

#

mmLol kubernetes#69 funny number

dusky shoreBOT Aug 11, 2021, 7:31 PM

#

GitHub

PROpen feat: add h service

dim pelican Aug 11, 2021, 7:34 PM

#

nice.

patent pivot Aug 11, 2021, 7:35 PM

#

LMFAO we are not having a service in my cluster called solely h

#

h-asgi minimum

fervent sage Aug 11, 2021, 7:35 PM

#

smh fine

twilit juniper Aug 11, 2021, 7:35 PM

#

dude no you didn't

vocal prairie Aug 11, 2021, 7:35 PM

#

omg this is amazing

twilit juniper Aug 11, 2021, 7:36 PM

#

well I mean joe did say he could

vocal prairie Aug 11, 2021, 7:36 PM

#

dusky shore

that ghcr link 404s for me

patent pivot Aug 11, 2021, 7:37 PM

#

same

fervent sage Aug 11, 2021, 7:37 PM

#

hahahaha

#

please type h to confirm

patent pivot Aug 11, 2021, 7:37 PM

#

lmfao

twilit juniper Aug 11, 2021, 7:37 PM

#

loll

fervent sage Aug 11, 2021, 7:37 PM

#

should be good now

patent pivot Aug 11, 2021, 7:38 PM

#

shameless plug with the mTLS error

#

I'll allow it

fervent sage Aug 11, 2021, 7:38 PM

#

how common are mtls errors anyway?

patent pivot Aug 11, 2021, 7:38 PM

#

providing you aren't being a naughty goomba, it'll never be seen

twilit juniper Aug 11, 2021, 7:38 PM

#

wait so this is the h bot?

#

or

fervent sage Aug 11, 2021, 7:38 PM

#

no

#

is a tiny asgi service

#

which just shows h for every route and method

twilit juniper Aug 11, 2021, 7:39 PM

#

oh

#

lol

fervent sage Aug 11, 2021, 7:39 PM

#

so like

twilit juniper Aug 11, 2021, 7:39 PM

#

nice

celest charm Aug 11, 2021, 7:39 PM

#

ASGI = ❤️

fervent sage Aug 11, 2021, 7:39 PM

#

GET /abc/def/ghi is h

#

POST /ducky is h

patent pivot Aug 11, 2021, 7:39 PM

#

twilit juniper Aug 11, 2021, 7:39 PM

#

lolll

fervent sage Aug 11, 2021, 7:40 PM

#

uh oh is not happy

patent pivot Aug 11, 2021, 7:40 PM

#

https://h.pythondiscord.com/

fervent sage Aug 11, 2021, 7:40 PM

#

ok

patent pivot Aug 11, 2021, 7:40 PM

#

works

fervent sage Aug 11, 2021, 7:40 PM

#

all is good

hoary anvil Aug 11, 2021, 7:43 PM

#

@patent pivot got a browser warning

#

for h.pythondiscord.com

patent pivot Aug 11, 2021, 7:44 PM

#

lol

#

you'll live

#

tell vco

fervent sage Aug 11, 2021, 7:44 PM

#

i guess i could make it specify the char encoding

#

but then again i could also not

hoary anvil Aug 11, 2021, 7:45 PM

#

but why would you not if you could also yes

fervent sage Aug 11, 2021, 7:45 PM

#

because i made that image in my /tmp dir and its gone because its so low effort

hoary anvil Aug 11, 2021, 7:45 PM

#

bruh

fervent sage Aug 11, 2021, 7:45 PM

#

but its high enough effort i cba to rewrite it lmao

hoary anvil Aug 11, 2021, 7:45 PM

#

verra sad

#

it is aye peetiful

#

i

#

man

patent pivot Aug 11, 2021, 7:46 PM

#

no no this is not a sign off on that at all lol

fervent sage Aug 11, 2021, 7:47 PM

#

there is context™️ behind this

hoary anvil Aug 11, 2021, 7:47 PM

#

fervent sage there is context™️ behind this

ctx.message

fervent sage Aug 11, 2021, 7:47 PM

#

joe, vc, late night

hoary anvil Aug 11, 2021, 7:48 PM

#

Joe's Late Night Show, with Alec VCO as this week's guest:
"Why do we need to create a website for h?"

#

yes

#

h.pydis.com

#

most excellent

patent pivot Aug 11, 2021, 7:52 PM

#

hmmmmm

#

not

#

urgently

#

I don't think

fervent sage Aug 11, 2021, 7:52 PM

#

this is in such serious need of a redesign its not even funny lol

patent pivot Aug 11, 2021, 7:52 PM

#

I might move away from Grafana alerting at some point

#

to Alertmanager

static canyon Aug 11, 2021, 7:55 PM

#

Reviews please https://github.com/python-discord/bot/pull/1742 👉 👈

#

bot#1742

dusky shoreBOT Aug 11, 2021, 7:55 PM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser

patent pivot Aug 11, 2021, 7:56 PM

#

lolol, hold on writing manifests, there's a bit more to it than a single container

#

need to figure out where I want to put alerts

#

maybe maybe lol, but it's a really core part of our devops, so I'm going to be figuring it out as we go along

#

it's the entire method of how alerts get checked and pushed out to Discord & OpsGenie

#

pager

#

https://www.atlassian.com/software/opsgenie

Atlassian

Opsgenie | Alerting and On-Call Management | Atlassian

Opsgenie is the #1 alerting and incident response tool. Never miss a critical alert, restore the service, and fix the underlying issue.

fervent sage Aug 11, 2021, 8:11 PM

#

better than an hour of AWS "You are not authorized to perform this operation." blob_pain

patent pivot Aug 11, 2021, 8:33 PM

#

imagine using the root user

green oriole Aug 11, 2021, 8:38 PM

#

Do we seriously now have a service to return the letter H? I love it

fervent sage Aug 11, 2021, 8:39 PM

#

:D

vocal prairie Aug 11, 2021, 8:41 PM

#

I love that

vale ibex Aug 11, 2021, 8:44 PM

#

joe could you reenable @brisk belfry ?

#

Should be good now

#

I've fixed the Dockerignore and turned on the auto-deploy action

green oriole Aug 11, 2021, 8:45 PM

#

If Joe isn't around I could maybe do it, I assume he brought down the number or replicas to zero?

vale ibex Aug 11, 2021, 8:46 PM

#

https://github.com/python-discord/kubernetes/blob/main/thread-bot/deployment.yaml#L6

stable mountainBOT Aug 11, 2021, 8:46 PM

#

thread-bot/deployment.yaml line 6

replicas: 1```

vale ibex Aug 11, 2021, 8:46 PM

#

doesn't seem like it

green oriole Aug 11, 2021, 8:47 PM

#

We don't usually commit those changes to the repo

vale ibex Aug 11, 2021, 8:47 PM

#

ahh

green oriole Aug 11, 2021, 8:47 PM

#

But no there is a replica

#

The auto deployment should work, I don't see anything that should disable it

vale ibex Aug 11, 2021, 8:47 PM

#

https://github.com/python-discord/thread-bot/runs/3305282550?check_suite_focus=true

#

it suceeded

#

bot just isn't online

green oriole Aug 11, 2021, 8:48 PM

#

Hmmm

vocal prairie Aug 11, 2021, 8:48 PM

#

I just noticed, this url is wrong: https://github.com/python-discord/bot/blob/main/bot/exts/info/site.py#L46

#

It's just /resources, not /pages/resources

vale ibex Aug 11, 2021, 8:50 PM

#

Did you want to fix it?

vocal prairie Aug 11, 2021, 8:50 PM

#

Ye, I can do that

vale ibex Aug 11, 2021, 8:50 PM

#

Noice

#

there's a few places in that file it's referenced

#

It might be better to change the constant to a baseurl

green oriole Aug 11, 2021, 8:50 PM

#

https://paste.pythondiscord.com/izenilatil.py @vale ibex

vocal prairie Aug 11, 2021, 8:50 PM

#

The tools link too

static canyon Aug 11, 2021, 8:50 PM

#

vocal prairie It's just /resources, not /pages/resources

Look at the variable

#

The variable has /pages in it

vocal prairie Aug 11, 2021, 8:51 PM

#

static canyon Look at the variable

Yeah I saw, I can fix that

vale ibex Aug 11, 2021, 8:51 PM

#

and then add /pages to the 3 places that need it

static canyon Aug 11, 2021, 8:51 PM

#

vocal prairie Yeah I saw, I can fix that

No I'm saying it's correct as it is

vocal prairie Aug 11, 2021, 8:51 PM

#

I mean I can fix the wrong links, my bad explanation

static canyon Aug 11, 2021, 8:52 PM

#

PAGES_URL = f"{URLs.site_schema}{URLs.site}/pages"
...
learning_url = f"{PAGES_URL}/resources"```it's correct though?

vale ibex Aug 11, 2021, 8:52 PM

#

nope

#

Resources are at https://pythondiscord.com/resources/

Python Discord | Resources

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

vocal prairie Aug 11, 2021, 8:52 PM

#

static canyon ```py PAGES_URL = f"{URLs.site_schema}{URLs.site}/pages" ... learning_url = f"{P...

We can remove the /pages part and manually add it when needed

static canyon Aug 11, 2021, 8:52 PM

#

/pages/resources redirects 🤷

#

But yeah I suppose

green oriole Aug 11, 2021, 8:53 PM

#

he doesn't care about my traceback

vale ibex Aug 11, 2021, 8:53 PM

#

oh lol

#

lemme look

#

oh...yea

#

I'm not gonna fix that

#

my PR will fix it as a sideaffect

static canyon Aug 11, 2021, 8:54 PM

#

@vocal prairie frequently-asked-questions is /pages/frequently-asked-questions (not just /frequently-asked-questions)

#

Same for /pages/rules and /pages/guides/pydis-guides/asking-good-questions/

vale ibex Aug 11, 2021, 8:55 PM

#

vale ibex and then add /pages to the 3 places that need it

.

vocal prairie Aug 11, 2021, 8:56 PM

#

Yeah, I'll manually append /pages

static canyon Aug 11, 2021, 8:57 PM

#

👍

#

I think the asking-good-questions link is wrong at the moment

#

Nvm it redirects to the correct one

vocal prairie Aug 11, 2021, 9:04 PM

#

Is there something special that needs to be set up when running the bot in Docker? I'm getting this error:

bot_1       | 2021-08-11 21:03:46 | bot | CRITICAL | Could not connect to site API. Is it running?

#

And afaik, compose sets up site by default

brazen charm Aug 11, 2021, 9:06 PM

#

you have to change the urls

vocal prairie Aug 11, 2021, 9:06 PM

#

I have them all configured properly to my knowledge

#

urls:
    # PyDis site vars
    connect_max_retries:       3
    connect_cooldown:          5
    site:        &DOMAIN       "pythondiscord.local:8000"
    site_api:    &API    !JOIN ["api.", *DOMAIN]
    site_api_schema:           "http://"
    site_paste:  &PASTE  !JOIN ["paste.", "pythondiscord.com"]
    site_schema: &SCHEMA       "http://"
    site_staff:  &STAFF  !JOIN ["staff.", *DOMAIN]

    paste_service:                      !JOIN ["https://", *PASTE, "/{key}"]
    site_logs_view:                     !JOIN [*SCHEMA, *STAFF, "/bot/logs"]

#

I haven't touched anything besides setting the BOT_TOKEN env var and the config.yml

brazen charm Aug 11, 2021, 9:08 PM

#

do you have pythondiscord.local set in your hosts file?

vocal prairie Aug 11, 2021, 9:08 PM

#

Yup, and when I go to http://pythondiscord.local:8000/ in the browser, it works fine

brazen charm Aug 11, 2021, 9:10 PM

#

ah if it's all in docker you may need to use the docker names

#

web:8000 for the site url I think?

vocal prairie Aug 11, 2021, 9:11 PM

#

Thank you, I found that part in the contrib guide now

brazen charm Aug 11, 2021, 9:11 PM

#

personally I run the bot itself normally so it's easier to restart

vale ibex Aug 11, 2021, 9:15 PM

#

@brisk brook I've actioned all your comments on thread-bot#1

dusky shoreBOT Aug 11, 2021, 9:15 PM

#

GitHub

PROpen Add nomination cog

static canyon Aug 11, 2021, 9:32 PM

#

Can I get two more reviews on bot#1742 please?

dusky shoreBOT Aug 11, 2021, 9:32 PM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser

tawdry vapor Aug 11, 2021, 9:36 PM

#

static canyon Can I get two more reviews on bot#1742 please?

It's not a drop-in replacement because our convert had a case that returned discord.Object. Is that an oversight on your part or did you not think it was helpful to keep it?

static canyon Aug 11, 2021, 9:38 PM

#

tawdry vapor It's not a drop-in replacement because our convert had a case that returned `dis...

When would it return discord.Object?

#

If you just use the default UserConverter it won't as of dpy 1.6

tawdry vapor Aug 11, 2021, 9:38 PM

#

When the fetch API call failed for a reason other than the user not being found

static canyon Aug 11, 2021, 9:39 PM

#

What would be such a scenario?

green oriole Aug 11, 2021, 9:39 PM

#

Discord being broken?

static canyon Aug 11, 2021, 9:39 PM

#

I mean if discord was broken then stuff would break anyway I guess (just further down the line)

tawdry vapor Aug 11, 2021, 9:40 PM

#

I don't really know. I guess it was a robustness thing but I don't have stats to gauge how useful it has been in practice.

#

But it was a concern that you didn't mention this behaviour at all in your PR

static canyon Aug 11, 2021, 9:40 PM

#

Can you link to the code for this?

tawdry vapor Aug 11, 2021, 9:41 PM

#

https://github.com/python-discord/bot/blob/main/bot/converters.py#L518-L522

stable mountainBOT Aug 11, 2021, 9:41 PM

#

bot/converters.py lines 518 to 522

except discord.HTTPException as e:
    # If the Discord error isn't `Unknown user`, return a proxy instead
    if e.code != 10013:
        log.info(f"Failed to fetch user, returning a proxy instead: status {e.status}")
        return proxy_user(arg)```

static canyon Aug 11, 2021, 9:42 PM

#

I don't think it's really worth having that to be honest

#

I did notice that but then forgot to comment about it

#

The only scenario I can think of where that'd actually be useful is when discord is down or something and so stuff would break anyway

static canyon Aug 11, 2021, 9:48 PM

#

tawdry vapor I don't really know. I guess it was a robustness thing but I don't have stats to...

I don't have stats to gauge how useful it has been in practice.
~~Maybe that's something @patent pivot can help with seeing as it's logged each time it happens~~ Mark knew how to do it, sorry for ping

brisk brook Aug 11, 2021, 9:48 PM

#

vale ibex <@!344404945359077377> I've actioned all your comments on thread-bot#1

Two small nitpicks then it should be good!

tawdry vapor Aug 11, 2021, 9:50 PM

#

static canyon > I don't have stats to gauge how useful it has been in practice. ~~Maybe that's...

Good point, I actually know how to look that up myself.

static canyon Aug 11, 2021, 9:50 PM

#

I'll let you do that then 👍

#

If it is used a fair amount then I guess keep it

tawdry vapor Aug 11, 2021, 9:50 PM

#

Although I cannot tell if it is taking a long time to query or if it just found nothing...

#

https://grafana.pythondiscord.com/d/CeNBKKfMk/service-logs?orgId=2&refresh=5s&var-job=bot&var-search=Failed+to+fetch+user%2C+returning+a+proxy+instead&from=now-2y&to=now

vale ibex Aug 11, 2021, 9:50 PM

#

brisk brook Two small nitpicks then it should be good!

gonna squash some of the commits before I merge

static canyon Aug 11, 2021, 9:51 PM

#

tawdry vapor Although I cannot tell if it is taking a long time to query or if it just found ...

Pretty sure that's finding nothing

#

Since for me it says like "querying" or something then loads a blank page after

#

Yeah, if you do say "Dormant" as the search term it's a lot more obvious in comparison

#

Also get a little spinny icon when it's loading

static canyon Aug 11, 2021, 9:52 PM

#

static canyon Pretty sure that's finding nothing

So basically it's fine to remove it 👍

tawdry vapor Aug 11, 2021, 9:53 PM

#

I think it's not working right

#

I don't think it's actually querying the entire 2 year range

#

Even with a query that I know should return many results, I cannot scroll farther than 5th of august

static canyon Aug 11, 2021, 9:54 PM

#

I assume it only shows top 100 or whatever

#

I'm getting 1000 results tops from the looks of it

brisk brook Aug 11, 2021, 9:56 PM

#

vale ibex gonna squash some of the commits before I merge

Your PR has been Bluenix™️ certified, very strict rules. Not many PRs get this certification

tawdry vapor Aug 11, 2021, 9:56 PM

#

Yeah same, only 1k

#

I guess it really never triggered.

static canyon Aug 11, 2021, 9:56 PM

#

Yeah

#

I mean that's definitely feasible seeing as I can't think of a scenario it would

#

So are you in agreement that it's okay to remove the proxy_user stuff? @tawdry vapor

vale ibex Aug 11, 2021, 10:02 PM

#

@brisk belfry

#

pls come online

#

ty

tawdry vapor Aug 11, 2021, 10:02 PM

#

static canyon So are you in agreement that it's okay to remove the `proxy_user` stuff? <@!1370...

Yeah I am in agreement.

static canyon Aug 11, 2021, 10:02 PM

#

I'll make a reference to this on the PR to make it clear

vale ibex Aug 11, 2021, 10:04 PM

#

vale ibex pls come online

🎉

viscid coral Aug 11, 2021, 10:04 PM

#

Nice!

#

No idea what the bot does but nice

static canyon Aug 11, 2021, 10:04 PM

#

@vale ibex Do you have time to review my 3rd PR today too? bot#1742

dusky shoreBOT Aug 11, 2021, 10:04 PM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser

vale ibex Aug 11, 2021, 10:05 PM

#

once I make a PR of my own, 2 secs

static canyon Aug 11, 2021, 10:05 PM

#

👍

vale ibex Aug 11, 2021, 10:08 PM

#

uhhh, that's a lot of commits

#

we should probably squash those down to a few

#

I don't think it should just be 1 though

#

ehhh, actually possibly

static canyon Aug 11, 2021, 10:10 PM

#

I was going to squash them but then realised I didn't know how and looking it up didn't really help much

vale ibex Aug 11, 2021, 10:10 PM

#

I can squash them all into 1 commit when merging via the github interface

#

I'm just trying to parse all the changes in my head to see if that makes sense

static canyon Aug 11, 2021, 10:10 PM

#

All the "Verified" ones are one-file edits

vale ibex Aug 11, 2021, 10:10 PM

#

otherwise I can check it out locally and squash

static canyon Aug 11, 2021, 10:11 PM

#

The verified ones are really two commits: updating converters and removing unused imports

#

Suppose can merge that into one though tbf

vale ibex Aug 11, 2021, 10:14 PM

#

I'm thinking

1 commit that adds the MemberOrUser converter, and changes all of the type hints, and removes unused imports
1 commit that removes the redundant isinstance check
1 commit that removes the FetchedUser and proxy_user things

static canyon Aug 11, 2021, 10:15 PM

#

vale ibex I'm thinking - 1 commit that adds the MemberOrUser converter, and changes all o...

Yeah, that sounds good

vale ibex Aug 11, 2021, 10:16 PM

#

cool, feel free to review bot#1744 in the mean time

dusky shoreBOT Aug 11, 2021, 10:16 PM

#

GitHub

PROpen Remove role pings when a helper vote is posted

vale ibex Aug 11, 2021, 10:16 PM

#

not too sure of the implications, I guess try it and test things 😄

fallen patrol Aug 11, 2021, 10:17 PM

#

vale ibex gonna squash some of the commits before I merge

someone sent me a guide on this btw, https://www.notion.so/pythondiscord/Squashing-a-Pull-Request-191e8efa2fbb4d72840fd17ca37cf7fa

#

you might find it useful

static canyon Aug 11, 2021, 10:17 PM

#

Does the thread bot ping both Mods and Admins in the thread? @vale ibex

Edit: Nvm, just remembered it's open source so can check myself and it does

fallen patrol Aug 11, 2021, 10:17 PM

#

😉

vale ibex Aug 11, 2021, 10:23 PM

#

fallen patrol someone sent me a guide on this btw, <https://www.notion.so/pythondiscord/Squash...

someone lol

vale ibex Aug 11, 2021, 10:23 PM

#

static canyon Does the thread bot ping both Mods and Admins in the thread? <@!1268115066322944...

lol yup

#

also, just squashed

static canyon Aug 11, 2021, 10:24 PM

#

vale ibex also, just squashed

ty 😄

#

And I reviewed your PR

vale ibex Aug 11, 2021, 10:24 PM

#

noice

#

annoyingly, since I forcepsuhed that rebase I'm actually disqualified from counting towards review bot

#

just remembered that lol

static canyon Aug 11, 2021, 10:25 PM

#

lol

tawdry vapor Aug 11, 2021, 10:27 PM

#

4 people reviewed bot#1738 and none of them noticed that the categories are already instance attributes of the cog 😔

dusky shoreBOT Aug 11, 2021, 10:27 PM

#

GitHub

PRMerged Make DORMANT_MSG Dynamic

vale ibex Aug 11, 2021, 10:28 PM

#

ah crap, I even used those when I was in there a few weeks ago

#

sadge

static canyon Aug 11, 2021, 11:17 PM

#

@tawdry vapor those issues should be fixed now 👍

#

bot#1742

dusky shoreBOT Aug 11, 2021, 11:18 PM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser

echo narwhal Aug 12, 2021, 6:39 AM

#

Congratulation on finishing your first project! Our bot uses the discord.py library though, and can't be used to add various unneeded scripts. Please make sure to be assigned to an issue before submitting a PR, or come discuss this with us in the #dev-contrib channel.

can someone help me? i dont understand this ^^

short snow Aug 12, 2021, 6:42 AM

#

context?

celest charm Aug 12, 2021, 6:48 AM

#

short snow context?

sir-lancebot#807

dusky shoreBOT Aug 12, 2021, 6:48 AM

#

GitHub

PRClosed Calculator

celest charm Aug 12, 2021, 6:49 AM

#

echo narwhal Congratulation on finishing your first project! Our bot uses the discord.py libr...

The Sir Lancebot project is our bot, @dusky shore. I don't see how your project fits into the bot.

#

You can make a command that implements a calculator, which could be useful.

echo narwhal Aug 12, 2021, 6:50 AM

#

celest charm You can make a command that implements a calculator, which could be useful.

i dont understand

short snow Aug 12, 2021, 6:50 AM

#

Scientific calculator ^

celest charm Aug 12, 2021, 6:51 AM

#

echo narwhal i dont understand

Our bot isn't just a collection of personal beginner projects, it's a Discord bot with some fun commands.

#

maybe @green oriole can clarify their message

green oriole Aug 12, 2021, 6:52 AM

#

Yes, our project is a discord bot. You are free to contribute commands that uses the discord.py library.

short snow Aug 12, 2021, 6:53 AM

#

The sirlancebot is a discord bot, it contains fun commands to play with on the server, you have made a calculator which isn't using the python discord.py library which we use to add commands to the bot, so your command won't be added to the bot even if the PR is merged.

Secondly, I don't see how the command fits our needs, it is just too "simple" to be added as a command if you could make it a scientific calculator then it could have been better but it doesn't adhere our contributing guide as we need to make an issue first which would get approved by a core developer and then a PR can be made

green oriole Aug 12, 2021, 6:53 AM

#

But your contribution was just a script in the root folder, it doesn't have anything to do with the bot

#

I would honestly love to see a proper calculator be added, just because parsing and interpreting a mathematical expression is quite interesting. But I don't think other core devs would agree with me haha

#

Congratulations on finishing your first project though @echo narwhal! If you want to easily share it putting the file in a gist (https://gist.github.com, basically a website for showing and sharing various script) would be a great idea!

rapid swallow Aug 12, 2021, 6:58 AM

#

!e
print(23*3)

stable mountainBOT Aug 12, 2021, 6:58 AM

#

@rapid swallow :white_check_mark: Your eval job has completed with return code 0.

rapid swallow Aug 12, 2021, 6:58 AM

#

A scientific calculator is an interesting idea

echo narwhal Aug 12, 2021, 6:58 AM

#

stable mountain <@562601836591185930> :white_check_mark: Your eval job has completed with return...

👀

green oriole Aug 12, 2021, 6:59 AM

#

My bad, I thought you said it was your first project. Well, even if it isn't it is still a good achievement lemon_pleased

echo narwhal Aug 12, 2021, 7:00 AM

#

green oriole My bad, I thought you said it was your first project. Well, even if it isn't it ...

it is

#

my 1st one

short snow Aug 12, 2021, 7:02 AM

#

good job,m but python file has a .py extension

static canyon Aug 12, 2021, 8:38 AM

#

Can I have some more reviews on bot#1742 please?

dusky shoreBOT Aug 12, 2021, 8:38 AM

#

GitHub

PROpen Remove redundant converters and renamed FetchedMember to MemberOrUser

vale ibex Aug 12, 2021, 8:44 AM

#

https://github.com/Rapptz/discord.py/commit/1e17b7fceaf7173b1666465e639d1bebaa126683

#

(╯°□°）╯︵ ┻━┻

#

guess this is the life of using unreleased versions lol

brazen charm Aug 12, 2021, 8:45 AM

#

doesn't the lockfile lock it to a specific rev? or do you have to do that manually if wanted

short snow Aug 12, 2021, 8:46 AM

#

ahh this guy opened his pr think

vale ibex Aug 12, 2021, 8:47 AM

#

brazen charm doesn't the lockfile lock it to a specific rev? or do you have to do that manual...

just checked, you can pin it to a specific rev/tag

#

but I didn't so I guess this is my own doing really lol

brazen charm Aug 12, 2021, 8:48 AM

#

I would do that if the lockfile doesn't do that already (which tbh I think would make more sense), always better to manually update when you know about it to fix something instead of getting a new version every time

short snow Aug 12, 2021, 8:49 AM

#

i think lockfile does pin it to a specific commit, which gets changed when you relock?

#

not sure

vale ibex Aug 12, 2021, 8:49 AM

#

Yea true, think I need to install git on the image now though

short snow Aug 12, 2021, 8:49 AM

#

i had the same issue an hour back

vale ibex Aug 12, 2021, 8:49 AM

#

small price to pay though IG

#

I think the issue is I was specifying the archive zip url, rather than the repo

#

since I didn't want to have to install git

#

and that archive zip is the latest version of master

brazen charm Aug 12, 2021, 8:51 AM

#

that might be it, the lock file currently only keeps track of the version which I assume doesn't change until they go into a beta/stable

vale ibex Aug 12, 2021, 8:51 AM

#

Yea

short snow Aug 12, 2021, 9:14 AM

#

rm -rf /var/lib/apt/lists/* chris why did u do this?

#

I wanted to copy your approach on one bot

vale ibex Aug 12, 2021, 9:15 AM

#

Since there's no need for them to be there using up image space

short snow Aug 12, 2021, 9:15 AM

#

what does it contain?

vale ibex Aug 12, 2021, 9:15 AM

#

that's where apt-get update things go

short snow Aug 12, 2021, 9:15 AM

#

oh

#

yes

#

ok ty

vale ibex Aug 12, 2021, 9:15 AM

#

👍

surreal veldt Aug 12, 2021, 9:16 AM

#

Anyone on bot#1724

dusky shoreBOT Aug 12, 2021, 9:16 AM

#

GitHub

IssueOpen New feature for the docs command

green oriole Aug 12, 2021, 9:17 AM

#

@surreal veldt would you like to work on it?

brazen charm Aug 12, 2021, 9:20 AM

#

there's already bot#447 which I'd say overlaps with the above issue

dusky shoreBOT Aug 12, 2021, 9:20 AM

#

GitHub

IssueOpen Support partial searches for documentation

surreal veldt Aug 12, 2021, 9:21 AM

#

green oriole <@751814647346102303> would you like to work on it?

Sure
Was thinking of using the difflib module

surreal veldt Aug 12, 2021, 9:22 AM

#

dusky shore

oh

green oriole Aug 12, 2021, 9:22 AM

#

Oh, good catch num, thank you

surreal veldt Aug 12, 2021, 9:22 AM

#

that was made some time ago

#

2019 lol

green oriole Aug 12, 2021, 9:23 AM

#

Would you like to work on that one @brazen charm? Asking since it has been a bit since your last comment

brazen charm Aug 12, 2021, 9:24 AM

#

no, not at the moment

green oriole Aug 12, 2021, 9:24 AM

#

Alrighty, then if you comment on the issue @surreal veldt I can assign it to you

surreal veldt Aug 12, 2021, 9:25 AM

#

green oriole Alrighty, then if you comment on the issue <@751814647346102303> I can assign it...

sorry uh what do i comment lol?

green oriole Aug 12, 2021, 9:25 AM

#

You can just say that you want to work on the issue

#

On bot#447 I mean

dusky shoreBOT Aug 12, 2021, 9:25 AM

#

GitHub

IssueOpen Support partial searches for documentation

brazen charm Aug 12, 2021, 9:25 AM

#

keep in mind that there are more than a 100k symbols from the loaded invs so naive fuzzy matching probably won't work very well in the majority of cases, only for things like typos

surreal veldt Aug 12, 2021, 9:26 AM

#

brazen charm keep in mind that there are more than a 100k symbols from the loaded invs so nai...

i was thinking difflib

#

you can change how accurate you want the results to be given your input

#

and change how many results max should it get

brazen charm Aug 12, 2021, 9:31 AM

#

brazen charm keep in mind that there are more than a 100k symbols from the loaded invs so nai...

as an example this is how many results I get with a simple containment check for context locally with fewer inventories that are a bit outdated

In [4]: len( [s for s in bot.get_cog("DocCog").doc_symbols if "context" in s.lower()])
Out[4]: 746

surreal veldt Aug 12, 2021, 9:32 AM

#

Thats fuzzy thing?

vale ibex Aug 12, 2021, 9:32 AM

#

!int e len( [s for s in bot.get_cog("DocCog").doc_symbols if "context" in s.lower()])

stable mountainBOT Aug 12, 2021, 9:32 AM

#

In [2]: len( [s for s in bot.get_cog("DocCog").doc_symbols if "context" in s.lower()])
Out[2]: 792```

vocal prairie Aug 12, 2021, 9:33 AM

#

Does this have anything to do with discord.py? As far as I can see, it doesn't https://github.com/python-discord/sir-lancebot/pull/809

static canyon Aug 12, 2021, 9:33 AM

#

vocal prairie Does this have anything to do with discord.py? As far as I can see, it doesn't <...

It was already discussed above and denied I thought

celest charm Aug 12, 2021, 9:34 AM

#

static canyon It was already discussed above and denied I thought

they submitted another PR

vocal prairie Aug 12, 2021, 9:34 AM

#

Oh wait, there were two

static canyon Aug 12, 2021, 9:34 AM

#

https://github.com/python-discord/sir-lancebot/pull/807

GitHub

Calculator by imranshaji7 · Pull Request #807 · python-discord/sir-...

I created a calculator using python ( i learned python in a week). please do add this as this would be a big achievement and I hope the users will also benefit from this. ( my discord id: 762215365...

#

Yeah, they submitted another one for some reason

short snow Aug 12, 2021, 9:34 AM

#

#dev-contrib message for some reason they opened it again

#

oops wrong ping

#

sorry, dawn ^

vocal prairie Aug 12, 2021, 9:34 AM

#

Akarys closed the first

celest charm Aug 12, 2021, 9:35 AM

#

@echo narwhal Why did you submit another PR? I think we explained that we don't randomly merge other people's projects into the bot, we only merge new commands or changes to existing commands.

short snow Aug 12, 2021, 9:35 AM

#

cc: @echo narwhal why did you open it again?

#

oh god

#

discord is glitching so much

#

sorry for double ping

echo narwhal Aug 12, 2021, 9:36 AM

#

celest charm <@!762215365446598666> Why did you submit another PR? I think we explained that ...

sry did that on accident and i am new to github so i dont understand anything

brazen charm Aug 12, 2021, 9:37 AM

#

surreal veldt Thats fuzzy thing?

no just a simple check for all symbols containing context, I'd imagine fuzzying would get you more matches unless you went for doing it on the whole symbols which would most likely fail because of the library namespaces before the symbols

green oriole Aug 12, 2021, 9:38 AM

#

Build the containers again

surreal veldt Aug 12, 2021, 9:38 AM

#

brazen charm no just a simple check for all symbols containing `context`, I'd imagine fuzzyin...

Ill use difflib, best for this imo

green oriole Aug 12, 2021, 9:39 AM

#

docker-compose build

vocal prairie Aug 12, 2021, 9:40 AM

#

docker compose up --build also works

green oriole Aug 12, 2021, 9:42 AM

#

Huh

#

No idea

vocal prairie Aug 12, 2021, 9:43 AM

#

Google says you need a version of psycopg2 below 2.9 to fix that

#

Oh hmmmm

short snow Aug 12, 2021, 9:52 AM

#

whats the issue again?

#

whats your settings.p?

#

gessing it is django

#

when you said bulma

#

the TIME_ZONE variable to be specific

vale ibex Aug 12, 2021, 9:58 AM

#

what changes have you made to the pyproject file?

#

just bumped bulma?

short snow Aug 12, 2021, 9:58 AM

#

weird, can you confirm it is 2.8.6 in poetry.lock

vale ibex Aug 12, 2021, 9:58 AM

#

to what ver?

short snow Aug 12, 2021, 9:58 AM

#

https://github.com/psycopg/psycopg2/issues/1293

#

maybe it can help

vale ibex Aug 12, 2021, 10:00 AM

#

psycopg2-binary 2.9.1 psycopg2 - Python-PostgreSQL Database Adapter

#

in poetry show --tree

#

lol yea

#

change ~=2.8 to ~2.8

short snow Aug 12, 2021, 10:01 AM

#

short snow weird, can you confirm it is 2.8.6 in poetry.lock

aha, nice, sometimes poetry acts weird

vale ibex Aug 12, 2021, 10:01 AM

#

vale ibex change ~=2.8 to ~2.8

should be fine after this

#

~=2.8 is the same as >=2.8, ==2.*