#dev-contrib | Python | Page 121

slow steppe Jul 16, 2021, 4:01 PM

#

*bot

vocal wolf Jul 16, 2021, 4:02 PM

#

explain.

slow steppe Jul 16, 2021, 4:02 PM

#

That's the whole point

vocal wolf Jul 16, 2021, 4:02 PM

#

lmao

slow steppe Jul 16, 2021, 4:02 PM

#

You had that coming

sleek steppe Jul 16, 2021, 4:03 PM

#

.wa short define

dusky shoreBOT Jul 16, 2021, 4:03 PM

#

Wolfram Alpha

determine the essential quality of

vocal wolf Jul 16, 2021, 4:03 PM

#

very nice

slow steppe Jul 16, 2021, 4:03 PM

#

That's too much effort

#

Wolfram has everything

#

Look I'll gladly write it all if y'all don't want to

gritty wind Jul 16, 2021, 4:05 PM

#

There is a side to contributing that’s often forgotten. Writing code is usually the smallest part, the rest is in review and maintenance.

If you’d like to get discussion on this, feel free to open an issue on the repo

vocal wolf Jul 16, 2021, 4:05 PM

#

Where would you get the definitions from?

gritty wind Jul 16, 2021, 4:05 PM

#

Though it feels redundant given wolfram

slow steppe Jul 16, 2021, 4:06 PM

#

vocal wolf Where would you get the definitions from?

Either an api or just webscrape it from dictionary.com

brazen charm Jul 16, 2021, 4:06 PM

#

the bot doesn't really need yet another module that would just expose some web api

thorny obsidian Jul 16, 2021, 4:34 PM

#

@vocal wolf I want to make an issue for an .epoch commands, which given a date/time or a duration (i.e. 40M (from now)) will spit back out the unix/epoch time to use the discord timestamp feature. Would that be lancebot?

vocal wolf Jul 16, 2021, 4:35 PM

#

that would be lancebot indeed

thorny obsidian Jul 16, 2021, 6:40 PM

#

vocal wolf that would be lancebot indeed

did the thing https://github.com/python-discord/sir-lancebot/issues/787

GitHub

.epoch command · Issue #787 · python-discord/sir-lancebot

Description Discord's timestamp feature will be rolling out to all platforms soon... ish ... probably. This timestamp takes an epoch timestamp to use in a rich/dynamic updating field. More ...

vocal wolf Jul 16, 2021, 6:42 PM

#

yes

#

lmao

#

I am not ~~Xith~~ a bot, therefore I don't know specific epoch times off the top of my head.
well yes of course the current time is about 1626461022.831569

patent pivot Jul 16, 2021, 9:35 PM

#

so

#

as far as I can see

#

multiple processes in snekbox is not harmful from a killing pov

#

they do seem to get killed off

#

I just need to check how memory limits are applied, if it's one per child proc it complicates things

green oriole Jul 16, 2021, 9:42 PM

#

Mmmmm I remember issues I found with child procs, but never really tried them

#

Will have to look into it

#

We probably also want to mount everything but the python binary in noexec

rotund light Jul 17, 2021, 12:08 AM

#

can someone give me an example of epooch?

wild prism Jul 17, 2021, 12:14 AM

#

rotund light can someone give me an example of epooch?

are you asking what epoch time is?

rotund light Jul 17, 2021, 12:16 AM

#

wild prism are you asking what epoch time is?

umm..kinda

wild prism Jul 17, 2021, 12:19 AM

#

it's another name for Unix time, which is the number of seconds since the new year started in 1970 in UTC

#

it's a handy way for computers to represent a particular time without ambiguity

rotund light Jul 17, 2021, 12:20 AM

#

ohh now i get it

#

so..kutiekat is saying to change this epooch time to standard time right?

wild prism Jul 17, 2021, 12:22 AM

#

what she wants is a command that gives you the epoch time for a given date-time

cold island Jul 17, 2021, 12:23 AM

#

This allows you to do something like: <t:1626481254>

#

(assuming you're not on iOS)

wild prism Jul 17, 2021, 12:23 AM

#

it's not super simple though, because the date-time is relative to a timezone, so you'd need to know the timezone to calculate the epoch time

cold island Jul 17, 2021, 12:24 AM

#

wdym

#

!e
Why not:

from datetime import datetime
print(datetime.utcnow().timestamp())```

stable mountainBOT Jul 17, 2021, 12:24 AM

#

@cold island :white_check_mark: Your eval job has completed with return code 0.

1626481471.142881

rotund light Jul 17, 2021, 12:24 AM

#

wild prism what she wants is a command that gives you the epoch time for a given date-time

ohk cool i want to try this

#

so @cold island the dateandtime is given by the user right?

cold island Jul 17, 2021, 12:26 AM

#

yes

wild prism Jul 17, 2021, 12:26 AM

#

cold island !e Why not: ```py from datetime import datetime print(datetime.utcnow().timestam...

Kat wants the command to work for a given datetime, not just right now

cold island Jul 17, 2021, 12:26 AM

#

cold island yes

You can look at examples in the bot on how we usually accept such an argument

rotund light Jul 17, 2021, 12:26 AM

#

cold island yes

okay cool i will make it

cold island Jul 17, 2021, 12:26 AM

#

wild prism Kat wants the command to work for a given datetime, not just right now

The converter takes care of that I believe

#

Hmm actually

#

It handles durations and UTC datetimes

#

Why not just assume UTC?

short snow Jul 17, 2021, 12:47 AM

#

cold island (assuming you're not on iOS)

iOS got support

thorny obsidian Jul 17, 2021, 12:49 AM

#

short snow iOS got support

iOS mobile? A few days ago it didn't

cold island Jul 17, 2021, 12:55 AM

#

Noice

#

Akarys will be delighted

short snow Jul 17, 2021, 1:06 AM

#

iPad

#

Mac also, dunno about mobile

rotund light Jul 17, 2021, 1:15 AM

#

cold island Akarys will be delighted

i am guessing he is from india

vocal prairie Jul 17, 2021, 3:00 AM

#

rotund light i am guessing he is from india

France actually, but that's off topic

rotund light Jul 17, 2021, 5:03 AM

#

vocal prairie France actually, but that's off topic

Ohh

balmy sparrow Jul 17, 2021, 6:40 AM

#

The timestamps seem to work on iOS mobile as well

obsidian patio Jul 17, 2021, 6:42 AM

#

cold island This allows you to do something like: <t:1626481254>

How do you do that? Is it automatic?

#

July 20, 2021 08:42 PM

balmy sparrow Jul 17, 2021, 6:44 AM

#

There's some specific format for it

#

I'm not sure what exactly, just remember it sorta looks like what you get doing \:emoji:

obsidian patio Jul 17, 2021, 6:45 AM

#

Ah

fervent sage Jul 17, 2021, 6:47 AM

#

https://discord.com/developers/docs/reference#message-formatting-timestamp-styles

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

tough imp Jul 17, 2021, 6:49 AM

#

can confirm timestamps work on iphone now

gritty wind Jul 17, 2021, 7:12 AM

#

Hmm, not seeing updates on the store or anything

vale ibex Jul 17, 2021, 7:17 AM

#

probably gradual roll out

fallen patrol Jul 17, 2021, 8:09 AM

#

gritty wind Hmm, not seeing updates on the store or anything

@tough imp @gritty wind what ios version and app versions

fallen patrol Jul 17, 2021, 8:10 AM

#

balmy sparrow I'm not sure what exactly, just remember it sorta looks like what you get doing ...

<t:unix>

gritty wind Jul 17, 2021, 8:11 AM

#

~~latest and latest~~
14.6 & 80.0 I think

tough imp Jul 17, 2021, 8:11 AM

#

my Discord is 82.0

#

that'll be it

gritty wind Jul 17, 2021, 8:12 AM

#

That seems to be latest on the store, not sure why I’m not getting an update in that case

#

Alright, feel free to push forward in that case

vale ibex Jul 17, 2021, 8:20 AM

#

Pushing an update to apple/google stores don't hit all regions at the same time

#

I've found it can take >a week sometimes for apps in multiple countries

green oriole Jul 17, 2021, 9:08 AM

#

Timestamps are rolled out everywhere? lemon_hyperpleased

#

https://github.com/python-discord/bot/pull/1666

GitHub

Make use of the new Discord features by Akarys42 · Pull Request #16...

Bump embed limit to 4096 characters
Use localized timestamps

rotund light Jul 17, 2021, 9:42 AM

#

wow how do u guys get so advance ?

green oriole Jul 17, 2021, 9:53 AM

#

What do you mean by that?

#

:(

rotund light Jul 17, 2021, 10:22 AM

#

green oriole What do you mean by that?

I mean..until I saw this bots code i didnt knew there were these many methods and functions 🤯just mind blown lol

green oriole Jul 17, 2021, 10:26 AM

#

Haha, reading source code is a very good way to learn some specific tricks

brazen charm Jul 17, 2021, 10:27 AM

#

Most of the code is also decoupled so it's not as hard as it looks at first glance

short snow Jul 17, 2021, 10:40 AM

#

If you are taking about the docs code then you are probably right, pokenmonmaster

short snow Jul 17, 2021, 12:07 PM

#

Whats the reason for putting python-dotenv = "~=0.17.1" in dev deps in bot?

patent pivot Jul 17, 2021, 12:07 PM

#

in prod we don't use dotenv

short snow Jul 17, 2021, 12:08 PM

#

ah ok

patent pivot Jul 17, 2021, 12:10 PM

#

prod env vars are injected by k8s (through docker env vars)

cold island Jul 17, 2021, 12:41 PM

#

green oriole Timestamps are rolled out everywhere? <:lemon_hyperpleased:754441879822663811>

If it hasn't reached all regions yet then we shouldn't hurry to merge it

green oriole Jul 17, 2021, 12:42 PM

#

Yep, we will see when it is ready to merge if it has been rolled to every region

#

It will probably take more time for us to review than for the store to roll out, or we can wait once it is ready

patent pivot Jul 17, 2021, 1:11 PM

#

@tawdry vapor @glacial veldt investigating multiprocs on snekbox, limits are certainly shared somehow, my test script is ```py
import os
from multiprocessing import Process

items = [1, 2, 3, 4]

def func(item):
a = "A" * 30_000_000
print(f"PID: {os.getpid()} - Processing: {item}")

if name == 'main':
procs = []

for item in items:
    p = Process(target=func, args=(item,))
    p.start()
    procs.append(p)

for proc in procs:
    proc.join()

for proc in procs:
    print(proc.exitcode)

#

#

killing is a little bit inconsistent, with the same limits sometimes one gets killed, sometimes two, etc.

#

testing how zombies are handled now

#

as far as I can see, things do get killed

green oriole Jul 17, 2021, 1:31 PM

#

Now my question is can you spawn a thread under another CGroup

glacial veldt Jul 17, 2021, 1:34 PM

#

As in running a process in one !e consumes a resource from all other concurrent !e calls?

patent pivot Jul 17, 2021, 1:36 PM

#

uhhh

green oriole Jul 17, 2021, 1:36 PM

#

Nah, we create a new cgroup for each eval

patent pivot Jul 17, 2021, 1:36 PM

#

child procs shouldn't be able to spawn into a different cgroup

green oriole Jul 17, 2021, 1:36 PM

#

Bear in mind that I don't know much about cgroups

#

But iirc fork() gives you the option of selecting a new cgroup?

#

Will that mean you have two cgroups under one process

patent pivot Jul 17, 2021, 1:40 PM

#

forked procs by default are going into the same cgroup ```
root@snekbox_dev:/Users/joseph/Desktop/Python/snekbox# cat /sys/fs/cgroup/memory/snekbox-040de838-6259-4414-abc6-a2c61e27d8a8/NSJAIL.57/tasks
57
60

#

fork does not give you any options

#

a process shouldn't be able to rehome itself in the pids or memory cgroups because we don't mount /sys/

#

okay — as far as I can see multiple processes seems to be safe within snekbox, so I'm going to open a PR to bump max PIDs to 5

#

https://github.com/python-discord/snekbox/pull/112

GitHub

Increase available PIDs to 5 by jb3 · Pull Request #112 · python-di...

This PR increases the PIDs cgroup limit to 5. Processes spawned in snekbox will have up to 5 PIDs available, each sharing the same memory limits and environment as the parent python process. As far...

#

updating some tests now

#

this is my revised unavailable test ```py
def test_subprocess_resource_unavailable(self):
code = dedent("""
import subprocess

        # Max PIDs is 5.
        for _ in range(6):
            print(subprocess.Popen(
                [
                    '/usr/local/bin/python3',
                    '-c',
                    'import time; time.sleep(1)'
                ],
            ).pid)
    """).strip()

    result = self.nsjail.python3(code)
    self.assertEqual(result.returncode, 1)
    self.assertIn("Resource temporarily unavailable", result.stdout)
    self.assertEqual(result.stderr, None)

green oriole Jul 17, 2021, 2:09 PM

#

Looks good

patent pivot Jul 17, 2021, 3:22 PM

#

@tawdry vapor I believe this tests multiproc resource limit sharing, just asserting that one of the child processes is SIGKILL'd ```py
def test_multiprocess_resource_limits(self):
code = dedent("""
import time
from multiprocessing import Process

        def f():
            object = "A" * 40_000_000
            time.sleep(0.5)


        proc_1 = Process(target=f)
        proc_2 = Process(target=f)

        proc_1.start()
        proc_2.start()

        proc_1.join()
        proc_2.join()

        print(proc_1.exitcode, proc_2.exitcode) 
    """)

    result = self.nsjail.python3(code)

    exit_codes = result.stdout.strip().split()
    self.assertIn("-9", exit_codes)
    self.assertEqual(result.stderr, None)

#

will commit now

tawdry vapor Jul 17, 2021, 3:22 PM

#

Yeah looks good enough

patent pivot Jul 17, 2021, 3:25 PM

#

pushed

patent pivot Jul 17, 2021, 3:59 PM

#

!eval ```py
from multiprocessing import Process

def f():
print("1234")

proc_1 = Process(target=f)
proc_2 = Process(target=f)

proc_1.start()
proc_2.start()

proc_1.join()
proc_2.join()

print(proc_1.exitcode, proc_2.exitcode)

stable mountainBOT Jul 17, 2021, 3:59 PM

#

@patent pivot :white_check_mark: Your eval job has completed with return code 0.

001 | 1234
002 | 1234
003 | 0 0

patent pivot Jul 17, 2021, 3:59 PM

#

sweet

#

cc @glacial veldt, up to 5 procs in snekbox now

glacial veldt Jul 17, 2021, 4:33 PM

#

Nice tyvm

rotund light Jul 17, 2021, 4:42 PM

#

green oriole Haha, reading source code is a very good way to learn some specific tricks

Ohh 1st trick

rotund light Jul 17, 2021, 4:42 PM

#

brazen charm Most of the code is also decoupled so it's not as hard as it looks at first glan...

Mhmm for some people like experienced

rotund light Jul 17, 2021, 4:42 PM

#

short snow If you are taking about the docs code then you are probably right, pokenmonmaste...

I mean the source codes

brazen charm Jul 17, 2021, 4:55 PM

#

rotund light Mhmm for some people like experienced

I mean, the files themselves are easier to understand, but the bot as a whole is not as complicated as it may seem from the amount of code it has because the features more often than not don't interact with other code. But there are some features which are complicated and need to use things like scheduling

glacial veldt Jul 17, 2021, 6:08 PM

#

!e

import anyio.to_thread

async def amain():
    await anyio.to_thread.run_sync(print, "hello")

anyio.run(amain, backend="trio")

stable mountainBOT Jul 17, 2021, 6:08 PM

#

@glacial veldt :white_check_mark: Your eval job has completed with return code 0.

hello

glacial veldt Jul 17, 2021, 6:08 PM

#

embarrassing xD

#

Thanks muchly!

#

!e
I wonder what happens if I use too many threads?

import anyio.to_thread
import time

async def amain():
    async with anyio.create_task_group() as tg:
        for i in range(6):
             tg.start_soon(anyio.to_thread.run_sync, time.sleep, 3)

anyio.run(amain, backend="trio")

stable mountainBOT Jul 17, 2021, 6:15 PM

#

@glacial veldt :x: Your eval job has completed with return code 1.

001 | Traceback (most recent call last):
002 |   File "<string>", line 9, in <module>
003 |   File "/snekbox/user_base/lib/python3.9/site-packages/anyio/_core/_eventloop.py", line 56, in run
004 |     return asynclib.run(func, *args, **backend_options)  # type: ignore
005 |   File "/snekbox/user_base/lib/python3.9/site-packages/trio/_core/_run.py", line 1932, in run
006 |     raise runner.main_task_outcome.error
007 |   File "<string>", line 7, in amain
008 |   File "/snekbox/user_base/lib/python3.9/site-packages/anyio/_backends/_trio.py", line 141, in __aexit__
009 |     raise ExceptionGroup(exc.exceptions) from None
010 | anyio._backends._trio.ExceptionGroup: 2 exceptions were raised in the task group:
011 | ----------------------------
... (truncated - too many lines)

Full output: https://paste.pythondiscord.com/qagikodiva.txt?noredirect

glacial veldt Jul 17, 2021, 6:15 PM

#

Interesting

fallen patrol Jul 17, 2021, 8:37 PM

#

@patent pivot why use tox.ini for isort and not pyproject.toml for king arthur?

patent pivot Jul 17, 2021, 8:37 PM

#

because then I can store isort & flake8 alongside one another

fallen patrol Jul 17, 2021, 8:39 PM

#

what is the advantage to that?

#

asking because I'm configuring a toolchain right now

patent pivot Jul 17, 2021, 8:39 PM

#

well, when you call flake8 it is also checking with isort that imports are compliant

#

because I use flake8-isort

fallen patrol Jul 17, 2021, 8:40 PM

#

have you ever looked at using flake9 which is it a fork of a flake8 that adds pyproject.toml support?

#

!pypi flake9

stable mountainBOT Jul 17, 2021, 8:40 PM

#

flake9 v3.8.3.post2

the modular source code checker: pep8 pyflakes and co

patent pivot Jul 17, 2021, 8:42 PM

#

I try not to use those wrappers that add a minor feature because then it relies on the downstream keeping up to date

#

also I don't think the author of that package has conducted themselves very appropriately

fallen patrol Jul 17, 2021, 8:43 PM

#

patent pivot also I don't think the author of that package has conducted themselves very appr...

Sauce?

patent pivot Jul 17, 2021, 8:43 PM

#

so for now, it's fine in tox.ini

patent pivot Jul 17, 2021, 8:43 PM

#

fallen patrol Sauce?

the first issue? https://gitlab.com/retnikt/flake9/-/issues/1

GitLab

Code of conduct? (#1) · Issues · retnikt / flake9

Does the authors of Flake8 are stubborn retards. violate the code of conduct?

fallen patrol Jul 17, 2021, 8:43 PM

#

ah

patent pivot Jul 17, 2021, 8:43 PM

#

corrected, but not a great look

fallen patrol Jul 17, 2021, 8:43 PM

#

(can black go in tox.ini too?)

patent pivot Jul 17, 2021, 8:43 PM

#

no, pyproject is the future

fallen patrol Jul 17, 2021, 8:44 PM

#

patent pivot corrected, but not a great look

hm, yeah. Not a great look at all.

fallen patrol Jul 17, 2021, 8:44 PM

#

patent pivot no, pyproject is the future

So if flake8 isn't going to implement it, do you think they'll ever cave or smth?

patent pivot Jul 17, 2021, 8:44 PM

#

maybe? I mean they have an open issue for it, so we'll just see

fallen patrol Jul 17, 2021, 8:45 PM

#

ah

patent pivot Jul 17, 2021, 8:45 PM

#

i need more things to add to king arthur i am going to brainstorm

fallen patrol Jul 17, 2021, 8:46 PM

#

one last question~

#

you can call isort [tools.isort] or [isort] in tox.ini?

patent pivot Jul 17, 2021, 8:46 PM

#

think it has to be tool.isort, no idea

fallen patrol Jul 17, 2021, 8:46 PM

#

because the code jam called it [isort] and i think it worked

#

interesting

patent pivot Jul 17, 2021, 8:47 PM

#

maybe

#

¯_(ツ)_/¯

green oriole Jul 17, 2021, 11:38 PM

#

patent pivot i need more things to add to king arthur i am going to brainstorm

Describe resources would be great, pulling logs to a pastebin too

patent pivot Jul 17, 2021, 11:39 PM

#

yea

green oriole Jul 17, 2021, 11:41 PM

#

Oh events would be nice too

patent pivot Jul 17, 2021, 11:42 PM

#

yeah I'm considering loading events into loki

rotund light Jul 18, 2021, 12:52 AM

#

brazen charm I mean, the files themselves are easier to understand, but the bot as a whole is...

mhm..true some bots source code are fairly easy to understand some are kinda complicated

#

what does snekbox do?

patent pivot Jul 18, 2021, 12:58 AM

#

snekbox is our evaluation application

#

when you run eval snippets with !eval

#

we don't want to run snippets on our bot because obviously that's dangerous, so we use snekbox which isolates user code safely and executes it

#

!e print("hello")

stable mountainBOT Jul 18, 2021, 12:59 AM

#

@patent pivot :white_check_mark: Your eval job has completed with return code 0.

hello

fallen patrol Jul 18, 2021, 2:20 AM

#

patent pivot we don't want to run snippets on our bot because obviously that's dangerous, so ...

@rotund light

rotund light Jul 18, 2021, 2:22 AM

#

Lol didnt see that 😅

remote wigeon Jul 18, 2021, 3:08 AM

#

patent pivot yeah I'm considering loading events into loki

ok, so, loki is flippin awesome

patent pivot Jul 18, 2021, 3:08 AM

#

+1

#

loki is fun

remote wigeon Jul 18, 2021, 3:09 AM

#

the metrics you can generate with it are op af

patent pivot Jul 18, 2021, 3:09 AM

#

ya

remote wigeon Jul 18, 2021, 3:10 AM

#

now im just annoyed that the brew formula for timescaledb is broken

#

been tryna test some shit

rotund light Jul 18, 2021, 6:47 AM

#

Is there any way we can run the bot without docker?

surreal venture Jul 18, 2021, 6:57 AM

#

rotund light Is there any way we can run the bot without docker?

Yes, using poetry

surreal venture Jul 18, 2021, 6:58 AM

#

patent pivot loki is fun

What's loki?

short snow Jul 18, 2021, 6:59 AM

#

https://grafana.com/oss/loki/6

surreal venture Jul 18, 2021, 6:59 AM

#

Broken link

rotund light Jul 18, 2021, 7:00 AM

#

surreal venture Yes, using poetry

Wait that poetry command ?

short snow Jul 18, 2021, 7:00 AM

#

remove the 6

surreal venture Jul 18, 2021, 7:00 AM

#

rotund light Wait that poetry command ?

Yup

short snow Jul 18, 2021, 7:00 AM

#

poetry run task start

rotund light Jul 18, 2021, 7:00 AM

#

On windows wont work

#

Poetry not found

gritty wind Jul 18, 2021, 7:00 AM

#

Make sure to install it first

#

Pip install poetry

rotund light Jul 18, 2021, 7:00 AM

#

https://grafana.com/oss/loki

Grafana Labs

Grafana Loki

Loki is a horizontally-scalable, highly-available, multi-tenant log aggregation system inspired by Prometheus. It is designed to be very cost effective and …

short snow Jul 18, 2021, 7:00 AM

#

Yes you can run the bot without docker but that would make it a bit complicated making you setup postgres and site as a must, and snekbox if you want eval and redis if you want persistence across runs (it would use fakeredis if not)

#

it is ran on the system

gritty wind Jul 18, 2021, 7:01 AM

#

Then install deps via
poetry install

#

This is all documented in the getting started guide

short snow Jul 18, 2021, 7:01 AM

#

as a cluster component

gritty wind Jul 18, 2021, 7:01 AM

#

Which you’ll really need if you plan to start contributing

rotund light Jul 18, 2021, 7:01 AM

#

gritty wind This is all documented in the getting started guide

It says to download docker

gritty wind Jul 18, 2021, 7:01 AM

#

It mentions that that’s optional, and describes how to do it locally

surreal venture Jul 18, 2021, 7:02 AM

#

rotund light It says to download docker

Docker is optional

rotund light Jul 18, 2021, 7:02 AM

#

Down the docker line yeah I saw that and I ran that too but yeah obvio didnt work cause I didnt install

surreal venture Jul 18, 2021, 7:02 AM

#

Just intall poetry first

rotund light Jul 18, 2021, 7:02 AM

#

Gotcha thanks

surreal venture Jul 18, 2021, 7:03 AM

#

https://python-poetry.org/docs/#installation

Introduction | Documentation | Poetry - Python dependency managemen...

Introduction Poetry is a tool for dependency management and packaging in Python. It allows you to declare the libraries your project depends on and it will manage (install/update) them for you.
System requirements Poetry requires Python 2.7 or 3.5+. It is multi-platform and the goal is to make it work equally well on Windows, Linux and OSX.
Note...

short snow Jul 18, 2021, 7:03 AM

#

i saw you ran sirlance a while back, how did u do that without poetry pithink docker?

rotund light Jul 18, 2021, 7:03 AM

#

short snow i saw you ran sirlance a while back, how did u do that without poetry <:pithink:...

Who me ?

short snow Jul 18, 2021, 7:03 AM

#

yes

rotund light Jul 18, 2021, 7:03 AM

#

I ran that with docker

short snow Jul 18, 2021, 7:03 AM

#

ah

rotund light Jul 18, 2021, 7:04 AM

#

But apparently idk what's happening to my laptop

short snow Jul 18, 2021, 7:04 AM

#

surreal venture https://python-poetry.org/docs/#installation

(Invoke-WebRequest -Uri https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py -UseBasicParsing).Content | python - this is the command

gritty wind Jul 18, 2021, 7:04 AM

#

If you’ve got docker, I’d recommend you at least use it for the site

gritty wind Jul 18, 2021, 7:04 AM

#

short snow `(Invoke-WebRequest -Uri https://raw.githubusercontent.com/python-poetry/poetry/...

Literally pip install poetry smh

rotund light Jul 18, 2021, 7:05 AM

#

gritty wind If you’ve got docker, I’d recommend you at least use it for the site

Docker in my machine atleast it's like bruh it works for the first time I install docker it works then I shut down the computer then tried to run docker bruh didnt work

gritty wind Jul 18, 2021, 7:05 AM

#

Does docker desktop start?

rotund light Jul 18, 2021, 7:05 AM

#

Nope

short snow Jul 18, 2021, 7:05 AM

#

sudo systemctl status docker.service try that, wait you are on windows, whats the alternative scal?

rotund light Jul 18, 2021, 7:06 AM

#

Sudo wont work on windows

short snow Jul 18, 2021, 7:06 AM

#

yeah i dunno win alternative

rotund light Jul 18, 2021, 7:06 AM

#

short snow yeah i dunno win alternative

It's just docker

#

docker

surreal venture Jul 18, 2021, 7:06 AM

#

rotund light It's just docker

Yeah I think so too

short snow Jul 18, 2021, 7:06 AM

#

no i am checking if the docker service is running

surreal venture Jul 18, 2021, 7:06 AM

#

short snow no i am checking if the docker service is running

Docker status or smth?

short snow Jul 18, 2021, 7:07 AM

#

yeah

rotund light Jul 18, 2021, 7:07 AM

#

@short snow u on linux ?

short snow Jul 18, 2021, 7:07 AM

#

yes

rotund light Jul 18, 2021, 7:07 AM

#

That's why xd

short snow Jul 18, 2021, 7:07 AM

#

systemctl show --property ActiveState docker see this, got from so

rotund light Jul 18, 2021, 7:08 AM

#

Xd currently on phone

#

But idk which application to blame for my screen flickering

short snow Jul 18, 2021, 7:09 AM

#

screen flickering 👀 i don't think that is a applicatin issue, probably your screen probablem

#

connect it to a monitor with HDMI or whatever and verify that ^

rotund light Jul 18, 2021, 7:09 AM

#

Yup it happened before but I got to repair before

short snow Jul 18, 2021, 7:09 AM

#

if you don't have monitor just use your tv

#

ah

rotund light Jul 18, 2021, 7:09 AM

#

Idk what happened this time

#

But one thing it solved when I restarted my laptop

patent pivot Jul 18, 2021, 9:26 AM

#

surreal venture What's loki?

Log storage & querying

rotund light Jul 18, 2021, 10:05 AM

#

Lol at first I thought loki from marvel

#

Btw what's redis ?

#

Found while reading the website

green oriole Jul 18, 2021, 10:07 AM

#

Technically it is Loki from the Norse mythology :P

green oriole Jul 18, 2021, 10:07 AM

#

rotund light Btw what's redis ?

It is a very efficient key-value storage. Long story short, a beefy dictionary.

rotund light Jul 18, 2021, 10:08 AM

#

green oriole Technically it is Loki from the Norse mythology :P

True though but yeah I knew loki from marvel then Norse

rotund light Jul 18, 2021, 10:09 AM

#

green oriole It is a very efficient key-value storage. Long story short, a beefy dictionary.

So it's used in docker things? Or just in vanilla python

green oriole Jul 18, 2021, 10:10 AM

#

Yeah, it is a service, just like postgres or so

#

You can run it in a container

rotund light Jul 18, 2021, 10:10 AM

#

Ah databases

rotund light Jul 18, 2021, 10:11 AM

#

green oriole Yeah, it is a service, just like postgres or so

Like mongo db ? Like they have dictornies too

green oriole Jul 18, 2021, 10:11 AM

#

I don't know much about Mongo, but I think so? Don't quote me on that though lemon_sweat

rotund light Jul 18, 2021, 10:13 AM

#

#

Its something like this @green oriole

green oriole Jul 18, 2021, 10:14 AM

#

Hmm Mongo seems more like JSON, you can have nested types - dictionaries inside dictionaries

#

You can't really do that with redis

#

At least not natively

rotund light Jul 18, 2021, 10:15 AM

#

green oriole You can't really do that with redis

Can u give an example cause I was thinking about mongo style lemon_sweat

green oriole Jul 18, 2021, 10:18 AM

#

Sure, the gist of redis is this:

> set mykey somevalue
OK
> get mykey
"somevalue"
```Set a key, get a key

#

Everything being extremely fast even if you have thousands of keys

rotund light Jul 18, 2021, 10:18 AM

#

Ah now I get it

#

It's like whole bunch of dictionaries

green oriole Jul 18, 2021, 10:19 AM

#

It also supports some more fancy stuff, like expirations, lists, sets..

#

It is one big dictionary, yes

short snow Jul 18, 2021, 10:19 AM

#

redis is in-memory database

rotund light Jul 18, 2021, 10:20 AM

#

green oriole It also supports some more fancy stuff, like expirations, lists, sets..

Cool..lol it's like a whole world inside a dictionary 😂

green oriole Jul 18, 2021, 10:23 AM

#

Haha, Redis do think like that

rotund light Jul 18, 2021, 10:27 AM

#

Are all the files in bot directory like main.py and those files for proper working of cogs and resectriction or for any other purpose?

#

Like we can just do the basic way load the cogs

gritty wind Jul 18, 2021, 10:37 AM

#

The init and main do call a few preparation functions such as databases, redis, and other startup stuff

#

The cogs after that are mostly modular

green oriole Jul 18, 2021, 10:40 AM

#

All of our cogs can be loaded separately, but we always need the main files

rotund light Jul 18, 2021, 11:53 AM

#

Ooh now I get it

dapper viper Jul 18, 2021, 4:38 PM

#

hi all

patent pivot Jul 18, 2021, 8:59 PM

#

if people wanna see something cool

#

https://github.com/python-discord/king-arthur/issues/new?assignees=jb3&labels=command&template=command.yaml

GitHub

Build software better, together

GitHub is where people build software. More than 65 million people use GitHub to discover, fork, and contribute to over 200 million projects.

#

😄

vocal prairie Jul 18, 2021, 9:06 PM

#

Woah, that's pretty cool. Fancy new github features

fallen patrol Jul 19, 2021, 2:41 AM

#

fluwushed

#

what happened to @stable mountain (#dev-log)

#

~~starts here #dev-log message~~

cold island Jul 19, 2021, 5:07 AM

#

We were stressing the bot a bit, should be fine now

quartz berry Jul 19, 2021, 1:47 PM

#

wow l

trail pilot Jul 19, 2021, 7:45 PM

#

Uhh..?

green oriole Jul 19, 2021, 7:57 PM

#

Yeah, you haven't updated the channel IDs

#

You have to set environment variables for them, if they are available

sleek steppe Jul 19, 2021, 8:01 PM

#

You don't need to change most of them

trail pilot Jul 19, 2021, 8:38 PM

#

Ah alright, that makes sense

viscid coral Jul 19, 2021, 9:26 PM

#

I suggested to enable charinfo command in #discord-bots channel. (The suggestion was made in #community-meta ). And was told to follow some guide. I am stuck here: https://pythondiscord.com/pages/guides/pydis-guides/contributing/installing-project-dependencies/#installing-dependencies-with-the-command-line

Python Discord - Installing Project Dependencies

A guide to installing the dependencies of our projects.

#

I did this fork thing on github

#

static canyon Jul 19, 2021, 9:53 PM

#

https://github.com/python-discord/bot/blob/main/bot/exts/utils/utils.py#L53

stable mountainBOT Jul 19, 2021, 9:53 PM

#

bot/exts/utils/utils.py line 53

@in_whitelist(channels=(Channels.bot_commands,), roles=STAFF_ROLES)```

static canyon Jul 19, 2021, 9:53 PM

#

All you need to do is update that line to channels=(Channels.bot_commands, Channels.discord_py)

#

As far as I can tell anyway

#

@viscid coral ^

static canyon Jul 19, 2021, 9:55 PM

#

viscid coral I suggested to enable `charinfo` command in <#343944376055103488> channel. (The ...

(I don't actually know how to help with the contributing guide stuff)

cold island Jul 19, 2021, 10:17 PM

#

viscid coral

Do you have git installed on your computer?

viscid coral Jul 20, 2021, 4:02 AM

#

cold island Do you have git installed on your computer?

Yes I am pretty sure I do

viscid coral Jul 20, 2021, 4:02 AM

#

static canyon All you need to do is update that line to `channels=(Channels.bot_commands, Chan...

How can I update it?

static canyon Jul 20, 2021, 6:06 AM

#

viscid coral How can I update it?

If you're signed in to GitHub you can do it from the website

viscid coral Jul 20, 2021, 6:06 AM

#

From my own forked repo?

static canyon Jul 20, 2021, 6:07 AM

#

If you go to the top of the file there's a pencil you can use for editing (greyed out for me because I'm not logged in)

static canyon Jul 20, 2021, 6:07 AM

#

viscid coral From my own forked repo?

On the python-discord one - https://github.com/python-discord/bot/blob/main/bot/exts/utils/utils.py#L53

stable mountainBOT Jul 20, 2021, 6:07 AM

#

bot/exts/utils/utils.py line 53

@in_whitelist(channels=(Channels.bot_commands,), roles=STAFF_ROLES)```

cold island Jul 20, 2021, 6:08 AM

#

Although the proper approach is to edit it locally and make sure it works

cold island Jul 20, 2021, 6:09 AM

#

static canyon On the python-discord one - https://github.com/python-discord/bot/blob/main/bot/...

They don't have write access

#

So if anything it will be on their fork

viscid coral Jul 20, 2021, 6:10 AM

#

So if I edit it on my fork

#

What than?

static canyon Jul 20, 2021, 6:11 AM

#

cold island They don't have write access

Right yea true

#

If you'd like I can do this one and then explain what I did for next time (because I'm honestly not too sure myself) @viscid coral

#

I'd assume https://github.com/python-discord/bot/pulls --> "New Pull Request"

#

But you should probably create a new issue [basically a feature request] about this first (saying pretty much what was said in #community-meta) https://github.com/python-discord/bot/issues

viscid coral Jul 20, 2021, 6:26 AM

#

static canyon But you should probably create a new issue [basically a feature request] about t...

Is that ok?

static canyon Jul 20, 2021, 6:27 AM

#

That's saying what the command does; I'd link it to why it needs to be allowed in #discord-bots specifically

viscid coral Jul 20, 2021, 6:28 AM

#

To add rections?

static canyon Jul 20, 2021, 6:28 AM

#

Possibly lead it with "In order to add a reaction in discordpy, we need the emoji's unicode. For most emojis...."

#

And the lack of space before the ( bothers me lol

#

them( --> them (

viscid coral Jul 20, 2021, 6:29 AM

#

static canyon Jul 20, 2021, 6:29 AM

#

I'd also edit the end slightly to "The best replacement for it is the !charinfo command, which currently isn't allowed in #discord-bots but I feel should be for the above reason" or something like that

static canyon Jul 20, 2021, 6:29 AM

#

viscid coral

To the beginning not the end

viscid coral Jul 20, 2021, 6:30 AM

#

Oh lol

#

In order to add a reaction in discordpy, we need the emoji's unicode. For most emojis.... For most emotes/emojis we can do \:emoji: , but for some of them (such as numbers or letters) this option is not possible. The best replacement for it is the emoji unicode, which can be easily shown in charinfo command.```

static canyon Jul 20, 2021, 6:30 AM

#

For most emojis.... For most emotes/emojis we can do :emoji:

#

Remove the leading "For most emojis..."

static canyon Jul 20, 2021, 6:31 AM

#

static canyon I'd also edit the end slightly to "The best replacement for it is the `!charinfo...

And then this @viscid coral

viscid coral Jul 20, 2021, 6:33 AM

#

 In order to add a reaction in discordpy, we need the emoji's unicode. For most emotes/emojis we can do \:emoji: , but for some of them (such as numbers and letters) this option is not possible. The best replacement for it is the emoji unicode, which can be easily shown in charinfo command. The best replacement for it is the charinfo command, which currently isn't allowed in discord.py, but I feel should be for the above reason.```
I am not the best in English lmao

static canyon Jul 20, 2021, 6:34 AM

#

(such as numbers or letters) -> (such as numbers and letters) (or --> and)

#

And you have "The best replacement for it..." twice

#

In order to add a reaction in discordpy, we need the emoji's unicode. For most emotes/emojis we can do `\:emoji:`, but for some of them (such as numbers and letters) this option is not possible. The best replacement for it is the `!charinfo` command, which currently isn't allowed in discord.py, but I feel should be for the above reason.

viscid coral Jul 20, 2021, 6:35 AM

#

static canyon ``` In order to add a reaction in discordpy, we need the emoji's unicode. For mo...

Yeah ok

short snow Jul 20, 2021, 6:35 AM

#

👀 Just open the issue who is gonna look at the grammar, if the core devs understand the issue that's enough shrug

viscid coral Jul 20, 2021, 6:36 AM

#

https://github.com/python-discord/bot/issues/1684

GitHub

Enable charinfo command in discord_py channel. · Issue #1684 · pyth...

In order to add a reaction in discordpy, we need the emoji's unicode. For most emotes/emojis we can do :emoji: , but for some of them (such as numbers and letters) this option is not possib...

static canyon Jul 20, 2021, 6:36 AM

#

True lol

static canyon Jul 20, 2021, 6:36 AM

#

viscid coral https://github.com/python-discord/bot/issues/1684

That's good 👍

#

Now then

viscid coral Jul 20, 2021, 6:37 AM

#

Now the entire fork thing

green oriole Jul 20, 2021, 6:37 AM

#

Oh hey, is that you? 😄

viscid coral Jul 20, 2021, 6:37 AM

#

Oh hey

static canyon Jul 20, 2021, 6:37 AM

#

viscid coral Now the entire fork thing

When I made my commit I just edited from GitHub but apparently you can't do that so not really sure what you do next lol

green oriole Jul 20, 2021, 6:38 AM

#

I am guessing you want to be assigned to the issue?

#

You can edit from GitHub, it will create a fork automatically

viscid coral Jul 20, 2021, 6:38 AM

#

https://github.com/NIRDERIi/bot Is that the correct fork way?

GitHub

NIRDERIi/bot

The community bot for the Python Discord community - NIRDERIi/bot

green oriole Jul 20, 2021, 6:38 AM

#

yep

viscid coral Jul 20, 2021, 6:39 AM

#

Oh great, so now I should edit what needed?

green oriole Jul 20, 2021, 6:40 AM

#

Yep! https://github.com/NIRDERIi/bot/edit/main/bot/exts/utils/utils.py#L53

viscid coral Jul 20, 2021, 6:40 AM

#

https://github.com/NIRDERIi/bot/blob/main/bot/constants.py#L437 ig it's here?

stable mountainBOT Jul 20, 2021, 6:40 AM

#

bot/constants.py line 437

discord_py: int```

green oriole Jul 20, 2021, 6:40 AM

#

Yeah, that's the constant

viscid coral Jul 20, 2021, 6:40 AM

#

But what to edit there?

#

They all look the same format

#

I need to remove it?

green oriole Jul 20, 2021, 6:41 AM

#

green oriole Yep! <https://github.com/NIRDERIi/bot/edit/main/bot/exts/utils/utils.py#L53>

Right there ^ you want to add Channels.discord_py to the tuple on line 53

viscid coral Jul 20, 2021, 6:41 AM

#

I press it in it says 404

static canyon Jul 20, 2021, 6:41 AM

#

viscid coral I press it in it says 404

Go to your fork

#

Then bot/exts/utils/utils.py

green oriole Jul 20, 2021, 6:42 AM

#

ah, it is a capital i, not an l

viscid coral Jul 20, 2021, 6:42 AM

#

viscid coral Jul 20, 2021, 6:42 AM

#

viscid coral

It's on edit mode here

green oriole Jul 20, 2021, 6:43 AM

#

Yep, you want to add the channel to in_whitelist.channels

#

.. that's what you just did

viscid coral Jul 20, 2021, 6:43 AM

#

Oh so it's ready?

green oriole Jul 20, 2021, 6:43 AM

#

okay 😄 can you remove the last comma and commit?

static canyon Jul 20, 2021, 6:44 AM

#

green oriole okay 😄 can you remove the last comma and commit?

last comma and extra whitespace

viscid coral Jul 20, 2021, 6:44 AM

#

I did the commit

static canyon Jul 20, 2021, 6:44 AM

#

static canyon All you need to do is update that line to `channels=(Channels.bot_commands, Chan...

So that it looks like this

viscid coral Jul 20, 2021, 6:45 AM

#

https://github.com/NIRDERIi/bot/blob/main/bot/exts/utils/utils.py#L52

stable mountainBOT Jul 20, 2021, 6:45 AM

#

bot/exts/utils/utils.py line 52

@in_whitelist(channels=(Channels.bot_commands, Channels.discord_py), roles=STAFF_ROLES)```

static canyon Jul 20, 2021, 6:45 AM

#

Yep

green oriole Jul 20, 2021, 6:45 AM

#

That should be good, you can open a PR now

#

https://github.com/python-discord/bot/compare/main...NIRDERIi:main

static canyon Jul 20, 2021, 6:46 AM

#

(Make sure to add "solves [#yourIssueNumber](linkToIssue)" to the PR message)

viscid coral Jul 20, 2021, 6:46 AM

#

What to do here?

viscid coral Jul 20, 2021, 6:46 AM

#

green oriole <https://github.com/python-discord/bot/compare/main...NIRDERIi:main>

I entered this link

green oriole Jul 20, 2021, 6:46 AM

#

huh, interesting

fervent sage Jul 20, 2021, 6:46 AM

#

it works for me

green oriole Jul 20, 2021, 6:47 AM

#

click compare across forks

viscid coral Jul 20, 2021, 6:47 AM

#

This is what happened when I pressed the link Akarys sent

fervent sage Jul 20, 2021, 6:47 AM

#

ok_handbutflipped

green oriole Jul 20, 2021, 6:47 AM

#

on the left select python-discord/main and on the right NIRDERLi/main

#

Yep, that's what you want

fervent sage Jul 20, 2021, 6:47 AM

#

thats right, now you just click create

viscid coral Jul 20, 2021, 6:47 AM

#

Ok

#

Where should I write wat TizzySaurus said?

#

After I press create pull request?

green oriole Jul 20, 2021, 6:48 AM

#

In the PR body, yes

static canyon Jul 20, 2021, 6:48 AM

#

In the box that shows when you press "Create pull request"

green oriole Jul 20, 2021, 6:48 AM

#

FWIW Closes #1684 is enough

#

You don't have to link it manually

viscid coral Jul 20, 2021, 6:49 AM

#

static canyon Jul 20, 2021, 6:49 AM

#

Just Closes #1684 works apparently

viscid coral Jul 20, 2021, 6:50 AM

#

Oh just Closes #1684 ok

fervent sage Jul 20, 2021, 6:50 AM

#

Closes #1684 is enough, github will automatically link the issue

static canyon Jul 20, 2021, 6:50 AM

#

And then describe the commit you made I guess (add support for !charinfo command in #discord-bots)

green oriole Jul 20, 2021, 6:50 AM

#

and a sentence or two describing the change and why

viscid coral Jul 20, 2021, 6:50 AM

#

Seems like it is in the title

green oriole Jul 20, 2021, 6:50 AM

#

you don't have to be as descriptive as in the issue

fervent sage Jul 20, 2021, 6:51 AM

#

the whole body could be Closes #1684 - added discord.py to the channel whitelist for charinfo

viscid coral Jul 20, 2021, 6:51 AM

#

green oriole Jul 20, 2021, 6:51 AM

#

perfect

viscid coral Jul 20, 2021, 6:51 AM

#

Oh ok

#

I am creating the pull request now

#

https://github.com/python-discord/bot/pull/1685

GitHub

Enabled charinfo for discord_py channel. by NIRDERIi · Pull Request...

Closes #1684
Add support to charinfo command in discord.py channel

#

Was it already approved?

#

lol

fervent sage Jul 20, 2021, 6:52 AM

#

shipit is a 10/10 emote

green oriole Jul 20, 2021, 6:52 AM

#

Now we just wait for linting

viscid coral Jul 20, 2021, 6:53 AM

#

Thank you @green oriole , @static canyon and @fervent sage for the help!

fervent sage Jul 20, 2021, 6:53 AM

#

why are there no smile emojis that arent creepy or outright terrifying lol

viscid coral Jul 20, 2021, 6:54 AM

#

lol you're right

fervent sage Jul 20, 2021, 6:55 AM

#

woo charinfo in ~1 min

viscid coral Jul 20, 2021, 6:56 AM

#

So you can use it there now?

green oriole Jul 20, 2021, 6:57 AM

#

It should be live in a couple of minutes

viscid coral Jul 20, 2021, 6:57 AM

#

Oh ok

green oriole Jul 20, 2021, 6:58 AM

#

You will see a message in #dev-log saying the bot started

viscid coral Jul 20, 2021, 6:59 AM

#

Like that one?

fervent sage Jul 20, 2021, 6:59 AM

#

yup

viscid coral Jul 20, 2021, 6:59 AM

#

green oriole Jul 20, 2021, 6:59 AM

#

Also @fervent sage, would you have, by any chance, a minute or two to spare? :3

fervent sage Jul 20, 2021, 6:59 AM

#

sure!

viscid coral Jul 20, 2021, 6:59 AM

#

Thank you for the help!

green oriole Jul 20, 2021, 6:59 AM

#

https://github.com/python-discord/bot/pull/1666 please review 🥺

GitHub

Make use of the new Discord features by Akarys42 · Pull Request #16...

Bump embed limit to 4096 characters
Use localized timestamps

fervent sage Jul 20, 2021, 6:59 AM

#

anything to take my mind off the oppressive heat lol

fervent sage Jul 20, 2021, 7:08 AM

#

green oriole https://github.com/python-discord/bot/pull/1666 please review 🥺

done :P

green oriole Jul 20, 2021, 7:09 AM

#

thank you sir

#

@vocal wolf hold on

vocal wolf Jul 20, 2021, 7:09 AM

#

?

green oriole Jul 20, 2021, 7:09 AM

#

not sure if timestamps have rolled out everywhere on iOS yet

fervent sage Jul 20, 2021, 7:10 AM

#

they should be out on all platforms, if people update to the latest version

green oriole Jul 20, 2021, 7:10 AM

#

Heyo @gritty wind, do you have access to discord timestamps yet? <t:0:R>

vocal wolf Jul 20, 2021, 7:10 AM

#

green oriole not sure if timestamps have rolled out everywhere on iOS yet

@patent pivot I feel like you'd be the one to know, as you're an apple user.

#

oh lol

green oriole Jul 20, 2021, 7:10 AM

#

Scale didn't have the update last time

short snow Jul 20, 2021, 7:10 AM

#

yeah they have rolled out

green oriole Jul 20, 2021, 7:10 AM

#

The new version is live, just not everywhere last time we checked

viscid coral Jul 20, 2021, 7:13 AM

#

green oriole Heyo <@!386599446571384843>, do you have access to discord timestamps yet? <t:0:...

How did you do that?

fervent sage Jul 20, 2021, 7:13 AM

#

<t:1:R>

viscid coral Jul 20, 2021, 7:14 AM

#

<t:1:R>

#

Cool, but how can I utilize it to time I want

green oriole Jul 20, 2021, 7:15 AM

#

Yep, you have to paste a Unix timestamp

short snow Jul 20, 2021, 7:21 AM

#

Bump, vco's commit reminded me of this

green oriole Jul 20, 2021, 7:27 AM

#

Done transferring, feel free to add priority tags if you wish alec

fervent sage Jul 20, 2021, 7:30 AM

#

hm that reminds me of something i was thinking of, so we all know the .github command is kinda useless now that we have inline resolving, so my proposal is that we make it focus on one PR or issue and provide extra detail, like who authored it, when it was created, and the thing that reminded me, its tags

short snow Jul 20, 2021, 7:32 AM

#

i feel like none of the two issues are part of the quackstack repo as they are related to ducky_australia which are part of branding

#

aren't accessories, just emotes

green oriole Jul 20, 2021, 7:32 AM

#

but the PRs will be made to Quackstack

fervent sage Jul 20, 2021, 7:35 AM

#

fervent sage hm that reminds me of something i was thinking of, so we all know the .github co...

smth like

short snow Jul 20, 2021, 7:36 AM

#

do labels have a hierarchy like discord-roles?

fervent sage Jul 20, 2021, 7:36 AM

#

iirc it depends on the order they're applied

short snow Jul 20, 2021, 7:36 AM

#

we could put the embed colour as the priority level or maybe ^^?

#

like priority level have some colour but parse them and put accordingly?

fervent sage Jul 20, 2021, 7:37 AM

#

we cant guarantee it will have a priority

short snow Jul 20, 2021, 7:37 AM

#

if none, then just keep it blank

fervent sage Jul 20, 2021, 7:37 AM

#

imo we should put the colour of the 'thing'

#

so an open issue is green, closed is red, etc. for prs

short snow Jul 20, 2021, 7:38 AM

#

uhh, like GitHub issues are orange, prs are green when opened?

#

ok maybe

vale ibex Jul 20, 2021, 8:38 AM

#

viscid coral How did you do that?

https://discord.com/developers/docs/reference#message-formatting-timestamp-styles

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

#

😄

#

the last letter changes what it looks like

gritty wind Jul 20, 2021, 9:50 AM

#

green oriole Heyo <@!386599446571384843>, do you have access to discord timestamps yet? <t:0:...

incident_actioned

green oriole Jul 20, 2021, 9:50 AM

#

Sweet

gritty wind Jul 20, 2021, 9:51 AM

#

fervent sage hm that reminds me of something i was thinking of, so we all know the .github co...

I do believe we have considered it at some point, but, with the current iteration of GitHub embeds, I’m not sure what we can do to top it

viscid coral Jul 20, 2021, 9:56 AM

#

green oriole Heyo <@!386599446571384843>, do you have access to discord timestamps yet? <t:0:...

Wait, it converted it in my phone to my language cool

rotund light Jul 20, 2021, 10:37 AM

#

guys i am making a pokemon game

#

just letting u know before i can push

#

||and have to live up to my username 😂 ||

fervent sage Jul 20, 2021, 10:38 AM

#

If it's related to a pydis bot you need to make an issue and have it approved by a core developer before adding features to the bot

rotund light Jul 20, 2021, 10:38 AM

#

fervent sage If it's related to a pydis bot you need to make an issue and have it approved by...

related to sirlance bot

fervent sage Jul 20, 2021, 10:39 AM

#

you need to make an issue at https://github.com/python-discord/sir-lancebot proposing the feature first

rotund light Jul 20, 2021, 10:39 AM

#

okay making one

weary pumice Jul 20, 2021, 5:04 PM

#

i want to start contributing to sir lancebot

#

i just need to follow the instructions and choose an issue or?

#

or is there something else i must do beforehand?

brazen charm Jul 20, 2021, 5:05 PM

#

That's mostly it, set the bot up, pick an issue, get assigned and work on it

weary pumice Jul 20, 2021, 5:12 PM

#

ah that is quite nice

wild prism Jul 20, 2021, 5:17 PM

#

weary pumice ah that is quite nice

you can also write up your own issue if you have an idea, just make sure to get approval before a PR though

weary pumice Jul 20, 2021, 5:29 PM

#

allright

#

well i dont really know what the bot does tbh, im just in for some python experience

#

taking a break from my main lang and exploring some other langs

gritty wind Jul 20, 2021, 6:09 PM

#

100%

vale ibex Jul 20, 2021, 6:10 PM

#

Just remember us when you're famous

weary pumice Jul 20, 2021, 6:30 PM

#

😳

#

he has vector in dirac notation for profile pic?

#

he must be based

rotund light Jul 21, 2021, 4:24 AM

#

rotund light guys i am making a pokemon game

Um…permission ?

viscid coral Jul 21, 2021, 6:29 AM

#

Permission for what?

fervent sage Jul 21, 2021, 6:30 AM

#

rotund light Um…permission ?

patience kek

rotund light Jul 21, 2021, 6:46 AM

#

fervent sage patience <:kek:585617800257863727>

Okay.. pithink lemon_swag

gritty wind Jul 21, 2021, 10:23 AM

#

Anyone play around with the new issue template features?

#

~~It seems contact info overrides any other templates~~

#

~~Can't figure out how to get everything to show up~~

#

~~I take that back, it seems to be the blank issues flag that does it~~

#

hmm that's not it either, I've removed the entire file lol

short snow Jul 21, 2021, 10:57 AM

#

how do u make one? I cannot see any place in the UI to do so? just write the yaml and push it?

gritty wind Jul 21, 2021, 11:11 AM

#

It'll prompt you in various places, such as the settings tab, but you can also just push it

green oriole Jul 21, 2021, 11:13 AM

#

gritty wind Anyone play around with the new issue template features?

https://github.com/python-discord/king-arthur/issues/new?assignees=jb3&labels=command&template=command.yaml 😄

gritty wind Jul 21, 2021, 11:21 AM

#

That's nice and all, but it really doesn't solve the problem lol

#

I figure it's because I was testing on a repo that doesn't have it enabled

#

I'll push it to the actual forms repo and see how that goes

green oriole Jul 21, 2021, 11:24 AM

#

templates are opt-in waiting list beta, so if you aren't in it, that ain't going to work

short snow Jul 21, 2021, 1:32 PM

#

Re: pixels#122

Nice idea but wouldn't this increase the moderation task on the API, basically say a use authenticates himself with Google, Discord, and GitHub, so he has 3 accounts. If you want to ban him, you would need to get his other two accounts too which can only be done through email checking on the three accounts, (which wouldn't really be liked by many, storing their emails). I can only see this way to completely ban a user from the pixel API from all their accounts.

dusky shoreBOT Jul 21, 2021, 1:32 PM

#

GitHub

IssueOpen Implement several ways of authentication

vale ibex Jul 21, 2021, 1:34 PM

#

If we were to go ahead with this issue, all of the authentication methods would point to the same user

short snow Jul 21, 2021, 1:37 PM

#

According to the status:WIP I think this was discussed in the pixels dev channel so I didn't take it up on the Github issue and rather asked it here.

Umm how would you point to the same user?

green oriole Jul 21, 2021, 1:39 PM

#

We would require you to link your Discord account when activating the other auth methods, I'd say?

short snow Jul 21, 2021, 1:40 PM

#

Oh i didn't think of that, that could be a nice way

green oriole Jul 21, 2021, 1:40 PM

#

Like, you must get a token from your browser first for OAuth, I'm pretty sure. We could have an /activate_token endpoint that will make your OAuth code start working but for that you need a Pixels token to perform the request.

brisk brook Jul 21, 2021, 2:14 PM

#

short snow Re: pixels#122 Nice idea but wouldn't this increase the moderation task on the ...

No, I may have worded it weirdly. Each authentication method would have different ratelimits (but it would of course be the same user).

Say the rate limit is 2/120s, and I have two ways of authentication. Then I could possibly send 4 requests in 120s, but both authentication methods would point to me

brisk brook Jul 21, 2021, 2:18 PM

#

short snow According to the status:WIP I think this was discussed in the pixels dev channel...

This is all kind of pseudo-whatever. But think of it as this way..

We have 2 tables

One central table, this stores some form of internal ID as well as the connection to Discord
Per authentication table that relates to the central user table, this is where we look up and verify users. To see if someone is banned we just check the central table

#

Also you may be confused with the scope of the issue, I don't mean adding several ways for someone to get a pixel token. As in having sign up with GitHub, sign up with Discord, sign up with Google.

I mean that there should be several ways for someone to interact with the pixels API. So we may have JWTs (like now), username + password type of thing, OAuth2, and other interesting technologies.

#

I hope that cleared it up for you

patent pivot Jul 21, 2021, 4:32 PM

#

@tawdry vapor how realistic is it to enable /dev/shm in snekbox

#

multiprocessing and a few other async tools rely on shared mem

tawdry vapor Jul 21, 2021, 4:33 PM

#

If we can find a way to set limits on it then we could enable it

#

It was disabled due to an exploit that allowed using unlimited memory

patent pivot Jul 21, 2021, 4:33 PM

#

ahh

#

yeah that rings a bell

#

hmm so

tawdry vapor Jul 21, 2021, 4:33 PM

#

There might be a cgroup for it, IDK

patent pivot Jul 21, 2021, 4:34 PM

#

the mount would look like ```
mount {
dst: "/dev/shm"
fstype: "tmpfs"
rw: true
}

tawdry vapor Jul 21, 2021, 4:34 PM

#

But it is separate from the normal memory one

patent pivot Jul 21, 2021, 4:34 PM

#

so we just need to figure if nsjail can limit the sizes of the tmpfs' it allocates

tawdry vapor Jul 21, 2021, 4:34 PM

#

I think that is all you have to do, yes.

patent pivot Jul 21, 2021, 4:34 PM

#

I'll have a look into it, thanks for confirming

#

--tmpfsmount|-T VALUE
    List of mountpoints to be mounted as tmpfs (R/W) inside the container. Can be specified multiple times. Supports 'dest' syntax. Alternatively, use '-m none:dest:tmpfs:size=8388608'

#

size arg indicates it supports a limit

#

it might be as simple as throwing size in that map? huh

tawdry vapor Jul 21, 2021, 4:37 PM

#

Perhaps. I never used that before.

#

https://github.com/google/nsjail/blob/master/config.proto#L41-L42

stable mountainBOT Jul 21, 2021, 4:38 PM

#

config.proto lines 41 to 42

/* E.g. size=5000000 for 'tmpfs' */
optional string options = 7 [default = ""];```

patent pivot Jul 21, 2021, 4:38 PM

#

yep, just stumbled across that myself

#

will give it a test locally to verify it behaves as expected, since we're only doing 2 parallel execs we can safely allocate 50mb per execution for shared mem

tawdry vapor Jul 21, 2021, 4:42 PM

#

So that's like 200mb total for memory?

#

50+50 for each gunicorn worker

#

Plus whatever the Falcon app uses

patent pivot Jul 21, 2021, 4:43 PM

#

yep, 200mb total possible for executions and then just overhead

vale ibex Jul 21, 2021, 7:55 PM

#

Would appreciate some eyes on this small fix https://github.com/python-discord/bot/pull/1690

green oriole Jul 21, 2021, 8:07 PM

#

!server

stable mountainBOT Jul 21, 2021, 8:07 PM

#

Server Information

Created: <t:1483877013:R>
Voice region: europe
Features: WELCOME_SCREEN_ENABLED, BANNER, ANIMATED_ICON, RELAY_ENABLED, VIP_REGIONS, DISCOVERABLE, INVITE_SPLASH, THREE_DAY_THREAD_ARCHIVE, NEWS, COMMUNITY, PREVIEW_ENABLED, PARTNERED, VANITY_URL, PRIVATE_THREADS, MEMBER_VERIFICATION_GATE_ENABLED, SEVEN_DAY_THREAD_ARCHIVE
Roles: 86
Member status: status_online 48796 status_offline 181374

Members: 230170

Helpers: 121
Moderation Team: 33
Admins: 15
Owners: 3
Contributors: 39

Channels: 292

Category: 32
News: 8
Staff: 69
Stage_Voice: 1
Text: 174
Voice: 8

green oriole Jul 21, 2021, 8:07 PM

#

Look, I am a good dev now

vale ibex Jul 21, 2021, 8:08 PM

#

vocal prairie Jul 21, 2021, 8:08 PM

#

stable mountain

Why is Europe not capitalized ? pithink

vale ibex Jul 21, 2021, 8:09 PM

#

That's what ctx.guild.region returns

vocal prairie Jul 21, 2021, 8:09 PM

#

I wonder why Discord does that

vale ibex Jul 21, 2021, 8:09 PM

#

We could capitilise I guess

green oriole Jul 21, 2021, 8:10 PM

#

Let's capitilise it

vale ibex Jul 21, 2021, 8:10 PM

#

https://discordpy.readthedocs.io/en/stable/api.html#discord.VoiceRegion

#

these are the possible values

green oriole Jul 21, 2021, 8:10 PM

#

I don't think I have any right to joke on spelling now lemon_zipped

vale ibex Jul 21, 2021, 8:11 PM

#

with there being some with underscores, not sure just capitilising will make it better

green oriole Jul 21, 2021, 8:11 PM

#

I guess you don't always capitalize enum options

vale ibex Jul 21, 2021, 8:11 PM

#

Also, I guess we're not important enough for vip_amsterdam sadge

green oriole Jul 21, 2021, 8:24 PM

#

Why aren't we on VIP regions actually?

vale ibex Jul 21, 2021, 8:27 PM

#

They've been phased out

#

partners and verified servers are upgraded to a high bitrate on all regions

green oriole Jul 21, 2021, 8:30 PM

#

Interesting

summer garden Jul 21, 2021, 8:49 PM

#

stable mountain

why are there 69 staff channels

wild prism Jul 21, 2021, 8:51 PM

#

nice

vale ibex Jul 21, 2021, 9:29 PM

#

Lmfao @green oriole

green oriole Jul 21, 2021, 9:29 PM

#

What again

vale ibex Jul 21, 2021, 9:29 PM

#

Did you also struggle and do it via Web ui?

green oriole Jul 21, 2021, 9:29 PM

#

I don't want to grab my laptop again

vale ibex Jul 21, 2021, 9:29 PM

#

I did the same

green oriole Jul 21, 2021, 9:29 PM

#

Yea

#

Haha

#

We have two PRs

#

Great

vale ibex Jul 21, 2021, 9:30 PM

#

Oh yea

green oriole Jul 21, 2021, 9:30 PM

#

I trust yours more than mine

vale ibex Jul 21, 2021, 9:30 PM

#

I would lol

green oriole Jul 21, 2021, 9:30 PM

#

Oh actually, I can't approve

vale ibex Jul 21, 2021, 9:30 PM

#

I had to make 2 branches because of autocorrect lol

green oriole Jul 21, 2021, 9:30 PM

#

Haha

vale ibex Jul 21, 2021, 9:32 PM

#

I had to load desktop version on my phone to approve it

green oriole Jul 21, 2021, 9:32 PM

#

Yay, that's probably the most risk I ever took to make a PR

vale ibex Jul 21, 2021, 9:32 PM

#

Lol

green oriole Jul 21, 2021, 9:32 PM

#

Glad it is merged

patent pivot Jul 21, 2021, 10:14 PM

#

hmm, I can't find a great way to figure out if /dev/shm limiting is working

#

well

#

when I try this poc I get exit code 135

nsjail conf:

mount {
    dst: "/dev/shm"
    fstype: "tmpfs"
    rw: true,
    options: "size=12"
}

python:

            from multiprocessing.shared_memory import SharedMemory
            try:
                mem = SharedMemory('test', create=True, size=128_000)
                mem.buf[:128_000] = bytearray([1] * 128_000)
            except FileExistsError:
                pass

#

but it seems to have to be significantly higher to trigger it

patent pivot Jul 21, 2021, 10:45 PM

#

hmm, if I try ```
mount {
dst: "/dev/shm"
fstype: "tmpfs"
rw: true
is_bind: false
options: "size=10M"
}

and ```py
            with open("/dev/shm/test", "w") as f:
                f.write("H" * 15_000_000)

I get Traceback (most recent call last):\n File "<string>", line 2, in <module>\nOSError: [Errno 27] File too large\n

#

which seems promising

#

and now with multiprocessing shm I can reproduce that ```py
from multiprocessing import shared_memory
shm_a = shared_memory.SharedMemory(create=True, size=15_000_000)
shm_a.buf[:15_000_000] = bytearray([1] * 15_000_000)

#

my guess is that the tiny byte limits aren't enforced by the kernel

#

I'm going with 40mb of shm

#

hmmm

#

hmmm

#

Traceback (most recent call last):
  File "<string>", line 8, in <module>
  File "/usr/local/lib/python3.9/multiprocessing/context.py", line 119, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild,
  File "/usr/local/lib/python3.9/multiprocessing/pool.py", line 242, in __init__
    self._task_handler.start()
  File "/usr/local/lib/python3.9/threading.py", line 892, in start
    _start_new_thread(self._bootstrap, ())
RuntimeError: can't start new thread

#

I wonder what limit this is

#

okay so

#

it's the PIDs limit

#

because even with pool size two multiprocessing seems to be trying to spawn over 5 threads?

#

okay, because it allows mp.Pool to work, I'm going to set the PIDs limit to 6

tawdry vapor Jul 21, 2021, 11:16 PM

#

Is it related to

processes is the number of worker processes to use. If processes is None then the number returned by os.cpu_count() is used.

#

How reliable is setting it to 6? Ideally we should understand why 6 works

sharp timber Jul 21, 2021, 11:24 PM

#

!e print(import('os').cpu_count())

stable mountainBOT Jul 21, 2021, 11:24 PM

#

@sharp timber :white_check_mark: Your eval job has completed with return code 0.

sharp timber Jul 21, 2021, 11:26 PM

#

There are three handler threads within Pool(), 2 PID's for the pool threads, and presumably one more for the main thread

#

!e ```py
import multiprocessingimport multiprocessing
import threading

if name == "main":
multiprocessing.set_start_method('fork')
pool = multiprocessing.Pool()
print(threading.get_ident())
print(pool._worker_handler.ident)
print(pool._task_handler.ident)
print(pool._result_handler.ident)
print(pool._pool)

#

Won't run cause shm isn't enabled rn I think?

#

My machine gives:

#

4445253128
123145553616898
123145570406402
123145587195906
[<ForkProcess name='ForkPoolWorker-1' pid=1129 parent=1113 started daemon>, <ForkProcess name='ForkPoolWorker-2' pid=1130 parent=1113 started daemon>, <ForkProcess name='ForkPoolWorker-3' pid=1131 parent=1113 started daemon>, <ForkProcess name='ForkPoolWorker-4' pid=1132 parent=1113 started daemon>, <ForkProcess name='ForkPoolWorker-5' pid=1133 parent=1113 started daemon>, <ForkProcess name='ForkPoolWorker-6' pid=1134 parent=1113 started daemon>, <ForkProcess name='ForkPoolWorker-7' pid=1135 parent=1113 started daemon>, <ForkProcess name='ForkPoolWorker-8' pid=1136 parent=1113 started daemon>]

#

4+workers

tawdry vapor Jul 22, 2021, 12:24 AM

#

What determines cpu_count in our prod env?

#

I think what we would need to do is check the configured PID limit and override it if it's insufficient for creating a pool

#

By comparing the config against 4 + cpu_count

#

That being said, I also don't want to force users to allow a high PID count. Maybe there needs to be an optional argument to enable what I described above.

patent pivot Jul 22, 2021, 1:14 AM

#

!int e print(import("os").cpu_count())

stable mountainBOT Jul 22, 2021, 1:14 AM

#

In [1]: print(__import__("os").cpu_count())
4```

patent pivot Jul 22, 2021, 1:15 AM

#

that's interesting

patent pivot Jul 22, 2021, 8:45 AM

#

diff CPU count in snekbox

stable mountainBOT Jul 22, 2021, 8:46 AM

#

@clever wraith :white_check_mark: Your eval job has completed with return code 0.

brisk brook Jul 22, 2021, 9:17 AM

#

Wat

eternal owl Jul 22, 2021, 10:53 AM

#

https://github.com/python-discord/site/pull/508
If anyone is free, do have a look at this PR for a review

GitHub

offtopicnames active attribute and support for PUT and PATCH reques...

closes #490
linked to python-discord/bot#1568
Changes

New attribute active for OffTopicName.
Can query based on the active attribute of OffTopicName.
Patch and Put support for OffTopicName.
DETAIL...

cold island Jul 22, 2021, 6:29 PM

#

Hmm the new native relative timestamps lack granularity. I want to know how many parts of a year passed, and not just full years

#

!server

stable mountainBOT Jul 22, 2021, 6:29 PM

#

Server Information

Created: <t:1483877013:R>
Voice region: europe
Features: THREE_DAY_THREAD_ARCHIVE, PRIVATE_THREADS, MEMBER_VERIFICATION_GATE_ENABLED, ANIMATED_ICON, PREVIEW_ENABLED, VANITY_URL, PARTNERED, WELCOME_SCREEN_ENABLED, INVITE_SPLASH, RELAY_ENABLED, DISCOVERABLE, COMMUNITY, BANNER, VIP_REGIONS, NEWS, SEVEN_DAY_THREAD_ARCHIVE
Roles: 86
Member status: status_online 50455 status_offline 180164

Members: 230619

Helpers: 121
Moderation Team: 33
Admins: 15
Owners: 3
Contributors: 39

Channels: 293

Category: 32
News: 8
Staff: 70
Stage_Voice: 1
Text: 174
Voice: 8

brisk brook Jul 22, 2021, 6:33 PM

#

cold island Hmm the new native relative timestamps lack granularity. I want to know how many...

Can't you fine-tune that?

cold island Jul 22, 2021, 6:50 PM

#

As far as I'm aware there's only one format for relative time

green oriole Jul 22, 2021, 7:02 PM

#

cold island Hmm the new native relative timestamps lack granularity. I want to know how many...

You can hover it to see the full timestamp

patent pivot Jul 22, 2021, 7:08 PM

#

i'm going to be doing some devops in #763406158522220544, https://status.pythondiscord.com/incident/98105 this maintenance

viscid coral Jul 22, 2021, 7:21 PM

#

cold island Hmm the new native relative timestamps lack granularity. I want to know how many...

Wdym like 5 years, 2 months 28 days and 5 hours

patent pivot Jul 22, 2021, 7:29 PM

#

https://forms.gle/zSwDrjdajRz7DkuM6 please submit easter eggs

Google Docs

PyDis Easter Egg suggestions

We want an easter egg to add to all Python Discord web responses.

vocal wolf Jul 22, 2021, 7:33 PM

#

Early devops hour with joe?

#

Hello yes

twilit juniper Jul 22, 2021, 7:34 PM

#

kinda

#

but it's just him shit posting

vocal wolf Jul 22, 2021, 7:34 PM

#

understandable

twilit juniper Jul 22, 2021, 7:34 PM

#

I mean it's joe what do you expect

vocal wolf Jul 22, 2021, 7:35 PM

#

I expect it.

#

I can't english either

twilit juniper Jul 22, 2021, 7:35 PM

#

Same

clever wraith Jul 22, 2021, 7:35 PM

#

is this the text channel for the dev-voice channel?

vocal wolf Jul 22, 2021, 7:35 PM

#

clever wraith is this the text channel for the dev-voice channel?

yeah

clever wraith Jul 22, 2021, 7:35 PM

#

vocal wolf yeah

thanks!

fringe sphinx Jul 22, 2021, 7:35 PM

#

the inside of joe banks is abusive lemon_angrysad

Screen_Shot_2021-07-22_at_12.35.47_PM.png

vocal wolf Jul 22, 2021, 7:36 PM

#

dev voice happens so little that there isn't anything else

twilit juniper Jul 22, 2021, 7:36 PM

#

Yeah and it's not open to all people all the time

vocal wolf Jul 22, 2021, 7:36 PM

#

@clever wraith so forgetting is just you segfaulting

twilit juniper Jul 22, 2021, 7:36 PM

#

Just Contributes I think

clever wraith Jul 22, 2021, 7:36 PM

#

so this is a rare privilege!

slow steppe Jul 22, 2021, 7:37 PM

#

patent pivot https://forms.gle/zSwDrjdajRz7DkuM6 please submit easter eggs

Joe do you plan on deleting the link?

vocal wolf Jul 22, 2021, 7:37 PM

#

@vale ibex I shall review your PR this instant, if you are awake.

brisk brook Jul 22, 2021, 7:37 PM

#

Dereferenced NULL pointer

vocal wolf Jul 22, 2021, 7:37 PM

#

the sir lance one

fringe sphinx Jul 22, 2021, 7:37 PM

#

clever wraith so this is a rare privilege!

I wouldn't exactly call listening to a joe rant a privilege

patent pivot Jul 22, 2021, 7:37 PM

#

slow steppe Joe do you plan on deleting the link?

post-stream

fringe sphinx Jul 22, 2021, 7:38 PM

#

my easter egg submission is unbeatable

slow steppe Jul 22, 2021, 7:38 PM

#

No mine is

fringe sphinx Jul 22, 2021, 7:38 PM

#

doubt

clever wraith Jul 22, 2021, 7:38 PM

#

damn, this is hella intresting and I have no idea what's going on

slow steppe Jul 22, 2021, 7:38 PM

#

Vco said mine is the best therefor it is

fervent sage Jul 22, 2021, 7:38 PM

#

fringe sphinx <:doubt:581332132702584833>

no really it is

fringe sphinx Jul 22, 2021, 7:38 PM

#

clever wraith damn, this is hella intresting and I have no idea what's going on

I'm not even in the vc

fringe sphinx Jul 22, 2021, 7:38 PM

#

fervent sage no really it is

what is it lmao

slow steppe Jul 22, 2021, 7:38 PM

#

I'll dm it

vocal wolf Jul 22, 2021, 7:38 PM

#

There's a lot of people here. You know what this means.

#

tryhard triage time

fringe sphinx Jul 22, 2021, 7:38 PM

#

ttt

fervent sage Jul 22, 2021, 7:38 PM

#

vocal wolf There's a lot of people here. You know what this means.

hell?

vocal wolf Jul 22, 2021, 7:39 PM

#

yes

clever wraith Jul 22, 2021, 7:39 PM

#

what's the issue btw?

vocal wolf Jul 22, 2021, 7:39 PM

#

clever wraith what's the issue btw?

There's many

clever wraith Jul 22, 2021, 7:40 PM

#

vocal wolf There's many

gotcha, we're not working on a github repo?

vocal wolf Jul 22, 2021, 7:40 PM

#

we are

#

I just need to allocate issues/PRs to different people

fringe sphinx Jul 22, 2021, 7:40 PM

#

ok it is a beautiful easter egg

vocal wolf Jul 22, 2021, 7:41 PM

#

@hollow cedar I knew I recognized your voice lol

#

I didn't see your name though so I thought I was going crazy

fringe sphinx Jul 22, 2021, 7:41 PM

#

I've never heard their voice

clever wraith Jul 22, 2021, 7:42 PM

#

this is great, there's so much going on

fringe sphinx Jul 22, 2021, 7:42 PM

#

i wish I could listen in lol

#

can someone transcribe everything for me

vocal wolf Jul 22, 2021, 7:42 PM

#

fringe sphinx can someone transcribe everything for me

There are multiple people talking at the same time, this will not work

fringe sphinx Jul 22, 2021, 7:42 PM

#

transcribe it in multiple lines

clever wraith Jul 22, 2021, 7:43 PM

#

hahaha

fringe sphinx Jul 22, 2021, 7:43 PM

#

🙄

#

get creative

vocal wolf Jul 22, 2021, 7:43 PM

#

@fervent sage take: https://github.com/python-discord/sir-lancebot/pull/790

#

@wild ridge greetings.

hollow cedar Jul 22, 2021, 7:44 PM

#

vocal wolf <@!123526035059900416> I knew I recognized your voice lol

haha hey

fringe sphinx Jul 22, 2021, 7:44 PM

#

why are they called pull requests? aren't they really push requests?

#

anyone can pull

#

but you need to request to actually make changes

vocal wolf Jul 22, 2021, 7:44 PM

#

fringe sphinx why are they called pull requests? aren't they really push requests?

pulling into main

fervent sage Jul 22, 2021, 7:44 PM

#

youre requesting to pull your code into the main branch

fringe sphinx Jul 22, 2021, 7:44 PM

#

but isn't that pushing your code

vocal wolf Jul 22, 2021, 7:44 PM

#

nah

#

if you're main

#

and there's a different branch

#

you're pulling the other branch toward you

clever wraith Jul 22, 2021, 7:44 PM

#

it doesn't happen until you're pulled in

fringe sphinx Jul 22, 2021, 7:44 PM

#

but I'm not main

fervent sage Jul 22, 2021, 7:45 PM

#

fringe sphinx but isn't that pushing your code

you push to your branch and request you have the content of yours pulled into another

brisk brook Jul 22, 2021, 7:45 PM

#

NDA vs. Freedom of Speech

#

Who would win?

vocal wolf Jul 22, 2021, 7:45 PM

#

Alright

#

here's another PR for review

#

https://github.com/python-discord/bot/pull/1686

fringe sphinx Jul 22, 2021, 7:45 PM

#

fervent sage you push to your branch and request you have the content of yours pulled into an...

but isn't the content pushed into the other

#

because you're doing it

fervent sage Jul 22, 2021, 7:45 PM

#

no cause youre not

#

youre requesting

hollow cedar Jul 22, 2021, 7:45 PM

#

brisk brook NDA vs. Freedom of Speech

everyone loses lol

fervent sage Jul 22, 2021, 7:45 PM

#

for someone else to pull it

fringe sphinx Jul 22, 2021, 7:45 PM

#

this is so confoozling

vocal wolf Jul 22, 2021, 7:45 PM

#

hello @mellow hare

fringe sphinx Jul 22, 2021, 7:45 PM

#

hi

fervent sage Jul 22, 2021, 7:45 PM

#

vocal wolf <https://github.com/python-discord/bot/pull/1686>

ok_handbutflipped

slow steppe Jul 22, 2021, 7:46 PM

#

@patent pivot would you use this as your Mac terminal theme?

clever wraith Jul 22, 2021, 7:46 PM

#

is there a description here of the tech stack that powers the discord server?

vocal wolf Jul 22, 2021, 7:47 PM

#

@vale ibex sir-lancebot#790 merged. Thank you @fervent sage for the review.

dusky shoreBOT Jul 22, 2021, 7:47 PM

#

GitHub

PRMerged Remove user input images

vocal wolf Jul 22, 2021, 7:47 PM

#

clever wraith is there a description here of the tech stack that powers the discord server?

@patent pivot

fringe sphinx Jul 22, 2021, 7:47 PM

#

clever wraith is there a description here of the tech stack that powers the discord server?

joe is our tech stack

fervent sage Jul 22, 2021, 7:47 PM

#

vocal wolf <@!126811506632294400> sir-lancebot#790 merged. Thank you <@!297045071457681409>...

~~can i put it in changelog~~ KEKW

vocal wolf Jul 22, 2021, 7:47 PM

#

lmfao

mellow hare Jul 22, 2021, 7:48 PM

#

Hi Xith

fringe sphinx Jul 22, 2021, 7:48 PM

#

fervent sage ~~can i put it in changelog~~ <:KEKW:781655746311618600>

do you even have perms

fervent sage Jul 22, 2021, 7:48 PM

#

yes

mellow hare Jul 22, 2021, 7:48 PM

#

You're awesome

#

That is all

fringe sphinx Jul 22, 2021, 7:48 PM

#

oh

vocal wolf Jul 22, 2021, 7:48 PM

#

:D

fervent sage Jul 22, 2021, 7:48 PM

#

mellow hare You're awesome

hem

#

youre cool

mellow hare Jul 22, 2021, 7:48 PM

#

I mean that's objectively false

vocal wolf Jul 22, 2021, 7:48 PM

#

I was literally about to ask you to review stuff hem

#

are you available for that

mellow hare Jul 22, 2021, 7:48 PM

#

Which stuff?

vocal wolf Jul 22, 2021, 7:48 PM

#

infraction type stuff

mellow hare Jul 22, 2021, 7:48 PM

#

I can try to be yeah

fervent sage Jul 22, 2021, 7:48 PM

#

hem youre too hot and want the sun to go away

mellow hare Jul 22, 2021, 7:48 PM

#

Just just toss me the pr

fringe sphinx Jul 22, 2021, 7:48 PM

#

vocal wolf I was literally about to ask you to review stuff hem

that's why he complimented you - so you'd feel bad asking him for something

#

it's all part of his master plan

mellow hare Jul 22, 2021, 7:48 PM

#

fervent sage hem youre too hot and want the sun to go away

That is actually correct

mellow hare Jul 22, 2021, 7:49 PM

#

fringe sphinx that's why he complimented you - so you'd feel bad asking him for something

That'd be some serious foresight on my part

vocal wolf Jul 22, 2021, 7:49 PM

#

@mellow hare (and anyone else, if you're up to it) bot#1682, bot#1680.

dusky shoreBOT Jul 22, 2021, 7:49 PM

#

GitHub

PROpen Add command to resend infraction DM
PROpen Allow manual mutes to override auto mutes

fervent sage Jul 22, 2021, 7:49 PM

#

oh i thought i approved the second one a while back lol

fringe sphinx Jul 22, 2021, 7:49 PM

#

I am bad at contributioning so that'll be a pass

hoary anvil Jul 22, 2021, 7:49 PM

#

28 people in vc O_O

fervent sage Jul 22, 2021, 7:50 PM

#

i tested and apparently forgot to approve

fringe sphinx Jul 22, 2021, 7:50 PM

#

hoary anvil 28 people in vc O_O

29

#

30

#

31

#

30

#

numbers be weird

hoary anvil Jul 22, 2021, 7:50 PM

#

/O_O\

mellow hare Jul 22, 2021, 7:50 PM

#

This is typically why I cap it at 25 in the other VCs

#

This is a special case going on

fervent sage Jul 22, 2021, 7:51 PM

#

we shouldnt have changed the perms lol

clever wraith Jul 22, 2021, 7:51 PM

#

fringe sphinx joe is our tech stack

lol, no seriously 🤣

hoary anvil Jul 22, 2021, 7:51 PM

#

fringe sphinx joe is our tech stack

such a pity he runs on macos

#

but at least it isn't windows

fringe sphinx Jul 22, 2021, 7:51 PM

#

clever wraith lol, no seriously 🤣

everything in the picture in #announcements is part of the tech stack

fervent sage Jul 22, 2021, 7:52 PM

#

where is redis

fringe sphinx Jul 22, 2021, 7:52 PM

#

getting dissed

#

again

#

redissed

clever wraith Jul 22, 2021, 7:52 PM

#

hoary anvil such a pity he runs on macos

I'm on a macos right now, linux distros are hard to configure for a daily driver cleanly

brisk brook Jul 22, 2021, 7:52 PM

#

The thing is, it's so easy to just gender someone correctly and it shows so much in terms of respect.

fringe sphinx Jul 22, 2021, 7:52 PM

#

nope

hoary anvil Jul 22, 2021, 7:52 PM

#

worked fine for me
depends on the linux distro, perhaps
or the pc

vocal wolf Jul 22, 2021, 7:53 PM

#

clever wraith I'm on a macos right now, linux distros are hard to configure for a daily driver...

you're going to make me arch btw

mellow hare Jul 22, 2021, 7:53 PM

#

Dude and yall

fervent sage Jul 22, 2021, 7:53 PM

#

yes, if im understanding right

#

you can add multiple remotes and pull/checkout from any

slow steppe Jul 22, 2021, 7:53 PM

#

brisk brook The thing is, it's so easy to just gender someone correctly and it shows so much...

Right. And once again, most people aren't going to get offended if it's an accident, but the problem are those people who purposely missgender others

clever wraith Jul 22, 2021, 7:53 PM

#

vocal wolf you're going to make me arch btw

yeah, I've been trying to build out arch as my daily driver. it's a real pain. turns out, there's a lot about an OS that I took for granted

hoary anvil Jul 22, 2021, 7:53 PM

#

brisk brook The thing is, it's so easy to just gender someone correctly and it shows so much...

depends
I have real issues remembering that some people here are male instead of female, or vice versa

hoary anvil Jul 22, 2021, 7:54 PM

#

clever wraith yeah, I've been trying to build out arch as my daily driver. it's a real pain. t...

now arch is a pain

fervent sage Jul 22, 2021, 7:54 PM

#

git remote add <name> <repo>
git checkout my-remote-branch

fringe sphinx Jul 22, 2021, 7:54 PM

#

hoary anvil depends I have real issues remembering that some people here are male instead of...

so just use they/them/their if you can't remember

vocal wolf Jul 22, 2021, 7:54 PM

#

clever wraith yeah, I've been trying to build out arch as my daily driver. it's a real pain. t...

It took me a long time to get it right, but I learned a metric ton of stuff along the way.

brisk brook Jul 22, 2021, 7:54 PM

#

slow steppe Right. And once again, most people aren't going to get offended if it's an accid...

Like that video of someone refusing to call an african-american woman by Doctor

clever wraith Jul 22, 2021, 7:54 PM

#

vocal wolf It took me a long time to get it right, but I learned a metric ton of stuff alon...

would love to swap notes

hoary anvil Jul 22, 2021, 7:54 PM

#

fringe sphinx so just use they/them/their if you can't remember

can't remember to do that either

fringe sphinx Jul 22, 2021, 7:54 PM

#

hoary anvil can't remember to do that either

that's something you should actively try to do

#

it's hard, I tend to default to he/him/his too

slow steppe Jul 22, 2021, 7:55 PM

#

brisk brook Like that video of someone refusing to call an african-american woman by Doctor

Yep. It happens a lot in real life too, and it really really sucks

fringe sphinx Jul 22, 2021, 7:55 PM

#

but it's respectful

vocal wolf Jul 22, 2021, 7:55 PM

#

clever wraith would love to swap notes

I don't have actual physical notes, but if you're having trouble ping me in an ot channel and I'll do my best to help.

hoary anvil Jul 22, 2021, 7:55 PM

#

fringe sphinx that's something you should actively try to do

I know, I just forget

clever wraith Jul 22, 2021, 7:55 PM

#

language is a weapon folks, learn how you're being manipulated, and navigate from there

patent pivot Jul 22, 2021, 7:56 PM

#

let's try keep dev contrib on topic for dev stuff, we are in dev voice right now 😃

fervent sage Jul 22, 2021, 7:56 PM

#

patent pivot let's try keep dev contrib on topic for dev stuff, we are in dev voice right now...

its too late lol

#

i dont have the mental capacity rn to explain git stuff sorry

clever wraith Jul 22, 2021, 7:57 PM

#

might be a good idea to build another channel just for the meta for this one

#

I see #867857957299290152

fervent sage Jul 22, 2021, 7:57 PM

#

we have #751591688538947646 and #799641437645701151

mellow hare Jul 22, 2021, 7:58 PM

#

Just made a #867857957299290152 channel for folks - yep

patent pivot Jul 22, 2021, 7:58 PM

#

cheers hem

mellow hare Jul 22, 2021, 7:58 PM

#

But it's likely better to scoot down to the other channels

fervent sage Jul 22, 2021, 7:58 PM

#

all the chatter belongs in the non dev vcs and vc chats tbh

mellow hare Jul 22, 2021, 7:58 PM

#

Yes yes I know

patent pivot Jul 22, 2021, 7:58 PM

#

update: nginx deployed, https://policy-bot.pythondiscord.com/ is now serving through nginx

fervent sage Jul 22, 2021, 7:58 PM

#

x-test: b

#

success!

vocal wolf Jul 22, 2021, 7:59 PM

#

how do you ping a voice channel again

fervent sage Jul 22, 2021, 7:59 PM

#

#!

slow steppe Jul 22, 2021, 7:59 PM

#

<#id>

#

#751591688538947646

thorny obsidian Jul 22, 2021, 7:59 PM

#

@patent pivot maybe you want to disable devops alerts? =P

vocal wolf Jul 22, 2021, 8:00 PM

#

an organized clusterfuck

mellow hare Jul 22, 2021, 8:00 PM

#

vocal wolf an organized clusterfuck

Band name

vocal wolf Jul 22, 2021, 8:00 PM

#

holy shit

#

@mellow hare Please review those PRs if you're able to. On a completely different note: morning.

mellow hare Jul 22, 2021, 8:02 PM

#

Yes yes yes

vocal wolf Jul 22, 2021, 8:02 PM

#

yes

#

@twilit juniper destroyed.

#

@fervent sage what's in the makefile lol

fervent sage Jul 22, 2021, 8:09 PM

#

uh

#

https://xkcd.com/378/

xkcd: Real Programmers

green oriole Jul 22, 2021, 8:32 PM

#

/shrug

#

I don't know the library

vale ibex Jul 22, 2021, 8:40 PM

#

vocal wolf <@!126811506632294400> I shall review your PR this instant, if you are awake.

Awake but not home

vocal wolf Jul 22, 2021, 8:40 PM

#

understandable, have fun at <place>

vale ibex Jul 22, 2021, 9:22 PM

#

It was a very nice place

#

It had sheep, cows and llamas

#

I had a burger for dinner and was wondering if it was one of the cows family

#

Gotta love British countryside pubs

vale ibex Jul 23, 2021, 9:00 AM

#

Anyone know who NotFlameDev on GitHub is on here?

fervent sage Jul 23, 2021, 9:21 AM

#

vale ibex Anyone know who NotFlameDev on GitHub is on here?

:P

vale ibex Jul 23, 2021, 9:21 AM

#

haha yea just saw that myself

#

already updated 👌

patent pivot Jul 23, 2021, 11:52 AM

#

for what service

#

I will when I get time.

static canyon Jul 23, 2021, 11:55 AM

#

Would bot#1642 just be a matter of updating https://github.com/python-discord/bot/blob/main/bot/exts/info/doc/_cog.py#L341-L347? If so might have a go it

dusky shoreBOT Jul 23, 2021, 11:55 AM

#

GitHub

PRMerged Fix helpdm couldn't DM the user

stable mountainBOT Jul 23, 2021, 11:55 AM

#

bot/exts/info/doc/_cog.py lines 341 to 347

if doc_embed is None:
    error_message = await send_denial(ctx, "No documentation found for the requested symbol.")
    await wait_for_deletion(error_message, (ctx.author.id,), timeout=NOT_FOUND_DELETE_DELAY)
    with suppress(discord.NotFound):
        await ctx.message.delete()
    with suppress(discord.NotFound):
        await error_message.delete()```

patent pivot Jul 23, 2021, 11:55 AM

#

📎 deployment.yaml

#

📎 ingress.yaml

#

📎 service.yaml

#

@clever wraith that's site

#

this is bot

📎 deployment.yaml

static canyon Jul 23, 2021, 11:55 AM

#

static canyon Would bot#1642 just be a matter of updating <https://github.com/python-discord/b...

bot#1624

dusky shoreBOT Jul 23, 2021, 11:55 AM

#

GitHub

IssueOpen Do not delete !docs invocation if it contains a ping

patent pivot Jul 23, 2021, 11:56 AM

#

yeah it should just be that

#

it's just one instance on one node

#

no, one total

#

yeah

#

any pod which has the annotations ```yaml
prometheus.io/scrape: true

#

will get scraped

#

uhhh

#

yea

#

https://paste.pythondiscord.com/akuqofebup.yaml?noredirect @clever wraith looks something like this

static canyon Jul 23, 2021, 12:06 PM

#

patent pivot yeah it should just be that

## towards top of file
DELETE_ERROR_MESSAGE_REACTION = '\u274c'  # :x:

...
# inside command
error_message = await send_denial(ctx, "No documentation found for the requested symbol.")

if ctx.message.mentions or ctx.message.role_mentions:
    await error_message.add_reaction(DELETE_ERROR_MESSAGE_REACTION)

    try:
        await self.bot.wait_for(
            'reaction_add',
            check=lambda reaction, user: reaction.message == error_message and user == ctx.author and str(reaction) == DELETE_ERROR_MESSAGE_REACTION,
            timeout=NOT_FOUND_DELETE_DELAY
        )
        
        with suppress(discord.HTTPException):
            await error_message.delete()

    except asyncio.TimeoutError:
        await error_message.clear_reaction(DELETE_ERROR_MESSAGE_REACTION)

else:
    await wait_for_deletion(error_message, (ctx.author.id,), timeout=NOT_FOUND_DELETE_DELAY)
    with suppress(discord.NotFound):
        await ctx.message.delete()
    with suppress(discord.NotFound):
        await error_message.delete()
```maybe something like this?

#

Not sure if the two suppressions are necessary in the else but the current code does 2 so just copied

static canyon Jul 23, 2021, 12:31 PM

#

Does this look right for merging a PR from my fork to Pydis?

patent pivot Jul 23, 2021, 12:33 PM

#

yep!

static canyon Jul 23, 2021, 12:34 PM

#

Let's hope this works then lemon_grimace

#

Need to fix some linting

viscid coral Jul 23, 2021, 12:45 PM

#

What does that mean?

placid ermine Jul 23, 2021, 12:47 PM

#

that linting failed, specifically:

viscid coral Jul 23, 2021, 12:50 PM

#

line too long?

#

Is that a thing

#

Maybe somehow use black( #black-formatter )?

thorny obsidian Jul 23, 2021, 12:52 PM

#

Black isn't compatible with our style guidelines. We do have a pre-commit hook people can use if they want.

viscid coral Jul 23, 2021, 12:53 PM

#

Oh

#

How can I see the line that is too long?

gritty wind Jul 23, 2021, 12:55 PM

#

Hey have a look at our contributing guide to learn how to setup all our tools (linting with flake, and pre-commit)

static canyon Jul 23, 2021, 12:58 PM

#

Let's see if this works

#

God damn it

#

Don't understand that

#

Is there any error in the code?

#

Forgot to import partial

#

Missing a , now lol

vale ibex Jul 23, 2021, 1:04 PM

#

You can do poetry run task precommit to install the pre-commit hooks

#

Assuming you have done poetry install already

static canyon Jul 23, 2021, 1:06 PM

#

I really should be can't be bothered to set everything up on my laptop lol

#

Did on my PC and it was a real hassle for me

#

Can't figure out what's wrong now lemon_grimace

#

Not got any errors in my IDE

gritty wind Jul 23, 2021, 1:13 PM

#

You have trailing white space on a few lines

#

Like:
‘print(“hi, notice the space after me”) ‘

#

I really wouldn’t recommend using the CI as your personal linter, it’ll probably be more hassle than it’s worth

brisk brook Jul 23, 2021, 1:15 PM

#

static canyon Not got any errors in my IDE

Which IDE are you using?

static canyon Jul 23, 2021, 1:15 PM

#

PyCharm

static canyon Jul 23, 2021, 1:15 PM

#

gritty wind You have trailing white space on a few lines

You sure?

gritty wind Jul 23, 2021, 1:16 PM

#

That’s what the CI is saying currently

#

I’m on mobile so it’s a bit hard to pull the actual line

static canyon Jul 23, 2021, 1:18 PM

#

Think I found one line at the end

gritty wind Jul 23, 2021, 1:19 PM

#

If you run the hook locally, it’ll actually fix it for you

static canyon Jul 23, 2021, 1:21 PM

#

I can't run it locally cause I haven't set it up

#

Can't find any trailing whitespace either

#

Gonna try setting everything up on my laptop

vale ibex Jul 23, 2021, 1:29 PM

#

There's no rush on making these changes, if you wanted to wait until you were back at your PC

#

Also, if you run into any issues feel free to ask here

static canyon Jul 23, 2021, 1:41 PM

#

I really can't figure this out

#

I've downloaded everything into PyCharm, and have installed dependencies via poetry

#

Then copy-pasted the code I committed into PyCharm and the only issues are ones that isn't really to what I did (e.g. Unresolved attribute reference 'trace' for class 'Logger' and Unresolved attribute reference 'endswith' for class 'ValidURL')

#

But if those are errors then why is the bot working right now?

brazen charm Jul 23, 2021, 1:45 PM

#

They're not errors, just the static checker not understanding non type hint annotations and dynamic code

static canyon Jul 23, 2021, 1:45 PM

#

Right, but then what's the issue with my code that's making the lint fail?

#

This lint: https://github.com/python-discord/bot/pull/1694/checks?check_run_id=3143774397

thorny obsidian Jul 23, 2021, 1:46 PM

#

A trailing whitespace somewhere

static canyon Jul 23, 2021, 1:46 PM

#

But there isn't one

#

I've even done a regex search

thorny obsidian Jul 23, 2021, 1:47 PM

#

let me take a look

brazen charm Jul 23, 2021, 1:48 PM

#

L471 and 472 have whitespace that shouldn't be there, maybe some others too

vale ibex Jul 23, 2021, 1:49 PM

#

When you run the pre-commit hook, it fixes those for you, but doesn't stage the changes

static canyon Jul 23, 2021, 1:49 PM

#

vale ibex When you run the pre-commit hook, it fixes those for you, but doesn't stage the ...

How do i do this?

vale ibex Jul 23, 2021, 1:49 PM

#

so you it might look like there aren't any trailing spaces in your code because they've already been fixed by the hook

#

poetry run task precommit to install the hook

#

It'll run automatically on commit, or you can run manually by doing poetry run task lint

static canyon Jul 23, 2021, 1:51 PM

#

brazen charm L471 and 472 have whitespace that shouldn't be there, maybe some others too

Thanks, fixed those two

#

God damn it more lint errors xD

vale ibex Jul 23, 2021, 1:52 PM

#

Something that's really nice with GitHub, is that if a lint action fails, the lines will be highlighted in the files changed tab

static canyon Jul 23, 2021, 1:52 PM

#

At least it says these ones

tough imp Jul 23, 2021, 1:53 PM

#

You can also configure pycharm to strip trailing whitespace on each save

#

it's not something you should have to look for manually

static canyon Jul 23, 2021, 1:57 PM

#

I202: Additional newline in a group of imports. 'from discord.ext.commands import BadArgument, Cog, Context, group, has_any_role' is identified as Third Party and 'from discord import Colour, Embed, Message, NotFound, Reaction, User' is identified as Third Party.
How do I fix this?

vale ibex Jul 23, 2021, 1:58 PM

#

It doesn't like the blank line on line 16

static canyon Jul 23, 2021, 1:58 PM

#

vale ibex It doesn't like the blank line on line 16

doesn't or does?

#

Wait sorry misread

#

I'll remove that

#

[flake8] F402: import 'group' from line 16 shadowed by loop variable
I can't find this "loop variable"?

#

Ah got it

#

Finally succeeded. Now need to make some changes

#

@brazen charm If I undo the "style changes" I'll have```py
def predicate_emoji_reaction(ctx: commands.Context, error_message: discord.Message, reaction: discord.Reaction, user: discord.User) -> bool:

#

I can do```py
def predicate_emoji_reaction(ctx: commands.Context, error_message: Message, reaction: Reaction, user: User) -> bool:

brazen charm Jul 23, 2021, 2:11 PM

#

you can split up the definition

static canyon Jul 23, 2021, 2:11 PM

#

brazen charm you can split up the definition

Using what style?

brazen charm Jul 23, 2021, 2:11 PM

#

the one other definitions in the cog use

static canyon Jul 23, 2021, 2:12 PM

#

So I should keep the full thing with the imports?

#

def predicate_emoji_reaction(
    ctx: commands.Context,
    error_message: discord.Message,
    reaction: discord.Reaction,
    user: discord.User
) -> bool:```

brazen charm Jul 23, 2021, 2:13 PM

#

static canyon So I should keep the full thing with the imports?

Yes, that'd be preferred. But like I mentioned the function would be more fitting as an util imo as it can already be used in multiple places

static canyon Jul 23, 2021, 2:13 PM

#

Yeah I'll make it a util

#

What would be a good function name?

#

                    with suppress(discord.NotFound):
                        await ctx.message.delete()
                    with suppress(discord.NotFound):
                        await error_message.delete()```and do we need two suppresses here?

tough imp Jul 23, 2021, 2:17 PM

#

if you had:

with suppress(discord.NotFound):
  await ctx.message.delete()
  await error_message.delete()

the second delete will not execute if the first one fails

static canyon Jul 23, 2021, 2:17 PM

#

Ah, I see

static canyon Jul 23, 2021, 2:23 PM

#

static canyon What would be a good function name?

CC @brazen charm

brazen charm Jul 23, 2021, 2:25 PM

#

delete_if_no_mention or something like that, I'm not particularly good at naming

static canyon Jul 23, 2021, 2:27 PM

#

the pypi command and possibly others in the future also delete invalid invocations, we should extract this to an util function under utils.messages instead of only implementing the functionality for this cog.
So it'd be something like```py
async def delete_if_no_mentions(ctx, error_message):
if ctx.message_has_mentions:
# don't delete invocation message
# allow deletion of error_message through reaction

else:
    # wait then delete ctx.message and error_message```?

#

And should I make this a separate issue? (since is no longer strictly relevant to the "prevent ghost pings")

#

CC @brazen charm

brazen charm Jul 23, 2021, 2:44 PM

#

I think doing a deletion under a mentions condition would be enough, as the caller can do its own wait_for_deletion on the bot response message. maybe don't need an util at all then, with just your if around the ctx.message deletion, although it would be a bit nicer

#

Unless I missed something and handling the reaction deletion on its own is required, didn't look into it in depth

static canyon Jul 23, 2021, 2:45 PM

#

brazen charm Unless I missed something and handling the reaction deletion on its own is requi...

It's not, but from my understanding we'd do it every time this function is called

#

So might as well have it as part of the function

static canyon Jul 23, 2021, 2:51 PM

#

static canyon And should I make this a separate issue? (since is no longer strictly relevant t...

Also ^ @brazen charm

brisk brook Jul 23, 2021, 2:56 PM

#

static canyon It's not, but from my understanding we'd do it every time this function is calle...

Not really, could be good for flexibility. If the message contains no mentions let it return immediately, otherwise wait for the reaction

static canyon Jul 23, 2021, 2:56 PM

#

That wouldn't necessarily work

#

Because what you delete after reaction is different to if there's no mentions

#

if message.mentions or message.role_mentions:  # has mentions
    if reacts:
       delete_error_message()
else:  # no mentions
    wait()
    delete_invocation_message()
    delete_error_message()

#

Maybe ```py
if has mentions:
if reacts:
return True
return False

wait()
delete_invocation_message()
return True
```then if it returns True, delete error_message

#

That could work

#

Or even```py
delete_invocation_message, delete_error_message = call_util_func()
if delete_invocation_message:
await ctx.message.delete()

if delete_error_message:
await error_message.delete()```

brisk brook Jul 23, 2021, 3:00 PM

#

Wait now I am confused, what is the difference between the code you made and wait_for_deletion()?

#

async def wait_for_deletion(*args, **kwargs) -> None:
    """..."""
    if message.guild is None:
        raise ValueError("Message must be sent on a guild")

    if attach_emojis:
        for emoji in deletion_emojis:
            try:
                await message.add_reaction(emoji)
            except discord.NotFound:
                log.trace(f"Aborting wait_for_deletion: message {message.id} deleted prematurely.")
                return

    check = partial(
        reaction_check,
        message_id=message.id,
        allowed_emoji=deletion_emojis,
        allowed_users=user_ids,
        allow_mods=allow_mods,
    )

    with contextlib.suppress(asyncio.TimeoutError):
        await bot.instance.wait_for('reaction_add', check=check, timeout=timeout)
        await message.delete()

*truncated

static canyon Jul 23, 2021, 3:02 PM

#

brisk brook Wait now I am confused, what is the difference between the code you made and `wa...

Hmm

brazen charm Jul 23, 2021, 3:02 PM

#

as I understand it something like this should be enough. The error message should be deleted unconditionally as it won't ever contain mentions, and has no information beyond stating that the lookup failed

                    await wait_for_deletion(error_message, (ctx.author.id,), timeout=NOT_FOUND_DELETE_DELAY)
                    if has_mentions(ctx.message):
                        with suppress(NotFound):
                            await ctx.message.delete()
                    with suppress(NotFound):
                        await error_message.delete()

static canyon Jul 23, 2021, 3:04 PM

#

This is what Akary's put. They suggested only deleting the error message if you react so went with that

#

The key thing is ctx.message doesn't get deleted when there's mentions

brisk brook Jul 23, 2021, 3:05 PM

#

Ah! Okay I understand now

#

            if doc_embed is None:
                error_message = await send_denial(ctx, "No documentation found for the requested symbol.")
                await wait_for_deletion(error_message, (ctx.author.id,), timeout=NOT_FOUND_DELETE_DELAY)
                if not ctx.message.mentions or not ctx.message.role_mentions:
                    with suppress(discord.NotFound):
                        await ctx.message.delete()
                with suppress(discord.NotFound):
                    await error_message.delete()
            else:
                msg = await ctx.send(embed=doc_embed)
                await wait_for_deletion(msg, (ctx.author.id,))

#

Can't we just do that then?

#

Add an if-statement for deleting ctx's message only

static canyon Jul 23, 2021, 3:07 PM

#

I think Numerlor wanted some of this as a util

brazen charm Jul 23, 2021, 3:07 PM

#

it'd be nice if the conditional deletion was an util, but it's fairly short so not required. When I was thinking of an util I didn't realize we can just wrap it in a conditional

brisk brook Jul 23, 2021, 3:08 PM

#

static canyon I think Numerlor wanted some of this as a util

Well yeah that was the wait_for_deletion() code you made haha

Now it's so short and already a util.

static canyon Jul 23, 2021, 3:10 PM

#

Would we want Emojis.trashcan or Emojis.cross_mark?

brisk brook Jul 23, 2021, 3:12 PM

#

I want to say the latter, but the former may be more fitting. Gonna double-check with how Emojis.cross_mark has been used previously.

static canyon Jul 23, 2021, 3:13 PM

#

I'm thinking Emojis.cross_mark too

brazen charm Jul 23, 2021, 3:14 PM

#

where would it be used?

static canyon Jul 23, 2021, 3:14 PM

#

The reaction you use to delete error_message

sleek steppe Jul 23, 2021, 3:14 PM

#

it should be a trashcan then

static canyon Jul 23, 2021, 3:14 PM

#

sleek steppe it should be a trashcan then

But we don't use trashcan for error messages

#

We use ❌

#

(I think)

brazen charm Jul 23, 2021, 3:15 PM

#

It's already a trashcan through wait_for_deletion

#

Your code doesn't need to touch that

static canyon Jul 23, 2021, 3:15 PM

#

!pypi d

stable mountainBOT Jul 23, 2021, 3:15 PM

#

d v0.2.2

Documentation generation that won't make you tear your hair out.

brisk brook Jul 23, 2021, 3:16 PM

#

static canyon But we don't use trashcan for error messages

https://sourcegraph.com/search?q=context:global+repo:^github\.com/python-discord/bot%24+Emojis.cross_mark&patternType=literal

It never gets used in reactions, only in messages.

context:global repo:^git… - Sourcegraph

Sourcegraph is a web-based code search and navigation tool for dev teams. Search, navigate, and review code. Find answers.

static canyon Jul 23, 2021, 3:18 PM

#

error_message = ...

await wait_for_deletion(error_message, (ctx.author.id,), timeout=NOT_FOUND_DELETE_DELAY)

if not (ctx.message.mentions or ctx.message.role_mentions):
    with suppress(discord.NotFound):
        await ctx.message.delete()```so this should be what we want right?

brisk brook Jul 23, 2021, 3:19 PM

#

You are accidentally closing wait_for_deletion() before all arguments have been passed

static canyon Jul 23, 2021, 3:19 PM

#

yep

brisk brook Jul 23, 2021, 3:20 PM

#

Ah, now that looks correct yeah.

static canyon Jul 23, 2021, 3:21 PM

#

Also

#

Actually nvm

brisk brook Jul 23, 2021, 3:22 PM

#

Push that and I'll review it