#dev-contrib | Python | Page 113

dry folio May 13, 2021, 6:59 PM

#

which makes it more complicated

#

so the dynamic questions first take out the dicts from json

#

then formats those strings

#

for example, it gets "{} + {} equals?" and "{}", then formats accordingly using dynamic_id's corresponding function, which returns them back formatted (but in a dataclass instance)

#

i understand that this can be confusing. i will change the dataclass name to FormattedQuizEntry.

celest charm May 13, 2021, 7:02 PM

#

nononononononono

dry folio May 13, 2021, 7:02 PM

#

celest charm nononononononono

hm?

celest charm May 13, 2021, 7:02 PM

#

do you see what the issue is?

dry folio May 13, 2021, 7:03 PM

#

celest charm do you see what the issue is?

no, not really

#

i thought it's just that there's confusion

#

between quiz entries fetched from json and quiz entries returned by format funcs

#

~~@vocal prairie sent .0 at 4:03 PM~~

vocal prairie May 13, 2021, 7:04 PM

#

I accidentally hit my numpad, ignore me. :poof:

dry folio May 13, 2021, 7:05 PM

#

vocal prairie I accidentally hit my numpad, ignore me. :poof:

lmao

#

meanwhile, fix error is typing out an entire essay

celest charm May 13, 2021, 7:07 PM

#

Inside of the cog, you do the following things:

parse the quiz entries from the JSON
keep track of the game state
send questions
watch for answers
it's a little bit crowded.

So what I would do is extract the quiz entry parsing, formatting etc. into a separate place.

#

For example:

@dataclass(frozen=True)
class QuizEntry:
    id: int
    question: str
    answers: List[str]
    hints: List[str]
    
    @staticmethod
    def from_json(json_entry: Dict[str, Any]) -> "QuizEntry":
        dyn_id = json_entry.get("dynamic_id")
        if dyn_id is not None:
            formatter = DYNAMIC_QUESTIONS_FORMAT_FUNCS[dyn_id]
            q_template = json_entry["question"]
            a_template = json_entry["answers"]
            question, answer = formatter(q_template, a_template)
            answers = [answer]
        else:
            question = json_entry["question"]
            answer = json_entry["answer"]
        id = json_entry["id"]
        hints = json_entry.get("hints", []
        return QuizEntry(id, question, answers, hints)

you can also imagine putting logic for deciding if an answer is correct into here.

#

but that's another non-small refactoring

dry folio May 13, 2021, 7:13 PM

#

celest charm For example: ```py @dataclass(frozen=True) class QuizEntry: id: int ques...

right, but some of the code requires getting only the hints, and it's all scattered over the code CONFUSED SCREAMING
ah my head is imploding lol

dry folio May 13, 2021, 7:13 PM

#

celest charm but that's another non-small refactoring

yeah... what do you suggest i do? i want to leave the refactoring for another pr but that feels a bit irresponsible lol
it's just that this is kinda starting to go beyond my scope of knowledge (and determination and brain power)

celest charm May 13, 2021, 7:16 PM

#

dry folio yeah... what do you suggest i do? i want to leave the refactoring for another pr...

It's fine to not do everything at once 🙂

dry folio May 13, 2021, 7:18 PM

#

celest charm It's fine to not do everything at once 🙂

thank you so much for understanding. i'm pretty conflicted cuz one i want to get this pr merged so i can finally try it out on sir lancebot but two i don't want to decrease the code's quality just because i'm eager and i try to do everything as best as i could. so for now you think we can leave this refactoring?

celest charm May 13, 2021, 7:18 PM

#

sure

#

it's just important to keep track of what parts of code might need to be split up into more pieces

#

and not wait until it becomes a method like https://github.com/python-discord/sir-lancebot/pull/718/files/ae3ecb3ac46d90ebab1cb556fdc357848f45abb5#diff-2b56425c5b483af73a4eaf13d49e54eca49dd8338d3b3f6cad5201ecad8d0366L279-L417

fervent sage May 13, 2021, 7:21 PM

#

would be cool if we could have the code embedding but with diffs

#

wonder how hard that'd be

vale ibex May 13, 2021, 7:29 PM

#

oh Sadge

#

I thought fix was a core dev so updated my branch and went to merge it

celest charm May 13, 2021, 7:29 PM

#

lol

#

no I'm just a nobody

#

I just nitpick on people's hard work as I said

vale ibex May 13, 2021, 7:30 PM

#

😄

granite plaza May 13, 2021, 7:30 PM

#

Im trying to do my testing for the bot. I have python 3.8 but it seems that I only have pipenv for python 3.7. Would this still work? If not how can I get pipenv for 3.8?

dry folio May 13, 2021, 7:30 PM

#

celest charm and not wait until it becomes a method like https://github.com/python-discord/si...

got it. so in the meantime would you mind re-reviewing the code? thanks!

celest charm May 13, 2021, 7:32 PM

#

done

celest charm May 13, 2021, 7:36 PM

#

celest charm and not wait until it becomes a method like https://github.com/python-discord/si...

Sourcery is... not happy.

#

maybe I should find how to extract methods from here

#

oh wait, this method doesn't even return anything?..

#

oh, I can't run unit tests without the database running?

#

that's... concerning

dry folio May 13, 2021, 7:39 PM

#

celest charm done

WOOOOOHOOOOOOOO EXAPOGGERS

#

one more core dev approval then we doneeee

#

sir-lancebot#726

dusky shoreBOT May 13, 2021, 7:40 PM

#

GitHub

PROpen Add "math" and "science" categories to the .quiz command (and more in desc)

sleek steppe May 13, 2021, 7:41 PM

#

Do you have any ideas on what could be broken up?

#

Also I like how the additions and deletions are close together

celest charm May 13, 2021, 7:45 PM

#

I am thinking of that right now

#

was busy with the other PR

#

So the cog is responsible for this, right?

#

.help

#

Refactoring 1. extract method from this block https://github.com/python-discord/sir-lancebot/pull/718/files/ae3ecb3ac46d90ebab1cb556fdc357848f45abb5#diff-2b56425c5b483af73a4eaf13d49e54eca49dd8338d3b3f6cad5201ecad8d0366R288-R299

#

Refactoring 2. extract method from this beast https://github.com/python-discord/sir-lancebot/pull/718/files/ae3ecb3ac46d90ebab1cb556fdc357848f45abb5#diff-2b56425c5b483af73a4eaf13d49e54eca49dd8338d3b3f6cad5201ecad8d0366R310-R397

#

Wait... why is it accessing the private paginator._linecount variable?

#

sounds fishy

sleek steppe May 13, 2021, 8:02 PM

#

thonk

celest charm May 13, 2021, 8:06 PM

#

ok. this method is pretty hard to refactor.

dry folio May 13, 2021, 8:07 PM

#

why is #dev-voice locked? can only contributors and above be in it?

celest charm May 13, 2021, 8:07 PM

#

this method is a good lesson on why mutable state makes it hard to reason about programs.

sleek steppe May 13, 2021, 8:08 PM

#

dry folio why is #dev-voice locked? can only contributors and above be in it?

Pretty much, yeah. It's locked the same reason #412375055910043655 is locked

dry folio May 13, 2021, 8:10 PM

#

sleek steppe Pretty much, yeah. It's locked the same reason <#412375055910043655> is locked

we need a dev-contrib vc, but open to everyone

celest charm May 13, 2021, 8:12 PM

#

celest charm Refactoring 2. extract method from this beast <https://github.com/python-discord...

(inside the beast) Extract this into a method https://github.com/python-discord/sir-lancebot/pull/718/files/ae3ecb3ac46d90ebab1cb556fdc357848f45abb5#diff-2b56425c5b483af73a4eaf13d49e54eca49dd8338d3b3f6cad5201ecad8d0366R345-R373 that returns a list of strings. (doesn't really depend on many things)

#

And this is an example of how comments become stale. Someone inserted the try-catch in a rush.

#

I think everyone should be able to understand this method, right?
https://paste.pythondiscord.com/fuliyidosu.py

#

So this is what I came up with @sleek steppe:
https://paste.pythondiscord.com/uziyekanij.py
I think it became much more understandable. Haven't tested it, though 😛
So if you think it's worth encorporating, encorporate it (also change the quotes and stuff)

dry folio May 13, 2021, 8:28 PM

#

celest charm So this is what I came up with <@!506618674921340958>: <https://paste.pythondisc...

my CGSC (compulsive grammar & spelling correction) was acting up but then i saw this lmao

celest charm May 13, 2021, 8:28 PM

#

I'm old, I can use the archaic

dry folio May 13, 2021, 8:29 PM

#

apparently "encorporate" is a word, just old

dry folio May 13, 2021, 8:29 PM

#

celest charm I'm old, I can use the archaic

lol 🤣

celest charm May 13, 2021, 8:29 PM

#

I already ignore punctuation and grammar to such an extent where [i/e]ncorporate doesn't really matter

sleek steppe May 13, 2021, 8:40 PM

#

celest charm So this is what I came up with <@!506618674921340958>: <https://paste.pythondisc...

I'll try it in a few, thanks

dry folio May 13, 2021, 9:54 PM

#

approaching 200... the record is 229 iirc lol

green oriole May 13, 2021, 9:57 PM

#

That's not a record you should try to break haha

patent pivot May 13, 2021, 9:58 PM

#

this

vocal prairie May 13, 2021, 10:39 PM

#

How do you set DEBUG to false in site? I'm trying to test PR #486, but I need to be able to see the error page.

#

I'm running with Docker on Windows, if that matters.

#

This is what is says right now

sleek steppe May 13, 2021, 10:58 PM

#

https://pythondiscord.com/pages/contributing/site/#2-environment-variables

DATABASE_URL=postgres://pysite:pysite@localhost:7777/pysite
METRICITY_DB_URL=postgres://pysite:pysite@localhost:7777/metricity
DEBUG=1
SECRET_KEY=suitable-for-development-only
STATIC_ROOT=staticfiles

I assume you'd set DEBUG to 0

fallen patrol May 13, 2021, 11:09 PM

#

sleek steppe Pretty much, yeah. It's locked the same reason <#412375055910043655> is locked

yeeters. You can now mention voice channels

#

#756327105389920306

dry folio May 13, 2021, 11:10 PM

#

green oriole That's not a record you should try to break haha

true lol, i said it as a joke because i didn't know my code had so much mini-flaws that there had to be 188 comments and reviews before it finally got 3 approvals (minus the core dev)

dry folio May 13, 2021, 11:10 PM

#

patent pivot <:this:470903994118832130>

clever wraith May 14, 2021, 3:16 AM

#

dry folio

second advice: keep THIS like a second longer

fallen patrol May 14, 2021, 5:03 AM

#

Notion api went into a public beta today

granite plaza May 14, 2021, 12:09 PM

#

I have tested my new code is there any specific tests that i should try before subbitting the pull request?

gritty wind May 14, 2021, 12:09 PM

#

This is @stable mountain?

granite plaza May 14, 2021, 12:09 PM

#

@dusky shore

gritty wind May 14, 2021, 12:09 PM

#

Just the lint should be enough

#

pipenv run lint

granite plaza May 14, 2021, 12:09 PM

#

k thanks

short snow May 14, 2021, 12:12 PM

#

Tests are only there on site and @stable mountain, not on lance

dry folio May 14, 2021, 12:30 PM

#

clever wraith second advice: keep *THIS* like a second longer

That would be like adding 15 more frames lmao

granite plaza May 14, 2021, 12:34 PM

#

Ok. I made a new branch on my fork but when I go to start the pull request it is comparing it with the main branch of the parent repository. IS this ok?

Also i accidentally committed to the main branch of my clone. I think i reverted it but im not sure. It still shows up as a commit but I think it changed what branch it was on im not entirly sure.

clever wraith May 14, 2021, 12:39 PM

#

dry folio That would be like adding 15 more frames lmao

Piskel has copy and paste

dry folio May 14, 2021, 12:40 PM

#

clever wraith Piskel has copy and paste

ik

granite plaza May 14, 2021, 12:40 PM

#

granite plaza Ok. I made a new branch on my fork but when I go to start the pull request it is...

I pushed you can see if i did it wrong there

sleek steppe May 14, 2021, 12:41 PM

#

granite plaza I pushed you can see if i did it wrong there

Did you do this commit on purpose? https://github.com/python-discord/sir-lancebot/pull/733/commits/c4ee8a3bd9eeee61e3a2312f6c8a42f64858c8a6

#

If you want to fix the linting errors, you can reset to this commit https://github.com/python-discord/sir-lancebot/pull/733/commits/f8c98972e2341fe621bc9b569a4b2fe0d1c5f391

git reset f8c98972e2341fe621bc9b569a4b2fe0d1c5f391 --hard

And then you would force push the changes

git push origin branch_name -f

vale ibex May 14, 2021, 12:46 PM

#

Also if you want a random true/false you can do this instead ```py
from random import random
if random() > 0.5:
do()
else:
dont()

#

I find it easier to read at least

sleek steppe May 14, 2021, 12:47 PM

#

I would do

from random import choice
func = random.choice((self.func1, self.func2))

vale ibex May 14, 2021, 12:48 PM

#

yea, that makes more sense

placid ermine May 14, 2021, 1:03 PM

#

~~func = (self.func1, self.func2)[random() > 0.5] to make you both happy~~

clever wraith May 14, 2021, 1:11 PM

#

Eww had to use Windows update

dry folio May 14, 2021, 1:31 PM

#

placid ermine ~~`func = (self.func1, self.func2)[random() > 0.5]` to make you both happy~~

LMFAO THIS

dry folio May 14, 2021, 1:31 PM

#

placid ermine ~~`func = (self.func1, self.func2)[random() > 0.5]` to make you both happy~~

fervent sage May 14, 2021, 1:33 PM

#

here's a smaller version of the gif for you so it takes up less space :)

clever wraith May 14, 2021, 1:46 PM

#

watching both in sync

vocal prairie May 14, 2021, 2:02 PM

#

Can someone unload the latex cog?

vale ibex May 14, 2021, 2:02 PM

#

Done

vocal prairie May 14, 2021, 2:03 PM

#

Ty

dry folio May 14, 2021, 2:26 PM

#

fervent sage here's a smaller version of the gif for you so it takes up less space :)

thank you!! :D

#

https://media.discordapp.net/attachments/635950537262759947/842756524748177458/megathis_small.gif

dry folio May 14, 2021, 2:27 PM

#

clever wraith watching both in sync

it went async for me :(

#

now i have to await it to go back in sync

sleek steppe May 14, 2021, 3:18 PM

#

@short snow what do you mean by "Full cog"? https://github.com/python-discord/sir-lancebot/pull/718#pullrequestreview-659533456

clever wraith May 14, 2021, 4:06 PM

#

hehe

short snow May 14, 2021, 4:28 PM

#

sleek steppe <@!736234578745884682> what do you mean by "Full cog"? <https://github.com/pytho...

Well, uhh it has just too many of those, so I put full cog 😛

#

I can update that in a while

#

if you want

sleek steppe May 14, 2021, 4:28 PM

#

There aren't any cogs in that file though?

short snow May 14, 2021, 4:29 PM

#

um one sec lemme see

#

ah my bad, its full file

sleek steppe May 14, 2021, 4:30 PM

#

Ah ok

patent pivot May 14, 2021, 4:44 PM

#

heads up

#

about to merge dewikification

#

need to manually override policy bot because it breaks on >250 commits (GH limitation)

sleek steppe May 14, 2021, 4:46 PM

#

noice

short snow May 14, 2021, 4:46 PM

#

ducky_party ducky_wizard ducky_regal

vale ibex May 14, 2021, 4:47 PM

#

This gonna be good

#

https://github.com/python-discord/site/actions/runs/842814635 👀

patent pivot May 14, 2021, 4:48 PM

#

deployment will take a few mins

#

it rolls

#

deployment started

vale ibex May 14, 2021, 4:49 PM

#

Nice

short snow May 14, 2021, 4:50 PM

#

nice, is api now going to be removed from site? and be migrated to the fast api one?

vale ibex May 14, 2021, 4:50 PM

#

not as part of these changes

#

This is dewikifiction

#

IE moving all pages into src control

patent pivot May 14, 2021, 4:50 PM

#

there are three major changes being made to site: dewikification, api migration and logs migration

#

so this is 1/3

#

okay it's starting to go live now

vale ibex May 14, 2021, 4:51 PM

#

and thats it right?

patent pivot May 14, 2021, 4:51 PM

#

I'll clear upstream cache once it goes green

short snow May 14, 2021, 4:52 PM

#

patent pivot there are three major changes being made to site: dewikification, api migration ...

umm, i get the first 2, whats logs migration?

patent pivot May 14, 2021, 4:52 PM

#

https://git.pydis.com/logcord

GitHub

python-discord/logcord

A web app designed to display fully styled logs from Discord. - python-discord/logcord

short snow May 14, 2021, 4:52 PM

#

the log view project den was doing?

#

ah ye

patent pivot May 14, 2021, 4:52 PM

#

allllllllllright

#

deploy complete

#

cache purged, should be ready in 30s

vocal prairie May 14, 2021, 4:53 PM

#

So wiki freeze is over?

patent pivot May 14, 2021, 4:53 PM

#

yep

#

we'll announce it shortly

vocal prairie May 14, 2021, 4:53 PM

#

eyy

thorny obsidian May 14, 2021, 4:53 PM

#

Yo wait really?

vocal prairie May 14, 2021, 4:53 PM

#

It deployed I think

thorny obsidian May 14, 2021, 4:53 PM

#

@exotic ember you're awesome

vocal prairie May 14, 2021, 4:53 PM

#

Fancy symbols

short snow May 14, 2021, 4:53 PM

#

we need to update the discord icons on guides

patent pivot May 14, 2021, 4:54 PM

#

it has deployed now, yes

patent pivot May 14, 2021, 4:54 PM

#

short snow we need to update the discord icons on guides

ya we do

thorny obsidian May 14, 2021, 4:54 PM

#

😎 Time to re-do our event pages
... after I finish my final 😢

vocal prairie May 14, 2021, 4:55 PM

#

Good luck!

short snow May 14, 2021, 4:57 PM

#

gl, the new guides are awesome, especially the table of contents 🤟

vocal prairie May 14, 2021, 4:59 PM

#

On the events page, this probably needs to be changed since it says 2020 is upcoming.

patent pivot May 14, 2021, 4:59 PM

#

ya

#

we can

#

prob wait

thorny obsidian May 14, 2021, 5:00 PM

#

mhm, after I submit my final today I'll be going through and updating that stuff

short snow May 14, 2021, 5:00 PM

#

events calender is a thing now? Or still to be done

thorny obsidian May 14, 2021, 5:00 PM

#

Our event pages in general need a slight re-do. We're not advertising what we do as well as we could

#

And yeah, I need some sort of event calendar but I need to think about the best way to display it

#

a month-by-month won't necessarily be the best way

short snow May 14, 2021, 5:02 PM

#

like notion's calender view?

#

site#188 there is a issue open on this

dusky shoreBOT May 14, 2021, 5:03 PM

#

GitHub

IssueOpen Event Calendar for Community Events

thorny obsidian May 14, 2021, 5:03 PM

#

nah, Notion's is not that helpful since we don't have weekly events. We typically have a big thing each month

short snow May 14, 2021, 5:03 PM

#

Yeah, a month wise, but in squares or line by line?

thorny obsidian May 14, 2021, 5:04 PM

#

I have an idea of what I want, just need to make sure it's feasible

short snow May 14, 2021, 5:07 PM

#

and the idea is?

sleek steppe May 14, 2021, 5:43 PM

#

yes

fervent sage May 14, 2021, 5:56 PM

#

beautiful now i can fix a thing on site

#

this has annoyed me for 3 weeks :P site#488

dusky shoreBOT May 14, 2021, 6:00 PM

#

GitHub

PROpen fix: USE_FAKEREDIS is uppercase

sleek steppe May 14, 2021, 6:01 PM

#

fervent sage this has annoyed me for 3 weeks :P site#488

It's not right though

#

https://github.com/python-discord/bot/blob/main/config-default.yml#L19

stable mountainBOT May 14, 2021, 6:01 PM

#

config-default.yml line 19

use_fakeredis: false```

sleek steppe May 14, 2021, 6:02 PM

#

Sadge it merged

patent pivot May 14, 2021, 6:02 PM

#

oh

#

that's a good point! hahaha

#

reverting

brazen charm May 14, 2021, 6:02 PM

#

Guess it depends on which bot you look at

patent pivot May 14, 2021, 6:02 PM

#

this is taken from the bot docs

fervent sage May 14, 2021, 6:03 PM

#

config file considering it's just referred to a .env file strongly suggests that its referring to .env

sleek steppe May 14, 2021, 6:03 PM

#

You could change it to config.yml maybe?

patent pivot May 14, 2021, 6:03 PM

#

not a bad shout

dusky shoreBOT May 14, 2021, 6:03 PM

#

GitHub

IssueOpen Hacktoberfest branding asset link is dead.

patent pivot May 14, 2021, 6:03 PM

#

will do it in my PR toxic

fervent sage May 14, 2021, 6:04 PM

#

another fuck up from vco

#

today gets better and better

thorny obsidian May 14, 2021, 6:04 PM

#

go for it

#

can you comment so I can assign you?

patent pivot May 14, 2021, 6:06 PM

#

sleek steppe You could change it to `config.yml` maybe?

👍

#

done

thorny obsidian May 14, 2021, 6:07 PM

#

(Dawn you're busy with forms and if you'd like to work on site front end stuff I have some tasks for you :3c)

#

yeah

#

We have channels for each of our larger projects that requires for back and forth convo

#

locked to staff only (mostly) for the time being since they're fairly important and most aren't ready to accept contributions from outside staff

vocal prairie May 14, 2021, 6:09 PM

#

Why is the privacy policy kept in Notion instead of on the site?

thorny obsidian May 14, 2021, 6:09 PM

#

That's a question for joe

patent pivot May 14, 2021, 6:10 PM

#

super fast for me to edit it, i'm the only one that ever touches the policy

#

pythondiscord.com?

#

https://github.com/python-discord/site/blob/main/pydis_site/templates/home/index.html

GitHub

python-discord/site

pythondiscord.com - A Django and Bulma web application. - python-discord/site

#

ya, was just checking that was the site you were on abouut

hard crest May 14, 2021, 6:17 PM

#

which is the current website for the changes are live as of now?

sleek steppe May 14, 2021, 6:17 PM

#

Should bot#1580 be transferred to lancebot repo/closed?

dusky shoreBOT May 14, 2021, 6:17 PM

#

GitHub

IssueOpen Wrong tooltip .mosaic

fervent sage May 14, 2021, 6:17 PM

#

closed imo

vocal prairie May 14, 2021, 6:18 PM

#

hard crest which is the current website for the changes are live as of now?

https://pydis.com has the changes

hard crest May 14, 2021, 6:18 PM

#

vocal prairie https://pydis.com has the changes

okay

patent pivot May 14, 2021, 6:21 PM

#

no lol

vocal prairie May 14, 2021, 6:23 PM

#

Those are shields, aren't they?

patent pivot May 14, 2021, 6:32 PM

#

we use github ones

granite plaza May 14, 2021, 6:40 PM

#

sir_lancebot#733
I updated the code here but it says a failed one of the checks. I think that was when i pushed the faultily code and just has not been rechecked but im not sure could someone confirm please.

#

sir-lancebot#733

dusky shoreBOT May 14, 2021, 6:40 PM

#

GitHub

PROpen Http status command randomness

sleek steppe May 14, 2021, 6:42 PM

#

granite plaza sir_lancebot#733 I updated the code here but it says a failed one of the checks...

I'm guessing it's because you're a first time contributor

patent pivot May 14, 2021, 6:42 PM

#

ah

#

actually out of interest @sleek steppe does it allow you to approve that

sleek steppe May 14, 2021, 6:43 PM

#

yes

patent pivot May 14, 2021, 6:43 PM

#

noice

granite plaza May 14, 2021, 6:43 PM

#

Oh ok.

sleek steppe May 14, 2021, 6:43 PM

#

I'm a maintainer verycool

patent pivot May 14, 2021, 6:43 PM

#

linting passed 🙂

#

review left, mainly surrounding docs

granite plaza May 14, 2021, 6:54 PM

#

There we go, sorry again its my first pull request 🙂

thorny obsidian May 14, 2021, 6:56 PM

#

granite plaza There we go, sorry again its my first pull request 🙂

It's a pretty decent PR, nice job!

granite plaza May 14, 2021, 6:56 PM

#

Thanks

thorny obsidian May 14, 2021, 7:00 PM

#

This is vaaaguely what I'd like to do for the events page. Although it may be too dynamic for what bulma + html can do. Still have to do research into to.
But I want it to be clear that we do a variety of events and I want to make sure we have a strong call to action for joining the events.
The following things should be clear:

What events we host and when they happen
How to join said events
Basic + required info for events

#

Yeah, I'm debating it. On one hand I like that some events are on their own pages so we can maybe have a summary for each and have super detailed info there without it overloading this page. But some pages would then be super light or just link to an external website

#

but... but... my consistency! (That's a valid point though)

granite plaza May 14, 2021, 7:04 PM

#

thorny obsidian Yeah, I'm debating it. On one hand I like that some events are on their own page...

What about a brief description in the boxes at the bottom of the page than a button that expands the box with more info. It wouldn't be another page.

thorny obsidian May 14, 2021, 7:05 PM

#

granite plaza What about a brief description in the boxes at the bottom of the page than a but...

oooh, I do like that. I know for the code jams those are information heavy. So I might have it switch between a "view event" and a "show more" depending if it needs to be a whole separate page. That still keeps the experience relatively consistent though.

vocal prairie May 14, 2021, 7:07 PM

#

thorny obsidian locked to staff only (mostly) for the time being since they're fairly important ...

I can do some stuff now since I have nothing to do

thorny obsidian May 14, 2021, 7:08 PM

#

How familiar are you with django/jinja + bulma?

vocal prairie May 14, 2021, 7:09 PM

#

Idk much Django/Jinja, but I've used Bulma.

#

But Django and Jinja are supposed to be rather straightforward, and they're not to hard to understand

thorny obsidian May 14, 2021, 7:10 PM

#

This can be a learning opportunity! Essentially, I want to change how the event pages work. What I'm curious about is if my above mockup is possible within jinja + bulma.
I'm also looking for someone to make our code jam pages better: https://pythondiscord.com/events/code-jams/7/

#

Right now they don't really give you the info you care about in a good manner

green oriole May 14, 2021, 7:11 PM

#

It doesn't look impossible, not sure how easy it is though - yes, that was a really interesting comment

thorny obsidian May 14, 2021, 7:12 PM

#

I want the important information to be clear:

Dates
Tech
Qualifier repo
Actual Jam repo

Results with us showing it off nicely
How to get involved next time

#

Right now it's just... blocks of text

#

I want to make it more scannable

vocal prairie May 14, 2021, 7:13 PM

#

That shouldn't be too hard

#

I think Django supports components

thorny obsidian May 14, 2021, 7:14 PM

#

So, there's a few tasks:

Prototyping / Proof of Concept the main events page
Mocking up changes to the specific code jam pages
Prototyping / Proof of Concept the code jam pages

trim cradle May 14, 2021, 7:14 PM

#

Sigh. I make my first PR to the site and it failed a lint test.

vocal prairie May 14, 2021, 7:15 PM

#

Btw, who's swfarnsworth on Github?

thorny obsidian May 14, 2021, 7:16 PM

#

Steler

trim cradle May 14, 2021, 7:16 PM

#

omg doxed

thorny obsidian May 14, 2021, 7:16 PM

#

well once I submit my final today I'll be setting up the site for the first time too, it'll be a good learning opportunity

vale ibex May 14, 2021, 7:17 PM

#

Don't forget to setup your hosts file 😄

#

The setup for me was update hosts file, run docker-compose up

green oriole May 14, 2021, 7:17 PM

#

thorny obsidian well once I submit my final today I'll be setting up the site for the first time...

submit my final today
What on earth are you doing on discord? 👀 👀 👀

thorny obsidian May 14, 2021, 7:18 PM

#

Waiting for my computations to run

green oriole May 14, 2021, 7:18 PM

#

Ha, fair enough

#

don't you have a typo right here?

vocal prairie May 14, 2021, 7:18 PM

#

thorny obsidian So, there's a few tasks: - Prototyping / Proof of Concept the main events page -...

I can see if I can get a basic version of the home event page

thorny obsidian May 14, 2021, 7:19 PM

#

listen, this is my prof's code as a base. I'm at the point where idgaf

green oriole May 14, 2021, 7:19 PM

#

Haha

thorny obsidian May 14, 2021, 7:19 PM

#

vocal prairie I can see if I can get a basic version of the home event page

that would be much appreciated!

brazen charm May 14, 2021, 7:22 PM

#

Could add the env var from https://github.com/python-discord/bot/pull/1529 somewhere in the contrib guides if anyone's free

sleek steppe May 14, 2021, 7:24 PM

#

brazen charm Could add the env var from <https://github.com/python-discord/bot/pull/1529> som...

Yeah I could PR that

brazen charm May 14, 2021, 7:27 PM

#

There's also an issue for the feature open for lancebot that's be good as a first issue for a new contrib

sleek steppe May 14, 2021, 7:27 PM

#

sleek steppe Yeah I could PR that

Actually someone else can do that I have no idea where pages are stored lol

vocal prairie May 14, 2021, 7:28 PM

#

brazen charm Could add the env var from <https://github.com/python-discord/bot/pull/1529> som...

I can do it

#

Lemme get the site up real quick

vale ibex May 14, 2021, 7:29 PM

#

127.0.0.1   pythondiscord.local
127.0.0.1   api.pythondiscord.local
127.0.0.1   staff.pythondiscord.local
127.0.0.1   admin.pythondiscord.local

#

to save you some time

sleek steppe May 14, 2021, 7:34 PM

#

brazen charm There's also an issue for the feature open for lancebot that's be good as a firs...

Are you referring to sir-lancebot#715?

dusky shoreBOT May 14, 2021, 7:34 PM

#

GitHub

IssueOpen ValueError: empty range for randrange() (10, 9, -1)

brazen charm May 14, 2021, 7:39 PM

#

sleek steppe Are you referring to sir-lancebot#715?

sir-lancebot#706

dusky shoreBOT May 14, 2021, 7:39 PM

#

GitHub

IssueOpen Adapt selective trace logging from bot

sleek steppe May 14, 2021, 7:39 PM

#

ah

vocal prairie May 14, 2021, 7:43 PM

#

brazen charm Could add the env var from <https://github.com/python-discord/bot/pull/1529> som...

What do you think should go in the required and description parts of the table?

#

Required is when it's required

brazen charm May 14, 2021, 7:44 PM

#

When the env var is required?
I'm not very familiar with the site

vocal prairie May 14, 2021, 7:44 PM

#

Here, where it says "something"

#

Although, Reddit should be removed from there

sleek steppe May 14, 2021, 7:45 PM

#

Yes

brazen charm May 14, 2021, 7:46 PM

#

I mean, I guess it isn't required at any point, just if you want to change which loggers emit trace logs

vocal prairie May 14, 2021, 7:46 PM

#

What about the description for that one?

#

Are Lancebot's env vars the same (REDDIT_CLIENT_ID and REDDIT_SECRET)? I can update it in the same PR

sleek steppe May 14, 2021, 7:47 PM

#

And REDDIT_WEBHOOK_ID IIRC

#

No it's REDDIT_WEBHOOK

vocal prairie May 14, 2021, 7:49 PM

#

And that's the ID of the Reddit webhook?

sleek steppe May 14, 2021, 7:49 PM

#

Yes

eternal owl May 14, 2021, 7:49 PM

#

vocal prairie Are Lancebot's env vars the same (`REDDIT_CLIENT_ID` and `REDDIT_SECRET`)? I can...

how shoot did I forget to add those in the reddit migration PRs

sleek steppe May 14, 2021, 7:50 PM

#

I'm not sure which section it would go in for the environment variable referencce

vale ibex May 14, 2021, 7:50 PM

#

eternal owl how shoot did I forget to add those in the reddit migration PRs

you couldn't 😄 This is on the site, which was in a freeze

vocal prairie May 14, 2021, 7:50 PM

#

sleek steppe I'm not sure which section it would go in for the environment variable referencc...

Probably Tokens/APIs

eternal owl May 14, 2021, 7:50 PM

#

vale ibex you couldn't 😄 This is on the site, which was in a freeze

ah peace : D

#

@vocal prairie are you taking care of it or should I add em

vocal prairie May 14, 2021, 7:51 PM

#

I got it

#

I'll update env vars in the same pr

eternal owl May 14, 2021, 7:51 PM

#

alright 👍 , thanks

brazen charm May 14, 2021, 7:53 PM

#

vocal prairie What about the description for that one?

Specifies which loggers emit trace logs through the listed names, should also mention the ! * prefixes that are commented somewhere in the pr

sleek steppe May 14, 2021, 7:54 PM

#

The description in bot#1529 should give enough info for that

dusky shoreBOT May 14, 2021, 7:54 PM

#

GitHub

PRMerged Make trace logging optional and allow selective enabling

vocal prairie May 14, 2021, 7:57 PM

#

Does this look good?

#

vale ibex May 14, 2021, 8:03 PM

#

I'd suggest mentioning that its a comma separated list

trim cradle May 14, 2021, 8:05 PM

#

@green oriole tbh I was just burned out from trying to set up an environment from the bot yesterday and I gambled that a text-only change would be fine

vocal prairie May 14, 2021, 8:05 PM

#

vale ibex I'd suggest mentioning that its a comma separated list

Updated to say: "Comma separated list that specifies which …"

patent pivot May 14, 2021, 8:07 PM

#

hey folks

#

site#492

dusky shoreBOT May 14, 2021, 8:07 PM

#

GitHub

PROpen Enable permanent redirects for redirect app

patent pivot May 14, 2021, 8:07 PM

#

hey folks

#

nevermind lint failed

#

oh kosa added tests for redirect code SMH

#

only kosa would do this....

#

or was it ks...

vale ibex May 14, 2021, 8:07 PM

#

smh, lint and test before pushing joe

vocal prairie May 14, 2021, 8:08 PM

#

I updated the Bot and Lance env vars on site, so I can pr that now

sleek steppe May 14, 2021, 8:08 PM

#

patent pivot or was it ks...

yeah it was ks

#

but it was kosa who changed the expected response to 302

vale ibex May 14, 2021, 8:11 PM

#

I remember seeing this discussed in #dev-core yesterday I think

#

maybe a few days ago, the days have melted

patent pivot May 14, 2021, 8:11 PM

#

yeah

vale ibex May 14, 2021, 8:11 PM

#

Not sure why there's a test there, if we were intending to switch back after it all went well

#

oh well, easy fix

sleek steppe May 14, 2021, 8:12 PM

#

if sir-lancebot#706 is approved then I can implement that

dusky shoreBOT May 14, 2021, 8:12 PM

#

GitHub

IssueOpen Adapt selective trace logging from bot

patent pivot May 14, 2021, 8:12 PM

#

okay CI passed :)

vale ibex May 14, 2021, 8:12 PM

#

sleek steppe if sir-lancebot#706 is approved then I can implement that

Done 😄

sleek steppe May 14, 2021, 8:12 PM

#

thanks

vale ibex May 14, 2021, 8:13 PM

#

I'll checkout and test it now

#

I'm gonna give implementing the new git action concurrency options a go tomorrow

#

It'll allow us to cancel actions on a branch/PR if another commit comes in

#

Since we don't care about the old action at that point

patent pivot May 14, 2021, 8:23 PM

#

nice

green oriole May 14, 2021, 8:24 PM

#

trim cradle <@!407110650217627658> tbh I was just burned out from trying to set up an enviro...

That's pretty fair. I'm going to bed right now, but if you need any help tomorrow it would be with pleasure.

sleek steppe May 14, 2021, 8:25 PM

#

Should the logging stuff go in bot/__main__.py or bot/__init__.py or another file?

trim cradle May 14, 2021, 8:25 PM

#

green oriole That's pretty fair. I'm going to bed right now, but if you need any help tomorro...

Night night 😙

vocal prairie May 14, 2021, 8:25 PM

#

Night Akarys

green oriole May 14, 2021, 8:25 PM

#

👋 😁

vale ibex May 14, 2021, 8:26 PM

#

If it any consolation stel, the site is a lot easier to setup

#

You just need to update your hosts file and run docker compose

sleek steppe May 14, 2021, 8:35 PM

#

sleek steppe Should the logging stuff go in `bot/__main__.py` or `bot/__init__.py` or another...

bump

vale ibex May 14, 2021, 8:38 PM

#

Is there anything to do with logging in either of them right now?

#

I faintly remember there being something in one of the files

#

It should go in there imo

sleek steppe May 14, 2021, 8:39 PM

#

I think it's init.py yeah

vale ibex May 14, 2021, 8:39 PM

#

:+1:

patent pivot May 14, 2021, 8:56 PM

#

hey folks, minor note: we're doing some tracing requests to try figure out if we've missed any paths to redirect with dewikification, but if anyone gets a 500 code or a cloudflare error please let me know so I can trace it down, cheers.

vocal prairie May 14, 2021, 10:09 PM

#

On the site, we use British English spelling, right?

patent pivot May 14, 2021, 10:13 PM

#

yeah

vale ibex May 14, 2021, 10:14 PM

#

A quick search and I've found some American that's slipped in there

#

but mostly British spellings

#

I bet it was Kat

thorny obsidian May 14, 2021, 10:16 PM

#

vocal prairie On the site, we use British English spelling, right?

(I'll send you virtual cookies if you can sneak in an american spelling or two)

vale ibex May 14, 2021, 10:16 PM

#

It was definitely kat, they're all in the events path

thorny obsidian May 14, 2021, 10:16 PM

#

:3c

vale ibex May 14, 2021, 10:16 PM

#

smh

#

😂

vocal prairie May 14, 2021, 10:16 PM

#

thorny obsidian (I'll send you virtual cookies if you can sneak in an american spelling or two)

I don't need browsers knowing more about me, so I'll have to pass.

vale ibex May 14, 2021, 10:17 PM

#

Kat's cookies are tracker free afaik

#

just watch for the ones with nuts :x

thorny obsidian May 14, 2021, 10:19 PM

#

pffft, Chris hasn't even taken me up on the cookie offer. My cookies are nut free unless you specifically request nuts =P

vocal prairie May 14, 2021, 10:19 PM

#

Sounds like a good deal to me

thorny obsidian May 14, 2021, 10:19 PM

#

@eternal owl Let me know when you have time to chat re: User Event Management PR. I'd like to talk through what I'd like to convert it to and what would be easiest for you considering the existing codebase and work.

vocal prairie May 14, 2021, 11:23 PM

#

@thorny obsidian For the events page under the "Upcoming Events" section, would you prefer a list (top) or a table (bottom)?

thorny obsidian May 14, 2021, 11:23 PM

#

Table Looks nice

vale ibex May 14, 2021, 11:45 PM

#

.ext unload latex

dusky shoreBOT May 14, 2021, 11:45 PM

#

:ok_hand: Extension successfully unloaded: bot.exts.evergreen.latex.

fervent sage May 15, 2021, 12:00 AM

#

@patent pivot does lance's redis have peristence on?

patent pivot May 15, 2021, 12:01 AM

#

yep

#

same as pythons

vale ibex May 15, 2021, 12:01 AM

#

Do they share a redis instance?

#

or are they separate containers?

patent pivot May 15, 2021, 12:01 AM

#

shared

vale ibex May 15, 2021, 12:02 AM

#

Cool

fervent sage May 15, 2021, 12:04 AM

#

reason i ask is sir-lancebot#734

dusky shoreBOT May 15, 2021, 12:04 AM

#

GitHub

IssueOpen Persist cog load states when using unload

tough imp May 15, 2021, 12:07 AM

#

there's sir-lancebot#705

dusky shoreBOT May 15, 2021, 12:07 AM

#

GitHub

IssueOpen Preserve The State Of Unloaded Cogs

fervent sage May 15, 2021, 12:07 AM

#

i read through every issue

#

and am blind

#

4th stupid fuck up ive done in the last day

#

just perfect

tough imp May 15, 2021, 12:09 AM

#

😔 dont feel bad about it

#

it's an interesting problem, i've been thinking about it for a while

#

because exts load before bot connects

fervent sage May 15, 2021, 12:10 AM

#

in theory there's no reason cogs shouldnt be able to be loaded from the async def login function right?

#

cogs should make the assumption they may be loaded or unloaded at any time, so they should™️ be able to be loaded dynamically at any time

tough imp May 15, 2021, 12:12 AM

#

theres the problem of renaming cogs, the bot should alert when the cache holds a name that doesnt match any existing cog, since that indicates a potential problem, but it cannot alert before it connects, so that information has to be stored somewhere

tough imp May 15, 2021, 12:14 AM

#

fervent sage in theory there's no reason cogs shouldnt be able to be loaded from the `async d...

i'm not sure, but I don't think it'd solve the problem entirely

#

whatever loads the cogs has to be able to tell the extensions manager that there was a problem

#

that information could live on the bot instance, but idk whether it should

vocal prairie May 15, 2021, 1:35 AM

#

In Django, is there a specification on how to link to a specific part of a page, or is it just the normal page/#id as it is in HTML?

exotic ember May 15, 2021, 1:36 AM

#

are you talking about our site pages specifically, or django in general?

vocal prairie May 15, 2021, 1:36 AM

#

PyDis site specifically

exotic ember May 15, 2021, 1:38 AM

#

you can just use a regular markdown link, ie [Python Discord Code of Conduct](/pages/code-of-conduct/), the link portion can be an absolute path starting at /pages/, or a relative path to the location of your page in the directory

#

then adding the id is just #id at the end, yeah

vocal prairie May 15, 2021, 1:39 AM

#

It's in an html file, not markdown

#

Sorry, I should've specified

exotic ember May 15, 2021, 1:42 AM

#

oh, you just use a regular <a> tag, but the href should use django's url template tag, see https://docs.djangoproject.com/en/3.1/ref/templates/builtins/#url

Built-in template tags and filters | Django documentation | Django

#

for reference, check out the navbar links at /pydis_site/templates/base/navbar.html

vocal prairie May 15, 2021, 1:46 AM

#

Got it, thank you!

short snow May 15, 2021, 3:39 AM

#

https://github.com/python-discord/sir-lancebot/pull/595 really short PR needing core dev approval

gritty wind May 15, 2021, 3:40 AM

#

I don’t think my comments were ever addressed

gritty wind May 15, 2021, 4:15 AM

#

How does one run the site now

#

it feels like JS isn't being loaded for me

#

#

started using manage.py runserver 8000

exotic ember May 15, 2021, 4:16 AM

#

have you tried hard refreshing?

gritty wind May 15, 2021, 4:16 AM

#

Yes

exotic ember May 15, 2021, 4:16 AM

#

gritty wind started using `manage.py runserver 8000`

I normally run on host using pipenv run start

gritty wind May 15, 2021, 4:17 AM

#

It's mainly that because that's the default pycharm django runner

#

but I'll try that too

#

Alright that's working

#

I wonder if it's the debug flag

exotic ember May 15, 2021, 4:17 AM

#

possibly

gritty wind May 15, 2021, 4:18 AM

#

I'll give that a shot

#

Thank you

#

Does the content app have auto reloads?

#

It's possible it does and I just have it misconfigured

#

Because django does watch for changes afaik

#

Nevermind me

#

it reloaded, I just didn't see it

short snow May 15, 2021, 4:33 AM

#

gritty wind I don’t think my comments were ever addressed

should be fixed now

eternal owl May 15, 2021, 6:00 AM

#

thorny obsidian <@!263560579770220554> Let me know when you have time to chat re: User Event Man...

Sure, lemme know you are free and we can talk about it

vale ibex May 15, 2021, 11:23 AM

#

Sick, that was easy

#

(#dev-log)

gritty wind May 15, 2021, 11:24 AM

#

what does github-ref return on main

vale ibex May 15, 2021, 11:24 AM

#

none

#

which is why the || is there

gritty wind May 15, 2021, 11:24 AM

#

👍

vale ibex May 15, 2021, 11:24 AM

#

I'll throw that in a comment

gritty wind May 15, 2021, 11:25 AM

#

hmm

#

shouldn't it return refs/heads/main

#

that's what the docs say

#

it'll work either way, but it makes the or redundant

vale ibex May 15, 2021, 11:26 AM

#

hmmm

#

The branch or tag ref that triggered the workflow. For example, refs/heads/feature-branch-1. If neither a branch or tag is available for the event type, the variable will not exist.

#

I took this is it wouldn't be there

gritty wind May 15, 2021, 11:26 AM

#

I have a CI testing repo on hand

#

I'll check and let you know

vale ibex May 15, 2021, 11:26 AM

#

Thanks ❤️

#

if that's the case, then yea, we remove it

gritty wind May 15, 2021, 11:27 AM

#

yeah it's redundant

#

I wonder what forks return

#

Fixed one, and left 3 more lemon_thinking

#

Gotta admit that's pretty funny

vale ibex May 15, 2021, 11:35 AM

#

yea lmfao

short snow May 15, 2021, 11:56 AM

#

@gritty wind I could remove the change in the emojis if needed, and keep only the .ttt log show <id> change

#

it basically moves this into a embed, so that it won't ping

deft patrol May 15, 2021, 12:51 PM

#

@trim cradle aha you in green tada

trim cradle May 15, 2021, 12:52 PM

#

deft patrol <@!253696366952316929> aha you in green <a:tada:800327713181007892>

I wear green clothes almost exclusively in real life, so it's just as well

fervent sage May 15, 2021, 12:52 PM

#

trim cradle I wear green clothes almost exclusively in real life, so it's just as well

CONGRATS

#

oop caps

#

lol

trim cradle May 15, 2021, 12:52 PM

#

Congrats on wearing green?

fervent sage May 15, 2021, 12:52 PM

#

on

gritty wind May 15, 2021, 12:52 PM

#

no, that's the right amount of hype

deft patrol May 15, 2021, 12:53 PM

#

well no wearing some kind of color 🤔

fervent sage May 15, 2021, 12:53 PM

#

getting the role and that it matches your green clothes

deft patrol May 15, 2021, 12:53 PM

#

idk

trim cradle May 15, 2021, 12:53 PM

#

The thrift store I used to go to made it easy. It was an lgbt thrift store and they used rainbow gradients for the clothes rack

deft patrol May 15, 2021, 12:53 PM

#

lol

#

Well, i guess he love green

#

https://avatars.githubusercontent.com/u/32915757?v=4

#

👀 green suit

#

@trim cradle

trim cradle May 15, 2021, 12:56 PM

#

That suit is black actually. Must be a lighting thing

deft patrol May 15, 2021, 12:57 PM

#

ooh but the green tie peeposhrug

#

lul

short snow May 15, 2021, 12:57 PM

#

anyway, I am curious what is this new project

deft patrol May 15, 2021, 12:58 PM

#

@short snow what project are you talking about?

short snow May 15, 2021, 12:58 PM

#

the one steler is leading

deft patrol May 15, 2021, 12:58 PM

#

oh got it

#

well vester too

gritty wind May 15, 2021, 12:58 PM

#

different projects

trim cradle May 15, 2021, 12:59 PM

#

Vester is working on a video series

vocal prairie May 15, 2021, 2:49 PM

#

I think the site needs a better Game Jams page. It has one right now, but all it says is "Sorry, this page is not ready yet." I think that's up for grabs.

#

cc: @thorny obsidian

thorny obsidian May 15, 2021, 3:04 PM

#

vocal prairie I think the site needs a better Game Jams page. It has one right now, but all it...

The Game Jam page can honestly be archived. With PyWeek we won't be doing our own separate one.

vocal prairie May 15, 2021, 3:05 PM

#

Okay. We still want a summary of the 2020 one though, right?

#

Also, is there a Code Jam logo that fits any year or time of year?

thorny obsidian May 15, 2021, 3:08 PM

#

vocal prairie Also, is there a Code Jam logo that fits any year or time of year?

I don't think we have an overall generic generic code jam logo. I can try to come up with one over the next week or so. Feel free to use last year's

thorny obsidian May 15, 2021, 3:08 PM

#

vocal prairie Okay. We still want a summary of the 2020 one though, right?

mmmmmm, we should probably include somethin4ge bute i THINK we can excluDe it for now

#

FIANCE Is very helpful with typING

green oriole May 15, 2021, 3:09 PM

#

lmao

vocal prairie May 15, 2021, 3:11 PM

#

thorny obsidian mmmmmm, we should *probably* include somethin4ge bute i THINK we can excluDe it ...

I won't include it on the events page for now, but I'll leave the 2020 page. Do you want me to move the url out of /events/game-jams/game-jam-2020 to /events/game-jam as a record?

thorny obsidian May 15, 2021, 3:11 PM

#

I gotta run to the grocery store before Seb's talk, so I'll be back later. And also yes, that sounds like a good idea

vale ibex May 15, 2021, 3:40 PM

#

aha, looking at @dusky shore actions

#

it looks like each workflow will need to be name spaced

#

otherwise each workflow will cancel each other

#

and only 1 will run

gritty wind May 15, 2021, 3:41 PM

#

o no

vale ibex May 15, 2021, 3:41 PM

#

I'll do that now

vocal wolf May 15, 2021, 3:41 PM

#

@sleek steppe what was the decision on ```py
await ctx.send()
return

vs
```py
return await ctx.send()

sleek steppe May 15, 2021, 3:41 PM

#

The first

vocal wolf May 15, 2021, 3:42 PM

#

k

vale ibex May 15, 2021, 3:43 PM

#

This seems like it'll work group: ${{ github.workflow }}-${{ github.ref }}

#

instead of manually setting the names

green oriole May 15, 2021, 3:44 PM

#

Hmm I was wondering about that

#

But they should trigger one after the other

vale ibex May 15, 2021, 3:44 PM

#

yea, it makes sense when you think about it

#

Hmm, IG we can merge this change and see if they get cancelled

green oriole May 15, 2021, 3:45 PM

#

Sure

vocal prairie May 15, 2021, 3:47 PM

#

Should I use GitHub's "fetch upstream" feature that pops up on my fork (site)?

vale ibex May 15, 2021, 3:47 PM

#

Yea, that'll update your fork with changes from the main repo

#

ok, this looks promising

#

it looks like the sentry and lint flows run in parallel

#

and since they're dependencies for the build flow, it didn't run

fervent sage May 15, 2021, 3:49 PM

#

there're a bunch of really old issues on lance which havent been touched in years, should some of them be closed?

vocal wolf May 15, 2021, 3:49 PM

#

fervent sage there're a bunch of really old issues on lance which havent been touched in year...

Yes.

#

I've been meaning to go over all issues in both the sir lance and bot repo

#

just haven't dedicated time to it

vale ibex May 15, 2021, 3:50 PM

#

Maybe we give it a few days on lance and then push to other repos?

#

this concurrency workflow thing that this

sleek steppe May 15, 2021, 3:50 PM

#

bot#1580 can be closed, it isn't even on the right repo

dusky shoreBOT May 15, 2021, 3:50 PM

#

GitHub

IssueOpen Wrong tooltip .mosaic

gritty wind May 15, 2021, 3:51 PM

#

chris too fast

vale ibex May 15, 2021, 3:52 PM

#

I'm sad, I don't have a sonic emote

vocal wolf May 15, 2021, 3:52 PM

#

lol

fervent sage May 15, 2021, 3:52 PM

#

there are other issues like sir-lancebot#338 which im sure a bunch of people whould be happy to do, but has so much stuff attached like the previous 2 PRs that it might be a bit overwhelming to work on (it certainly is for me)

dusky shoreBOT May 15, 2021, 3:52 PM

#

GitHub

IssueOpen Blank .bm bookmarking request message

fervent sage May 15, 2021, 3:53 PM

#

imo that could do with being closed, and a new issue opened with a tl;dr of the proposed implementation and comments from previous PRs

vocal wolf May 15, 2021, 4:01 PM

#

https://github.com/python-discord/sir-lancebot/blob/c09ab5c5b8a2d682c320229271e75f21d7b33256/bot/exts/evergreen/reddit.py#L102

#

uh

#

@sleek steppe why is this here?

sleek steppe May 15, 2021, 4:02 PM

#

Um actually I'm not sure

vocal wolf May 15, 2021, 4:02 PM

#

who added it lol

sleek steppe May 15, 2021, 4:02 PM

#

me lol

#

I think when resolving merge conflicts I messed something up

#

https://github.com/python-discord/sir-lancebot/commit/a7279c624b093ffe826edadbc999103083710953#diff-8cb2289b4d7c266aae03ba2e9b90e3caef94748d2f3169c83cd8c6b6bc5e5678

#

I'll fix that

vocal wolf May 15, 2021, 4:04 PM

#

I have it in my review

#

dw

#

you'll be able to commit through the comment in like 3 years when I'm done

sleek steppe May 15, 2021, 4:05 PM

#

Ah Ok

vocal wolf May 15, 2021, 4:05 PM

#

lmfao

#

very much /s

sleek steppe May 15, 2021, 4:05 PM

#

I'll just resolve merge conflicts for the fourth time

#

fifth actually

vocal wolf May 15, 2021, 4:06 PM

#

I wonder if you could've just used sed to do like

#

almost all the single to double quote conversion

#

I'd rather not deal with the regex though

sleek steppe May 15, 2021, 4:11 PM

#

What does this mean? 🤔

vale ibex May 15, 2021, 4:14 PM

#

which action?

sleek steppe May 15, 2021, 4:15 PM

#

It was lint but I don't see it anymore

fervent sage May 15, 2021, 4:17 PM

#

sir-lancebot#425 can probably also be closed and I can just stick it in sir-lancebot#710

dusky shoreBOT May 15, 2021, 4:17 PM

#

GitHub

IssueOpen New avatarmod command [name subject to change]
Optional user arguments

fervent sage May 15, 2021, 4:18 PM

#

those are not thr right way round in the embed lol

sleek steppe May 15, 2021, 4:20 PM

#

I thought we said we didn't want that 🤔

fervent sage May 15, 2021, 4:20 PM

#

not that i can see/recall

sleek steppe May 15, 2021, 4:21 PM

#

Well we talked about it here https://discordapp.com/channels/267624335836053506/635950537262759947/832329867743723550

fervent sage May 15, 2021, 4:22 PM

#

well

#

either way that issue can be closed

sleek steppe May 15, 2021, 4:25 PM

#

@green oriole for https://github.com/python-discord/sir-lancebot/pull/718#discussion_r632977867 do you mean matches[0]?

green oriole May 15, 2021, 4:25 PM

#

Do I?

sleek steppe May 15, 2021, 4:26 PM

#

leftovers is a string

green oriole May 15, 2021, 4:27 PM

#

maaaaaaaaayyybe

#

Oh, I see it

#

There's a conversion

#

            embed_title = "But there's another one!"
            leftovers = str(matches)
            embed_text = f"You have another match, this being {leftovers}."```
-> ```py
            embed_title = "But there's another one!"
            embed_text = f"You have another match, this being {matches[0]}."```

sleek steppe May 15, 2021, 4:27 PM

#

Yep

short snow May 15, 2021, 4:34 PM

#

short snow <@!386599446571384843> I could remove the change in the emojis if needed, and ke...

@gritty wind i think you missed this.

vocal wolf May 15, 2021, 4:34 PM

#

@sleek steppe finished review.

sleek steppe May 15, 2021, 4:34 PM

#

Thanks

vocal wolf May 15, 2021, 4:34 PM

#

I've lost like

#

a bunch of sanity near the end of it

gritty wind May 15, 2021, 4:34 PM

#

short snow <@!386599446571384843> i think you missed this.

I don't know

vocal wolf May 15, 2021, 4:34 PM

#

because I thought I was nearing the end

#

when I was like

#

in the middle

short snow May 15, 2021, 4:37 PM

#

is my review mentioned toxic?

sleek steppe May 15, 2021, 4:40 PM

#

https://github.com/python-discord/sir-lancebot/pull/718/commits/92c33d625068b9b39564dbf4fb9f6c1102711955

sleek steppe May 15, 2021, 5:48 PM

#

I feel like the review policy should be 1 staff/contrib approval since all core devs are staff 🤔

gritty wind May 15, 2021, 5:50 PM

#

Well, no

#

If you do that

#

The one core dev approval will merge

sleek steppe May 15, 2021, 5:51 PM

#

Oh true, I wasn't thinking lol

vale ibex May 15, 2021, 5:58 PM

#

Yea 😄 We always want at least 2 trusted people to approve a PR

#

and we want at least 1 core dev approval on everything

placid ermine May 15, 2021, 6:09 PM

#

#dev-log message
👀

#

interesting

sleek steppe May 15, 2021, 6:12 PM

#

I'm guessing this is because sir-lancebot#705 isn't finished

dusky shoreBOT May 15, 2021, 6:12 PM

#

GitHub

IssueOpen Preserve The State Of Unloaded Cogs

vale ibex May 15, 2021, 6:12 PM

#

Yea 😄

#

atm we're manually unloading it each time

vale ibex May 15, 2021, 6:46 PM

#

.help latex

dusky shoreBOT May 15, 2021, 6:46 PM

#

Query "latex" not found.

vale ibex May 15, 2021, 6:46 PM

#

nice

green oriole May 15, 2021, 6:48 PM

#

And we often forget to unload lol

fallen patrol May 15, 2021, 6:52 PM

#

🤔 why did it suggest this

#

vale ibex May 15, 2021, 6:52 PM

#

!s

stable mountainBOT May 15, 2021, 6:52 PM

#

Command Help

!site
Can also use: s

Commands for getting info about our website.

Subcommands:

!site faq
Info about the site's FAQ page.
!site help
Info about the site's Getting Help page.
!site home
Info about the website itself.
!site resources
Info about the site's Resources page.
!site rules [rules]...
Provides a link to all rules or, if specified, displays specific rule(s).
!site tools
Info about the site's Tools page.

vale ibex May 15, 2021, 6:52 PM

#

It's suggesting s

#

but then it appends the rest of your message

#

since it assumes those are parameters

green oriole May 15, 2021, 6:53 PM

#

Hah

#

You can mention the bot to run commands

vale ibex May 15, 2021, 6:53 PM

#

yup

fallen patrol May 15, 2021, 6:54 PM

#

nice

#

it detects filter circumvention with that as well

vale ibex May 15, 2021, 6:55 PM

#

filters come first

#

if a message matches a filter then it's deleted before a command is ran

vocal wolf May 15, 2021, 7:09 PM

#

@sleek steppe I reviewed the things and the stuff again. I think I may just fall over and sleep after reviewing so many files lol

sleek steppe May 15, 2021, 7:09 PM

#

lmao, I'll check it out

vocal wolf May 15, 2021, 7:09 PM

#

You used a single quote for quotes

#

in one of the changes

sleek steppe May 15, 2021, 7:09 PM

#

oh no

vocal wolf May 15, 2021, 7:09 PM

#

You've became the same thing you swore to destroy

sleek steppe May 15, 2021, 7:11 PM

#

Ahh it's because I just took away the f string

eternal owl May 15, 2021, 7:18 PM

#

Could we use a formatter like black in our pre commit config to convert single quotes to double?

sleek steppe May 15, 2021, 7:19 PM

#

We could, but we don't follow the same style guide as black, so it make things more difficult than not

eternal owl May 15, 2021, 7:21 PM

#

I think we can configure it to format specific stuff

#

not sure tho

#

reviewing your PR now, let me set a stopwatch to see how long it takes, lol

sleek steppe May 15, 2021, 7:29 PM

#

eternal owl I think we can configure it to format specific stuff

Ah didn't realize that

eternal owl May 15, 2021, 7:32 PM

#

is there a way to target non-modified files/lines during a review

sleek steppe May 15, 2021, 7:33 PM

#

No

vocal wolf May 15, 2021, 7:34 PM

#

If we used black to format stuff, I think even if we configured it a lot

#

it would still explode

#

and flake8 would be mad either way

#

also black really likes putting anything within brackets on different lines

#

for instance, ```py
embed = Embed(title="something")

would turn into
```py
embed = Embed(
  title="something"
)

eternal owl May 15, 2021, 7:35 PM

#

oof

#

that could be annoying for short lines

vocal wolf May 15, 2021, 7:36 PM

#

yep

#

@sleek steppe I've looked over as many things as I could. It looks fine to me.

#

thank you for the PR

sleek steppe May 15, 2021, 7:37 PM

#

sir-lancebot#718

dusky shoreBOT May 15, 2021, 7:37 PM

#

GitHub

PROpen Spring cleanup

vocal wolf May 15, 2021, 7:37 PM

#

sir-lance#718

#

yeah that one

sleek steppe May 15, 2021, 7:37 PM

#

I'll just commit your suggestions now

vocal wolf May 15, 2021, 7:37 PM

#

@clever wraith will you be doing something about this soon?

https://github.com/python-discord/bot/pull/1558

#

stuff and things need to be resolved.

eternal owl May 15, 2021, 7:38 PM

#

are you merging it?

vocal wolf May 15, 2021, 7:38 PM

#

eternal owl are you merging it?

the spring cleaning?

eternal owl May 15, 2021, 7:38 PM

#

ye

vocal wolf May 15, 2021, 7:38 PM

#

not atm, no

eternal owl May 15, 2021, 7:38 PM

#

okay

vocal wolf May 15, 2021, 7:38 PM

#

it's 84 files, I don't think I'm good enough for approval lol

#

thanks

sleek steppe May 15, 2021, 7:40 PM

#

Conflict #6

fallen patrol May 15, 2021, 7:45 PM

#

@vocal wolf one of the bots use black in its pre-commit iirc

vocal wolf May 15, 2021, 7:45 PM

#

which one?

fallen patrol May 15, 2021, 7:46 PM

#

Doesnt Lance?

vocal wolf May 15, 2021, 7:46 PM

#

let me check

sleek steppe May 15, 2021, 7:46 PM

#

Nope

vocal wolf May 15, 2021, 7:46 PM

#

pretty sure it doesn't

sleek steppe May 15, 2021, 7:46 PM

#

https://github.com/python-discord/sir-lancebot/blob/main/Pipfile#L20-L30

stable mountainBOT May 15, 2021, 7:46 PM

#

Pipfile lines 20 to 30

[dev-packages]
flake8 = "~=3.8"
flake8-annotations = "~=2.3"
flake8-bugbear = "~=20.1"
flake8-docstrings = "~=1.5"
flake8-import-order = "~=0.18"
flake8-string-format = "~=0.3"
flake8-tidy-imports = "~=4.1"
flake8-todo = "~=0.7"
pep8-naming = "~=0.11"
pre-commit = "~=2.1"```

sleek steppe May 15, 2021, 7:47 PM

#

^ those are all of the dev packages

fallen patrol May 15, 2021, 7:47 PM

#

🤔

#

Hm

patent pivot May 15, 2021, 7:48 PM

#

we don't use black on any of our projects

#

(and probably won't, flakke8 is fine)

hardy gorge May 15, 2021, 7:49 PM

#

I'm secretly using black somewhere. Don't tell anyone.

vocal wolf May 15, 2021, 7:49 PM

#

lol

patent pivot May 15, 2021, 7:50 PM

#

hahaha

fervent sage May 15, 2021, 7:51 PM

#

hardy gorge I'm secretly using black somewhere. Don't tell anyone.

is it in ||[redacted]||?

vocal wolf May 15, 2021, 7:56 PM

#

@patent pivot Congratulations! You've been randomly selected to review the Spring Cleaning PR! This isn't a choice, you must do it now.

https://github.com/python-discord/sir-lancebot/pull/718

patent pivot May 15, 2021, 7:56 PM

#

oh lord

sleek steppe May 15, 2021, 7:57 PM

#

lol

thorny obsidian May 15, 2021, 8:00 PM

#

Lmao Xith is my fave domain lead now

vocal wolf May 15, 2021, 8:00 PM

#

:D

fervent sage May 15, 2021, 8:03 PM

#

xith > *

eternal owl May 15, 2021, 8:12 PM

#

which editor do you use @sleek steppe

sleek steppe May 15, 2021, 8:23 PM

#

eternal owl which editor do you use <@!506618674921340958>

VSCode

eternal owl May 15, 2021, 8:23 PM

#

right

#

so in pycharm, it is showing me some type annotation errors which could be useful for this PR

#

error highlights

#

and typos

sleek steppe May 15, 2021, 8:24 PM

#

We can't be strict with typing when using discord.py lol

eternal owl May 15, 2021, 8:25 PM

#

I mean, incorrect function return type annotations, etc

#

I will include some of them in the review if not all

sinful schooner May 15, 2021, 8:26 PM

#

I have a question

eternal owl May 15, 2021, 8:29 PM

#

if its regarding python/python libs, you can check out #❓｜how-to-get-help, if its regarding our projects on github, you can ask here

vale ibex May 15, 2021, 8:55 PM

#

!docs refreshdoc

stable mountainBOT May 15, 2021, 8:55 PM

#

Inventories refreshed

vale ibex May 15, 2021, 8:55 PM

#

(see #dev-log)

green oriole May 15, 2021, 9:14 PM

#

It is 11pm

fallen patrol May 15, 2021, 9:14 PM

#

@vale ibex it moved to https://flask.palletsprojects.com/en/2.0.x/testing/

green oriole May 15, 2021, 9:15 PM

#

spring cleanup is merged TODAY

fallen patrol May 15, 2021, 9:15 PM

#

green oriole spring cleanup is merged TODAY

u have 45 minutes

green oriole May 15, 2021, 9:16 PM

#

Yes

#

@sleek steppe are you still around?

sleek steppe May 15, 2021, 9:17 PM

#

Yeah

green oriole May 15, 2021, 9:17 PM

#

There are a couple of comments to solve from iceman, if you can please

sleek steppe May 15, 2021, 9:17 PM

#

Yep

vale ibex May 15, 2021, 9:21 PM

#

I'm not entirely sure how to manage the docs, I think this is right, can someone double check? !docs setdoc flask https://flask.palletsprojects.com/en/2.0.x/ https://flask.palletsprojects.com/en/2.0.x/objects.inv

green oriole May 15, 2021, 9:23 PM

#

Seems correct

vocal prairie May 15, 2021, 9:23 PM

#

That looks right to me, but you might need the /api/ on the end

#

Since you want the docs to redirect to the API reference

vale ibex May 15, 2021, 9:24 PM

#

hmm, true

#

!docs setdoc flask https://flask.palletsprojects.com/en/2.0.x/api/ https://flask.palletsprojects.com/en/2.0.x/objects.inv

stable mountainBOT May 15, 2021, 9:25 PM

#

According to the API, your request is malformed.

vale ibex May 15, 2021, 9:25 PM

#

Sadge

green oriole May 15, 2021, 9:25 PM

#

Sad

vale ibex May 15, 2021, 9:26 PM

#

!docs setdoc flask https://flask.palletsprojects.com/en/2.0.x/ https://flask.palletsprojects.com/en/2.0.x/objects.inv

stable mountainBOT May 15, 2021, 9:26 PM

#

According to the API, your request is malformed.

vale ibex May 15, 2021, 9:26 PM

#

🤔

green oriole May 15, 2021, 9:26 PM

#

There is no logging anywhere

#

that’s so helpful

#

I assume a validator isn’t liking it

vale ibex May 15, 2021, 9:26 PM

#

It's raising a ResponseCodeError

#

and getting handled in the error handler

green oriole May 15, 2021, 9:27 PM

#

You can see on the site log it is returning 400

vale ibex May 15, 2021, 9:27 PM

#

Bad Request: /bot/documentation-links

#

hmmm

green oriole May 15, 2021, 9:29 PM

#

I mean, we could run the validators manually

vale ibex May 15, 2021, 9:30 PM

#

400: if the request body has invalid fields, see the response for details

#

odd

sleek steppe May 15, 2021, 9:30 PM

#

@eternal owl https://hackmd.io/@Y1bKKDhaRoeTMz_bW9jEOg/SkqibsT_O for the last comment, did you link the wrong thing?

eternal owl May 15, 2021, 9:30 PM

#

ops I prolly did

#

fun.py

#

line 203

#

return statement of _get_text_and_embed

sleek steppe May 15, 2021, 9:31 PM

#

ah

vale ibex May 15, 2021, 9:32 PM

#

Does it return a 400 if it already exists?

green oriole May 15, 2021, 9:33 PM

#

Hmmm

#

Not sure

vale ibex May 15, 2021, 9:33 PM

#

We could del and add

green oriole May 15, 2021, 9:33 PM

#

What is its pk

vale ibex May 15, 2021, 9:33 PM

#

package name

green oriole May 15, 2021, 9:34 PM

#

That could be it

vale ibex May 15, 2021, 9:34 PM

#

!d

stable mountainBOT May 15, 2021, 9:34 PM

#

All inventories (`23` total)

• aiohttp
• arcade
• asyncpg
• dateutil
• discordpy
• django
• flask

green oriole May 15, 2021, 9:34 PM

#

what isnthe command

#

thanks

#

Yeah, most probably

vale ibex May 15, 2021, 9:35 PM

#

!docs deletedoc flask

stable mountainBOT May 15, 2021, 9:35 PM

#

Successfully deleted flask and refreshed the inventories.

vale ibex May 15, 2021, 9:35 PM

#

!docs setdoc flask https://flask.palletsprojects.com/en/2.0.x/api/ https://flask.palletsprojects.com/en/2.0.x/objects.inv

stable mountainBOT May 15, 2021, 9:35 PM

#

Added the package flask to the database and updated the inventories.

green oriole May 15, 2021, 9:35 PM

#

@eternal owl do you wanna give it a last look? No obligation, we have enough reviews

vale ibex May 15, 2021, 9:35 PM

#

!d flask

stable mountainBOT May 15, 2021, 9:35 PM

#

flask

Unable to parse the requested symbol.

eternal owl May 15, 2021, 9:35 PM

#

green oriole <@!263560579770220554> do you wanna give it a last look? No obligation, we have ...

which

vale ibex May 15, 2021, 9:36 PM

#

Looks like it's appending the /api/ itself

green oriole May 15, 2021, 9:36 PM

#

Spring cleanup

vale ibex May 15, 2021, 9:36 PM

#

!docs deletedoc flask

stable mountainBOT May 15, 2021, 9:36 PM

#

Successfully deleted flask and refreshed the inventories.

vale ibex May 15, 2021, 9:36 PM

#

!docs setdoc flask https://flask.palletsprojects.com/en/2.0.x/ https://flask.palletsprojects.com/en/2.0.x/objects.inv

stable mountainBOT May 15, 2021, 9:36 PM

#

Added the package flask to the database and updated the inventories.

eternal owl May 15, 2021, 9:36 PM

#

I haven't done all files, but you can merge it I guess

vale ibex May 15, 2021, 9:36 PM

#

!flask

#

!d flask

stable mountainBOT May 15, 2021, 9:36 PM

#

flask

This part of the documentation covers all the interfaces of Flask. For parts where Flask depends on external libraries, we document the most important right here and provide links to the canonical documentation.

eternal owl May 15, 2021, 9:36 PM

#

since there are enough reviews

vale ibex May 15, 2021, 9:36 PM

#

Nice

#

!d testing

stable mountainBOT May 15, 2021, 9:36 PM

#

testing

vale ibex May 15, 2021, 9:37 PM

#

I'm gonna move over to spam

green oriole May 15, 2021, 9:37 PM

#

eternal owl since there are enough reviews

That’s up to you, I wouldn’t want you to feel like you lost your time before you didn’t submit your review

sleek steppe May 15, 2021, 9:37 PM

#

I think I'll test more so nothing's broken

green oriole May 15, 2021, 9:37 PM

#

;-;

eternal owl May 15, 2021, 9:37 PM

#

I prolly won't find time or energy again, if I sit for a review, it will prolly be in like 24-48 hours 😬

green oriole May 15, 2021, 9:37 PM

#

you have 23 minutes (/s)

eternal owl May 15, 2021, 9:38 PM

#

so you can go ahead and merge when ready, no need to wait for me

green oriole May 15, 2021, 9:38 PM

#

Alrighty, thanks for the review!

sleek steppe May 15, 2021, 9:38 PM

#

ye merge

vale ibex May 15, 2021, 9:39 PM

#

push the button

sleek steppe May 15, 2021, 9:39 PM

#

eternal owl May 15, 2021, 9:39 PM

#

only core devs can merge?

sleek steppe May 15, 2021, 9:39 PM

#

If I was able to merge then it would be green

vale ibex May 15, 2021, 9:39 PM

#

I was presuming Ak wanted to do the honours lol

green oriole May 15, 2021, 9:40 PM

#

YES

vale ibex May 15, 2021, 9:40 PM

#

TOO BAD

#

lul

#

I was so tempted

eternal owl May 15, 2021, 9:40 PM

#

sleek steppe If I was able to merge then it would be green

true

green oriole May 15, 2021, 9:41 PM

#

I feel so much better now

#

I can go sleep

sleek steppe May 15, 2021, 9:41 PM

#

nice finally 😩

eternal owl May 15, 2021, 9:41 PM

#

lol

#

what time is it there

green oriole May 15, 2021, 9:42 PM

#

Still May 15th

#

11:42pm

#

Okay, let’s not do a PR like that again, shall we

eternal owl May 15, 2021, 9:42 PM

#

lol

#

its 3:12 AM here, tmw sunday, so no sleep time

#

nvm, its already sunday

#

@short snow reviewed the wiki guess PR, just a few changes and bugs detected.

sleek steppe May 15, 2021, 9:43 PM

#

Now we see if anything is broken

#

Also I think I put merge conflicts on every PR DogKek

eternal owl May 15, 2021, 9:44 PM

#

you sure did haha

sleek steppe May 15, 2021, 9:46 PM

#

The conflicts on sir-lancebot#683 a big

dusky shoreBOT May 15, 2021, 9:46 PM

#

GitHub

PROpen Updates Sir-lancebot To Python3.9.4

vale ibex May 15, 2021, 9:46 PM

#

I closed my last long standing Pr yesterday

#

Cool

sleek steppe May 15, 2021, 9:47 PM

#

||I think I can delete my fork now||

vocal prairie May 15, 2021, 9:47 PM

#

vale ibex Looks like it's appending the /api/ itself

Maybe the object.inv had it already

fervent sage May 15, 2021, 9:48 PM

#

wait did we merge cleanup 👁️

vocal prairie May 15, 2021, 9:48 PM

#

Apparently

fervent sage May 15, 2021, 9:48 PM

#

YES!

vale ibex May 15, 2021, 9:48 PM

#

vocal prairie Maybe the object.inv had it already

Yea, probably 😄

eternal owl May 15, 2021, 9:49 PM

#

sleek steppe ||I think I can delete my fork now||

I should prolly do that too

#

I have been working on my fork forever

sleek steppe May 15, 2021, 9:50 PM

#

ah nice it got to 1500 additions/deletions before the merge

eternal owl May 15, 2021, 9:52 PM

#

gn bois

sleek steppe May 15, 2021, 9:52 PM

#

@fervent sage https://github.com/python-discord/sir-lancebot/issues/689#issuecomment-822447940 mmLul

fervent sage May 15, 2021, 9:53 PM

#

pog

fervent sage May 15, 2021, 10:24 PM

#

aye, sir-lancebot#738

dusky shoreBOT May 15, 2021, 10:24 PM

#

GitHub

PROpen feat: allow replying to messages to bookmark

sleek steppe May 15, 2021, 10:31 PM

#

fervent sage aye, sir-lancebot#738

The thing about optional is that if the converter is failed, is that it's silenced. Maybe the error should say "valid message" or something

fervent sage May 15, 2021, 10:32 PM

#

sleek steppe The thing about optional is that if the converter is failed, is that it's silenc...

done

#

initially i had that wording, then went down a massive rabbithole of trying to do smart converty stuff to make the converter work normally with that error and eventaually i gave up and went back to this

sleek steppe May 15, 2021, 10:33 PM

#

lol

fallen patrol May 15, 2021, 10:38 PM

#

fervent sage aye, sir-lancebot#738

that was rejected multiple times by joe

fervent sage May 15, 2021, 10:41 PM

#

no it wasnt?

fallen patrol May 15, 2021, 11:11 PM

#

@fervent sage #dev-contrib message

#

fervent sage May 15, 2021, 11:22 PM

#

Well here's my take:

The issue is approved
Very few people use the bookmark command
Very few people who use the bookmark command will use the reply
Those few people are likely the ones who will turn off pings anyway

#

It can be undone pretty fast anyway

patent pivot May 16, 2021, 12:01 AM

#

lol

#

i think both of those are opinions

#

and ya, I think it's fine & am fine with it being implemented 🙂

#

if I had objections the issue probably wouldn't be approved, or we would have discussed it

short snow May 16, 2021, 12:32 AM

#

eternal owl <@!736234578745884682> reviewed the wiki guess PR, just a few changes and bugs d...

I was looking to merge those files, and keep them into separate classes just, I don't really like the jumping of contributors from file to file.

fallen patrol May 16, 2021, 1:14 AM

#

pithink

#

just launched lance in docker

#

why are both enabled

#

ik

#

just wondering why both are enabled

#

rather than the one

#

also its may

#

so neither task should have starting 🤔

#

oh wait

sleek steppe May 16, 2021, 1:16 AM

#

They aren't sending it

fallen patrol May 16, 2021, 1:16 AM

#

nvm i understand how it probably works

#

yeah

#

because in theory the bot could be on all year round

#

without ever turning off

#

so the tasks need to be there, just not sending?

sleek steppe May 16, 2021, 1:25 AM

#

https://github.com/python-discord/sir-lancebot/blob/e6e280cd13236647ffcaa35f522baeb747fbf97e/bot/utils/decorators.py#L35

stable mountainBOT May 16, 2021, 1:26 AM

#

bot/utils/decorators.py line 35

def seasonal_task(*allowed_months: Month, sleep_time: t.Union[float, int] = ONE_DAY) -> t.Callable:```

sleek steppe May 16, 2021, 1:26 AM

#

@fallen patrol ^

#

so if you set DEBUG=true in your .env file, you would see that it's sleeping for a day

fallen patrol May 16, 2021, 5:19 AM

#

🤔

#

[scripts]
start = "python -m bot"

#

https://paste.pythondiscord.com/covogijomu.py

#

what is wrong?

gritty wind May 16, 2021, 5:21 AM

#

python 3.7

#

project uses 3.8

fallen patrol May 16, 2021, 5:49 AM

#

ah.

fallen patrol May 16, 2021, 6:03 AM

#

gritty wind python 3.7

So means scripts like that only work on 3.8??

#

Because I don't get that error when i run that Same script without the shortcut name

#

Or when I run it in the pipenv venv.

gritty wind May 16, 2021, 6:04 AM

#

Things change between versions

#

It can be any number of things

fallen patrol May 16, 2021, 6:04 AM

#

Wait I know the cause nvm

#

My system python 3.7

#

So when I do pipenv in the environment it's actually running on 3.7

#

Even if I also have 3.7 for the bot

gritty wind May 16, 2021, 6:05 AM

#

try installing pipenv on your 3.8 environment, or try using pipx

fallen patrol May 16, 2021, 6:10 AM

#

I'm more curious why I get that error altogether

#

If I enter the venv and then try it it works fine even though it's a 3.7 venv as well

fervent sage May 16, 2021, 1:08 PM

#

@vale ibex hey :P you around to quickly look over the boomark pr

vale ibex May 16, 2021, 1:14 PM

#

sort of, request my review and I'll give it a look when I can

gritty wind May 16, 2021, 1:47 PM

#

Hey @vale ibex if you've got time, I replied to your comment on the 3.9 PR

vale ibex May 16, 2021, 1:47 PM

#

I saw and resolved 😄

gritty wind May 16, 2021, 1:47 PM

#

schweet

vale ibex May 16, 2021, 1:48 PM

#

fervent sage <@!126811506632294400> hey :P you around to quickly look over the boomark pr

Does 1.6 bring anything breaking?

#

I'm not against bumping

sleek steppe May 16, 2021, 1:50 PM

#

Hmm I think the only breaking change is in 1.7

#

Which is also an easy fix

fervent sage May 16, 2021, 1:53 PM

#

vale ibex Does 1.6 bring anything breaking?

shouldnt break anything

green oriole May 16, 2021, 1:55 PM

#

Discord will take care of breaking it, don't worry

sleek steppe May 16, 2021, 1:57 PM

#

I could make a PR to bump dpy to 1.6

vale ibex May 16, 2021, 1:57 PM

#

What's the breaking change in 1.7?

#

If we're bumping, might as well goto 1.7.2

sleek steppe May 16, 2021, 1:58 PM

#

We subclass commands.Paginator which has adds a linesep kwarg which broke the paginator when we were upgrading to 1.7 in sir-lancebot#683

dusky shoreBOT May 16, 2021, 1:59 PM

#

GitHub

PROpen Updates Sir-lancebot To Python3.9.4

vale ibex May 16, 2021, 1:59 PM

#

ahhh yea

green oriole May 16, 2021, 1:59 PM

#

... I cannot process this sentence, I need some coffee

fervent sage May 16, 2021, 1:59 PM

#

should i put my pr on hold until we're beyind 1.6 so we dont need to ever have any annoying workarounds in the bot

green oriole May 16, 2021, 2:00 PM

#

Frick, I don't drink coffee

green oriole May 16, 2021, 2:00 PM

#

fervent sage should i put my pr on hold until we're beyind 1.6 so we dont need to ever have a...

Yeah, probably

sleek steppe May 16, 2021, 2:00 PM

#

green oriole ... I cannot process this sentence, I need some coffee

nahh, that was just a bad sentence lol

green oriole May 16, 2021, 2:00 PM

#

Aha thanks

#

Sounds like an easy fix

vale ibex May 16, 2021, 2:00 PM

#

I think we should re-do sir-lancebot#683 with just the changes required to upgrade to 3.9 and bump versions

dusky shoreBOT May 16, 2021, 2:00 PM

#

GitHub

PROpen Updates Sir-lancebot To Python3.9.4

vale ibex May 16, 2021, 2:00 PM

#

without the extra changes in there

#

will make it easier to review & test

#

We can change type hints etc as we come to them

green oriole May 16, 2021, 2:01 PM

#

I disagree, updating type hints is part of the upgrade

sleek steppe May 16, 2021, 2:01 PM

#

It also has a billion conflicts right now lol

green oriole May 16, 2021, 2:01 PM

#

We should migrate to the nicer interface

#

Honestly we should do some freezes when doing major reworks like that

#

If lance doesn't get any merge in a week, there's no harm

short snow May 16, 2021, 2:02 PM

#

sleek steppe It also has a billion conflicts right now lol

oh shit, I completely forgot about the PR

#

do you want to fix them? 😛

sleek steppe May 16, 2021, 2:03 PM

#

@short snow since your here, feel free...

short snow May 16, 2021, 2:03 PM

#

oh god on god

green oriole May 16, 2021, 2:03 PM

#

My lord

short snow May 16, 2021, 2:03 PM

#

i will do it soon™️

#

!remind 12h do it

stable mountainBOT May 16, 2021, 2:03 PM

#

Okay.

Your reminder will arrive in 12 hours!

short snow May 16, 2021, 2:03 PM

#

and die in peace

sleek steppe May 16, 2021, 2:03 PM

#

The ellipsis at the end makes it funnier lol

gritty wind May 16, 2021, 2:05 PM

#

I think the type hinting shouldn’t be done in a PR

patent pivot May 16, 2021, 2:05 PM

#

green oriole I disagree, updating type hints is part of the upgrade

I don't like this because it leads to more huge PRs, we should stick to one overall change per PR and since typehints are non-breaking they don't need to be changed in the same PR as CI and dev tools amendments

gritty wind May 16, 2021, 2:05 PM

#

This is spring cleanup all over again

#

Let’s just add this to the poetry PR

#

So it’s poetry and deps

green oriole May 16, 2021, 2:05 PM

#

gritty wind Let’s just add this to the poetry PR

That's just worse lol

gritty wind May 16, 2021, 2:06 PM

#

Upgrading d.py in a dep bump is worse?

green oriole May 16, 2021, 2:06 PM

#

If we really wish to we can generate a PR and make sure that they are enough people online to merge in like 42 minutes

gritty wind May 16, 2021, 2:06 PM

#

I don’t think we should make an explicit effort to upgrade type hints

#

We gain nothing from it

#

And just waste time

#

Type hints can be upgraded implicitly over time

#

As you change code or add new code

green oriole May 16, 2021, 2:06 PM

#

Uniformising them is nice

gritty wind May 16, 2021, 2:07 PM

#

Not really worth the time though

green oriole May 16, 2021, 2:07 PM

#

Perhaps, yeah

patent pivot May 16, 2021, 2:07 PM

#

gritty wind Type hints can be upgraded implicitly over time

I like this approach

gritty wind May 16, 2021, 2:08 PM

#

Have you gotten a chance to update the 3.9 poetry branch yet

green oriole May 16, 2021, 2:09 PM

#

We should really use feature freezes more

patent pivot May 16, 2021, 2:09 PM

#

Not yet, I won't be able to look at it until the end of the week, but any staffer is free to take it over, just let me know

green oriole May 16, 2021, 2:09 PM

#

Having a 1k lines conflict is not okay

merry ember May 16, 2021, 2:09 PM

#

Hi, I'm having issues with LinePaginator. I get varying lines between pages, and not because there are no more items. I want to display 10 lines per page but can't get it to work, other than with ImagePaginator, but that feels like the wrong tool.

sleek steppe May 16, 2021, 2:10 PM

#

I think it's a good idea to just upgrade discord.py in the poetry PR

patent pivot May 16, 2021, 2:10 PM

#

I hate the idea of using feature freezes, they should be a last-ditch effort when there are no other solutions.

#

Shutting down enthusiastic contributors isn't a good idea

green oriole May 16, 2021, 2:11 PM

#

We can always have ready to merge PRs but just hold them for a bit

patent pivot May 16, 2021, 2:11 PM

#

but then we have several PRs which are just gathering conflicts

green oriole May 16, 2021, 2:11 PM

#

As long as we keep freezes short and spare, it should be alright in my opinion

green oriole May 16, 2021, 2:12 PM

#

patent pivot but then we have several PRs which are just gathering conflicts

It will generate conflicts either way

patent pivot May 16, 2021, 2:12 PM

#

We just should aim not to have PRs which change hundreds of lines, that's the solution, we don't need to open a PR changing hundreds of type hints.

green oriole May 16, 2021, 2:13 PM

#

I'm not talking about this one in particular, but some PRs will have to generate big changes, like when we had the wiki freeze

gritty wind May 16, 2021, 2:13 PM

#

We don’t usually do huge migrations

green oriole May 16, 2021, 2:13 PM

#

Some version bumps can also cause that (although here it doesn't since it is optional)

gritty wind May 16, 2021, 2:13 PM

#

Those are special cases we should minimize

green oriole May 16, 2021, 2:14 PM

#

Even if we minimize them, we would run into one one day or the other

#

We should better be prepared next time we do

#

That's all I'm saying

gritty wind May 16, 2021, 2:14 PM

#

We’ll handle those as the need arises

#

I don’t think we’ll often be surprised by us having to make large migrations

#

Those things are usually known in advance, or don’t immediately go into effect

patent pivot May 16, 2021, 2:17 PM

#

Yeah, we can handle them, I just don't think we should have a policy of using more freezes, iirc we've only ever used 2 in PyDis history for the move to Django and dewikification, and both of those were fairly annoying to deal with

fervent sage May 16, 2021, 2:17 PM

#

if this is gonna be a fairly big thing can i just bump d.py to 1.6 in my pr so it works better, since it wont break anything

#

then whenever the poetry thing happens it can go to 1.7.2

patent pivot May 16, 2021, 2:18 PM

#

bumping to 1.7.2 shouldn't be a large PR should it?

#

isn't the modification only in the paginatior

sleek steppe May 16, 2021, 2:19 PM

#

yeah it shouldn't be a large PR

patent pivot May 16, 2021, 2:21 PM

#

we can probably put it in the poetry PR then since it's already touching dependencies

#

but yeah, I won't be able to get to that until Friday

fervent sage May 16, 2021, 2:21 PM

#

joe when do your a levels finish?

short snow May 16, 2021, 2:22 PM

#

so the update sir lancebot to 3.9.4 by me and toxic is not needed?

vale ibex May 16, 2021, 2:23 PM

#

I'm gonna resolve conflicts in the poetry PR and commit a version bump

gritty wind May 16, 2021, 2:25 PM

#

Make sure to delete the lock file

#

That’ll update sub dependencies

#

(Also makes locking faster hyperlemon )

vale ibex May 16, 2021, 2:28 PM

#

I think I've done it

patent pivot May 16, 2021, 2:31 PM

#

fervent sage joe when do your a levels finish?

Friday lol

fervent sage May 16, 2021, 2:31 PM

#

a week before mine pensivewobble

gritty wind May 16, 2021, 2:34 PM

#

Go study Alec smh

#

I’ve got a feeling something went very very wrong Chris

#

Oh I was looking at the wrong diff lmao

vale ibex May 16, 2021, 2:37 PM

#

lmfao

#

kk so the poetry PR is ready

#

once this is merged we should do the deps bump

#

Hmmm, it's asking for builldtools to install multidict

#

Do we need to bump one of the deps?

#

I'd rather not have gcc in the image if poss

gritty wind May 16, 2021, 2:48 PM

#

Can you post the traceback

#

We shouldn’t need them

#

Also post the result of the poetry graph

vale ibex May 16, 2021, 2:49 PM

#

!paste

stable mountainBOT May 16, 2021, 2:49 PM

#

Pasting large amounts of code

If your code is too long to fit in a codeblock in discord, you can paste your code here:
https://paste.pydis.com/

After pasting your code, save it by clicking the floppy disk icon in the top right, or by typing ctrl + S. After doing that, the URL should change. Copy the URL and post it here so others can see it.

vale ibex May 16, 2021, 2:49 PM

#

https://paste.pythondiscord.com/ugagepivet.shell

#

https://paste.pythondiscord.com/abehimadog.sql

#

looks like d.py depends on it

#

I can try bump d.py in this pr

sleek steppe May 16, 2021, 2:51 PM

#

Oh I thought that's what you did

#

oh you reverted it

vale ibex May 16, 2021, 2:51 PM

#

I was going to do them seperatly

gritty wind May 16, 2021, 2:51 PM

#

Interesting

vale ibex May 16, 2021, 2:51 PM

#

in different PRs to make it easire ot review & test

#

but now that I've bumped d.py to 1.7.2 it's fine

#

So I'll update the paginator now too

gritty wind May 16, 2021, 2:52 PM

#

Ah that makes sense

#

I was wondering why we didn't need that on python

#

it already used 1.6

sleek steppe May 16, 2021, 2:53 PM

#

1.6 supports python 3.9 but 1.5 doesn't

vale ibex May 16, 2021, 2:54 PM

#

kk pushed

#

it builds fine, runs and paginator works