I think that's what #mod-tools message is about
#dev-contrib
vale ibex
sleek steppe
No access to link 😔
sleek steppe
I'm fine with that, I'd like getting to 1k additions/deletions
vocal wolf
No access to link 😔
maybe one day lol
vale ibex
I think we can leave this PR as is and have the others as issues
or we can include the tvban part in this pr
vocal wolf
@short snow In bot#1564, please make purgeban not take any argument for purge days, but instead take args for time. If time exists, don't permaban.
Please also do the same thing for voiceban, where if a time is supplied, it won't be permanent.
dusky shoreBOT
vocal wolf
<@!736234578745884682> In bot#1564, please make purgeban not take any argument f...
@vale ibex good?
vale ibex
Yea, since we're removing the arg for purge days, just make sure we still use 1 day as a const.
We should add this scope to the issue/PR for context
eternal owl
will it be possible to make a custom cooldown decorator that applies cooldown based on the command arguments?
sleek steppe
Yes
balmy sparrow
it looks like wrapping things in ` to make codeblocks is a rather common usecase, maybe we could make a util for it?
sleek steppe
I like how the docstring for the SourceConverter on lancebot still has tag in it
brazen charm
it looks like wrapping things in \` to make codeblocks is a rather common usecas...
In what way would it work? Wrap some passed in string in backticks?
sleek steppe
@balmy sparrow should all converters go in converter.py?
balmy sparrow
i saw some places with
strikethrough = "~~"
...
strikethrough + "text" + strikethrough
``` and the suchi'd assume them all to be there
or is that not how everyone else thinks?
fervent sage
<@!271586885346918400> should all converters go in converter.py?
imo yea
brazen charm
I don't think passing it through an util function instead really helps the readability of the string, do you have an example on how it'd look compared to just doing ```
f"`{text}`"
forget i said this, adding the symbols are definitely easier
yeah, you're right, it's more readable this way
sleek steppe
nice
sleek steppe
Well the checks passed
sleek steppe
Also that's only on bot right
sleek steppe
Oh lancebot has no tests
balmy sparrow
what do you think about merging the ping command cog and the uptime command cog?
https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/evergreen/uptime.py
https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/evergreen/ping.py
vocal prairie
I think that's a good idea, it would be cleaner
fervent sage
i'm good with ^ if a core dev is, considering i made the ping command i'd like to take it on
(will make an issue)
patent pivot
done
balmy sparrow
@fervent sage will it conflict if we merge your PR now before the spring cleaning PR?
fervent sage
yep but the conflicts shouldnt be too bad to fix
(+ i can fix them myself which im fine with)
stable mountainBOT
Pipfile line 13
"async-rediscache[fakeredis]" = "~=0.1.2"```
gritty wind
Used to think this format meant optional dependency
But I can't find anything about it in the pipenv docs
Tbf the pipenv docs are shit
Anyone know what it actually means?
gritty wind
yeah
vale ibex
also "~=0.1.2" is wrong
patent pivot
yeah it is extra optional deps
gritty wind
SO post says extras option for extras
patent pivot
for example, aiohttp has a speedups extra which brings aiodns, cchardet and a few other things
tough imp
also "~=0.1.2" is wrong
Are you sure? I think ~=0.1.2 will allow 0.1.3 but not 0.2
~=0.1 would allow 0.2
vale ibex
would it?
vale ibex
I think I'm misunderstanding then
I was under the assumption ~=0.1 would only allow ~=0.1.X
IG I was wrong
Ahh yes I see now
~=0.1 is >=0.1, ==0.*
TIL, thanks
tough imp
Yea it's "this or higher right-most number"
vale ibex
yea
sleek steppe
@balmy sparrow I'm not sure about replacing return from with return by
balmy sparrow
what's this referring to 
balmy sparrow
🤔 i felt like "returned by" sounded right
but english isn't my first language, so maybe I'm wrong there
fervent sage
i think returned by fits better too
you return from a function, and have a thing returned from a function
the api returns a thing, the thing has been returned by the api
sleek steppe
vale ibex
My two cents is that only reusable converters should be in there
If they're only used in one place, then they're better off in the same tower as the cog
sleek steppe
Well I'm pretty sure all lancebot's converters are only used in one place
vale ibex
Hmm, I think the destiction should be usable, rather than used
Eg a whitelist check or a duration converter makes sense to be a util
Whereas something specific to a cog should be with that cog
sleek steppe
The ones that I have in converters.py are WrappedMessageConverter, CoordinateConverter, SourceConverter, and DateConverter
vale ibex
Those names don't really tell me exactly what they do, but I'm willing to hear other people's opinions on this
I'd prefer only convertors that could reasonably be reused by another cog be in that utils folder
If those fit into that category then fine 😀
fallen patrol
`Pipfile` line 13
```Pipfile
"async-rediscache[fakeredis]" = "~=0.1.2"```
what's the source for this?
sleek steppe
async-rediscache#1
dusky shoreBOT
sleek steppe
cool
stable mountainBOT
setup.py lines 37 to 39
extras_require={
"fakeredis": ["fakeredis[lua]>=1.4.4"],
},```This is useful if you have dependencies that can add functionality, or something similar, but don't need them to always be available
fallen patrol
Python allows you to set optional dependencies for your modules
no not that
fallen patrol
async-rediscache#1
this, when its on seb's github
patent pivot
not sure I follow, Sebastiaan maintains async-rediscache
ah, you mean how is it detecting it?
fallen patrol
not sure I follow, Sebastiaan maintains async-rediscache
(the not needing the SebastiaanZ/ before the repo#issue)
sleek steppe
It was previously on python-discord so it redirects
vale ibex
@sleek steppe smh, commiting single quotes in a PR
that's a paddling 😂
Just found it funny since you have that spring clean pr lol
sleek steppe
<@!506618674921340958> smh, commiting single quotes in a PR
Which PR?
sleek steppe
I copied and pasted most of it lol
vale ibex
hah yea thought as much
sleek steppe
stable mountainBOT
bot/exts/evergreen/avatar_modification/avatar_modify.py lines 313 to 314
"""Load the PfpModify cog."""
bot.add_cog(AvatarModify(bot))```lul
that's on me
actually no, I blame @fervent sage for suggesting a better name
it's all vco's fault, yes, that's it
😄
sleek steppe
understandable
fervent sage
hahaha
sleek steppe
feel free to clean up my mistake in your PR if you like 😛
Already done lol
fervent sage
youre the one who stole it :P
vale ibex
vocal wolf
alright did anything get destroyed while I was asleep?
vocal wolf
Understandable, the day of reckoning is upon us.
Would you look at that, it's progress o' clock.
vocal wolf
noo!!
gritty wind
1566
thorny obsidian
:3c you're welcome. I'm very good at making issues and no contributions
vocal wolf
:3c you're welcome. I'm very good at making issues and no contributions
I thought issues count as contributions?
like the creation of them
thorny obsidian
Egh, to me "real" contributions are the PRs and Reviews
vocal wolf
ah
thorny obsidian
Which is also why you should vote no to the thing in the other channel regarding me 
thorny obsidian
haha, maybe after my finals
thorny obsidian
I'm currently watching my lectures at 2x speed to just even make a real attempt at catching up
vocal wolf
sounds like something that I'd do
short snow
<@!736234578745884682> In bot#1564, please make purgeban not take any argument f...
ok, willl do
vocal wolf
ty
short snow
ty
uhh one question, by taking no arguments for purge days, meaning, i just remove that argument?
and use 1?
dusky shoreBOT
short snow
arghh, the second i edit any line, it would cuz those flake errors
and if i reset it origin, it works perfectly
short snow
https://github.com/python-discord/sir-lancebot/pull/649 needs a quick approval
from core dev
we can reduce 3 prs down 🙃
all of them are short
balmy sparrow
testing 645 now
vale ibex
Done your suggestion @balmy sparrow 👍
green oriole
Nah, only the first three
balmy sparrow
oh makes sense
i thought the webhook hates me and selectively sent my stupidest nitpicks >.>
vale ibex
Haha, recently I had 3 of my webhooks fail
green oriole
Haha
vale ibex
!clos
sleek steppe
clos doesn't make sense
vale ibex
hmmm the command suggester doesn't catch it
sleek steppe
!clos
sleek steppe
You're just an admin 😛
vale ibex
So yea, since the bot already suggests the correct command, don't think its something we want to change
if not any(role.id in MODERATION_ROLES for role in ctx.author.roles):
yup, looks like mods don't get suggestions
sleek steppe
yeah that
green oriole
You should use off-topic though
sleek steppe
Isn't that a webhook
brazen charm
I'm not sure if that's something that's worth it, considering that markdown is commonly used in the threads and is used for quoting
balmy sparrow
@vco re: sir-lancebot#722 , what do you think about moving the ping command to the uptime command's file? that way the original author will also show up on the file on github
dusky shoreBOT
fallen patrol
wow smh @fervent sage linting errors
fervent sage
I'm gonna be totally honest, i really dont appreciate how you're talking to me like that, it seems very aggressive
fallen patrol
no, sorry, it was meant to be like a 😛
fervent sage
@vco re: sir-lancebot#722 , what do you think about moving the ping command to t...
ive already done the commit how would i do that?
fallen patrol
do the thing where commits get reversed and then recommit into that file
patent pivot
ive already done the commit how would i do that?
is the proposal to put it into the spring cleanup branch?
patent pivot
oh right, so swapping the order that was done?
fervent sage
im not totally sure what you mean?
currently there's a commit merging both cogs, but the suggestion is i merge them the other way
patent pivot
right yeah
so you need to undo the previous commit, make the changes and then force push a new commit
git reset HEAD~1 to go back a commit
then make changes
git commit ... to commit
and then git push --force to update the branch
fallen patrol
so you need to undo the previous commit, make the changes and then force push a ...
force push?
patent pivot
yes, you are altering history
fallen patrol
mind blowing
fervent sage
then there's another issue which is that i did it this way round specifically because it makes more sense for 'uptime' to be in ping than the other way around
patent pivot
because we undid the commit with HEAD~1, which is git sugar for HEAD take away 1 commit
sleek steppe
git reset HEAD^ 
fallen patrol
`git reset HEAD^` <:VeryCool:585580174750253057>
what does this do?
sleek steppe
same thing I think
clever wraith
and then `git push --force` to update the branch
Use the git push --force
fervent sage
that should be an otn: "use the git push force"
patent pivot
HEAD^ is short for HEAD^1 which seems to differ from HEAD~1 in which commit it selects
so you can do HEAD~ as well for ~1
clever wraith
`git reset HEAD^` <:VeryCool:585580174750253057>
Wouldn't you want to do --hard?
fervent sage
then there's another issue which is that i did it this way round specifically be...
on this, imo it makes more sense to add a comment saying "The uptime command is from <author>" so that the placement still makes sense, given there was thought that went into the ordering originally
cc @balmy sparrow
sleek steppe
Wouldn't you want to do --hard?
Depends on if you're trying to unstage changes or erase them
clever wraith
Ah true
balmy sparrow
on this, imo it makes more sense to add a comment saying "The uptime command is ...
Anything works, I don't have an issue with where the commands are obviously, the issue was only making sure the original author gets their due credit
fervent sage
Anything works, I don't have an issue with where the commands are obviously, the...
actually they arent on it anyway lol because of the folder rename from seasons to exts, so time to go commit hunting
balmy sparrow
oh oof
fervent sage
i tracked down the original commit and commented it in case anyone wanted to look 
dry folio
hey, i have a question regarding https://github.com/python-discord/sir-lancebot/issues/719... even tho it was approved that we add new categories to the quiz command, are we authorized to also change some stuff, fix some flaws and add some dynamic programming? our current code can be found at https://github.com/cat-dev-group/sir-lancebot
vocal prairie
hey, i have a question regarding https://github.com/python-discord/sir-lancebot/...
Can you explain what exactly you mean by "dynamic? And which flaws you're referring to?
short snow
also remember, there is already a pr up on sir-lance which refactors this file, so have a look at it before doing stuff.
dry folio
Can you explain what exactly you mean by "dynamic? And which flaws you're referr...
not hardcoding. like how i did VARIATION_TOLERANCE = 83
dry folio
also remember, there is already a pr up on sir-lance which refactors this file, ...
really? which is that and who made it?
vocal prairie
not hardcoding. like how i did `VARIATION_TOLERANCE = 83`
I have no idea what that means. Can you give an example?
vocal prairie
I agree, the commit messages aren't great
gritty wind
These commits are seriously in violation of our guide
I will close the PR if these commits are left as is
dry folio
These commits are seriously in violation of our guide
do commits have to follow guide in the fork as well?
oh no
vocal prairie
Yes, since those commits get merged
dry folio
then i really fricked up, i don't know that
short snow
the commits on the fork, will be same as that on the pr
gritty wind
No, but are you going to rename all of them before PRing?
dry folio
No, but are you going to rename all of them before PRing?
yes, definitely
dry folio
No, but are you going to rename all of them before PRing?
if it violates the guidelines, i'll go back tomorrow and change everything lol
vocal prairie
Some of those aren't for Lance, are they?
dry folio
Some of those aren't for Lance, are they?
they all are-
dry folio
<https://github.com/python-discord/sir-lancebot/pull/618>
well this isn't merged yet, and we already started coding... oh no
i have this bad feeling
vocal prairie
they all are-
I suggest that you rename them now, and make sure to follow the guide in the future
dry folio
that all shit broke down
dry folio
I suggest that you rename them now, and make sure to follow the guide in the fut...
i can't, it's late here
vocal prairie
I didn't mean now now. But whenever you get the chance, it might be best to go back.
gritty wind
You don't have to do it immediately, but the sooner the better
Definitely before PRing
Alright, back to the question on hand
gritty wind
not hardcoding. like how i did `VARIATION_TOLERANCE = 83`
Defining constants like that is fine
dry folio
yay
vocal prairie
I'm still confused on this "dynamic" and these "flaws"
gritty wind
If the dynamic system refers to like switching numbers in math questions, that sounds cool as long as it works
dry folio
If the dynamic system refers to like switching numbers in math questions, that s...
yes, it works
dry folio
If the dynamic system refers to like switching numbers in math questions, that s...
also, regarding the https://github.com/python-discord/sir-lancebot/pull/618 pr, should we redo everything to make it fit with that?
vocal prairie
also, regarding the https://github.com/python-discord/sir-lancebot/pull/618 pr, ...
You could just wait until that gets approved, since it seems to be rather far along. But don't delete the code, some of it would definitely be useful.
dry folio
You could just wait until that gets approved, since it seems to be rather far al...
so i should just keep on going? knowing that it might all be for nothing?
vocal prairie
Maybe take a look at Jason's code, and then see how you can change the code you have right now to make it work. But don't set anything in stone yet, keep in mind that things can change as reviewing goes along.
Keep in mind that that's a maybe
gritty wind
With all the reviews and what not, that PR is definitely approaching the final stages, so let's not make any huge changes for now
This should probably be a different PR as well
You can open an issue for that sometime
dry folio
This should probably be a different PR as well
yes ofc, so should i wait for that pr to be approved first, and redo everything?
short snow
for now, just adding math and science questions shouldn't be a problem
you can do the "dynamic" part once it gets merged
in a separate pr like scaleios said
dry folio
in a separate pr like scaleios said
Yes of course, but I'd prefer just redoing the whole thing after your pr's approved, so i could do actual formal commits, implement the mutiple answers, etc. I'll just wait for now
I need to sleep now, i'll make an announcement and close the issue tmr
fallen patrol
I need to sleep now, i'll make an announcement and close the issue tmr
you shouldn't close the issue
just wait for the pr with the open issue
short snow
Yes of course, but I'd prefer just redoing the whole thing after your pr's appro...
that's totally up to you 😄
dry folio
just wait for the pr with the open issue
Oki
dry spoke
gritty wind
Hey, that's not really relevant to this channel. This channel is for pythondiscord projects.
Check out #editors-ides
short snow
totally forgot that voice bans have tests too
@gritty wind you haven't awaited action here, should i do that in this pr? or it was not done for some reason
gritty wind
Which tests?
short snow
shouldn't it be just action?
short snow
yeah, just saw that, got it
gritty wind
notice the lack of parentheses
import asyncio
async def test():
print("The function")
async def main():
print("Started main")
x = test()
print("called test, but didn't await")
await asyncio.sleep(2)
print("slept a bit, still nada. let's await the function now")
await x
print("done")
asyncio.run(main())
I can't explain async, so here's a POC that explains the concept
short snow
yeah i got that, didn't see the apply_infrac function
and in the test below that is was just action, but it was a callable of user.kick already, defined two lines about that
olive cloak
we can suggest new features for Sir Lancelot right?
what if you could train a model for english and general help just with this discord server?
short snow
introducing machine learning to sir lancebot is something we frowned upon from doing so.
it introduces unnecessary complexicity
and getting human help is much understandable than a bot talking to you
vocal wolf
what if you could train a model for english and general help just with this disc...
We've decided against the use of any type of machine learning for helping as it'd be a unpredictable black box, unfortunately.
Thank you for the idea, though.
olive cloak
ah fair enough, yeah i guess since it would pretty weird if the bot started swearing since it learned it before lol
fervent sage
i wouldnt mind automatic help messages for d.py
but i also have enough experience with ML and GPT-2 to realise what a horrific mess it can turn into lol
short snow
lol
olive cloak
lmao, really wanted to learn C++ i guess
vocal wolf
lol
patent pivot
The exclusion from ML from lancebot or most of our projects isn't because it's risky at all, AI/ML is certainly battle tested. The reason is that it comes with several large dependencies, requires a lot of compute to train and is a big thing to maintain in an area which we don't have many folks familiar with
short snow
whoops
cold island
lol no worries
short snow
for some reason whenever i specify co author, the github actions runs twice
dry folio
hey, i have a question:
my lack of experience caused me to write some pretty informal commit messages in one of the forks i was supposed to pr to sir lancebot. however, i've decided to abandon that fork and start over since the structure of the program i'm supposed to modify will soon change completely, rendering my code incompatible. when i open a new fork, i don't need to worry about my last fork, right? so i wouldn't have to re-write the 40 commit messages if i open a new fork after the code changes?
this is the kind of msgs im talking about lol
cold island
hey, i have a question:
my lack of experience caused me to write some pretty inf...
a fork is your own version of the repository. You can do with it whatever you want, and delete it as well.
fallen patrol
If you delete the fork, you aren't going to have the commits as well.
A different solution would just be to create a new branch from upstream:main
you don't need to delete it.
cold island
If you didn't open a PR yet, you can also force push changes
and it'll override your git history
dry folio
a fork is your own version of the repository. You can do with it whatever you wa...
alright, i'm going to start over then
sleek steppe
Yeah you could just reset (soft) to the first commit and force push it
dry folio
Yeah you could just reset (soft) to the first commit and force push it
no but it's not just that, the thing is i'm working on adding tons of stuff to .quiz command, but the literal structure of the file is undergoing a huge change so i gotta start over anyways lol
ten hours of hard work, poof
sleek steppe
If you aren't on main you could delete the branch
dry folio
If you aren't on main you could delete the branch
i'd prefer starting over with a new fork
cold island
ten hours of hard work, *poof*
where is that change?
If someone is restructuring the file, it might be better to merge your changes first
Although those commit message are indeed not great
dry folio
where is that change?
https://github.com/cat-dev-group/sir-lancebot/blob/main/bot/exts/evergreen/trivia_quiz.py here and here https://github.com/cat-dev-group/sir-lancebot/blob/main/bot/resources/evergreen/trivia_quiz.json, but no one's gonna accept that with those commit msgs... should i go rewrite them all? it'll only take like 2 hours and then i can send a pr...
dry folio
If someone is restructuring the file, it might be better to merge your changes f...
really? but then their change would have to adapt to my changes lol
green oriole
If you really want to rewrite your commit history, using rebase is a way better choice
cold island
Yes, someone will have to adapt either way, but I'm not sure that you having to adapt is the better choice here.
dry folio
If you really want to rewrite your commit history, using rebase is a way better ...
rebase?
dry folio
Yes, someone will have to adapt either way, but I'm not sure that you having to ...
:D i see a last strand of hope
green oriole
Rebase is basically an interactive tool allowing you to rwrite your git history, like squashing two commits into one and changing the messages
cold island
Either way, conflicts like that should be brought forward before deciding to abandon your work.
dry folio
Rebase is basically an interactive tool allowing you to rwrite your git history,...
ok, so how do i install rebase?
green oriole
It is part of git itself
dry folio
Either way, conflicts like that should be brought forward before deciding to aba...
yes yes, i'll get to work with rebase and see if i can make it better
dry folio
It is part of git itself
oh-
cold island
Before that, where is the structure change?
dry folio
Before that, where is the structure change?
balmy sparrow
https://why.life-is-pa.in/5YD2no can we rename projects? (to update to Sir Lancebot now)
cold island
https://github.com/python-discord/sir-lancebot/pull/618/
I think you should proceed with development as usual, as it mainly splits the file into several. Whichever PR is merged first, it should be fairly simple to adjust the other.
dry folio
I think you should proceed with development as usual, as it mainly splits the fi...
alright! thanks a lot! also, is it valid if i do a new fork, and put all my 40 commits into 6 or 7 logical big commits (like i have a completed copy, all i have to do is to copy it onto the github file)?
because 40 commits to rewrite is a little... too much lol
cold island
Whatever is convenient for you. As long as the changes in each commit tell the same story (described in the commit message) it works.
dry folio
Whatever is convenient for you. As long as the changes in each commit tell the s...
ofc! it will be way more detailed and formal than the little pieces right now
:D
cold island
Small commits are fine fwiw
dry folio
Small commits are fine fwiw
yes, but then i'll have to rewrite all the small commits lol
cold island
But I usually opt for several big ones when I'm writing a feature
dry folio
anyways, i'll get to work!
dry folio
But I usually opt for several big ones when I'm writing a feature
alright! thanks a lot!!! i abandonned this yesterday but i'm restarting today lol :D
eager fable
@dry folio I liked your previous nickname "Wait... It's all objects?"
It was a good one
dry folio
It was a good one
yes, i like it too
dry folio
But I usually opt for several big ones when I'm writing a feature
how would i write this part? i don't have a relevant issue
dusky shoreBOT
sleek steppe
Sure
fallen patrol
I mean
sleek steppe
What is it then
dry folio
That isn't even a commit message
the commit message is "Add 30 math questions and 30 science questions to trivia_quiz.json"
fallen patrol
What is it then
Pr or comment
dry folio
i mean, it's better than "sciency stuff" lmao
sleek steppe
Pr or comment
He is talking about
fallen patrol
Oh
cold island
@short snow why did you resolve https://github.com/python-discord/bot/pull/1446/files#r627739424? 🤔
sleek steppe
This one? It isn't resolved
cold island
I unresolved it
sleek steppe
Ah ok
balmy sparrow
sir-lancebot#716 can be merged btw
dusky shoreBOT
vale ibex
grrr j9 beat me to it lol
sleek steppe
Was gonna ping you to merge lol
missing a not broke the .mosaic command so I'll make a PR to fix it lol
green oriole
Well, it isn’t working
balmy sparrow
missed a not there that's my bad
green oriole
.mosaic 5
dusky shoreBOT
thorny obsidian
!ext unload mosaic
stable mountainBOT
:x: Could not find the extension mosaic.
balmy sparrow
yeah, the condition got reversed because i missed a not by the looks of it
fallen patrol
.mosaic -5
green oriole
Aha
vocal prairie
.mosaic 20000 works
green oriole
can you send a PR in ?
vocal prairie
Just not anything below 10,000
balmy sparrow
toxic's on it
thorny obsidian
Reminder that all commits should be tested in a PR before approval is given.
sleek steppe
I tested it but it wasn't broken for me 🤔
fallen patrol
Just not anything below 10,000
ngl 20k seems very nice
balmy sparrow
yeah my bad, was careless
green oriole
We want to avoid user image inputs as much as possible
sleek steppe
yeah my bad, was careless
It's both of our faults because I forgot to pull when testing it
green oriole
Yes but it is moderated discord wide
vale ibex
#476196547324018688 if anyone with access wants to test the hotfix
sleek steppe
You guys saw nothing 
cold island
@sleek steppe those .mosaic subtitles are 👌
thorny obsidian
@sleek steppe lots of people having fun with the command in #sir-lancebot-playground
deft patrol
great because it starts from one person and then everyone tests it 😄
vale ibex
heh it's fun trying to spot it in the usage
thorny obsidian
@balmy sparrow gooood call on if it isn't a perfect square you get the next nearest, makes the command much more fun to use
balmy sparrow
ahh thanks :D
sleek steppe
I feel so proud of that math there 
||Definitely didn't copy it ||
balmy sparrow
although i'm still so embarrassed about that condition
thorny obsidian
haha, it's fiiiine
patent pivot
lol wait is that gonna trip the resource limits i wonder
keeping my eye on #dev-ops-notifications
sleek steppe
Doesn't the max_workers=1 allow 1 concurrent image command at a time
vocal prairie
@vale ibex It's that Lance isn't receiving the USER_UPDATE event
vale ibex
yea, I thought fetch_member deals with that, since it's an API request
rather than going through the cache
clever wraith
I see a bee there.
vocal prairie
fervent sage
discord.py does something it technically shouldnt, which is make people think that members have things like id, avatar, etc
vale ibex
ahhh, so the cache is appending the member extras to the fetch_user call?
fervent sage
discord doesnt necessarily send you the member's internal user object tho
clever wraith
I thought why I was blocked by api discord... But in fact it turned out to be repl.it... Helped kill 1
fervent sage
so the member's user field is filling from cache
vale ibex
hmmm
sleek steppe
It doesn't update it?
fervent sage
fetch_user should work
vale ibex
lemme see if we use anything attribs of the member obj
We use member.display_name
but IG we can just change that to use ctx.member
rather than the fetched user
I'll make the changes and spin up a bot in the test server
fervent sage
discord doesnt necessarily send you the member's internal user object tho
actually im wrong on this, however discord.py doesnt seem to update cached users from fetch_member, and then populates the member's user details by getting from the (non updated) user cache...
???
sleek steppe
but IG we can just change that to use ctx.member
You mean author right
vale ibex
ye, that 1
merry ember
Hi, if I have an idea for an "experimental" feature that would be "fun to try", do I submit an issue to sir-lancebot or how do I discuss the possibility of a contribution?
fervent sage
you can submit an issue yeah, though we can likely tell you here if its the sort of thing that fits lance
stable mountainBOT
discord/member.py line 220
self._user = state.store_user(data['user'])```(after which you can create an issue :P)
merry ember
:)
I thought og lance since I'm a beginner at contributing but it's possible that the feature is more of a utility than "fun".
Basically I want a way to keep track of the help channels I've interacted with in the last x minutes/hour. It may only be an issue for me but I've "lost" several discussions because I forgot which channels I participated in.
sleek steppe
I could see if fetch_user makes a difference
vale ibex
I'm working on it now
i've got it implemented on 8bitify if anyone with access wants to play
thorny obsidian
Basically I want a way to keep track of the help channels I've interacted with i...
something like this: https://github.com/python-discord/bot/issues/1567?
?
merry ember
That sounds about it!
fallen patrol
<#476196547324018688>
#null
fervent sage
Basically I want a way to keep track of the help channels I've interacted with i...
thats been discussed, and i think the tl;dr was along the lines of "for the few people who actually knew about the command and could benefit from it they may as well use discord's search bar instead"
thorny obsidian
Yeah, having an easier way to narrow down where you've been helping recently is something that's been requested
We're discussing it and possible other solutions at our staff meeting this Sunday
merry ember
Can I search in just help channels? It would be neat If iI could get a list and a link to my newest post but that may be a nice to have.
Oh sweet, so then it's not only me. :)
thorny obsidian
Yeah, discord's search isn't really robust enough if you channel hop enough and have longer convos elsewhere
merry ember
Could one request a bot to simply at one whenever something is said in the same conversation?
Or DM as I guess the issue was about, sorry, haven't looked through it yet.
thorny obsidian
so, let me grab some screenshots of some of the other proposals
Those are the other 3 suggestions, each with their pros and cons
merry ember
Wow, it's indeed not only a "me" problem, good to hear, and some great suggestions.
thorny obsidian
yeah, definitely not only a you problem~
fervent sage
without actually reading the content that sounds really funny to intentionally ghost ping people
sleek steppe
lol it's a definite no
sleek steppe
A new helper wouldn't understand the ghost ping
thorny obsidian
All of these are still on the table so-to-speak. Will be a topic of discussion this Sunday and following days.
fervent sage
tho i'd rather the ping stays until i click a reaction on it to yeet it, on second thoughts
vocal prairie
That could be confusing to the claimer
merry ember
That's awesome, thank you for the info, happy to see that things are being done. :)
thorny obsidian
That's awesome, thank you for the info, happy to see that things are being done....
yeah, thanks for recommending a suggestion too! We value that kind of feedback
merry ember
Well, I'll just have to think of some other "fun" feature then. ^^
@thorny obsidian Sorry if I'm being slow but what did I do that was good? 😬
fervent sage
suggesting new things is good, it helps the community evolve and get better for everyone :P
thorny obsidian
come to this channel and make a suggestion!
merry ember
Aah! Got it, thanks. :)
thorny obsidian
It's something I value, if members of the community feel comfortable enough to suggest improvements that's typically a good sign
merry ember
I mean, I was nervous about it, because well, new experience. But the contribution guidelines feel very friendly so decided to give it a go.
thorny obsidian
I mean, I was nervous about it, because well, new experience. But the contributi...
yay! That's good to know
merry ember
It basically says don't hesitate to ask, so then I banked on people actually expecting questions. :)
So yeah, good work with those.
fervent sage
step 1: get a large guild
vale ibex
use a command, change your pfp and then use the same command
short snow
<@!736234578745884682> why did you resolve <https://github.com/python-discord/bo...
Um, I think I implemented that, will have a look,
vale ibex
make sure you don't have member intent enabled
peeps in the test server feel free to use my bot, ill leave it on
fervent sage
chriiiiisssss :)
crashfile-detector#1
dusky shoreBOT
fervent sage
:P
vale ibex
hah it's a bit pointless now though
short snow
New project 👀
short snow
I am late, it started 4 days ago 
fervent sage
hasnt been fixed downstream yet™️
short snow
We didn’t change the mosaic command 😔
balmy sparrow
what's this referring to?
balmy sparrow
about the color?
balmy sparrow
same, blue looked good
thorny obsidian
The color of the embed is not critical and fine. Changes requested should be made with more reasoning than "I don't like the color"
short snow
I was saying it to use the same colour as 8bit
And yeah it was a very optional one, got no comment, so thought it got skipped
sleek steppe
well*
dusky shoreBOT
fallen patrol
got it
fallen patrol
hah it's a bit pointless now though
actually not really honestly
its happened multiple times
vale ibex
see my comments after that message
the bug that caused it has been fixed in chromium now, and will be backported into Discord soon
fallen patrol
I did
vale ibex
so we won't need something like this
vale ibex
nah, we're still not certain if we want to include it in our infra
so it's not really something we're actually working on
fallen patrol
another thing about it
vale ibex
more of a proof of concept
fallen patrol
yeah
just that
nothing more
since it should use head unless that doens't work then it should get
because a smart person could skip this by not implementing head requests
fallen patrol
idc you can make an endpoint that blocks head requests
which means that it wouldn't work
patent pivot
again, PoC lol
vale ibex
Yea, and exactly what we'd do in that circumstance is unknown
like we could block by default
sleek steppe
I'm gonna fix some merge conflicts on spring-cleanup now 😔
patent pivot
this is based on a gist that I wrote recently and we've stuck it in a fastapi app, we're going to talk about how/whether we're going to use it in a staff meeting at some point
sleek steppe
Oh I'm surprised there's only one conflict
vale ibex
fervent sage
huh nice
patent pivot
patent pivot
lmfao
sleek steppe
Do we only use """ for multiline docstrings?
thorny obsidian
probs not if I had to guess
sleek steppe
Because shivanth commented here https://github.com/python-discord/sir-lancebot/pull/718#pullrequestreview-652970218 and I'm guessing I should just leave the '''
patent pivot
interesting
dusky shoreBOT
dry folio
sir-lancebot#726?
yes exactly!!
patent pivot
dry folio
the last one took 2 mins, this one was after i merged the new updates into this branch (sorry i didn't specify that)
patent pivot
interesting
dry folio
https://github.com/python-discord/sir-lancebot/pull/726/checks?sha=c742604f31009...
yes this one! @patent pivot
patent pivot
yeah
sleek steppe
image = next(
(
url for url in data["image_list"]
if url.endswith(self.valid_image_extensions)
), emoji
)
Does this look fine lol
vale ibex
It shouldn't happen often, since the cache is normally used
dry folio
It shouldn't happen often, since the cache is normally used
alright, thanks!
either way, i fixed all the lint errors and so the pr is ready for review :D
sleek steppe
The ones on bot take longer than that lol because of the tests an generating coverage reports
vale ibex
_iter = (
url
for url in data["image_list"]
if url.endswith(self.valid_image_extensions)
)
image = next(_iter, emoji)
hmmm
not sure which looks better
sleek steppe
I'll use that one, thanks
fallen patrol
```py
_iter = (
url
for url in data["image_list"]
if url.endswith(se...
wait this is valid code?
vale ibex
What makes you think it isn't?
patent pivot
lol
cold island
```py
_iter = (
url
for url in data["image_list"]
if url.endswith(se...
this one looks better
vale ibex
I'm genuinely curious, since I wrote that in discord's editor, so it could very well be wrong 😂
sleek steppe
Yeah I included it in my commit
merry ember
Hi, I got Sir Lancebot up and running locally and when I ran the .help command the "navigation" disappeared after a while so I didn't have time to read through all the pages. I just tested on the actual bot and it's the same. Is this the expected/necessary behaviour or is there room for improvement?
sleek steppe
It eventually times out and removes the reactions
vocal wolf
I think we can actually delete that, we're not really using it
what is it even tracking lol
oh, I see
yeah this isn't used at all
Closed project, we can always open it back up if need be
merry ember
Ah, I figured as much.
vocal wolf
although I don't think that will be necessary
patent pivot
cheers for the QoL fixes @clever wraith
clever wraith
Ay, was hesitant on the extensions one since it was pretty nitpicky although I wonder if i should've iust gone with !raw's approach of adding zero width characters instead of escaping all markdown
fallen patrol
Ay, was hesitant on the extensions one since it was pretty nitpicky although I w...
what command did it edit?
fervent sage
bot#1571 and bot#1572
dusky shoreBOT
clever wraith
The first one, yeah
sleek steppe
Ay, was hesitant on the extensions one since it was pretty nitpicky although I w...
Any markdown would affect it, wouldn't it?
short snow
<@!736234578745884682> why did you resolve <https://github.com/python-discord/bo...
I had implemented that locally, but there was still a small bug in it: #dev-contrib message
green oriole
Honestly I think I have 20 tests failing locally but not inside the CI, sooooo
cold island
I had implemented that locally, but there was still a small bug in it: https://c...
Ok, but please push changes before marking as resolved 😄
I can't see the changes you make locally
short snow
Ok, but please push changes before marking as resolved 😄
ah ok, i used to mark changes as done, when i finish them locally, would remember that next time.
do you know why that test fails tho, the link i had linked in the above msg, i do convert it to str, but doesn't get converted for some reason
short snow
that's what is followed in all tests of incidents, so i followed the pattern it is not needed, dunno how it got added into mine
cold island
I'm genuinely asking, I suck at unittests
cold island
ah ok, i used to mark changes as done, when i finish them locally, would remembe...
Also, if you can't push the changes because you have a bug, then you're not really done.
@green oriole can you explain to me the downside of using channel.history in your PR? it just seems much simpler and cleaner
We have like a max 10 messages in that channel anyway
green oriole
Well I just avoid fetching one too many message
Manually breaking would just add more code
cold island
Add? Not really. You'll ditch the suppress and the multi-line next
green oriole
That's almost the same idea as doing it manually
short snow
one second, messed up commits, will fix it
cold island
It's the same idea, it's just less readable
green oriole
Is it less readable? I could add a more in-depth comment
short snow
ok, should be fixed now zig, also i think you forgot to reply on https://github.com/python-discord/bot/pull/1446#discussion_r624363552
akarys here, https://github.com/python-discord/bot/pull/1446/files#r615390833, should i check for webhook is None, directly after the fetch line? and log level should be error?
cold island
Is it less readable? I could add a more in-depth comment
I think
async for new_message in message.channel.history(before=message.created_at):
if messages[-1].created_at - new_message.created_at > timedelta(seconds=2):
break
messages.append(new_message)
Looks much clearer than:
with contextlib.suppress(NoMoreItems):
while True:
new_message = await message.channel.history( # noqa: B305 - yes flake8, .next() is a thing here.
before=messages[-1].created_at,
after=messages[-1].created_at - timedelta(seconds=2)
).next()
messages.append(new_message)
This combination of suppress, infinite loop, and creating an iterator in a loop for a single next just seems like a code smell tbh
Especially when an async for is an adequate replacement
green oriole
I think
```py
async for new_message in message.channel.history(before=message.cr...
It will break if it reaches the end of the channel though
cold island
It will break if it reaches the end of the channel though
how will it break?
green oriole
If there is no message I'm pretty sure it, I'll raise NoMoreItems
cold island
Shouldn't that just stop the loop? like StopIteration stops a for loop
Wait no
That's not what history does
it'll just return an empty set of messages and the loop will end pretty sure
cold island
tnx
merry ember
Hi, I'm setting up my test server to work with bot (already have invited and successfully ran sir-lancebot) and am struggling with the configs. I don't fully understand which channels, categories etc my server needs. Can someone post a screenshot of their working test server or is there some other way I can get "confirmation" that I've got the things set up right?
vocal prairie
Hi, I'm setting up my test server to work with bot (already have invited and suc...
Are you trying to set up Lancebot or Python?
And the guides on this page explain everything you need to do: https://pythondiscord.com/pages/contributing/
merry ember
@vocal prairie Python, Lancebot already works. I'm in the middle of setting up Python and find the setup somewhat challenging.
vocal prairie
In your config.yml, change these sections
style.emojis
guild.categories
guild.channels
guild.roles
guild.webhooks
sleek steppe
Did you use the template?
vocal prairie
discord.new/zmHtscpYN9E3 is the template that helps
merry ember
I've been trying to get the template but didn't catch the part where it opens in Discord. I've just been forwarded to discord.com/channels/@me in the browser. In my defence I'm on a 14" laptop and everything is a bit of a mess... 😬
Well then, that worked, thank you!
vocal prairie
👍
merry ember
A few more issues; There are two "video" roles (green and grey) in the template, which id do I add to configs and does it matter? I can't find roles for project_leads and domain_leads. Do I create these and are there some specific permissions etc these need?
gritty wind
You don’t need to add everything in the config
Follow the guide on the website as it has all the sections you need
merry ember
That’s a relief 🙃
gritty wind
If in doubt, guess
merry ember
I’ve been doing that though, and it says to look in config for the sections to set up
How do I deal with webhooks? Can I ignore them in config or should I create them and guess the channel they should post in?
gritty wind
You don’t need to create anything if you use the template
Everything is created for you
The only thing you need to manually add is the trash can emoji
merry ember
Ok, there are no webhooks in my server using the template so I just ignore those in config?
vale ibex
Yea, my dotenv just looks like this ```
BOT_TOKEN=
BOT_GUILD=476190141161930753
USE_FAKEREDIS=true
REDIS_HOST=redis
BOT_DEBUG=true
PREFIX=&
AOC_ROLE_ID=651730380898041862
BOT_ADMIN_ROLE_ID=476190234653229056
LOVEFEST_ROLE_ID=795910065424171028
ROLE_HELPERS=476190429960732672
AOC_CHANNEL_ID=476190141161930755
AOC_COMMANDS_CHANNEL_ID=476196062214750219
CHANNEL_ANNOUNCEMENTS=476196024512413698
CHANNEL_COMMUNITY_BOT_COMMANDS=476196062214750219
CHANNEL_DEVLOG=476196115432210443
This is for @stable mountain
gritty wind
This is strange because my server definitely had the webhooks
Anyways, skip them for now, add them later if the bot doesn't start
merry ember
I’m just not very good at this. 😬
sleek steppe
It can start without it
merry ember
But I got Lancebot up and running, yay. 🙃
This is indeed a more intermediate levelled challenge.
short snow
Everything is created for you
We hooks aren’t, you need to make them
merry ember
How do I know which channel they post in, or do I just guess?
short snow
Post what?
merry ember
Webhooks post in a specific channel?
gritty wind
The channel doesn't matter, and the bot starts fine without them. You can add the IDs as you need them
merry ember
Excellent, thank you!
short snow
Are u setting up bot and Lance?
merry ember
Yes, that’s the plan.
short snow
Oh ok, running with docker or pipenv?
merry ember
Haven’t used Docker yet, just installed it but got Lance running with pipenv.
I’m on Unbutu 20.4 via WSL2
short snow
Yeah Lance is pretty simple to run, bot is where the challenge comes 🙃
merry ember
Mmhm
short snow
That OS doesn’t matter, until u are on windows
merry ember
Haha, I mean, I am on Windows but not more than I can help. :)
vocal prairie
Docker is easier for bot imo
Since bot has a database and stuff, that can be hard to set up
short snow
But, slower and more resource taking, in my case
merry ember
That’s what I started to realise, hence my downloading Docker desktop.
vocal prairie
It works well enough on my 4 gig ram computer
merry ember
Wow
short snow
I run site with pipenv and then run bot with pipenv, so works well
Yeah same, 4 gig ram here
merry ember
I haven’t started to look at site yet, maybe I should? Do I need it for running the bot? I just updated my hosts file but am still in the config step. Haven’t attempted to run yet.
gritty wind
You need it running, but you can use the docker compose for that
short snow
Yeah, site contains the api, which is needed for the bot
There are plans to separate tho, and it is a work in progress
merry ember
Oh, definitely Docker then...
short snow
I run it normally without docker, never went through a problem
patent pivot
It's no problem to run locally, but docker is certainly simpler considering it provisions postgres
Also if you want to be pedantic it's closer to the production environment
merry ember
I’m rather new to Docker so this should be an excellent opportunity to get familiar with it.
patent pivot
💪
merry ember
So technically, if I use Docker, I only need the BOT_TOKEN in .env?
gritty wind
Yeah BOT_TOKEN
and the site token
BOT_API_KEY=badbot13m0n8f570f942013fc818f234916ca531
merry ember
But that’s set by Docker?
gritty wind
It is set in the docker-compose
But I assumed you are running the site using docker, and the app using pipenv
vocal prairie
It is set in the docker-compose
It is? Nice
gritty wind
I do something similar so I can use my IDE's debugger
short snow
If u run with or without it, u only need token and bot api key
gritty wind
api key is set in the docker-compose, so if you do a full docker-compose setup, you technically only need the token
merry ember
That was probably what I meant. :)
dry folio
`BOT_API_KEY=badbot13m0n8f570f942013fc818f234916ca531`
incredible token
placid ermine
incredible token
vocal prairie
The forms frontend is really nice.
Whoever worked on that, you did a wonderful job!
patent pivot
hmmm @vale ibex what does local dev of the metabase cog look like
if not configured will this just error out when the DNS lookup fails?
vale ibex
I've made it so that it you don't give the username and pass env var, the cog won't load
If you give them, but don't change the url, then it'll error out on dns ye
patent pivot
ahhh I missed that
patent pivot
@vale ibex 
vale ibex
Oh yea lol
That was so that the link wasn't sent in the test server
Didn't want to leak anything
Probs should have removed / mentioned that lol
patent pivot
lmfao
fallen patrol
<@!126811506632294400> <:thonk:420721659406974977>
What is this lol
patent pivot
from bot#1573
dusky shoreBOT
clever wraith
for .mosaic, i think a cool parameter is to mosaic other peoples avatars
.mosaic <number of squares> <optional user tag>
short snow
We need to bump license year of bot
brazen charm
It was already discussed and deemed unnecessary
short snow
because?
brazen charm
short snow
ahh okay, thanks
green oriole
This is an obscure PR bot#1573 
what does it even do? Does it just upload the data from metabase to a pastebin ?
dusky shoreBOT
short snow
https://github.com/python-discord/sir-lancebot/pull/583#discussion_r627074804 could some staff un resolve this comment
green oriole
Done
deft patrol
Noice 😀
merry ember
Hi, I’m trying to run Python bot with Docker on WSL2 Ubuntu but can’t connect to Redis. I’ve used both use_fakeredis=true and USE_FAKEREDIS=true in .env with the same result.
bot_1 | for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
bot_1 | socket.gaierror: [Errno -2] Name or service not known
bot_1 | 2021-05-09 14:01:43 | bot | CRITICAL | Could not connect to Redis. Is it running?```Yeah, I came across that problem too when I set it up, could u share your config?
merry ember
Just a sec
So I just changed use_fakeredis to true in config.yml and have a new issue instead, yay.
redis:
host: "redis.default.svc.cluster.local"
password: !ENV "REDIS_PASSWORD"
port: 6379
use_fakeredis: true
``` Or do you need to see the whole config file?Ah, because that's my new issue, now it can't connect to the site API.
short snow
what's the schema set to?
merry ember
2021-05-09 15:31:29 | bot | CRITICAL | Could not connect to site API. Is it running?```
```yml
urls:
# PyDis site vars
connect_max_retries: 3
connect_cooldown: 5
site: &DOMAIN "pythondiscord.local"
site_api: &API "api.pythondiscord.local"
site_api_schema: "http://"
site_paste: &PASTE !JOIN ["paste.", *DOMAIN]
site_schema: &SCHEMA "http://"
site_staff: &STAFF !JOIN ["staff.", *DOMAIN]
paste_service: !JOIN [*SCHEMA, *PASTE, "/{key}"]
site_logs_view: !JOIN [*SCHEMA, *STAFF, "/bot/logs"]
# Snekbox
snekbox_eval_api: "http://snekbox.default.svc.cluster.local/eval"
# Discord API URLs
discord_api: &DISCORD_API "https://discordapp.com/api/v7/"
discord_invite_api: !JOIN [*DISCORD_API, "invites"]
# Misc URLsw
bot_avatar: "https://raw.githubusercontent.com/python-discord/branding/main/logos/logo_circle/logo_circle.png"
github_bot_repo: "https://github.com/python-discord/bot"
It should be web:8000 for docker iirc
and api.web:8000 for api
See the contribution guide on site
merry ember
I've been doing nothing but looking at that for two days but I started out without Docker so I guess I forgot to change again once I decided to use it.
short snow
Ah ok 👍
merry ember
Thank you for pointing that out, here we go again...
OMG thank you!
It finally connected, I was so close but had forgotten about changing config for Docker... Really appreciate the help.
short snow
No problem 
merry ember
Wow I'm silly, it even says to change it in the config file, I guess I went for .env since it's in the environment variables section, just like the guide for Lance.
Now there's an issue with running tests - all but one fail. I guess this is because I'm using Docker? Do I need to run locally to run tests?
I did read and follow the instructions of the test guide: https://github.com/python-discord/bot/blob/main/tests/README.md#tools
brazen charm
I believe I also had a test failing locally previously, you can just ignore it if it's not related to the code you're wowrking with
merry ember
I've yet to get to working on some code, getting it up and running has been an adventure on its own. But that feels comforting, I guess I can try and "do something" and see if I can get a test to pass.
brazen charm
I didn't really look into why it didn't work
merry ember
@brazen charm Did you too run the bot in Docker?
brazen charm
No, I run it directly
merry ember
Ah, so then it's not necessarily a Docker issue.
vale ibex
Congrats @fervent sage ! 😄
fervent sage
vocal prairie
Congrats @fervent sage!
sleek steppe
Welcome to the green team! 
short snow
Congrats @sleek steppe @fervent sage
fervent sage
Welcome to the green team! <:shipit:826492371813400637>
welcome to the yellow team too 
short snow
Ah, so then it's not necessarily a Docker issue.
Which test is failing, and tests don’t depend on docker, so it’s the reason it fails
stable mountainBOT
Hey @merry ember!
merry ember
@short snow https://paste.pythondiscord.com/itesotewot.less
merry ember
That was just to get the names of the failing tests but I'll run again. 👍
short snow
Yeah, I wanted the details
merry ember
Oh, i asked if you wanted the trace backs in the first message but think it got lost since I couldn't post it..
Do you want the trace backs for a new run?
gritty wind
try changing the perms of the log folder
short snow
sudo rm -r logs/ && mkdir logs && touch logs/bot.log seems to fix this
Stel had the same issue earlier
Had used this and it had fixed it
short snow
Lol go on..
merry ember
short snow
You can ignore that
merry ember
Woho
Wow, I never thought I would get stuff to work.
And this is just on the PC, I have a Mac too... 🙃
short snow
Lol, it is indeed bumpy, once u get into contributing to bot, I am sure u will switch to pipenv
Just do the same steps, will work out
merry ember
I think for now this will be my dedicated bot machine..
Is it preferable to run with pipenv? I was afraid to use Docker but now I'm more afraid to set it up with pipenv.
merry ember
It works with Docker, finally, I was just wondering whether I should try to get it to work with pipenv too.
vocal prairie
Why use pipenv if you can use Docker?
merry ember
I don't know, that's my question... I think @short snow hinted that that would be a good thing to do.
fervent sage
because docker comes with more overhead and slower restarts
vocal prairie
But that's not that bad
merry ember
Personally I would prefer to run it locally, feels like I have more control, but given that I don't know what I'm doing, Docker is fine.
gritty wind
I run locally because it allows me to run through my IDE, and my debugger
But do whatever works for you
short snow
Why use pipenv if you can use Docker?
Docker is used for production environment and not really useful when u are developing
vocal prairie
True
It's better for prod unless you set it up with a multi-stage dockerfile. Then it's better (at least for my personal projects)
short snow
Running two pipenv run start (site and bot) is faster than running docker, imo
gritty wind
You may have special circumstances, but most people I've helped set up the bot, and me, have the containers up in seconds
You don't have to convince anyone though
Ultimately, it comes down to preference
short snow
Umm, it is up in seconds, but I still feel pipenv is faster, yeah personal preference
gritty wind
As long as your code is fine, no one cares how you run
vocal prairie
There's a planned migration to poetry for Lancebot, right?
short snow
Yeah
gritty wind
There's already a PR opened for it
The reason it's pending is it's a 3.9 migration as well
that is waiting on one dependency
short snow
Joe
gritty wind
I've PRed the 3.9 dependency a couple days ago
it should be updated on pypi soon
Then I've got a PR ready for bot as well
short snow
Pr link?
gritty wind
short snow
Wonderful
merry ember
Just checking; From this I take it that I have to wait around for a new good first issue to become available? https://github.com/python-discord/bot/contribute
gritty wind
The good first issue are usually issues that are easier for getting started
but they aren't required
merry ember
I've been "doing" OS before, but not on a "real" project so am a little fuzzy on the procedure.
gritty wind
Have a look through this page
If you see an issue without the s: planning tag, and want to take it
Leave a comment
You'll get assigned if there are no problems
merry ember
Ah, without the Assignee?
short snow
Yep
merry ember
I mean an issue that isn't in planning and doesn't have an assignee?
gritty wind
If something is assigned, you could ask the author to collab on it, but that's up to them
yeah
merry ember
Ah
fervent sage
i lost my config file for bot
gritty wind
We have one on notion for the staff server
fervent sage
oh yeah the staff server exists i definitely rememberd that
gritty wind
personally don't use it for development
don't need everyone seeing how good a programmer I am
fervent sage
merry ember
How can I add the proper emojis to my test server?
merry ember
Ok
green oriole
Alright, it is working now
def partition_text(string: str, max_chars: int) -> List[str]:
"""Return partitions of string with less than max_chars characters."""
if len(string) == 0:
raise ValueError("String cannot be empty")
partitions = []
index = 0
done = False
while not done:
partition_start = index
while not done:
start_index = index
while True:
if index >= len(string):
done = True
break
if string[index] in BREAKABLE_CHARACTER:
index += 1
while string[index] in BREAKABLE_CHARACTER:
index += 1
break
index += 1
if index - start_index > max_chars:
raise ValueError(f"Word {string[start_index:index]!r} is larger than max_chars ({max_chars})")
if index - partition_start > max_chars:
index = start_index
break
partitions.append(string[partition_start:index])
return partitions
I guess once commented it shouldn't be that bad? It is probably more readable already
cold island
Eeeh, I'd like to try and get the current implementation to work first
so give me a bit
whole forge
3 nested while loops 
cold island
Yeah I'd rather exhaust other options before opting for this
whole forge
so whats the goal? just split a long string into a list of strings broken up on a break character?
green oriole
Commented version: https://paste.pythondiscord.com/oruzocohel.py
cold island
so whats the goal? just split a long string into a list of strings broken up on ...
basically textwrap.wrap
whole forge
hm, but what? if its basically that why not use that?
cold island
I'm not sure
whole forge
im guessing its the BREAKABLE_CHARACTER that makes it incompatible with wrap
green oriole
Gotta run
cold island
I'll give you an update if I figure something out
fervent sage
pain:
yaml.scanner.ScannerError: while scanning for the next token
found character '\t' that cannot start any token
in "config.yml", line 281, column 1
everything was going so well until it wasnt
fervent sage
ive updated it to be spaces on notion
merry ember
Hello again... Running bot tests goes splendidly, but it seems like the fix I did to run the tests now has broken running the bot...
ERROR: for bot Cannot start service bot: OCI runtime create failed: container_linux.go:367: starting container process caused: process_linux.go:495: container init caused: rootfs_linux.go:60: mounting "/run/desktop/mnt/host/wsl/docker-desktop-bind-mounts/Ubuntu-20.04/8925b0b7a1cb21fef2aea7d49c967f40547df4b488732886b5221703b6c28c1e" to rootfs at "/var/lib/docker/overlay2/030f3260f6d15a90093897c6ed603b98fdd514a97664f139cb4aad31f59da22c/merged/bot/logs" caused: no such file or directory: unknown
ERROR: Encountered errors while bringing up the project.```remove the container and rebuild it
merry ember
Will do
gritty wind
also do a volume prune
merry ember
A what?
gritty wind
it's a command
docker volume prune
It'll remove any unused volumes
do that after removing the container
merry ember
Thank you, both bot and tests run now. 🙏
merry ember
I've just started looking, I don't know if I'm ready considering the pain it was just to get the thing working...
I just added the trash can, got a bit side tracked and then noticed that the bot wouldn't run, again.
Yay, my trash can is working and I'm so happy. 🥲
fervent sage
:)
gritty wind
Ping doesn't work locally
vocal prairie
Nice bot name
gritty wind
I have an issue opened for that
fervent sage
ah
well the main point was to see if the bot was really alive which it thankfully is
cold island
@green oriole
At https://github.com/python-discord/bot/pull/1549/files#diff-6226fd47d9677af7c1a68077c7229358b3e0c4b9bae7c71e8ab61fda1530320bR146 you shouldn't join with an empty string. There should be a space by default, and a newline if the previous partition ended with a period.
At https://github.com/python-discord/bot/pull/1549/files#diff-6226fd47d9677af7c1a68077c7229358b3e0c4b9bae7c71e8ab61fda1530320bR179 try adding placeholder="".
This should deal with the formatting issues I've seen.
merry ember
How do I tell Lance the trash can emoji ID? Don't say I've missed this too in the instructions...
merry ember
I know, but where do I "set it"?
I works for bot, which is awesome, but I suspect Lance also needs to know about it.
gritty wind
TRASHCAN_EMOJI