#dev-contrib | Python | Page 101

short snow Apr 13, 2021, 4:56 PM

#

not sure, maybe ask ks, they are the code owner

sleek steppe Apr 13, 2021, 4:56 PM

#

I'll just leave it for now

short snow Apr 13, 2021, 4:57 PM

#

ok_handbutflipped .

sleek steppe Apr 13, 2021, 4:58 PM

#

    p_star_one = star_one / leaderboard["number_of_participants"]
ZeroDivisionError: division by zero

#

for .aoc stats command

short snow Apr 13, 2021, 4:59 PM

#

yeah, since there are no boards specified, so leaderboard is empty

thorny obsidian Apr 13, 2021, 4:59 PM

#

Seb would be the person to ask for AoC stuff

short snow Apr 13, 2021, 5:01 PM

#

#dev-log message @vale ibex is this because of too much jumping of files, i am thinking of moving helpers into games/cog i.e. the file where they are getting used

thorny obsidian Apr 13, 2021, 5:03 PM

#

In general you want to add some reasoning for why you're doing things. Like proper commit messages providing context and basic reasoning so people can follow the general logic and not guess at your intentions

short snow Apr 13, 2021, 5:04 PM

#

yeah understood

fallen patrol Apr 13, 2021, 5:06 PM

#

Hey, does lancebot work on arm?

vale ibex Apr 13, 2021, 5:06 PM

#

Yea, that's it. I don't mind having helper functions in other files, they can be very useful in larger cogs. But a lack of any comments explaining why you chose to do things in a certain way makes it difficult for reviews to follow your thought process

vale ibex Apr 13, 2021, 5:07 PM

#

fallen patrol Hey, does lancebot work on arm?

That'll depend on whether our dependencies work on arm

#

you may need to build wheels for a bunch of them when installing them

short snow Apr 13, 2021, 5:07 PM

#

yeah, (like kutie's commit descriptions on adding int e to sir lance)

I would document the code, and update the reasoning

vocal prairie Apr 13, 2021, 5:08 PM

#

You can see the commit description under the commit title in GitHub, right?

thorny obsidian Apr 13, 2021, 5:08 PM

#

short snow yeah understood

I'd also recommend doing that for reviews in general. Instead of saying "Make this a constant" with no other reasoning, it's helpful to add why you think things should be like that. It makes it easier on both sides for the review because the person submitting the PR knows your intentions and it cuts down on some of the clarifying back and forth

sleek steppe Apr 13, 2021, 5:09 PM

#

.status cat 418 works on python 3.9 now lol

short snow Apr 13, 2021, 5:09 PM

#

right, I would remember these points while reviewing/commiting next time

#

one problem with the investigate to py3.9 issue is:

new prs are getting merged quite frequently, so we need to mention the changes in those prs till the second our pr gets merged

sleek steppe Apr 13, 2021, 5:15 PM

#

Here's a tip for testing the .latex command: don't enable BOT_DEBUG

patent pivot Apr 13, 2021, 5:15 PM

#

yeah I haven't made it yet because we didn't need it in the end

#

we might add it in future but we needed to limit a certain service to helpers only but it turned out being fine without that for now

vale ibex Apr 13, 2021, 5:16 PM

#

sleek steppe Here's a tip for testing the .latex command: don't enable BOT_DEBUG

I added logging.getLogger("matplotlib").setLevel(logging.ERROR) to __init__.py in my pfp PR

#

we should probably cherry pick that if this PR doesn't get merged soon

green oriole Apr 13, 2021, 5:18 PM

#

fallen patrol Hey, does lancebot work on arm?

Not really, it is a bit hard to get running

placid ermine Apr 13, 2021, 5:18 PM

#

sleek steppe Here's a tip for testing the .latex command: don't enable BOT_DEBUG

wdym

fallen patrol Apr 13, 2021, 5:18 PM

#

green oriole Not really, it is a bit hard to get running

but its possible without code changes?

green oriole Apr 13, 2021, 5:19 PM

#

You can probably make sure that the deps are working

sharp timber Apr 13, 2021, 5:19 PM

#

gc.collect() is a bit of a hack, and triggers a global python GC. You're not supposed to ever have to do that. I would expect this to be cleaned up by reference counting, so if it's not then we should look into where we're making a reference cycle and deconstruct that better.

green oriole Apr 13, 2021, 5:19 PM

#

Probably not worth the effort though

sleek steppe Apr 13, 2021, 5:19 PM

#

placid ermine wdym

the first time I called it I got like a billion debug logs and it took forever

vale ibex Apr 13, 2021, 5:19 PM

#

See #dev-contrib message

sleek steppe Apr 13, 2021, 5:19 PM

#

yeah

patent pivot Apr 13, 2021, 5:19 PM

#

also worth noting this got a bit superseded by my CF access antics

fallen patrol Apr 13, 2021, 5:19 PM

#

green oriole You can probably make sure that the deps are working

have you done it?

patent pivot Apr 13, 2021, 5:20 PM

#

and the project we were going to protect doesn't need it

fallen patrol Apr 13, 2021, 5:20 PM

#

patent pivot also worth noting this got a bit superseded by my CF access antics

fwiw the more laughing thing is i've never seen a repo without anything in it

patent pivot Apr 13, 2021, 5:20 PM

#

lol

green oriole Apr 13, 2021, 5:20 PM

#

fallen patrol have you done it?

Yeah, it was a mess

patent pivot Apr 13, 2021, 5:21 PM

#

I'll probably private it

green oriole Apr 13, 2021, 5:21 PM

#

I had to make it run on the host

fallen patrol Apr 13, 2021, 5:21 PM

#

patent pivot I'll probably private it

:/ donnt

patent pivot Apr 13, 2021, 5:21 PM

#

doesn't need to be public

#

it has code locally I just haven't published it

green oriole Apr 13, 2021, 5:21 PM

#

Public gud

patent pivot Apr 13, 2021, 5:21 PM

#

lol

fallen patrol Apr 13, 2021, 5:21 PM

#

^

#

public > private

patent pivot Apr 13, 2021, 5:21 PM

#

when it does something I will

fallen patrol Apr 13, 2021, 5:21 PM

#

I don't trust a person with private repos

fervent sage Apr 13, 2021, 5:21 PM

#

fallen patrol public > private

it depends

sleek steppe Apr 13, 2021, 5:21 PM

#

private sus

patent pivot Apr 13, 2021, 5:21 PM

#

but right now it is, as you noted, empty

#

lol I have more private repos than public

fallen patrol Apr 13, 2021, 5:22 PM

#

fervent sage it depends

public keys > private keys

#

lol

#

remember when i once sent my private key to #deleted-channel

vocal prairie Apr 13, 2021, 5:22 PM

#

#deleted-channel?

short snow Apr 13, 2021, 5:22 PM

#

I have literally 0 private repositories

vocal prairie Apr 13, 2021, 5:23 PM

#

short snow I have literally 0 private repositories

Me neither

patent pivot Apr 13, 2021, 5:23 PM

#

Oh actually that project does have working code lol

#

Whoops

sleek steppe Apr 13, 2021, 5:24 PM

#

I'm looking at this for the pridefact command

Sendable = Union[commands.Context, discord.TextChannel]

When this could have been abc.Messageable 😩
Also .pridefact always sends Error parsing date: String does not contain a date: ct

fallen patrol Apr 13, 2021, 5:25 PM

#

vocal prairie #deleted-channel?

vocal prairie Apr 13, 2021, 5:25 PM

#

Lol

fallen patrol Apr 13, 2021, 5:25 PM

#

back when dm-log was a thing

#

HappyThink its gone now

short snow Apr 13, 2021, 5:26 PM

#

sleek steppe I'm looking at this for the pridefact command ```py Sendable = Union[commands.Co...

#sir-lancebot-playground message hmm

patent pivot Apr 13, 2021, 5:27 PM

#

yeah we removed dm log

fallen patrol Apr 13, 2021, 5:27 PM

#

it wasn't the best feature

#

i found out about it the hard way

patent pivot Apr 13, 2021, 5:29 PM

#

it's a balance

#

DM log proved useful a few times in weedling out DM invite spam before it hit many users

vocal prairie Apr 13, 2021, 5:29 PM

#

What did dm log even do?

#

Python's dms?

patent pivot Apr 13, 2021, 5:30 PM

#

but yeah users have become too accustomed to the belief that DMing bots doesn't go anywhere

patent pivot Apr 13, 2021, 5:30 PM

#

vocal prairie What did dm log even do?

Relayed bot DMs to a channel yeah

vocal prairie Apr 13, 2021, 5:30 PM

#

I sometimes dm bots links and stuff just to remember.

#

But now I use my own bot.

sharp timber Apr 13, 2021, 5:30 PM

#

I use my own bot

vocal prairie Apr 13, 2021, 5:30 PM

#

Since I don't want random people getting stuff.

fervent sage Apr 13, 2021, 5:30 PM

#

i use my alt

thorny obsidian Apr 13, 2021, 5:31 PM

#

One day discord will allow messaging yourself like Slack and all will be well

fallen patrol Apr 13, 2021, 5:31 PM

#

patent pivot but yeah users have become too accustomed to the belief that DMing bots doesn't ...

fwiw the actual thing is: users have become too accustomed to the belief that DMing bots isn't read by people who they talk to daily

vocal prairie Apr 13, 2021, 5:31 PM

#

Or you can make a group dm with no one in it besides yourself.

fervent sage Apr 13, 2021, 5:31 PM

#

dave is ignoring me tho

sleek steppe Apr 13, 2021, 5:31 PM

#

fervent sage i use my alt

same

sharp timber Apr 13, 2021, 5:31 PM

#

But yeah, trusting a random bot with your links is generally not the beset of ideas, although enough people were doing it it was kind of concerning

vocal prairie Apr 13, 2021, 5:31 PM

#

vocal prairie Or you can make a group dm with no one in it besides yourself.

I do this sometimes.

fallen patrol Apr 13, 2021, 5:31 PM

#

if a bot support server staff can read my messages, then idrc there's a lot of people

#

if the mods of a server which i talk to are reading them, thonk

patent pivot Apr 13, 2021, 5:31 PM

#

fallen patrol fwiw the actual thing is: users have become too accustomed to the belief that DM...

I would argue you'd probably want your private key going to those who you somewhat know, lol. Not sure the difference is too large there.

fallen patrol Apr 13, 2021, 5:32 PM

#

that was an accidental paste in that situation

#

and it hadn't been configured yet

#

i was trying to paste it on a server

patent pivot Apr 13, 2021, 5:32 PM

#

ah

fallen patrol Apr 13, 2021, 5:32 PM

#

i'm staff of a really large bot and we do have a relay cog

fervent sage Apr 13, 2021, 5:33 PM

#

which bot 👀

patent pivot Apr 13, 2021, 5:33 PM

#

but yeah most of the functionality we implement is ensuring a balance between user privacy, security and moderation

fallen patrol Apr 13, 2021, 5:33 PM

#

#

it only forwards it if >

fallen patrol Apr 13, 2021, 5:34 PM

#

fervent sage which bot 👀

if you want an invite i can dm you

fervent sage Apr 13, 2021, 5:35 PM

#

nah was just interested which

fallen patrol Apr 13, 2021, 5:35 PM

#

gamesrob https://gamesrob.com/

GamesROB

Main Page

fervent sage Apr 13, 2021, 5:36 PM

#

nice

sleek steppe Apr 13, 2021, 5:37 PM

#

I tested everything on python 3.9, the ones that error are the aoc commands and .pridefact

fallen patrol Apr 13, 2021, 5:38 PM

#

but

#

.pridefact

#

errors here too

#

sleek steppe Apr 13, 2021, 5:39 PM

#

thonk

#

ment

vocal halo Apr 13, 2021, 5:44 PM

#

hey devs how @stable mountain use its docs commands

fallen patrol Apr 13, 2021, 5:44 PM

#

!src d

stable mountainBOT Apr 13, 2021, 5:44 PM

#

Command: docs

Look up documentation for Python symbols.

Source Code

Go to GitHub

vocal halo Apr 13, 2021, 5:44 PM

#

like once one of you told me there is a object.i something file on site

#

and we have to use that

#

can you name that file again pls

vocal prairie Apr 13, 2021, 5:45 PM

#

vocal halo like once one of you told me there is a object.i something file on site

https://github.com/python-discord/bot/blob/806a057eb97e02ccfd14e1f7644f5c04d4e749cd/bot/exts/info/doc/_cog.py#L366

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

#

Read that line

vocal halo Apr 13, 2021, 5:45 PM

#

thanks mate

#

😄

fallen patrol Apr 13, 2021, 5:45 PM

#

OBJECT.INV

#

there we go i just remembered

#

no

#

/objects.inv

#

what the

#

did that just

vocal prairie Apr 13, 2021, 5:46 PM

#

It's in the link.

fallen patrol Apr 13, 2021, 5:46 PM

#

replace my query

#

#

lmao

vocal halo Apr 13, 2021, 5:47 PM

#

sorry but i forgot how to use that file

#

what module we need?'

sleek steppe Apr 13, 2021, 5:47 PM

#

fallen patrol replace my query

doc set

vocal prairie Apr 13, 2021, 5:47 PM

#

vocal halo what module we need?'

You should probably read the source code.

vocal halo Apr 13, 2021, 5:48 PM

#

yeah i am reading sorry for that

vocal prairie Apr 13, 2021, 5:48 PM

#

It's the best way to get answers.

#

!d discord

stable mountainBOT Apr 13, 2021, 5:48 PM

#

discord

In order to work with the library and the Discord API in general, we must first create a Discord Bot account.

Creating a Bot account is a pretty straightforward process.

sleek steppe Apr 13, 2021, 5:48 PM

#

!d <- that lists all of the inventories

vocal prairie Apr 13, 2021, 5:49 PM

#

Yeah, it is.

vocal halo Apr 13, 2021, 5:52 PM

#

Can you please help me?

magic arch Apr 13, 2021, 6:09 PM

#

vocal halo Can you please help me?

Hey! See #❓｜how-to-get-help, unless of course you're looking for help regarding contributing to one of the bots here, etc

vocal prairie Apr 13, 2021, 6:10 PM

#

magic arch Hey! See <#704250143020417084>, unless of course you're looking for help regardi...

They were wondering about the source of the docs command.

magic arch Apr 13, 2021, 6:10 PM

#

Ah alright gotcha

sleek steppe Apr 13, 2021, 7:25 PM

#

@short snow I pushed a bit more improvements to typing and fixed LinePaginator, I can PR now

stable mountainBOT Apr 13, 2021, 8:44 PM

#

@patent pivot

It has arrived!

Here's your reminder: changelog doc changes if no one else has.
[Jump back to when you created the reminder](#dev-contrib message)

sleek steppe Apr 13, 2021, 8:45 PM

#

lol

patent pivot Apr 13, 2021, 8:45 PM

#

cc <@&267628507062992896>, I can't do that tonight, can someone summarise and changelog bot#1014

dusky shoreBOT Apr 13, 2021, 8:45 PM

#

GitHub

PRMerged Doc improvements

gritty wind Apr 13, 2021, 8:46 PM

#

I'll do some reading and prepare something

sleek steppe Apr 13, 2021, 8:51 PM

#

Wonder why this only has 2020 thonk https://github.com/python-discord/sir-lancebot/blob/main/bot/resources/pride/facts.json

gritty wind Apr 13, 2021, 8:53 PM

#

The intention from the code appears to be allowing people to fetch facts from a given day

#

I do not know why

#

let's see

sleek steppe Apr 13, 2021, 8:54 PM

#

Well that makes the command useless in 2021

gritty wind Apr 13, 2021, 8:55 PM

#

Not true, it still sends random facts as long as one exists

sleek steppe Apr 13, 2021, 8:56 PM

#

gritty wind Apr 13, 2021, 8:56 PM

#

or nvm, I misread

#

yea

#

idk, the whole thing is weird

fallen patrol Apr 13, 2021, 9:06 PM

#

https://github.com/python-discord/sir-lancebot/blob/main/bot/resources/pride/facts.json

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

#

@gritty wind @sleek steppe ^

gritty wind Apr 13, 2021, 9:07 PM

#

?

fallen patrol Apr 13, 2021, 9:07 PM

#

the pride command

gritty wind Apr 13, 2021, 9:07 PM

#

Yes, what's your point?

fallen patrol Apr 13, 2021, 9:08 PM

#

the reason its weird

gritty wind Apr 13, 2021, 9:08 PM

#

I still don't get what you mean

clever wraith Apr 13, 2021, 9:56 PM

#

Hey if we're talking about changelogs, latex hasn't been done

gritty wind Apr 13, 2021, 9:57 PM

#

It still needs to get the memory fixes

clever wraith Apr 13, 2021, 9:57 PM

#

Hmm?

gritty wind Apr 13, 2021, 9:58 PM

#

It has no resource limits atm, so regular usage can crash the bot

clever wraith Apr 13, 2021, 9:58 PM

#

I know that he added a cooldown in a pr

gritty wind Apr 13, 2021, 9:58 PM

#

The cooldown on its own won't be enough, as one input alone could crash the whole thing

fallen patrol Apr 13, 2021, 9:58 PM

#

not the root cause

clever wraith Apr 13, 2021, 9:58 PM

#

sir-lancebot#682 I think

dusky shoreBOT Apr 13, 2021, 9:58 PM

#

GitHub

PROpen Fix Latex Cog Bug

clever wraith Apr 13, 2021, 9:58 PM

#

gritty wind The cooldown on its own won't be enough, as one input alone could crash the whol...

True

fallen patrol Apr 13, 2021, 9:59 PM

#

matplotlib.pyplot.figure to matplotlib.figure.Figure

#

that is probably a larger fix

clever wraith Apr 13, 2021, 9:59 PM

#

He did that as well

gritty wind Apr 13, 2021, 9:59 PM

#

The bigger fix would be adding actual memory constraints, so we don't have to depend on random fixes to cut down on the usage bit by bit

#

I'm working on converting the whole thing to use processes, but I'm somewhat busy

clever wraith Apr 13, 2021, 10:00 PM

#

Yeah, fair

stable mountainBOT Apr 13, 2021, 10:21 PM

#

@fallen patrol

It has arrived!

Here's your reminder: if the docs command still looks bad because discord changed markdown on mobile talk about making an issue..
[Jump back to when you created the reminder](#dev-contrib message)

patent pivot Apr 13, 2021, 10:23 PM

#

@fallen patrol https://github.com/jb3/discord-oauth2-gate

GitHub

jb3/discord-oauth2-gate

Cloudflare Worker for Discord OAuth2 Authentication - jb3/discord-oauth2-gate

fallen patrol Apr 13, 2021, 10:23 PM

#

!d aiohttp.ClientSession

stable mountainBOT Apr 13, 2021, 10:23 PM

#

aiohttp.ClientSession

class aiohttp.ClientSession(*, connector=None, loop=None, cookies=None, headers=None, skip_auto_headers=None, auth=None, json_serialize=json.dumps, version=aiohttp.HttpVersion11, ...)```
The class for creating client sessions and making requests.

fallen patrol Apr 13, 2021, 10:23 PM

#

No, it does not look bad mostly

vocal prairie Apr 13, 2021, 10:23 PM

#

Screenshot?

fallen patrol Apr 13, 2021, 10:24 PM

#

#

yes i am aware that is basically impossible to fix

vocal prairie Apr 13, 2021, 10:24 PM

#

That looks weird.

fallen patrol Apr 13, 2021, 10:24 PM

#

patent pivot <@!717983911824588862> https://github.com/jb3/discord-oauth2-gate

lmao

vocal prairie Apr 13, 2021, 10:24 PM

#

Much better on desktop.

fallen patrol Apr 13, 2021, 10:25 PM

#

do be aware the color is cause of android AMOLED

vocal prairie Apr 13, 2021, 10:25 PM

#

Yeah ik.

patent pivot Apr 13, 2021, 10:25 PM

#

live now and working!

vocal prairie Apr 13, 2021, 10:25 PM

#

Noice

#

OAuth2 is quite interesting.

fervent sage Apr 13, 2021, 10:26 PM

#

patent pivot live now and working!

Once you authorize you will be redirected to:
A random place in time and space without light. A black box if you will :)

fallen patrol Apr 13, 2021, 10:27 PM

#

patent pivot live now and working!

…privacy policy?

#

what is that

vocal prairie Apr 13, 2021, 10:27 PM

#

fervent sage Once you authorize you will be redirected to: A random place in time and space ...

Cough cough, the black box

fallen patrol Apr 13, 2021, 10:27 PM

#

*not asking what the privacy policy is but that link

patent pivot Apr 13, 2021, 10:27 PM

#

fervent sage Once you authorize you will be redirected to: A random place in time and space ...

Once authorising you will be redirected to ṫ̴̑ȟ̴̐e̸͛͆ ̸͋̑v̸͑̃ȏ̴͠ḯ̷̅d̷̈̕

vocal prairie Apr 13, 2021, 10:27 PM

#

I hate those characters.

patent pivot Apr 13, 2021, 10:27 PM

#

fallen patrol …privacy policy?

links to https://pydis.com/privacy/

vocal prairie Apr 13, 2021, 10:28 PM

#

Oh, that became user facing?

#

Nice

patent pivot Apr 13, 2021, 10:28 PM

#

the option in the dev portal yea

vocal prairie Apr 13, 2021, 10:28 PM

#

That's nice

patent pivot Apr 13, 2021, 10:28 PM

#

fervent sage Apr 13, 2021, 10:28 PM

#

my brain just assumes that everyone automatically sees displace patchnotes because of how useful they are kek

vocal prairie Apr 13, 2021, 10:28 PM

#

displace patchnotes?

fallen patrol Apr 13, 2021, 10:28 PM

#

bruh

#

https://my-cool-app.com

vocal prairie Apr 13, 2021, 10:29 PM

#

smh

fallen patrol Apr 13, 2021, 10:29 PM

#

#notascam

vocal prairie Apr 13, 2021, 10:29 PM

#

Discord's domains

patent pivot Apr 13, 2021, 10:29 PM

#

lol

fervent sage Apr 13, 2021, 10:29 PM

#

discord has one domain to trump all others

#

watchanimeattheoffice.com

patent pivot Apr 13, 2021, 10:29 PM

#

lol

fervent sage Apr 13, 2021, 10:29 PM

#

it has a url that beats even that

fallen patrol Apr 13, 2021, 10:29 PM

#

fervent sage watchanimeattheoffice.com

what the fuckkkkkk

patent pivot Apr 13, 2021, 10:29 PM

#

of course don't forget

#

https://bigbeans.solutions/

Discord

Nitro Benefits and Features | Discord

Enhance your Discord experience with Nitro - get custom emojis, animated avatars, larger file uploads, HD screensharing, and more.

fallen patrol Apr 13, 2021, 10:30 PM

#

lmao

#

https://airhorn.solutions/

/airhorn

A Discord bot with live statistics that makes airhorn sounds BEEP BOOP.

#

that one too

patent pivot Apr 13, 2021, 10:30 PM

#

but yeah oauth2 thing is live now

#

i would say break it

#

but i don't think i want that lol

fallen patrol Apr 13, 2021, 10:32 PM

#

my new bot invite link: https://watchanimeattheoffice.com/api/oauth2/authorize?client_id=409107086526644234&permissions=379968&scope=bot

vocal prairie Apr 13, 2021, 10:33 PM

#

That works?

#

Noice

#

Triple deploy.

fervent sage Apr 13, 2021, 10:45 PM

#

uh oh

fallen patrol Apr 13, 2021, 10:45 PM

#

patent pivot but yeah oauth2 thing is live now

cause hoe deployed the oauth thing i think

#

*joe

fervent sage Apr 13, 2021, 10:46 PM

#

oauth is totally unrelated to the bot

patent pivot Apr 13, 2021, 10:46 PM

#

lol

#

yeah

#

oauth stuff sits on cloudflare edge

vocal prairie Apr 13, 2021, 10:52 PM

#

Quadruple deploy

#

What is going on.

vale ibex Apr 13, 2021, 10:53 PM

#

Resetting the bot to deal with an on-going mod issue

#

nothing to worry about

vocal prairie Apr 13, 2021, 10:53 PM

#

Okie

fallen patrol Apr 13, 2021, 11:38 PM

#

vale ibex Resetting the bot to deal with an on-going mod issue

this? #dev-log message

vale ibex Apr 13, 2021, 11:38 PM

#

Nah that's unrelated

short snow Apr 14, 2021, 12:38 AM

#

sleek steppe <@!736234578745884682> I pushed a bit more improvements to typing and fixed Line...

sure do it, if you haven't already

fallen patrol Apr 14, 2021, 1:11 AM

#

@placid ermine #sir-lancebot-playground message

#

ah

#

because

#

aight so what is that

#

even

#

…

#

that's on the raw command and the latex command lel

fallen patrol Apr 14, 2021, 2:12 AM

#

<@&267628507062992896> latex cog causing crashes again

#

Tbf

#

.latex $L(x):=\sum_{j=0}^kyj(\prod{\begin{smallmatrix}0\le m\le k\m\ne j\end{smallmatrix}}\frac{x-x_m}{x_j-x_m})$
``` that kills it in one shot

thorny obsidian Apr 14, 2021, 2:13 AM

#

I can either unload the cog or Lancebot will just keep restarting. Either way it's Lancebot so it's not critical.

fallen patrol Apr 14, 2021, 2:13 AM

#

Unload ig?

#

Was prev unloaded for the same thing

vocal prairie Apr 14, 2021, 2:13 AM

#

hahastinkypoop has a pr open.

#

That fixes it at least a little.

#

It doesn't go over 110 mb.

fallen patrol Apr 14, 2021, 2:14 AM

#

But hasn't been merged yet

fallen patrol Apr 14, 2021, 2:14 AM

#

thorny obsidian I can either unload the cog or Lancebot will just keep restarting. Either way it...

Or 3) review the pr

vocal prairie Apr 14, 2021, 2:14 AM

#

And goes back down to normal once you give proper input.

vocal prairie Apr 14, 2021, 2:14 AM

#

fallen patrol But hasn't been merged yet

Yeah.

thorny obsidian Apr 14, 2021, 2:15 AM

#

I mean... my review won't do much until a core dev can look at it

#

Also... it's lancebot. Not critical.

fallen patrol Apr 14, 2021, 2:29 AM

#

thorny obsidian Also... it's lancebot. Not critical.

i mean, it hasn't respawned in 3 minutes

vocal prairie Apr 14, 2021, 2:29 AM

#

sir-lancebot#682

dusky shoreBOT Apr 14, 2021, 2:29 AM

#

GitHub

PROpen Fix Latex Cog Bug

fallen patrol Apr 14, 2021, 2:29 AM

#

finally ironically

fervent sage Apr 14, 2021, 2:32 AM

#

Hm what we need is a ping command mmLol

fallen patrol Apr 14, 2021, 2:32 AM

#

hm

vocal prairie Apr 14, 2021, 2:32 AM

#

fervent sage Hm what we need is a ping command <:mmLol:356831697385422848>

Yes

fallen patrol Apr 14, 2021, 2:32 AM

#

.uptime

fallen patrol Apr 14, 2021, 2:33 AM

#

fervent sage Hm what we need is a ping command <:mmLol:356831697385422848>

what pr number might that be if it were to exist?

fervent sage Apr 14, 2021, 2:33 AM

#

Uh 861 I think off the top of my head

fallen patrol Apr 14, 2021, 2:33 AM

#

sir-lancebot#861

fervent sage Apr 14, 2021, 2:33 AM

#

I think it's dead lol remember

fallen patrol Apr 14, 2021, 2:33 AM

#

sir-lancebot#681

dusky shoreBOT Apr 14, 2021, 2:33 AM

#

GitHub

PROpen feat: add ping command

vocal prairie Apr 14, 2021, 2:34 AM

#

fervent sage I think it's dead lol remember

861? That's far too high.

fervent sage Apr 14, 2021, 2:34 AM

#

?

fallen patrol Apr 14, 2021, 2:34 AM

#

its sir-lancebot#681 not sir-lancebot#861

dusky shoreBOT Apr 14, 2021, 2:34 AM

#

GitHub

PROpen feat: add ping command

fallen patrol Apr 14, 2021, 2:35 AM

#

fervent sage ?

you thought it was sir-lancebot#861 but in reality its sir-lancebot#681

dusky shoreBOT Apr 14, 2021, 2:35 AM

#

GitHub

PROpen feat: add ping command

fallen patrol Apr 14, 2021, 2:35 AM

#

stop.

fervent sage Apr 14, 2021, 2:35 AM

#

Ah

fallen patrol Apr 14, 2021, 2:37 AM

#

lmao lance died again

vocal prairie Apr 14, 2021, 2:57 AM

#

Why did dev voice move up again?

vocal prairie Apr 14, 2021, 2:57 AM

#

fallen patrol lmao lance died again

9 reconnects in an hour

vocal wolf Apr 14, 2021, 2:57 AM

#

we archived bounty board

fallen patrol Apr 14, 2021, 2:57 AM

#

vocal prairie 9 reconnects in an hour

its fine

Either way it's Lancebot so it's not critical.

vocal prairie Apr 14, 2021, 2:57 AM

#

I thought dev voice was below dev contrib

vocal prairie Apr 14, 2021, 2:57 AM

#

fallen patrol its fine > Either way it's Lancebot so it's not critical.

Yeah ig

fallen patrol Apr 14, 2021, 2:57 AM

#

ohhhhh

fallen patrol Apr 14, 2021, 2:57 AM

#

vocal prairie I thought dev voice was below dev contrib

u have android

vocal wolf Apr 14, 2021, 2:57 AM

#

vocal prairie I thought dev voice was below dev contrib

it is?

fallen patrol Apr 14, 2021, 2:58 AM

#

that's why

#

its an android bug

vocal wolf Apr 14, 2021, 2:58 AM

#

ah

vocal prairie Apr 14, 2021, 2:58 AM

#

Oh

#

I see

vocal wolf Apr 14, 2021, 2:58 AM

#

gosh darn it discord

#

anyway

fallen patrol Apr 14, 2021, 2:58 AM

#

same thing occurs in pyweek

vocal wolf Apr 14, 2021, 2:58 AM

#

why is sir lance dying so often?

vocal prairie Apr 14, 2021, 2:58 AM

#

vocal wolf why is sir lance dying so often?

Latex

fallen patrol Apr 14, 2021, 2:58 AM

#

vocal wolf why is sir lance dying so often?

doesn't matter its not critical

#

buttt

vocal wolf Apr 14, 2021, 2:58 AM

#

fallen patrol doesn't matter its not critical

Still matters to me.

vocal prairie Apr 14, 2021, 2:58 AM

#

sir-lancebot#682 should fix it

dusky shoreBOT Apr 14, 2021, 2:58 AM

#

GitHub

PROpen Fix Latex Cog Bug

fallen patrol Apr 14, 2021, 2:58 AM

#

sir-lancebot#682

dusky shoreBOT Apr 14, 2021, 2:58 AM

#

GitHub

PROpen Fix Latex Cog Bug

vocal prairie Apr 14, 2021, 2:59 AM

#

Hopefully

fallen patrol Apr 14, 2021, 2:59 AM

#

vocal wolf Still matters to me.

if you wanna drop a like and follow hit up sir-lancebot#682

#

i really bungled that statement

magic arch Apr 14, 2021, 2:59 AM

#

ill subscribe 🙂 👍

#

lol

vocal wolf Apr 14, 2021, 2:59 AM

#

it's high priority now.

fallen patrol Apr 14, 2021, 3:00 AM

#

nice

vocal prairie Apr 14, 2021, 3:00 AM

#

Noice

fallen patrol Apr 14, 2021, 3:00 AM

#

add a review if you want

#

since ur a core dev it would mean only one contributor needed

vocal wolf Apr 14, 2021, 3:01 AM

#

fallen patrol add a review if you want

I'll do it if I can

fallen patrol Apr 14, 2021, 3:01 AM

#

ok

#

fun

#

there's also room for abuse #bot-commands message

placid ermine Apr 14, 2021, 3:04 AM

#

fallen patrol there's also room for abuse https://canary.discord.com/channels/2676243358360535...

bruh

fallen patrol Apr 14, 2021, 3:05 AM

#

wait was that you

placid ermine Apr 14, 2021, 3:05 AM

#

no

#

bruh

fervent sage Apr 14, 2021, 3:06 AM

#

'room for abuse' applies to basically everything that takes user content and passes it back in some form, it's a thing that happens and the only real way to deal with it is just to moderate it case-by-case

vocal wolf Apr 14, 2021, 3:06 AM

#

@fervent sage ping command merged.

fervent sage Apr 14, 2021, 3:07 AM

#

aye

vocal wolf Apr 14, 2021, 3:08 AM

#

@fervent sage another ping, another poke.

https://github.com/python-discord/sir-lancebot/pull/679#pullrequestreview-635178032

fervent sage Apr 14, 2021, 3:09 AM

#

i actually saw the comment pop up on my other monitor before the ping :P

vocal wolf Apr 14, 2021, 3:09 AM

#

lel

fallen patrol Apr 14, 2021, 3:10 AM

#

hey

#

~~are you guys able to review the bot killing bug?~~

vocal wolf Apr 14, 2021, 3:10 AM

#

fallen patrol ~~are you guys able to review the bot killing bug?~~

the latex thing?

fallen patrol Apr 14, 2021, 3:10 AM

#

yeah

#

it like

#

dies after several commands rn

vocal wolf Apr 14, 2021, 3:11 AM

#

I'll get there.

fallen patrol Apr 14, 2021, 3:11 AM

#

because it isn't even closing it

vocal halo Apr 14, 2021, 3:12 AM

#

hey you guys know about @stable mountain so can you help me in #help-lemon

#

that would be nice of you

placid ermine Apr 14, 2021, 3:13 AM

#

fallen patrol dies after several commands rn

*several commands with bad input
but yeah 😔

#

the hacky workaround I PRed does seem to do the job tho

#

gc is stdlib

vocal wolf Apr 14, 2021, 3:13 AM

#

huh

#

ty

#

oh interesting

fallen patrol Apr 14, 2021, 3:13 AM

#

placid ermine *several commands with bad input but yeah 😔

also i mean

#

the error is pretty uh

vocal wolf Apr 14, 2021, 3:14 AM

#

I should use this lib in my projects

placid ermine Apr 14, 2021, 3:14 AM

#

fallen patrol the error is pretty uh

bot killing?

#

yes

fallen patrol Apr 14, 2021, 3:14 AM

#

placid ermine Apr 14, 2021, 3:14 AM

#

well yes

fallen patrol Apr 14, 2021, 3:14 AM

#

its

#

an interesting error

#

because the ^ never points to the error

placid ermine Apr 14, 2021, 3:15 AM

#

O lol

#

interesting

vocal wolf Apr 14, 2021, 3:15 AM

#

Does gc.collect() have the possibility of effecting other cogs?

fallen patrol Apr 14, 2021, 3:15 AM

#

granted

placid ermine Apr 14, 2021, 3:15 AM

#

probably not

#

i think

#

i'm not sure

#

but Bast said using gc.collect() isn't a good fix

vocal wolf Apr 14, 2021, 3:16 AM

#

fallen patrol granted

@sullen phoenix I feel like I've seen you talk about the gc module before. Are you able to comment on this?

#

wait I replied to the wrong thread

vocal wolf Apr 14, 2021, 3:17 AM

#

vocal wolf Does `gc.collect()` have the possibility of effecting other cogs?

This is the one

fallen patrol Apr 14, 2021, 3:17 AM

#

yes, yes you did

sullen phoenix Apr 14, 2021, 3:18 AM

#

you typically do not want to manually invoke it, yeah

vocal wolf Apr 14, 2021, 3:19 AM

#

placid ermine but Bast said using gc.collect() isn't a good fix

Is this our only option?

fallen patrol Apr 14, 2021, 3:20 AM

#

just reload the cog after command execution

placid ermine Apr 14, 2021, 3:21 AM

#

vocal wolf Is this our only option?

I'm still trying to figure out why it isn't getting GCed automatically

#

and looking at SO, it seems like memory issues are pretty common with matplotlib

#

fervent sage Apr 14, 2021, 3:22 AM

#

ok, timed command looking nice is success, but i've had to switch up the code a bit:

        prefix = ""
        if subctx := getattr(ctx, "subcontext"):
            prefix = f"{ctx.command} "
            ctx = subctx

        ...  # more code and logic

            embed = self.error_embed(
                f"Your input was invalid: {error}\n\nUsage:\n``{ctx.prefix}{prefix}{ctx.command} {ctx.command.signature}``"
            )

i really dont like the name prefix here for the parent context's command so i'd love suggestions for alternative symbol names for it

vocal wolf Apr 14, 2021, 3:24 AM

#

Latex cog unloaded.

#

@placid ermine @fallen patrol also taken off of high priorty.

fallen patrol Apr 14, 2021, 3:25 AM

#

lol

vocal wolf Apr 14, 2021, 3:25 AM

#

take your time when debugging

fallen patrol Apr 14, 2021, 3:25 AM

#

vocal wolf Latex cog unloaded.

did you unload it?

vocal wolf Apr 14, 2021, 3:25 AM

#

I agreed with kat that it would be best to do that.

fallen patrol Apr 14, 2021, 3:25 AM

#

ah

#

so if it gets loaded again ping someone?

placid ermine Apr 14, 2021, 3:25 AM

#

yeah, i'm inclined to agree too 😔

fallen patrol Apr 14, 2021, 3:25 AM

#

because it was unloaded earlier but the bot reconnected

fervent sage Apr 14, 2021, 3:26 AM

#

fervent sage ok, timed command looking nice is success, but i've had to switch up the code a ...

i think ive come up with a decent one, "parent_command"

#

oh no, flake8 is unhappy

#

time for some ✨ rearranging ✨

fallen patrol Apr 14, 2021, 3:29 AM

#

fervent sage oh no, flake8 is unhappy

why?

fervent sage Apr 14, 2021, 3:29 AM

#

line too long

fallen patrol Apr 14, 2021, 3:29 AM

#

just black it

#

lmfao

#

btw

#

running black on the lancebot repo changes like 56 files

vocal wolf Apr 14, 2021, 3:30 AM

#

black can be weird sometimes with flake8 and conflict

fervent sage Apr 14, 2021, 3:30 AM

#

black wouldnt fix it since its a too long string

vocal wolf Apr 14, 2021, 3:30 AM

#

wouldn't autopep8 work better?

fervent sage Apr 14, 2021, 3:30 AM

#

the only way was for me to split it into a couple parts which black doesnt know how to - and shouldnt even attempt to - do

fallen patrol Apr 14, 2021, 3:31 AM

#

like

#

\

fallen patrol Apr 14, 2021, 3:31 AM

#

vocal wolf wouldn't autopep8 work better?

wdym

vocal wolf Apr 14, 2021, 3:31 AM

#

would conflict less with flake8

fervent sage Apr 14, 2021, 3:32 AM

#

okie, correct command signature fix pushed

#

also wow i forgot how good vscode's integration with github PRs is

vocal wolf Apr 14, 2021, 3:34 AM

#

#

lol

#

I can't computer

#

this works well

sullen phoenix Apr 14, 2021, 3:34 AM

#

vocal wolf Is this our only option?

i’m not sure, but that would be a last, last resort

vocal wolf Apr 14, 2021, 3:34 AM

#

sullen phoenix i’m not sure, but that would be a last, last resort

I ain't ready for the side effects.

#

lol

sullen phoenix Apr 14, 2021, 3:34 AM

#

haha yeah

fervent sage Apr 14, 2021, 3:35 AM

#

vocal wolf

lmao you almost gave me a heart attack i thought for a sec that i'd somehow made a mystery bug that added an extra 2 .s but its just that your prefix is ... lmao

vocal wolf Apr 14, 2021, 3:36 AM

#

xd

short snow Apr 14, 2021, 3:36 AM

#

@vale ibex mentioned the changes and updated the PR description

fallen patrol Apr 14, 2021, 3:38 AM

#

@fervent sage what is subcontext?

fervent sage Apr 14, 2021, 3:39 AM

#

@vocal wolf more than happy to make that change, but im at a loss for commit message lol (preferably following the format chore: <msg>) kek

#

hm improve code clarity perhaps but it feels like it doesnt quite fit

vocal wolf Apr 14, 2021, 3:40 AM

#

"Moved variable into if statement"

fallen patrol Apr 14, 2021, 3:40 AM

#

fervent sage <@!196664644113268736> more than happy to make that change, but im at a loss for...

'made good changes; code better'

fervent sage Apr 14, 2021, 3:40 AM

#

there are 2 ~~no 3~~ no 4 hard things in computing:
cache invalidation
naming
timezones
git commit messages that dont suck

fallen patrol Apr 14, 2021, 3:40 AM

#

staying within resource limits

vocal wolf Apr 14, 2021, 3:40 AM

#

git commit -am "I updated files." && git push

#

There.

clever wraith Apr 14, 2021, 3:41 AM

#

I finally understood how cogs work!

#

I would like to contribute

vocal wolf Apr 14, 2021, 3:42 AM

#

nice!

clever wraith Apr 14, 2021, 3:42 AM

#

How can I contribute

fervent sage Apr 14, 2021, 3:42 AM

#

if there is one thing i pride myself on it's my git commit messages which over the past year i have successfully wrangled from "aaAAAaAaaAAa" to actual readable useful commits

clever wraith Apr 14, 2021, 3:42 AM

#

Lol

#

I never use git and github

#

this will be a first for me

fervent sage Apr 14, 2021, 3:43 AM

#

if all else is awful, at least my commit messages will be nice kek

clever wraith Apr 14, 2021, 3:43 AM

#

lol

vocal halo Apr 14, 2021, 3:43 AM

#

aah guys you said ask help in help channels

#

no one helped and now that channel is closed by bot

vocal wolf Apr 14, 2021, 3:43 AM

#

@clever wraith git is an extremely powerful tool. Here's a tutorial to get you started:

https://www.youtube.com/watch?v=HkdAHXoRtos

YouTube

Fireship

Git It? How to use Git and Github

Learn how to use Git and Github 🐙🐱 in this interactive tutorial by sending a pull request to this repo in exchange for a free AngularFirebase sticker 🔥https://github.com/codediodeio/gimmie-sticker

PRO https://angularfirebase.com/pro
Atlassian https://www.atlassian.com/git/tutorials

▶ Play video

clever wraith Apr 14, 2021, 3:44 AM

#

ok anyway idk what command to make

#

should i make a What Harry Potter House are you in?

vocal halo Apr 14, 2021, 3:44 AM

#

help me

clever wraith Apr 14, 2021, 3:44 AM

#

basically a questionnaire that determines what harry potter house you are in

vocal wolf Apr 14, 2021, 3:44 AM

#

clever wraith should i make a What Harry Potter House are you in?

Sounds like a good idea, I'm pretty darn sure we don't have that.

clever wraith Apr 14, 2021, 3:45 AM

#

but since it’s not original i could maybe change it up a bit

#

duck houses??

#

which duck house do you belong in

vocal wolf Apr 14, 2021, 3:45 AM

#

@vocal halo We're all volunteers here, you must be patient when receiving help. If you don't get an answer to your question, try to be more specific on what the problem is and what you've already tried.

clever wraith Apr 14, 2021, 3:45 AM

#

hmmm

vocal wolf Apr 14, 2021, 3:46 AM

#

@clever wraith ditch the harry potter houses. Which duck are you?

clever wraith Apr 14, 2021, 3:46 AM

#

i’ll try implementing it on my bot first, it it works i’ll try adding it to sir lancebot

vocal halo Apr 14, 2021, 3:46 AM

#

vocal wolf <@!810793785356976129> We're all volunteers here, you must be patient when recei...

i am patient i am waiting from last day

clever wraith Apr 14, 2021, 3:46 AM

#

yes which sucks

#

duck

fallen patrol Apr 14, 2021, 3:46 AM

#

@placid ermine I just found a fix for your latex command

vocal halo Apr 14, 2021, 3:46 AM

#

ducky_yellow

fallen patrol Apr 14, 2021, 3:46 AM

#

It fixes all issues with it

#

rm -f latex.py

clever wraith Apr 14, 2021, 3:46 AM

#

wow

placid ermine Apr 14, 2021, 3:47 AM

#

oooh

#

that makes so much sense

#

many thank

fallen patrol Apr 14, 2021, 3:47 AM

#

Np

fervent sage Apr 14, 2021, 3:47 AM

#

i was 50/50 on saying "what remove it?" but i thought you were gonna propose a real solution, my disappointment is immeasurable and my day is ruined kek

vocal wolf Apr 14, 2021, 3:47 AM

#

fallen patrol `rm -f latex.py`

How about the no

vocal halo Apr 14, 2021, 3:47 AM

#

hey bro i found but no one helped can you @fallen patrol

#

objects.inv

clever wraith Apr 14, 2021, 3:48 AM

#

does the sir lancebot use load extension?

fallen patrol Apr 14, 2021, 3:48 AM

#

Ah I think I did answer when u originally asked

#

But

vocal wolf Apr 14, 2021, 3:48 AM

#

clever wraith does the sir lancebot use load extension?

yes

fallen patrol Apr 14, 2021, 3:48 AM

#

!src d

stable mountainBOT Apr 14, 2021, 3:48 AM

#

Command: docs

Look up documentation for Python symbols.

Source Code

Go to GitHub

fallen patrol Apr 14, 2021, 3:48 AM

#

.src ext

clever wraith Apr 14, 2021, 3:48 AM

#

ok so for my command to work i’ll need a setup function right

fallen patrol Apr 14, 2021, 3:48 AM

#

I hate u lance

vocal halo Apr 14, 2021, 3:48 AM

#

fallen patrol Ah I think I did answer when u originally asked

yeah you did but now i dont understand all the code in like in a cycle

vocal wolf Apr 14, 2021, 3:48 AM

#

clever wraith ok so for my command to work i’ll need a setup function right

also yes

#

wait

fervent sage Apr 14, 2021, 3:48 AM

#

oh also xithrius i made the fixes :P

fallen patrol Apr 14, 2021, 3:48 AM

#

Yes

vocal wolf Apr 14, 2021, 3:48 AM

#

@fervent sage do you have a tutorial for cogs in dpy?

fervent sage Apr 14, 2021, 3:48 AM

#

i do

clever wraith Apr 14, 2021, 3:48 AM

#

no no no

fallen patrol Apr 14, 2021, 3:49 AM

#

vocal wolf <@!297045071457681409> do you have a tutorial for cogs in dpy?

You need the setup method and cannot be async

clever wraith Apr 14, 2021, 3:49 AM

#

i already know cogs

fallen patrol Apr 14, 2021, 3:49 AM

#

I think they may have meant the init.py file?

vocal wolf Apr 14, 2021, 3:49 AM

#

clever wraith i already know cogs

There's no harm in reading another tutorial (I think)

fallen patrol Apr 14, 2021, 3:49 AM

#

vocal wolf There's no harm in reading another tutorial (I think)

(it depends on the tutorial)

vocal wolf Apr 14, 2021, 3:49 AM

#

(anything but youtube)

vocal wolf Apr 14, 2021, 3:50 AM

#

fervent sage oh also xithrius i made the fixes :P

I will stare.

fervent sage Apr 14, 2021, 3:50 AM

#

uh there's https://vcokltfre.dev/tutorial/05-cogs for general cog stuff, and https://vcokltfre.dev/tips/cogs for transitioning existing commands to use cogs

fallen patrol Apr 14, 2021, 3:50 AM

#

Fwiw alec's tutorial is pretty good but I think there was a hole luckily I already knew it

fervent sage Apr 14, 2021, 3:50 AM

#

o.O what hole

#

i plug holes

fallen patrol Apr 14, 2021, 3:50 AM

#

Idr

vocal wolf Apr 14, 2021, 3:50 AM

#

fervent sage uh there's <https://vcokltfre.dev/tutorial/05-cogs> for general cog stuff, and <...

@clever wraith stare I suggest.

placid ermine Apr 14, 2021, 3:50 AM

#

anyway
for some reason
it looks like there's 13 references to the fig variable when there is bad input, but only 7 when the input is good

clever wraith Apr 14, 2021, 3:51 AM

#

lol okay

#

i’ll check em out

#

does anyone wanna write the command with me?

#

i’m kinda trash at python

fallen patrol Apr 14, 2021, 3:52 AM

#

Wut

#

@fervent sage gimme tldr https://vcokltfre.dev/tips/optional/

Optional Arguments

Sometimes in discord.py you'll want optional arguments. The correct way to do this is using typing.Optional, not defaulting the arguments to None.

#

Why typing.Optional

vocal wolf Apr 14, 2021, 3:53 AM

#

@fervent sage would this work?

-       if subctx := getattr(ctx, "subcontext", None):
+       if ctx := getattr(ctx, "subcontext", None):
+            parent_command = f"{ctx.command} "
-            ctx = subctx

fervent sage Apr 14, 2021, 3:53 AM

#

nop because if it has no subcommand parent would be undefined later

clever wraith Apr 14, 2021, 3:53 AM

#

!d typing.Optional

stable mountainBOT Apr 14, 2021, 3:53 AM

#

typing.Optional


typing.Optional```
Optional type.

`Optional[X]` is equivalent to `Union[X, None]`.

Note that this is not the same concept as an optional argument, which is one that has a default. An optional argument with a default does not require the `Optional` qualifier on its type annotation just because it is optional. For example:

```py
def foo(arg: int = 0) -> None:
    ...
```  On the other hand, if an explicit value of `None` is allowed, the use of `Optional` is appropriate, whether the argument is optional or not. For example...

fervent sage Apr 14, 2021, 3:53 AM

#

fallen patrol <@297045071457681409> gimme tldr https://vcokltfre.dev/tips/optional/

this is bad advice pls ignore it i need to remove this

clever wraith Apr 14, 2021, 3:53 AM

#

here you go

placid ermine Apr 14, 2021, 3:53 AM

#

fervent sage this is bad advice pls ignore it i need to remove this

lmao

fervent sage Apr 14, 2021, 3:53 AM

#

the issue is which i didnt knwo when i wrote it

fallen patrol Apr 14, 2021, 3:53 AM

#

fervent sage this is bad advice pls ignore it i need to remove this

Lol but

fervent sage Apr 14, 2021, 3:53 AM

#

that d.py supresses conversion errors when using it

fallen patrol Apr 14, 2021, 3:54 AM

#

What does typing.Optional do that = None do?

vocal wolf Apr 14, 2021, 3:54 AM

#

fervent sage nop because if it has no subcommand parent would be undefined later

parent_command = "" is still there btw

#

@fallen patrol I think this gives pretty good examples.

https://docs.python.org/3/library/typing.html#typing.Optional

#

of what is correct

fervent sage Apr 14, 2021, 3:54 AM

#

hm yes i think that should work, i'll test it now

vocal wolf Apr 14, 2021, 3:54 AM

#

So it's more like

#

+       parent_command = ""
-       if subctx := getattr(ctx, "subcontext", None):
+       if ctx := getattr(ctx, "subcontext", None):
+            parent_command = f"{ctx.command} "
-            ctx = subctx

@fervent sage

fervent sage Apr 14, 2021, 3:56 AM

#

oh actually it should be if ctx := getattr(ctx, "subcommand", ctx) but will fix now

fallen patrol Apr 14, 2021, 3:56 AM

#

vocal wolf <@!717983911824588862> I think this gives pretty good examples. <https://docs.p...

So what does optional do??

fervent sage Apr 14, 2021, 3:56 AM

#

wait

#

no

#

thats why i made it that way in the first place

#

hang on

vocal wolf Apr 14, 2021, 3:56 AM

#

fallen patrol So what does optional do??

Tells you that the argument can be None.

fervent sage Apr 14, 2021, 3:56 AM

#

!e

a = 1
if a := None:
  pass

print(a)

stable mountainBOT Apr 14, 2021, 3:56 AM

#

@fervent sage :white_check_mark: Your eval job has completed with return code 0.

None

fervent sage Apr 14, 2021, 3:57 AM

#

ok yeah

vocal wolf Apr 14, 2021, 3:57 AM

#

Optional[X] is equivalent to Union[X, None]

#

Union[X, None] means that the arg will either be of type X or None.

fervent sage Apr 14, 2021, 3:57 AM

#

that's why i set ctx in that way, it's because otherwise you end up overwriting it as a value you dont want

fallen patrol Apr 14, 2021, 3:57 AM

#

Wait what is union aaaaAAAA

#

!d typing.Union

stable mountainBOT Apr 14, 2021, 3:57 AM

#

typing.Union


typing.Union```
Union type; `Union[X, Y]` means either X or Y.

To define a union, use e.g. `Union[int, str]`. Details...

vocal wolf Apr 14, 2021, 3:58 AM

#

fervent sage that's why i set ctx in that way, it's because otherwise you end up overwriting ...

Alright so your current implementation should be the good?

fervent sage Apr 14, 2021, 3:58 AM

#

i think so but i need a couple minutes to regain my brain to think about it now kek

vocal wolf Apr 14, 2021, 3:59 AM

#

fervent sage i think so but i need a couple minutes to regain my brain to think about it now ...

Same.

fervent sage Apr 14, 2021, 4:00 AM

#

thought process as i regain said brain:

        # current version
        parent_command = ""
        if subctx := getattr(ctx, "subcontext", None):
            parent_command = f"{ctx.command} "
            ctx = subctx

        # proposed version
        parent_command = ""
        if ctx := getattr(ctx, "subcontext", None): # this overwrites ctx unconditionally which we dont want
            parent_command = f"{ctx.command} "

        # fixed proposed version
        parent_command = ""
        if ctx := getattr(ctx, "subcontext", ctx): # this will always be truthy which we also dont want
            parent_command = f"{ctx.command} "
``` i have concluded that i believe the current way is the good way

vocal wolf Apr 14, 2021, 4:00 AM

#

then your way will remain.

placid ermine Apr 14, 2021, 4:02 AM

#

Deleting all references to the figure, and/or using the window manager to kill the window in which the figure appears on the screen, is not enough, because pyplot maintains internal references until close() is called.
mfw when calling close() doesn't remove internal references either

vocal wolf Apr 14, 2021, 4:11 AM

#

@fervent sage on current branch:

Traceback (most recent call last):
  File "/home/xithrius/.local/share/virtualenvs/sir-lancebot--q_Shpea/lib/python3.8/site-packages/discord/ext/commands/core.py", line 85, in wrapped
    ret = await coro(*args, **kwargs)
  File "/home/xithrius/Repositories/PythonDiscord/sir-lancebot/bot/exts/evergreen/timed.py", line 24, in timed
    if not ctx.subcontext.command:
AttributeError: 'Context' object has no attribute 'subcontext'

Caused by ...timed uwu

fervent sage Apr 14, 2021, 4:11 AM

#

hmm

fervent sage Apr 14, 2021, 4:13 AM

#

vocal wolf <@!297045071457681409> on current branch: ```py Traceback (most recent call last...

aaa why you break my code kek

vocal wolf Apr 14, 2021, 4:13 AM

#

oh my god I'm stupid lol

fervent sage Apr 14, 2021, 4:14 AM

#

you and me both lol, i didnt even notice when i did the commit for it

vocal wolf Apr 14, 2021, 4:14 AM

#

revert that and squash push

fervent sage Apr 14, 2021, 4:14 AM

#

that is beyond my git knowledge, how do i do?

vocal wolf Apr 14, 2021, 4:14 AM

#

I will show you de wey

sharp timber Apr 14, 2021, 4:23 AM

#

lmao oof

#

I've done this before ;-;

short snow Apr 14, 2021, 4:24 AM

#

@sleek steppe @vocal prairie i divided the dependencies here: https://github.com/python-discord/sir-lancebot/issues/549#issuecomment-818877028

I followed pattern toxic-me-dawn

If you guys want any changes let me know, and you can directly push to my fork if you are sure or if you are not sure just push to update/python3.9/<name>

GitHub

Investigate an upgrade to Python 3.9.4 · Issue #549 · python-discor...

Description Python 3.9.1 has been released today (yay!), which means that it's mature enough for us to start looking into upgrading the Python version of sir-lancebot. We'll obvious...

fervent sage Apr 14, 2021, 4:24 AM

#

always a good day when your terminal looks like this at 5am kek

short snow Apr 14, 2021, 4:24 AM

#

lol, xith disappeared

sharp timber Apr 14, 2021, 4:25 AM

#

He is finding materials

#

to show da wey

fervent sage Apr 14, 2021, 4:25 AM

#

short snow lol, xith disappeared

into my dms to show me da wey

short snow Apr 14, 2021, 4:25 AM

#

oh

#

i thought he was doing intense stackoverflow

vocal wolf Apr 14, 2021, 4:25 AM

#

I hath shown him de wey

sharp timber Apr 14, 2021, 4:25 AM

#

praise

fervent sage Apr 14, 2021, 4:26 AM

#

de wey has been very successfully shown by xithrius

#

and now i bookmark the resources because there's a 110% chance i will have forgotten de wey by the next time kek

vocal wolf Apr 14, 2021, 4:28 AM

#

its ok you have the alias in your zshrc

fervent sage Apr 14, 2021, 4:28 AM

#

true

#

until that lies forgotten like 8 of the other ones i only remember when i add more kek

vocal wolf Apr 14, 2021, 4:28 AM

#

https://github.com/Xithrius/dotfiles/blob/master/.zshrc#L58

Source

fervent sage Apr 14, 2021, 4:28 AM

#

vocal wolf Apr 14, 2021, 4:29 AM

#

docker system prune -a

short snow Apr 14, 2021, 4:30 AM

#

http://iscaliforniaonfire.com/ lol

fervent sage Apr 14, 2021, 4:30 AM

#

best alias is alias mkbot="sh /home/vcokltfre/mkbot.sh"

#

which executes

echo "Name: "
read name
cd /home/vcokltfre/projects/python_discord

git clone https://github.com/vcokltfre/yatb $name
cd ./$name
rm -rf .git

git init
git commit -m "feat: initial commit" --allow-empty

code .

vocal wolf Apr 14, 2021, 4:31 AM

#

@fervent sage we're stupid again (I think).

fervent sage Apr 14, 2021, 4:31 AM

#

oh no

vocal wolf Apr 14, 2021, 4:31 AM

#

ctx.subcontext is used once

#

in the timed.py file

#

so why not just replace it with new_ctx in the if statement

fervent sage Apr 14, 2021, 4:31 AM

#

because the error handler needs it

vocal wolf Apr 14, 2021, 4:32 AM

#

nevermind you're not stupid, I am

#

lol

fervent sage Apr 14, 2021, 4:32 AM

#

kek

vocal wolf Apr 14, 2021, 4:32 AM

#

everything is fine

#

nothing is on fire

fervent sage Apr 14, 2021, 4:32 AM

#

that's a very familiar progression of thoughts to me lol

vocal wolf Apr 14, 2021, 4:32 AM

#

merged.

fervent sage Apr 14, 2021, 4:33 AM

#

epic

vocal wolf Apr 14, 2021, 4:33 AM

#

and yes, I did test the newest version

fervent sage Apr 14, 2021, 4:33 AM

#

pretty errors for when we're pretty dumb kek

#

i love how i got woken at 4am to deal with some people breaking tos on gta online server, and ended up staying awake another hour and a half from being sidetracked by code lmao

short snow Apr 14, 2021, 4:34 AM

#

short snow http://iscaliforniaonfire.com/ lol

!otn a is california on fire?

fervent sage Apr 14, 2021, 4:35 AM

#

if we do that we also need a !otn a yes for that one time in 27 years time when they line up

short snow Apr 14, 2021, 4:36 AM

#

quackstack#31 needs one core dev review and quackstack gets more closer to the finish line

dusky shoreBOT Apr 14, 2021, 4:36 AM

#

GitHub

PROpen Switch random generation to use HSV over RGB

fervent sage Apr 14, 2021, 4:36 AM

#

i should be quackstack core dev mmLol

short snow Apr 14, 2021, 4:37 AM

#

anything, just one review

fervent sage Apr 14, 2021, 4:37 AM

#

but i have a commit anyway so it wouldnt matter lol

#

actually that should work with just a helper+ review iirc on quackstack

short snow Apr 14, 2021, 4:38 AM

#

oo i can disable auto merge

fervent sage Apr 14, 2021, 4:38 AM

#

unless that changed

vocal halo Apr 14, 2021, 6:08 AM

#

hey devs I figure out how to do that

#

but i still dont understand how @stable mountain diffrence between one name for two or more URI?

#

like if i check the objects.inv file there are 3 lists and when i do

#

!d list

stable mountainBOT Apr 14, 2021, 6:11 AM

#

list


class list([iterable])```
Lists may be constructed in several ways:

• Using a pair of square brackets to denote the empty list: `[]`

• Using square brackets, separating items with commas: `[a]`, `[a, b, c]`

• Using a list comprehension: `[x for x in iterable]`

• Using the type constructor: `list()` or `list(iterable)`...

vocal halo Apr 14, 2021, 6:11 AM

#

it give me one list

#

how it find which one to give?

gritty wind Apr 14, 2021, 6:12 AM

#

It doesn’t - a URI is not a URI if it isn’t unique. They have different paths

#

It finds the ones that match the exact given path

vocal halo Apr 14, 2021, 6:12 AM

#

gritty wind It doesn’t - a URI is not a URI if it isn’t unique. They have different paths

read my question again pls

gritty wind Apr 14, 2021, 6:12 AM

#

Only one of the 3 lists is actually just “list”

#

The other 2 have different paths

vocal halo Apr 14, 2021, 6:13 AM

#

gritty wind Only one of the 3 lists is actually just “list”

yea

#

then how @stable mountain find which is real

gritty wind Apr 14, 2021, 6:13 AM

#

When you call docs with list, it pulls the one that’s just list

#

Because they have different paths

#

That’s what makes it a U(nique)RI

vocal halo Apr 14, 2021, 6:14 AM

#

gritty wind That’s what makes it a U(nique)RI

well let me test it pls

short snow Apr 14, 2021, 6:15 AM

#

why do we store caches with hash of the timestamp, and why not just the timstamp

vocal halo Apr 14, 2021, 6:17 AM

#

@gritty wind i was looping in Name now i am going to loop through URI

brazen charm Apr 14, 2021, 6:39 AM

#

When the symbol names are the same, the bot will move the latter occurrences to different names depending on some conditions

vale ibex Apr 14, 2021, 9:24 AM

#

Added some screenshots to my PR, ready for review now 😄 bot#1524

dusky shoreBOT Apr 14, 2021, 9:24 AM

#

GitHub

PROpen Use a paginated embed to output multiple snowflakes

short snow Apr 14, 2021, 9:31 AM

#

A tz-naive object is a object which is timezone unaware right?

vale ibex Apr 14, 2021, 9:35 AM

#

yea

short snow Apr 14, 2021, 9:37 AM

#

vale ibex yea

if there is no timezone given, how does it get the time?

#

and why did kwzrd use arrow rather than just specifying UTC timezine while doing datetime.datetime and there is utcfromtimestamp

vale ibex Apr 14, 2021, 9:38 AM

#

context?

short snow Apr 14, 2021, 9:39 AM

#

https://github.com/python-discord/bot/pull/1523

GitHub

Branding: correct broken timestamp persistence & improve cosmetics ...

So when Phil Karlton said ~

There are only two hard things in Computer Science: cache invalidation and naming things.

~ I think he forgot about timezones.
Branding
The new branding manager [#1463...

vale ibex Apr 14, 2021, 9:40 AM

#

It's likely due to how datetime deals with timezones

#

read the warning here https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow

#

Arrow makes things like this much easier

tough imp Apr 14, 2021, 9:40 AM

#

short snow A tz-naive object is a object which is timezone unaware right?

yes correct, a naive datetime instance is ambiguous and open to interpretation; it doesnt point to any specific point in time

#

datetime specifically deals with naive instances as if they were local time

short snow Apr 14, 2021, 9:41 AM

#

yeah i read that, it was mentioned in your pr description, but like it said you can specify the timezone to be UTC, that won't take it to be naive

tough imp Apr 14, 2021, 9:42 AM

#

you can, but I find the code to be ugly ~ arrow makes tz-aware objects by default, which I like

#

we've also started using arrow for this reason elsewhere

#

as the descr explains 😄

short snow Apr 14, 2021, 9:42 AM

#

ah ok, that was my question

#

thanks

vale ibex Apr 14, 2021, 9:42 AM

#

tough imp we've also started using arrow for this reason elsewhere

Like in the help channel cog, much easier to work with

tough imp Apr 14, 2021, 9:42 AM

#

by the way, datetime.utcfromtimestamp sucks

#

it creates a naive timestamp again

#

I don't fully understand why ~ you're basically creating an unusable object, because the library itself will misinterpret it

vale ibex Apr 14, 2021, 9:43 AM

#

Yea, it assumes the time stamp given to it is in local time

#

so tries to compensate it to utc

short snow Apr 14, 2021, 9:43 AM

#

uhh, it says utcfrom in the functino name tho

tough imp Apr 14, 2021, 9:43 AM

#

yes, it won't convert the timestamp to local time

#

but the object won't know that it's in UTC

#

so the library itself will understand it to be local time

#

explained in the warning here: https://docs.python.org/3/library/datetime.html#datetime.datetime.utcfromtimestamp

short snow Apr 14, 2021, 9:44 AM

#

oh

tough imp Apr 14, 2021, 9:44 AM

#

simply using utcfromtimestamp is not enough

#

you need to specify the tz manually

#

which makes no sense to me as a user, I'm already saying it's utc

#

arrow does not behave like this, both utcnow and utcfromtimestamp will produce aware objects

#

which makes more sense to me

short snow Apr 14, 2021, 9:46 AM

#

yeah, arrow makes it simpler and clear

tough imp Apr 14, 2021, 9:47 AM

#

yea so while datetime does support tz-aware objects, I find the API cumbersome in that case

#

I don't know whether it necessarily justifies adding a dependency, but since we already adopted it elsewhere, I decided to do the same

#

because it makes tz-aware objects by default, there's less risk that someone else will make the same error as I did later on

#

although at least comparing a naive and aware object raises an exception

short snow Apr 14, 2021, 9:50 AM

#

right, seems much clear now, thanks!

#

yes, it won't convert the timestamp to local time
but the object won't know that it's in UTC

If this is a known bug, why don't the maintainers fix it?

tough imp Apr 14, 2021, 9:51 AM

#

it's probably not a bug

#

it's documented behaviour

#

I just find it unexpected that utcnow().timestamp() does not work at all

#

it seems intuitive to me

short snow Apr 14, 2021, 9:52 AM

#

hmm, i will need to look into does.

tough imp Apr 14, 2021, 9:54 AM

#

afaik some parts of the stdlib mimic the behaviour of Java libraries, so maybe they wanted it to behave the same way

#

or maybe the way it behaves makes perfect sense and I'm just missing something

short snow Apr 14, 2021, 10:02 AM

#

https://blog.ganssle.io/articles/2019/11/utcnow.html found this while i was looking around

Paul Ganssle

Paul Ganssle - Stop using utcnow and utcfromtimestamp

A public service announcement about the dangers of utcnow and utcfromtimestamp and the benefits of using their replacements.

vocal prairie Apr 14, 2021, 12:13 PM

#

short snow <@!506618674921340958> <@!788119126450765844> i divided the dependencies here: h...

That works, I'll try to work on some today.

short snow Apr 14, 2021, 12:36 PM

#

sure no worries, you can do it at your own pace

sleek steppe Apr 14, 2021, 2:07 PM

#

thonk

short snow Apr 14, 2021, 2:14 PM

#

whoops copied it twice

#

updated it

sleek steppe Apr 14, 2021, 2:18 PM

#

Are we trying to upgrade everything that isn't upgraded?

short snow Apr 14, 2021, 2:19 PM

#

kind of, since on updating packages, they get support for python3.9

#

like if we upgrade to python3.9, but don't upgrade discord.py from 1.5, it won't have python3.9 support

sleek steppe Apr 14, 2021, 2:32 PM

#

Do we even use aiodns? Github code search shows nothing

tawdry vapor Apr 14, 2021, 2:33 PM

#

Should be using it, yes

#

Considering the code was ported from the bot

#

And I know for a fact that does use it

patent pivot Apr 14, 2021, 2:34 PM

#

Pretty sure it's a use if present thing under the hood of aiohttp

#

I forget though

short snow Apr 14, 2021, 2:34 PM

#

lemme see one minute

#

grep helps

tawdry vapor Apr 14, 2021, 2:35 PM

#

No it isn't. It has to be manually configured as far as i know

patent pivot Apr 14, 2021, 2:35 PM

#

It isn't used in the code base

#

Hm

tawdry vapor Apr 14, 2021, 2:35 PM

#

That's how the docs show it

#

I know where to look so I guess I'll quickly find the use for you

patent pivot Apr 14, 2021, 2:36 PM

#

Changed in version 1.0

#

Changed in version 1.0: The resolver is aiohttp.AsyncResolver now if aiodns is installed.

tawdry vapor Apr 14, 2021, 2:36 PM

#

https://www.github.com/python-discord/sir-lancebot/tree/main/bot%2Fbot.py

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

#

Line 33

patent pivot Apr 14, 2021, 2:36 PM

#

aha, nice

short snow Apr 14, 2021, 2:38 PM

#

@sleek steppe should i implement the rest of the typing changes with co authoring you, or you will open a pr from your branch?

tawdry vapor Apr 14, 2021, 2:39 PM

#

patent pivot >>> Changed in version 1.0: The resolver is aiohttp.AsyncResolver now if aiodns ...

Oops. It's sort of documented at the very beginning of the docs ironically but I only ever searched the api reference which leads to a manual example

#

Never explicitly says anywhere (besides the change log I suppose) that it will automatically use it. That's annoying

short snow Apr 14, 2021, 2:40 PM

#

maybe we could add a comment in the pipfile to say where it is used

green oriole Apr 14, 2021, 2:40 PM

#

That should be an optional dependency on aiohttp lemon_pensive

patent pivot Apr 14, 2021, 2:40 PM

#

if it's used in the code that's fine

#

it is

#

pip install aiohttp[speedups]

green oriole Apr 14, 2021, 2:41 PM

#

Oh nice

#

Is that what we are doing though?

#

Nope

#

We should do that tbh

#

aiohttp should be a dependency of our code

sleek steppe Apr 14, 2021, 2:47 PM

#

short snow <@!506618674921340958> should i implement the rest of the typing changes with co...

I can do that now

short snow Apr 14, 2021, 2:48 PM

#

Sure go ahead then, just squash down to the important commits

tawdry vapor Apr 14, 2021, 2:48 PM

#

I question if that still works

#

https://github.com/aio-libs/aiohttp/blob/v3.7.4/aiohttp/resolver.py#L149

GitHub

aio-libs/aiohttp

Asynchronous HTTP client/server framework for asyncio and Python - aio-libs/aiohttp

#

The Boolean is always false with the line potentially setting it to true commented out above

#

I'm on mobile so I'm boot able to check if it gets set elsewhere

#

https://github.com/aio-libs/aiohttp/issues/559

GitHub

aiohttp client does not support ipv6 addresses · Issue #559 · aio-l...

attempting to get a webpage from an ipv6 address doesnt appear to work in aiohttp 0.17.4 when i run the ipv6 address through curl it works. i also tried the ipv4 address through the aiohttp client ...

#

Yeah it's disabled by default

patent pivot Apr 14, 2021, 2:52 PM

#

aha

placid ermine Apr 14, 2021, 2:59 PM

#

okay

#

after 1 day of researching I have found no way where the latex works without a manual gc.collect

tawdry vapor Apr 14, 2021, 3:06 PM

#

What's the context for this?

brazen charm Apr 14, 2021, 3:07 PM

#

does the bot reach memory limits if it waits for the gc to do it itself?

placid ermine Apr 14, 2021, 3:09 PM

#

Yeah

green oriole Apr 14, 2021, 3:10 PM

#

Hmmmmm

#

Isn't CPython supposed to call the GC when the memory limit is reached?

placid ermine Apr 14, 2021, 3:11 PM

#

tawdry vapor What's the context for this?

The latex command was bugged, every time there's invalid input the memory usage increases and doesn't come down
ultimately causes bot to exceed memory limits and restart

tawdry vapor Apr 14, 2021, 3:11 PM

#

Is it running in a thread or process executor

sleek steppe Apr 14, 2021, 3:12 PM

#

thread

placid ermine Apr 14, 2021, 3:12 PM

#

yeah

tawdry vapor Apr 14, 2021, 3:12 PM

#

Have you tried process

placid ermine Apr 14, 2021, 3:12 PM

#

yes, and i got hit by a huge error

#

i redirected the stderr to a file, the file is 21.3 MB

#

lol

tawdry vapor Apr 14, 2021, 3:13 PM

#

No idea what that could be

#

Anyway, using an actual latex install instead of matplotlib may still be viable, if you're desperate for solutions.

#

They can actually be pretty small and quick (like maybe 10 MB, most of which would be fonts) - it's just that the popular distributions aren't

vale ibex Apr 14, 2021, 3:15 PM

#

Scale was working on changing it to multiprocessing and limiting the spawned process's memory

brazen charm Apr 14, 2021, 3:16 PM

#

Nothing really wrong with calling it yourself imo if it works properly for large inputs without complicating it through limited processes. the allocation thresholds could also be adjusted but that's a larger impact

placid ermine Apr 14, 2021, 3:18 PM

#

so uh
bug fixed?

#

interesting

brazen charm Apr 14, 2021, 3:23 PM

#

Running it in a separate process will let the os take care of it, but if there are problems with that's I don't think it's really necessary if the manual call does everything properly

placid ermine Apr 14, 2021, 3:24 PM

#

Okay so I started going through the large error and this is what it boils down to:

PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'E:\\Python Projects\\Sir Lancebot\\sir-lancebot\\bot\\log\\hackbot.log' -> 'E:\\Python Projects\\Sir Lancebot\\sir-lancebot\\bot\\log\\hackbot.log.1'

gritty wind Apr 14, 2021, 3:24 PM

#

The manual call can do everything properly - and still error (presuming you stick with matplotlib). What happens if you pass in an input long or complex enough where you simply need more ram. No optimizations can basically beat the numbers game

#

How are you forking it

placid ermine Apr 14, 2021, 3:25 PM

#

how am i what

#

I just run it in a ProcessPoolExecutor

gritty wind Apr 14, 2021, 3:26 PM

#

How are you making the new process

brazen charm Apr 14, 2021, 3:26 PM

#

I assume there's no reasonable way to limit the expressions passed to it?

placid ermine Apr 14, 2021, 3:27 PM

#

I doubt it

gritty wind Apr 14, 2021, 3:27 PM

#

You can limit length - not so much for complexity

placid ermine Apr 14, 2021, 3:27 PM

#

gritty wind How are you making the new process

with ProcessPoolExecutor() as pool:
  image = await asyncio.get_running_loop().run_in_executor(
    pool, self._render, text, image_path
  )

#

However
I don't think matplotlib's tex allows much complexity any way

tawdry vapor Apr 14, 2021, 3:33 PM

#

If it's a separate process then it may be possible to use cgroups to limit resource usage, if that is the concern.

gritty wind Apr 14, 2021, 3:34 PM

#

I got it more or less working with the resource library

#

Though just the process takes up quite a bit of ram on its own

brazen charm Apr 14, 2021, 3:36 PM

#

Does resource work on win?

woven sand Apr 14, 2021, 3:38 PM

#

ht

#

ther

placid ermine Apr 14, 2021, 3:38 PM

#

<@&267629731250176001>

trim cradle Apr 14, 2021, 3:38 PM

#

You can learn about Python py_strong

green oriole Apr 14, 2021, 3:38 PM

#

Hello here

tawdry vapor Apr 14, 2021, 3:38 PM

#

Are you just spamming to get voice verified?

#

Yes

#

Please don't

trim cradle Apr 14, 2021, 3:39 PM

#

Alright then

#

!tvban 803721494139502632 "2 weeks" Spamming is no way to get voice verified.

stable mountainBOT Apr 14, 2021, 3:39 PM

#

:incoming_envelope: :ok_hand: applied voice ban to @woven sand until 2021-04-28 15:39 (13 days and 23 hours).

tawdry vapor Apr 14, 2021, 3:40 PM

#

brazen charm Does resource work on win?

Dunno but it seems very linux-y to me based on naming conventions. Windows support isn't important as long as its use can be disabled to avoid outright crashing on Windows

mellow hare Apr 14, 2021, 3:43 PM

#

If it's to be used within a docker container, I'm comfortable with that

gritty wind Apr 14, 2021, 3:44 PM

#

Resource doesn't work on windows, but I handled it like:
if (has-resource) or (doesn't have resource && debug): add cog
else: don't add cog

#

I figure no one is hosting prod on windows yet

tawdry vapor Apr 14, 2021, 3:45 PM

#

I don't think we should be putting much consideration into the production needs of others.

gritty wind Apr 14, 2021, 3:45 PM

#

yeah

tawdry vapor Apr 14, 2021, 3:45 PM

#

As long as development/contribution is feasible cross platform, that's good enough

#

And if a few things don't work that's okay

placid ermine Apr 14, 2021, 3:52 PM

#

@gritty wind since you're working on this, can I stop my fruitless researches then?

gritty wind Apr 14, 2021, 3:53 PM

#

Processes?

placid ermine Apr 14, 2021, 3:53 PM

#

latex fix

gritty wind Apr 14, 2021, 3:53 PM

#

If you'd like to still work on it, I have to get some other important things done first

#

otherwise, yeah I'll do it

placid ermine Apr 14, 2021, 3:53 PM

#

gritty wind otherwise, yeah I'll do it

that'd be great

vocal prairie Apr 14, 2021, 5:16 PM

#

@cold island Just curious, allowing mods to go off duty would be good so that they wouldn't get pinged while they aren't on Discord, right?

fallen patrol Apr 14, 2021, 5:18 PM

#

si

#

they would still keep the helper role

#

and they would still be hosted in the right

#

just not under moderators

#

it would either be mod-team or helpers

gritty wind Apr 14, 2021, 5:20 PM

#

They will still be hoisted in the mods section

#

Both roles will exist

vocal prairie Apr 14, 2021, 5:21 PM

#

Ohhhh

#

So there are two mod roles

#

One is a hoist with the perms

#

The other is for pinging

#

Right?

gritty wind Apr 14, 2021, 5:21 PM

#

more or less

vale ibex Apr 14, 2021, 5:25 PM

#

vocal prairie So there are two mod roles

Yea, you may notice that that part is already live 😄

vocal prairie Apr 14, 2021, 5:25 PM

#

That's cool

fallen patrol Apr 14, 2021, 5:26 PM

#

vale ibex Yea, you may notice that that part is already live 😄

pls, have someone rename it

gritty wind Apr 14, 2021, 5:27 PM

#

why?

vocal prairie Apr 14, 2021, 5:27 PM

#

Wdym rename?

fallen patrol Apr 14, 2021, 5:27 PM

#

        moderators:         &MODS_ROLE      831776746206265384
        mod_team:           &MOD_TEAM_ROLE  267629731250176001

cold island Apr 14, 2021, 5:27 PM

#

the names are final yet. Shouldn't matter for now when trying to ping mods

fallen patrol Apr 14, 2021, 5:27 PM

#

calls them mod role and mod team role

gritty wind Apr 14, 2021, 5:27 PM

#

The naming in the code can be different to show intentions

#

Ultimately, the role you ping will always be moderators

fallen patrol Apr 14, 2021, 5:28 PM

#

but it is weird to have them the same in client

gritty wind Apr 14, 2021, 5:28 PM

#

It also makes the most sense that the pingable role will be the one users can see in the sidebar

gritty wind Apr 14, 2021, 5:28 PM

#

fallen patrol but it is weird to have them the same in client

Is it? They serve the same purpose, and for most users, there's only one way to interact with them

#

like Zig said, this isn't final

#

But I much prefer it this way

fallen patrol Apr 14, 2021, 5:29 PM

#

gritty wind like Zig said, this isn't final

the names are final yet

#

are

gritty wind Apr 14, 2021, 5:29 PM

#

that's a typo I'm pretty sure

fallen patrol Apr 14, 2021, 5:29 PM

#

oh

gritty wind Apr 14, 2021, 5:29 PM

#

@cold island ?

cold island Apr 14, 2021, 5:29 PM

#

yes lol it's a typo

fallen patrol Apr 14, 2021, 5:30 PM

#

imo it looks really really weird when looking at a mods roles

gritty wind Apr 14, 2021, 5:30 PM

#

I still don't get why

fallen patrol Apr 14, 2021, 5:30 PM

#

vocal prairie Apr 14, 2021, 5:30 PM

#

It's the best option anyway.

fallen patrol Apr 14, 2021, 5:30 PM

#

it would be nice to see which role is which

gritty wind Apr 14, 2021, 5:30 PM

#

tbh that looks fine to me

#

There is no real reason to be able to make the distinction

#

It'll be pretty clear anyways because they either have 2 roles or 1

vocal prairie Apr 14, 2021, 5:31 PM

#

In your own test server, it would take two minutes to change if you want.

cold island Apr 14, 2021, 5:31 PM

#

we're just setting things up, I really don't see why it's important to be figured out now

vocal prairie Apr 14, 2021, 5:31 PM

#

Just recolor one role if you want

fallen patrol Apr 14, 2021, 5:31 PM

#

imo there is a pretty good reason to make a distinction

cold moon Apr 14, 2021, 5:31 PM

#

This is weird. Maybe first should be Active Mods or second Mods Team?

cold island Apr 14, 2021, 5:31 PM

#

Like I said.

#

We're just setting things up.

fallen patrol Apr 14, 2021, 5:32 PM

#

if you're going off duty, being the same as the other mods is gonna get you about as many pings as when ppl look to the list and ping a mod for help with their code

gritty wind Apr 14, 2021, 5:32 PM

#

The moderators name will stay in at least 1, so users can still ping them
& in my opinion it makes the most sense that the role visible in the side bar, is the role you are used to pinging

vocal prairie Apr 14, 2021, 5:32 PM

#

But they can only ping one role?

gritty wind Apr 14, 2021, 5:32 PM

#

And people don't ping individual mods often, when they do, we tell them not to

fallen patrol Apr 14, 2021, 5:32 PM

#

i would either host them separately or make them different colors

fallen patrol Apr 14, 2021, 5:32 PM

#

gritty wind The `moderators` name will stay in at least 1, so users can still ping them & in...

the sidebar could say Mod Team

gritty wind Apr 14, 2021, 5:33 PM

#

but you can't ping mod team

#

you can only ping mods

vocal prairie Apr 14, 2021, 5:33 PM

#

It isn't final. So why does it matter now?

#

And it's actually clearer if there are two roles with the same name.

#

Because if one role is named one thing, and then somebody goes to ping it and it isn't available, that could cause confusion.

fallen patrol Apr 14, 2021, 5:42 PM

#

vcokltfre/tutorial#1 vcokltfre/tutorial#2 vcokltfre/tutorial#3 vcokltfre/tutorial#4 vcokltfre/tutorial#5 vcokltfre/tutorial#6 vcokltfre/tutorial#7 vcokltfre/tutorial#8 vcokltfre/tutorial#9 vcokltfre/tutorial#10 vcokltfre/tutorial#11 vcokltfre/tutorial#12 vcokltfre/tutorial#13 vcokltfre/tutorial#14 vcokltfre/tutorial#15 vcokltfre/tutorial#16

#

imo there shouldn't even be an error message, or just the first 5 and then say only 5

fervent sage Apr 14, 2021, 5:53 PM

#

as a side note i think now that we allow linking of any org/repo we should probably prefix the links with where they come from, like

:prmerged: vcokltfre/tutorial#1 - feat: mention tokens tip in index and below codeblocks

vocal prairie Apr 14, 2021, 5:54 PM

#

I think we should do that if at least one of them isn't from us.

#

If they're all from PyDis, then i don't think it matters

#

Or at least from the same PyDis repo.

fallen patrol Apr 14, 2021, 5:54 PM

#

at at minimum prefix them with which repo in all cases

vocal prairie Apr 14, 2021, 5:54 PM

#

Or, if it's all from the same repo: GitHub - vcokltfre/tutorial in the title maybe

fallen patrol Apr 14, 2021, 5:56 PM

#

this is how it used to be

fallen patrol Apr 14, 2021, 6:57 PM

#

Lmfao

#

.latex $lancebot.do(crash)$$

#

FYI @gritty wind rn it crashes after about 7 uses

#

Because memory leak

#

Idk about the new pr but the current implementation does

gritty wind Apr 14, 2021, 6:58 PM

#

what are you talking about? No such command exists

#

lol thanks

fallen patrol Apr 14, 2021, 6:59 PM

#

gritty wind what are you talking about? No such command exists

Latex

gritty wind Apr 14, 2021, 6:59 PM

#

.help latex

dusky shoreBOT Apr 14, 2021, 6:59 PM

#

Query "latex" not found.

fallen patrol Apr 14, 2021, 6:59 PM

#

Lol u unloaded it

gritty wind Apr 14, 2021, 7:18 PM

#

@vale ibex It's currently using the input hash yeah

vale ibex Apr 14, 2021, 7:19 PM

#

So @gritty wind summary so far, latex cog checks local cache for a file with the same hash as the args, if it doesn't exist, spawn a subprocess, passing the latex args as command line args

#

then within the subprocess we generate the file, and save it with the hash

#

then within the cog itself read the file and ctx.send

#

with the subprocess being limited & set with a high nice value

fallen patrol Apr 14, 2021, 7:28 PM

#

vale ibex So <@!386599446571384843> summary so far, latex cog checks local cache for a fil...

small thing there

#

if its identical to the last time and threw an error, cache the error as well?

green oriole Apr 14, 2021, 7:32 PM

#

Sounds about right

vale ibex Apr 14, 2021, 7:34 PM

#

fallen patrol if its identical to the last time and threw an error, cache the error as well?

yea we could do

gritty wind Apr 14, 2021, 8:52 PM

#

I'm not sure if I'm going crazy or what

#

but the resource library seems to not know what bytes are

#

apparently need to dedicate like ~~a GB~~ 400mb to the subprocess to get a basic 4 letter word to process

#

something is definitely wrong

vocal prairie Apr 14, 2021, 9:47 PM

#

We only use internal bots.

cold island Apr 14, 2021, 10:07 PM

#

What does it do?

tough imp Apr 14, 2021, 10:10 PM

#

texes it 🤡

fervent sage Apr 14, 2021, 10:10 PM

#

it would also be possible to run https://github.com/chialab/math-api internally as a microservice and just make api queries to it for images right?

GitHub

chialab/math-api

Serverless API to render maths using MathJax for Node. - chialab/math-api

clever wraith Apr 14, 2021, 10:10 PM

#

is it allowed for anyone to contribute to bots in this server?

fervent sage Apr 14, 2021, 10:10 PM

#

yep

clever wraith Apr 14, 2021, 10:11 PM

#

is there a list of things that you guys want? like features or some

fervent sage Apr 14, 2021, 10:12 PM

#

there's the issues tab on the bot repos which have some feature/bugfix/etc. suggestions, some of which i believe arent claimed, you can also make your own issue if you want to implementa a feature

clever wraith Apr 14, 2021, 10:12 PM

#

ok

fallen patrol Apr 14, 2021, 10:13 PM

#

fervent sage it would also be possible to run https://github.com/chialab/math-api internally ...

but

#ot0-psvm’s-eternal-disapproval message

#

not impossible to set up

#

okay so

gritty wind Apr 14, 2021, 10:14 PM

#

that was specifically about a carbon.now.sh api

#

but its similar enough

fallen patrol Apr 14, 2021, 10:14 PM

#

how did you guys make latex not load every start

gritty wind Apr 14, 2021, 10:15 PM

#

wdym?

fallen patrol Apr 14, 2021, 10:15 PM

#

or is someone actually unloading it every reconnect

#

oh

gritty wind Apr 14, 2021, 10:15 PM

#

it's only been unloaded twice

fallen patrol Apr 14, 2021, 10:15 PM

#

the bot hasn't reconnected since yeah

gritty wind Apr 14, 2021, 10:15 PM

#

.help latex

dusky shoreBOT Apr 14, 2021, 10:15 PM

#

Query "latex" not found.

gritty wind Apr 14, 2021, 10:15 PM

#

it has not

fallen patrol Apr 14, 2021, 10:15 PM

#

someone add lancebot․do⟮crash⟯ to otn smh

fallen patrol Apr 14, 2021, 10:31 PM

#

nope just gotta ask staff for them

#

although

#

it'd be nice for the bot to have a command just for that lmao

gritty wind Apr 14, 2021, 10:32 PM

#

You don't really need more than one emoji

fallen patrol Apr 14, 2021, 10:32 PM

#

btw you can right click

gritty wind Apr 14, 2021, 10:32 PM

#

treashcan

fallen patrol Apr 14, 2021, 10:32 PM

#

trash

gritty wind Apr 14, 2021, 10:32 PM

#

or just any random image you have on your PC

fallen patrol Apr 14, 2021, 10:32 PM

#

#

ah that sucks

#

get better soon

gritty wind Apr 14, 2021, 10:33 PM

#

yes, if embeds are enabled

#

yes

sleek steppe Apr 14, 2021, 10:35 PM

#

.help emoji

#

Ah right I was gonna make a pr for this command

fallen patrol Apr 14, 2021, 10:36 PM

#

.enoji

#

.emoji

sleek steppe Apr 14, 2021, 10:36 PM

#

But my fork is deleted

fallen patrol Apr 14, 2021, 10:36 PM

#

smh

cold island Apr 14, 2021, 10:42 PM

#

.emoji

dusky shoreBOT Apr 14, 2021, 10:42 PM

#

Command Help

.emoji <emoji>
A group of commands related to emojis.

Subcommands:
count [category_query]
Returns embed with emoji category and info given by the user.
info <emoji>
Returns relevant information about a Discord Emoji.

sleek steppe Apr 14, 2021, 10:45 PM

#

Can you PR from a fork of a fork lol

#

Yeah that won't work

#

Guess I'll wait

vale ibex Apr 14, 2021, 10:48 PM

#

Change origin to the main repo

#

Upstream I mean

sleek steppe Apr 14, 2021, 10:49 PM

#

Hmm maybe

git switch -c branch_name --track upstream/main
git commit ...
git push origin branch_name

vocal prairie Apr 14, 2021, 10:49 PM

#

You can still get the id I think.

#

And then pull it from the cdn.

gritty wind Apr 14, 2021, 10:50 PM

#

(you can also all collaborate on the fork if that's your thing)

sleek steppe Apr 14, 2021, 10:52 PM

#

https://cdn.discordapp.com/emojis/{id}

fallen patrol Apr 14, 2021, 11:02 PM

#

bot_commands: &BOT_CMD 267659945086812160

#

what does the &BOT_CMD mean in the config file?

#

since not everything has that

gritty wind Apr 14, 2021, 11:03 PM

#

It's a variable

#

You can reference BOT_CMD later

#

if you dig through, you can find how it's used in other parts

#

If I wasn't lazy, I'd open up my config and point out certain ones

fallen patrol Apr 14, 2021, 11:04 PM

#

so like

gritty wind Apr 14, 2021, 11:04 PM

#

Here are some examples:
https://github.com/python-discord/bot/blob/main/config-default.yml#L225

fallen patrol Apr 14, 2021, 11:04 PM

#

from constants import BOT_CMD?

gritty wind Apr 14, 2021, 11:05 PM

#

These are more variables for the yaml file

fallen patrol Apr 14, 2021, 11:05 PM

#

ohhh

#

so it ok

#

that makes sense and is cool lol

#

and what does token: !ENV "BOT_TOKEN" do?

#

since its a !

#

not a &

gritty wind Apr 14, 2021, 11:06 PM

#

pull it from the environment variables

fallen patrol Apr 14, 2021, 11:06 PM

#

wtf that's

#

i-

gritty wind Apr 14, 2021, 11:06 PM

#

the equivalent of os.environ.get

fallen patrol Apr 14, 2021, 11:06 PM

#

my config system is now dead on my bot tyvm

gritty wind Apr 14, 2021, 11:06 PM

#

I'm pretty sure this is using a custom parser

fallen patrol Apr 14, 2021, 11:07 PM

#

Meh

#

I'll borrow it

gritty wind Apr 14, 2021, 11:07 PM

#

Basically this entire section
https://github.com/python-discord/bot/blob/main/bot/constants.py#L25-L192

#

I don't know why we use yaml lol, but I don't care enough to question it

#

it works

sleek steppe Apr 14, 2021, 11:12 PM

#

@short snow when can you review the PR? I want to delete this fork lol

sullen phoenix Apr 14, 2021, 11:20 PM

#

gritty wind I don't know why we use yaml lol, but I don't care enough to question it

the beautiful config format of devops™️

tough imp Apr 14, 2021, 11:55 PM

#

gritty wind I don't know why we use yaml lol, but I don't care enough to question it

what would you use instead?

gritty wind Apr 14, 2021, 11:55 PM

#

I'm a bit mad and just put everything in good ol' python

#

I mean, we basically do

tough imp Apr 14, 2021, 11:56 PM

#

I dont like yaml but I'm not aware of anything better sadclown

#

using yaml allows you to dynamically load attributes from multiple files

#

that could be awkward with python source code

patent pivot Apr 14, 2021, 11:58 PM

#

I've had some joy using TOML recently

gritty wind Apr 14, 2021, 11:58 PM

#

Possibly, but mind you I'm usually not configuring 300 constants

#

Have used JSON in the past

#

that was fun

tough imp Apr 14, 2021, 11:58 PM

#

but I think there are some significant advantages to keeping most constants in source code, eg that your editor can actually guide you to the definition

#

vanilla json doesnt have comments

tough imp Apr 15, 2021, 12:01 AM

#

patent pivot I've had some joy using TOML recently

I think toml is ugly lol but I've never seriously used it

patent pivot Apr 15, 2021, 12:01 AM

#

the area where toml fails is lists