quackstack#32
#dev-contrib
short snow
Approve akarys pr, and you can get it here
green oriole
lol
fallen patrol
functionality should return either when akarys pr is merged or in about 30 minutes for quackstack
green oriole
Yeah, it will be fixed by sir-lancebot#642
fallen patrol
basically when it refreshes the repo list, 6 repos get left out
sleek steppe
oh right I forgot it didn't get merged to main
green oriole
Actually we also need https://github.com/python-discord/sir-lancebot/pull/665 to be fixed
fervent sage
one day
green oriole
That's another blocker
fervent sage
one day i'll type docker-compose not compsoe
gritty wind
or alias it and dw about it 👀
fallen patrol
one day i'll type docker-compose not compsoe
short snow
Bash aliases
fallen patrol
zsh
fervent sage
i would make an alias
sleek steppe
That's another blocker
Do I need to resolve the conflicts?
fervent sage
but then i have no incentive to fix my typing
fallen patrol
but then i have no incentive to fix my typing
ture that
fervent sage
idk if that was intentional but 10/10
green oriole
Do I need to resolve the conflicts?
If you could that'd be perfect
I can do it otherwise
vocal prairie
but then i have no incentive to fix my typing
Tpye like so much that your computer understands it. It worked for me.
fervent sage
@short snow ive checked out the code on your colors branch and the server error when saving the duck seems to have been reintroduced
vale ibex
uh is this a bug with `.savatar`
there's a few random effects, one of which is to overlay some bats in the top right
since the bats are black, it's probably being hidden
gritty wind
haha that's hilarious
sleek steppe
If you could that'd be perfect
yeah I can do it
fallen patrol
there's a few random effects, one of which is to overlay some bats in the top ri...
smh
lets add image color detection to see if the top is dark or bright 😄
fallen patrol
if i was serious I wouldn't have put the 😄
vale ibex
If anyone wants to put a white outline on this feel free
fervent sage
<@!736234578745884682> ive checked out the code on your colors branch and the se...
also ignore this, have pushed the fix for it myself
vale ibex
I'll add it to my PR for pfp modifiers
fervent sage
also ignore this, have pushed the fix for it myself
also i suck at git and realise how stupid i am lol
fallen patrol
also i suck at git and realise how stupid i am lol
yeah understandable i heard
green oriole
yeah I can do it
Cool, thanks!
sleek steppe
@green oriole conflicts resolved
green oriole
Sweet, thanks!
sleek steppe
Wait I forgot to remove a comment
green oriole
lol yes
thorny obsidian
Okaaaay, I think I have int e for Lancebot working, but I'm not well versed enough to test the features. @hardy gorge if you're around, do you wanna hop into my test server and see if I'm made the proper changes?
sleek steppe
@green oriole I changed the comment btw
thorny obsidian
This invitation extends to others who are comfortable with our int e command and would like to test it but also don't want to break my test bot
hardy gorge
I'm not around at the moment. I can test it tomorrow, though. In about 13 hours or so.
vocal prairie
What is int e?
gritty wind
!src internal
stable mountainBOT
vocal prairie
Ty!
gritty wind
line 218 there
vocal prairie
I see it now. Ty
vale ibex
Ak's PR has now had 2 PRs into it 😂
thorny obsidian
Let's us do things like this:
vocal prairie
That's cool!
sleek steppe
what's that second role 👀
thorny obsidian
!remind 3H check out the poetry set-up and test it against pipenvs
stable mountainBOT
gritty wind
what's that second role 👀
Tomatoes
thorny obsidian
haha, one for something else I'm involved with that has a name I don't want shared publically
An old integration I forgot to remove really
clever wraith
This invitation extends to others who are comfortable with our int e command and...
So how could int e break the bot?
vocal prairie
Since someone could run a command that directly takes down the bot or smth
Since int e isn't through snekbox
gritty wind
It's locked to admins
clever wraith
It's locked to admins
I guessed as much
thorny obsidian
Internal eval accesses the bots internals directly, so you could theoretically nuke a server with it depending on the bots perms
gritty wind
So yes, an admin can technically mess with things
though the hosting server itself doesn't matter that much, the pod will just die and redeploy
bigger issue is messing with the discord server, or the environment secrets
clever wraith
bigger issue is messing with the discord server, or the environment secrets
Yeah someone could leak the tokens
Which would be bad, and illegal I think
gritty wind
Illegal in what way?
clever wraith
I'm not sure, I assumed it might be considered cybercrime
fallen patrol
!src internal
!src int e
stable mountainBOT
fallen patrol
it gets sub commands lel
sleek steppe
yea
stable mountainBOT
@thorny obsidian
It has arrived!
fallen patrol
Sigh
!remind 4d if the docs command still looks bad because discord changed markdown on mobile talk about making an issue.
stable mountainBOT
gritty wind
is this before or after the rework?
gritty wind
so before
the rework is in a PR atm
it's still
in development
it fixes some issues
fallen patrol
Note: they changed markdown in like the last few updates of discord
sleek steppe
How did they change it?
fallen patrol
Send a screen shot of the docs embed
sleek steppe
fallen patrol
gritty wind
ah, android
fallen patrol
Used to have a blue title with visible ``
Now it has a `` title with no link
It's still clickable
gritty wind
android is a clusterfuck
gritty wind
!mute @gritty wind 12H good night
fallen patrol
Did @stable mountain even say anything
stable mountainBOT
IDK, muted Scaleios I guess, I'm tried
fervent sage
tried lol
fallen patrol
Smh
Oh I just realized it's impossible for some commands to become slash commands
At least with current api
vocal prairie
Why?
vocal prairie
Do you need one?
fallen patrol
Snekbox
vocal prairie
Oh, yeah, not for that.
patent pivot
It's impossible to have a new line in an argument
limitation of the editor they use for slash commands UI, but might work with UI components so
we'll see
but this seems like a problem we can work around
but again, we'll wait for them to reach a more GA state
thorny obsidian
Alright, I think I'm ready to PR this
short snow
<@!736234578745884682> ive checked out the code on your colors branch and the se...
i know about that, I purposely waited for that, when the PR was opeend yours wasn't merged so I didn't keep it either, I was waiting for it to get merged and then do rebase into mine, will do that in sometime
short snow
also ignore this, have pushed the fix for it myself
ok cool!
fervent sage
yea it would have worked when merged anyway i'm just a bit of a moron with git sometimes 
it should still work /shrug so no harm i guess
short snow
lol ok, I will leave it
the 10th time am getting this, konifer's commit and when someone merges the main into their fork's main
magic arch
Maybe round the time at the bottom to a few digits?
short snow
dunno, i like to be precise
magic arch
Up to you I suppose 
fallen patrol
after lot of different stuff, this is the best i could get
I uh thought @placid ermine was writing that.
patent pivot
We've touched on the idea internally, no issue specified though
placid ermine
after lot of different stuff, this is the best i could get
timing it seems a good idea
i'm not so sure about the embed
placid ermine
would love a second opinion on this too
tawdry vapor
I don't think a time is useful to most users. It's just gonna be a distraction for readers.
The embed therefore loses purpose and just ends up unnecessarily bulking up the message
fervent sage
eh i like it - it's not that big, gives some insight into how long it took, and is an interesting technical detail, which is nice in a technical community imo
tawdry vapor
I wouldn't care if the stat was hidden but Discord doesn't provide us with a way to do that
I firmly believe that displaying the execution time is just bloat.
fervent sage
i mean by extension so is the whole latex rendering command. is it actually needed for the server? nah, but it's interesting and a cool feature, the time is the same - it's an interesting technical detail
tawdry vapor
That's such a stretch I'm not sure why you're even trying to make that argument.
fervent sage
its not?
tawdry vapor
The usefulness of rendering latex is far larger compared to the usefulness of seeing the rendering time
fervent sage
sir-lancebot is a bot that provides extra utilities that are not technically needed to operate the server, and by all means they're cool and make the community better, so why is another technical detail in a technical community bad?
tawdry vapor
Because this is an actually useful feature and not just a game or something for fun. So we should be mindful of readability rather than coming in with the mindset of throwing cool trinkets onto it.
fervent sage
but having a small string saying how long it took doesn't decrease readability
tawdry vapor
Maybe readability isn't the perfect term, but I disagree. like I said, it's just a distraction from the actual intent of the message being communicated by the person invoking the command.
fervent sage
i'd agree if this were some random non-technical server, but in a server full of technical people i just cant understand why a technical detail would be a bad thing
its another piece of interesting information which adds onto the command and just gives a little more insight into what it took
tawdry vapor
It's a distraction just like I said. It would be in any context, including a technical server. Exception being when you want to actually benchmark it for some reason.
fervent sage
i disagree but i see this is a pointless argument ¯_(ツ)_/¯
patent pivot
My thoughts:
– How much does that value fluctuate, it's probably either going to be very short or very long (examples I've seen are 0.2s-2s), and in the longer cases you probably know that because the command takes a bit to respond.
– We should definitely be caching the responses from latex if it is a task which takes multiple seconds, probably in a volatile cache that stores the last X queries. Generation time does not make sense in that context.
– If we do decide to include it we certainly need to trim down that floating point, 0.23289893932s and similar is just annoying, 2 decimal places maximum.
tawdry vapor
It's not even an interesting detail IMO because it's not like one would expect this to take a long time to render. It's more interesting when something does (or is perceived to) take a long time.
fallen patrol
i mean by extension so is the whole latex rendering command. is it actually need...
the pypi command was shrunk down. There's a bunch of avatar commands. There's a wa command too. Lotsa api wrappers that at a point lance has become an api client
placid ermine
so uh
do i add the embed/timing or nah?
fervent sage
If sir-lancebot#672 it might not be needed
placid ermine
alright then
cold moon
Does anyone know how to get absolute URLs from response.redirect_chain in Django test client? Currently this is returning relative URL /path/to/page, but django_hosts reverse is returning full URL.
short snow
response.redirect_chain[-1] returns the relative url, on that you can just do request.build_absolute_uri(), to get the absolute url.
hardy gorge
@thorny obsidian Is there a branch somewhere I can spin up and test?
thorny obsidian
<@!212644551926611969> Is there a branch somewhere I can spin up and test?
I forked lancebot for it but I think I forgot to actually push my changes. I'll push as soon as I'm at my computer
solid pumice
@thorny obsidian nope what it does is create a file with the code inside and then with pty processes it runs the code interactivlly
thorny obsidian
<@!212644551926611969> nope what it does is create a file with the code inside a...
How safe is this from untrusted user input? Our snekbox is very robust in terms of people trying to break it
solid pumice
How safe is this from untrusted user input? Our snekbox is very robust in terms ...
didn't implement security against untrastud user input
but I can do it
short snow
should some logic be implemented on int eval to protect from forkbombs and etc?
thorny obsidian
So that's our cornerstone feature of snekbox. We can run untrusted user input. It's the most important part of the project so unless another implementation can do that it's not something we'll consider
thorny obsidian
should some logic be implemented on `int eval` to protect from forkbombs and etc...
Nah. Int e is admin only because of how powerful it is. If we need to guard it against admin input we have a larger problem
solid pumice
So that's our cornerstone feature of snekbox. We can run untrusted user input. I...
then when I implement security like snekbox ill come back
short snow
well i know about that, but you should always be on the safe side, what if someone finds a potential way of doing it?
brazen charm
Getting user input from stdout is not particularly hard even with current eval as you can patch it
Restricting the internal eval would really make it lose its purpose
fervent sage
Nah. Int e is admin only because of how powerful it is. If we need to guard it a...
tbf as my pin in #discord-bots says, even if you trust someone it doesnt mean they cant make unintentional mistakes - better safe than sorry
solid pumice
Getting user input from stdout is not particularly hard even with current eval a...
it is not that easy, I spent like hours trying to find a method
fervent sage
though given it's running on k8s any fork bomb or filesystem stuff wont affect much, and you'd have to be actively trying to do so to mess up server stuff like channels/whatever
so really i'd agree that validation is not super necessary here
brazen charm
Messing with the system is not that impactful compared to what you can do with the server itself
short snow
tbf as my pin in <#343944376055103488> says, even if you trust someone it doesnt...
yeah that's what I meant to say
fervent sage
true, but again you have to be trying to mess up server stuff
green oriole
There is no way to really mess it up considering that almost any programming issue will lead it to reach a resource limit and restart
fervent sage
at which point again you have bigger issues
green oriole
I am fairly confident that it will recover itself from potential problems
If you are deleting the whole server because of a programming error there isn't much we can do to prevent it
short snow
we could prevent it from deleting resources
green oriole
Well admins already used it to delete some stuff
thorny obsidian
And our mitigations to be safe for this revolve around how we deal with the admin role itself. I'm wary of trying to build in protections into snekbox if that'll prevent us from dealing with raids or investigating issues.
green oriole
The whole goal of int e is that it isn't restricted
brazen charm
Accidentally messing with it sounds like it'd lead to a short downtime at worst to me. You can't restrict it whole without limiting its uses and if only some things are limited it can be (accidentally) worked around
green oriole
I think we can safely assume that admins will only run evals they are 100% sure will work correctly
short snow
i know our staff is smart and has lot of verifications, but sometimes mistakes can happen, like it happened on coding den, and they got raided
fervent sage
even if you do try to restrict stuff, as @slow steppe and myself found out it's a futile act regardless, in combination with all the other points about it being admin only etc.
thorny obsidian
Coding den was a social engineering thing, limiting int e would not have prevented that
fervent sage
anyways, i have been awake for 26 hours and just did 32 miles of cycling so im gonna go to bed and die in peace
green oriole
... How
short snow
Coding den was a social engineering thing, limiting int e would not have prevent...
i didn't say about their attack, i was pointing to mistakes
green oriole
Well context is important
Do you think we should put restrictions in int e in case an admin account is compromised?
thorny obsidian
But I am wary of limiting int e because if we're trying to troubleshoot an issue and we build in protections that prevent us from properly troubleshooting... that defeats the purpose of int e and then we'll just remove the protections and continue on as normal
balmy sparrow
Do you think we should put restrictions in int e in case an admin account is com...
with 2FA as well, I think it'd be safe to assume that this won't happen right?
green oriole
If we do have restrictions, admins should be able to bypass it
short snow
maybe it would ping admins, and then wait for an admin approval
balmy sparrow
or am i overestimating how good 2FA is
thorny obsidian
Again, the more impactful harm int e can do is that it can nuke the server. But we won't have a good way to prevent that without overengineering it to death
green oriole
with 2FA as well, I think it'd be safe to assume that this won't happen right?
2FA won't protect against token grabbing
It will protect against known passwords though
balmy sparrow
oh right I didn't think of that
thorny obsidian
maybe it would ping admins, and then wait for an admin approval
Waiting for a second admin to run an int e is a big blocker. Especially in the case where we're just checking info like who has what role.
green oriole
Listing who has a role should be a command tbh
thorny obsidian
We use it for more complicated stuff like the find out who is just a mod. So we need to subtract out those who have admin roles, etc
green oriole
We could have ways to select which roles to include and which ones to exclude
But that's out of scope for now I'd say
int e is used for more standard things than checking roles
short snow
Waiting for a second admin to run an int e is a big blocker. Especially in the c...
can't think of anything smarter as of now
thorny obsidian
But that's just an example. There are other int e things we do where it's just querying information. I don't want to focus down on an example.
short snow
yeah I understand
slow steppe
even if you do try to restrict stuff, as <@!280457250613493762> and myself found...
ohh no not leaking my token again
gritty wind
I don’t think limiting int e is something we’d consider at all
The whole point is that it’s a direct eval in the bot instance
magic arch
Would it be plausible to just find/replace the bot token in all int e outputs? That way it's not really restricted or anything but you can't just grab the token without at least a little bit of extra thought and playing around.
thorny obsidian
Honestly, if someone gets access to int e and they're a bad actor they don't need to try to find the bot token. They can run whatever code they want already.
gritty wind
If you get access to int e, you can already destroy the server without it
Admins can mass ban, mass delete, and do other mass destructive things
sleek steppe
Does @stable mountain have admin?
gritty wind
I don’t think so
But if you have int e, you have access to an admin account
Specifically the admin role
slow steppe
Would it be plausible to just find/replace the bot token in all int e outputs? T...
for 1) what kutiekat just said, and 2) its not really possible. There are so many ways to get it, and even if u replace the token from the output str, there are many ways to get around that type of filter, ie returning set(self.bot.http.token) or returning self.bot.http.token.replace(onechar, anotherchar).
sleek steppe
set would not be helpful though
slow steppe
I mean if someone really wanted the token they could do it like that and just copy paste each letter or whatever
sleek steppe
set is unordered and doesn't have duplicates lol
gritty wind
Token[:-1]
Token[-1]
Put the two together, and you’ve got the token
I don’t think the token is that big of a concern though
If you already have the eval, what does the token grant you
cyan stirrup
Connect to all types of databases using python and then download the database? - Any help to get me started please ?
My goal is to do the following to reduce my day to day work labour-
Write a Python script that will take my Database type - Oracle, Mongo, MySQL, PostgreSQL, Microsoft SQL Server, SQLite, MongoDB, Redis, MariaDB, Firebase, Elasticsearch (any other type if there is any other type) My USERNAME and PASSWORD Then if I give a table name it will allow me to download the Database file - DB_file.parquet (etc.)
That's just my goal to download that DB. Please tell me how to start the process, I could use some ways to start the process for this. Please I request someone to help me out.
I'm new to programming, I'm a non-tech person trying to learn to code, only did some basic python PCEP certification.
gritty wind
Hey, this channel is for discussion about pythondiscord projects
If you need help, check out #❓｜how-to-get-help
Or #databases
sleek steppe
patent pivot
internal eval, executing code live on the prod bot
vocal prairie
If you have access to int e, you don't need the token.
Anyone who does is trusted.
So there's no real need to secure anything imo.
sleek steppe
Anyone who does is trusted.
And probably already has the token
gritty wind
Hmm we don’t really
I mean I can probably ask Joe to give it to me
But I have no reason
sleek steppe
Hmm we don’t really
Oh I thought it was a team application lol
vocal prairie
All I'm saying is that there's no need for extra security in int e.
Besides role validation.
gritty wind
Maybe it is, but I’m not on the team lol
sleek steppe
ah
patent pivot
It is a team app but only the owners are on the team
We access protect most of our passwords/secrets as need to know
magic arch
Honestly, if someone gets access to int e and they're a bad actor they don't nee...
Ah yeah that's true I guess.
fallen patrol
But if you have int e, you have access to an admin account
So the @stable mountain role is above the admin role?
magic arch
They mean that admins are the only ones that have int e access, so anyone who can use int e already has admin perms
sleek steppe
admin can't ban as fast as @stable mountain tho 👀
green oriole
I mean if something like that happens I'd guess that the admin in question would self bot
patent pivot
So the <@409107086526644234> role is above the admin role?
nope
vocal prairie
Is that for the sake of security or just cause?
patent pivot
it's just the way we've got things set up
vocal prairie
Okie
patent pivot
We are continuously improving security, a lot of our devops and moderation tooling works under a zero-trust architecture (https://www.cloudflare.com/learning/security/glossary/what-is-zero-trust/) and as I mentioned our credentials are shared on a need-to-know basis with admins and preferably use RBAC as well, so it's not unforeseeable that in future we'll look into securing features like internal eval, but I think the aforementioned solutions here are not useful from the proactive front.
However, I would not mind seeing this feature implemented anyway as a reactive measure, not as a security measure but more as an incident prevention measure. If an admin runs a snippet somewhere that accidentally returns an object which reveals the token then that token could easily be compromised. We don't need to try counter bypasses through things like character replacement or base64 encoding, just the most simple case. I think that a filter so simple is worth implementing.
vocal prairie
I agree.
Extra security features are pointless, but checking whether someone else might get something they shouldn't is smart.
short snow
@fervent sage can't say a bug, but yeah this needs to fixed
sleek steppe
Just have a max_concurrency check
short snow
that would max_concurrency spam then ig
short snow
lemme test
sleek steppe
mhm
short snow
looks like max_concurrency needs a error handler
nope it won't spam, it will just send it once
i will comment on the pr quick
fallen patrol
I mean if something like that happens I'd guess that the admin in question would...
Or is just zith
Xith*
fallen patrol
looks like `max_concurrency` needs a error handler
But, that would prevent two people from running the command at the same time.
vocal wolf
Or is just zith
No mortal being can surpass @stable mountain's muting speed
sleek steppe
But, that would prevent two people from running the command at the same time.
Nope, it takes a bucket.
fallen patrol
Wdym
sleek steppe
oof
vocal wolf
sleek steppe
yeah that ^
stable mountainBOT
fallen patrol
Wtf
vocal wolf
that's stupid lol
fallen patrol
WHAT THE FUCK
sleek steppe
!docs discord.discord.ext.commands.BucketType
??
stable mountainBOT
vocal wolf
Nevermind, that makes no sense
vocal wolf
have fun
patent pivot
WHAT THE FUCK
let's keep things chill, please
vocal wolf
!docs discord.discord.ext.commands.BucketType
@patent pivot while you're here, any idea why this is a thing?
I thought it'd make sense, but now I'm just confused
vocal wolf
ye
patent pivot
hmmm
probably just some weird logic on how we fetch the relevant inventory to scout from
green oriole
<@!165023948638126080> while you're here, any idea why this is a thing?
Isn't that part of the class docstring?
I can't load the docs I'm on mobile haha
sleek steppe
Yeah but BucketType links to discord.discord.ext.ect when others ink to discord.ext.ect
vocal wolf
https://github.com/python-discord/bot/pull/1414 needs more reviews
short snow
vocal prairie
https://github.com/python-discord/bot/pull/1414 needs more reviews
Only staff should review that one, right?
Since it's Sentry?
If not, then it looks good to me.
vocal wolf
It doesn't have anything to do with sentry
vocal prairie
Okie
vocal wolf
https://github.com/python-discord/bot/pull/1414 needs more reviews
@tawdry vapor for this PR, is there anything else I should look into besides what we've already gone over (status codes)?
tawdry vapor
I don't think
I just didn't get around to testing it after you fixed the config issue
brazen charm
<@!165023948638126080> while you're here, any idea why this is a thing?
They used the normal class directive instead of autoclass that everything else uses on the page and it stuck on the module name to the front when building the html for the id. It's a bit more prominent in the pyside docs where everything looks like PySide6.QtCore.PySide6.QtCore.QObject
vocal wolf
huh
balmy sparrow
https://github.com/Rapptz/discord.py/commit/296bd069c106edfe848ae851bb207fe22784c4da i think this was the hotfix after I asked in their server
also, do we need this converter anymore? https://github.com/python-discord/bot/blob/0cdcaf3e44eac0d64a3ad0c8eda82171a3b4f42b/bot/converters.py#L492 the UserConverter already fetches the user if it wasn't found in cache(since v1.6)
brazen charm
Feels somewhat hacky as it could've just been setting the current module to the actual module and only specifying the class name, but then I'm also not completely sure how the autoclass ignores the module name before the class names as I'm not that familiar with sphinx
short snow
dawn and toxic have you guys tested the pr and then approved?
ig yes, i wouldn't fire up docker
so you have test it?
vocal prairie
mhm. It worked fine for me.
vocal wolf
https://github.com/python-discord/bot/pull/1414 needs more reviews
@tough imp since you reviewed before, I'd like your opinion on the current state.
tough imp
I'll take a look once I get out of my post-food coma
vocal wolf
tough imp
but I probably cannot test; I dont have help channels set up in my guild
vocal wolf
rip
fallen patrol
Ik that @short snow has help channels set up
sleek steppe
dawn and toxic have you guys tested the pr and then approved?
Yep
thorny obsidian
oh come on! flake8 passed locally
sleek steppe
Happens all the time 😔
sleek steppe
It's the same error too 
Also this is interesting
I get this error for help channels
https://paste.pythondiscord.com/ipehepayej.sql, I think I have the wrong version of arrow
because I don't get that error in the shell
vocal prairie
Wrong versions of packages?
fallen patrol
smh
dusky shoreBOT
fallen patrol
Sir-Lancebot#673
dusky shoreBOT
dusky shoreBOT
fallen patrol
ok.
vocal prairie
We need that better regEx lol.
fallen patrol
for this, i see a hardcoded url to a pydis site but shouldn't it be an internal url?
that same line of code on @stable mountain is https://github.com/python-discord/bot/blob/0cdcaf3e44eac0d64a3ad0c8eda82171a3b4f42b/bot/utils/services.py#L24
thorny obsidian
god damn fucking finally.
@gritty wind @green oriole As an FYI, with a blank install of Sir Lancebot with the usual pipenv sync --dev and with the precommit hook my flake8 was passing locally but failing github actions. No idea what was going on.
vocal prairie
Local stuff goes brrr sometimes.
thorny obsidian
Let's test out a poetry install though
vocal prairie
Is poetry nice?
vocal prairie
That sounds like the yarn vs npm situation.
npm is older so more accepted, while yarn is better in performance.
sleek steppe
Is poetry nice?
Very
fallen patrol
for this, i see a hardcoded url to a pydis site but shouldn't it be an internal ...
oh wait i should put this as a comment on the pr by @thorny obsidian
fallen patrol
huh?
you have a hard link to the website when it probably should go off of a config
which is exactly what @stable mountain does
thorny obsidian
Do you have a link or file w/line number?
fallen patrol
yep! linked above, follow the reply chain
fallen patrol
yes
thorny obsidian
That's python's though?
patent pivot
that's not hardcoded
fallen patrol
yes that's my point
patent pivot
okay so
thorny obsidian
So you replied to my PR but you don't provide any additional context. I don't know what you're specifically talking about
fallen patrol
ohhhh i didn't give the line number
patent pivot
I don't get the argument here
vocal prairie
I think they're saying that instead of having the url hardcoded, it should be referenced from a config. (I don't really agree)
patent pivot
the paste service is:
a) always publicly available
b) always going to be on pythondiscord.com (we're always going to have that domain)
c) very very easy to change and not volatile enough that it warrants the addition of a new environment variable
thorny obsidian
what is it? I am so lost
patent pivot
so no, this should not be hardcoded
patent pivot
what is *it*? I am so lost
paste site domain
one sec I'll get you the actual lines
fallen patrol
fallen patrol
I think they're saying that instead of having the url hardcoded, it should be re...
yes, and the reason for it to be like @stable mountain as in both from config
thorny obsidian
so no, this should not be hardcoded
So... I should put it in config?
patent pivot
the paste service is:
a) always publicly available
b) always going to be on pyth...
for these reasons
fallen patrol
the paste service is:
a) always publicly available
b) always going to be on pyth...
then why does @stable mountain do it
patent pivot
because python has a config system
thorny obsidian
Okay cool. I generally trust Seb's implementation of int e and tried to keep it intact as much as possible.
fallen patrol
because python has a config system
oh and sir-lance doesn't
patent pivot
just because Python does something doesn't mean we have to do it on lancebot
yes, sir lancebot works entirely off environment variables for now
and even if we did, this is such a minuscule item in a PR which is never going to be important for the reasons above
we aren't deploying an application which has to be future proofed, if we need to change things we can just sed on the source and update very easily, it's not something that needs configuration
thorny obsidian
okay turns out I wasn't too tired to try out poetry wheeeeeeee
sleek steppe
^
thorny obsidian
what's the poetry command to actually start the bot?
thorny obsidian
You have a draft PR for it, no?
thorny obsidian
eeeey there we go thanks
I was trying poetry run start and poetry run task but not all of it together
Is pretty nice
placid ermine
(bump on sir-lancebot#668)
dusky shoreBOT
fallen patrol
(bump on sir-lancebot#668)
imagine contributing pr 666
sleek steppe
ono 
fervent sage
i just removed 'valid' from it
sleek steppe
lol
fervent sage
valid isnt important enough for me to care about changing stuff around it to accommodate its existance
spot the missing . aAAaaAAAaa
thorny obsidian
(bump on sir-lancebot#668)
Github app is not being informative, what else is needed to approve the PR?
patent pivot
reviews
thorny obsidian
Core dev or anyone?
sleek steppe
lol
fervent sage
approve mine and i'll approve yours
patent pivot
let's see
sleek steppe
forgot chris is core dev now 
thorny obsidian
Cool, I'll see if I can review it in the morning if no one else has yet
fervent sage
im gonna dedicate the next 15 minutes to breaking the .timed command i made
sleek steppe
@fervent sage shouldn't you use constants.Client.prefix instead of doing .help
or maybe just ctx.prefix
sleek steppe
ah
patent pivot
review left on sir-lancebot#668
dusky shoreBOT
fervent sage
lol
looks like ive fallen back into conventional commits (which is a good thing, but consistency lol)
deft patrol
True
placid ermine
so uh for the latex thing
it takes at worst 10 seconds on my laptop for the weirdest of weird expressions, for normal expressions it rarely takes over a second, and almost always remains <2-3 seconds
also, i have never cached anything in files
how does that work
like
it's not like i just dump a dict in a txt file
fallen patrol
Github app is not being informative, what else is needed to approve the PR?
I'm not even entirely sure why there's a github app
I use the mobile browser for all of my github needs because the mobile app is missing so many features.
balmy sparrow
looks like ive fallen back into conventional commits <:kek:585617800257863727> (...
I'd been meaning to ask you about this haha why'd you stop in the first place?
patent pivot
github app is nice
patent pivot
also, i have never cached anything in files
it'd just be calculating a hash of the query (probably with hashlib) and then writing that as like _latex_cache/{hash}.png
placid ermine
oh
patent pivot
then before you generate one the next time you hash the query again and check if it exists under _latex_cache and if so send that, else generate, save and repeat
patent pivot
your call, if it's consistently the same time it's fine, and we're using an executor so should be good
sleek steppe
github app is nice
Only if it had find in page 😔
magic arch
I feel like a cache wouldn't be too useful though as usually latex expressions would probably be pretty unique. Sure, definitely help out a bit but not sure if it's worth it tbh
tawdry vapor
I'm inclined to agree but I don't mind if someone wants to implement it just cause they can
fervent sage
I'd been meaning to ask you about this haha why'd you stop in the first place?
consistency with most other commits in pydis so it looked odd
from now on im just going full conventional commits because they're nice and i do them by default
fallen patrol
github app is nice
How? You can't even copy a link to a specific line.
Note: android
patent pivot
for what I need to use it for it works well
stuff like deploy approvals, issues & discussions and GitHub Enterprise it's good
fervent sage
latex renders wont change, cache clearing doesnt matter, if it happens it happens
patent pivot
in production it will automatically happen on restart, there is a use for clearing to prevent the disk from filling (unlikely but ¯_(ツ)_/¯). I guess in that situation we say "store maximum 100 files and delete based on oldest used time"
placid ermine
aight, so i don't have to worry about it, right?
fervent sage
my take is:
in production which is the only place it will be long running since its specific to pydis it's gonna get cleared on restarts
not in production it will be ran rarely ever or at most infrequently, so size likely is of no concern
patent pivot
I don't foresee it cropping up. It'd be nice to have the logic in place eventually but I'd be happy to work with that if an issue is opened and it's fairly low priority
placid ermine
nice
cold moon
from django.views.generic import RedirectView
class CustomRedirectView(RedirectView):
"""Extended RedirectView for manual route args."""
@classmethod
def as_view(cls, *args, **initkwargs):
"""Overwrites original as_view to add static args."""
cls.static_args = args
return super().as_view(**initkwargs)
def get_redirect_url(self, *args, **kwargs):
"""Extends default behaviour to use static args."""
args = args + self.static_args
return super().get_redirect_url(*args, **kwargs)
Why does routes to what I don't pass static args have static args of other routes?
green oriole
<@!386599446571384843> <@!407110650217627658> As an FYI, with a blank install of...
Hmmmm I see your fix commit, those empty lines definitely need to be there. Could you give me the output of pipenv run pip freeze on your install when you have a second?
short snow
uhh, do we really need latex cache? It is pretty fast already, and mostly the latex equations are different
cold moon
I also think cache is not necessary, because chance that between redeploys command get executed twice with same input is really small
green oriole
Are we really gonna render the same latex command many time in a row? I don't really think so, sounds like something that should be solved with a rate limit
placid ermine
i don't really like the idea of rate limiting it tbh
if the command is being used chances are that it's being used as part of a longer conversation where other people might also use the command to follow up
cold island
Caching sounds a bit over engineered for a feature that we don't know how often it's going to be used and how. If it's going to be used in the middle of conversation then a modest rate limit should be barely felt. So let's start with that and then consider adjustments when we have usage statistics
I will also argue that a minimal rate limit is necessary even with caching.
green oriole
I also think we should rate limit resource intensive tasks
Although we have automatic mutes
cold moon
Max ratelimit what is reasonable is 5s, not more
short snow
agree
patent pivot
My reasoning for cache is to prevent DoS attacks, but it people are in consensus otherwise then that's fine
vale ibex
We could put a user cooldown+guild cool down on it
cold moon
No, if user start spamming with it, @stable mountain catch this user
vale ibex
Still would leave us open to a ddos with multiple users
But we have that when worse with the pfp stuff anyway
cold moon
Sir Lancebot is not so important service, and we have resource limits in k8s
patent pivot
We shouldn't rely on that, but I guess so yes
cold island
Shouldn't it be in the same class as the other image-based commands?
Chris iirc you were working on queuing those
vale ibex
Shouldn't it be in the same class as the other image-based commands?
Image stuff isn't in the same cog until my pr is merged
Yea I've got them in executors but not in the same concurrency bucket with this pr
cold island
yeah I think that's fine. Whichever gets merged first we can adjust the other
vale ibex
Max concurrency doesn't work with groups out of the box
So need to implement a custom bucket
cold island
That should prevent any possible DoS attacks
or well
mitigate what they affect
Is there some sort of cooldown for that custom bucket?
vale ibex
It doesn't exist yet, so there could be
cold island
I'm just thinking
vale ibex
I was planning to implement it similar to max concurrency
So it would queue up the commands
cold island
what if you get 100 invocations for image stuff. Each of those is blocking
vale ibex
And there would be a max le gth of the queue
I've got them in threads now, so they're not completely blocking
cold island
I see
vale ibex
Sir-lancebot#597
dusky shoreBOT
vale ibex
... Case sensitive regex
cold island
lol
vale ibex
sir-lancebot#597
dusky shoreBOT
cold island
should also probably look for word boundaries
cold moon
I think if we add max concurrency, then this should be at least 4-5
short snow
btw did the absolute url thing work last time?
cold moon
Yes
vale ibex
Ah lol, I'm disqualified from review bot since I've got a commit on your PR @green oriole
green oriole
haha
vale ibex
So is Vco 😛
green oriole
Interesting
sleek steppe
Oh lol
green oriole
Well at least my commits aren't all red anymore
vale ibex
hah
fervent sage
well while there are a few devs here :P
could i get some reviews on sir-lancebot#672
fervent sage
on a side note im so proud that i didnt make flake8 lint unhappy even once
vale ibex
How much is it worth 👀
sleek steppe
~~on a side note im so proud that i didnt make flake8 lint unhappy even once~~
Impressive
vale ibex
Possibly the single most important PR to date sir-lancebot#675 /s
dusky shoreBOT
thorny obsidian
Hurm, how do I check if the logging is correct
vale ibex
correct in what way?
gritty wind
I might be missing context, but what do you mean
sleek steppe
Possibly the single most important PR to date sir-lancebot#675 ~~/s~~
I agree
thorny obsidian
I don't know how to set up so I can check if the log.trace is working
vale ibex
Ahh, put BOT_DEBUG=true in your .env
placid ermine
aaa i forget i have to git add all over again after changes
sleek steppe
git commit -a -m "..."
placid ermine
i am not used to that and i am not going to change old habits
||/s||
sleek steppe
😔
short snow
Hurm, how do I check if the logging is correct
It would be showed in your terminal when you would run the command
thorny obsidian
Chris helped me get the logging.trace, which is what I was trying to check.
trend on our repos
placid ermine
lol
sleek steppe
have i triggered a <:shipit:826492371813400637> trend on our repos
Yes, you have
fervent sage
Possibly the single most important PR to date sir-lancebot#675 ~~/s~~
well its merged
placid ermine
added max_concurrency and stuff to sir-lancebot#668
dusky shoreBOT
short snow
@thorny obsidian could show how the logs look for this comment, https://github.com/python-discord/sir-lancebot/pull/673#discussion_r611207482
thorny obsidian
Did you not test it yourself to see how they looked? I assumed you did
sleek steppe
added max_concurrency and stuff to sir-lancebot#668
Should we be type hinting to bot.Bot instead of commands.Bot?
short snow
Did you not test it yourself to see how they looked? I assumed you did
Nope, just tested the PR, mine where some short comments, so didn’t, if it would have been some core code change then I would have done it
placid ermine
Should we be type hinting to bot.Bot instead of commands.Bot?
i went through two or three other cogs, all of 'em use commands.Bot
patent pivot
yeah the log trace doesn't clarify things with the = syntax
placid ermine
not that it makes much of a difference anyway
patent pivot
it might with log.trace(f"Updating locals {self._locals} with {locals_}") but it's a trace log and points to the logger so it should have enough
short snow
i went through two or three other cogs, all of 'em use commands.Bot
They are not the same everywhere yes, but I would go with bot.Bot personally as it is more "accurate", someone could probably open a quick PR to change all of them, if this gets approved
short snow
yeah the log trace doesn't clarify things with the `=` syntax
Doesn’t f strings print them out as self._locals=......
patent pivot
Yes, but I don't think that's clearer than keeping it like it is currently or what I proposed above
short snow
Yeah yours would be clearer
And should we just remove python syntax from here, https://github.com/python-discord/sir-lancebot/pull/673#discussion_r611208428, since output is just plain text it is not python code to have py syntax
short snow
Ok, i don’t think paste to hastebin would be used anywhere else, but should it be a utils function
patent pivot
we'll do what we did with Python, we keep it in a cog until we need it elsewhere and then we promote it to a utility
vocal prairie
~~on a side note im so proud that i didnt make flake8 lint unhappy even once~~
Impressive
patent pivot
yes
fallen patrol
And should we just remove python syntax from here, https://github.com/python-dis...
on python it is py
fallen patrol
using the escape method means that all other markdown characters will be backslashed
patent pivot
nope
fallen patrol
the <hacky> solution i use in my bot is a zero width space around ``
gritty wind
for the most part nothing really happens if a user manages to break out
fallen patrol
does @stable mountain prevent it?
gritty wind
We had an issue a few days ago that showed how to circumvent it
fallen patrol
for the most part nothing really happens if a user manages to break out
no, the response just looks really bad if you're trying to copy it
green oriole
Well the problem is just that it looks bad
patent pivot
!int e ```py
print("`" * 3)
In [2]: print("`" * 3)
yeah
fallen patrol
i just
gritty wind
no, the response just looks really bad if you're trying to copy it
Right, but you probably wouldn't do that by accident
fallen patrol
what i did for my bot
gritty wind
you're probably trying to break out
fallen patrol
is if it escapes it just uploads as a file instead
gritty wind
and in that case, that's sort of on you
fallen patrol
is if it escapes it just uploads as a file instead
which is what !e does
stable mountainBOT
@patent pivot :white_check_mark: Your eval job has completed with return code 0.
Code block escape attempt detected; will not output result
Full output: https://paste.pythondiscord.com/ovabatiboz.txt?noredirect
patent pivot
ah yeah
green oriole
It is for int e though
fallen patrol
you could just do that for int e
if it tries to escape just paste it
because that way you get the full response for the one case when you need it
¯_(ツ)_/¯
hardy gorge
I don't mind it as much on int e. int e is an internal feature that only admins can use anyway.
sleek steppe
For the raw command we just replaced ` with `\u200b
gritty wind
This feels like a different case because
it is something you can do accidentally
how do you enter a zero-space width accidentally
green oriole
Got rid of the comment
fallen patrol
oh wait
green oriole
It was indeed wrong, thank you
hardy gorge
I don't like inserting zero-width spaces, because I often copy things from internal eval for a next evaluation
fallen patrol
i have a comment on that same line of code anyhow
hardy gorge
If the bot were to insert zero-width spaces, that would become tedious
fallen patrol
should have a \n before the last three ```
hardy gorge
I could still copy my own output, but it's something pushed far to the top
fallen patrol
If the bot were to insert zero-width spaces, that would become tedious
if you don't have that character there in that case, you aren't copying the full output
when it escapes is the only case it would be there
hardy gorge
I feel like the number of times we are actually trying to do something with triple backticks are very limited
I don't think it's ever really come up with internal eval
fallen patrol
im of the camp that if the output contains ``` just upload to pastebin
hardy gorge
For internal eval?
thorny obsidian
The screenshot akarys has there is not a result from the int e command. It was my copying and pasting code from int e.
fallen patrol
For internal eval?
yeah
it uploads if its too long already
so it'd just be a small check to do so
fallen patrol
Got rid of the comment
i replaced it with a different thing because you made me notice something else
hardy gorge
I don't think I like uploading output too often for internal eval
We're typically scripting over a longer session of internal evals
Having the output in the browser gets in the way of that flow
So, unless something is really breaking otherwise, I'd prefer to keep output in the client
fallen patrol
do remember, it would only upload if ``` is in the output, and if it did send directly to discord, then it would not be copyable output
hardy gorge
But you'd still have the output directly in the client and your own message to copy from
fallen patrol
but
you wouldn't
in the rare case that you want ``` it would escape the codeblock
hardy gorge
I can still click edit on my message and copy my input, right?
fallen patrol
yeah, but you wouldn't easily be able to copy the output
hardy gorge
And I still have the output right here in the client
fallen patrol
but it would look like the above image
hardy gorge
I don't see a lot of things wrong with that
I have all the output I need right there
patent pivot
having used internal eval hundreds of times now I don't see a situation where triple backticks have ever been returned
fallen patrol
basically, the only thing this affects is if you output ``` then any markdown in the message will be absorbed by markdown and you won't be able to copy it really
a very edge case
hardy gorge
Yes, and I don't care that in such edge cases the output is less than copyable
I do care about keeping the output in the client as much as possible
fallen patrol
you could also convert it to upload as files rather than to the pastebin which would then auto embed on pc
hardy gorge
I mean, this is a feature that we use internally
thorny obsidian
I don't really see the need to solve this one edge case for an admin-only command that, in all honestly, won't be used a lot on lancebot
hardy gorge
I think that unless one of us (admins) really wants it differently, I don't think we should solve such edge cases
fallen patrol
why is this so huge
fallen patrol
I think that unless one of us (admins) really wants it differently, I don't thin...
okay yea makes sense
fervent sage
fallen patrol
<:pepeHmmCoffee:585628416536084483>
unless that file was recently updated that was not in there recently
source: I opened all of the links and added them to a playlist
gritty wind
it was recently updated
fervent sage
git blame says someone called Neil Shah added razer vids to the google category :P
patent pivot
ah I might have approved that lol
gritty wind
All the links are sorted under google, so it's easy to see why someone would add that accidentally
especially since it was towards the bottom
fervent sage
well, sir-lancebot#676 should fix it
vocal wolf
https://github.com/python-discord/sir-lancebot/pull/642
Needs one more review
fallen patrol
….and all of a sudden the apparent logic of the entire command is exposed
random_youtuber = random.choice(self.youtubers)
category = self.yt_vids[random_youtuber]
random_vid = random.choice(category)
why don't we have the json pre-commit anymore
fallen patrol
first it chooses from one of the youtubers, then it chooses on the videos
gritty wind
would've been useful here
vocal wolf
<https://github.com/python-discord/sir-lancebot/pull/642>
Needs one more review
@gritty wind (since you're already here) I'm confused, doesn't this actually have enough to merge? Two staff members approved.
fallen patrol
this means that razer will have a 50% chance to be the video
fervent sage
<@!386599446571384843> (since you're already here) I'm confused, doesn't this ac...
i have a commit in there so im disqualified
vale ibex
It's because we have commits on the branch
fervent sage
vocal wolf
gosh diggity darnit
balmy sparrow
wait staff approvals are enough for merges? not core-devs?
vocal wolf
alright scal time 4 you to review
fervent sage
2 staff or 1 core dev iirc
vale ibex
It's and iirc
gritty wind
2 staff or 1 core dev iirc
nah core dev is mandatory
cold island
wait staff approvals are enough for merges? not core-devs?
at least 2 staff, at least one of which is core dev
fervent sage
ah right
gritty wind
1 core dev and 2 staff to be exact
balmy sparrow
right makes sense
gritty wind
but all core devs are staff so
vocal wolf
lol
gritty wind
1 core dev and 1 non-core dev staff is what it works out to
vocal wolf
alright who's going to review that one before the meeting
patent pivot
contributors can also provide the second review
vocal wolf
if anyone
fallen patrol
contributors can also provide the second review
are contribs the people with the role here or those who have at least one commit on the repo
patent pivot
the role
gritty wind
why is this such a big diff lol
patent pivot
I have to manually add them to the policy
gritty wind
shouldn't it have just removed the check
vale ibex
It's a rewrite too 😅
sleek steppe
And some other PR's for the issue cog
gritty wind
alright, I won't do this justice in 20 minutes
vocal wolf
https://github.com/python-discord/bot/pull/1414 this also needs reviewing/testing
gritty wind
oh that's finally ready? 👀
gritty wind
very nice
cold island
🤔
fervent sage
timed execution woo, thanks chris
vocal wolf
@gritty wind if you want to test it, my bot is up on the test server
balmy sparrow
🤔
the pipenv to poetry PR also has a "hacktoberfest accepted" label on it for some reason
vale ibex
the pipenv to poetry PR also has a "hacktoberfest accepted" label on it for some...
It's because staff are trolls
😀
hardy gorge
because poetry is one big hack that's only supposed to appear during halloween
(disclaimer: I like poetry)
sleek steppe
poetry is the best
fervent sage
if there's one feature from poetry i love more than anything else
it's how simple it is to publish packages
hardy gorge
poetry has some quirks and is fairly opinionated
I haven't experienced it myself (yet), but I've heard that it doesn't deal well with being run in very protected environments, with custom certificates and a lot of network rules
placid ermine
bump sir-lancebot#668
dusky shoreBOT
sleek steppe
bump bot#1471
dusky shoreBOT
fervent sage
bump bot#1471
i'll take a look over this now
vocal wolf
yes
sleek steppe
yes
fallen patrol
wait will it send a new message every channel or every update
sleek steppe
staring at <#622895325144940554>
I do that all the time lol
sleek steppe
nice
vocal wolf
it worketh
vocal wolf
because that would be very painful to do
fallen patrol
sleek steppe
sorted(channels, key=lambda c: c.position)
fallen patrol
because that would be very painful to do
would it?
vocal wolf
yes.
fallen patrol
how painful?
vocal wolf
So painful that I decided to use a set
thorny obsidian
Hmmmm I see your fix commit, those empty lines definitely need to be there. Coul...
sleek steppe
sorted(channels, key=lambda c: c.position)
lol
vocal wolf
At the same time I wasn't sure at the time of writing the PR that having it sorted would be necessary
if anyone wants to write a PR to have it sorted, go ahead
sleek steppe
I don't think it's necessary
vale ibex
I'd prefer attrgetter, rather than lambda but that would work
sleek steppe
operator.attrgetter right? I could make a PR for it if you want
vale ibex
operator.attrgetter right? I could make a PR for it if you want
Sounds good, just make sure to add context in the PR body, so people who didn't see this convo kbow what's going on 😄
vale ibex
It doesn't really, its just polish
sleek steppe
available=', '.join(c.mention for c in self.available_help_channels) or None
fervent sage
rare
vale ibex
heh
fervent sage
that being said i havent been pinged for that in like a week now which is nice
fallen patrol
> `available=', '.join(c.mention for c in self.available_help_channels) or None...
seems like
'None' would better
sleek steppe
why?
vale ibex
that being said i havent been pinged for that in like a week now which is nice
Yea, haven't hit the limit since Monday
fallen patrol
Currently available help channel(s):
vs
Currently available help channel(s): None
gritty wind
we hit the limit basically right after we raised it
I don't remember what day it was
sleek steppe
works nicely
eager fable
works nicely
Why are you seeing @stable mountain without a pfp?
fallen patrol
Why are you seeing <@!409107086526644234> without a pfp?
they are self hosting it
notice the role color
vocal wolf
what happens in the rare case that there is no channels?
Pretty sure it'll just say None
patent pivot
it was earlier than the 5th
eager fable
notice the role color
Yeah saw now, thanks :)
fallen patrol
Pretty sure it'll just say `None`
afaict the variable is nothing
sleek steppe
Darn the line is 123 chars long 😔
gritty wind
The change happened 12 days ago
fervent sage
Darn the line is 123 chars long 😔
lol get flake8'd
gritty wind
according to github
patent pivot
vocal wolf
afaict the variable is nothing
sleek steppe
does this look fine lol
fallen patrol
does this look fine lol
the other thing to check is the actual channel positions
sometimes
discord lies
or they aren't how they actually sort
gritty wind
double quotes please
sleek steppe
ah right
fallen patrol
double quotes please
if they have pre-commit on then it should do it automatically
😛
I actually still code in single quotes and then black it
gritty wind
what I have seen is it's safer to assume people don't have it setup correctly
fallen patrol
ah
gritty wind
no matter how long they've been contibuting
sleek steppe
That line already had single quotes 😔
gritty wind
Noted, will ban xith promptly
fallen patrol
yep i see
fallen patrol
what I have seen is it's safer to assume people don't have it setup correctly
case in point xith
also case in point, the repo checks didn't catch it
gritty wind
perhaps the rule doesn't exist
brazen charm
Don't think quotes are handled during linting
vocal wolf
@gritty wind you reviewed, we're both getting banned
gritty wind
it was good knowing you
vocal wolf
lmfao
gritty wind
the check does in fact not exist
fallen patrol
I have to manually add them to the policy
is this where they're added to the policy if they aren't part of the organization? https://github.com/python-discord/.github/blob/e6eb0cfdbd2493b377c3ca000d1f9f16f276b806/review-policies/core-developers.yml#L38-L47
gritty wind
(at least not anymore)
patent pivot
is this where they're added to the policy if they aren't part of the organizatio...
yep
fallen patrol
very cool
vocal wolf
banded
vocal wolf
@gritty wind push double quotes to master lol
patent pivot
lol i don't
well
i do but i have to go put on my admin hat and go "yes"
and i don't wat to put that hat on
gritty wind
Well, if you want another hat, I have opened a hat shop
I only take payments in Joe hours
gritty wind
woah
sleek steppe
bot#1516 needing reviews
fallen patrol
uh, this already got commited #dev-log message
add timed command for timed execution of commands - vcokltfre
sleek steppe
It was merged into automatic linking of issues pr
fallen patrol
o
vocal wolf
@sleek steppe tyvm for the PR!
sleek steppe
Np lol 🙂
fallen patrol
how can i make a pr or something for @slow bone
slow boneBOT
gritty wind
it's the want modmail in your server category
gritty wind
I don't think we host a modified version, but feel free to make the suggestions
gritty wind
interesting
fallen patrol
its an easy enough fix
gritty wind
what's the issue?
fallen patrol
reason: its a link to the server icon so when it changes the link is invalid
gritty wind
Right, so we need like a bot restart on icon change?
fallen patrol
MOST if not nearly all servers using the bot this doesn't impact them
no, because when that message was sent the icon was fine
its probably not worth it to change but
it would have to be a bot code edit
vocal prairie
But you want to?
patent pivot
what is the fix here
gritty wind
I don't think that's worth doing
fallen patrol
^
gritty wind
it would make updates quite difficuilt
ultimately, it would be a nice fix, if it adds no maintenance burden to us
aka if it changes upstream
patent pivot
if you want to push a fix then push it upstream, we're not modifying our local bot code from a fork or something
fallen patrol
i'll have two answers for it later, and then try it upstream
but there's two ways to do it
ultimately one way is perhaps better, and that could be adding a feature to allow servers to set that icon
other way is uploading the server icon to the embed
gritty wind
is that supported for footers?
fallen patrol
its supported for all images in the embed afaik
gritty wind
Oh so you're thinking a separate attachment?
fallen patrol
where name.ext is a file that is uploaded in the same message
