#dev-contrib | Python | Page 94

patent pivot Mar 31, 2021, 5:23 PM

#

to sentyr

short snow Mar 31, 2021, 5:24 PM

#

it will, but it will keep the logging statement "unclosed", otherwise there is no need of logging the error message

patent pivot Mar 31, 2021, 5:26 PM

#

I think an informational success log is all that is necessary here, the error will be handled through other flows

short snow Mar 31, 2021, 5:26 PM

#

right, same here.

patent pivot Mar 31, 2021, 5:27 PM

#

alright

#

cc @tough imp, only a couple of review comments left in that case

short snow Mar 31, 2021, 5:27 PM

#

ok am computer, will approve it

patent pivot Mar 31, 2021, 5:27 PM

#

a couple of info level logs in the fetch_directory and fetch_file methods and then the open one about a minor comment wording change

#

both optional to implement, I'm approving now

short snow Mar 31, 2021, 5:28 PM

#

and pipfile merge conflict

patent pivot Mar 31, 2021, 5:28 PM

#

ah yeah

short snow Mar 31, 2021, 5:28 PM

#

https://github.com/python-discord/bot/pull/1463#discussion_r604412625 even this one.

GitHub

Rewrite branding manager by kwzrd · Pull Request #1463 · python-dis...

Resolves #1431
Resolves #1377

This PR implements the changes proposed in #1431. The branding management extension is rewritten to comply with the new event structures in the branding repository.
W...

tough imp Mar 31, 2021, 5:28 PM

#

let me catch up with the conversation

short snow Mar 31, 2021, 5:29 PM

#

is left to mention

tough imp Mar 31, 2021, 5:29 PM

#

wait dont merge it the target branch is still set to my fork

patent pivot Mar 31, 2021, 5:29 PM

#

yeah don't worry, won't merge

short snow Mar 31, 2021, 5:30 PM

#

and, did you guys have a discussion about the new file preview feature

#

would you run checks on the file content?

patent pivot Mar 31, 2021, 5:31 PM

#

we've not held discussions, no

#

we'll probably hold them on sunday

short snow Mar 31, 2021, 5:31 PM

#

oh ok

patent pivot Mar 31, 2021, 5:31 PM

#

depending on some implementation details we might run checks, we'll see

vocal prairie Mar 31, 2021, 5:32 PM

#

#community-meta is talking about that right now.

short snow Mar 31, 2021, 5:33 PM

#

Btw, for sir-lancebot#605, the orignal logo is not soo visible so would we want to create a personal logo for it?

dusky shoreBOT Mar 31, 2021, 5:33 PM

#

GitHub

PROpen [sir-lancebot] #605 Add WTF Python Command

tough imp Mar 31, 2021, 5:36 PM

#

regarding the fetch utils, a failed fetch looks like this

#

#

it reaches sentry, but its logged by the caller, such that it can say what it was trying to fetch

#

this way you dont have to look at logging breadcrumbs to figure out exactly what happened

#

i will add a log on success

#

i'll try to address everything tonight, need to finish some work first & have something to eat

patent pivot Mar 31, 2021, 5:41 PM

#

yeah don't stress on it 🙂

patent pivot Mar 31, 2021, 6:36 PM

#

@tough imp debug is fine with me 👍

tough imp Mar 31, 2021, 6:36 PM

#

mr_thumbers

patent pivot Mar 31, 2021, 6:36 PM

#

anddddd

#

morged

#

shipit shipit shipit shipit

tough imp Mar 31, 2021, 6:37 PM

#

shipit

#

hope it will serve pydis well

patent pivot Mar 31, 2021, 6:38 PM

#

i'm sure it will, thank you for the contribution!

sleek steppe Mar 31, 2021, 6:38 PM

#

Will I be changeloged? pogchamp

patent pivot Mar 31, 2021, 6:40 PM

#

sleek steppe Will I be changeloged? <:pogchamp:804213564688039956>

fosho!

#

did we ever changelog .github for users?

#

ah that's an old feature isn't it, so probably not

#

changelogged! @sleek steppe

sleek steppe Mar 31, 2021, 6:43 PM

#

Thanks!

vocal wolf Mar 31, 2021, 7:16 PM

#

This PR is now up for grabs: https://github.com/python-discord/bot/pull/1303

clever wraith Mar 31, 2021, 9:34 PM

#

Hello every body i need some help please . I try to create a contact book ( MVC app) with PyQt . I want to create a "search field" someone can help me please ?

vale ibex Mar 31, 2021, 9:36 PM

#

clever wraith Hello every body i need some help please . I try to create a contact book ( MVC ...

Hi! please check out #❓｜how-to-get-help. This channel (#dev-contrib)is specifically for discussions around Python Discord projects.

clever wraith Mar 31, 2021, 9:44 PM

#

vale ibex Hi! please check out <#704250143020417084>. This channel (<#635950537262759947>)...

Ok thanks.

fallen patrol Mar 31, 2021, 9:57 PM

#

sleek steppe Thanks!

shiftyeyes

#

~~formatting bug on mobile

#

#

Needs to have a \n between both ```

#

So it becomes
```
Fan of Python, Yada Yada yada
```
And not
```Fan of Python```

#

So it becomes

Fan of Python, Yada Yada yada

And not
Fan of Python

#

vale ibex Mar 31, 2021, 10:02 PM

#

vocal wolf This PR is now up for grabs: <https://github.com/python-discord/bot/pull/1303>

Is there an easy way to work on a PR like this? is it possible to move the code from their fork to a branch on the main repo?

vocal wolf Mar 31, 2021, 10:05 PM

#

vale ibex Is there an easy way to work on a PR like this? is it possible to move the code ...

Not completely sure, usually what I do it just checkout the branch to continue working on it with gh pr checkout 1303 and just push to that branch

vale ibex Mar 31, 2021, 10:06 PM

#

Alright I'll give that a quick try and see how it goes

whole forge Mar 31, 2021, 10:07 PM

#

you would need the github cli installed tho

tough imp Mar 31, 2021, 10:07 PM

#

I think you can probably just checkout their branch, make a new branch off it, and push it into the upstream

sleek steppe Mar 31, 2021, 10:07 PM

#

fallen patrol Needs to have a \n between both ```

That wasn't in my PR though

vale ibex Mar 31, 2021, 10:07 PM

#

I have an alias setup cpr = "!cd ${GIT_PREFIX:-.} && git fetch origin refs/pull/${1}/head && git checkout FETCH_HEAD #"

tough imp Mar 31, 2021, 10:07 PM

#

or just continue working on their branch if that's ok

vale ibex Mar 31, 2021, 10:19 PM

#

I'm going to checkout branch and push it up

#

it'll make a new PR though, so I'll action all of the comments first

fallen patrol Mar 31, 2021, 10:22 PM

#

vale ibex I have an alias setup `cpr = "!cd ${GIT_PREFIX:-.} && git fetch origin refs/pull...

What is && VS ;

gritty wind Mar 31, 2021, 10:23 PM

#

fallen patrol So it becomes ``` Fan of Python, Yada Yada yada ``` And not ```Fan of Python```

Those literally look the same on my phone lol

vocal prairie Mar 31, 2021, 10:24 PM

#

Mobile's code blocks are weird.

fallen patrol Mar 31, 2021, 10:24 PM

#

gritty wind Those literally look the same on my phone lol

You have an iPhone, this is an android bug

#

(right?)

gritty wind Mar 31, 2021, 10:24 PM

#

Discord is an Android bug

fallen patrol Mar 31, 2021, 10:24 PM

#

gritty wind Those literally look the same on my phone lol

You see the screen shot fwiw?

gritty wind Mar 31, 2021, 10:25 PM

#

Yeah

vale ibex Mar 31, 2021, 10:25 PM

#

fallen patrol What is && VS ;

What do you mean? I can't see && VS ; in that command?

vocal prairie Mar 31, 2021, 10:25 PM

#

I don't even see code blocks on android.

patent pivot Mar 31, 2021, 10:25 PM

#

vale ibex What do you mean? I can't see `&& VS ;` in that command?

&& vs using ;

sleek steppe Mar 31, 2021, 10:25 PM

#

lol

fallen patrol Mar 31, 2021, 10:25 PM

#

vale ibex What do you mean? I can't see `&& VS ;` in that command?

Oh I mean what does the ; character do VS using &&

vocal prairie Mar 31, 2021, 10:25 PM

#

I just see the ones that are like print("hello"). Everything looks like that.

patent pivot Mar 31, 2021, 10:25 PM

#

echo abc; echo def; vs echo abc && echo def

fallen patrol Mar 31, 2021, 10:25 PM

#

Yeah ^^

patent pivot Mar 31, 2021, 10:25 PM

#

the differencce iss

fallen patrol Mar 31, 2021, 10:26 PM

#

I was using && for a period and now was using ;

patent pivot Mar 31, 2021, 10:26 PM

#

; continues ignoring the previous error code

fallen patrol Mar 31, 2021, 10:26 PM

#

Ohhh

patent pivot Mar 31, 2021, 10:26 PM

#

sleek steppe Mar 31, 2021, 10:27 PM

#

one works on windows one doesn't kekwait

fallen patrol Mar 31, 2021, 10:27 PM

#

Oof

#

Btw is precommit a pydis specific thing?

#

Like, a tool written and used in the repo?

gritty wind Mar 31, 2021, 10:28 PM

#

Nah it’s a standalone package

patent pivot Mar 31, 2021, 10:28 PM

#

fallen patrol Btw is precommit a pydis specific thing?

https://pre-commit.com/

gritty wind Mar 31, 2021, 10:28 PM

#

Pretty nice tool when it works

sleek steppe Mar 31, 2021, 10:29 PM

#

I still don't get why pipenv run precommit runs differently than pipenv run pre-commit

vale ibex Mar 31, 2021, 10:29 PM

#

precommit installs the hook

gritty wind Mar 31, 2021, 10:29 PM

#

Two different commands

vale ibex Mar 31, 2021, 10:29 PM

#

pre-commit runs it

gritty wind Mar 31, 2021, 10:29 PM

#

Precommit is a custom one we defined

#

Which just runs “pre-commit install” or something along those lines

sleek steppe Mar 31, 2021, 10:29 PM

#

oh cool

whole forge Mar 31, 2021, 10:33 PM

#

doesnt have to be pipenv btw

#

its a executable that lives in your git hooks folder

#

can easily be run manually without pipenv

vale ibex Mar 31, 2021, 10:34 PM

#

Does a user lose roles when they leave a server?

fallen patrol Mar 31, 2021, 10:34 PM

#

uh

#

https://pythondiscord.com/pages/contributing/bot/#server-setup

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

very out of date template

whole forge Mar 31, 2021, 10:34 PM

#

vale ibex Does a user lose roles when they leave a server?

yes

fallen patrol Mar 31, 2021, 10:34 PM

#

https://discord.new/zmHtscpYN9E3

#

very very out of date ~~and has bad permissions too~~

vale ibex Mar 31, 2021, 10:34 PM

#

whole forge yes

Cool, I don't have to care about this case then, thanks

patent pivot Mar 31, 2021, 10:35 PM

#

lol

#

it's up to date

#

that's a 1-to-1 copy of the server we use for testing bot features now

fallen patrol Mar 31, 2021, 10:35 PM

#

patent pivot that's a 1-to-1 copy of the server we use for testing bot features now

did you just update it?

vestal heath Mar 31, 2021, 10:36 PM

#

does the....... when ducky logo appears it is shown first in log
or after the time expires ?

fallen patrol Mar 31, 2021, 10:36 PM

#

btw

#

I have a very simple idea for configuring all of the emojis

whole forge Mar 31, 2021, 10:37 PM

#

i think the one here was the very first duck, nice

gritty wind Mar 31, 2021, 10:37 PM

#

It isn’t the same structure as the main server

patent pivot Mar 31, 2021, 10:37 PM

#

fallen patrol did you just update it?

no

sleek steppe Mar 31, 2021, 10:37 PM

#

fallen patrol https://discord.new/zmHtscpYN9E3

Wait that was a thing...I didn't have to make it from scratch?

gritty wind Mar 31, 2021, 10:37 PM

#

It’s just enough to get you all the things you need

fallen patrol Mar 31, 2021, 10:37 PM

#

except for the emojis

#

anyways

gritty wind Mar 31, 2021, 10:37 PM

#

Can’t add those so

fallen patrol Mar 31, 2021, 10:37 PM

#

about that

#

idea: make a public bot that fetches all of the emojis in the test server and has one command, to add emojis to the server when invoked by the server owner

gritty wind Mar 31, 2021, 10:38 PM

#

You can put any emoji, it doesn’t have to be the trash can

fallen patrol Mar 31, 2021, 10:38 PM

#

then instantly leaves the server

whole forge Mar 31, 2021, 10:38 PM

#

things are planned for easier setup, will happen sometime™️

gritty wind Mar 31, 2021, 10:38 PM

#

The main package for that has been in review cycles

#

Probably since I joined staff but still

#

Review cycles

whole forge Mar 31, 2021, 10:39 PM

#

you mean, review closed loop?

gritty wind Mar 31, 2021, 10:39 PM

#

At this point, basically lol

fallen patrol Mar 31, 2021, 10:39 PM

#

https://pythondiscord.com/pages/contributing/bot/#server-setup also the reddit link is to an archived site

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

gritty wind Mar 31, 2021, 10:42 PM

#

I’m pretty sure that’s intentional

#

It was archived before that guide even existed

vale ibex Mar 31, 2021, 11:25 PM

#

I've raised bot#1493 as a replacement for bot#1303

dusky shoreBOT Mar 31, 2021, 11:25 PM

#

GitHub

PROpen [bot] #1493 Stream and revokestream commands
PROpen [bot] #1303 Adding <prefix>stream and <prefix>revokestream commands

vale ibex Mar 31, 2021, 11:25 PM

#

I actioned the comments from @tawdry vapor and gave it a pass myself, then tested it locally.

#

I was planning to give it another read through to make sure there wasn't anything else that I missed, but it's getting late, so I'm going to head to bed for now.

fallen patrol Mar 31, 2021, 11:35 PM

#

fallen patrol uh

zoomEyes this had the ninja duck smh

#

The first one, so that's what that was

sleek steppe Mar 31, 2021, 11:43 PM

#

already_allowed = any(Roles.video == role.id for role in user.roles)

Could be changed to

already_allowed = user._roles.has(Roles.video)

Maybe? Also I don't know why it's called user when it's a member object

vale ibex Mar 31, 2021, 11:46 PM

#

Yea that is a huge simplification, I think I remember lines like that in a few places in that cog

#

Could you add a comment against one of them to prompt me when I look tomorrow?

sleek steppe Mar 31, 2021, 11:47 PM

#

Ok

tawdry vapor Apr 1, 2021, 12:02 AM

#

I don't know if I agree

#

It seems like a bad idea to rely on private APIs

#

We currently rely on the http client but it has strong advantages and also seems like something that would be more stable.

#

Also discord.py has some attributes/functions that are named like they're public but aren't documented. I remember asking about one and was told that despite being undocumented it was virtually guaranteed to be part of the stable API

#

I don't remember why they said it isn't documented but I do remember that the reason didn't really make sense to me.

fallen patrol Apr 1, 2021, 12:08 AM

#

tawdry vapor We currently rely on the http client but it has strong advantages and also seems...

doesn't bot make its own client?

tawdry vapor Apr 1, 2021, 12:09 AM

#

Yes but I don't see why that is relevant

fallen patrol Apr 1, 2021, 12:09 AM

#

was a question, because i know that the commands.Bot class has its own bot.http class

#

basically a help question

sleek steppe Apr 1, 2021, 12:09 AM

#

Client.HTTPClient is responsible for making requests to the discord api

#

and it doesn't belong the commands.Bot it belongs the Client

tawdry vapor Apr 1, 2021, 12:12 AM

#

This was the conversation I had #381965515721146390 message

#

It eventually did get documented

sleek steppe Apr 1, 2021, 12:14 AM

#

I'm pretty sure discord.utils.SnowflakeList is made so that you can do operations like that and it's more efficient. Plus I've seen many people in that server including danny using it so ¯_(ツ)_/¯

fallen patrol Apr 1, 2021, 12:14 AM

#

sleek steppe I'm pretty sure discord.utils.SnowflakeList is made so that you can do operation...

well, danny could be an exception because y'know

tawdry vapor Apr 1, 2021, 12:15 AM

#

Many people using it doesn't necessarily imply it's stable or if discord.py would respect that and avoid breaking changes.

#

You're probably right though. It hasn't changed in 3 years.

#

The reason it isn't public is cause it'd require some extra design considerations

#

e.g. the current thing is mutable and a public API shouldn't allow the cache to be mutated.

real cosmos Apr 1, 2021, 3:25 AM

#

tawdry vapor Many people using it doesn't necessarily imply it's stable or if discord.py woul...

sounds interesting

green oriole Apr 1, 2021, 7:30 AM

#

Hey @short snow, has anyone approved https://github.com/python-discord/sir-lancebot/issues/651 ?

GitHub

Build-Your-Own Ducky! · Issue #651 · python-discord/sir-lancebot

Build-Your-Own Ducky! Well by now you know what this issue is going to be about, so lemme just brief it to you - Duckies are lovely, so why not have a command which can: Allow you to build a ducky ...

short snow Apr 1, 2021, 7:31 AM

#

green oriole Hey <@!736234578745884682>, has anyone approved https://github.com/python-discor...

nope, it has the planning label, so that tells it

green oriole Apr 1, 2021, 7:32 AM

#

Well, by putting a lot of efforts into writing an issue without coordinating with us you are risking to loose a lot of time

#

We have other plans to make duckies, I’m afraid we are not interested in that

short snow Apr 1, 2021, 7:33 AM

#

okay

#

well, if we have ducky maker on site, why not on the bot?

green oriole Apr 1, 2021, 7:43 AM

#

Because the UI will be terrible

short snow Apr 1, 2021, 7:45 AM

#

hmm true

green oriole Apr 1, 2021, 7:47 AM

#

That said, we could think into integrating the secret project into sir lance

#

Is that something you’d be interested in?

#

Sorry if my github message sounded a bit harsh, I didn’t mean to

short snow Apr 1, 2021, 7:49 AM

#

green oriole Is that something you’d be interested in?

yeah

#

no problems, it wasn't harsh 😄

green oriole Apr 1, 2021, 7:50 AM

#

Alright, I’ll make sure to assign you once the issue is created

short snow Apr 1, 2021, 7:50 AM

#

but i need to know the secret project first

green oriole Apr 1, 2021, 7:51 AM

#

Haha, you’ll know soon

#

I’ll probably take care of it tomorrow

#

Err, next week

short snow Apr 1, 2021, 7:53 AM

#

cool ok_handbutflipped

#

well @green oriole how about a duckify command which would put the person's pfp instead of the duck on the board, or make a duck pond ish on the bottom, like a layer on the bottom

#

https://images-ext-2.discordapp.net/external/9lh8u-pj0lq0OHs4xVq3YSl1T3l_B7lDoRPkxSfNF9Q/https/ducks.vcokltf.re/duck/Thanos?width=398&height=479

green oriole Apr 1, 2021, 7:55 AM

#

Hmm that sounds interesting

#

I believe @thorny obsidian is running this bot, I think that’s something we would want in sir lance at the end of the event

#

we could do some improvements like that

short snow Apr 1, 2021, 7:56 AM

#

ves is running the bot

#

he said in community meta

green oriole Apr 1, 2021, 7:56 AM

#

Ves is running @opal ridge

#

Not this one I believe

short snow Apr 1, 2021, 7:56 AM

#

i thought you were talking about that, this one means sir lance?

green oriole Apr 1, 2021, 7:57 AM

#

I was talking about integrating @spare tapir in @dusky shore

short snow Apr 1, 2021, 7:58 AM

#

oh ok

#

i never noticed they were two different bots 🤦‍♂️

#

is the repo private?

green oriole Apr 1, 2021, 8:03 AM

#

I thiiik they are private for the time being

#

You can extract the source code of @opal ridge

short snow Apr 1, 2021, 8:06 AM

#

green oriole You can extract the source code of <@!824238118118621195>

even that is private

green oriole Apr 1, 2021, 8:07 AM

#

The container is public it seems like

#

Yeah it is

short snow Apr 1, 2021, 8:10 AM

#

link?

#

#sir-lancebot-playground message the issue with random duckies, hence i asked about building your own ducky

patent pivot Apr 1, 2021, 8:22 AM

#

We'll probably make the repository public at some point, but the container is open yeah if you really want to poke around

short snow Apr 1, 2021, 8:24 AM

#

short snow link?

^

patent pivot Apr 1, 2021, 8:25 AM

#

on mobile right now

#

it should just be on the org packages

short snow Apr 1, 2021, 10:00 AM

#

ok lemme see if i can find it

#

https://github.com/orgs/python-discord/packages/container/package/ninjabot found it

GitHub

Build software better, together

GitHub is where people build software. More than 56 million people use GitHub to discover, fork, and contribute to over 100 million projects.

short snow Apr 1, 2021, 10:55 AM

#

hahaha done 😄

thorny obsidian Apr 1, 2021, 11:54 AM

#

Lmao I don't think I remembered to actually git init or make any commits to the Become a Duck bot

patent pivot Apr 1, 2021, 11:55 AM

#

lol

thorny obsidian Apr 1, 2021, 11:55 AM

#

@green oriole I thought we wanted vco's thingy as a potential lancebot command after this event?

#

But the code is real bad. I'd want to properly write it with good commits

patent pivot Apr 1, 2021, 11:56 AM

#

The issue opened wasn't for random ducks with that API, but instead for a generator (select accessories, colour)

#

so it's whether we can pull off an implementation of that which is a) resource friendly b) has nice UX

thorny obsidian Apr 1, 2021, 11:58 AM

#

Aaah, okie doke

short snow Apr 1, 2021, 12:25 PM

#

thorny obsidian But the code is real bad. I'd want to properly write it with good commits

i could do that

short snow Apr 1, 2021, 12:27 PM

#

thorny obsidian <@407110650217627658> I thought we wanted vco's thingy as a potential lancebot c...

yes that is what we discussed above, with few more features/improvements , whatever you call them, to it

short snow Apr 1, 2021, 12:32 PM

#

patent pivot so it's whether we can pull off an implementation of that which is a) resource f...

well yes,

(a) we can do this, by caching random ducks, and generating new ones, every x minutes. and then sending a random one from them. Well for the building your own ducky, if we keep maxconcurrency and a cooldown it would be good

(b) am not sure of this

patent pivot Apr 1, 2021, 12:32 PM

#

it's not a random duck generator

#

that's fine and doable because we have an api for that

short snow Apr 1, 2021, 12:34 PM

#

we could make an api for that then.

#

(which would take the resources like the dict i said in the issue, and then it would generate the ducky)

patent pivot Apr 1, 2021, 12:35 PM

#

yeah, if we write an API for the planned site generator then using it on lancebot should be no trouble

#

I'm of the opinion that it's a neat idea, but we should implement it on site and see how that goes and if that scales we look at Lancebot

short snow Apr 1, 2021, 12:37 PM

#

lemon could update his issue

green oriole Apr 1, 2021, 1:36 PM

#

thorny obsidian <@407110650217627658> I thought we wanted vco's thingy as a potential lancebot c...

Yup, that was the idea. One of the biggest issue with having a ducky maker with your own settings inside discord is that we would have to rerender and upload the new image to discord every time a setting is changed, which would hurt rate limits and resources quite a lot. I think it is better to just redirect users to the site web if they want to do that.

cold moon Apr 1, 2021, 1:39 PM

#

We could make that this renders image at server using query parameters

short snow Apr 1, 2021, 1:40 PM

#

that's what i meant, pass in something like the dict i mentioned in the issue

short snow Apr 1, 2021, 1:40 PM

#

green oriole Yup, that was the idea. One of the biggest issue with having a ducky maker with ...

like joe said, we are probably making an api for it and then using it

green oriole Apr 1, 2021, 1:42 PM

#

Well I mean, if we have to trigger another render every time you click an arrow while going through the equipment list it will probably be too heavy (CC @patent pivot )

short snow Apr 1, 2021, 1:44 PM

#

i thought just displaying the final image at the end

#

and in the list, add them as emojis

#

like:

thorny obsidian Apr 1, 2021, 1:45 PM

#

green oriole Yup, that was the idea. One of the biggest issue with having a ducky maker with ...

Yeah that makes a lot of sense~ Thanks for the clarification :D

short snow Apr 1, 2021, 1:46 PM

#

title: Build Your Own Ducky (hair emoji + skin emoji)

#

or just the name

patent pivot Apr 1, 2021, 1:46 PM

#

green oriole Well I mean, if we have to trigger another render every time you click an arrow ...

no idea without benchmarking really

green oriole Apr 1, 2021, 1:46 PM

#

Emojis would be too small I think

#

Alright, we can benchmark our aaaaAAAA implementation

short snow Apr 1, 2021, 2:18 PM

#

looks like there is quakstack project, probably our super secret project

#

i will go through it and then comment on the issues regarding duckies on lance

#

i.e. mine and lemon's

green oriole Apr 1, 2021, 2:21 PM

#

That isn’t the super secret project either :3

short snow Apr 1, 2021, 2:21 PM

#

btw can i contribute in the quakstack project, or is restricted to the staff

#

bruhhh, this is getting ...

thorny obsidian Apr 1, 2021, 2:22 PM

#

haha, our super secret project technically doesn't need to be super secret anymore, but you'll hear more about it closer to May

short snow Apr 1, 2021, 2:22 PM

#

!remind 8h Look into quackstack and comment on sir lancebot issue 651 652

stable mountainBOT Apr 1, 2021, 2:22 PM

#

You're the boss!

Your reminder will arrive in 8 hours!

short snow Apr 1, 2021, 2:22 PM

#

thorny obsidian haha, our super secret project technically doesn't need to be super secret anymo...

that's good news, gives a bit relief

#

do we really want a separate ducky bot (ves' status), and not put it into sir quaksksalot

thorny obsidian Apr 1, 2021, 2:24 PM

#

but Chris's thing was originally going to be our April Fools event for this year, but it ended up being really awesome so now it's going to be it's own thing.

green oriole Apr 1, 2021, 2:24 PM

#

It will be integrated to lance, Seb is probably working on something else

short snow Apr 1, 2021, 2:25 PM

#

hmmm, and is quakstack a api or a package to generate random duckies?

short snow Apr 1, 2021, 2:25 PM

#

thorny obsidian but Chris's thing was originally going to be our April Fools event for this year...

comeee on spill it!

thorny obsidian Apr 1, 2021, 2:26 PM

#

I won't spoil it for Chris and the rest of the team working on it~

vale ibex Apr 1, 2021, 2:26 PM

#

thorny obsidian but Chris's thing was originally going to be our April Fools event for this year...

👀

green oriole Apr 1, 2021, 2:26 PM

#

short snow hmmm, and is quakstack a api or a package to generate random duckies?

It will be everything

short snow Apr 1, 2021, 2:26 PM

#

ok, am confused rn, i will be back later

#

gtg cya!

green oriole Apr 1, 2021, 2:26 PM

#

if I understand the project correctly, it will be a core PyPI package with a microservice and a CLI

#

cya

short snow Apr 1, 2021, 4:04 PM

#

green oriole if I understand the project correctly, it will be a core PyPI package with a mic...

ok, thanks

#

is it going to be used with our projects?

green oriole Apr 1, 2021, 4:05 PM

#

Which part with which project?

short snow Apr 1, 2021, 4:05 PM

#

the quakstack with site and lance

green oriole Apr 1, 2021, 4:06 PM

#

Yeah sure

short snow Apr 1, 2021, 4:06 PM

#

so no need to write an api for it?

green oriole Apr 1, 2021, 4:07 PM

#

I’m not too sure about the structure of the project itself, I’d say let’s see when we get to it

short snow Apr 1, 2021, 4:12 PM

#

discord.Guild.fetch_member uses an extra API call, instead is using discord.Guild.get_member better?

#

context: chris' stream PR

vale ibex Apr 1, 2021, 4:13 PM

#

Yea, we are using get_member first

#

if that fails (because the user isn't in the cache) we fall back to fetch

short snow Apr 1, 2021, 4:14 PM

#

ok.

#

fetch member raises this according to the docs

vale ibex Apr 1, 2021, 4:15 PM

#

@tawdry vapor hah! I actually thought of the arrow thing before bed last night, so made the changes already. The only difference is that scheduler.schedule_at needs a naive datetime, so I use arrow.utcnow().naive

vale ibex Apr 1, 2021, 4:15 PM

#

short snow fetch member raises this according to the docs

yea, it also raises a few other things too, which aren't documented sadly

short snow Apr 1, 2021, 4:17 PM

#

vale ibex yea, it also raises a few other things too, which aren't documented sadly

right

#

so you are right on that comment on mark ig

vale ibex Apr 1, 2021, 4:18 PM

#

yea, those are the ones we're already capturing, so should be good.

#

both forbidden and discordservererror are handled elsewhere, as they wouldn't be limitted to this cog if they start happening

short snow Apr 1, 2021, 4:20 PM

#

btw is quakstack open for contributions or limited to staff

green oriole Apr 1, 2021, 4:21 PM

#

Good question

#

Hey @crude gyro are you taking care of quackstack?

short snow Apr 1, 2021, 4:22 PM

#

oh god, these ducky names, i need to click everytime on the person to see who it is

fallen patrol Apr 1, 2021, 4:22 PM

#

same

short snow Apr 1, 2021, 4:23 PM

#

there is our ninjaducky lurker

crude gyro Apr 1, 2021, 4:32 PM

#

@green oriole I'm not implementing it, no. my contribution was to specify all the issues, the rest is up to you all.

short snow Apr 1, 2021, 4:32 PM

#

one more thing, instead of putting the whole branding repo, and opening the project time taking, why not just put the ducky assets tehre

green oriole Apr 1, 2021, 4:33 PM

#

Alrighty

short snow Apr 1, 2021, 4:33 PM

#

crude gyro <@407110650217627658> I'm not implementing it, no. my contribution was to specif...

well https://github.com/python-discord/quackstack/issues/6 is already mentioned ig, i see poetry.lock there

GitHub

Set up Poetry for dependency management. · Issue #6 · python-discor...

Let's use Poetry for dependency management in this application, since we're planning on pushing it to PyPI as well.

green oriole Apr 1, 2021, 4:33 PM

#

I think branding is a good place to centralize all of our content

#

You don’t have to hunt it here and there, it is all in one place

short snow Apr 1, 2021, 4:33 PM

#

yeah, am just saying to link only the quakstack

#

the branding repo is bigg

green oriole Apr 1, 2021, 4:33 PM

#

and if we want to share assets between projects we have a common place

green oriole Apr 1, 2021, 4:34 PM

#

short snow well https://github.com/python-discord/quackstack/issues/6 is already mentioned ...

@fervent sage is way too fast haha. Can we close this issue?

short snow Apr 1, 2021, 4:36 PM

#

should i go ahead and do this? https://github.com/python-discord/quackstack/issues/4

GitHub

CI: Linting and pre-commit · Issue #4 · python-discord/quackstack

Let's set up linting, pre-commit, all that basic stuff we have everywhere.

fervent sage Apr 1, 2021, 4:37 PM

#

go for it

short snow Apr 1, 2021, 4:38 PM

#

cool

#

@green oriole https://github.com/python-discord/sir-lancebot/issues/651 can we do this, since we have quakstack now? and if not, we can write an api for it

GitHub

Build-Your-Own Ducky! · Issue #651 · python-discord/sir-lancebot

Build-Your-Own Ducky! Well by now you know what this issue is going to be about, so lemme just brief it to you - Duckies are lovely, so why not have a command which can: Allow you to build a ducky ...

green oriole Apr 1, 2021, 4:38 PM

#

Let’s wait until quackstack is ready and talk about what we can do then

short snow Apr 1, 2021, 4:40 PM

#

uhh ok, we could possibly keep it open and with defferd label, so even others could share their input

#

as expected, it took quite some time cloning it

green oriole Apr 1, 2021, 4:45 PM

#

Alright, now that we discussed it I don’t mind leaving it open

#

Hmmmm

#

lemon has another issue

#

Whatever, let’s keep both open

short snow Apr 1, 2021, 4:46 PM

#

cool

#

is quakstack using 3.8 or 3.9

#

3.8+ ok cool (in pyproject.toml)

green oriole Apr 1, 2021, 4:50 PM

#

Consider that to be 3.9 ( lemon_warpaint @fervent sage)

#

/s

fervent sage Apr 1, 2021, 4:50 PM

#

kek

crude gyro Apr 1, 2021, 4:59 PM

#

green oriole Whatever, let’s keep both open

I don't think we need both to be open. I feel like my comment in https://github.com/python-discord/sir-lancebot/issues/651 was pretty clear.

@short snow

GitHub

Build-Your-Own Ducky! · Issue #651 · python-discord/sir-lancebot

Build-Your-Own Ducky! Well by now you know what this issue is going to be about, so lemme just brief it to you - Duckies are lovely, so why not have a command which can: Allow you to build a ducky ...

#

to be even clearer - https://github.com/python-discord/sir-lancebot/issues/652 replaces #651. But if you want to handle it jason that's still fine, I don't want to do it.

GitHub

.quack - Procedural Duck Generator! · Issue #652 · python-discord/s...

Description A command to fetch a random duck from QuackStack. https://github.com/python-discord/quackstack Proposed Implementation This command can be called in two ways: With .quack, you simply ge...

short snow Apr 1, 2021, 5:03 PM

#

ok cool, i will implement it once quakstack is done

#

uhh cc: @fervent sage

green oriole Apr 1, 2021, 5:04 PM

#

Alright, if we agree to not have a ducky builder let’s close it then, but I thought some people still wanted to discuss it

fallen patrol Apr 1, 2021, 5:05 PM

#

short snow uhh cc: <@!297045071457681409>

👀 what are you using that has thee nice cli

#

and the branch and such

short snow Apr 1, 2021, 5:05 PM

#

zsh and spaceship

#

another thing, quacken, should I use flakehell or just install them normally?

vale ibex Apr 1, 2021, 5:59 PM

#

@tawdry vapor Just to double check, since I'm still new to dealing with timezones. Do you think this diff would work for changing schedule_at()? ```diff

delay = (time - datetime.utcnow()).total_seconds()

delay = (time - datetime.now(time.tzinfo or timezone.utc)).total_seconds()

#

It works in testing at least, for both naive and aware

tawdry vapor Apr 1, 2021, 6:03 PM

#

Looks fine and if you say your tests work then go for it

vale ibex Apr 1, 2021, 6:04 PM

#

Cool, what did we decide on for member._roles.has()

#

Is it too risky to use?

tawdry vapor Apr 1, 2021, 6:05 PM

#

There's no decision

#

Wait

#

That diff may be wrong

#

Because if you pass a naïve time it will use timezone.utc which makes the other operand aware.

vale ibex Apr 1, 2021, 6:08 PM

#

So just delay = (time - datetime.now(time.tzinfo)).total_seconds() then, makes sense

#

since tzinfo being none means naive

#

but that doesn't offset to utc

tawdry vapor Apr 1, 2021, 6:09 PM

#

I believe datetime.now(time.tzinfo) if time.tzinfo else datetime.utcnow()

#

Though at that point it wouldn't look nice in-line

vale ibex Apr 1, 2021, 6:09 PM

#

yea, I'll expand it to a full if statement

stable mountainBOT Apr 1, 2021, 10:22 PM

#

@short snow

It has arrived!

Here's your reminder: Look into quackstack and comment on sir lancebot issue 651 652.
[Jump back to when you created the reminder](#dev-contrib message)

whole forge Apr 1, 2021, 10:32 PM

#

fallen patrol 👀 what are you using that has thee nice cli

you can use oh-my-posh for that which despite the name is crossplatform and cross-shell. https://ohmyposh.dev/

short snow Apr 2, 2021, 12:53 AM

#

#changelog message perfectt!

patent pivot Apr 2, 2021, 12:56 AM

#

we're switching back to pyweek branding 😄

short snow Apr 2, 2021, 1:12 AM

#

short snow well <@!407110650217627658> how about a duckify command which would put the pers...

should open a issue for this?

short snow Apr 2, 2021, 1:37 AM

#

@fervent sage https://ducks.vcokltf.re/duck/ilcheese2 there seems to be some issues with the ducky here, the beard and outfit.

thorny obsidian Apr 2, 2021, 1:37 AM

#

lmao that's perfect imo

short snow Apr 2, 2021, 1:39 AM

#

perfect?

thorny obsidian Apr 2, 2021, 1:39 AM

#

oh yes, perfect.

sleek steppe Apr 2, 2021, 1:45 AM

#

Lol

short snow Apr 2, 2021, 1:47 AM

#

welp, but yeah we could either make some cases which don't match together or edit the assets to make it match

#

like making the beard end smoothly

short snow Apr 2, 2021, 11:15 AM

#

@patent pivot https://github.com/python-discord/quackstack/pull/14/commits/068ad5b97d271a063fcea50cf9923041af12da59 this the bug you are facing on olli

GitHub

Setup linting and pre-commit. by Shivansh-007 · Pull Request #14 · ...

Closes #4.
This PR adds a flake8 and pre-commit linting toolchain.

#

probably

patent pivot Apr 2, 2021, 11:17 AM

#

oh I think

#

wait

#

i thinkk it's linting all the code in the venv or something

short snow Apr 2, 2021, 11:18 AM

#

uhh, idts

#

try using .flake8 and see once

patent pivot Apr 2, 2021, 11:18 AM

#

look at this run https://github.com/python-discord/olli/runs/2253404822?check_suite_focus=true

short snow Apr 2, 2021, 11:19 AM

#

looks like that

gritty wind Apr 2, 2021, 11:19 AM

#

that would explain the sheer number of warnings

patent pivot Apr 2, 2021, 11:19 AM

#

hahahah yeah

short snow Apr 2, 2021, 11:19 AM

#

but annotation works on my pr correctly

patent pivot Apr 2, 2021, 11:19 AM

#

not sure what it's doing though

#

because uhh

#

it shouldn't have a venv

gritty wind Apr 2, 2021, 11:19 AM

#

it is

patent pivot Apr 2, 2021, 11:19 AM

#

ah

#

wait

#

.cache

#

yeah

gritty wind Apr 2, 2021, 11:19 AM

#

it is not using venvs

#

Yeah the updates

#

more likely

#

it's in the wrong dir

green oriole Apr 2, 2021, 11:20 AM

#

Two minutes long linting hahaha

gritty wind Apr 2, 2021, 11:20 AM

#

so the site packages are in the same dir as the project

patent pivot Apr 2, 2021, 11:21 AM

#

this should do it

#

golden

short snow Apr 2, 2021, 11:22 AM

#

yeah works

#

hmm, why tox.ini was failing on my pr

patent pivot Apr 2, 2021, 11:22 AM

#

now I just need a docker image and we shoooooould be good to go to prod

gritty wind Apr 2, 2021, 11:23 AM

#

Why don't we have a project tempelate

#

most of our stacks are carbon copies

patent pivot Apr 2, 2021, 11:23 AM

#

yeah

patent pivot Apr 2, 2021, 12:25 PM

#

apologies for dev log today lol

#

i do bring good news though, olli now deploys successfully

short snow Apr 2, 2021, 12:32 PM

#

patent pivot apologies for dev log today lol

lol, now it would be easier for me to add it to quakstack

patent pivot Apr 2, 2021, 12:32 PM

#

is quackstack not in #dev-log yet

short snow Apr 2, 2021, 12:33 PM

#

nope

vale ibex Apr 2, 2021, 1:28 PM

#

sir-lancebot#577 just needs 1 more review on it, it deals with the bot.exts.evergreen.error_handler ERROR: Unhandled command error: 'User' object has no attribute 'roles' we see in the service logs
~~Its also the last branch on my fork, so I'll finally be able to delete it 😂 ~~

dusky shoreBOT Apr 2, 2021, 1:28 PM

#

GitHub

PROpen [sir-lancebot] #577 First pass of easy to produce errors

gritty wind Apr 2, 2021, 1:31 PM

#

jealous 😢

#

I can take a look at it tonight

#

!remind 8H review

stable mountainBOT Apr 2, 2021, 1:31 PM

#

Sure thing!

Your reminder will arrive in 8 hours!

gritty wind Apr 2, 2021, 1:31 PM

#

If someone gets to it first, delete that please lol

vale ibex Apr 2, 2021, 1:32 PM

#

!remind 470M 386599446571384843 check review and delete remind if it's done

stable mountainBOT Apr 2, 2021, 1:32 PM

#

Affirmative!

Your reminder will arrive in 7 hours and 50 minutes!

gritty wind Apr 2, 2021, 1:32 PM

#

Lmao

vale ibex Apr 2, 2021, 1:32 PM

#

😄

short snow Apr 2, 2021, 1:37 PM

#

even this lemon_long lol

gritty wind Apr 2, 2021, 1:40 PM

#

That was a pretty small diff lol

vocal prairie Apr 2, 2021, 2:51 PM

#

Random thought. The in-site thing for customizing ducks would be cool if it was like https://lemonsaur.us

Lemonsaurus!

The personal website of Leon Sandøy

patent pivot Apr 2, 2021, 4:42 PM

#

vocal prairie Random thought. The in-site thing for customizing ducks would be cool if it was ...

completely agree, lemon did a really neat job of that

patent pivot Apr 2, 2021, 5:06 PM

#

okay moment of truth for olli 😄

#

let's see if this release actually works

#

need to fix the tagging

#

but otherwise

#

v good!

#

https://github.com/orgs/python-discord/packages/container/package/olli

GitHub

Build software better, together

GitHub is where people build software. More than 56 million people use GitHub to discover, fork, and contribute to over 100 million projects.

vale ibex Apr 2, 2021, 5:11 PM

#

What's Loki?

patent pivot Apr 2, 2021, 5:14 PM

#

vale ibex What's Loki?

https://grafana.com/oss/loki/

Grafana Labs

Grafana Loki

Loki is a horizontally-scalable, highly-available, multi-tenant log aggregation system inspired by Prometheus. It is designed to be very cost effective and …

#

The thing that powers service logs on grafana

vale ibex Apr 2, 2021, 5:16 PM

#

Huh that's cool

green oriole Apr 2, 2021, 6:14 PM

#

@patent pivot https://github.com/python-discord/olli/pull/1

GitHub

Add case sensitive tokens by jb3 · Pull Request #1 · python-discord...

Users may want certain tokens to be case sensitive and only trigger as written exactly in the token configuration.
This PR implements a case sensitive flag for users to specify which forces matches...

patent pivot Apr 2, 2021, 6:14 PM

#

lmfao

patent pivot Apr 2, 2021, 6:40 PM

#

did i like my docs here yet

#

https://python-discord.github.io/olli/

Olli

Olli searches your Loki logs and relays matching terms to Discord.

#

everyone go oggle over how great my docs are

gritty wind Apr 2, 2021, 6:41 PM

#

You don’t have a slim version

#

Which is just rude

green oriole Apr 2, 2021, 6:41 PM

#

Everybody should have slim version

#

Even if it is the exact same

#

Minus one file

patent pivot Apr 2, 2021, 6:42 PM

#

lol

#

it's built on python slim how muCH MORE SSLIM DO YOU WANT

gritty wind Apr 2, 2021, 6:42 PM

#

Unironically, that may be easier, even if it’s an alias haha

#

I want to type slim

green oriole Apr 2, 2021, 6:43 PM

#

patent pivot it's built on python slim how muCH MORE SSLIM DO YOU WANT

Delete /

patent pivot Apr 2, 2021, 6:43 PM

#

I get slim for images that people are building off

#

but not for standalone thingss

green oriole Apr 2, 2021, 6:44 PM

#

Smh

#

That isn't open source friendly

#

I am disappointed

gritty wind Apr 2, 2021, 6:44 PM

#

I was setting up ghost yesterday

#

They have an alpine and a regular image

green oriole Apr 2, 2021, 6:44 PM

#

Ung, not alpine

gritty wind Apr 2, 2021, 6:44 PM

#

And I don’t understand why they don’t just have the alpine

green oriole Apr 2, 2021, 6:44 PM

#

Whatdidyoujustsay

gritty wind Apr 2, 2021, 6:45 PM

#

Well look at it this way

green oriole Apr 2, 2021, 6:45 PM

#

Musl SUCKS

gritty wind Apr 2, 2021, 6:45 PM

#

How often will you need the bigger image outside of dev

green oriole Apr 2, 2021, 6:45 PM

#

Get that garbage outta here

#

Get Alpine, Void and similar INTO THE SUN

patent pivot Apr 2, 2021, 6:45 PM

#

green oriole Musl SUCKS

not for long

#

!pep 656

stable mountainBOT Apr 2, 2021, 6:45 PM

#

**PEP 656 - Platform Tag for Linux Distributions Using Musl**

Link

Status

Draft

Created

17-Mar-2021

Type

Informational

patent pivot Apr 2, 2021, 6:46 PM

#

we'll have musl wheels soon, which might ease some of the pain

green oriole Apr 2, 2021, 6:46 PM

#

lemon_sentimental lemon_pensive

#

Don't...

#

Target musl

patent pivot Apr 2, 2021, 6:46 PM

#

well, I guess it's a draft, but we'll see

green oriole Apr 2, 2021, 6:46 PM

#

Don't support this

patent pivot Apr 2, 2021, 6:46 PM

#

I don't think it's like

#

a goal to switch from libc to musl

#

it's just a move to try support both lol

gritty wind Apr 2, 2021, 6:46 PM

#

green oriole Musl SUCKS

I tried googling musl, but my phone took me to a muslim dating site lmao

#

Are you actually on pypi yet

green oriole Apr 2, 2021, 6:47 PM

#

Hahaha

#

Look at musl libc

green oriole Apr 2, 2021, 6:47 PM

#

patent pivot it's just a move to try support both lol

But by supporting both you are saying that musl is fine

#

But it is NOT

patent pivot Apr 2, 2021, 6:48 PM

#

gritty wind Are you actually on pypi yet

who

gritty wind Apr 2, 2021, 6:48 PM

#

Akarys is being paid by big anti musl

patent pivot Apr 2, 2021, 6:48 PM

#

green oriole But by supporting both you are saying that musl is fine

it's not fine yet mmLul

gritty wind Apr 2, 2021, 6:48 PM

#

Ollie

patent pivot Apr 2, 2021, 6:48 PM

#

!pypi olli

stable mountainBOT Apr 2, 2021, 6:48 PM

#

olli v0.1.0

Olli searches your Loki logs and relays matching terms to Discord.

gritty wind Apr 2, 2021, 6:48 PM

#

Near

green oriole Apr 2, 2021, 6:48 PM

#

gritty wind Akarys is being paid by big anti musl

I am the anti musl

vocal prairie Apr 2, 2021, 6:49 PM

#

patent pivot https://python-discord.github.io/olli/

Ooh, fancy.

fallen patrol Apr 2, 2021, 7:10 PM

#

I'm extremely just nitpicking here

#

https://github.com/python-discord/sir-lancebot/blob/0f69e00aa55ca7294e71e19ab41b57bef7a9f977/bot/exts/halloween/spookynamerate.py#L369

patent pivot Apr 2, 2021, 7:10 PM

#

lol

#

open a PR if it's a huge peeve

#

otherwise it doesn't matter

fallen patrol Apr 2, 2021, 7:11 PM

#

zoomEyes

green oriole Apr 2, 2021, 7:11 PM

#

Tbh we are already issuing warning for missing channels

fallen patrol Apr 2, 2021, 7:11 PM

#

seasonal bot not sir-lancebot

#

issue isn't the warning its the reference to the old name

patent pivot Apr 2, 2021, 7:12 PM

#

that's fine

#

posting a link here is fine and all, but there's no point mobilising someone else for a one line change

#

if it's a huge problem for you we'll accept a PR

stable mountainBOT Apr 2, 2021, 9:22 PM

#

@vale ibex

It has arrived!

Here's your reminder: 386599446571384843 check review and delete remind if it's done.
[Jump back to when you created the reminder](#dev-contrib message)

vale ibex Apr 2, 2021, 9:22 PM

#

!remind delete 1845

stable mountainBOT Apr 2, 2021, 9:22 PM

#

I don't think so.

You can't modify reminders of other users!

vale ibex Apr 2, 2021, 9:22 PM

#

oh lol, rip @gritty wind

patent pivot Apr 2, 2021, 9:26 PM

#

!remind delete 1845

stable mountainBOT Apr 2, 2021, 9:26 PM

#

Affirmative!

That reminder has been deleted successfully!

patent pivot Apr 2, 2021, 9:26 PM

#

WINNER

#

saving scaleios one reminder at a time

#

wait chris pinged him anyway wow chris

vale ibex Apr 2, 2021, 9:28 PM

#

gottem

fallen patrol Apr 2, 2021, 9:29 PM

#

!src something that doesn't exist

stable mountainBOT Apr 2, 2021, 9:29 PM

#

Bad argument

Unable to convert 'something that doesn't exist' to valid command, tag, or Cog.

fallen patrol Apr 2, 2021, 9:30 PM

#

so... why do some error messages delete and others don't?

patent pivot Apr 2, 2021, 9:31 PM

#

lancebot ones do

#

bot ones don't

#

that was from memory so may be wrong

sleek steppe Apr 2, 2021, 9:34 PM

#

kinda wish the docs command error messages wasn't an auto delete but a trashcan

fallen patrol Apr 2, 2021, 10:31 PM

#

.src something that doesn't exist pt 2

#

I-

fallen patrol Apr 2, 2021, 10:32 PM

#

patent pivot lancebot ones do

Lancebot is much more restrictive than bot lmao

patent pivot Apr 2, 2021, 10:32 PM

#

intentionally

fallen patrol Apr 2, 2021, 10:33 PM

#

Why

#

Is it because of bot vs sir complexity?

patent pivot Apr 2, 2021, 10:34 PM

#

lancebot has more publicly facing features

#

and larger embeds etc.

fallen patrol Apr 2, 2021, 10:35 PM

#

Ah

#

Fwiw I was talking about the src command not being allowed in the same channels as bot source

fallen patrol Apr 2, 2021, 11:02 PM

#

well that's a nice issue

#

sirlancebot#653

dusky shoreBOT Apr 2, 2021, 11:02 PM

#

GitHub

PRMerged [bot] #653 Allow helpers to nominate people

fallen patrol Apr 2, 2021, 11:03 PM

#

sir-lancebot#653

dusky shoreBOT Apr 2, 2021, 11:03 PM

#

GitHub

IssueOpen [sir-lancebot] #653 Add internal evaluation to sir-lancebot

fallen patrol Apr 2, 2021, 11:03 PM

#

dusky shore

lmao bug

vocal prairie Apr 2, 2021, 11:04 PM

#

Ye, because it only looks for the "bot" part.

#

After it checks for sir-lancebot.

#

Which wasn't there.

sleek steppe Apr 2, 2021, 11:06 PM

#

Which is why dyi5fsefcsebot#653gy6gfrtt works

dusky shoreBOT Apr 2, 2021, 11:06 PM

#

GitHub

PRMerged [bot] #653 Allow helpers to nominate people

vocal prairie Apr 2, 2021, 11:07 PM

#

mhm

vale ibex Apr 2, 2021, 11:37 PM

#

@cold island @patent pivot I've got that fix to issues here https://github.com/python-discord/sir-lancebot/pull/577

GitHub

First pass of easy to produce errors by ChrisLovering · Pull Reques...

Relevant Issues

Closes #576
Description

I've made sure that anywhere with an on_message listener properly deals with messages from within DMs. This has been done by checking if message.g...

patent pivot Apr 2, 2021, 11:37 PM

#

hah

vale ibex Apr 2, 2021, 11:38 PM

#

slightly different implementation, since it assumes the config is setup right

#

so it only fails in DMs

patent pivot Apr 2, 2021, 11:38 PM

#

lgtm

#

where are we at on the comment from scale

vale ibex Apr 2, 2021, 11:40 PM

#

my last commit was to resolve that

patent pivot Apr 2, 2021, 11:40 PM

#

hmm

#

ahh

#

yeah

#

alright, well then

#

morge

#

shipit

vale ibex Apr 2, 2021, 11:41 PM

#

🎉 Can delete my fork now too 😂

short snow Apr 3, 2021, 7:32 AM

#

@vocal wolf #dev-log message what do you think would be a good explaination here?

#

@fervent sage opened lint and ghcr pull requests on quackstack ducky_wizard

#

can we add quackstack to #dev-log

balmy sparrow Apr 3, 2021, 10:38 AM

#

What's quackstack?

gritty wind Apr 3, 2021, 10:39 AM

#

https://github.com/python-discord/quackstack

#

It makes ducks

placid ermine Apr 3, 2021, 10:39 AM

#

naturally

balmy sparrow Apr 3, 2021, 10:41 AM

#

Neat

patent pivot Apr 3, 2021, 11:54 AM

#

i will add it now

patent pivot Apr 3, 2021, 11:55 AM

#

short snow can we add quackstack to <#622895325144940554>

done

#

also reviewed your PR

balmy sparrow Apr 3, 2021, 12:25 PM

#

how does the https://git.pydis.com links work?

patent pivot Apr 3, 2021, 12:27 PM

#

balmy sparrow how does the <https://git.pydis.com> links work?

We use a Traefik middleware that looks like this:

apiVersion: traefik.containo.us/v1alpha1
kind: Middleware
metadata:
  name: github-redirect
spec:
  redirectRegex:
    regex: ^https://git.pythondiscord.com/(.*)
    replacement: http://github.com/python-discord/${1}

#

so basically any request to git.pythondiscord.com/* has that last bit captured and then we redirect to github.com/python-discord/<whatever was in *>

balmy sparrow Apr 3, 2021, 12:28 PM

#

ah interesting

patent pivot Apr 3, 2021, 12:28 PM

#

https://doc.traefik.io/traefik/middlewares/redirectregex/

RedirectRegex - Traefik

Traefik Documentation

balmy sparrow Apr 3, 2021, 12:30 PM

#

right thanks

#

i probably don't need to be setting something like that up for myself haha

patent pivot Apr 3, 2021, 12:33 PM

#

there are other ways to achieve things like that, it's entirely doable through cloudflare or just pure nginx

balmy sparrow Apr 3, 2021, 12:38 PM

#

i'll look into it, thanks 👌

short snow Apr 3, 2021, 12:42 PM

#

patent pivot done

perfect!

wise oriole Apr 3, 2021, 12:43 PM

#

can I suggest one addition to the .bm or .bookmark command?

patent pivot Apr 3, 2021, 12:43 PM

#

for sure

wise oriole Apr 3, 2021, 12:43 PM

#

okay.

tough imp Apr 3, 2021, 12:44 PM

#

patent pivot there are other ways to achieve things like that, it's entirely doable through c...

would you be able to give a quick summary for why you've chosen traefik over nginx?

patent pivot Apr 3, 2021, 12:45 PM

#

primarily really nice integration with kubernetes

#

we use the traefik CRDs (custom resource definitions) so that we can declare ingress routes into our cluster in the same way we'd declare a deployment or a configuration file

#

like uhhh

short snow Apr 3, 2021, 12:45 PM

#

what is the con with nginx in kuber?

patent pivot Apr 3, 2021, 12:45 PM

#

let me find a nice ingress

wise oriole Apr 3, 2021, 12:46 PM

#

so.. it would be nice if other users get a dm from the bot too when they react with 📨 on the message that the user sent. Currently you have to resend the .bm message to find out what the bot dm'ed. but reacting with the emoji to make the bot send it to you too would be a nice addition

#

.bm 827886705603772486 by reacting to the emoji below 👇

#

oops

patent pivot Apr 3, 2021, 12:46 PM

#

apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: site
spec:
  entryPoints:
    - websecure
  routes:
  - match: Host(`pythondiscord.com`) || Host(`api.pythondiscord.com`)
    kind: Rule
    services:
    - name: site
      port: 80
  - match: Host(`staff.pythondiscord.com`)
    kind: Rule
    services:
    - name: site
      port: 80
    middlewares:
    - name: site-cloudflare-access
  tls:
    certResolver: cfresolver
    domains:
    - main: "*.pythondiscord.com"
      sans: [pythondiscord.com]

#

here is an ingress for traefik

vale ibex Apr 3, 2021, 12:48 PM

#

wise oriole so.. it would be nice if other users get a dm from the bot too when they react w...

https://github.com/python-discord/sir-lancebot/pull/645 🙂

GitHub

Bookmark command allows other users to bookmark the same message by...

Relevant Issues

Closes #341
Description

Removed the previous ✉ emoji that got added the to author's message.
Replaced it with the below functionality:
When someone calls .bm on a message...

wise oriole Apr 3, 2021, 12:48 PM

#

ohhh

#

this was already..

#

kk

patent pivot Apr 3, 2021, 12:48 PM

#

it's in a readable format and is quite easy to follow, but to explain a bit:

entrypoint is the port that traefik is responding on

routes are the route entries that this ingress is responsible for, in this case pythondiscord.com, api.pythondiscord.com and staff.pythondiscord.com, you can see that the last one has a middleware configured which verifies that requests to it are from authenticated users from our SSO provider

tls is just TLS config, traefik will automatically generate and serve SSL certificates (big pro over nginx which needs a separate cert-manager deployment). you can see we use *.pythondiscord.com as the main name and for site we also add in pythondiscord.com as a SAN (subject alternate name)

tough imp Apr 3, 2021, 12:49 PM

#

mm yeah, the kubernetes integration is probably not that interesting to me right now but the SSL management sounds awesome

patent pivot Apr 3, 2021, 12:49 PM

#

basically traefik is a lot more bundled together and is a simpler setup process imo

#

what provider are you using for deployment? it has a lot of integrations

short snow Apr 3, 2021, 12:50 PM

#

patent pivot it's in a readable format and is quite easy to follow, but to explain a bit: en...

sounds interesting, used nginx before, never heard of traefik until on now.

patent pivot Apr 3, 2021, 12:50 PM

#

#

traefik can pick stuff up from all those providers

tough imp Apr 3, 2021, 12:50 PM

#

i'm not even using docker right now, it's nginx -> gunicorn -> flask directly on the host, and I deploy via git pulls 🤡

#

but I'm trying to learn

patent pivot Apr 3, 2021, 12:51 PM

#

hahaha

#

traefik also has a nice set of middleware

#

#

we're also doing stuff like client authenticated TLS pulls

#

so when our traefik instance gets a request as well as presenting a certificate for pythondiscord.com it also asks the client to present a certificate so we can verify it comes from either Cloudflare or a member of the DevOps team

tough imp Apr 3, 2021, 12:54 PM

#

i may try to migrate my app to traefik for the sake of experience

patent pivot Apr 3, 2021, 12:54 PM

#

#

if the load balancer is hit directly

tough imp Apr 3, 2021, 12:55 PM

#

I'd like to containerize everything but last time I was looking into it, I didn't see an obvious way to use certbot in the nginx container

#

and that's what I got stuck on

patent pivot Apr 3, 2021, 12:55 PM

#

oh yeah, traefik 100% solves that

#

we use the DNS-01 ACME challenge with the Cloudflare integration, entirely transparent with auto-renew

tough imp Apr 3, 2021, 12:57 PM

#

sounds awesome

#

may look into it later today

patent pivot Apr 3, 2021, 1:02 PM

#

traefik also has metrics mmLul

thorny obsidian Apr 3, 2021, 1:02 PM

#

The real reason joe likes traefik: graphs

short snow Apr 3, 2021, 1:02 PM

#

Also someone needs to clear the mentioned issues on quakstack

#

like adding assets to branding, and poetry setup

patent pivot Apr 3, 2021, 1:03 PM

#

on it

#

https://github.com/python-discord/quackstack/pull/15 i have a suggestion here

GitHub

Add lint workflow. by Shivansh-007 · Pull Request #15 · python-disc...

NOTE: This PR is blocked by #14, so wait for that to be merged first.
This PR adds a workflow running linting, with pip caching.

short snow Apr 3, 2021, 1:04 PM

#

ok, will have a look

short snow Apr 3, 2021, 1:08 PM

#

patent pivot https://github.com/python-discord/quackstack/pull/15 i have a suggestion here

fixed.

patent pivot Apr 3, 2021, 1:10 PM

#

lol, I foiled the linting

#

nice

short snow Apr 3, 2021, 1:11 PM

#

https://github.com/python-discord/quackstack/issues/6 this is already done

GitHub

Set up Poetry for dependency management. · Issue #6 · python-discor...

Let's use Poetry for dependency management in this application, since we're planning on pushing it to PyPI as well.

#

if i approve 17, will u merge it pithink

patent pivot Apr 3, 2021, 1:12 PM

#

looks like more whitespace fixes are needed

#

one second

#

I'll bundle them into this PR

#

ahh yeah there are loads of linting fixes needed

short snow Apr 3, 2021, 1:16 PM

#

patent pivot ahh yeah there are loads of linting fixes needed

yeah, vco should fix those ig

#

since it is his code, he knows it th best

gritty wind Apr 3, 2021, 1:16 PM

#

Linting should be pretty easy to fix without knowing context too much

patent pivot Apr 3, 2021, 1:17 PM

#

most should be fixable yeah

#

I don't mind doing it

short snow Apr 3, 2021, 1:18 PM

#

i was talking about doc strings mainly

patent pivot Apr 3, 2021, 1:19 PM

#

ah, most are self-explanatory through code though, there isn't loads of code

short snow Apr 3, 2021, 1:19 PM

#

yeah, do it or i can do it in 2-3 hours

patent pivot Apr 3, 2021, 1:22 PM

#

branding is such a pain to clone jfc

#

I'm 2.5 minutes in and it hasn't got past Cloning into '/Users/joseph/Desktop/Python/quackstack/branding'...

gritty wind Apr 3, 2021, 1:23 PM

#

Is it the size?

#

If that’s it, we can move the duckies out to another repo, and have quack stack pull only those

patent pivot Apr 3, 2021, 1:24 PM

#

I think it's the size, but it might also just be because I'm on a slowish connection

#

but yeah, I can't start the app

#

but that's fine, I was only testing a return value but I got it anyway

short snow Apr 3, 2021, 1:25 PM

#

patent pivot branding is such a pain to clone jfc

yeah, i had suggested it before too, in this chat

#

to just catch a release containing only duck assets

#

or a branch with only duck assets

patent pivot Apr 3, 2021, 1:26 PM

#

taskipy is cool

short snow Apr 3, 2021, 1:26 PM

#

it took 2min40 sec for me

patent pivot Apr 3, 2021, 1:26 PM

#

branch will still have the same problems

#

yeah I was still going at 5 minutes so I killed it

short snow Apr 3, 2021, 1:27 PM

#

patent pivot branch will still have the same problems

same problems meaning?

patent pivot Apr 3, 2021, 1:27 PM

#

huge clone time

#

that's not the intended usage of branches, branches should always be mergeable

short snow Apr 3, 2021, 1:28 PM

#

yeah

#

what other options do we have, or we have to stay with this

gritty wind Apr 3, 2021, 1:36 PM

#

gritty wind If that’s it, we can move the duckies out to another repo, and have quack stack ...

^

short snow Apr 3, 2021, 1:37 PM

#

i was just a second too fast

patent pivot Apr 3, 2021, 1:37 PM

#

okay added a load of pep8 fixes

#

CI passed

vocal prairie Apr 3, 2021, 1:41 PM

#

Yay!

short snow Apr 3, 2021, 1:49 PM

#

also update your branch name joe.

sleek steppe Apr 3, 2021, 1:50 PM

#

pipenv run precommit

gritty wind Apr 3, 2021, 1:52 PM

#

The instructions for each project are also included in the project’s Readme

short snow Apr 3, 2021, 1:53 PM

#

gritty wind The instructions for each project are also included in the project’s Readme

not for all.

#

the contributing guide has

cold moon Apr 3, 2021, 1:53 PM

#

I'd say that Duckstack should use API to fetch all ducky assets file paths and then pull these

short snow Apr 3, 2021, 1:54 PM

#

that is something like what joe suggested

gritty wind Apr 3, 2021, 1:54 PM

#

Most of the ones that get contributions have the setup guide linked in the readme

short snow Apr 3, 2021, 1:54 PM

#

pulling of a zip, as a background task

#

i feel ks's idea is better, to fetch all ducky asset in that the quakstack folder on the branding as a background task

patent pivot Apr 3, 2021, 2:06 PM

#

short snow also update your branch name joe.

you can't rename a pull request branch

patent pivot Apr 3, 2021, 2:06 PM

#

short snow i feel ks's idea is better, to fetch all ducky asset in that the quakstack folde...

isn't that my idea?

short snow Apr 3, 2021, 2:06 PM

#

patent pivot you can't rename a pull request branch

oh ok

short snow Apr 3, 2021, 2:06 PM

#

patent pivot isn't that my idea?

very very similar.

patent pivot Apr 3, 2021, 2:07 PM

#

https://download-directory.github.io/

#

we can download just the quackstack folder

#

but I like the idea of a zip rather than individual assets

short snow Apr 3, 2021, 2:08 PM

#

yeah, just downloading the quakstack folder

#

https://github.com/python-discord/quackstack/

GitHub

python-discord/quackstack

An on-demand procedural ducky delivery service. An infinite stack of duckies! - python-discord/quackstack

fallen patrol Apr 3, 2021, 7:32 PM

#

patent pivot you can't rename a pull request branch

i learned this the hard way once.…

patent pivot Apr 3, 2021, 7:33 PM

#

lol

#

you can like

#

move branches

#

but github doesn't pick up on it yet

fallen patrol Apr 3, 2021, 8:21 PM

#

patent pivot but github doesn't pick up on it yet

yeah

#

i renamed the branch

#

and github was like: nah you deleted it and created an identical branch tyvm

patent pivot Apr 3, 2021, 8:30 PM

#

cc @fervent sage the quackstack docker image does not work

#

it doesn't fetch branding submodule

#

FileNotFoundError: [Errno 2] No such file or directory: 'branding/quackstack/silverduck_templates'

#

from prod

fervent sage Apr 3, 2021, 8:42 PM

#

hmm, i guess it depends on that already being there

#

sec

patent pivot Apr 3, 2021, 8:43 PM

#

git will need adding to the build image but otherwise should be good

#

am available to review a PR

#

git submodule update

#

maybe needs a git submodule init as well? I forget

fervent sage Apr 3, 2021, 8:44 PM

#

im too busy for implementing that rn, but someone will probably take on an issue since its pretty simple

#

git submodule update --init

patent pivot Apr 3, 2021, 8:44 PM

#

aha

#

I cannnnnnn

#

oh hm

#

hmmm

#

we need to do that after copying the code right

#

yeah

#

that sucks, build times are going to shoot up

#

should just be this right?

#

https://github.com/python-discord/quackstack/pull/19

GitHub

Update submodules in Dockerfile by jb3 · Pull Request #19 · python-...

This fetches the submodules in the Docker image build to have the branding repository ready by the time the app starts, preventing the error we experienced while trying to deploy:
FileNotFoundError...

#

cc <@&409416496733880320> for approval on that as well, it'll need a devops sign off

#

I can't test it locally because no docker so if someone wants to do that I'd appreciate it, but I think that should be correct

hardy gorge Apr 3, 2021, 8:52 PM

#

I'd recommend you to create an unprivileged user and run the actual app as that user, but we typically don't do that yet in all of our dockerfiles and it's out of scope for this PR

#

It looks fine, but I'll try to build it locally

patent pivot Apr 3, 2021, 8:54 PM

#

hardy gorge I'd recommend you to create an unprivileged user and run the actual app as that ...

Yeah, that is a good suggestion

hardy gorge Apr 3, 2021, 8:54 PM

#

Do I need to do anything special to reproduce this bug?

#

I'm really out of the loop on this project

patent pivot Apr 3, 2021, 8:55 PM

#

you need to ensure you don't have the branding submodule already cloned I think

#

I'm not too knowledgable either

hardy gorge Apr 3, 2021, 8:56 PM

#

just running the docker-compose should trigger the error in the old situation?

#

Or do I need to make a request?

#

Right

#

api_1  |     for name in self._accessor.listdir(self):
api_1  | FileNotFoundError: [Errno 2] No such file or directory: 'branding/quackstack/silverduck_templates'

#

alright

#

now try the fix

patent pivot Apr 3, 2021, 9:16 PM

#

looks good, project deployed

vale ibex Apr 3, 2021, 10:38 PM

#

That's the valid BSD value for a connection error 😄

#

Also, I'm not ignoring your first question, i just don't know the answer

sleek steppe Apr 3, 2021, 10:41 PM

#

!exit

stable mountainBOT Apr 3, 2021, 10:41 PM

#

Exiting Programmatically

If you want to exit your code programmatically, you might think to use the functions exit() or quit(), however this is bad practice. These functions are constants added by the site module as a convenient method for exiting the interactive interpreter shell, and should not be used in programs.

You should use either SystemExit or sys.exit() instead.
There's not much practical difference between these two other than having to import sys for the latter. Both take an optional argument to provide an exit status.

Official documentation with the warning not to use exit() or quit() in source code.

fallen patrol Apr 4, 2021, 1:12 AM

#

...why did it boot twice if it didn't deploy?

vocal prairie Apr 4, 2021, 1:12 AM

#

Maybe it was an internal thing?

fallen patrol Apr 4, 2021, 1:23 AM

#

!ping

stable mountainBOT Apr 4, 2021, 1:23 AM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

patent pivot Apr 4, 2021, 5:36 AM

#

fallen patrol ...why did it boot twice if it didn't deploy?

there are a lot of cases where the bot restarts

#

way more than just auto-deploy

fallen patrol Apr 4, 2021, 5:37 AM

#

~~smh bad practice~~

#

well, without any info it is

gritty wind Apr 4, 2021, 5:37 AM

#

Hm?

fallen patrol Apr 4, 2021, 5:37 AM

#

anyways im very busy, d.py 1.7 just released and its 2 am

patent pivot Apr 4, 2021, 5:37 AM

#

if we detect a node is performing suboptimally we transition the pod off it

fallen patrol Apr 4, 2021, 5:37 AM

#

im def not updating to 1.7 at 2am

patent pivot Apr 4, 2021, 5:38 AM

#

we also transition to better balance resource usage across the cluster

#

There isn't much to migrate to for d.py 1.7 so it shouldn't be too big of a job

gritty wind Apr 4, 2021, 5:41 AM

#

do they have wheels published

#

yeah

patent pivot Apr 4, 2021, 5:41 AM

#

yeah

short snow Apr 4, 2021, 5:42 AM

#

patent pivot There isn't much to migrate to for d.py 1.7 so it shouldn't be too big of a job

https://discordpy.readthedocs.io/en/latest/whats_new.html#v1-7-0]

fallen patrol Apr 4, 2021, 5:54 AM

#

patent pivot There isn't much to migrate to for d.py 1.7 so it shouldn't be too big of a job

its not so much that its the new features

#

and oh my

#

the new features

fallen patrol Apr 4, 2021, 5:54 AM

#

short snow https://discordpy.readthedocs.io/en/latest/whats_new.html#v1-7-0]

THESE ARE SO GREAT

fallen patrol Apr 4, 2021, 6:17 AM

#

Specifically

#

Replies have much better support

fallen patrol Apr 4, 2021, 7:10 AM

#

Ok

fallen patrol Apr 4, 2021, 7:12 AM

#

patent pivot There isn't much to migrate to for d.py 1.7 so it shouldn't be too big of a job

In the case of python bot and sir lancebot neither really use anything of the major changes with the bot, so I think for the most part it's gonna be an easy swap.

I just took two bots and bumped the requirements and they run fine.

green oriole Apr 4, 2021, 8:09 AM

#

Hey @short snow, I have some pretty big concerns about https://github.com/python-discord/sir-lancebot/issues/655

GitHub

Bonk! Bonk! · Issue #655 · python-discord/sir-lancebot

Description Add a .bonk <userid/username/mention> command, which when invoked would send gif of mentioned member being "bonked" by Master Yoda. Example: .bonk 386599...

#

It may work in a small server such as gurkult, but here it will probably just turn into a moderation mess

short snow Apr 4, 2021, 8:33 AM

#

green oriole It may work in a small server such as gurkult, but here it will probably just tu...

moderation mess like?

#

#dev-log message and what do you guys think of this, the solution part

green oriole Apr 4, 2021, 9:04 AM

#

short snow moderation mess like?

Well, I’m afraid bonk will be used in a bad way, to mock other users and it will turn into a heated discussion

short snow Apr 4, 2021, 9:25 AM

#

Hmm yeah

#

also https://github.com/python-discord/quackstack/issues/3#issuecomment-812958499 am I right here?

GitHub

API: Generate a random man-duck with an optional seed. · Issue #3 ·...

Once python-discord/aaaaAAAA#33 has been solved, the man-duck templates should be moved in here as well, and we should be able to generate a random man-duck the same way that we currently generate ...

thorny obsidian Apr 4, 2021, 11:59 AM

#

I'm of the opinion that lancebot should be a learning experience primarily. Essentially dropping in completed cogs or commands or features from other servers is not something I'm interested in seeing.

short snow Apr 4, 2021, 3:51 PM

#

thorny obsidian I'm of the opinion that lancebot should be a learning experience primarily. Esse...

i had asked the orginary owner to do it here too ( @hahastinkypoop#8591 ), they are quite active here also

placid ermine Apr 4, 2021, 3:57 PM

#

can confirm

vale ibex Apr 4, 2021, 7:31 PM

#

Anyone know if this pesky • can be easily removed? (In embed footers)

patent pivot Apr 4, 2021, 7:34 PM

#

no way sadly, implemented by Discord

vale ibex Apr 4, 2021, 7:44 PM

#

👍

sharp timber Apr 4, 2021, 10:59 PM

#

You can potentially finagle it by not setting a timestamp for the footer and instead formatting it yourself, but that loses the user-datetime-adaption discord does for you there

balmy sparrow Apr 5, 2021, 3:11 AM

#

https://github.com/python-discord/bot/blob/47d535c82af5463699b7d8e4533ba415fd4e964a/bot/converters.py#L492
is this converter necessary now, as the UserConverter already fetches from the API if the user wasn't found in cache (since 1.6)
https://discordpy.readthedocs.io/en/stable/ext/commands/api.html#discord.ext.commands.UserConverter

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

short snow Apr 5, 2021, 3:17 AM

#

Oh, didn't know about that, can the userconverter be used here https://github.com/python-discord/bot/blob/stream-and-revokestream-commands/bot/exts/moderation/stream.py#L46-#L50 ?

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

balmy sparrow Apr 5, 2021, 3:18 AM

#

if a User is all you need there, sure

#

that's fetching/getting a Member there though

sleek steppe Apr 5, 2021, 3:19 AM

#

Converters are for strings so I don't see how that would be better

balmy sparrow Apr 5, 2021, 3:19 AM

#

i guess the code there becomes 2 lines if you use a converter, not much of a point other than that

magic arch Apr 5, 2021, 3:20 AM

#

Heya folks! Totally random, but if anyone familiar with the mock roles used in the bot tests is free, would you mind taking a peek at https://github.com/python-discord/bot/pull/1499#issuecomment-813159304? Thanks!

short snow Apr 5, 2021, 3:20 AM

#

yeah, you would need to edit the unittests a bit, i will look into it, and comment on the changes required

magic arch Apr 5, 2021, 3:21 AM

#

Ah thanks a bunch - take your time!

balmy sparrow Apr 5, 2021, 3:22 AM

#

balmy sparrow that's fetching/getting a Member there though

turns out the MemberConverter also lazily fetches from the API (since 1.5.1)

sleek steppe Apr 5, 2021, 3:26 AM

#

-        embed.colour = user.colour if user.colour != Colour.default() else Colour.blurple()
+        embed.colour = user.colour if user.colour.value else Colour.blurple()

Maybe?

short snow Apr 5, 2021, 3:26 AM

#

magic arch Ah thanks a bunch - take your time!

In the test_information file, i.e. https://github.com/python-discord/bot/blob/main/tests/bot/exts/info/test_information.py, you need to introduce a new parameter named colour, currently it mocks a Role and then adds a .colour attribute to it, like shown here: https://github.com/python-discord/bot/blob/main/tests/bot/exts/info/test_information.py#L314.

You can make few constants in the file with the colour codes, and then use it where ever there is a MockMember instance. Well this is the first step, now another thing is required, since it was using top_role.colour earlier, you can remove all of that code, since it is not being right now.

Hopefully this should work, 🤞

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

short snow Apr 5, 2021, 3:27 AM

#

sleek steppe ```diff - embed.colour = user.colour if user.colour != Colour.default() e...

imo, user.colour != Colour.default() seems more understandable

balmy sparrow Apr 5, 2021, 3:28 AM

#

sleek steppe ```diff - embed.colour = user.colour if user.colour != Colour.default() e...

that would depend on user.colour becoming None right? but it won't, it'll just give default color if there was no colour

#

or does the value of default color give None?

magic arch Apr 5, 2021, 3:28 AM

#

Default color is technically 0 I believe, but I felt Colour.default() was more understandable

magic arch Apr 5, 2021, 3:29 AM

#

short snow In the `test_information` file, i.e. https://github.com/python-discord/bot/blob/...

Thanks so much, I’ll work on this and let you know how it goes!

sleek steppe Apr 5, 2021, 3:29 AM

#

balmy sparrow that would depend on user.colour becoming None right? but it won't, it'll just g...

user.colour always returns something iirc?

balmy sparrow Apr 5, 2021, 3:30 AM

#

yeah my bad

#

so default color's value will be None?

sleek steppe Apr 5, 2021, 3:30 AM

#

and default colour has a value of zero

balmy sparrow Apr 5, 2021, 3:30 AM

#

right makes sense

magic arch Apr 5, 2021, 4:39 AM

#

@short snow Thanks so much again for your help, I was able to get the tests passing! 🥳

short snow Apr 5, 2021, 4:43 AM

#

magic arch <@!736234578745884682> Thanks so much again for your help, I was able to get the...

perfect, i will give it a review soon!

magic arch Apr 5, 2021, 4:44 AM

#

Sounds good, couldn't have fixed this without you!

short snow Apr 5, 2021, 8:57 AM

#

#sir-lancebot-playground message these are flooded in the bot history, am not sure if anyone even notices them

fallen patrol Apr 5, 2021, 12:31 PM

#

short snow https://discord.com/channels/267624335836053506/607247579608121354/8285538374421...

~~sus~~

gritty wind Apr 5, 2021, 12:31 PM

#

it's not the result of the command 👀

#

The avatar commands do sometimes error out though

#

~~Espcially if you just updated your PFP~~

fallen patrol Apr 5, 2021, 12:32 PM

#

gritty wind ~~Espcially if you just updated your PFP~~

~~then make a helper function to get the pfp and it fetches the new one if the cache file errors~~

gritty wind Apr 5, 2021, 12:33 PM

#

Sounds reasonable, can you open an issue?

fallen patrol Apr 5, 2021, 12:33 PM

#

*opens issue*

gritty wind Apr 5, 2021, 12:33 PM

#

lol

fallen patrol Apr 5, 2021, 12:33 PM

#

~~bruh~~

#

minor QoL improvement

#

pls add github links to #dev-log channel topic

gritty wind Apr 5, 2021, 12:33 PM

#

Wdym?

#

Ah

fallen patrol Apr 5, 2021, 12:34 PM

#

zoomEyes

gritty wind Apr 5, 2021, 12:34 PM

#

but to what repo

fallen patrol Apr 5, 2021, 12:34 PM

#

github.com/pydis

gritty wind Apr 5, 2021, 12:34 PM

#

gotcha

#

I can do that now lol

patent pivot Apr 5, 2021, 12:34 PM

#

done

gritty wind Apr 5, 2021, 12:34 PM

#

Too quick

patent pivot Apr 5, 2021, 12:34 PM

#

flexing my short URLs

vocal prairie Apr 5, 2021, 12:36 PM

#

@fallen patrol Just wanted to let you know, there are PRs open to the API docs to document stage channels.

fallen patrol Apr 5, 2021, 12:36 PM

#

yeah

#

that and

#

#

they're type 13 iirc

#

sir-lancebot#653 ~~what is black knight?~~

dusky shoreBOT Apr 5, 2021, 12:38 PM

#

GitHub

IssueOpen [sir-lancebot] #653 Add internal evaluation to sir-lancebot

patent pivot Apr 5, 2021, 12:38 PM

#

discontinued project

fallen patrol Apr 5, 2021, 12:38 PM

#

gritty wind Sounds reasonable, can you open an issue?

bug report or feature...

gritty wind Apr 5, 2021, 12:38 PM

#

Bug report I think

fallen patrol Apr 5, 2021, 12:38 PM

#

patent pivot discontinued project

is it public?

patent pivot Apr 5, 2021, 12:38 PM

#

no, it was a closed source security bot

fallen patrol Apr 5, 2021, 12:38 PM

#

ah

#

does the eval command use textwrap at all?

patent pivot Apr 5, 2021, 12:39 PM

#

The Black Knight provides a number of security features to our admins. This bot is not open-source, for security reasons.
from #welcome at the time

fallen patrol Apr 5, 2021, 12:40 PM

#

This bot is not open-source, for security reasons.
ahhh, security by obscurity.

patent pivot Apr 5, 2021, 12:40 PM

#

the implementation used textwrap

#

lol, that's not security through obscurity

fallen patrol Apr 5, 2021, 12:40 PM

#

patent pivot the implementation used textwrap

ew~~

patent pivot Apr 5, 2021, 12:41 PM

#

seems it was used in one place

vocal prairie Apr 5, 2021, 12:41 PM

#

Why was the !f command removed?

patent pivot Apr 5, 2021, 12:41 PM

#

what was !f again?

vocal prairie Apr 5, 2021, 12:41 PM

#

The command for free help channels?

gritty wind Apr 5, 2021, 12:41 PM

#

Isn't that free?

patent pivot Apr 5, 2021, 12:41 PM

#

!f

gritty wind Apr 5, 2021, 12:41 PM

#

We don't have free help channels anymore?

fallen patrol Apr 5, 2021, 12:41 PM

#

patent pivot

ohhh

#

okay whew

#

its not like the bot that uses textwrap.indent

gritty wind Apr 5, 2021, 12:41 PM

#

It was kept for a while during the transition afaik

patent pivot Apr 5, 2021, 12:42 PM

#

that rings a bell

gritty wind Apr 5, 2021, 12:42 PM

#

But now we just have #❓｜how-to-get-help

gritty wind Apr 5, 2021, 12:42 PM

#

patent pivot that rings a bell

It used to link to a static help channel that didn't have activity for a while

patent pivot Apr 5, 2021, 12:42 PM

#

yeah

gritty wind Apr 5, 2021, 12:42 PM

#

But it's usage went down quite a lot with the new system

vocal prairie Apr 5, 2021, 12:43 PM

#

Makes sense.

short snow Apr 5, 2021, 12:43 PM

#

patent pivot discontinued project

discontinued why?

gritty wind Apr 5, 2021, 12:43 PM

#

Discord got better at handling things

#

is part of it

patent pivot Apr 5, 2021, 12:43 PM

#

Yeah, pretty much that.

vocal prairie Apr 5, 2021, 12:43 PM

#

Does defcon also do it?

patent pivot Apr 5, 2021, 12:43 PM

#

There were a few reasons, but we didn't need the project in the end.

vocal prairie Apr 5, 2021, 12:44 PM

#

Or is that different?

gritty wind Apr 5, 2021, 12:44 PM

#

Defcon limits who can join the server

short snow Apr 5, 2021, 12:44 PM

#

defcon is pretty useful in cases of raids

gritty wind Apr 5, 2021, 12:44 PM

#

It's part of it, but not everything that was planned for that project

#

it's only one protection

fallen patrol Apr 5, 2021, 12:46 PM

#

gritty wind ~~Espcially if you just updated your PFP~~

fwiw i've never seen it error so uh, do you have a place where its errored handy?

gritty wind Apr 5, 2021, 12:47 PM

#

I can pull one from the logs

#

one sec

fallen patrol Apr 5, 2021, 12:47 PM

#

ah

#

seems it has a silent response

gritty wind Apr 5, 2021, 12:48 PM

#

Yup that's the one I pulled haha

fallen patrol Apr 5, 2021, 12:48 PM

#

short snow Apr 5, 2021, 12:48 PM

#

chris's pr should fix this

gritty wind Apr 5, 2021, 12:48 PM

#

It isn't silent on our end 😓

fallen patrol Apr 5, 2021, 12:48 PM

#

guess that's a second bug.…..

gritty wind Apr 5, 2021, 12:48 PM

#

Does it? Isn't chris' PR about rates

fallen patrol Apr 5, 2021, 12:48 PM

#

an error handler not outputting anything

short snow Apr 5, 2021, 12:48 PM

#

it is mostly because of too much resource burning

gritty wind Apr 5, 2021, 12:48 PM

#

That's unrelated to this bug

short snow Apr 5, 2021, 12:48 PM

#

or it is because of pfp not found?

gritty wind Apr 5, 2021, 12:48 PM

#

Yeah cache things

fallen patrol Apr 5, 2021, 12:49 PM

#

sir-lancebot#649

dusky shoreBOT Apr 5, 2021, 12:49 PM

#

GitHub

PROpen [sir-lancebot] #649 Porting Command Suggestions from python-discord/bot

patent pivot Apr 5, 2021, 12:49 PM

#

we did have a spike in cpu throttling the other day didn't we

fallen patrol Apr 5, 2021, 12:49 PM

#

that one?

gritty wind Apr 5, 2021, 12:49 PM

#

This would be unrelated, but yeah (on the throttling comment)

short snow Apr 5, 2021, 12:49 PM

#

try running .8bitify a lot of times

fallen patrol Apr 5, 2021, 12:49 PM

#

sir-lancebot#597

dusky shoreBOT Apr 5, 2021, 12:49 PM

#

GitHub

PROpen [sir-lancebot] #597 Move pfp commands into executors

short snow Apr 5, 2021, 12:49 PM

#

after some point, it won't reply

#

yes that one

gritty wind Apr 5, 2021, 12:49 PM

#

Again, not the same error

#

The logs show a 404

short snow Apr 5, 2021, 12:50 PM

#

yeah ik, i was just telling

fallen patrol Apr 5, 2021, 12:50 PM

#

ffs i need to change my pfp anyways

gritty wind Apr 5, 2021, 12:50 PM

#

Ah, okay

fallen patrol Apr 5, 2021, 1:03 PM

#

@patent pivot are you able to share the eval command for black night?

#

as akarys commented on that pr

#

sir-lancebot#653

dusky shoreBOT Apr 5, 2021, 1:04 PM

#

GitHub

IssueOpen [sir-lancebot] #653 Add internal evaluation to sir-lancebot

gritty wind Apr 5, 2021, 1:05 PM

#

I don’t know if that was ever written 👀

short snow Apr 5, 2021, 1:05 PM

#

ves wrote it

gritty wind Apr 5, 2021, 1:05 PM

#

Anyways, last time this was discussed, someone said Sebaatian will be handling it

fallen patrol Apr 5, 2021, 1:06 PM

#

patent pivot Apr 5, 2021, 1:06 PM

#

gritty wind I don’t know if that was ever written 👀

https://github.com/python-discord/rattlesnake/tree/master/rattlesnake/exts/admin_tools/internal_eval

fallen patrol Apr 5, 2021, 1:06 PM

#

gritty wind Anyways, last time this was discussed, someone said Sebaatian will be handling i...

my actual interest is in the implementation zoomEyes

gritty wind Apr 5, 2021, 1:06 PM

#

Can’t open it, in mobile lol

patent pivot Apr 5, 2021, 1:06 PM

#

fallen patrol <@!165023948638126080> are you able to share the eval command for black night?

Someone will PR it shortly so it'll be public then

fallen patrol Apr 5, 2021, 1:06 PM

#

patent pivot https://github.com/python-discord/rattlesnake/tree/master/rattlesnake/exts/admin...

can you paste that in a gist? pleadingpoint

patent pivot Apr 5, 2021, 1:07 PM

#

just wait for it to be PR'd, I'm sure someone will take it fairly soon

fallen patrol Apr 5, 2021, 1:08 PM

#

its really interesting how its always 404s and not 403s

#

sir-lancebot#656

dusky shoreBOT Apr 5, 2021, 1:08 PM

#

GitHub

IssueOpen [sir-lancebot] #656 Pfp commands sometimes error on pfp change

fallen patrol Apr 5, 2021, 1:08 PM

#

how taxxing would it be to just fetch the new link every time

patent pivot Apr 5, 2021, 1:08 PM

#

404s is good design

#

prevents accidental information exposure

patent pivot Apr 5, 2021, 1:09 PM

#

fallen patrol how taxxing would it be to just fetch the new link every time

probably fine

fallen patrol Apr 5, 2021, 1:09 PM

#

patent pivot Apr 5, 2021, 1:10 PM

#

lol

gritty wind Apr 5, 2021, 1:10 PM

#

On its own it’s fine

#

Putting it in a command tho

patent pivot Apr 5, 2021, 1:10 PM

#

hmmmm

#

what's the endpoint

#

get user info?

#

why is the cache not updating

gritty wind Apr 5, 2021, 1:11 PM

#

Members intent

patent pivot Apr 5, 2021, 1:11 PM

#

ah

fallen patrol Apr 5, 2021, 1:11 PM

#

gritty wind Members intent

does the bot not ask for it?

gritty wind Apr 5, 2021, 1:12 PM

#

Not sir-lance, no

#

The only intent we get is members on python, everything else is off

patent pivot Apr 5, 2021, 1:12 PM

#

so

fallen patrol Apr 5, 2021, 1:12 PM

#

are you sure of that scaleios

#

!src

stable mountainBOT Apr 5, 2021, 1:12 PM

#

Bot's GitHub Repository

Repository

Go to GitHub

patent pivot Apr 5, 2021, 1:12 PM

#

why is this erroring

gritty wind Apr 5, 2021, 1:12 PM

#

Wdym?

patent pivot Apr 5, 2021, 1:13 PM

#

we should get the profile information from the message event

#

which includes a user

gritty wind Apr 5, 2021, 1:13 PM

#

patent pivot Apr 5, 2021, 1:13 PM

#

https://canary.discord.com/developers/docs/resources/channel#message-object author here should be a user

Discord Developer Portal

Discord Developer Portal — API Docs for Bots and Developers

Integrate your service with Discord — whether it's a bot or a game or whatever your wildest imagination can come up with.

gritty wind Apr 5, 2021, 1:13 PM

#

But that’s just a cache object, no?

patent pivot Apr 5, 2021, 1:13 PM

#

and surely ctx.message.author pulls from that?

fallen patrol Apr 5, 2021, 1:13 PM

#

seems it gets a lot of users

gritty wind Apr 5, 2021, 1:13 PM

#

Or is it hmm

gritty wind Apr 5, 2021, 1:14 PM

#

fallen patrol seems it gets a lot of users

Yeah members is on?

#

It’s off for sir-lance

patent pivot Apr 5, 2021, 1:14 PM

#

members is on for bot, off for lance, yeah

gritty wind Apr 5, 2021, 1:14 PM

#

Where the image processing is

patent pivot Apr 5, 2021, 1:14 PM

#

on for metricity

#

on for modmail

fallen patrol Apr 5, 2021, 1:14 PM

#

#

https://cdn.discordapp.com/avatars/717983911824588862/b18efaa4ee8e8b32b434709320332b41.png

#

very odd

gritty wind Apr 5, 2021, 1:15 PM

#

That’s empty on mobile

#

Ah now it loaded

patent pivot Apr 5, 2021, 1:15 PM

#

yeah I don't think this is a cache thing

fallen patrol Apr 5, 2021, 1:15 PM

#

*closes issue*

patent pivot Apr 5, 2021, 1:15 PM

#

do we have a sentry error for this

fallen patrol Apr 5, 2021, 1:15 PM

#

~~its still a bug but something else~~

gritty wind Apr 5, 2021, 1:15 PM

#

Why would it be getting the old UrL?

#

Yeah tons

patent pivot Apr 5, 2021, 1:15 PM

#

lol

gritty wind Apr 5, 2021, 1:15 PM

#

Look for 404s basically

patent pivot Apr 5, 2021, 1:16 PM

#

what cache mode does d.py default to

fervent sage Apr 5, 2021, 1:16 PM

#

gritty wind

is there a specific reason this creates an instance of Intents() before calling all()?

gritty wind Apr 5, 2021, 1:16 PM

#

Idk lol

fervent sage Apr 5, 2021, 1:16 PM

#

fair enough kek

fallen patrol Apr 5, 2021, 1:17 PM

#

fervent sage is there a specific reason this creates an instance of Intents() before calling ...

good question

patent pivot Apr 5, 2021, 1:17 PM

#

what would happen if we disabled all caching

#

through this https://discordpy.readthedocs.io/en/stable/api.html#discord.MemberCacheFlags.none

fallen patrol Apr 5, 2021, 1:17 PM

#

💥

patent pivot Apr 5, 2021, 1:17 PM

#

would it?

gritty wind Apr 5, 2021, 1:18 PM

#

So it rerequests on every usage of member?

#

Do you know the rates

patent pivot Apr 5, 2021, 1:18 PM

#

50/s for general routes iirc

fallen patrol Apr 5, 2021, 1:18 PM

#

gritty wind Apr 5, 2021, 1:19 PM

#

Is that lance?

fallen patrol Apr 5, 2021, 1:19 PM

#

yeah

#

~~no its a totally random bot~~

gritty wind Apr 5, 2021, 1:19 PM

#

I’m p sure default doesn’t include it

#

Lol

fallen patrol Apr 5, 2021, 1:19 PM

#

https://github.com/python-discord/sir-lancebot/blob/6ce46b60c81450dca50cc4a9a500608342b50b59/bot/bot.py#L145-L150

patent pivot Apr 5, 2021, 1:20 PM

#

is it this error?

fallen patrol Apr 5, 2021, 1:20 PM

#

gritty wind Apr 5, 2021, 1:21 PM

#

Yeah

fallen patrol Apr 5, 2021, 1:21 PM

#

patent pivot is it this error?

fwiw even if this isn't an error, that error handler doesn't return any response if something did go wrong

patent pivot Apr 5, 2021, 1:21 PM

#

26 occurrences

fervent sage Apr 5, 2021, 1:21 PM

#

btw is there a problem if i create branches on the main repo?

gritty wind Apr 5, 2021, 1:21 PM

#

If you have a dummy account, switching pfp should reproduce

patent pivot Apr 5, 2021, 1:22 PM

#

fervent sage btw is there a problem if i create branches on the main repo?

nah, staff can go for it

gritty wind Apr 5, 2021, 1:22 PM

#

fervent sage btw is there a problem if i create branches on the main repo?

That preferred for staff

fallen patrol Apr 5, 2021, 1:23 PM

#

gritty wind If you have a dummy account, switching pfp should reproduce

should, we say

#

at minimum

#

.8bitify

#

~~well at minimum~~

#

its still my old pfp

patent pivot Apr 5, 2021, 1:23 PM

#

right

#

because it's cached

#

hold on one second

fallen patrol Apr 5, 2021, 1:23 PM

#

you're just gonna turn off the cache on the current bot

#

lol

patent pivot Apr 5, 2021, 1:24 PM

#

no I'm going to restart it

fallen patrol Apr 5, 2021, 1:24 PM

#

ah

#

then we know its a cache issue

patent pivot Apr 5, 2021, 1:25 PM

#

alright it's starting up

#

try now