#dev-contrib | Python | Page 90

left flume Mar 8, 2021, 3:18 PM

#

oh

#

I see

subtle kraken Mar 8, 2021, 3:21 PM

#

don't all embeds have colors?

#

well tags don't

vocal prairie Mar 8, 2021, 3:22 PM

#

Some of them are set to a black-ish color.

gritty wind Mar 8, 2021, 3:22 PM

#

hmm why did that embed send twice

#

anyways yeah, some just use the default color

vocal prairie Mar 8, 2021, 3:22 PM

#

Somebody manually sent it.

subtle kraken Mar 8, 2021, 3:22 PM

#

vocal prairie Some of them are set to a black-ish color.

its default (discord) then

#

I can only recall tags having it to be fair

#

I think all commands respond with color embeds though

left flume Mar 8, 2021, 3:45 PM

#

Yeah those embeds have a transparent colour

#

For example, !help doesn't have a colour, but !rules does

short snow Mar 8, 2021, 3:46 PM

#

Hmm we could add blurple color to help command

obsidian patio Mar 8, 2021, 3:49 PM

#

I think the best way would be to have a helper for it, so it’s all easy to change depending on the occasion. If we want to change the error color, for example, we just do it in the config for the helper. At the same time, we can have auto-set titles, like for errors with error titles

vale ibex Mar 8, 2021, 3:50 PM

#

Yea, I think we should make constants.Colours describe actions/states rather than colours

#

eg constants.Colours.error is red

obsidian patio Mar 8, 2021, 3:56 PM

#

We could have both

short snow Mar 8, 2021, 3:57 PM

#

obsidian patio I think the best way would be to have a helper for it, so it’s all easy to chang...

Yeah i meant until we have the embed helper

vale ibex Mar 8, 2021, 3:57 PM

#

obsidian patio We could have both

For sure

short snow Mar 8, 2021, 4:00 PM

#

Anything on this?

vale ibex Mar 8, 2021, 4:01 PM

#

I'm @ work atm, so can't look into it too much

#

!remind 2h #dev-contrib message

stable mountainBOT Mar 8, 2021, 4:01 PM

#

Of course!

Your reminder will arrive in 2 hours!

short snow Mar 8, 2021, 4:15 PM

#

Sure

vale ibex Mar 8, 2021, 4:16 PM

#

So if no one has helped by then I'll give it a look

green oriole Mar 8, 2021, 4:21 PM

#

what is the context ?

short snow Mar 8, 2021, 4:22 PM

#

Wikiguess game

green oriole Mar 8, 2021, 4:30 PM

#

Not sure

#

Maybe you can redact the answer

short snow Mar 8, 2021, 4:31 PM

#

Redact like?

green oriole Mar 8, 2021, 4:35 PM

#

If you find part of the answer in the description you can replace it by [redacted]

short snow Mar 8, 2021, 4:37 PM

#

Oh

#

will do

short snow Mar 8, 2021, 5:01 PM

#

@green oriole what do u think of using add fields instead of separate embed for each snowflake?

green oriole Mar 8, 2021, 5:03 PM

#

We want to use a separate embed like we do for !role

short snow Mar 8, 2021, 5:03 PM

#

It could be spamming tho

#

well it is restricted to staff that’s why

#

ig

tropic bobcat Mar 8, 2021, 5:19 PM

#

Idea here, !whois bot. Let me explain in the virtual cycling world we use discord and have accounts/teams on zwiftpower. com We often what to find the Discord user on zwiftpower.com. I have built a whois bot. we do !zw whois set 123 and this links the user Discord to the zwiftpower profile.
Now the proposal for Python Discord.

Add a whois bot that allows a user to link them to a whitelisted set of urls, github, twitter, gitlab, ... some place they might have a profile.
Its optional and the user can update or clear this at any time.
If a user does a WHOIS the URL is sent as a DM to them, do we want a notice sent to both users?
rate limit?

vale ibex Mar 8, 2021, 5:21 PM

#

How would this be different to the discord provided social links?

#

IE. if you look at my discord profile you can see my battlenet tag and my steam

tropic bobcat Mar 8, 2021, 5:22 PM

#

let me look

vale ibex Mar 8, 2021, 5:22 PM

#

you can add many different type of links there

#

spotify, github etc.

tropic bobcat Mar 8, 2021, 5:22 PM

#

but I think the short answer is yes, because it would be specific to this guild.

patent pivot Mar 8, 2021, 5:22 PM

#

I think that the Discord provided feature for this is fine, a good portion of our user base already use their profile to display these socials

tropic bobcat Mar 8, 2021, 5:23 PM

#

Screen_Shot_2021-03-08_at_10.22.59_AM.png

#

I don't see social links

patent pivot Mar 8, 2021, 5:23 PM

#

they are there

#

tropic bobcat Mar 8, 2021, 5:23 PM

#

oh

patent pivot Mar 8, 2021, 5:23 PM

#

on mine i have github and twitter and stufff

tropic bobcat Mar 8, 2021, 5:24 PM

#

didn't recognize what those where

#

So then those are public in every guild?

vale ibex Mar 8, 2021, 5:24 PM

#

yup

#

If you open Joe's you can see he has a lot more

short snow Mar 8, 2021, 5:24 PM

#

Lol

patent pivot Mar 8, 2021, 5:25 PM

#

lol

tropic bobcat Mar 8, 2021, 5:25 PM

#

Back to my zwiftpower thing then applications.

#

is there a way to get or set this without viewing the user profile?

#

I guess that just needs to be a bot.

patent pivot Mar 8, 2021, 5:27 PM

#

Bots cannot read or set user connections, no.

#

(without the user approving that access)

tropic bobcat Mar 8, 2021, 5:27 PM

#

right

#

one of the things we need in the cycling teams is a way for the admins to get and set this.

patent pivot Mar 8, 2021, 5:29 PM

#

Yeah, we don't really have the same need here, we leave that up to the users.

tropic bobcat Mar 8, 2021, 5:29 PM

#

Thanks, it would be nice for all problems to be this easy.

patent pivot Mar 8, 2021, 5:29 PM

#

The benefit of letting Discord handle it is that to connect a profile to Discord you must have it verified by Discord

#

so you can't just claim you are torvalds on GitHub and have that work

tropic bobcat Mar 8, 2021, 5:29 PM

#

right

stable mountainBOT Mar 8, 2021, 6:01 PM

#

@vale ibex

It has arrived!

Here's your reminder: [#dev-contrib message](/guild/267624335836053506/channel/635950537262759947/).
[Jump back to when you created the reminder](#dev-contrib message)

vale ibex Mar 8, 2021, 6:02 PM

#

@short snow You still need help with that?

vocal wolf Mar 8, 2021, 6:11 PM

#

Thank.

balmy sparrow Mar 8, 2021, 6:14 PM

#

is this heading meant to be like this?

hardy gorge Mar 8, 2021, 6:15 PM

#

@cold moon You're an absolute superhero when it comes to implementing important features. Thanks!

subtle kraken Mar 8, 2021, 6:16 PM

#

balmy sparrow is this heading meant to be like this?

pretty sure yes, those 3 roles are all same just different colour

balmy sparrow Mar 8, 2021, 6:16 PM

#

oh huh. why are there three different patrons roles?

subtle kraken Mar 8, 2021, 6:16 PM

#

3 different tiers

thorny obsidian Mar 8, 2021, 6:16 PM

#

balmy sparrow is this heading meant to be like this?

Yup, those are the 3 different colors available to Patrons depending on which tier they select.

balmy sparrow Mar 8, 2021, 6:17 PM

#

right 👍

vocal prairie Mar 8, 2021, 6:23 PM

#

I mentioned an issue about Seasonal Bot being mentioned on the website in #community-meta, is there something I should do about that?

vale ibex Mar 8, 2021, 6:27 PM

#

vocal prairie I mentioned an issue about Seasonal Bot being mentioned on the website in <#4294...

I've updated the specific page you mentioned

vocal prairie Mar 8, 2021, 6:27 PM

#

Thank you!

vale ibex Mar 8, 2021, 6:27 PM

#

Thanks for pointing it out 😄

clever wraith Mar 8, 2021, 9:00 PM

#

Hey @gritty wind , anything on verification yet?

patent pivot Mar 8, 2021, 9:16 PM

#

for unsplash?

#

nothing yet

short snow Mar 8, 2021, 11:10 PM

#

vale ibex <@!736234578745884682> You still need help with that?

Hmm, not like help but ways to make the question

#

am currently just using ak’s redact idea

cosmic moat Mar 9, 2021, 12:49 AM

#

@vocal wolf fedex assures me my parts will be here tomorrow

vocal wolf Mar 9, 2021, 12:49 AM

#

noice

short snow Mar 9, 2021, 12:50 AM

#

What had happened?

cosmic moat Mar 9, 2021, 12:59 AM

#

short snow What had happened?

gpu had continually shut down, with no way of recovery, this lead to a lot of lost work, to the point where i actually wasn't able to dev anymore

short snow Mar 9, 2021, 1:00 AM

#

lemon_grimace lemon_pensive

clever wraith Mar 9, 2021, 3:36 AM

#

patent pivot for unsplash?

let me know if i messed something up!

short snow Mar 9, 2021, 6:34 AM

#

this is my current logic for wiki guess game

short snow Mar 9, 2021, 7:35 AM

#

well this is the only think i can possibly think of as of now

#

and fixes every bug i could possibly find

--

#

splitting on , ->
for Junction to match Junction, West Virginia

#

removing () and [] ->
for Call Me Lightning to match Call Me Lightning (song)

tawdry vapor Mar 9, 2021, 7:57 AM

#

If it's still an issue, you could try to write a heuristic for detecting overly-complex titles.

#

If the random title is too complicated, then you can discard it and get a different random one.

short snow Mar 9, 2021, 8:10 AM

#

like if it contains -+-*/[]{}()!@#$%^& then run again?

#

Also i have re-structured the trivia cog since it was huge and if i added wiki questions to it, it would be even huger

#

i will remove the pycache, was getting the __all__ through dir() hence it came there

#

trivia_quiz would now change to _cog

#

and the cog would be loaded in __init__

short snow Mar 9, 2021, 8:51 AM

#

would love to get reviews on bot#1446

dusky shoreBOT Mar 9, 2021, 8:51 AM

#

GitHub

PROpen [bot] #1446 Enhancing information within the incidents channel.

tough imp Mar 9, 2021, 8:58 AM

#

I'll take a look

short snow Mar 9, 2021, 9:08 AM

#

tough imp I'll take a look

Cool! thanks

tough imp Mar 9, 2021, 9:46 AM

#

So how do staff feel about this feature? The issue was put back into planning

#

It seems useful, but I wonder if it's necessary to support 10+ embeds, is it ever the case that someone sends more than 10 message links with their report?

short snow Mar 9, 2021, 9:53 AM

#

tough imp So how do staff feel about this feature? The issue was put back into planning

senjan was ok with it, as far i know, and they suggested to post multiple webhooks in case of more than 10+ embeds

#

i don't think this can ever be a case tho

tough imp Mar 9, 2021, 9:56 AM

#

In terms of functionality and presentation this probably ought to be reviewed by people who use the channel

#

I can do a code review later

short snow Mar 9, 2021, 9:58 AM

#

alright!

short snow Mar 9, 2021, 3:36 PM

#

@vale ibex did u find any other method? For getting the question wiki guess? (I have opened a pr with my current method)

#

@clever wraith my pr still has few stuff to do

#

the wikiguess game

#

especially how it gets the wiki questioms

clever wraith Mar 9, 2021, 3:51 PM

#

Alright! Just think it looks good so far

clever wraith Mar 9, 2021, 3:52 PM

#

short snow especially how it gets the wiki questioms

How are you getting them?

short snow Mar 9, 2021, 3:53 PM

#

Check out the code, i think u must have seen it when u reviewed

green oriole Mar 9, 2021, 3:54 PM

#

What do you mean by “Idk man, you didn't lint” @clever wraith ?

short snow Mar 9, 2021, 3:54 PM

#

You awesome descipriotn

#

description*

green oriole Mar 9, 2021, 3:54 PM

#

Oh, I see

#

I was a joke, my code is linted 😄

clever wraith Mar 9, 2021, 3:55 PM

#

short snow Mar 9, 2021, 3:55 PM

#

Lmao

clever wraith Mar 9, 2021, 3:55 PM

#

green oriole I was a joke, my code is linted 😄

I know lmao I was playing into it

short snow Mar 9, 2021, 3:55 PM

#

Code looks good lemme test it once

clever wraith Mar 9, 2021, 3:56 PM

#

I just have to read I'm not at my computer 😢

short snow Mar 9, 2021, 3:57 PM

#

I don’t think you should approve a PR without testing

short snow Mar 9, 2021, 4:32 PM

#

https://github.com/atbaker/wikipedia-question-generator How about using something like for generating questions?

GitHub

atbaker/wikipedia-question-generator

Uses NLP and wikipedia to try to generate trivia questions - atbaker/wikipedia-question-generator

hybrid oriole Mar 9, 2021, 4:46 PM

#

Hello there! Where should I ask for candidate to maintain a project? My two co-worker disappeared, and doing things alone is not the best choice out there. I also don't want to leave the community.. Any suggestion?

green oriole Mar 9, 2021, 4:54 PM

#

short snow https://github.com/atbaker/wikipedia-question-generator How about using somethin...

I like the idea, but it is no longer maintained

#

Hello @hybrid oriole, you should ask in off-topic, this channel is for Python Discord open source projects :)

hybrid oriole Mar 9, 2021, 4:57 PM

#

My bad sorry

short snow Mar 9, 2021, 4:57 PM

#

green oriole I like the idea, but it is no longer maintained

I could implement it on my own

#

rarely did machine learning so could be something new for me

green oriole Mar 9, 2021, 4:58 PM

#

hybrid oriole My bad sorry

No problem

green oriole Mar 9, 2021, 4:58 PM

#

short snow I could implement it on my own

That's an interesting proposal, but I'm not 100% sure if we want to have ML in our projects, I'll ask others

short snow Mar 9, 2021, 4:59 PM

#

Yeah. Had the same question hence asked here

cold island Mar 9, 2021, 5:06 PM

#

Hmm how should I typehint this variable?
https://github.com/python-discord/bot/blob/5a8cbaac5a91bfa83a4971961b87cf676b555f50/bot/exts/moderation/watchchannels/_watchchannel.py#L63

green oriole Mar 9, 2021, 5:07 PM

#

defaultdict[dict[..., ...]]

cold island Mar 9, 2021, 5:07 PM

#

in 3.8 it's still Dict right?

green oriole Mar 9, 2021, 5:07 PM

#

Ah yeah

#

I'm not 100% sure if there is a typing equivalent for defaultdict

cold island Mar 9, 2021, 5:08 PM

#

hmmm

#

maybe just Dict? lol

green oriole Mar 9, 2021, 5:08 PM

#

But that's basically a MutableMapping

cold island Mar 9, 2021, 5:08 PM

#

I guess I can alias it

green oriole Mar 9, 2021, 5:08 PM

#

Or Dict, yeah

#

typing.DefaultDict is a thing

#

So there you go

cold island Mar 9, 2021, 5:09 PM

#

o

#

tnx

patent pivot Mar 9, 2021, 5:11 PM

#

@short snow what type of setup are we talking in terms of ML

short snow Mar 9, 2021, 5:23 PM

#

patent pivot <@!736234578745884682> what type of setup are we talking in terms of ML

https://github.com/atbaker/wikipedia-question-generator something related to this

GitHub

atbaker/wikipedia-question-generator

Uses NLP and wikipedia to try to generate trivia questions - atbaker/wikipedia-question-generator

#

Haven't done anything yet just was found this and thought of asking if it is ok to use

patent pivot Mar 9, 2021, 5:24 PM

#

hmmm

#

I don't think bringing ML into a project such as lancebot is a great idea

short snow Mar 9, 2021, 5:25 PM

#

So should I just keep what it is like now

patent pivot Mar 9, 2021, 5:25 PM

#

while it's a cool idea it's significantly above the current entry bar + lancebot is aimed to run on minimal resources

#

yeah

short snow Mar 9, 2021, 5:25 PM

#

[python-discord/sir-lancebot] Pull request opened: #618 Wikiguess Game

#

Uhh

#

Will mention the to do and tada

dusky shoreBOT Mar 9, 2021, 5:26 PM

#

GitHub

PROpen [sir-lancebot] #616 Aoc fixes

tough imp Mar 9, 2021, 6:55 PM

#

Is there any chance that the bot's http_session may get get closed and re-assigned? Basically I'm wondering whether it's guaranteed that the bot's login method will only run once, so that I can store a reference to the http session somewhere instead of looking it up on the bot instance every time

#

Looking at d.py source it doesn't look like login can run more than once, even in the case of a connection reset or similar

#

But the login docstring in our bot subclass says "Re-create the connector..." so I'm not sure whether that may be implying something related

#

Ah this explains why it says that, so it's unrelated https://github.com/kwzrd/pydis-bot/commit/a21f4e63680e55149c33ee0bdde938281a8eb020

green oriole Mar 9, 2021, 7:07 PM

#

AFAIK we don't roll out new Http sessions right now, maybe we might in the future for some reason, but I don't think so

tough imp Mar 9, 2021, 7:12 PM

#

Oh well I just realized that I cannot safely do what I wanted to anyway because the session is still None at init time

green oriole Mar 9, 2021, 7:14 PM

#

Yeeeppp

tough imp Mar 9, 2021, 7:15 PM

#

But if you schedule a task in a cog's init that will access the session and try to make a request, is there a guarantee that login will have completed by then? (by the time your task runs)

#

It seems that we connect to Redis before instantiating bot to avoid that kind of a scenario

green oriole Mar 9, 2021, 7:37 PM

#

I thiiink so

#

It would be nice if you could still check that the instance us here and throw a better exception than an NPE if not

fallen patrol Mar 9, 2021, 9:52 PM

#

If sir Lancebot throws an error do all core devs get an email?

#

I hope not

#

Since I just caused a few errors

patent pivot Mar 9, 2021, 9:55 PM

#

if it's the same error then no

#

we get one email per error type

fallen patrol Mar 9, 2021, 9:56 PM

#

Oof

#

Threw an error on production

#

Tried to make it send a message over 2k characters.

#

#bot-commands message

fallen patrol Mar 9, 2021, 9:57 PM

#

patent pivot we get one email per error type

I threw perhaps the same error on both

#

Whups

patent pivot Mar 9, 2021, 9:58 PM

#

we didn't get an email

vale ibex Mar 9, 2021, 10:05 PM

#

fallen patrol Whups

Do you mind writing an issue on the bot repo for this? 😄

#

!src

stable mountainBOT Mar 9, 2021, 10:05 PM

#

Bot's GitHub Repository

Repository

Go to GitHub

fallen patrol Mar 9, 2021, 10:05 PM

#

vale ibex Do you mind writing an issue on the bot repo for this? 😄

@patent pivot told me it was triggered 3 months ago....

#

👀

patent pivot Mar 9, 2021, 10:06 PM

#

p sure we have a ssue

#

https://github.com/python-discord/bot/issues/1366

GitHub

The paginator should properly handle too long lines · Issue #1366 ·...

We often have some features feeding too long lines to the paginator, leading to a cryptic RuntimeError. The paginator should properly handle those. Here is a Sentry issue showing this error from th...

fallen patrol Mar 9, 2021, 10:06 PM

#

But do you have the issue for sir Lancebot?

patent pivot Mar 9, 2021, 10:06 PM

#

opened from the sentry issue you triggered 😄

fallen patrol Mar 9, 2021, 10:06 PM

#

I threw the same thing on lance

patent pivot Mar 9, 2021, 10:06 PM

#

hmmmm

#

which commmand

fallen patrol Mar 9, 2021, 10:07 PM

#

Well

#

Snake snakify

#

#sir-lancebot-playground message

#

Afaik I can check uwu as well if I get on a computer

static canyon Mar 9, 2021, 10:38 PM

#

Just noticed that some of the dates on the .zodiac command are seemingly off by one day (e.g. last day of Aries is counted as Taurus).

How would I go about making a PR to fix this? Looks like I just need to change https://github.com/python-discord/sir-lancebot/blob/1df233eb6e5061f0ed6127d158f9414e2b7749a3/bot/resources/valentines/zodiac_explanation.json but not sure what the correct process of doing this is.

vale ibex Mar 9, 2021, 10:42 PM

#

The formal process is raise issue -> core dev approves it -> implement fix -> raise PR -> PR approved by core dev -> merge to main

#

Sometimes for smaller fixes the first 2 can be skipped

#

(If a core dev approves it here)

cold island Mar 9, 2021, 10:42 PM

#

Will the linter scream at me if I try to use a string as a typehint?

static canyon Mar 9, 2021, 10:42 PM

#

vale ibex The formal process is raise issue -> core dev approves it -> implement fix -> ra...

Thanks 👍

vale ibex Mar 9, 2021, 10:42 PM

#

A literal string yes, str no

cold island Mar 9, 2021, 10:43 PM

#

hmmm

vale ibex Mar 9, 2021, 10:43 PM

#

3.9 brings that

cold island Mar 9, 2021, 10:43 PM

#

I don't want to import the actual class because that creates a circular import

vale ibex Mar 9, 2021, 10:43 PM

#

https://realpython.com/python39-new-features/#annotated-type-hints

brazen charm Mar 9, 2021, 10:44 PM

#

Forward refs are fine

tough imp Mar 9, 2021, 10:45 PM

#

maybe you can guard the import with if typing.TYPE_CHECKING?

#

if it's only used to annotate

cold island Mar 9, 2021, 10:45 PM

#

I will now find out what that is, thanks 👍

static canyon Mar 9, 2021, 10:52 PM

#

@vale ibex would I do this as a bug report issue?

#

If so, for the known impacted platforms should I just say all?

cold island Mar 9, 2021, 10:52 PM

#

you can open a bug report, yeah

#

yeah, the platforms part is more specific when it's an issue of formatting etc

#

but if it's a logic issue then it naturally affects everything

static canyon Mar 9, 2021, 11:03 PM

#

Think I've created that correctly lol

clever wraith Mar 9, 2021, 11:10 PM

#

Hey, made a small pr fixing this here #sir-lancebot-playground message

#

would appreciate if someone would review

#

sir-lancebot#621

dusky shoreBOT Mar 9, 2021, 11:11 PM

#

GitHub

PROpen [sir-lancebot] #621 Embed fix in earth_photos

short snow Mar 10, 2021, 12:45 AM

#

Can someone reply to this comment bot#1234 and bot#1154

dusky shoreBOT Mar 10, 2021, 12:45 AM

#

GitHub

PROpen [bot] #1234 Add timeit eval command
IssueOpen [bot] #1154 Add projects subcommands to source command

dusky shoreBOT Mar 10, 2021, 3:01 AM

#

GitHub

IssueOpen [bot] #1295 Improving dormant help channel embed

short snow Mar 10, 2021, 3:18 AM

#

dusky shore

?

vocal prairie Mar 10, 2021, 3:19 AM

#

I deleted my message since I found the answer.

clever wraith Mar 10, 2021, 3:31 AM

#

Why sir lance bot doesn't use YAML configuration like @stable mountain ?

short snow Mar 10, 2021, 3:40 AM

#

clever wraith Why sir lance bot doesn't use YAML configuration like <@409107086526644234> ?

For storing constants?

clever wraith Mar 10, 2021, 3:42 AM

#

yeah

short snow Mar 10, 2021, 3:44 AM

#

You can open a issue about that probably

#

it would easier than doing int(os.env(...., ....)) for every thing

clever wraith Mar 10, 2021, 3:47 AM

#

bot designed as a fun and beginner-friendly learning environment

I guess they didn't implement it because its' a beginner friendly project focused on simplicity/minimalism

short snow Mar 10, 2021, 4:31 AM

#

sir-lancebot#618 is up for review 😄

dusky shoreBOT Mar 10, 2021, 4:31 AM

#

GitHub

PROpen [sir-lancebot] #618 Wikiguess Game

short snow Mar 10, 2021, 8:41 AM

#

Have we found out the problem why .ttt is blocking?

keen valley Mar 10, 2021, 8:48 AM

#

https://github.com/python-discord/meta/discussions/85#discussioncomment-460910
What about this

GitHub

Off-topic channel name suggestions · Discussion #85 · python-discor...

green oriole Mar 10, 2021, 8:50 AM

#

What’s the context behind this one?

sharp timber Mar 10, 2021, 9:12 AM

#

I'm noticing that ctx.cog.games is never cleared except on restart, and it's looped over fully in several places, like here:

        if opponent is not None and not all(
            opponent not in (player.user for player in g.players) for g in ctx.cog.games if not g.over
        ):
``` which could get ugly if the number of games gets high

#

Calling .ttt actually runs this/similar logic three times

#

.ttt history

dusky shoreBOT Mar 10, 2021, 9:13 AM

#

Most recent Tic Tac Toe games

#1: @balmy sparrow vs AI (draw)

#2: @left flume :trophy: vs AI

short snow Mar 10, 2021, 9:14 AM

#

its back... we can merge my PR then

#

after review..

left flume Mar 10, 2021, 10:38 AM

#

Add this to the help command: py await ctx.send(ctx.author.mention, embed=embed) ^^^^^^^^^^^^^^^^^^

#

instead of sending 2 different msgs

#

I discovered this only because of TizzySaurus so credits to him

#

Its was an efficient feature so I thought I'd suggest it here

#

The bot only sends one message instead of two

green oriole Mar 10, 2021, 10:40 AM

#

I don’t get it, where do you want to add this?

left flume Mar 10, 2021, 10:40 AM

#

!help

static canyon Mar 10, 2021, 10:40 AM

#

When you do !help in a non-bot channel the bot will send two messages

#

One saying "here's the result" and one the actual result

#

They're suggestion merging the two messages into one

left flume Mar 10, 2021, 10:41 AM

#

ye

gritty wind Mar 10, 2021, 10:42 AM

#

short snow its back... we can merge my PR then

Your PR can be merged before or after we fix ttt, but that’s not the reason it is held up

#

Also we didn’t fix ttt

#

Just that it comes back online after restarts

green oriole Mar 10, 2021, 10:43 AM

#

!source help

stable mountainBOT Mar 10, 2021, 10:43 AM

#

Help Command

An interactive instance for the bot help command.

Source Code

Go to GitHub

green oriole Mar 10, 2021, 10:44 AM

#

hmm I don’t think that’s possible, at least not easily, we are using a decorator to redirect to #bot-commands https://github.com/python-discord/bot/blob/master/bot/decorators.py#L65

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

left flume Mar 10, 2021, 10:45 AM

#

alright

#

also, whats the asyncio.sleep for the help command?

green oriole Mar 10, 2021, 10:48 AM

#

Which line?

left flume Mar 10, 2021, 10:50 AM

#

Idk but there's an inactivity timeout for the help command isn't it?

#

How long is it before the bot stops responding to any further reactions

green oriole Mar 10, 2021, 10:51 AM

#

Yep, on the paginator

#

but it doesn’t use asyncio.sleep

left flume Mar 10, 2021, 10:51 AM

#

oh

#

how long tho?

green oriole Mar 10, 2021, 10:52 AM

#

It is asking d.py for a certain type of event, and provide a timeout paramater

#

I think it is either set to 2 or 5 minutes

left flume Mar 10, 2021, 10:56 AM

#

oh I see

#

thanks

short snow Mar 10, 2021, 11:50 AM

#

@sharp timber You have ticked both (I want to implement, anyone can implement) on sir-lancebot#622

dusky shoreBOT Mar 10, 2021, 11:51 AM

#

GitHub

IssueOpen [sir-lancebot] #622 Battleship game ends abruptly if given bad input

static canyon Mar 10, 2021, 1:55 PM

#

I've been going through the source code of the .zodiac command - re sir-lancebot#620 - and I noticed that there's some oddities, like for the .zodiac date command, the zodiac logic for capricorn is done manually, but then the rest of the signs are done in the zodiac_date_verifier? Is there a reasoning as to manually doing one but doing the other 11 manually? https://github.com/python-discord/sir-lancebot/blob/master/bot/exts/valentines/valentine_zodiac.py#L101-L106

dusky shoreBOT Mar 10, 2021, 1:55 PM

#

GitHub

IssueOpen [sir-lancebot] #620 Incorrect Zodiac Dates

gritty wind Mar 10, 2021, 2:10 PM

#

If I had to guess

#

it is done that way to avoid problems with the calculation between two years

#

Yeah I think it is

#

future = datetime.datetime(year=2021, month=1, day=10)
past = datetime.datetime(year=2020, month=12, day=15)
past.date() < datetime.datetime.now().date() < future.date()
> False

clever wraith Mar 10, 2021, 2:15 PM

#

Hey, there's a problem with the .easteravatarify command

#

It's really slow

gritty wind Mar 10, 2021, 2:16 PM

#

cc @vale ibex

clever wraith Mar 10, 2021, 2:16 PM

#

Oop

#

.avatareasterify

gritty wind Mar 10, 2021, 2:16 PM

#

.avatareasterify

clever wraith Mar 10, 2021, 2:16 PM

#

It types for about a minute

gritty wind Mar 10, 2021, 2:16 PM

#

yeah I think all the pfp ones are pretty slow

#

.help

#

it is blocking too it seems

#

The blocking part is what chris was looking into fixing

clever wraith Mar 10, 2021, 2:17 PM

#

Do 8bitify by comparison

gritty wind Mar 10, 2021, 2:17 PM

#

not sure if anything can be done for the speed 🤔

clever wraith Mar 10, 2021, 2:17 PM

#

Fair

gritty wind Mar 10, 2021, 2:17 PM

#

.8bitify

clever wraith Mar 10, 2021, 2:18 PM

#

It's a bit faster

#

But less processing I guess

gritty wind Mar 10, 2021, 2:18 PM

#

that is definitely a little faster, but probably just because its a different operation

#

yeah

clever wraith Mar 10, 2021, 2:18 PM

#

True

gritty wind Mar 10, 2021, 2:19 PM

#

I guess we could maybe spend time making micro tweaks to speed it up, but even if it takes a minute, I think that's fine for what it is

clever wraith Mar 10, 2021, 2:19 PM

#

It's probably not worth it

#

The only problem would be the blocking then

green oriole Mar 10, 2021, 2:22 PM

#

lemon_pensive

short snow Mar 10, 2021, 2:26 PM

#

Chris's PR should reduce it down pretty much
I will give it review tomorrow

static canyon Mar 10, 2021, 2:31 PM

#

gritty wind it is done that way to avoid problems with the calculation between two years

Yeah I guess that makes sense tbf

#

I would've thought there's an easier way but yea that works

gritty wind Mar 10, 2021, 2:31 PM

#

There probably is

#

you can compare timestamps

vale ibex Mar 10, 2021, 2:31 PM

#

It won't reduce the cpu load by much

#

but it will make it non-blocking

short snow Mar 10, 2021, 2:32 PM

#

it would, the number of uses would reduce

#

and not run too many process at one time

vale ibex Mar 10, 2021, 2:34 PM

#

Yea, it's a big PR, but most of the code is previous code that already existed, just moved into different files

sleek steppe Mar 10, 2021, 3:56 PM

#

When someone does .<some_group>, it sends help for that group, right? So when it does that, it uses ctx.send_help. Since the bot.help_command is commands.DefaultHelpCommand, it uses the (not so pretty) default help command. So I was thinking, instead of doing

await ctx.send_help(ctx.command)

We should do something like

help_command = ctx.bot.get_command("help")
await help_command(ctx, ctx.command.name)

sleek steppe Mar 10, 2021, 4:29 PM

#

I mean what would be better would be if we just subclassed commands.HelpCommand.

balmy sparrow Mar 10, 2021, 5:55 PM

#

Why're we shifting sir lancebot to use poetry instead of pipenv? (Not complaining, I've personally been a fan of poetry :P)

patent pivot Mar 10, 2021, 5:56 PM

#

We might not, we're just discussing it internally and wanted to give it a try

#

Full deets in the description of https://github.com/python-discord/sir-lancebot/pull/623

GitHub

Pipenv to poetry by jb3 · Pull Request #623 · python-discord/sir-la...

This PR migrates the dependency manager for Sir Lancebot to Poetry.
This is not intended to be merged anytime soon but is more of an experiment to see whether the tool integrates well and has good ...

balmy sparrow Mar 10, 2021, 5:57 PM

#

Ooh nice

#

Had issues with pipenv on my computer, poetry has always worked like a charm

#

Does one offer anything that the other doesn't? I think I read somewhere that poetry is used for packages or something

#

Maybe that's because of it's publish option

subtle kraken Mar 10, 2021, 6:03 PM

#

balmy sparrow Does one offer anything that the other doesn't? I think I read somewhere that po...

pipenv has scripts which poetry doesn't have, or so I don't recall it having it

patent pivot Mar 10, 2021, 6:11 PM

#

subtle kraken pipenv has scripts which poetry doesn't have, or so I don't recall it having it

I used the thing mark found for that

#

so you can do poetry run task lint

#

https://pypi.org/project/taskipy/

PyPI

taskipy

tasks runner for python projects

subtle kraken Mar 10, 2021, 6:12 PM

#

nice

tawdry vapor Mar 10, 2021, 6:35 PM

#

Can it avoid creating a venv?

patent pivot Mar 10, 2021, 6:40 PM

#

uhhhh

#

ah

#

yea

#

poetry config settings.virtualenvs.create false

tawdry vapor Mar 10, 2021, 6:42 PM

#

Preferably use the env var in docker and ci

patent pivot Mar 10, 2021, 6:43 PM

#

ah

#

founnd it yeah

#

alright just testing locally, build takes a bit because ffmpeg deps

gritty wind Mar 10, 2021, 6:49 PM

#

what are we using ffmpeg for?

patent pivot Mar 10, 2021, 6:50 PM

#

uhhhh

#

some voice commands on lancebot iirc

gritty wind Mar 10, 2021, 6:53 PM

#

hm

#

any idea which ones?

#

I didn't know we had voice commands lol

#

just a cursory search shows none, but I didn't look too hard

patent pivot Mar 10, 2021, 6:56 PM

#

lol I forget

#

spooky sounds @gritty wind

clever wraith Mar 10, 2021, 6:57 PM

#

@patent pivot what voice commands oooo

patent pivot Mar 10, 2021, 6:57 PM

#

.spookysound

#

sadge

gritty wind Mar 10, 2021, 6:57 PM

#

ah

clever wraith Mar 10, 2021, 6:57 PM

#

.spookysound

gritty wind Mar 10, 2021, 6:57 PM

#

that probably doesn't show up in the help menu

patent pivot Mar 10, 2021, 6:57 PM

#

seems we got rid of it now

gritty wind Mar 10, 2021, 6:57 PM

#

yeah

patent pivot Mar 10, 2021, 6:57 PM

#

but never liike

#

changed deps at all

gritty wind Mar 10, 2021, 6:58 PM

#

Has anyone ever cleaned deps lol

#

poetry should have a command for cleaning up some things, but lobbing parts off and seeing what breaks would be needed to clean everything up

patent pivot Mar 10, 2021, 6:59 PM

#

if it's in our dep file it won't be cleared up

vocal wolf Mar 10, 2021, 6:59 PM

#

isn't ffmpeg pretty heavy?

gritty wind Mar 10, 2021, 6:59 PM

#

does poetry have a post-install hook?

#

or any hooks for that matter

patent pivot Mar 10, 2021, 7:00 PM

#

to do what

gritty wind Mar 10, 2021, 7:00 PM

#

we can use it to remove hiredis

#

though that's more of a hypothetical

patent pivot Mar 10, 2021, 7:01 PM

#

hmm

#

hiredis won't even install so

gritty wind Mar 10, 2021, 7:01 PM

#

Hm, wdym?

#

It's a required dep

#

Ah I didn't mean install then remove

#

I meant not installing in the first place

patent pivot Mar 10, 2021, 7:03 PM

#

ah

green oriole Mar 10, 2021, 7:20 PM

#

vocal wolf isn't ffmpeg pretty heavy?

If by heavy you mean 8 minutes of downloading apt deps, yeah

vocal wolf Mar 10, 2021, 7:21 PM

#

lmao

clever wraith Mar 10, 2021, 7:35 PM

#

Thanks for the merge

vale ibex Mar 10, 2021, 7:39 PM

#

@short snow I intend to action the rest of your comments too, just don't have time for the others rn

sleek steppe Mar 10, 2021, 9:14 PM

#

For example, #sir-lancebot-playground message . I think we should invoke the help command instead.

short snow Mar 11, 2021, 12:05 AM

#

vale ibex <@!736234578745884682> I intend to action the rest of your comments too, just do...

Alright not a problem

cold island Mar 11, 2021, 12:17 AM

#

bot#1459 is out hyperlemon

dusky shoreBOT Mar 11, 2021, 12:17 AM

#

GitHub

PROpen [bot] #1459 Talentpool Autoreview

obsidian patio Mar 11, 2021, 12:18 AM

#

Great work👏

clever wraith Mar 11, 2021, 12:20 AM

#

@vale ibex congrats on getting mod!

short snow Mar 11, 2021, 12:23 AM

#

What does auto review do?

#

Got it

#

this looks jnteresting

#

I can try to give it a code review once done. Does it need rhe site pr setup?

patent pivot Mar 11, 2021, 12:36 AM

#

it does, yeah

short snow Mar 11, 2021, 12:38 AM

#

Welp, that means i would

#

require a site setup and not use the docker builds

#

Big task!

cold island Mar 11, 2021, 12:40 AM

#

you can use docker, it just requires some magic

#

I set up everything on my end by starting bot, site, and metricity on the same docker compose project

short snow Mar 11, 2021, 12:42 AM

#

I meant using the docker compose of bot

#

since that takes it from ghrcio

#

And even need metricity,

cold island Mar 11, 2021, 12:45 AM

#

youuu don't have to use metricity

#

but you will be limited in the data you can use

#

without manually populating the database

cold island Mar 11, 2021, 12:46 AM

#

short snow I meant using the docker compose of bot

you can start up the bot without the site

short snow Mar 11, 2021, 12:47 AM

#

Hmm, but u think your site pr makes it connect to metricity

cold island Mar 11, 2021, 12:47 AM

#

cold island you can start up the bot without the site

docker-compose up --no-deps bot

short snow Mar 11, 2021, 12:47 AM

#

cold island you can start up the bot without the site

yeah understood abiut that, thanks

#

Its given in the contributing guide on the site

cold island Mar 11, 2021, 12:48 AM

#

short snow Hmm, but u think your site pr makes it connect to metricity

wdym

#

You don't have to start up metricity, it will just tell you the user has no messages

short snow Mar 11, 2021, 12:52 AM

#

Ah ok, got it!

#

Metricity even stores deleted msgs, so do you count them?

cold island Mar 11, 2021, 12:53 AM

#

With joe's suggestion from ~20 minutes ago, not anymore

short snow Mar 11, 2021, 12:55 AM

#

Ok cool

#

will role giving dates helpmin review, like contributor role given to them in this date, etc.

#

And we can make all the voice channels as one

#

Voice chat

cold island Mar 11, 2021, 12:58 AM

#

I just realized I didn't limit the new commands to mods+

short snow Mar 11, 2021, 12:58 AM

#

Oh lol

floral venture Mar 11, 2021, 12:58 AM

#

Dumb question: How do I fork the repo with Docker?

cold island Mar 11, 2021, 1:00 AM

#

short snow will role giving dates helpmin review, like contributor role given to them in th...

not sure what you're asking

short snow Mar 11, 2021, 1:02 AM

#

Like in the auto review, you include msgs, top channel, date join, etc. We can include on which dates where they given whilemrole, like:

Roles:

Contributors given on {}.
Voice Verified given on {}

cold island Mar 11, 2021, 1:05 AM

#

hmm

#

we don't actually have that info I think

short snow Mar 11, 2021, 1:10 AM

#

probably, dpy doesn’t support it, any plans on storing it?

cold island Mar 11, 2021, 1:11 AM

#

not that I know of

short snow Mar 11, 2021, 1:22 AM

#

Worth doing tho.

#

We can include it in the !user also

floral venture Mar 11, 2021, 1:28 AM

#

I am getting the error

Traceback (most recent call last):
  File "bot.py", line 12, in <module>
    from bot import constants
  File "C:\Users\Osa\Documents\GitHub\sir-lancebot\bot\bot.py", line 12, in <module>
    from bot import constants
ImportError: cannot import name 'constants' from partially initialized module 'bot' (most likely due to a circular import) (C:\Users\Osa\Documents\GitHub\sir-lancebot\bot\bot.py)

When I try to start the bot.

brazen charm Mar 11, 2021, 1:28 AM

#

What would be the use for that data? Don't think it's particularly important to keep track of

thorny obsidian Mar 11, 2021, 1:29 AM

#

@floral venture how are you starting the bot? like the command you're typing into terminal

floral venture Mar 11, 2021, 1:29 AM

#

thorny obsidian <@!442088054321184778> how are you starting the bot? like the command you're typ...

I am simply opening bot.py

thorny obsidian Mar 11, 2021, 1:30 AM

#

so to run sir-lancebot I think you have to go do: python -m bot since it's running it as a module or something like that

#

make sure you're at the correct level to do so

floral venture Mar 11, 2021, 1:31 AM

#

thorny obsidian so to run sir-lancebot I think you have to go do: `python -m bot` since it's run...

I just tried that and it gave the same error but less long.

thorny obsidian Mar 11, 2021, 1:31 AM

#

what level of the directory are you on when you run that command?

floral venture Mar 11, 2021, 1:32 AM

#

thorny obsidian what level of the directory are you on when you run that command?

I am at C:\Users\Osa\Documents\GitHub\sir-lancebot\bot when I execute the command

thorny obsidian Mar 11, 2021, 1:32 AM

#

can you back out to sir-lancebot and try it again?

floral venture Mar 11, 2021, 1:34 AM

#

thorny obsidian can you back out to sir-lancebot and try it again?

Alright, I did that and after installing a few pips it threw a very long error that said Errno 11001

thorny obsidian Mar 11, 2021, 1:35 AM

#

Can you screenshot that error? Also, can you check what fakeredis is set to ... somewhere amongst the config files?

floral venture Mar 11, 2021, 1:37 AM

#

thorny obsidian Can you screenshot that error? Also, can you check what `fakeredis` is set to .....

Here is the screenshot, I could not seem to find the config files

thorny obsidian Mar 11, 2021, 1:38 AM

#

yup, $10 that's a redis thing. Give me 5 seconds, let me grab where you need to set fake-redis to true

#

@floral venture In your .env file, do you have USE_FAKEREDIS = true?

floral venture Mar 11, 2021, 1:40 AM

#

thorny obsidian <@!442088054321184778> In your .env file, do you have `USE_FAKEREDIS = true`?

I did not add that to the env no

thorny obsidian Mar 11, 2021, 1:41 AM

#

Try adding that and that error shoooould go away

floral venture Mar 11, 2021, 1:42 AM

#

thorny obsidian Try adding that and that error shoooould go away

I added it and I get the same error

thorny obsidian Mar 11, 2021, 1:45 AM

#

floral venture I added it and I get the same error

The env file is saved? Also can you change the line to: USE_FAKEREDIS=True

floral venture Mar 11, 2021, 1:46 AM

#

thorny obsidian The env file is saved? Also can you change the line to: `USE_FAKEREDIS=True`

I was sure to save the .env when I made the change and I tried many different formats (The one you suggested being the first I tried.)

thorny obsidian Mar 11, 2021, 1:47 AM

#

hurmmmm could you screenshot the .env file minute the bot token for me?

floral venture Mar 11, 2021, 1:49 AM

#

thorny obsidian hurmmmm could you screenshot the .env file minute the bot token for me?

Here you are.

thorny obsidian Mar 11, 2021, 1:54 AM

#

For the first one, can you change it to BOT_DEBUG=True?

floral venture Mar 11, 2021, 1:55 AM

#

Could it be the fact that I added CHANNEL_ANNOUNCEMENTS twice?

floral venture Mar 11, 2021, 1:56 AM

#

thorny obsidian For the first one, can you change it to `BOT_DEBUG=True`?

I tried that and same result btw

thorny obsidian Mar 11, 2021, 1:59 AM

#

floral venture Could it be the fact that I added `CHANNEL_ANNOUNCEMENTS` twice?

I would get rid of one and try it

floral venture Mar 11, 2021, 1:59 AM

#

thorny obsidian I would get rid of one and try it

I did that for both and got the same result

thorny obsidian Mar 11, 2021, 2:06 AM

#

@floral venture well it's definitely a redis issue. This is from the latest pull of the lancebot?

floral venture Mar 11, 2021, 2:07 AM

#

thorny obsidian <@!442088054321184778> well it's definitely a redis issue. This is from the late...

I pulled it around an hour ago so probably

thorny obsidian Mar 11, 2021, 2:07 AM

#

okay, let me pull the latest then

#

hmmmm, I just pulled it and with my .env file it works just fine.

#

@floral venture are you using pipenv or no?

floral venture Mar 11, 2021, 2:14 AM

#

thorny obsidian <@!442088054321184778> are you using `pipenv` or no?

I installed it yeah

thorny obsidian Mar 11, 2021, 2:16 AM

#

@floral venture so you're doing pipenv install to setup the environment and then pipenv run python -m bot to get it running?

sleek steppe Mar 11, 2021, 2:16 AM

#

sleek steppe For example, https://discord.com/channels/267624335836053506/607247579608121354/...

Should I just make an issue? It's been ignored twice lol

floral venture Mar 11, 2021, 2:24 AM

#

thorny obsidian <@!442088054321184778> so you're doing `pipenv install` to setup the environment...

You're awesome Thank you so much for the help!

sleek steppe Mar 11, 2021, 2:24 AM

#

sleek steppe Should I just make an issue? It's been ignored twice lol

Alright I got ignored again I'll just open an issue mmLul

vocal prairie Mar 11, 2021, 2:25 AM

#

sleek steppe Alright I got ignored again I'll just open an issue <:mmLul:785637594502529084>

I don't really understand what you mean.

#

Why would you invoke a help command for a command that already works?

sleek steppe Mar 11, 2021, 2:26 AM

#

?

#

It uses the default command that looks not as good.

#

like this

.[http_status|status|httpstatus] 

Group containing dog and cat http status code commands.

Commands:
  cat Sends an embed with an image of a cat, portraying the status code.
  dog Sends an embed with an image of a dog, portraying the status code.

Type .help command for more info on a command.
You can also type .help category for more info on a category.

#

instead of this

#

see?

#

It might be a command that works, but it doesn't look too good.

vocal prairie Mar 11, 2021, 2:29 AM

#

Oh, that would be nice.

sleek steppe Mar 11, 2021, 2:30 AM

#

Ok, would that be a bug or a feature?

#

I'm thinking it would be a bug

#

Actually, I'll make it a feature

thorny obsidian Mar 11, 2021, 2:39 AM

#

@sleek steppe you're not getting ignored, it's just I would need to really look into it and I don't quite have the time right now. Opening an issue is definitely the best way to go to get eyes on something

sleek steppe Mar 11, 2021, 2:41 AM

#

Alright, thanks!

floral venture Mar 11, 2021, 4:13 AM

#

What API is used for the .movies command?

vocal wolf Mar 11, 2021, 4:16 AM

#

floral venture What API is used for the .movies command?

IMDBv4 iirc

sleek steppe Mar 11, 2021, 4:17 AM

#

.source movies

#

blobpain

#

Ok this is the source https://github.com/python-discord/sir-lancebot/blob/master/bot/exts/evergreen/movie.py#L55-L101

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

#

It uses the movie db

floral venture Mar 11, 2021, 4:20 AM

#

vocal wolf IMDBv4 iirc

Hm, can I create an API key for free or does it cost a monthly subscription?

vocal wolf Mar 11, 2021, 4:20 AM

#

Pretty sure it's free

#

at least there's a free version of it

floral venture Mar 11, 2021, 4:23 AM

#

vocal wolf at least there's a free version of it

Ah alright, I can’t seem to find a link to the API website. Is it inside the code?

vocal wolf Mar 11, 2021, 4:24 AM

#

https://www.themoviedb.org/

vocal prairie Mar 11, 2021, 4:24 AM

#

This is in the code: https://api.themoviedb.org/3/

vocal wolf Mar 11, 2021, 4:24 AM

#

Here's the docs: https://developers.themoviedb.org/3

short snow Mar 11, 2021, 4:46 AM

#

floral venture You're awesome Thank you so much for the help!

You can also do pipenv run start

short snow Mar 11, 2021, 6:54 AM

#

buggg

#

the pfp is different and the author is different

#

(Sk9's pfp, and lemon is the author)

balmy sparrow Mar 11, 2021, 7:05 AM

#

https://github.com/python-discord/sir-lancebot/blob/10b98e96714c03264ab0f0e168bd5e682e7b1315/bot/exts/halloween/spookyavatar.py#L39 it's using ctx.author for the image, instead of the user arg that is passed

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

short snow Mar 11, 2021, 7:06 AM

#

yes

balmy sparrow Mar 11, 2021, 7:06 AM

#

seems like a super small fix, whoever was working on making the image commands run in executors can add this in too

short snow Mar 11, 2021, 7:07 AM

#

i will add a comment during the next review on it

#

@vocal wolf we should remove good first issue from https://github.com/python-discord/bot/issues/1427 and add deferred since there are problems in on_typing event of discord.py. Ig

GitHub

Place 3 help channels in the available pool · Issue #1427 · python-...

Following on from python-discord/meta#92. We want to provide a third help channel in the available category so that more people can type their question at once without the channel being claimed hal...

vocal wolf Mar 11, 2021, 7:21 AM

#

@short snow you should discuss that within the issue so we don't lose this to time

short snow Mar 11, 2021, 7:22 AM

#

i will comment.

vocal wolf Mar 11, 2021, 7:22 AM

#

ty

short snow Mar 11, 2021, 7:28 AM

#

vocal wolf ty

done.

#

was finding the context

#

hence took time

vocal wolf Mar 11, 2021, 7:28 AM

#

ok_handbutflipped

short snow Mar 11, 2021, 1:07 PM

#

@cold island I had left two comments on your review on Enhance Incidents msg, did you check them out?

cold island Mar 11, 2021, 1:26 PM

#

Thanks! I will check them soon

sleek steppe Mar 11, 2021, 2:20 PM

#

How do you get the emojis when running locally?

obsidian patio Mar 11, 2021, 2:20 PM

#

Are you referring to emojis like the trashcan?

sleek steppe Mar 11, 2021, 2:21 PM

#

Yep

obsidian patio Mar 11, 2021, 2:23 PM

#

For local testing, I'd recommend just replacing it with something else. For example, the trash emoji can be replaced with ❌

sleek steppe Mar 11, 2021, 2:24 PM

#

How do you replace it?

gritty wind Mar 11, 2021, 2:24 PM

#

Are you on sir-lancebot or python?

sleek steppe Mar 11, 2021, 2:24 PM

#

sir-lancebot

gritty wind Mar 11, 2021, 2:25 PM

#

In that case you really don't need to.

#

If you still want to

#

It's line 154 in the constants file

obsidian patio Mar 11, 2021, 2:25 PM

#

The trashcan should need to be replaced

gritty wind Mar 11, 2021, 2:25 PM

#

just make sure to not accidentally commit your changes

#

The program runs fine without it

obsidian patio Mar 11, 2021, 2:25 PM

#

This one https://github.com/python-discord/sir-lancebot/blob/10b98e96714c03264ab0f0e168bd5e682e7b1315/bot/constants.py#L171 (line 171 in constants.py)

gritty wind Mar 11, 2021, 2:25 PM

#

it will produce an error when you paginate or something

#

but it won't stop

sleek steppe Mar 11, 2021, 2:25 PM

#

Yeah I guess so

cold moon Mar 11, 2021, 2:37 PM

#

I think we should use 🗑️ instead? This is default emoji

green oriole Mar 11, 2021, 2:54 PM

#

@celest charm snekbox is made to run stuff from untrusted sources

#

I’d consider a user provided regex and input as untrusted

#

It would make sense to put a memory and resource limit on it

#

Also as for regex101.com, I mean, there is repl.it to execute code, but yet we have !eval

#

Keeping some stuff inside Discord is useful

celest charm Mar 11, 2021, 2:55 PM

#

repl.it is slow to set up

green oriole Mar 11, 2021, 2:55 PM

#

That’s my two cents on it

celest charm Mar 11, 2021, 2:55 PM

#

regex101 is instant

#

The only harmful side-effect of regular expressions is taking too much time. (given that their size is limited to 2000)

#

They can't do networking or launch missiles

green oriole Mar 11, 2021, 2:56 PM

#

They are memory based regex dos attacks, aren’t they?

celest charm Mar 11, 2021, 2:56 PM

#

no

#

time-based

green oriole Mar 11, 2021, 2:57 PM

#

Hmm okay

#

We can run it into another thread and kill it after a few seconds if that’s the real issue

celest charm Mar 11, 2021, 2:57 PM

#

In another process, maybe.

#

Because otherwise it would block

gritty wind Mar 11, 2021, 2:58 PM

#

if the problem with snekbox that the formatting isn't great, we already do parsing for snkebox results

celest charm Mar 11, 2021, 2:58 PM

#

I just don't see the need to invoke snekbox. It's like using SpaceX to get to the grocery store

gritty wind Mar 11, 2021, 2:59 PM

#

if the grocery store was on the moon, that would make sense

#

likewise

thorny obsidian Mar 11, 2021, 2:59 PM

#

(must.... resist.... otn... a....)

green oriole Mar 11, 2021, 2:59 PM

#

What if there is a black hole between you and the shop

gritty wind Mar 11, 2021, 2:59 PM

#

snekbox is for running arbitrary code

celest charm Mar 11, 2021, 2:59 PM

#

regex isn't arbitrary code

green oriole Mar 11, 2021, 3:00 PM

#

It is an arbitrary input though

gritty wind Mar 11, 2021, 3:00 PM

#

I still think we're taking user input

#

and running it through an evaluation process on our end

celest charm Mar 11, 2021, 3:00 PM

#

lol, we're taking user input in every command

#

and running it through an evaluation process

gritty wind Mar 11, 2021, 3:00 PM

#

which just seems safer in an isolated environment

celest charm Mar 11, 2021, 3:00 PM

#

should we run every command in snekbox?

gritty wind Mar 11, 2021, 3:00 PM

#

that's not the same for every command and you know it

green oriole Mar 11, 2021, 3:00 PM

#

I mean, between converting a string to an int and executing regex there is a world

#

Regex is dangerous

#

it isn’t advised to execute regex from an unstruted source

#

While casting to an int is fine

gritty wind Mar 11, 2021, 3:01 PM

#

I honestly don't see the pushback against snekbox

#

is there some reason that we shouldn't use snekbox

celest charm Mar 11, 2021, 3:01 PM

#

We don't run arbitrary code because it can produce arbitrary side-effects, like talking to the network.

Regex isn't "arbitrarily dangerous". It can simply take much time, which is mitigated:

By running it in a separate process;
By using the regex library

celest charm Mar 11, 2021, 3:02 PM

#

gritty wind is there some reason that we shouldn't use snekbox

The same reason we don't convert strings to integers via snekbox.

gritty wind Mar 11, 2021, 3:02 PM

#

green oriole I mean, between converting a string to an int and executing regex there is a wor...

^

green oriole Mar 11, 2021, 3:02 PM

#

celest charm We don't run arbitrary code because it can produce arbitrary side-effects, like ...

So why don’t we do that

celest charm Mar 11, 2021, 3:02 PM

#

If you want, I can reopen my PR

#

and we'll discuss there

#

but I don't think I'll be able to work on it, I'm busy with other things

green oriole Mar 11, 2021, 3:03 PM

#

Sure

#

We have all the time in the world

#

Well, maybe not all of it

#

But still

gritty wind Mar 11, 2021, 3:03 PM

#

again

#

I still don't understand why we can't use snekbox

#

this isn't as dangerous as running user code

#

but also not as safe as an int cast

celest charm Mar 11, 2021, 3:04 PM

#

Safety isn't measured on a spectrum. There are very specific things that can go wrong.

#

In case of regex, the only side-effect is taking too much time. Do you disagree?

gritty wind Mar 11, 2021, 3:05 PM

#

I don't know, I'm not a regex expert

#

So? What's the cost related with evaluating random user input in snekbox

green oriole Mar 11, 2021, 3:05 PM

#

At some point our resources will be gone though

#

We can’t execute a regex for 10 minutes, we simply can’t handle that

gritty wind Mar 11, 2021, 3:06 PM

#

That can be circumvented with the regex library

celest charm Mar 11, 2021, 3:06 PM

#

green oriole We can’t execute a regex for 10 minutes, we simply can’t handle that

well, I already said how to prevent it

gritty wind Mar 11, 2021, 3:06 PM

#

but still, the opportunity for doing something malicious seems greater than the cost of running in snekbox

#

that cost still being a mystery to me

green oriole Mar 11, 2021, 3:07 PM

#

celest charm well, I already said how to prevent it

I really don’t get where is the issue then

#

I guess snekbox has some overhead when transmitting over the network and preparing the process

#

But that’s nothing compared to running a somewhat complicated regex

celest charm Mar 11, 2021, 3:09 PM

#

The solution with snekbox will:

take more time to execute;
be more complex (because we'll have to construct Python source code for snekbox to be executed and interpret snekbox's results correctly);
take more computational power on snekbox side;
be harder to fix bugs in and to change (because you'll have to setup snekbox to run the command)

green oriole Mar 11, 2021, 3:11 PM

#

Doesn’t take any additional computational power

celest charm Mar 11, 2021, 3:11 PM

#

Snekbox will have to set up and tear down the Python interpreter

#

but yes, not too much

gritty wind Mar 11, 2021, 3:12 PM

#

The time taken for snekbox is not noticeable, go ahead and try the eval command
I don't think that's really true, it's slightly more complex, but nothing crazy
Like starting it up?
That seems like a good trade of for ease of mind to me

#

I mean just look at the eval command

#

that has people trying to break it

#

all the damn time

celest charm Mar 11, 2021, 3:12 PM

#

I'm not saying it will make the command unusable. I'm just saying that that's the cost.

gritty wind Mar 11, 2021, 3:12 PM

#

I don't think that's a cost

#

Taking arbitrary input and executing it seems like a no-brainer for snekbox imo

green oriole Mar 11, 2021, 3:13 PM

#

Resoirces wise, that’s a cost I’m fine with

#

It is worth the investment

gritty wind Mar 11, 2021, 3:13 PM

#

!e print("this is instantaneous")

stable mountainBOT Mar 11, 2021, 3:13 PM

#

@gritty wind :white_check_mark: Your eval job has completed with return code 0.

this is instantaneous

celest charm Mar 11, 2021, 3:13 PM

#

It's not arbitrary code, for christ sake

green oriole Mar 11, 2021, 3:13 PM

#

Arbitrary data?

celest charm Mar 11, 2021, 3:14 PM

#

I also already said that every command takes arbitrary data.
Arbitrary code is dangerous because it can do harmful side-effects, like networking.

green oriole Mar 11, 2021, 3:14 PM

#

.>

gritty wind Mar 11, 2021, 3:15 PM

#

Ok here are my final thoughts on this

#

Regex is input that we put through more dangerous evaluation that something like an int cast. There is no real cost imo associated with snekbox evaluation. Peace of mind can sometimes come at the cost of minor redundancies.

celest charm Mar 11, 2021, 3:16 PM

#

Okay, you can write the command if you want

#

"Interpreting untrusted arbitrary user input as an integer is unsafe. We don't know what happens if a user finds some special input that explodes the computer. So we'll do it in snekbox."

#

Excuse me for the tone.

#

My point is that if there's some bug in re/regex that causes some behaviour other than timeout, it's a bug, similar to a bug in the integer parsing.

green oriole Mar 11, 2021, 3:20 PM

#

Was the regex library timeout proven to be unreliable?

celest charm Mar 11, 2021, 3:20 PM

#

No.

green oriole Mar 11, 2021, 3:20 PM

#

Well, not sure why it has be rejected then

gritty wind Mar 11, 2021, 3:20 PM

#

I'm not gonna keep arguing this. I don't think you're wrong

#

But I also think I'm not wrong

fallen patrol Mar 11, 2021, 3:21 PM

#

but its a bug. We can plan something might happen, but if it does, we may not know it happened. If regex were to break snekbox, then there's bigger problems, such as snekbox having a glaring security issue that needs to be fixed.
I think I'm following, correct me if I'm off here

green oriole Mar 11, 2021, 3:21 PM

#

I honestly think all three are good solutions, maybe there is one better than the other, but in the end they all work

celest charm Mar 11, 2021, 3:21 PM

#

fallen patrol but its a bug. We can plan something might happen, but if it does, we may not kn...

If we account for such bugs, we should account for a bug in integer parsing as well.

gritty wind Mar 11, 2021, 3:21 PM

#

I'm not trying to account for bugs in the std library

#

that's not what I'm arguing

celest charm Mar 11, 2021, 3:21 PM

#

I'm not saying you are

gritty wind Mar 11, 2021, 3:22 PM

#

what I'm saying is that regex is a language that can be exploited, at least easier than something like an integer conversion

fallen patrol Mar 11, 2021, 3:22 PM

#

celest charm If we account for such bugs, we should account for a bug in integer parsing as w...

couldn't a regex command just be wrap a submission with some regex code and run it? Easy~~

gritty wind Mar 11, 2021, 3:22 PM

#

If the cost of evaluating in snekbox is low

#

and the benefit is that it's less likely to mess up a critical thing in the server's infrastructure

#

Then I think its an ok tradeoff

#

that being said

#

I understand you wanting to keep things simple

#

and rely on existing tools

celest charm Mar 11, 2021, 3:24 PM

#

I just think the fear is not rational. You haven't provided any justification to believe that there is a risk of something other than time consumption in regular expressions.

#

well, other than that it's a more complex language than integers

green oriole Mar 11, 2021, 3:24 PM

#

If the timeout was proven to be unreliable, it will slow down our whole infra and make the bot OOM

celest charm Mar 11, 2021, 3:25 PM

#

We could just use re and wrap it in standard timeout prevention from stdlib

fallen patrol Mar 11, 2021, 3:25 PM

#

celest charm We could just use `re` and wrap it in standard timeout prevention from stdlib

but why not use snekbox?

gritty wind Mar 11, 2021, 3:25 PM

#

It's not about past exploits/current limitations exclusively

#

As a more complex language

celest charm Mar 11, 2021, 3:26 PM

#

fallen patrol but why *not* use snekbox?

<#dev-contrib message>

gritty wind Mar 11, 2021, 3:26 PM

#

it is more likely for exploits to be found in it

#

then for something relatively simpler like type casts

celest charm Mar 11, 2021, 3:26 PM

#

alright, let's just stop this

#

If so many people are worried about potential exploits, alright, let's make it call snekbox.

green oriole Mar 11, 2021, 3:28 PM

#

I am okay with killing a thread after a certain amount of time

#

that should be safe enough

#

or process

celest charm Mar 11, 2021, 3:29 PM

#

Same. (can't really kill a thread, so a process)

vocal prairie Mar 11, 2021, 3:33 PM

#

Quick question. I'm working on improving the pagination (and the trash can) experience by deleting reactions that aren't from the OP, so how would I be able to test this code? Because as far as I know, @stable mountain is customized for this server specifically.

gritty wind Mar 11, 2021, 3:33 PM

#

we have a guide on setting up the bot, and a server template to help you get it done

#

So you may need to take some time to set things up

#

you can find the guide

#

https://pythondiscord.com/pages/contributing/bot/

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

here

vocal prairie Mar 11, 2021, 3:34 PM

#

Thanks you!

sleek steppe Mar 11, 2021, 4:12 PM

#

sir-lancebot#624 🙂

dusky shoreBOT Mar 11, 2021, 4:12 PM

#

GitHub

IssueOpen [sir-lancebot] #624 Using group commands without specifying a subcommand sends the default help command.

sleek steppe Mar 11, 2021, 5:29 PM

#

Can someone review this issue?

vocal prairie Mar 11, 2021, 5:29 PM

#

Is there a more updated server template? I can see the one in the website for setting up the bot testing, but that doesn't have all the channels.

gritty wind Mar 11, 2021, 5:31 PM

#

The template shouldn’t require any new channels

#

But it also doesn’t have all the channels

#

You just need the ones listed in the guide

vocal prairie Mar 11, 2021, 5:32 PM

#

Oh ok.

#

I was looking more at the config.yml file, so I guess I confused myself.

vocal wolf Mar 11, 2021, 6:48 PM

#

@gritty wind poke https://github.com/python-discord/bot/issues/1457#issuecomment-792985956

gritty wind Mar 11, 2021, 6:48 PM

#

Oh

#

I can assign you?

#

We can remove the field name as well in the shortened version

#

I'll add that now

sleek steppe Mar 11, 2021, 7:20 PM

#

Can anyone look at sir-lancebot#624 ?

dusky shoreBOT Mar 11, 2021, 7:20 PM

#

GitHub

IssueOpen [sir-lancebot] #624 Using group commands without specifying a subcommand sends the default help command.

vocal wolf Mar 11, 2021, 7:26 PM

#

gritty wind I can assign you?

yes.

#

I can do this PR

fallen patrol Mar 11, 2021, 10:15 PM

#

smh

#

snekbox, pipenv has a glitch

#

sleek steppe Mar 11, 2021, 10:57 PM

#

How long does it usually take for someone to respond to an issue lol?

vocal wolf Mar 11, 2021, 10:59 PM

#

sleek steppe How long does it usually take for someone to respond to an issue lol?

Depends on the problem/question/bug at hand, and the activity of contributes. Given certain circumstances, a response could occur anywhere from a couple minutes to a couple days.

#

Which issue are you referring to?

sleek steppe Mar 11, 2021, 11:00 PM

#

dusky shore

this one ^

#

It's not a big one

vocal wolf Mar 11, 2021, 11:02 PM

#

@sleek steppe approved. You can begin working on it whenever. Just a confirmation: You're intending to make .games send the first embed when help is needed?

sleek steppe Mar 11, 2021, 11:06 PM

#

vocal wolf <@!506618674921340958> approved. You can begin working on it whenever. Just a co...

Well, not only .games, I have a list. It's .snakes, .space, .emoji, .minesweeper, .movies, .status, .extensions (and its subcommands), and .bemyvalentine

vocal wolf Mar 11, 2021, 11:07 PM

#

Right

sleek steppe Mar 11, 2021, 11:07 PM

#

All of them use ctx.send_help

vocal wolf Mar 11, 2021, 11:07 PM

#

Sounds good to me

sleek steppe Mar 11, 2021, 11:07 PM

#

I'm also ready to PR now 🙂

vocal wolf Mar 11, 2021, 11:11 PM

#

sleek steppe I'm also ready to PR now 🙂

You have the changes ready?

sleek steppe Mar 11, 2021, 11:11 PM

#

Well, not yet but I've pushed

vocal wolf Mar 11, 2021, 11:11 PM

#

huh

#

yeah go ahead with the PR lol

#

But next time I suggest waiting for an issue to be approved before working on it

#

Users have gone ahead in the past to make a PR and get rejected because their changes were not discussed

sleek steppe Mar 11, 2021, 11:13 PM

#

Sorry I guess I was a little impatient

vocal wolf Mar 11, 2021, 11:13 PM

#

np

cold island Mar 11, 2021, 11:18 PM

#

yeah it's not a problem, it might just turn out to be a waste of time on your end if it ends up rejected

fallen patrol Mar 12, 2021, 12:36 AM

#

👀

#

help

#

I'm trying to run a snekbox, but having trouble with docker-compose

#

👀

sharp timber Mar 12, 2021, 12:58 AM

#

That's probably redis

#

@fallen patrol try setting fakeredis to true in the env file

fallen patrol Mar 12, 2021, 1:00 AM

#

WAIT SNEKBOX USES REDIS?

#

why???

sharp timber Mar 12, 2021, 1:01 AM

#

#dev-contrib message or FAKEREDIS=True in the .env

#

I don't think it does

#

but snekbox doesn't make http requests I don't think? Does it?

#

What's the rest of that error

fallen patrol Mar 12, 2021, 1:02 AM

#

👀

#

hm

#

I didn't make a .env

#

brb time to check how .env files work 😰

#

okay so

#

as I continue to find an issue i continue to fix the issue

#

docker was not running as a service

#

currently is building the image

tawdry vapor Mar 12, 2021, 1:26 AM

#

snekbox doesn't use redis. That environment variable would do nothing.

fallen patrol Mar 12, 2021, 1:28 AM

#

ye

#

hm

#

what kind of request does snekbot what

#

!src e

stable mountainBOT Mar 12, 2021, 1:29 AM

#

Command: eval

Run Python code and get the results.

Source Code

Go to GitHub

tawdry vapor Mar 12, 2021, 1:30 AM

#

That's the source for the command, not for the server.

fallen patrol Mar 12, 2021, 1:30 AM

#

no i know

#

the server is running now

#

I have to make the client part side to test it

#

…where does the bot make the requests

tawdry vapor Mar 12, 2021, 1:31 AM

#

It's all in that file

fallen patrol Mar 12, 2021, 1:32 AM

#

which file

tawdry vapor Mar 12, 2021, 1:32 AM

#

The one linked to you by the command above

fallen patrol Mar 12, 2021, 1:32 AM

#

ah

#

data = {"input": code}

#

and json equals that

#

👏

#

got a snekbox running now

vocal wolf Mar 12, 2021, 1:52 AM

#

bot#1452 needs review.

dusky shoreBOT Mar 12, 2021, 1:52 AM

#

GitHub

PROpen [bot] #1452 Remove invoked command and message after failure.

sleek steppe Mar 12, 2021, 2:02 AM

#

sir-lancebot#625 needs review 👀

dusky shoreBOT Mar 12, 2021, 2:02 AM

#

GitHub

PROpen [sir-lancebot] #625 change ctx.send_help to ctx.invoke(help_command)

short snow Mar 12, 2021, 2:05 AM

#

!remind 5h ^^^ and chris’ move pfp commands

stable mountainBOT Mar 12, 2021, 2:05 AM

#

I got you.

Your reminder will arrive in 5 hours!

fallen patrol Mar 12, 2021, 5:05 AM

#

👀 why was snake snakify updated to use an embed?

stable mountainBOT Mar 12, 2021, 7:05 AM

#

@short snow

It has arrived!

Here's your reminder: ^^^ and chris’ move pfp commands.
[Jump back to when you created the reminder](#dev-contrib message)

fallen patrol Mar 12, 2021, 7:09 AM

#

!remind 1s wait I can use this here?

stable mountainBOT Mar 12, 2021, 7:09 AM

#

I'll allow it.

Your reminder will arrive in 1 second!

#

@fallen patrol

It has arrived!

Here's your reminder: wait I can use this here?.
[Jump back to when you created the reminder](#dev-contrib message)

fallen patrol Mar 12, 2021, 7:09 AM

#

Oh okay

fallen patrol Mar 12, 2021, 7:09 AM

#

fallen patrol 👀 why was snake snakify updated to use an embed?

Also, boop.

#

Of someone had answer

short snow Mar 12, 2021, 7:10 AM

#

stable mountain <@736234578745884682>

!remind 30M

stable mountainBOT Mar 12, 2021, 7:10 AM

#

Missing required argument

content

fallen patrol Mar 12, 2021, 7:14 AM

#

short snow !remind 30M

Failed argument

short snow Mar 12, 2021, 7:15 AM

#

nvm, am free now. Will review them

cinder wharf Mar 12, 2021, 11:13 AM

#

I'm quite new to docker, does the docker image for snekbox host the API on the local host? How would I use the API from a python program from the same local host?

eternal owl Mar 12, 2021, 12:08 PM

#

https://github.com/python-discord/snekbox#running-snekbox

GitHub

python-discord/snekbox

Easy, safe evaluation of arbitrary Python code. Contribute to python-discord/snekbox development by creating an account on GitHub.

short snow Mar 12, 2021, 12:33 PM

#

@cold island i have a question, is this the way, we use multiple line strings in bot or just your method:

review = f"They were nominated **{nomination_times}** before"
review += f", but their nomination was called off **{rejection_times}**."

I mean the way you use += to add strings

cold island Mar 12, 2021, 12:35 PM

#

This isn't a multiple line string, I still want everything to be written in the same line, it was just too long to be written as such in the code. I could in retrospect do:

review = (
  f"They were nominated **{nomination_times}** before"
  f", but their nomination was called off **{rejection_times}**."
)

I think

#

I just went with the style that was already in the cog

short snow Mar 12, 2021, 12:35 PM

#

Yeah, i meant why don't didn't u use () and used += instead

#

oh ok, might wanna change it?

cold island Mar 12, 2021, 12:36 PM

#

Yeah that might be a good idea

short snow Mar 12, 2021, 12:36 PM

#

should i add it is as a comment on my review or you will just do it

cold island Mar 12, 2021, 12:36 PM

#

Either is fine

#

You can add a comment if you want credit for the change lol

short snow Mar 12, 2021, 12:37 PM

#

my pr is gonna come like tomorrow, so your choice

#

lol, no need 😄

#

also the spelling of maxiumum in _cog is wrong

#

it should be maximum

#

but you haven't change that part, so i can't comment there

green oriole Mar 12, 2021, 12:39 PM

#

....... lol

vocal wolf Mar 12, 2021, 12:44 PM

#

https://github.com/python-discord/bot/pull/1452 one more approval/review is needed.

short snow Mar 12, 2021, 1:39 PM

#

https://github.com/python-discord/bot/pull/1014#discussion_r531249324 is this right?

GitHub

Doc improvements by Numerlor · Pull Request #1014 · python-discord/...

Improves the doc command to have more consistent outputs and speeds it up with a bit of caching
Visual

old
new

relative urls are now resolved to absolute, allowing them to be used from...

green oriole Mar 12, 2021, 1:40 PM

#

What do you mean?

short snow Mar 12, 2021, 1:43 PM

#

like, all the arguments need to be on separate line

#

and

green oriole Mar 12, 2021, 1:43 PM

#

Well, yes

short snow Mar 12, 2021, 1:43 PM

#

def func(
  a,b,c
):
``` is bad

#

ok thanks

fallen patrol Mar 12, 2021, 1:49 PM

#

cinder wharf I'm quite new to docker, does the docker image for `snekbox` host the API on the...

127.0.0.1:8060/eval

cinder wharf Mar 12, 2021, 1:49 PM

#

fallen patrol `127.0.0.1:8060/eval`

Ah okay

#

And btw, is there any precautions I should take?

fallen patrol Mar 12, 2021, 1:50 PM

#

¯_(ツ)_/¯

short snow Mar 12, 2021, 2:24 PM

#

is there a grammarly plugin for pycharm prof?

vocal wolf Mar 12, 2021, 2:28 PM

#

Doesn't pycharm already check grammer automatically?

green oriole Mar 12, 2021, 2:28 PM

#

There’s the JB plugin...uhhh...

#

Grazzle?

sleek steppe Mar 12, 2021, 2:29 PM

#

@short snow what do you think would be a good attribute name for the help command? Since help_command is already taken up.

green oriole Mar 12, 2021, 2:34 PM

#

I personally think the current solution is fine

#

We may run into issues of the cog is reloaded

sleek steppe Mar 12, 2021, 2:36 PM

#

Yep or if it's unloaded entirely.

#

Which hopefully doesn't happen

green oriole Mar 12, 2021, 2:41 PM

#

I don't mind have it error out of it is unloaded honestly

sleek steppe Mar 12, 2021, 2:41 PM

#

Maybe I should check if help_command is None and if it is use ctx.send_help

#

Or does it not matter

green oriole Mar 12, 2021, 2:50 PM

#

I guess we can have a utility function doing that

short snow Mar 12, 2021, 3:30 PM

#

sleek steppe <@736234578745884682> what do you think would be a good attribute name for the h...

self.custom_help_command maybe

#

anything is fine

#

for me

#

hence i gave a approve

clever wraith Mar 12, 2021, 4:26 PM

#

!remind 20m review chris's pfp executors PR (sir-lancebot#597)

stable mountainBOT Mar 12, 2021, 4:26 PM

#

Of course!

Your reminder will arrive in 1 year and 8 months!

dusky shoreBOT Mar 12, 2021, 4:26 PM

#

GitHub

PROpen [sir-lancebot] #597 Move pfp commands into executors

clever wraith Mar 12, 2021, 4:26 PM

#

oh great

#

!remind 20 minutes review chris's pfp executors PR (sir-lancebot#597)

stable mountainBOT Mar 12, 2021, 4:26 PM

#

Bad argument

minutes is not a valid duration string.

dusky shoreBOT Mar 12, 2021, 4:26 PM

#

GitHub

PROpen [sir-lancebot] #597 Move pfp commands into executors

stable mountainBOT Mar 12, 2021, 4:26 PM

#

Command Help

!remind [mentions]... <expiration> <content>
Can also use: reminder, reminders, remindme

Commands for managing your reminders.

Subcommands:

!remind delete <id_>
Delete one of your active reminders.
!remind edit
Commands for modifying your current reminders.
!remind list
View a paginated embed of all reminders for your user.
!remind new [mentions]... <expiration> <content>
Set yourself a simple reminder.

short snow Mar 12, 2021, 4:28 PM

#

Welp, try your best not pollute these channels

clever wraith Mar 12, 2021, 4:30 PM

#

yup

#

how do I review again?

fallen patrol Mar 12, 2021, 4:30 PM

#

Out of curiosity

#

Is there any talk to update snekbox to a different framework

sleek steppe Mar 12, 2021, 4:31 PM

#

clever wraith how do I review again?

You look at the files changed tab

clever wraith Mar 12, 2021, 4:31 PM

#

ok

short snow Mar 12, 2021, 4:32 PM

#

fallen patrol Is there any talk to update snekbox to a different framework

You can talk to mark or seb about that most probably

green oriole Mar 12, 2021, 4:32 PM

#

fallen patrol Is there any talk to update snekbox to a different framework

Like removing falcon?

fallen patrol Mar 12, 2021, 4:32 PM

#

What is falcon?

#

ASGI framework? 😓

short snow Mar 12, 2021, 4:32 PM

#

They are talking about nsjail most probably

fallen patrol Mar 12, 2021, 4:32 PM

#

Oh, no, the api framework

green oriole Mar 12, 2021, 4:33 PM

#

We are using falcon for the API framework

fallen patrol Mar 12, 2021, 4:33 PM

#

Cause I was going to mess around with ns_jail and possibly use it for my own stuff.

#

*snekbox

#

**with licensed credit

#

:D

green oriole Mar 12, 2021, 4:34 PM

#

I don't understand what you are asking

fallen patrol Mar 12, 2021, 4:34 PM

#

And since I intend to rewrite the framework to a different one, FastAPI, if it was already in the works I'd either wait or help.

green oriole Mar 12, 2021, 4:35 PM

#

Alright, I don't think we plan to change it

#

It works fairly well right now, and we only have one route

fallen patrol Mar 12, 2021, 4:35 PM

#

Cause I know a different point is planned to be rewritten

#

Yeah

#

I think that's the dB api to be rewritten in FastAPI

green oriole Mar 12, 2021, 4:36 PM

#

Ah yeah, we are going to separate it from the Django website and rewrite it in FastAPI

fallen patrol Mar 12, 2021, 4:38 PM

#

Ye

short snow Mar 12, 2021, 4:56 PM

#

sir-lancebot#605 needs review 😄

dusky shoreBOT Mar 12, 2021, 4:56 PM

#

GitHub

PROpen [sir-lancebot] #605 Add WTF Python Command

left flume Mar 12, 2021, 6:09 PM

#

So this is what I made for sir-lancebot issue#613. I hope this is okay. I'll then modify it according to the contributor guidelines if needed. Just wanted a staff member to kinda like review it...

https://paste.pythondiscord.com/zozekigasi.py

clever wraith Mar 12, 2021, 6:17 PM

#

sir-lancebot#613

dusky shoreBOT Mar 12, 2021, 6:17 PM

#

GitHub

IssueOpen [sir-lancebot] #613 Rock-Paper-Scissors Command

clever wraith Mar 12, 2021, 6:18 PM

#

@left flume nice, maybe add uhh the ability to play against other players?

left flume Mar 12, 2021, 6:18 PM

#

hmmmmmmmmmmmmmmmmmmmmmmmmmm

#

well thats something that i cant do...

#

but if im given some time, ill try adding it

sleek steppe Mar 12, 2021, 6:27 PM

#

left flume well thats something that i cant do...

!d discord.ext.commands.Bot.wait_for

stable mountainBOT Mar 12, 2021, 6:27 PM

#

`discord.ext.commands.Bot.wait_for`

wait_for(event, *, check=None, timeout=None)```
This function is a [*coroutine*](https://docs.python.org/3/library/asyncio-task.html#coroutine).

Waits for a WebSocket event to be dispatched.

This could be used to wait for a user to reply to a message, or to react to a message, or to edit a message in a self-contained way.

The `timeout` parameter is passed onto [`asyncio.wait_for()`](https://docs.python.org/3/library/asyncio-task.html#asyncio.wait_for "(in Python v3.9)"). By default, it does not timeout. Note that this does propagate the [`asyncio.TimeoutError`](https://docs.python.org/3/library/asyncio-exceptions.html#asyncio.TimeoutError "(in Python v3.9)") for you in case of timeout and is provided for ease of use.

In case the event returns multiple arguments, a [`tuple`](https://docs.python.org/3/library/stdtypes.html#tuple "(in Python v3.9)") containing those arguments is returned instead. Please check the [documentation](../../api.html#discord-api-events) for a list of events and their parameters.... [read more](https://discordpy.readthedocs.io/en/stable/ext/commands/api.html#discord.ext.commands.Bot.wait_for)

sleek steppe Mar 12, 2021, 6:28 PM

#

but maybe it would have to do that in the dms or something.

sleek steppe Mar 12, 2021, 6:29 PM

#

green oriole I guess we can have a utility function doing that

Whre do you think I can put it?

left flume Mar 12, 2021, 6:29 PM

#

thanks

#

why would it need to be in dms tho?

sleek steppe Mar 12, 2021, 6:30 PM

#

So they can't see each other's choices.

green oriole Mar 12, 2021, 6:31 PM

#

bot.utils.extensions I'd say

sleek steppe Mar 12, 2021, 6:31 PM

#

Would invoke_help_command(ctx, *commands) suffice?

left flume Mar 12, 2021, 6:33 PM

#

oh, I see

green oriole Mar 12, 2021, 6:41 PM

#

I think so

sleek steppe Mar 12, 2021, 6:42 PM

#

why does this happen why I try to login to github thonk

clever wraith Mar 12, 2021, 6:42 PM

#

@sleek steppe issues with github apparently

sleek steppe Mar 12, 2021, 6:43 PM

#

oh right

green oriole Mar 12, 2021, 6:45 PM

#

Uh oh

sleek steppe Mar 12, 2021, 7:11 PM

#

Ok, it seems to be working now.

sleek steppe Mar 12, 2021, 7:53 PM

#

green oriole `bot.utils.extensions` I'd say

Isn't that for the extensions command?

green oriole Mar 12, 2021, 7:54 PM

#

Well, that's an utility to retrieve an extension I guess

sleek steppe Mar 12, 2021, 8:00 PM

#

green oriole Well, that's an utility to retrieve an extension I guess

Is checking if exts.evergreen.help is in extensions fine?

vocal wolf Mar 12, 2021, 8:20 PM

#

@tough imp Sorry, I'm having a bit of trouble understanding your comment here about the available_help_channels attribute. It does make sense that if an admin moves a channel it would get desynced, but what do you mean by "the d.py representation"?

https://github.com/python-discord/bot/pull/1414#discussion_r589386847

#

Also, I do think we should keep the dynamic_message attribute as we need to access it when checking if the ID can be edited at all when a channel is moved.

tough imp Mar 12, 2021, 8:22 PM

#

Okay let me explain ~ btw you definitely don't need to address that comment, it was just thoughts that I had when looking over the code

vocal wolf Mar 12, 2021, 8:23 PM

#

I've resolved everything else besides this so far, I think the feature is nearing completion.

grim tide Mar 12, 2021, 8:24 PM

#

how does the bot know when to unmute/unban someone? I know they store the timestamp in a db, but how will the bot know the timestamp is over?

tough imp Mar 12, 2021, 8:25 PM

#

So we're keeping a set of available help channels, but so does d.py, we use their representation when the set is empty:

self.available_help_channels = set(
  c for c in self.available_category.channels if not _channel.is_excluded_channel(c)
)

So what I was thinking is, could we always use self.available_category.channels and not keep our own? Because that category should remain up-to-date even when the bot itself doesn't move the channel. If you don't keep your own state, you lose the burden of maintaining it, and you don't risk desync in case someone other than the bot moves the channel

#

But I think the problem with looking at self.available_category.channels is that it may not be up-to-date yet - I'm hypothesising a little bit, but I believe that when you send a channel move request to the API, even if you await it, it doesn't mean that we've received the "channel move" event back from Discord, so the self.available_category.channels may be lagging behind

tough imp Mar 12, 2021, 8:29 PM

#

grim tide how does the bot know when to unmute/unban someone? I know they store the timest...

I belive on start-up the bot pulls the infractions from the database and schedules the un-do event as an async task

grim tide Mar 12, 2021, 8:29 PM

#

i see. thanks :))

tough imp Mar 12, 2021, 8:29 PM

#

That's an oversimplification, but in general I believe that's how it works

grim tide Mar 12, 2021, 8:31 PM

#

yeah my instinctive approach is to keep a local cache of the db and check it every second for any timestamps that match the current one, but I figured that is too resource intensive and also it's prone to error (e.g. accidentally skipped a second) - so that's a bad idea

#

but thanks for explaining anyway :)

tough imp Mar 12, 2021, 8:31 PM

#

There is a scheduler abstraction that the bot uses to handle this

#

But I'm not familiar with it

gritty wind Mar 12, 2021, 8:31 PM

#

The skipping a second problem can be solved by checking if a timestamp is current or in the past

#

but the tasks system seems much simpler

grim tide Mar 12, 2021, 8:32 PM

#

and less resource intensive (imagine checking a database every single second)

vocal wolf Mar 12, 2021, 8:32 PM

#

tough imp So we're keeping a set of available help channels, but so does d.py, we use thei...

The reason I create this set is to not include the how-to-get-help channel in the test server, and the #🔴｜cooldown｜🔴 channel next to the available help channels (if that's not not included already).

tough imp Mar 12, 2021, 8:32 PM

#

If you can live with a little imprecision, you could just query every e.g. 5 minutes, and un-do all infractions that are in the past

vocal wolf Mar 12, 2021, 8:33 PM

#

But having the set in general isn't the best idea, yeah

grim tide Mar 12, 2021, 8:33 PM

#

tough imp If you can live with a little imprecision, you could just query every e.g. 5 min...

that's a compromize, i guess.

tough imp Mar 12, 2021, 8:34 PM

#

You could probably do the check in the database, so that you're not pulling the whole table every time, just select expired infractions

#

Imprecise but simple

tough imp Mar 12, 2021, 8:35 PM

#

vocal wolf The reason I create this set is to not include the how-to-get-help channel in th...

Your solution is fine mr_thumbers

grim tide Mar 12, 2021, 8:35 PM

#

tough imp You could probably do the check in the database, so that you're not pulling the ...

i'm assuming SQL is better in this case (since the format is fixed, and it's much easier and efficient to just add a row)

#

actually, saying that, SQL is designed for a lot of queries so i don't see this being too big of a different tbf

tough imp Mar 12, 2021, 8:36 PM

#

I have another wild idea that I haven't put much thought into - could we utilize a channel change listener? That should receive all events, not only those triggered by the bot

#

And check if a help channel was moved ~ if so, update the message

#

But yeah, feel free to keep what you have

tough imp Mar 12, 2021, 8:38 PM

#

grim tide i'm assuming SQL is better in this case (since the format is fixed, and it's muc...

Yes, when I say database I usually just assume something SQL-based

#

Unless your infraction table is gargantuan it should be a simple select that gets processed very quickly

grim tide Mar 12, 2021, 8:38 PM

#

this server has a tendency towards nosql from what i could see; but I'm not experienced with any nosql except json so I'll prefer sql whenever possible

gritty wind Mar 12, 2021, 8:39 PM

#

We have a ton of sql, especially for @stable mountain, but I doubt you'll be dealing with enough data for it to matter

#

so do what you feel comfortable with

grim tide Mar 12, 2021, 8:40 PM

#

thanks

vocal wolf Mar 12, 2021, 8:46 PM

#

tough imp Your solution is fine <:mr_thumbers:386686131460374528>

lemon_long we can keep the current implementation for now, then make a large change with a PR once we discover how to rework the desync. The current PR is now ready for re-review.

tough imp Mar 12, 2021, 8:47 PM

#

mr_thumbers

vocal wolf Mar 12, 2021, 8:56 PM

#

@tough imp Thank you for showing me ~~de wey~~ that self.bot.http methods are a thing, because I didn't know they existed.

green oriole Mar 12, 2021, 9:00 PM

#

sleek steppe Is checking if `exts.evergreen.help` is in extensions fine?

I think so, I'm not 100% sure

tough imp Mar 12, 2021, 9:01 PM

#

vocal wolf <@!144912469071101952> Thank you for showing me ~~de wey~~ that `self.bot.http` ...

Yea they are super convenient for when you only have IDs

vocal wolf Mar 12, 2021, 9:01 PM

#

ye

tough imp Mar 12, 2021, 9:02 PM

#

I dont think a Message.edit really does much apart from passing its own ID and the channel ID to the HTTP method anyway

fallen patrol Mar 12, 2021, 10:39 PM

#

tough imp Yea they are super convenient for when you only have IDs

Aren't they only a thing on a custom implementation

#

Or is bot.http standard on dpy

sleek steppe Mar 12, 2021, 10:41 PM

#

fallen patrol Or is bot.http standard on dpy

http is a part of discord.Client and that's how it makes requests I think. https://github.com/Rapptz/discord.py/blob/master/discord/http.py

GitHub

Rapptz/discord.py

An API wrapper for Discord written in Python. Contribute to Rapptz/discord.py development by creating an account on GitHub.

#

the HttpClient class specifically: https://github.com/Rapptz/discord.py/blob/master/discord/http.py#L93

fallen patrol Mar 12, 2021, 10:47 PM

#

O

short snow Mar 13, 2021, 12:41 AM

#

green oriole Grazzle?

Grazle*

short snow Mar 13, 2021, 12:56 AM

#

Why don't we have black code formatter in our linter?

gritty wind Mar 13, 2021, 12:58 AM

#

If you want, you can try configuring black for your setup

#

That being said

#

I’m fairly against it, because we try to be as open and accommodating to as many styles as possible

#

While maintaining a workable code base

sleek steppe Mar 13, 2021, 1:08 AM

#

sir-lancebot#625 needs review. (finally got flake8 to be happy lol)

dusky shoreBOT Mar 13, 2021, 1:08 AM

#

GitHub

PROpen [sir-lancebot] #625 change ctx.send_help to ctx.invoke(help_command)

short snow Mar 13, 2021, 1:08 AM

#

will have a look

sleek steppe Mar 13, 2021, 1:13 AM

#

Also, is there away to run flake8 so it can pass the checks first try?

gritty wind Mar 13, 2021, 1:13 AM

#

What's the first failure?

sleek steppe Mar 13, 2021, 1:13 AM

#

The imports

gritty wind Mar 13, 2021, 1:14 AM

#

Are you running flake8 directly, or through the lint command?

sleek steppe Mar 13, 2021, 1:14 AM

#

I ran flake8 directly

#

Also with pre-commit

gritty wind Mar 13, 2021, 1:17 AM

#

Well to only run it once, it would have to be auto fixing

#

and it doesn't auto correct imports

sleek steppe Mar 13, 2021, 1:18 AM

#

Why did it pass though?

gritty wind Mar 13, 2021, 1:18 AM

#

If it passed after the first run, something has modified them since, but it isn't flake

#

What IDE are you using?

sleek steppe Mar 13, 2021, 1:19 AM

#

vscode

gritty wind Mar 13, 2021, 1:20 AM

#

I'm not sure what's fixing it then :P

sleek steppe Mar 13, 2021, 1:21 AM

#

It didn't get modified though, I had to change them myself.

gritty wind Mar 13, 2021, 1:21 AM

#

Ah right

#

So that's why it passed the second time then, no?

sleek steppe Mar 13, 2021, 1:22 AM

#

I pushed 3 times, and flake8 passed all three times.

gritty wind Mar 13, 2021, 1:22 AM

#

Ah got you

#

Your hooks are most likely not using the flake8 plugins

#

There is a workaround

#

one secc

#

Putting this in .git\hooks\pre-commit

#

It's a bit hacky but pipenv and pre-commit don't play nice in some contexts

thorny obsidian Mar 13, 2021, 1:25 AM

#

Ah, the windows, vscode, and pre-commit thingy

gritty wind Mar 13, 2021, 1:25 AM

#

you can drop vscode, it's on pycharm too :P

#

just windows pain

thorny obsidian Mar 13, 2021, 1:25 AM

#

#

I literally have it in a section for my personal PyDis notes

gritty wind Mar 13, 2021, 1:26 AM

#

We should just PR that to pre-commit lol

tawdry vapor Mar 13, 2021, 3:36 AM

#

Why does the hook have to be modified. Is it not just a git configuration issue?

#

I didn't have to modify my hook and I don't have problems with line ending hooks

thorny obsidian Mar 13, 2021, 3:39 AM

#

I don't really use git on the command line. I like to use it within vscode or git kraken. To get it to play nice with vscode on windows, I ended up having to modify the pre-commit.

gritty wind Mar 13, 2021, 3:39 AM

#

The hook runs completely out of the venv when run with a GUI on windows

tawdry vapor Mar 13, 2021, 3:39 AM

#

Your editor should respect your gitconfig. And you'd need to configure line endings in your editor too.

gritty wind Mar 13, 2021, 3:40 AM

#

The line endings thing is pretty easy to change, but idk what’s up with the venv thing

tawdry vapor Mar 13, 2021, 3:40 AM

#

Also i am pretty sure autocrlf must be false, not input.

gritty wind Mar 13, 2021, 3:40 AM

#

At one point I tried switching it to system in the precommit config, but that seems to have been changed on master with no effect

tawdry vapor Mar 13, 2021, 3:41 AM

#

Never mind, doesn't seem to matter...

however, if a file with CRLF endings accidentally gets introduced, then you may want Git to fix it. You can tell Git to convert CRLF to LF on commit but not the other way around by setting core.autocrlf to input:

gritty wind Mar 13, 2021, 3:41 AM

#

Isn’t input just whatever is on the repo

tawdry vapor Mar 13, 2021, 3:41 AM

#

Input is what I quoted above.,

gritty wind Mar 13, 2021, 3:41 AM

#

Ah no

#

Alright

#

Fair enough

thorny obsidian Mar 13, 2021, 3:42 AM

#

Yeah, habit from using VSCode for work stuff that I forget to change my line endings and the like. Sometimes I do my work stuff on my beefier desktop, so I forget to revert. And you presume a lot about me having any sort of proper gitconfig lemon_sweat

tawdry vapor Mar 13, 2021, 3:43 AM

#

Well it's a legitimate concern if many contributors encounter issues with the line ending hook. It's not a particularly important hook, so if it comes down to it, we can get rid of it. Requiring the hook to be modified is far from ideal. However, I'm trying to see if there is a more reasonable solution like just editing the gitconfig

gritty wind Mar 13, 2021, 3:44 AM

#

I mean I don't think removing it will help much in this instance

#

the worst thing it does is give a false sense of security

#

when it works it works, when it doesn't it just lints without the plugins

tawdry vapor Mar 13, 2021, 3:45 AM

#

I mean removing just the line ending hook. Is there a bigger issue that I'm not understanding?

gritty wind Mar 13, 2021, 3:45 AM

#

Ah, thought you were talking about flake8

tawdry vapor Mar 13, 2021, 3:45 AM

#

A fix was pushed for flake8 a few months ago.

#

At least I thought it was. Maybe there's a different issue now.

thorny obsidian Mar 13, 2021, 3:47 AM

#

Oh these are my notes from awhile ago. I think Numerlor confirmed that it was fixed so is less of an issue

gritty wind Mar 13, 2021, 3:47 AM

#

I thought it was too

gritty wind Mar 13, 2021, 3:47 AM

#

sleek steppe I pushed 3 times, and flake8 passed all three times.

But this was typical behavior for that problem, so idk

thorny obsidian Mar 13, 2021, 3:48 AM

#

I don't think the line ending hook is that bad. Maybe it's worth having a "hey, if you're on windows let's fix your line-endings" thing in the contribution guide

tawdry vapor Mar 13, 2021, 3:48 AM

#

Unfortunately git doesn't have provisions for letting us check in local configs

#

Despite having a repository-local config feature

#

We could have a pipenv script to set the right settings.

gritty wind Mar 13, 2021, 3:49 AM

#

Hmm

#

Isn't there an option for that hook to have it match the pre-existing line endings?

#

By default on windows, it'll clone in CRLF but push in LF

#

So whatever the hook does on windows doesn't really matter