#dev-contrib | Python | Page 84

short snow Feb 12, 2021, 6:17 AM

#

after a process of reviews and checls

#

or sometimes without those

short snow Feb 12, 2021, 7:09 AM

#

wooohooo!

#

atlast now cht can work in help channels

#

@vocal wolf they are no longer in this server, ak said so

#

i wanted the list of anthems they had collected

vocal wolf Feb 12, 2021, 7:19 AM

#

rip

#

I'll see if they respond

#

I think this would be a cool feature. If anyone's interested, you can give it a poke. https://github.com/python-discord/sir-lancebot/issues/73

short snow Feb 12, 2021, 8:26 AM

#

so pypi is ready for review?

#

sir-lancebot#73

dusky shoreBOT Feb 12, 2021, 8:27 AM

#

GitHub

IssueOpen [sir-lancebot] #73 [Feature Request] Seasonal information

short snow Feb 12, 2021, 8:27 AM

#

hmmm

keen valley Feb 12, 2021, 9:34 AM

#

short snow <@!196664644113268736> they are no longer in this server, ak said so

lol

granite goblet Feb 12, 2021, 10:19 AM

#

Also tagging @short snow Hey! Sorry this is actually already implemented, I'll reply on github as well. You can search for 'prideanthem' to see example usage,, unless there's something else going on?

#

(It was PR #227)

green oriole Feb 12, 2021, 10:21 AM

#

granite goblet Also tagging <@!736234578745884682> Hey! Sorry this is actually already implemen...

Hello, and welcome back! I don’t think anyone is working on it right now (CC @vocal wolf), feel free to open a PR if you feel like it. 😄

granite goblet Feb 12, 2021, 10:22 AM

#

green oriole Hello, and welcome back! I don’t think anyone is working on it right now (CC <@!...

Oh no, I'm saying the issue is out of date. I already submitted a PR to implement that command, and it was accepted and merged in

green oriole Feb 12, 2021, 10:22 AM

#

Oh, it is already implemented

granite goblet Feb 12, 2021, 10:22 AM

#

Yeah :D

vocal wolf Feb 12, 2021, 10:22 AM

#

green oriole Hello, and welcome back! I don’t think anyone is working on it right now (CC <@!...

The PR was already implemented in sir-lancebot#227

dusky shoreBOT Feb 12, 2021, 10:22 AM

#

GitHub

PRMerged [sir-lancebot] #227 Implemented .prideanthem command

granite goblet Feb 12, 2021, 10:23 AM

#

Not to say there's no added functionality you could work on if you wanted ^^

green oriole Feb 12, 2021, 10:23 AM

#

Is there anything in the issue that hasn’t been implemented yet?

granite goblet Feb 12, 2021, 10:27 AM

#

I don't remember if I implemented a way to refrain from repeating songs quickly, and I'm sure there's more songs out there to add now, there was a suggestion to include a foreign or foreign language flag to include to allow/select pride anthems in other languages, I don't think I did that

And then there was the unanswered question of support for adding more pride anthems through the command (e.g. .prideanthem add <song info> rather than through prs

#

I'm actually heading to bed right now though, but feel free to tag me in any questions and I'll get back to you tomorrow :D

green oriole Feb 12, 2021, 10:33 AM

#

Alrighty, have a good night!

gritty bolt Feb 12, 2021, 10:45 AM

#

What's the brief and help parameter for @commands.command() for?

short snow Feb 12, 2021, 12:01 PM

#

Help parameter basically overwrites the the docstring on our @commands.command() function

#

and

#

Brief is The short help text for the command.

clever wraith Feb 12, 2021, 2:06 PM

#

how is this? https://github.com/python-discord/sir-lancebot/issues/587

GitHub

Add command for fun facts about Python · Issue #587 · python-discor...

Description A simple command that would give you fun facts about python itself. Reasoning If people wanted to learn more about Python and get some trivia, this would be a useful command. Proposed I...

short snow Feb 12, 2021, 2:14 PM

#

Patience you must have my young Padwan

clever wraith Feb 12, 2021, 2:26 PM

#

short snow Patience you must have my young Padwan

ok

gritty bolt Feb 12, 2021, 2:35 PM

#

short snow Help parameter basically overwrites the the docstring on our `@commands.command(...

What's the difference between the help parameter and regular docstring?

sleek steppe Feb 12, 2021, 2:55 PM

#

gritty bolt What's the difference between the help parameter and regular docstring?

Don't really understand that question

#

It's just the difference between

@command(help = 'This is a good command')
async def command(ctx): ...

And

@command()
async def command(ctx):
"""This is a good command"""
    ...

gritty bolt Feb 12, 2021, 3:26 PM

#

So the only difference is where the text is placed?

clever wraith Feb 12, 2021, 3:29 PM

#

should I wait for my issues to get approved, or start on the PR?

exotic ember Feb 12, 2021, 3:31 PM

#

clever wraith should I wait for my issues to get approved, or start on the PR?

yes please, that way there is less wasted work in the event the issue scope changes

short snow Feb 12, 2021, 3:38 PM

#

gritty bolt What's the difference between the help parameter and regular docstring?

sometimes for making it easier to understand code, coders incldue their explaination of the code, which is unncessary for the other ppl in the community to know

#

hence you use the help parameter to override it

short snow Feb 12, 2021, 3:38 PM

#

sleek steppe It's just the difference between ``` @command(help = 'This is a good command') a...

like this ^

#

    @command(
        help = 'Docstring that the community members would see when do a help on the command',
        aliases=(...)
    )
    async def command(ctx):
        """Docstring that contributors would see when looking at this pr."""
        ...

#

is github webhook every going to update my profile pic 😤

green oriole Feb 12, 2021, 3:52 PM

#

You need to clear the cache

short snow Feb 12, 2021, 3:52 PM

#

and how do i? on desktop ubuntu

green oriole Feb 12, 2021, 3:55 PM

#

Clear ~/.cache/discord maybe?

clever wraith Feb 12, 2021, 4:01 PM

#

exotic ember yes please, that way there is less wasted work in the event the issue scope chan...

ok

exotic ember Feb 12, 2021, 4:07 PM

#

hmmm?

clever wraith Feb 12, 2021, 4:20 PM

#

edited

clever wraith Feb 12, 2021, 5:14 PM

#

@gritty wind how were the changes i made?

gritty wind Feb 12, 2021, 5:14 PM

#

Haven't had a chance to start reviewing things today yet

#

I'll let you know when I get around to it

clever wraith Feb 12, 2021, 5:26 PM

#

ok

clever wraith Feb 12, 2021, 7:56 PM

#

@gritty wind so how is it?

gritty wind Feb 12, 2021, 8:02 PM

#

I'm still working on other things, haven't gotten around to it

clever wraith Feb 12, 2021, 8:22 PM

#

gritty wind I'm still working on other things, haven't gotten around to it

ok

vocal wolf Feb 12, 2021, 9:29 PM

#

@serene flare are you ChrisLovering on GitHub?

patent pivot Feb 12, 2021, 9:30 PM

#

that's the other chris lol @vocal wolf

vocal wolf Feb 12, 2021, 9:30 PM

#

darn

patent pivot Feb 12, 2021, 9:30 PM

#

this chris is uhhhh

#

i have the name

vocal wolf Feb 12, 2021, 9:32 PM

#

bot#1416 needs review(s)

dusky shoreBOT Feb 12, 2021, 9:32 PM

#

GitHub

PROpen [bot] #1416 Creation of the PyPi command.

sleek steppe Feb 12, 2021, 9:36 PM

#

vocal wolf <@!347272409151438858> are you ChrisLovering on GitHub?

I think it's @vale ibex

vocal wolf Feb 12, 2021, 9:37 PM

#

You are correct

serene flare Feb 12, 2021, 9:37 PM

#

Sorry to disappoint!

vocal wolf Feb 12, 2021, 9:37 PM

#

Chris with an underscore is Wubbzi

serene flare Feb 12, 2021, 9:38 PM

#

correct

clever wraith Feb 13, 2021, 1:08 AM

#

i would like to improve @dusky shore 's xkcd command

short snow Feb 13, 2021, 1:14 AM

#

oepn a issue

#

saying how will u improve it

#

and why

short snow Feb 13, 2021, 2:01 AM

#

can we quicly have a look at the valentine fix pr

#

or valetine would get over 😦

clever wraith Feb 13, 2021, 2:16 AM

#

how do I make a new branch?

#

(yes ik i'm dumb)

short snow Feb 13, 2021, 2:18 AM

#

clever wraith how do I make a new branch?

git checkout -b feature/name

clever wraith Feb 13, 2021, 2:19 AM

#

ok

ember cloud Feb 13, 2021, 3:02 AM

#

should there be a command explaining .whl files?

#

and this site https://www.lfd.uci.edu/~gohlke/pythonlibs

gritty bolt Feb 13, 2021, 3:05 AM

#

For sir lancebot, is there a way for the evergreen error handler to not give out the error ERROR: Unhandled command error:

#

I have have handled the error on the cog, but for some reason, the evergreen error handler is still triggered

clever wraith Feb 13, 2021, 3:16 AM

#

@gritty wind how were the changes I made?

gritty wind Feb 13, 2021, 3:19 AM

#

Again, I will tell you when I get around to reviewing it

tawdry vapor Feb 13, 2021, 3:45 AM

#

gritty bolt For sir lancebot, is there a way for the evergreen error handler to not give out...

Yes. Set the handled attribute on the exception you handled to True.

gritty bolt Feb 13, 2021, 3:46 AM

#

Wait, so like error.handled = True?

tawdry vapor Feb 13, 2021, 3:47 AM

#

Yes

gritty bolt Feb 13, 2021, 3:48 AM

#

That's neat, thanks

gritty bolt Feb 13, 2021, 5:22 AM

#

What's the command to see the help message for a cog?

#

Or do I have to manually make one?

short snow Feb 13, 2021, 5:31 AM

#

clever wraith <@!386599446571384843> how were the changes I made?

https://tenor.com/view/yoda-patience-you-must-have-patience-gif-15254127

Tenor

short snow Feb 13, 2021, 5:31 AM

#

gritty bolt What's the command to see the help message for a cog?

<prefix>help <command>

short snow Feb 13, 2021, 5:32 AM

#

tawdry vapor Yes. Set the `handled` attribute on the exception you handled to `True`.

where would that be put? In our cog error handler right?

#

@vocal wolf can you put a image on how the pypi looks now?

#

the pypi command of bot

tawdry vapor Feb 13, 2021, 5:34 AM

#

No. The error handler is coded to ignore errors that have that attribute

vocal wolf Feb 13, 2021, 5:34 AM

#

look at the very top comment

#

of the PR

#

image has been updated

short snow Feb 13, 2021, 5:34 AM

#

ok thanks!

tawdry vapor Feb 13, 2021, 5:34 AM

#

You need to set it in your local error handler

short snow Feb 13, 2021, 5:35 AM

#

ok thanks Mark!

gritty bolt Feb 13, 2021, 6:20 AM

#

For sir lancebot, is it possible for the help parameters of commands.command to display a list of arguments one could make?

#

For example, I have keys in a dictionary which are the arguments the user can put into the command

cold island Feb 13, 2021, 7:49 AM

#

hmm how can I use a converter without context?

short snow Feb 13, 2021, 8:06 AM

#

@vocal wolf #bot-commands message we forgot something, we need to escape the *.

#

or they would get bold or in italics

vocal wolf Feb 13, 2021, 8:07 AM

#

There's so many edge cases lol

#

thanks, I'll implement that soon

short snow Feb 13, 2021, 8:07 AM

#

🤷

#

cool, np!

#

again, it was vester who caught the edge case

#

idk how he always does that.

celest charm Feb 13, 2021, 8:11 AM

#

cold island hmm how can I use a converter without context?

If the converter doesn't require any info from context, it should be a simple function, right?

#

Otherwise, it doesn't make sense to call a converter without a context, because it needs some info from it

cold island Feb 13, 2021, 8:16 AM

#

celest charm If the converter doesn't require any info from context, it should be a simple fu...

it doesn't use the context from what I see

celest charm Feb 13, 2021, 8:16 AM

#

@cold island Does it do any async actions?

cold island Feb 13, 2021, 8:16 AM

#

but it's a signature used by dpy

#

so I don't think you can change it

celest charm Feb 13, 2021, 8:17 AM

#

@cold island https://discordpy.readthedocs.io/en/latest/ext/commands/commands.html#converters
discord.py allows any callable to be used as a converter

#

but if you need async stuff or access to the context, you need to make a class

cold island Feb 13, 2021, 8:18 AM

#

it doesn't use anything async

celest charm Feb 13, 2021, 8:18 AM

#

Then why isn't it a function?

cold island Feb 13, 2021, 8:19 AM

#

🤷‍♂️

celest charm Feb 13, 2021, 8:20 AM

#

@cold island I guess you could
a) make it a function;
b) extract the conversion logic into a function that will be called in two places;
c) just copypaste the logic, because the fact that your algorithm matches the converter could be a coincidence.

#

d) pass None or some other garbage for ctx in the converter method, but that's evil and should not be done

cold island Feb 13, 2021, 8:21 AM

#

But then I have to change all places where it was used 😔

celest charm Feb 13, 2021, 8:21 AM

#

@cold island wdym?

#

b) and c) don't have this issue

cold island Feb 13, 2021, 8:22 AM

#

c isn't the case

celest charm Feb 13, 2021, 8:22 AM

#

then b)

cold island Feb 13, 2021, 8:22 AM

#

I'm passing None rn but it's pretty meh

celest charm Feb 13, 2021, 8:22 AM

#

ugh

#

👀

#

Well, it has the obvious disadvantage that if the converter starts requiring the context, your part will crash and burn.

#

So maybe just extract the conversion logic into its own method/function?

cold island Feb 13, 2021, 8:23 AM

#

it really has nothing to do with dpy logic

green oriole Feb 13, 2021, 8:23 AM

#

What do you want to convert?

cold island Feb 13, 2021, 8:23 AM

#

DurationDelta

celest charm Feb 13, 2021, 8:23 AM

#

can you give a link?

green oriole Feb 13, 2021, 8:23 AM

#

Isn't that a custom converter

cold island Feb 13, 2021, 8:23 AM

#

it is

celest charm Feb 13, 2021, 8:24 AM

#

found it https://github.com/python-discord/bot/blob/79bfab3c1e90aeb148fda1fddceb671ea4602db3/bot/converters.py#L301

#

Yeah, idk why it's a class

cold island Feb 13, 2021, 8:24 AM

#

it's subclassed below

#

which is... weird

celest charm Feb 13, 2021, 8:24 AM

#

oh jesus

cold island Feb 13, 2021, 8:24 AM

#

why the fuck is it subclassed lol

celest charm Feb 13, 2021, 8:24 AM

#

mamma mia

cold island Feb 13, 2021, 8:25 AM

#

It's like Ellipse(Circle)

celest charm Feb 13, 2021, 8:25 AM

#

yeah lmao

green oriole Feb 13, 2021, 8:25 AM

#

It does make sense if you follow the logic 🤷

rapid swallow Feb 13, 2021, 8:25 AM

#

git blame someone

green oriole Feb 13, 2021, 8:25 AM

#

That's an interesting problem though

#

I'd say move the logic out of the converter to an util

cold island Feb 13, 2021, 8:26 AM

#

fix is right though...

#

neither DurationDelta nor Duration need to be classes

green oriole Feb 13, 2021, 8:28 AM

#

Well, we use them as d.py converter, so we have to put them in a class, right ?

celest charm Feb 13, 2021, 8:28 AM

#

@cold island @green oriole This is how I would do it if backwards compatibility should be preserved https://paste.pythondiscord.com/usuhunewev.py

celest charm Feb 13, 2021, 8:28 AM

#

green oriole Well, we use them as d.py converter, so we have to put them in a class, right ?

no

#

https://discordpy.readthedocs.io/en/latest/ext/commands/commands.html#converters

#

It can be a simple callable

#

(i.e. a function)

cold island Feb 13, 2021, 8:28 AM

#

yes, if you scroll up you'll see allowed_string

green oriole Feb 13, 2021, 8:28 AM

#

Let's make it a function then, there's no point in having a class

#

Well, apart from the subclass, but we can work around that

cold island Feb 13, 2021, 8:29 AM

#

yeah, it's just going to massively clutter the PR

green oriole Feb 13, 2021, 8:29 AM

#

celest charm <@!512354988157173763> <@!407110650217627658> This is how I would do it if back...

That's a good solution IMO ~~apart from the PEP8 breaking constant name~~

celest charm Feb 13, 2021, 8:30 AM

#

green oriole Well, apart from the subclass, but we can work around that

Read the hastebin snippet above ^

green oriole Feb 13, 2021, 8:30 AM

#

cold island yeah, it's just going to massively clutter the PR

I don't think that should stop us from making the needed changes

celest charm Feb 13, 2021, 8:30 AM

#

celest charm <@!512354988157173763> <@!407110650217627658> This is how I would do it if back...

This is how I would do it with just functions (backwards compatibility broken) https://paste.pythondiscord.com/isocedahad.py

vocal wolf Feb 13, 2021, 8:31 AM

#

short snow <@!196664644113268736> https://discord.com/channels/267624335836053506/267659945...

Fixed.

https://github.com/python-discord/bot/pull/1419

cold island Feb 13, 2021, 8:31 AM

#

celest charm This is how I would do it with just functions (backwards compatibility broken) h...

Can it be used in a union?

celest charm Feb 13, 2021, 8:32 AM

#

hmmmmmmmmmmmm

#

Not sure, can you try?

#

Putting a function in a Union is certainly a brutal hack

green oriole Feb 13, 2021, 8:32 AM

#

I don't see why not though

celest charm Feb 13, 2021, 8:32 AM

#

because it's not a type

vocal wolf Feb 13, 2021, 8:32 AM

#

@green oriole my god I didn't L I N T

celest charm Feb 13, 2021, 8:33 AM

#

and it's abuse of typehints

green oriole Feb 13, 2021, 8:33 AM

#

vocal wolf <@!407110650217627658> my god I didn't `L I N T`

Bad developer smh

vocal wolf Feb 13, 2021, 8:33 AM

#

not again lmfao

green oriole Feb 13, 2021, 8:33 AM

#

Haha

cold island Feb 13, 2021, 8:33 AM

#

That makes me want to go with option b

#

I think I'll go with b

vocal wolf Feb 13, 2021, 8:34 AM

#

@green oriole bing bam pow

green oriole Feb 13, 2021, 8:35 AM

#

Very good

celest charm Feb 13, 2021, 8:35 AM

#

I guess you could do something like

def to_class_converter(converter: Callable[[str], T]) -> Type[Converter]:
    class _Converter(Converter):
        async def convert(ctx, arg: str):
            return converter(arg)
    return _Converter

but it's #esoteric-python

IMO the converter interface is object-orientation abuse (which I already said). It uses classes that should really be functions.

vocal wolf Feb 13, 2021, 8:35 AM

#

@green oriole does it even need another review?

green oriole Feb 13, 2021, 8:35 AM

#

🤷

vocal wolf Feb 13, 2021, 8:35 AM

#

alright, merging

#

done

#

📎 unknown.png

#

hyperlemon

green oriole Feb 13, 2021, 8:37 AM

#

Damn, increased coverage

vocal wolf Feb 13, 2021, 8:37 AM

#

merged before the bot could even react

green oriole Feb 13, 2021, 8:37 AM

#

That's so silly haha

vocal wolf Feb 13, 2021, 8:37 AM

#

fastest PR in the west

#

@obsidian patio thank you for finding the edge case of the PyPi command. It has been resolved.

short snow Feb 13, 2021, 8:59 AM

#

vocal wolf Fixed. <https://github.com/python-discord/bot/pull/1419>

one minute lemme have a look

vocal wolf Feb 13, 2021, 9:00 AM

#

already merged

obsidian patio Feb 13, 2021, 9:01 AM

#

vocal wolf <@!572303014346489866> thank you for finding the edge case of the PyPi command. ...

Not sure what I found, but happy to help hahah

#

Aaah, I see it now, if we’re thinking of the same thing

#

@green oriole @vocal wolf what’s the current state of the #779073065560703007? Any plans?

vocal wolf Feb 13, 2021, 9:04 AM

#

Me and Ak are planning to discuss it sometime to see what we can do with it

obsidian patio Feb 13, 2021, 9:11 AM

#

Alright, sounds good

gritty bolt Feb 13, 2021, 9:34 AM

#

For sir lancebot, is it possible for the help parameters of commands.command to display a variable list?

#

I have a dictionary and its keys are the arguments of the command

#

So I would like to display that to the user

#

Is it possible to somehow put the dictionary into the help text or do I have to do that manually?

wise oriole Feb 13, 2021, 9:42 AM

#

I entered the command .bemyvalentine in a wrong way and still there is a 30 min cooldown. can you make cooldown such that its only applied if the command worked successfully.

#sir-lancebot-playground message
I did this, and they gave 30 min cooldown. (command didnt execute correctly cause of user's mistake -> still a cooldown). was it intended to work this way?

short snow Feb 13, 2021, 9:46 AM

#

gritty bolt For sir lancebot, is it possible for the `help` parameters of `commands.command`...

yeah, it is just used like a normal variable

#

which has a string assigned to it

gritty bolt Feb 13, 2021, 9:46 AM

#

Example?

short snow Feb 13, 2021, 9:50 AM

#

Can u give an example of how u want it?

#

Like do the “can” part and i will see if that is right or wrong.

gritty bolt Feb 13, 2021, 9:57 AM

#

"""
            The rhyme scheme is made from characters separated by slashes. E.g "abab/cdcd/efef/gg". The slashes denote a new stanza, i.e, they create a new line. Same characters mean that the lines rhyme. Note that the characters are case sensitive! For example, a and A represent two different rhyme schemes.

            You may also use our existing rhyme scheme templates:
                + shakespearean-sonnet
                + couplets
                + ...
            """

#

I currently have the list at the bottom manually typed in

short snow Feb 13, 2021, 9:57 AM

#

@green oriole @gritty wind @eternal owl sorry for the ping but can sir-lancebot#575 be reviewed as soon as possible as the valentine has only 15 days left

dusky shoreBOT Feb 13, 2021, 9:57 AM

#

GitHub

PROpen [sir-lancebot] #575 Fixes Valentine Commands Bug.

gritty bolt Feb 13, 2021, 9:57 AM

#

    templates: Dict[str, str] = {
        "shakespearean-sonnet": "abab/cdcd/efef/gg"
    }

#

This is what the dictionary look like

eternal owl Feb 13, 2021, 9:59 AM

#

I just gave my final exam, I will review it tonight for sure @short snow

short snow Feb 13, 2021, 10:00 AM

#

gritty bolt ```python """ The rhyme scheme is made from characters separated by ...

Ok, so this is about the help paramater for commands.command and not the doctstring for a function.

You can do it like this:

green oriole Feb 13, 2021, 10:01 AM

#

!remind 2h30M review 575

stable mountainBOT Feb 13, 2021, 10:01 AM

#

Can do!

Your reminder will arrive in 2 hours and 30 minutes!

short snow Feb 13, 2021, 10:01 AM

#

@commands.command(
  help=f"""
      ...
      {''.join(x for x in x)}
      ...
      """
  aliases=("poem",)
)
async def love_poem():
  ,,,

gritty bolt Feb 13, 2021, 10:02 AM

#

Ah I see, alright

short snow Feb 13, 2021, 10:03 AM

#

eternal owl I just gave my final exam, I will review it tonight for sure <@73623457874588468...

Np! Hope they went well lemon_pleased

vale ibex Feb 13, 2021, 10:23 AM

#

vocal wolf <@!347272409151438858> are you ChrisLovering on GitHub?

You rang?

vocal wolf Feb 13, 2021, 10:24 AM

#

I did, we're good tho

#

pypi command was merged

#

and now is up and running

#

All conversations were resolved in the end

vale ibex Feb 13, 2021, 10:25 AM

#

🎉

vocal wolf Feb 13, 2021, 10:25 AM

#

!source pypi

stable mountainBOT Feb 13, 2021, 10:25 AM

#

Command: pypi

Provide information about a specific package from PyPI.

Source Code

Go to GitHub

vocal wolf Feb 13, 2021, 10:26 AM

#

here's the final product

vale ibex Feb 13, 2021, 10:26 AM

#

Ooo fancy itertools.cycle

vocal wolf Feb 13, 2021, 10:28 AM

#

ye lol

cold island Feb 13, 2021, 10:40 AM

#

well this is kind of annoying. I want to use the Duration converter which returns a datetime, but when I want to use a method of datetime on the result it complains that the variable is of type Duration.

celest charm Feb 13, 2021, 10:41 AM

#

Maybe putting converters in annotations wasn't the best idea ahem

#

Is it possible to use Annotated?

exotic ember Feb 13, 2021, 10:42 AM

#

cold island well this is kind of annoying. I want to use the Duration converter which return...

what does the code look like? I don't understand why it happens

celest charm Feb 13, 2021, 10:42 AM

#

exotic ember what does the code look like? I don't understand why it happens

# MyConverter converts to an int

def foo(bar: MyConverter):
    print(42 + bar) # error; bar is a MyConverter, can't add to an int!

cold island Feb 13, 2021, 10:43 AM

#

def bla(duration: Duration):
  print(duration.isoformat())

#

isoformat belongs to datetime, but duration is of type Duration as far as Pycharm is concerned

celest charm Feb 13, 2021, 10:43 AM

#

That's why

#

!pep 593

stable mountainBOT Feb 13, 2021, 10:44 AM

#

**PEP 593 - Flexible function and variable annotations**

Link

Status

Accepted

Python-Version

3.9

Created

26-Apr-2019

Type

Standards Track

celest charm Feb 13, 2021, 10:44 AM

#

exists, but bot is not on 3.9 yet (right?), and AFAICT discord.py doesn't support it

vale ibex Feb 13, 2021, 10:44 AM

#

Isn't this the converters.Duration converter?

cold island Feb 13, 2021, 10:44 AM

#

yes

vale ibex Feb 13, 2021, 10:45 AM

#

I've seen it used exactly like that in the reminder command

#

!src remind

stable mountainBOT Feb 13, 2021, 10:45 AM

#

Command: remind

Commands for managing your reminders.

Source Code

Go to GitHub

celest charm Feb 13, 2021, 10:45 AM

#

Well, it works, it's just that the type checker can't tell that it's right

vale ibex Feb 13, 2021, 10:45 AM

#

Ahhh

celest charm Feb 13, 2021, 10:45 AM

#

because it's type annotation abuse

cold island Feb 13, 2021, 10:46 AM

#

yeah it's just annoying to not have the auto complete and see the yellow highlight

green oriole Feb 13, 2021, 10:47 AM

#

You can typehint it again I guess

#

duration: datetime at the top of the function body

celest charm Feb 13, 2021, 10:48 AM

#

Maybe you could do something like

from typing import TYPE_CHECKING

if TYPE_CHECKING:
    Duration = datetime # or whatever type it converts to
else:
    class Duration:
        ...

#

anyway, any solution is probably a hack

#

not sure duration: datetime will work

#

maybe ```py
assert isinstance(duration, datetime)

cold island Feb 13, 2021, 10:49 AM

#

it does work

#

but

#

it's ugly

green oriole Feb 13, 2021, 10:49 AM

#

🤷

#

You can keep it during development and get rid of it when committing

celest charm Feb 13, 2021, 10:52 AM

#

@cold island You could make a datetime wrapper that would also inherit from Converter and have a convert method, but that's worse

green oriole Feb 13, 2021, 10:52 AM

#

celest charm Maybe you could do something like ```py from typing import TYPE_CHECKING if TYP...

Could we do that directly in the converter file? That could be a good solution

celest charm Feb 13, 2021, 10:54 AM

#

IMO using annotations like this is abuse of notation, with the obvious downsides that
a) type checkers will not understand WTF you're doing, which renders our thoroughly typehinted codebase much less typesafe
b) if you want to make a union converter or an optional converter, you have to use class-based converters
c) will it work with delayed evaluation of annotations? (which is default since 3.10)

vocal wolf Feb 13, 2021, 10:57 AM

#

lmfao

celest charm Feb 13, 2021, 10:59 AM

#

!pypi aiohttp?sql=drop+table+students&

stable mountainBOT Feb 13, 2021, 10:59 AM

#

NEGATORY.

There was an error when fetching your PyPi package.

celest charm Feb 13, 2021, 11:00 AM

#

@vocal wolf ^^^

#

arrrgh

vocal wolf Feb 13, 2021, 11:00 AM

#

tis a shame

celest charm Feb 13, 2021, 11:00 AM

#

@vocal wolf Don't substitute URLs with format. It's almost as bad as formatting SQL with f-strings.

#

You should use facilities built into aiohttp.

vocal wolf Feb 13, 2021, 11:01 AM

#

don't we format urls through format a lot throughout the bot?

celest charm Feb 13, 2021, 11:01 AM

#

maybe we do, we probably shouldn't

#

Especially in places we pass some token and such

vocal wolf Feb 13, 2021, 11:02 AM

#

We don't pass a token for this one

celest charm Feb 13, 2021, 11:02 AM

#

URL = "https://pypi.org/pypi/{package}/json"

^ aiohttp?sql=drop+table+students& gets substituted here, and we get

https://pypi.org/pypi/aiohttp?sql=drop+table+students&/json

celest charm Feb 13, 2021, 11:03 AM

#

vocal wolf We don't pass a token for this one

Sure. But people are going to look at the code base and look at how dynamic URLs should be generated, and they'll see format.

vocal wolf Feb 13, 2021, 11:03 AM

#

How should we do it?

celest charm Feb 13, 2021, 11:03 AM

#

Here I don't think aiohttp will help, you should just check that the name only contains a-zA-Z0-9 or _-

#

otherwise, say that it's not a valid package name

vale ibex Feb 13, 2021, 11:07 AM

#

Is this worth an issue to remove all instances?

celest charm Feb 13, 2021, 11:08 AM

#

Well, it's not always evil. It's only evil with unchecked user input

vocal wolf Feb 13, 2021, 11:09 AM

#

Now that you told me about it, I'll keep it in mind for as long as I can remember.

celest charm Feb 13, 2021, 11:09 AM

#

for example, it's fine to use it in python-news, because it's only substituted internally

vocal wolf Feb 13, 2021, 11:09 AM

#

I feel like it is a good idea

celest charm Feb 13, 2021, 11:09 AM

#

Maybe we should make some tag or something about it? I have seen it a couple of times

#

e.g. in super's youtube command

vocal wolf Feb 13, 2021, 11:10 AM

#

What would the regex be? Something like [a-Z0-9_-]*?

celest charm Feb 13, 2021, 11:11 AM

#

[-_a-zA-Z0-9]+

vocal wolf Feb 13, 2021, 11:11 AM

#

Is a-Z equivalent to a-zA-Z or am I just imagining that it exists?

vale ibex Feb 13, 2021, 11:11 AM

#

I think . can be in pypi names too

#

So maybe something like [\.\-_a-zA-Z0-9]+?

vocal wolf Feb 13, 2021, 11:12 AM

#

discord.py

celest charm Feb 13, 2021, 11:12 AM

#

yeah

#

[-._a-zA-Z0-9]+

#

no need for \

celest charm Feb 13, 2021, 11:12 AM

#

vocal wolf Is `a-Z` equivalent to `a-zA-Z` or am I just imagining that it exists?

a-Z means "all characters between a and Z", but Z comes before a, so it's empty.

vocal wolf Feb 13, 2021, 11:12 AM

#

ah

celest charm Feb 13, 2021, 11:12 AM

#

you could do A-z, but that's confusing.

vale ibex Feb 13, 2021, 11:12 AM

#

isn't ._ a special pattern?

vocal wolf Feb 13, 2021, 11:12 AM

#

thank you for information

celest charm Feb 13, 2021, 11:13 AM

#

vale ibex isn't ._ a special pattern?

. is special, but not in [ ]

#

!e

import re
print(re.match("[-._a-zA-Z0-9]+", "context_manager-patma.py"))

stable mountainBOT Feb 13, 2021, 11:13 AM

#

@celest charm :white_check_mark: Your eval job has completed with return code 0.

<re.Match object; span=(0, 24), match='context_manager-patma.py'>

celest charm Feb 13, 2021, 11:15 AM

#

I haven't found any other occurences of URL&format.

vocal wolf Feb 13, 2021, 11:17 AM

#

I'll do a pr

short snow Feb 13, 2021, 11:22 AM

#

@vocal wolf you can do this for the commands that are using a similar thing

#

cht.sh is one of them

celest charm Feb 13, 2021, 11:22 AM

#

short snow cht.sh is one of them

is it in lancebot?

short snow Feb 13, 2021, 11:22 AM

#

yes

celest charm Feb 13, 2021, 11:28 AM

#

well, I don't know if it's actually that critical if it's known to be impossible to abuse for a given service

#

also, maybe this could be refactored to use aiohttp's built-in formatting

📎 unknown.png

vocal wolf Feb 13, 2021, 11:31 AM

#

which cog is that for?

celest charm Feb 13, 2021, 11:31 AM

#

wolfram

#

but that's just a refactoring

#

(here it's actually secure)

vocal wolf Feb 13, 2021, 11:52 AM

#

@celest charm thank you for noticing this and all, I'll do a thing once I wake

celest charm Feb 13, 2021, 11:53 AM

#

👍

short snow Feb 13, 2021, 12:12 PM

#

#bot-commands message @vocal wolf we should send the help command or the error handler user input error here

late wolf Feb 13, 2021, 12:17 PM

#

We do send help command

#

the person just clicked on trash icon

short snow Feb 13, 2021, 12:19 PM

#

ah

#

my bad

#

sorry xith

gritty bolt Feb 13, 2021, 12:23 PM

#

For sir lancebot doc string conventions, must each line use most of the 80 characters for each line?

#

Right now I am using about 75% of the 80 characters for each line just so that they line up nicely in my text editor

#

But if using most of the 80 characters is preferred, then I can change that

vale ibex Feb 13, 2021, 12:24 PM

#

Max line length in sir lancebot is 120, rather than 80

gritty bolt Feb 13, 2021, 12:24 PM

#

I meant for doc strings

vale ibex Feb 13, 2021, 12:24 PM

#

Ah, well the max is just a max, rather than a target

#

So if your doc strings get the point across in less that 80, then that's fine

#

I wouldn't try to add words just to reach the 80 limit

gritty bolt Feb 13, 2021, 12:26 PM

#

For example

    """
    A decorator to access and cache rhyme sets.

    If the rhyme set of the word already exists in the cache, then
    there is no need to execute `func` because results can be taken from the
    cache. Otherwise, execute `func` and store the results into the cache.
    """

#

I hit enter after about 75% of the 80 characters limit

vale ibex Feb 13, 2021, 12:26 PM

#

ohhh, multi-line blocks like that

gritty bolt Feb 13, 2021, 12:26 PM

#

Yep

vale ibex Feb 13, 2021, 12:29 PM

#

Then yea, looking at other doc strings, it looks like just try to get them up to the limit

#

your 75% thing looks fine

#

also, I'm still pretty sure the line limit is 120, rather than 80

gritty bolt Feb 13, 2021, 12:29 PM

#

I thought python conventions is 79 characters max?

gritty wind Feb 13, 2021, 12:29 PM

#

Be careful of short broken up strings or

vale ibex Feb 13, 2021, 12:29 PM

#

Checkout tox.ini in the root

gritty bolt Feb 13, 2021, 12:29 PM

#

What do you mean by short broken up strings?

gritty wind Feb 13, 2021, 12:29 PM

#

you get

#

!help eval

stable mountainBOT Feb 13, 2021, 12:29 PM

#

Command Help

!eval [code]
Can also use: e

*Run Python code and get the results.

This command supports multiple lines of code, including code wrapped inside a formatted code
block. Code can be re-evaluated by editing the original message within 10 seconds and
clicking the reaction that subsequently appears.

We've done our best to make this sandboxed, but do let us know if you manage to find an
issue with it!*

vocal wolf Feb 13, 2021, 12:29 PM

#

short snow sorry xith

np

vale ibex Feb 13, 2021, 12:30 PM

#

gritty wind !help eval

Wasn't there a PR to deal with this?

gritty wind Feb 13, 2021, 12:30 PM

#

Yes, and it's still open

vale ibex Feb 13, 2021, 12:30 PM

#

Ahh

gritty wind Feb 13, 2021, 12:30 PM

#

bot#1285

dusky shoreBOT Feb 13, 2021, 12:30 PM

#

GitHub

PROpen [bot] #1285 Formats Per-Command Help Output

gritty wind Feb 13, 2021, 12:30 PM

#

It's stalled right now due to a lack of ideas

#

If you have any, feel free to share

#

But even if it does get implemented, it still needs to be ported

green oriole Feb 13, 2021, 12:31 PM

#

We should remove single line breaks, and keep consecutive line breaks IMO

gritty wind Feb 13, 2021, 12:31 PM

#

So your best bet is to test out if it looks good

green oriole Feb 13, 2021, 12:31 PM

#

Not sure what is the proposed solution in the PR

gritty wind Feb 13, 2021, 12:31 PM

#

Iirc that's what the PR does

green oriole Feb 13, 2021, 12:31 PM

#

Sweet

vale ibex Feb 13, 2021, 12:31 PM

#

can we just not replace all \n with nothing, and s-

#

nvm

gritty wind Feb 13, 2021, 12:31 PM

#

It actually does
re.sub("(?<!\n)\n(?!\n)", " ", command.help)

vale ibex Feb 13, 2021, 12:31 PM

#

I read the chat, and seems like that's what its doing 😛

gritty wind Feb 13, 2021, 12:31 PM

#

I don't remember what that does

#

Ah it removes multiline so it's a single line

#

and then discord breaks it up

#

That's a positive lookahead and behind

green oriole Feb 13, 2021, 12:32 PM

#

!remind 1h Learn how to calculate time deltas you dummy, and actually review 575 this time

stable mountainBOT Feb 13, 2021, 12:32 PM

#

Can do!

Your reminder will arrive in 1 hour!

gritty bolt Feb 13, 2021, 12:51 PM

#

Is it okay to use a the LinePaginator as my embed?

#

There may be times where the user might generate a really large poem where a LinePaginator is necessary

#

However, there also may be times where it isn't if the poem is short

#

Is it okay to use the LinePaginator at all times?

gritty wind Feb 13, 2021, 12:52 PM

#

The paginator just sends a single embed if it can

#

I think it should be fine

gritty bolt Feb 13, 2021, 12:58 PM

#

For some reason, the reactions of the line paginator on my test server does not work. They reactions count increases by one but it does not do anything to the line paginator

gritty wind Feb 13, 2021, 12:59 PM

#

Do you see anything relevant in the logs?

gritty bolt Feb 13, 2021, 1:00 PM

#

Nothing

gritty wind Feb 13, 2021, 1:01 PM

#

Hmm are the changes pushed to github yet?

gritty bolt Feb 13, 2021, 1:01 PM

#

Not yet, but I can do so now

gritty wind Feb 13, 2021, 1:02 PM

#

I'll test it when you do

vale ibex Feb 13, 2021, 1:05 PM

#

I think I'm going to cancel sir-lancebot#577 and implement sir-lancebot#581 instead

dusky shoreBOT Feb 13, 2021, 1:05 PM

#

GitHub

PROpen [sir-lancebot] #577 First pass of easy to produce errors
IssueOpen [sir-lancebot] #581 Block commands from working in DMs

cold island Feb 13, 2021, 1:08 PM

#

Is there an easy way to get the bot's member object?

gritty wind Feb 13, 2021, 1:08 PM

#

self.bot.user

cold island Feb 13, 2021, 1:08 PM

#

👌

gritty wind Feb 13, 2021, 1:08 PM

#

but to get the member object I think you have to filter the guild

balmy sparrow Feb 13, 2021, 1:19 PM

#

Yep, bot.user gives you a ClientUser object

stable mountainBOT Feb 13, 2021, 1:32 PM

#

@green oriole

It has arrived!

Here's your reminder: Learn how to calculate time deltas you dummy, and actually review 575 this time.
[Jump back to when you created the reminder](#dev-contrib message)

gritty bolt Feb 13, 2021, 1:39 PM

#

gritty wind I'll test it when you do

I have just pushed the changes

#

Forgot to link: https://github.com/python-discord/sir-lancebot/pull/558

GitHub

Markov poem gen by melodicht · Pull Request #558 · python-discord/s...

Relevant Issues

Closes #127, and responds to #97
Description

Based on the original closed PR, this current version also uses the Markov model to give the user a valentines-themed poem. This time...

gritty wind Feb 13, 2021, 1:47 PM

#

No worries, and I think your lock file may be out of date

#

Running pipenv install should fix it though

#

Hmm what input are you using to get a long output?

gritty bolt Feb 13, 2021, 1:51 PM

#

gritty wind Hmm what input are you using to get a long output?

.poem onceuponatimetherewasanuglybarnacle,hewassouglyeveryonediedtheend

#

I was testing the bot's ability to process long rhyme schemes. I am considering adding a limit to how long a rhyme scheme can be

gritty wind Feb 13, 2021, 1:53 PM

#

Do you see all 5 emojis on the embed?

gritty bolt Feb 13, 2021, 1:53 PM

#

Yep

#

📎 unknown.png

#

I have ran pipenv install, the bug is still there

#

Wait, I tried using the LinePaginator on a shorter long rhyme scheme and it worked

#

It seems like the LinePaginator breaks for very long lines?

#

Wait nevermind, it worked once before breaking again

#

I think I realise what's happening here, it breaks after the poem timeout runs out

#

I have to separate the message sending process from the poem generation process. I will work on that and see if that's the cause

celest charm Feb 13, 2021, 2:32 PM

#

gritty wind It actually does `re.sub("(?<!\n)\n(?!\n)", " ", command.help)`

rrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrr

gritty wind Feb 13, 2021, 2:36 PM

#

Do you have a better solution?

celest charm Feb 13, 2021, 2:37 PM

#

gritty wind Do you have a better solution?

No, I was just hinting to an r-string

gritty wind Feb 13, 2021, 2:37 PM

#

hmm why though lol

celest charm Feb 13, 2021, 2:38 PM

#

gritty wind hmm why though lol

well, newlines are treated by the regex parser as newlines, but it's a bit unexpected

#

r"(?<\n)\n)\n(?!\n)", and you don't have to remember whether it works

#

it's not very important, if it's already there

gritty wind Feb 13, 2021, 2:39 PM

#

Fair enough

sleek steppe Feb 13, 2021, 2:46 PM

#

gritty wind but to get the member object I think you have to filter the guild

What about guild.me

#

!d discord.Guild.me

stable mountainBOT Feb 13, 2021, 2:54 PM

#

`discord.Guild.me`

me```
Similar to [`Client.user`](#discord.Client.user "discord.Client.user") except an instance of [`Member`](#discord.Member "discord.Member"). This is essentially used to get the member version of yourself.

Type [`Member`](#discord.Member "discord.Member")

gritty bolt Feb 13, 2021, 3:03 PM

#

@short snow Yo, I am done with #558 Markov Poem Generator PR

vale ibex Feb 13, 2021, 3:08 PM

#

sir-lancebot#558

dusky shoreBOT Feb 13, 2021, 3:08 PM

#

GitHub

PROpen [sir-lancebot] #558 Markov poem gen

vale ibex Feb 13, 2021, 3:34 PM

#

@green oriole Want me to raise a PR for #ot0-psvm’s-eternal-disapproval message?

#

or issue it first?

green oriole Feb 13, 2021, 3:35 PM

#

You can PR it right away

vale ibex Feb 13, 2021, 3:48 PM

#

sir-lancebot#589 fwiw

dusky shoreBOT Feb 13, 2021, 3:48 PM

#

GitHub

PROpen [sir-lancebot] #589 Reset valentine command cooldown on failure

gritty wind Feb 13, 2021, 3:50 PM

#

I don't know if this is possible, but can that be extended to all commands in the error handler?

vale ibex Feb 13, 2021, 3:51 PM

#

possibly, not sure how reset_cooldown reacts if there isn't a cooldown to be reset

#

so it might mean checking for a cd first

#

but definitely possible

#

but it would still require the command to raise an error, atm it just returns so no error

#

Yea, looks like reset_cooldown is safe even if there's no cooldown

#

So we could just remove the if and just always reset the cd

#

i guess the question would be, is there a case where a command raises an error and we don't want to reset the CD?

clever wraith Feb 13, 2021, 5:38 PM

#

is there a template server i can use for sir lancbot?

#

@gritty wind

vale ibex Feb 13, 2021, 5:39 PM

#

The template for the other bot will work for sirlancebot too

clever wraith Feb 13, 2021, 5:39 PM

#

vale ibex The template for the other bot will work for sirlancebot too

oooh

#

ok

vale ibex Feb 13, 2021, 5:39 PM

#

it'll just have more than what's needed

clever wraith Feb 13, 2021, 5:39 PM

#

link?

vale ibex Feb 13, 2021, 5:40 PM

#

https://pythondiscord.com/pages/contributing/bot/#test-server-and-bot-account

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

The last part of that

#

You'll need to set these env vars ```
BOT_TOKEN=
BOT_GUILD=

REDIS_HOST=redis
BOT_DEBUG=true
PREFIX=

AOC_ROLE_ID=
BOT_ADMIN_ROLE_ID=
LOVEFEST_ROLE_ID=
ROLE_HELPERS=

AOC_CHANNEL_ID=
AOC_COMMANDS_CHANNEL_ID=
CHANNEL_ANNOUNCEMENTS=
CHANNEL_COMMUNITY_BOT_COMMANDS=
CHANNEL_DEVLOG=

clever wraith Feb 13, 2021, 5:41 PM

#

vale ibex You'll need to set these env vars ``` BOT_TOKEN= BOT_GUILD= REDIS_HOST=redis BO...

wha?

#

ok

vale ibex Feb 13, 2021, 5:41 PM

#

That's my .env file for sir-lancebot

#

with the values taken out

clever wraith Feb 13, 2021, 5:41 PM

#

👍

vale ibex Feb 13, 2021, 5:42 PM

#

This is the full list https://pythondiscord.com/pages/contributing/sir-lancebot/sir-lancebot-env-var-reference/

Python Discord | Sir Lancebot Environment Variable Reference

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

Some cogs require extra API tokens to work

#

If they aren't present, the cog just won't load

gritty wind Feb 13, 2021, 5:42 PM

#

To start the bot up, you only need the first table Core, everything else can be added as needed for features

#

Some of the debug variables will also be really useful in general

clever wraith Feb 13, 2021, 6:22 PM

#

gritty wind To start the bot up, you only need the first table `Core`, everything else can b...

👍

#

why am I getting this error when I do pipenv run start?

https://paste.pythondiscord.com/zadojuzule.sql

gritty wind Feb 13, 2021, 6:28 PM

#

It means you don't have Redis setup and running

clever wraith Feb 13, 2021, 6:28 PM

#

redis>

gritty wind Feb 13, 2021, 6:28 PM

#

Are you using the docker container?

clever wraith Feb 13, 2021, 6:28 PM

#

gritty wind Are you using the docker container?

no

#

docker takes too much space on my computer

#

which is why i don't prefer

gritty wind Feb 13, 2021, 6:28 PM

#

Alright, you can use fake redis

#

Is this @stable mountain or @dusky shore

final bane Feb 13, 2021, 6:29 PM

#

Oie gamers chatos do caramba

gritty wind Feb 13, 2021, 6:29 PM

#

Yeah that's fine, I only use it for DBs personally

clever wraith Feb 13, 2021, 6:29 PM

#

gritty wind Is this <@!409107086526644234> or <@!528937022996611082>

@dusky shore

gritty wind Feb 13, 2021, 6:29 PM

#

Alright, set
USE_FAKEREDIS to true in your env file

clever wraith Feb 13, 2021, 6:30 PM

#

gritty wind Alright, set `USE_FAKEREDIS` to true in your env file

should 'true' be captial?

gritty wind Feb 13, 2021, 6:30 PM

#

it doesn't matter

clever wraith Feb 13, 2021, 6:56 PM

#

why is lint flake8 failing?

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

gritty wind Feb 13, 2021, 6:57 PM

#

Is there any more text with that?

clever wraith Feb 13, 2021, 6:57 PM

#

hold on

#

Flake8...................................................................Failed

hook id: flake8
exit code: 1

Loading .env environment variables...
bot/exts/evergreen/xkcd.py:73:18: E225 missing whitespace around operator

gritty wind Feb 13, 2021, 6:58 PM

#

So on line 73 of file xkcd.py, you are missing a whitespace

#

probably something like
x=2
instead of x = 2

clever wraith Feb 13, 2021, 6:58 PM

#

ah

#

@gritty wind i don't get this part of the PR form:

Reasoning

what does it mean?

gritty wind Feb 13, 2021, 7:08 PM

#

So why did you choose the solution you did

#

Why did you do A instead of B

#

Let me find a good example

clever wraith Feb 13, 2021, 7:11 PM

#

ok

gritty wind Feb 13, 2021, 7:11 PM

#

Hmm looks like most people ignore it

#

If you link the feature you're working on, I may be able to help you write it

clever wraith Feb 13, 2021, 7:11 PM

#

https://github.com/python-discord/sir-lancebot/issues/588

GitHub

Improve xkcd command · Issue #588 · python-discord/sir-lancebot

Description The current xkcd command doesn’t have the description, or a link to the comic. Reasoning It would help provide more info about the comic. Proposed Implementation Use the ‘alt’ key in th...

gritty wind Feb 13, 2021, 7:12 PM

#

Alright, so I'm assuming you just added a field in the embed that contains the alt from the request

clever wraith Feb 13, 2021, 7:12 PM

#

gritty wind Alright, so I'm assuming you just added a field in the embed that contains the `...

yes, and link to the url

gritty wind Feb 13, 2021, 7:13 PM

#

Your reasoning may be

The `alt` key from the request was already available, and could be safely added to the embed. The URL was also available```

#

It's just a brief description of the way you've implemented the feature

clever wraith Feb 13, 2021, 7:15 PM

#

Ah

#

@gritty wind made a PR for xkcd command

gritty wind Feb 13, 2021, 7:24 PM

#

Coolio, now all that remains is someone to review it lol

clever wraith Feb 13, 2021, 7:24 PM

#

yes

vale ibex Feb 13, 2021, 7:29 PM

#

@clever wraith im on mobile so wasn't able to test the changes. Please correct me if what I said wasn't correct.

#

The url /latest just 404s for me

clever wraith Feb 13, 2021, 7:31 PM

#

vale ibex The url /latest just 404s for me

wha?

vale ibex Feb 13, 2021, 7:31 PM

#

https://xkcd.com/latest

#

If the user does.xkcd latest the url seems to be set to that right?

clever wraith Feb 13, 2021, 7:32 PM

#

yup

#

hold on

#

lemme replace with the number instead

vale ibex Feb 13, 2021, 7:33 PM

#

self.latest_comic_info will be the json for the latest comic

clever wraith Feb 13, 2021, 7:33 PM

#

vale ibex `self.latest_comic_info` will be the json for the latest comic

ok

#

but anyway, we make the request, so could I use that?

vale ibex Feb 13, 2021, 7:34 PM

#

Wdym?

clever wraith Feb 13, 2021, 7:35 PM

#

vale ibex Wdym?

like we do self.bot.http_session.get(f"{BASE_URL}/{comic}/info.0.json") as resp:

vale ibex Feb 13, 2021, 7:37 PM

#

Yea, the info var will contain the response as it either gets set to self.latest_comic_info or with the resl from the request

clever wraith Feb 13, 2021, 8:04 PM

#

vale ibex Yea, the info var will contain the response as it either gets set to `self.lates...

ok

cosmic moat Feb 13, 2021, 8:16 PM

#

@short snow I'm going to work on the youtube command later, I'll ping you when I've done so

short snow Feb 13, 2021, 9:28 PM

#

gritty bolt <@!736234578745884682> Yo, I am done with #558 Markov Poem Generator PR

Will have a look. Great!

short snow Feb 13, 2021, 9:28 PM

#

cosmic moat <@!736234578745884682> I'm going to work on the youtube command later, I'll ping...

Sure

#

I got three pings here, where is the third one... hmmmm

#

Got it .

#

Two things: @gritty bolt

Mark the reviews as resolved if they are done.
You have conflict in you pipfile.lock

clever wraith Feb 13, 2021, 9:55 PM

#

would the thing I did for imporving the xkcd command go in #changelog ?

#

@short snow

short snow Feb 13, 2021, 10:05 PM

#

How would i know?

#

it depends on the mods

#

But idts

#

since there was one for xkcd recently

#

@vale ibex can u include a screenshot in your pr?

#

about the change

vale ibex Feb 13, 2021, 10:21 PM

#

which pr?

short snow Feb 13, 2021, 10:22 PM

#

The cooldown on valentine kne

#

one*

vale ibex Feb 13, 2021, 10:23 PM

#

Ah, there's nothing to screenshot on that

#

Its just the user doesn't get a cooldown if the command fails

short snow Feb 13, 2021, 10:23 PM

#

so userinputerror doesn’t send a embed?

vale ibex Feb 13, 2021, 10:23 PM

#

all the user facing stuff is the same

#

It's the same error embed as before

#

its just now their cd gets reset

#

Take a look at bot/bot:67

short snow Feb 13, 2021, 10:27 PM

#

1st message gets send here

📎 FFA68B4C-0CB9-4CF0-953F-DADE15BDA332.jpeg

#

And second here

📎 CF771559-4CCB-487C-A22E-18A8B2F8398A.jpeg

vale ibex Feb 13, 2021, 10:28 PM

#

Where is that second screenshot from?

short snow Feb 13, 2021, 10:28 PM

#

am really tired (4am here) or is it really sending 2 embeds

#

error handler

vale ibex Feb 13, 2021, 10:28 PM

#

where

short snow Feb 13, 2021, 10:28 PM

#

Sirlance/bot/exts/evergreen

#

/errorhandler.py

vale ibex Feb 13, 2021, 10:30 PM

#

🤔

#

That code was getting hit before too, let me investigate

short snow Feb 13, 2021, 10:31 PM

#

https://github.com/python-discord/sir-lancebot/blob/13620a6461a78e43e8b16b9ad35691ff30622332/bot/exts/evergreen/error_handler.py#L64

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

vale ibex Feb 13, 2021, 10:31 PM

#

yea I see it

short snow Feb 13, 2021, 10:31 PM

#

vale ibex That code was getting hit before too, let me investigate

Sure

clever wraith Feb 13, 2021, 10:33 PM

#

short snow since there was one for xkcd recently

hmm?

short snow Feb 13, 2021, 10:34 PM

#

Ah it didn’t

#

idk wait for the mods to reply

vale ibex Feb 13, 2021, 10:40 PM

#

Alright, so it looks like you're right @short snow. I missed the error listener cog we have in that folder. I only saw the error handler in bot/bot

#

After taking a look though, the only thing it adds is the help embed with a short message about their input, which we want anyway for this.

#

I'll add a comment

short snow Feb 13, 2021, 10:43 PM

#

vale ibex After taking a look though, the only thing it adds is the help embed with a shor...

Alrughtyy cool

vale ibex Feb 13, 2021, 10:48 PM

#

short snow Alrughtyy cool

Done 👍

#

Nice spot btw

short snow Feb 13, 2021, 11:01 PM

#

vale ibex Done 👍

Commented

clever wraith Feb 13, 2021, 11:35 PM

#

@short snow how is the idea on making a fun fact command about python?

#

@short snow

vocal wolf Feb 13, 2021, 11:46 PM

#

@clever wraith There's no need to ping anyone multiple times in succession. People will get to you when they can, you need to be patient.

clever wraith Feb 14, 2021, 12:00 AM

#

ok

cosmic moat Feb 14, 2021, 12:09 AM

#

short snow Sure

i'll be working on it soon, should we use the same emojis we are for the reddit command?

short snow Feb 14, 2021, 12:22 AM

#

cosmic moat i'll be working on it soon, should we use the same emojis we are for the reddit ...

Yep.

short snow Feb 14, 2021, 12:23 AM

#

clever wraith <@!736234578745884682> how is the idea on making a fun fact command about python...

Well, i kinda like it iff the facts are of good quality but final decisison is on the triage lead and the other staff

clever wraith Feb 14, 2021, 12:25 AM

#

short snow Well, i kinda like it iff the facts are of good quality but final decisison is o...

ok

gritty bolt Feb 14, 2021, 1:32 AM

#

short snow Two things: <@!171159641416400897> 1. Mark the reviews as resolved if they are ...

I just marked the reviews as resolved. How do I fix the conflict in Pipfile.lock?

brazen charm Feb 14, 2021, 1:38 AM

#

If your pipfile is up to date with master, just relock

cosmic moat Feb 14, 2021, 1:38 AM

#

do we have a server with a downvote emoji?

short snow Feb 14, 2021, 1:39 AM

#

Hmm, idk how to explain this, maybe try googling u will find something

cosmic moat Feb 14, 2021, 1:39 AM

#

If not, I'll add one

#

doesn't look like it

short snow Feb 14, 2021, 1:40 AM

#

cosmic moat do we have a server with a downvote emoji?

We don’t really need down votes

cosmic moat Feb 14, 2021, 1:41 AM

#

for dislikes, no?

short snow Feb 14, 2021, 1:41 AM

#

On yt command

#

Idts

cosmic moat Feb 14, 2021, 1:41 AM

#

short snow Idts

wdym?

short snow Feb 14, 2021, 1:41 AM

#

I never look at dislikes personally

cosmic moat Feb 14, 2021, 1:41 AM

#

short snow I never look at dislikes personally

hmm, alright

short snow Feb 14, 2021, 1:41 AM

#

likes are more important imo

cosmic moat Feb 14, 2021, 1:41 AM

#

should it be upvotes

#

or thumbs up/thumbs down

short snow Feb 14, 2021, 1:42 AM

#

One min, lemme see

#

the ones used in reddit, the grey one

short snow Feb 14, 2021, 1:42 AM

#

cosmic moat should it be <:upvotes:638694108134899714>

This

cosmic moat Feb 14, 2021, 1:43 AM

#

okie

#

Do we have a server for sir lancebot emojis?

gritty bolt Feb 14, 2021, 1:50 AM

#

brazen charm If your pipfile is up to date with master, just relock

With pipenv lock, right?

short snow Feb 14, 2021, 1:52 AM

#

cosmic moat Do we have a server for sir lancebot emojis?

I think so, vested had told me

cosmic moat Feb 14, 2021, 1:52 AM

#

short snow I think so, vested had told me

how could I get invited there?

short snow Feb 14, 2021, 1:52 AM

#

Ask some core dev, even am not in it

cosmic moat Feb 14, 2021, 1:52 AM

#

I see the upvote command is from there, but I'm not sure where there is

brazen charm Feb 14, 2021, 1:52 AM

#

Yes, I usually do it during the merge, so pipfile gets updated to master and your version and then the pipfile.lock gets relocked and overwritten by your version

cosmic moat Feb 14, 2021, 1:52 AM

#

short snow Ask some core dev, even am not in it

ah

short snow Feb 14, 2021, 1:52 AM

#

Ask xith mahbe

#

he is online

cosmic moat Feb 14, 2021, 1:53 AM

#

@vocal wolf do we have a emoji server, and if so, could I be invited?

short snow Feb 14, 2021, 1:53 AM

#

Just reser the pipfile and relock it, this should work imo

cosmic moat Feb 14, 2021, 1:53 AM

#

we probably should have pinged a helper core dev rather than a mod haha, hopefully he doesn't think there is a problem

short snow Feb 14, 2021, 1:54 AM

#

cosmic moat we probably should have pinged a helper core dev rather than a mod haha, hopeful...

Only one with online status.

#

so i thought, he was the best

patent pivot Feb 14, 2021, 1:55 AM

#

lol

#

i was like

#

90% sure we had an invite pinned somewhere

cosmic moat Feb 14, 2021, 1:56 AM

#

short snow Only one with online status.

ah true

cosmic moat Feb 14, 2021, 1:56 AM

#

patent pivot 90% sure we had an invite pinned somewhere

do we?

patent pivot Feb 14, 2021, 1:56 AM

#

not sure

#

will find after i finish this pizza

cosmic moat Feb 14, 2021, 1:57 AM

#

patent pivot will find after i finish this pizza

lol nice

#

and thanks :D

short snow Feb 14, 2021, 1:58 AM

#

Dm me the invite too

gritty bolt Feb 14, 2021, 2:00 AM

#

I did pipenv lock and it still doesn't work, I really don't know what I am doing wrong

#

I have tried searching the issue up, but I only found one blog post and its solution didn't work
https://dev.to/rrees/resolving-git-conflicts-in-pipenv-lockfiles-2g03

DEV Community

Resolving Git conflicts in Pipenv Lockfiles

How to resolve conflicting Git changes to Pipenv Lockfiles quickly

short snow Feb 14, 2021, 2:03 AM

#

short snow Just reser the pipfile and relock it, this should work imo

This works?

patent pivot Feb 14, 2021, 2:03 AM

#

as of now the only users in the emote servers are helpers, so I'd need to check what our policy is on that before sending out invites tot non-staff

gritty wind Feb 14, 2021, 2:03 AM

#

Try running install?

vocal wolf Feb 14, 2021, 2:03 AM

#

Do we have an emoji server?

cosmic moat Feb 14, 2021, 2:04 AM

#

vocal wolf Do we have an emoji server?

I'll send it to you

gritty wind Feb 14, 2021, 2:04 AM

#

If it’s conflicting with master, merge master into your branch first

short snow Feb 14, 2021, 2:04 AM

#

patent pivot as of now the only users in the emote servers are helpers, so I'd need to check ...

According to this, we do

gritty wind Feb 14, 2021, 2:04 AM

#

And make sure you are merging upstream master

patent pivot Feb 14, 2021, 2:04 AM

#

we have 2

#

lol

short snow Feb 14, 2021, 2:04 AM

#

U have more then 50 emojis?

sullen phoenix Feb 14, 2021, 2:04 AM

#

vocal wolf Do we have an emoji server?

pinned in #dev-core

vocal wolf Feb 14, 2021, 2:04 AM

#

oh so it does exist

patent pivot Feb 14, 2021, 2:05 AM

#

ahhhhhh that's where it's pinned

short snow Feb 14, 2021, 2:05 AM

#

Ok i really need sleep now. Bye! It is 7am lemon_grimace

vocal wolf Feb 14, 2021, 2:05 AM

#

short snow Ok i really need sleep now. Bye! It is 7am <:lemon_grimace:754601078561046558>

You're getting my sleep schedule lol

#

gn

gritty bolt Feb 14, 2021, 2:06 AM

#

short snow This works?

By reset, do you mean replacing the pipfile.lock file with master's pipfile.lock and then running pipenv lock?

gritty bolt Feb 14, 2021, 2:08 AM

#

gritty wind If it’s conflicting with master, merge master into your branch first

Yeah, that's what I did, but when I run pipenv lock it brings me back to where I started

gritty wind Feb 14, 2021, 2:08 AM

#

Can you pull master and push without locking?

gritty bolt Feb 14, 2021, 2:09 AM

#

I suppose I could but wouldn't my pipfile be outdated?

gritty wind Feb 14, 2021, 2:09 AM

#

Yeah, I’ll try to run the lock on my end to see what’s up

#

Alternatively you can dump them on pastebin

#

!paste

stable mountainBOT Feb 14, 2021, 2:10 AM

#

Pasting large amounts of code

If your code is too long to fit in a codeblock in discord, you can paste your code here:
https://paste.pydis.com/

After pasting your code, save it by clicking the floppy disk icon in the top right, or by typing ctrl + S. After doing that, the URL should change. Copy the URL and post it here so others can see it.

cosmic moat Feb 14, 2021, 2:10 AM

#

vocal wolf You're getting my sleep schedule lol

that's even later than you most nights lol

#

I'm wondering how they even managed to function so late

vocal wolf Feb 14, 2021, 2:10 AM

#

You have not seen my summer sleep schedule

#

go to bed at 10-11am

#

wake up at 6-8pm

gritty bolt Feb 14, 2021, 2:10 AM

#

gritty wind Yeah, I’ll try to run the lock on my end to see what’s up

I just did it

gritty wind Feb 14, 2021, 2:11 AM

#

Alright, I'll check it out

#

Hmm seems its complaining about unrelated libraries

#

One thing to try would be to completely delete the pipfile and running install again, but that may not work as inteneded

#

another would be to delete it completely, and manually copy it in from the master branch

gritty bolt Feb 14, 2021, 2:20 AM

#

For the second option, just copy it from the master branch and push?

gritty wind Feb 14, 2021, 2:20 AM

#

copy it from the master branch (not through git), install, and push

gritty bolt Feb 14, 2021, 2:23 AM

#

Okay just did it

gritty wind Feb 14, 2021, 2:27 AM

#

Ok if it doesn't work, I regenerated it again on my end

#

And it's showing up different from your branch

#

https://paste.pythondiscord.com/toniyegebo.json

gritty bolt Feb 14, 2021, 2:29 AM

#

So what do I do?

gritty wind Feb 14, 2021, 2:29 AM

#

Did it work?

#

Ah yeah it worked

#

It's flaring up the dependencies you added for some reason, but those should be easy to fix

gritty bolt Feb 14, 2021, 2:31 AM

#

Do I copy your paste and push it?

gritty wind Feb 14, 2021, 2:31 AM

#

Nah mine is the same as yours now

#

https://github.com/python-discord/sir-lancebot/pull/558/conflicts

#

You should see two red paragraphs on this page

#

something like this

📎 unknown.png

#

It's just git(hub) being weird, but you can remove the

<<<<<<< markov-poem-gen
=======
>>>>>>> master

And it'll work

#

same thing for both paragraphs

#

essentially this

📎 unknown.png

#

I'm not sure why it's fucking up though, it normally works

gritty bolt Feb 14, 2021, 2:34 AM

#

gritty wind something like this

Where did you get this?

gritty wind Feb 14, 2021, 2:34 AM

#

gritty wind https://github.com/python-discord/sir-lancebot/pull/558/conflicts

If you go to the PR, at the very bottom where it says conflicts, there should be a resolve button

gritty bolt Feb 14, 2021, 2:35 AM

#

The one in the top right?

📎 unknown.png

gritty wind Feb 14, 2021, 2:35 AM

#

On that page, there is a prev/next button you can use to find the highlighted bits

#

Yeah top right

gritty bolt Feb 14, 2021, 2:35 AM

#

I can't remove the markers though

#

Or do I copy it into my text editor, remove them and re-push?

gritty wind Feb 14, 2021, 2:36 AM

#

Like you can't edit it online at all?

gritty bolt Feb 14, 2021, 2:37 AM

#

Omg, I can, I just never tried it and I thought I couldn't

#

It was that easy...

clever wraith Feb 14, 2021, 2:44 AM

#

short snow Well, i kinda like it iff the facts are of good quality but final decisison is o...

we need some sources

cosmic moat Feb 14, 2021, 5:16 AM

#

How come I am unable to get emojis working in my local server? lol

📎 unknown.png

#

Also, @short snow this is a demo

short snow Feb 14, 2021, 5:16 AM

#

cosmic moat I'm wondering how they even managed to function so late

idk, this was probably my first time, otherwise i sleep at 2am max

gritty wind Feb 14, 2021, 5:16 AM

#

What do you have in your constants?

cosmic moat Feb 14, 2021, 5:16 AM

#

        self.youtube_emoji = self.bot.get_emoji(810358765114622053)
        self.post_detail_emoji = self.bot.get_emoji(810362544287383624)
        self.user_emoji = self.bot.get_emoji(810359435960385536)
        self.view_emoji = self.bot.get_emoji(810371390124458024)
        self.like_emoji = self.bot.get_emoji(810361845353021471)

#

these are just from my bot test servers

short snow Feb 14, 2021, 5:17 AM

#

ah no need of get emojis

#

look how reddit is done

cosmic moat Feb 14, 2021, 5:17 AM

#

short snow look how reddit is done

        upvote_emoji = self.bot.get_emoji(755845219890757644)
        comment_emoji = self.bot.get_emoji(755845255001014384)
        user_emoji = self.bot.get_emoji(755845303822974997)
        text_emoji = self.bot.get_emoji(676030265910493204)
        video_emoji = self.bot.get_emoji(676030265839190047)
        image_emoji = self.bot.get_emoji(676030265734201344)
        reddit_emoji = self.bot.get_emoji(676030265734332427)

#

should I not get it in __init__?

gritty wind Feb 14, 2021, 5:18 AM

#

Honestly these should all be in constants.py 🤔

#

Is your code public yet?

cosmic moat Feb 14, 2021, 5:19 AM

#

gritty wind Is your code public yet?

this version?

gritty wind Feb 14, 2021, 5:19 AM

#

Yesh

cosmic moat Feb 14, 2021, 5:19 AM

#

no, it's still progress

#

once I get these emojis workign it will be

gritty wind Feb 14, 2021, 5:19 AM

#

hmm can you dump it somewhere for testing?

short snow Feb 14, 2021, 5:19 AM

#

hmm, are those the right ids?

#

\<emoji>

gritty wind Feb 14, 2021, 5:20 AM

#

I think you can't use like the emoji object in messages, you just use the name:id

short snow Feb 14, 2021, 5:20 AM

#

so: would become !lemon_hyperpleased

cosmic moat Feb 14, 2021, 5:20 AM

#

got it 🥳

📎 unknown.png

short snow Feb 14, 2021, 5:21 AM

#

awesomeee

cosmic moat Feb 14, 2021, 5:21 AM

#

the problem was getting them in __init__, so I get them on command time, yeah

#

I'll add these to constants

gritty wind Feb 14, 2021, 5:21 AM

#

noice

cosmic moat Feb 14, 2021, 5:21 AM

#

and change the ids to the emoji server ones

gritty wind Feb 14, 2021, 5:21 AM

#

You really just need the IDs to be added to constants

cosmic moat Feb 14, 2021, 5:21 AM

#

then you'll have it

cosmic moat Feb 14, 2021, 5:21 AM

#

gritty wind You really just need the IDs to be added to constants

yeah

short snow Feb 14, 2021, 5:21 AM

#

you forgot to spaces between the emojis ig

cosmic moat Feb 14, 2021, 5:22 AM

#

short snow you forgot to spaces between the emojis ig

It's something we'll have to fix, the emojis are not equally sized

#

I've been doing the emojis with f1re, so we'll fix those after this commit

short snow Feb 14, 2021, 5:22 AM

#

okie dokie

cosmic moat Feb 14, 2021, 5:33 AM

#

@gritty wind @short snow I committed the new changes

#

It's not ready for merge quite yet though -- need to change all of the emoji id's from my test server

short snow Feb 14, 2021, 5:54 AM

#

cosmic moat <@!386599446571384843> <@!736234578745884682> I committed the new changes

will have a look later in the day

cosmic moat Feb 14, 2021, 5:55 AM

#

sounds good

#

It should be good to merge if you guys approve

gritty wind Feb 14, 2021, 6:01 AM

#

Can you re-request a review from the current reviewers to clear out their approvals/denials

cosmic moat Feb 14, 2021, 6:06 AM

#

gritty wind Can you re-request a review from the current reviewers to clear out their approv...

sure

#

er, how do I start a review again?

gritty wind Feb 14, 2021, 6:07 AM

#

If you go to the files changed menu, there is a review button

#

if you want to rerequest a review

#

Do it at the very top of the conversations menu

short snow Feb 14, 2021, 6:08 AM

#

top right corner

gritty wind Feb 14, 2021, 6:08 AM

#

You can also dismiss the reviews by clicking on the cog thing

cosmic moat Feb 14, 2021, 6:10 AM

#

gritty wind If you go to the files changed menu, there is a review button

It seems like I can't rerequest jason's for whatever reason

gritty wind Feb 14, 2021, 6:10 AM

#

Hmm you should be, screenshot?

cosmic moat Feb 14, 2021, 6:10 AM

#

also I've had this just sitting here for a while

📎 unknown.png

gritty wind Feb 14, 2021, 6:10 AM

#

We don't assign on PRs btw -- I learned that the hard way lol

cosmic moat Feb 14, 2021, 6:11 AM

#

won't let me request

📎 unknown.png

cosmic moat Feb 14, 2021, 6:11 AM

#

gritty wind We don't assign on PRs btw -- I learned that the hard way lol

ah, how come?

gritty wind Feb 14, 2021, 6:11 AM

#

What happens when you click on the circle?

gritty wind Feb 14, 2021, 6:11 AM

#

cosmic moat ah, how come?

Idk, it doesn't really signify much that other things don't. It is isn't a big deal though

cosmic moat Feb 14, 2021, 6:11 AM

#

tuns blue and then nothing

gritty wind Feb 14, 2021, 6:12 AM

#

Possibly because he's not part of the org

#

It doesn't influence the review count, so I don't think it should matter

#

But he may be able to rerequest himself

cosmic moat Feb 14, 2021, 6:13 AM

#

ah okay

#

im not even sure what I did just here lol

📎 unknown.png

#

the pr/review process confuses me a bit sometimes on github

#

anyways, I'm going to head off to bed

#

goodnight!

gritty wind Feb 14, 2021, 6:15 AM

#

You left a review comment - neither an approval nor request

#

night night

late wolf Feb 14, 2021, 6:46 AM

#

#sir-lancebot-playground message
Even though !e? was not a command, why was

You are not allowed to use that command here. Please use the #bot-commands channel instead.
message sent?

gritty wind Feb 14, 2021, 6:46 AM

#

!e is a command

#

eval

#

!e print("hello world")

stable mountainBOT Feb 14, 2021, 6:47 AM

#

@gritty wind :white_check_mark: Your eval job has completed with return code 0.

hello world

late wolf Feb 14, 2021, 6:49 AM

#

gritty wind `!e` is a command

but !e? isn't

gritty wind Feb 14, 2021, 6:52 AM

#

Right

#

it's the command suggestion

#

not the actual command

late wolf Feb 14, 2021, 6:52 AM

#

huh?

gritty wind Feb 14, 2021, 6:53 AM

#

Try it in #bot-commands

late wolf Feb 14, 2021, 6:53 AM

#

I get a suggestion

gritty wind Feb 14, 2021, 6:53 AM

#

Yeah, which you are not allowed to get in #sir-lancebot-playground

short snow Feb 14, 2021, 9:05 AM

#

problem with help command

📎 Screenshot_from_2021-02-14_14-35-34.png

#

ah it is the cog problem

#

@gritty bolt Reviewed

gritty bolt Feb 14, 2021, 9:43 AM

#

I merged master to my local repo and now I get this error:

sir-lancebot/bot/exts/evergreen/issues.py", line 182, in on_message
    message.channel.category.id in WHITELISTED_CATEGORIES
AttributeError: 'NoneType' object has no attribute 'id'

#

The bot is functioning for my cog though

exotic ember Feb 14, 2021, 9:46 AM

#

gritty bolt I merged master to my local repo and now I get this error: ```python sir-lancebo...

the command assumes the channel you run the command in is in a category

#

I assume the channel you ran the command in has no category? in that case message.channel.category would return None, therefore there is an access error on the id field

gritty bolt Feb 14, 2021, 9:47 AM

#

by category, you mean like "Development" would be the category of this channel?

exotic ember Feb 14, 2021, 9:48 AM

#

yep

gritty bolt Feb 14, 2021, 9:48 AM

#

@short snow do you really prefer soft red instead of pink for the love poem?

exotic ember Feb 14, 2021, 9:49 AM

#

if it's an error embed, the convention is to use soft red

vale ibex Feb 14, 2021, 9:50 AM

#

Similar thing happens in DMs too, I have a PR open for it somewhere

gritty bolt Feb 14, 2021, 9:50 AM

#

exotic ember if it's an error embed, the convention is to use soft red

Oh I see

gritty bolt Feb 14, 2021, 10:11 AM

#

How do I add a cool down on a command?

gritty wind Feb 14, 2021, 10:12 AM

#

There's a discord.py decorator for it

#

one sec

#

https://github.com/python-discord/sir-lancebot/blob/master/bot/exts/evergreen/cheatsheet.py#L77

GitHub

python-discord/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - python-discord...

gritty bolt Feb 14, 2021, 10:14 AM

#

Thanks. But, how do I use it? What is BucketType.user?

gritty wind Feb 14, 2021, 10:14 AM

#

You can just add it above the command

gritty bolt Feb 14, 2021, 10:14 AM

#

Actually, wait, if it is a discord.py command I could probably search the docs

gritty wind Feb 14, 2021, 10:14 AM

#

The bucket types indicate who the limit applies to, for example user limits it to each individual user using it once per 10 minutes

#

A global bucket would be for all of discord, etc

#

https://discordpy.readthedocs.io/en/latest/ext/commands/api.html#discord.ext.commands.cooldown

gritty bolt Feb 14, 2021, 10:16 AM

#

Awesome, thanks

#

Is it possible to have a cooldown that refreshes after the bot gives what the user requested?

#

For example, in the poem cog, the user can request for another poem only when they get one

#

If I do it in terms of time, then those who requested shorter poems would have to wait long and those who requested very long poems may get a chance to execute the command multiple times

#

Is it max_concurrency?

gritty wind Feb 14, 2021, 10:19 AM

#

I don't know that there's any good bulitin way to handle that

#

Max concurrency will apply to all users across the bot, not really connected to cooldowns

#

I guess what you'd be looking for is a global cache instead

#

we keep some of those for certain features

short snow Feb 14, 2021, 10:20 AM

#

We can do it on our own, after sending the result, we can reset the cooldown ig

gritty bolt Feb 14, 2021, 10:21 AM

#

short snow We can do it on our own, after sending the result, we can reset the cooldown ig

If I do max_concurrency(1, BucketType.user), wouldn't that do just that?

short snow Feb 14, 2021, 10:22 AM

#

Never used it, so idk

gritty wind Feb 14, 2021, 10:23 AM

#

Ah yeah, that sounds good

gritty bolt Feb 14, 2021, 10:26 AM

#

If a user decides to spam the command even though max_concurrency is enabled, will the bot on the server automatically punish the user?

short snow Feb 14, 2021, 10:26 AM

#

If same thing was sent 3 times ig in 10 seconds

#

ks has a pr on that which changes it to 3 ig

#

not sure tho

gritty bolt Feb 14, 2021, 10:27 AM

#

Oh I see

short snow Feb 14, 2021, 10:41 AM

#

@green oriole @gritty wind Just a reminder to review the connect four pr. lemon_pleased

cosmic moat Feb 14, 2021, 2:41 PM

#

@vale ibex About moving the emoji ID locations -- it looks like only the "general" emojis go there, i.e. status, approved, etc.

#

but, the reddit extension's emoji ids are in the module itself, and I cleaned up mine by putting it in a YouTube class in constants.py

#

should it still be added?

vale ibex Feb 14, 2021, 2:44 PM

#

i mean the dice emoji, the tic tac toe emoji the issue and Pr emojis are all in there

#

but yea I agree, the emojis are a little scattered atm

#

So probably not a huge deal.

cosmic moat Feb 14, 2021, 2:46 PM

#

vale ibex i mean the dice emoji, the tic tac toe emoji the issue and Pr emojis are all in ...

it seemed like those were a bit more general maybe?

#

I can definitely add them there though

#

However, it's a little bit of conflict between the reddit command and here, since I do use two of the reddit emojis

#

actually, I'll add the emojis I need there, and then do another issue about moving the reddit emojis, should only take a bit

vale ibex Feb 14, 2021, 2:49 PM

#

Sure! 🙂

cosmic moat Feb 14, 2021, 2:53 PM

#

sounds good!

#

also, how can I use emojis in this format?

    issue = "![IssueOpen](https://cdn.discordapp.com/emojis/629695470327037963.webp?size=128 "IssueOpen")"
    issue_closed = "![IssueClosed](https://cdn.discordapp.com/emojis/629695470570307614.webp?size=128 "IssueClosed")"
    pull_request = "![PROpen](https://cdn.discordapp.com/emojis/629695470175780875.webp?size=128 "PROpen")"
    pull_request_closed = "![PRClosed](https://cdn.discordapp.com/emojis/629695470519713818.webp?size=128 "PRClosed")"
    merge = "![PRMerged](https://cdn.discordapp.com/emojis/629695470570176522.webp?size=128 "PRMerged")"

vale ibex Feb 14, 2021, 2:55 PM

#

those get auto changed into the emoji by discord if they're sent as text

#

Try it

cosmic moat Feb 14, 2021, 2:55 PM

#

ah

vale ibex Feb 14, 2021, 2:55 PM

#

!IssueOpen

#

Copy paste that into disc

cosmic moat Feb 14, 2021, 2:55 PM

#

IssueOpen

#

yep

#

alright, thank you

vale ibex Feb 14, 2021, 2:55 PM

#

👍

#

~~Remember this when the owl coup begins~~

cosmic moat Feb 14, 2021, 2:58 PM

#

vale ibex ~~Remember this when the owl coup begins~~

~~will do~~

#

~~forever loyal~~

#

alright, chages pushed @vale ibex

vale ibex Feb 14, 2021, 3:01 PM

#

:youtube::post_detail::user::view::like:

#

youtube :post_detail: :user: :view: :like:

#

🤔

cosmic moat Feb 14, 2021, 3:03 PM

#

ah

#

wrong server

#

sigh

vale ibex Feb 14, 2021, 3:04 PM

#

They'll need to be the ids from #578587418123304972

#

Flake8 didn't like the new line after the docstring either

#

do you have the precommit hook setup?

cosmic moat Feb 14, 2021, 3:06 PM

#

vale ibex do you have the precommit hook setup?

yes

#

it's passing for me

vale ibex Feb 14, 2021, 3:06 PM

#

weird

#

what about if you do pipenv run lint?

cosmic moat Feb 14, 2021, 3:06 PM

#

all passing

vale ibex Feb 14, 2021, 3:06 PM

#

🤔

cosmic moat Feb 14, 2021, 3:06 PM

#

even flake8 . gives nothing

vale ibex Feb 14, 2021, 3:07 PM

#

Weird

#

PS C:\Users\Chris\src\sir-lancebot> pipenv run lint
Loading .env environment variables...
Check for merge conflicts................................................Passed
Check Toml...............................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Mixed line ending........................................................Passed
Trim Trailing Whitespace.................................................Passed
check blanket noqa.......................................................Passed
Flake8...................................................................Failed
- hook id: flake8
- exit code: 1

Loading .env environment variables...
bot/exts/evergreen/youtube.py:111:1: D202 No blank lines allowed after function docstring

#

Mine fails if I checkout your PR

hardy gorge Feb 14, 2021, 3:10 PM

#

Hmm, this is a message from a flake8 plugin

vale ibex Feb 14, 2021, 3:10 PM

#

Do you think pipenv install is needed?

hardy gorge Feb 14, 2021, 3:10 PM

#

Could you do something like pipenv run flake8 --version?

green oriole Feb 14, 2021, 3:10 PM

#

cosmic moat even `flake8 .` gives nothing

You are probably running the system flake8 here

hardy gorge Feb 14, 2021, 3:10 PM

#

And/run pipenv run flake8 without precommit

#

My guess is that precommit bypasses the venv

#

Falls back to systemwide

cosmic moat Feb 14, 2021, 3:11 PM

#

hardy gorge And/run `pipenv run flake8` without precommit

still nothing

hardy gorge Feb 14, 2021, 3:11 PM

#

And the version?

#

What's the output?

cosmic moat Feb 14, 2021, 3:11 PM

#

3.8.4 (mccabe: 0.6.1, pycodestyle: 2.6.0, pyflakes: 2.2.0) CPython 3.8.5 on Linux

vale ibex Feb 14, 2021, 3:12 PM

#

pipenv sync --dev?

hardy gorge Feb 14, 2021, 3:12 PM

#

So, no plugins installed

#

Try the sync --dev

cosmic moat Feb 14, 2021, 3:13 PM

#

got it :D

#

alright, that change is pushed as well

vale ibex Feb 14, 2021, 3:17 PM

#

youtube reddit_post_text reddit_users youtube_views youtube_like

clever wraith Feb 14, 2021, 3:45 PM

#

I need a couple sourcesfor fun facts about python

#

also, where should I store the text file?

vale ibex Feb 14, 2021, 3:45 PM

#

bot/resources/evergreen

clever wraith Feb 14, 2021, 3:46 PM

#

vale ibex `bot/resources/evergreen`

ah

vale ibex Feb 14, 2021, 3:46 PM

#

As for resources you could open a discussion and ask for some input from the community, or take a look around google

clever wraith Feb 14, 2021, 3:46 PM

#

ok

#

yup

vale ibex Feb 14, 2021, 3:46 PM

#

I'm not aware of any sources with many facts, there might be some out there

clever wraith Feb 14, 2021, 3:47 PM

#

vale ibex I'm not aware of any sources with many facts, there might be some out there

yup

#

i think maybe making a discusson would be best

short snow Feb 14, 2021, 3:47 PM

#

Sorry supermazingcoder, got stuck with exam prep today, will see if i can do a review tomorrow

timid sentinel Feb 14, 2021, 3:48 PM

#

Depending on what sort of thing you're looking for, you could take a look at https://github.com/satwikkansal/wtfpython @clever wraith.

GitHub

satwikkansal/wtfpython

What the f*ck Python? 😱. Contribute to satwikkansal/wtfpython development by creating an account on GitHub.

vale ibex Feb 14, 2021, 3:48 PM

#

Getting a random one from that could be cool

timid sentinel Feb 14, 2021, 3:51 PM

#

You could also have some less programming related ones, like python 1.0 was released in ..., guido van rossum was the original creator of python, he was know as the BDFL which stand for ..., python was voted as the nth most popular language in the stackoverflow survey, etc, etc

short snow Feb 14, 2021, 3:53 PM

#

https://data-flair.training/blogs/facts-about-python-programming/

DataFlair

16 Facts about Python Programming that every Geek should know - Dat...

16 facts about python programming. If you are a geek then you should know this lesser known things about python. Why you need to start learning it now

cosmic moat Feb 14, 2021, 3:53 PM

#

Thank you for the review @cold moon

#

great suggestions

#

I made all of the changes

short snow Feb 14, 2021, 4:05 PM

#

@cosmic moat no frequent pushed (is mentioned in contributing guide)

#

make all commits, and push together at end

cosmic moat Feb 14, 2021, 4:05 PM

#

ah, I was not aware of that

#

I actually didn't know that was a thing

#

what is the difference?

short snow Feb 14, 2021, 4:06 PM

#

difference in?

cosmic moat Feb 14, 2021, 4:07 PM

#

between pushing after everyone commit and at the end of them all

brazen charm Feb 14, 2021, 4:08 PM

#

A push to an open pr will trigger actions, so it's not ideal if you can group them but doesn't matter all that much

short snow Feb 14, 2021, 4:09 PM

#

Can everyone see my new pfp or old pfp on github webhook? Cuz even on ipad it shows the old one

sleek steppe Feb 14, 2021, 4:15 PM

#

it shows the one you have on discord lol

short snow Feb 14, 2021, 4:18 PM

#

Hmmm

#

📎 9045B803-EC90-4612-BAD7-08A23FC9D28E.jpeg

sleek steppe Feb 14, 2021, 4:19 PM

#

interesting

#

📎 unknown.png

short snow Feb 14, 2021, 4:19 PM

#

Lemme try clearing cache

#

Nah, doesn’tnwork 😦

#

Anyway heading of to bed. Gn!

sleek steppe Feb 14, 2021, 4:23 PM

#

Good night

vale ibex Feb 14, 2021, 4:24 PM

#

Good luck with the exam!

short snow Feb 14, 2021, 4:25 PM

#

3 days to go for that. lemon_pleased

vale ibex Feb 14, 2021, 4:27 PM

#

Ahh fair enough 😄

sleek steppe Feb 14, 2021, 4:32 PM

#

Why does await ctx.send_help('command') use commands.DefaultHelpCommand for sir-lancebot?

clever wraith Feb 14, 2021, 4:36 PM

#

timid sentinel Depending on what sort of thing you're looking for, you could take a look at htt...

i don't understand, what is this?

#

it looks like a lesson lemon_thinking

sleek steppe Feb 14, 2021, 4:37 PM

#

sleek steppe Why does `await ctx.send_help('command')` use commands.DefaultHelpCommand for si...

oh it's because @dusky shore bot.help_command is still commands.DefaultHelpCommand

timid sentinel Feb 14, 2021, 4:37 PM

#

clever wraith i don't understand, what *is* this?

It's a collection of individual examples of python (or cpython) behaviour that may seem weird or unexpected

clever wraith Feb 14, 2021, 4:37 PM

#

timid sentinel It's a collection of individual examples of python (or cpython) behaviour that m...

ah

clever wraith Feb 14, 2021, 4:55 PM

#

so how can I get a weird fact from this? lemon_thinking

#

@timid sentinel

timid sentinel Feb 14, 2021, 4:58 PM

#

I meant that more for inspiration, you could try and convert some of the examples into more concise facts

#

You don't have to use that if it isn't the sort of facts you were looking for

clever wraith Feb 14, 2021, 4:59 PM

#

ok

celest charm Feb 14, 2021, 5:19 PM

#

short snow https://data-flair.training/blogs/facts-about-python-programming/

> Lesser known things about Python
>

📎 unknown.png

#

learn something new every day, right

gritty wind Feb 14, 2021, 5:23 PM

#

Tbf it can be a shock to people who have never heard about python, though it is certainly infamous for it

clever wraith Feb 14, 2021, 5:28 PM

#

celest charm learn something new every day, right

:kek:

#

@celest charm however...

📎 unknown.png

obsidian patio Feb 14, 2021, 5:33 PM

#

celest charm \> Lesser known things about Python \>

Wait, really?

clever wraith Feb 14, 2021, 5:56 PM

#

hat;s this error?

📎 unknown.png

#

in uptime.py

celest charm Feb 14, 2021, 6:03 PM

#

obsidian patio Wait, really?

Yeah. Still recovering from the shock!

celest charm Feb 14, 2021, 6:03 PM

#

gritty wind Tbf it can be a shock to people who have never heard about python, though it is ...

just show them lisp dialects

clever wraith Feb 14, 2021, 6:04 PM

#

ok

gritty wind Feb 14, 2021, 6:04 PM

#

Some lisp programmers stand by it 😔

clever wraith Feb 14, 2021, 6:04 PM

#

that import thing tho

#

so funny

vale ibex Feb 14, 2021, 6:11 PM

#

clever wraith hat;s this error?

have you done pipenv sync --dev?

clever wraith Feb 14, 2021, 6:11 PM

#

oh wait not yet

#

should I put an absolute path or a relative one for opening the fle?

#

@vale ibex

vale ibex Feb 14, 2021, 7:19 PM

#

Opening what file?

clever wraith Feb 14, 2021, 7:37 PM

#

the text file

#

how do I make the help command?

vale ibex Feb 14, 2021, 7:45 PM

#

Sorry, I don't have the context here. I thought you were having an issue with arrow?

clever wraith Feb 15, 2021, 1:48 AM

#

vale ibex Sorry, I don't have the context here. I thought you were having an issue with ar...

i finshed that

short snow Feb 15, 2021, 3:32 AM

#

@SuperMaZingCoder#0001 having a look at your pr now

#

@cosmic moat do you have a test server? so that i can join and test it out?

cosmic moat Feb 15, 2021, 4:08 AM

#

@short snow all changes addressed

short snow Feb 15, 2021, 5:39 AM

#

#sir-lancebot-playground message WIkipedia doesn't filter out 18+ content

gritty wind Feb 15, 2021, 5:40 AM

#

I don't think talking about those things is 18+

#

by itself

#

If it had porn on the other hand, that may be a different story

#

but Porn sites, and porn in general is legitimate knowledge

cold moon Feb 15, 2021, 5:42 AM

#

@cosmic moat Cooldown comment should be added to command docstring instead. Also, could you please use bot.bot.Bot instead of commands.Bot in typehints to make IDEs autocomplete and analysis better?

short snow Feb 15, 2021, 12:29 PM

#

should cht.sh be allowed in #python-discussion

gritty wind Feb 15, 2021, 12:29 PM

#

I think it’s too blocky for that

#

We don’t want to flood pygen

short snow Feb 15, 2021, 12:30 PM

#

yeah. thought so

#

maybe we could reduce the truncated amount

short snow Feb 15, 2021, 1:30 PM

#

#sir-lancebot-playground message this pings the user

#

which is not needed

green oriole Feb 15, 2021, 1:37 PM

#

Yes

#

In fact, it should even be in an embed

short snow Feb 15, 2021, 2:00 PM

#

green oriole In fact, it should even be in an embed

should i open a quick pr for that?

#

also you have a requested review on c4 on lance along with scaleios

green oriole Feb 15, 2021, 2:01 PM

#

short snow should i open a quick pr for that?

Yes, sure thing

#

I may not review the connect four PR until this weekend, but it may get merged before then

short snow Feb 15, 2021, 2:02 PM

#

we have many study leaves :D, so i have time for coding

#

got timetable today

cosmic moat Feb 15, 2021, 2:30 PM

#

cold moon <@!523662958916665361> Cooldown comment should be added to command docstring ins...

It is i think

#

https://github.com/SuperMaZingCoder/sir-lancebot/blob/feature/youtube/bot/exts/evergreen/youtube.py#L84

GitHub

SuperMaZingCoder/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - SuperMaZingCod...

#

yeah

short snow Feb 15, 2021, 2:31 PM

#

one approve needed for this and markov poem

#

it would be awesome if you do it on markov

#

since valentine has only 13 days left

cold moon Feb 15, 2021, 2:32 PM

#

cosmic moat It is i think

Command docstring is https://github.com/SuperMaZingCoder/sir-lancebot/blob/feature/youtube/bot/exts/evergreen/youtube.py#L123

GitHub

SuperMaZingCoder/sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development. - SuperMaZingCod...

cosmic moat Feb 15, 2021, 2:32 PM

#

ah I put it in the wrong place

cold moon Feb 15, 2021, 2:33 PM

#

Yes, search_youtube don't have cooldown, command have cooldown

cosmic moat Feb 15, 2021, 2:36 PM

#

cold moon Yes, `search_youtube` don't have cooldown, command have cooldown

fixed

celest charm Feb 15, 2021, 2:50 PM

#

@cosmic moat Why is the logic so complex?

#

Can't you just throw an exception if either the analytcis or the video search doesn't succeed, and catch it at the top level?

#

Besides, under what circumstances would youtube statistics or youtube search return non-200 if youtube is not totally down?

cosmic moat Feb 15, 2021, 2:53 PM

#

well, it just checks for a non 200 return code and logs it with where it's from and the return code

celest charm Feb 15, 2021, 2:53 PM

#

why doesn't it also check if the computer is on fire?

cosmic moat Feb 15, 2021, 2:53 PM

#

LOL

celest charm Feb 15, 2021, 2:54 PM

#

i.e. why does it care about that? and why would it occur?

#

If youtube is down, you might as well get a failed connection, which you don't catch.

cosmic moat Feb 15, 2021, 2:54 PM

#

well, it cares so that we don't flood the console with errors, and because it gives valuable information about the return code.

#

and it could happen if we've hit the daily rate limit

#

if we get a failed connection

#

that's not related to the youtube command

celest charm Feb 15, 2021, 2:56 PM

#

@cosmic moat it is, youtube/google could have screwed up its DNS stuff

cosmic moat Feb 15, 2021, 2:56 PM

#

doubt

celest charm Feb 15, 2021, 2:56 PM

#

well, last year:

google's services were down for a few hours
cloudflare had a royal screwup with DNS
so it's on the same level of probability

#

i.e. once a year

cosmic moat Feb 15, 2021, 2:57 PM

#

ah

#

that wouldn't be catched?

celest charm Feb 15, 2021, 2:57 PM

#

It would be thrown as an exception, and the top-level handler will catch it.

#

So I'd say just leave all the issues to the top-level handler, because doing here otherwise really makes the code hard to read

cosmic moat Feb 15, 2021, 2:58 PM

#

can I just add an exception at the top

#

and keep the rest

#

i like knowing the error code