#dev-contrib | Python | Page 57

patent pivot Jun 25, 2020, 5:23 PM

#

You can't make an inventory for any package

#

We don't make the inventories

green mesa Jun 25, 2020, 5:23 PM

#

Then how py bot does scraping of docs?

brazen charm Jun 25, 2020, 5:24 PM

#

for example python has the inventory on http://docs.python.org/objects.inv, that's downloaded when the bot starts

green mesa Jun 25, 2020, 5:24 PM

#

Oooo

brazen charm Jun 25, 2020, 5:24 PM

#

if coc.py doesn't have that inventory the doc cog can't do anything with it

green mesa Jun 25, 2020, 5:25 PM

#

How can I check that

patent pivot Jun 25, 2020, 5:25 PM

#

https://github.com/python-discord/site/blob/master/pydis_site/apps/api/viewsets/bot/documentation_link.py

GitHub

python-discord/site

pythondiscord.com - A Django and Bulma web application. - python-discord/site

#

all the ones we have stored

📎 Screenshot_2020-06-25_at_18.25.42.png

#

and we can add them with

#

!doc set

stable mountainBOT Jun 25, 2020, 5:26 PM

#

Missing required argument package_name.

#

Command Help

!docs set <package_name> <base_url> <inventory_url>
Can also use: docs s

*Adds a new documentation metadata object to the site's database.

The database will update the object, should an existing item with the specified package_name already exist.

Example:
!docs set python https://docs.python.org/3/ https://docs.python.org/3/objects.inv*

green mesa Jun 25, 2020, 5:26 PM

#

So can I store this data in db

#

Like bot make inventory url and store in db and when someone fire command bot look there

patent pivot Jun 25, 2020, 5:27 PM

#

you need to find the inventory URLs, but yes

brazen charm Jun 25, 2020, 5:28 PM

#

If they don't have the inventory then your choices are pretty much only getting the urls for every symbol yourself or redesigning the whole cog

green mesa Jun 25, 2020, 5:30 PM

#

Actually I love to do programming but I am a very big noob and where I live programming is not so appreciated I don't know y so sorry if I disturb you much ,I only have this server to clear my doubts

clever wraith Jun 25, 2020, 5:46 PM

#

!issue #419

#

!issue 419

#

.issue 419

dusky shoreBOT Jun 25, 2020, 5:46 PM

#

GitHub

PROpen [seasonalbot] #419 More Questions for the Trivia Quiz

clever wraith Jun 25, 2020, 5:47 PM

#

@patent pivot where can these emojis be found?

patent pivot Jun 25, 2020, 5:48 PM

#

hmmmmmm

clever wraith Jun 25, 2020, 5:48 PM

#

?

#

the pr emojis

patent pivot Jun 25, 2020, 5:49 PM

#

I know

#

I was looking for them

#

📎 unknown.png

clever wraith Jun 25, 2020, 5:49 PM

#

oh

#

can i use them in my bot

patent pivot Jun 25, 2020, 5:49 PM

#

uhh

#

probably

#

IssueClosed IssueOpen
PROpen PRClosed PRMerged

clever wraith Jun 25, 2020, 5:50 PM

#

k

patent pivot Jun 25, 2020, 5:50 PM

#

right click > copy link > save image

clever wraith Jun 25, 2020, 5:50 PM

#

wow

#

i can save em?

patent pivot Jun 25, 2020, 5:50 PM

#

I don't see a reason why not

brazen charm Jun 25, 2020, 5:51 PM

#

Would some stats be wanted for the doc (something like fetched package) joe? slowly reworking parts of it so can throw those in

patent pivot Jun 25, 2020, 5:51 PM

#

oh that'd be super dope

#

yeah

#

hmm you know

#

maybe we could do the whole symbol

#

flask.Response or whatever

#

docs_fetches.flask.Response

#

@brazen charm

brazen charm Jun 25, 2020, 5:55 PM

#

Stat for the individual symbol counts?

patent pivot Jun 25, 2020, 5:56 PM

#

because if we want total number of flask we can do doc_fetches.flask.*

#

hmmm

#

let me see

brazen charm Jun 25, 2020, 5:58 PM

#

There's a lot of individual symbols that'd can potentially be fetched, not familiar with the stats but could that be an issue?

patent pivot Jun 25, 2020, 5:59 PM

#

shouldn't be, I'm just going to check

#

the thing I'm not so sure about is nesting

woeful thorn Jun 25, 2020, 6:01 PM

#

@patent pivot @clever wraith they're GitHub's assets: https://github.com/primer/octicons

GitHub

primer/octicons

A scalable set of icons handcrafted with <3 by GitHub - primer/octicons

patent pivot Jun 25, 2020, 6:02 PM

#

ahhh

clever wraith Jun 25, 2020, 6:02 PM

#

nice

#

thanks @patent pivot @woeful thorn

cold moon Jun 25, 2020, 6:12 PM

#

I have 2 ideas for PyDis GitHub bot: (Note: Both suggestions is for Contributors in this server only. Giving these permissions to everyone will be too risky to be abused, but I think Contributors is enough trusted for these.)

Make possible to add some labels with defining them in title of issue/PR. Example: [level:0][planning][area:api,moderation] My issue should add these labels to issue/PR (don't add planning to PR, in PRs WIP should available). This should not apply to all labels, like priority is something that users can't measure themself I think. After applying labels, this should edit title and remove labels from there.
Add possibility to self-assign to issue with attaching [assign] at start of comment. This should not do this when some user is already assigned. This should automatically assign WIP label too.

brazen charm Jun 25, 2020, 6:20 PM

#

The titles would be way too messy with that info included

cold moon Jun 25, 2020, 6:23 PM

#

I mean, title should automatically edited after labels added by bot.

patent pivot Jun 25, 2020, 6:25 PM

#

@cold moon I like the ideas

#

not so sure about the [assign]

#

i like the natural language bots

#

like

#

I would like to work on this issue.

brazen charm Jun 25, 2020, 6:26 PM

#

Title changes will be kept in the PR so I don't think putting it there if it's deleted right away would be nice

woeful thorn Jun 25, 2020, 6:27 PM

#

It's also totally non-discoverable

tough imp Jun 25, 2020, 6:27 PM

#

I wonder whether it'd be possible to automatically transfer area tags from the linked issue, if there is one

#

but I guess there can be multiple

cold moon Jun 25, 2020, 6:27 PM

#

Maybe yes verbose version for assigning is better

#

Maybe for @dusky shore there should available [season:<season>] label assigning, when SeasonalBot will use GitHub bot too in one day.

patent pivot Jun 25, 2020, 7:35 PM

#

SeasonalBot does use it

#

It's currently down because I upgraded to macOS Big Sur and I'm just going to deploy it to K8S instead of set it up locally

#

I also think labels is something that core devs should be assigning kind of

#

since things have been mislabelled before where people don't get the labels and such

#

and it's kind of the purpose of this chat to communicate with core devs

#

pinging a core dev and asking for an assignment of labels is fine if we haven't already got to it

green mesa Jun 26, 2020, 12:22 AM

#

How bot decide we are talking asking about discord or datetime like !d discord.clinet or !d datetime😅

brazen charm Jun 26, 2020, 12:24 AM

#

As I mentioned, it uses the pregenerated inventory those doc pages provide. That's then parsed into the inventories dict of the cog. For example the entry for discord.Client looks like this "discord.Client": "https://discordpy.readthedocs.io/en/stable/api.html#discord.Client"

#

The packages aren't differentiated, it's just one big dict of symbols

green mesa Jun 26, 2020, 12:34 AM

#

Ok

green mesa Jun 26, 2020, 1:47 AM

#

Means bot only need this url = https://discordpy.readthedocs.io/en/stable/api.html/objects.inv and it breaks when command is fired plz correct if I am wrong

brazen charm Jun 26, 2020, 1:49 AM

#

the url will be https://discordpy.readthedocs.io/en/stable/objects.inv but what do you mean with "it breaks" ?

green mesa Jun 26, 2020, 1:50 AM

#

I meant it breaks into base url and package name auto?

brazen charm Jun 26, 2020, 1:50 AM

#

with the site set up, you use the commands joe has shown above to add the inventory url and that adds all the symbols to the dict

#

https://discordapp.com/channels/267624335836053506/635950537262759947/725763875936534610 all 3 need to be provided

green mesa Jun 26, 2020, 1:51 AM

#

Ty

clever wraith Jun 26, 2020, 7:53 AM

#

@green mesa help me yaar

green mesa Jun 26, 2020, 7:54 AM

#

Ahhh actually u have to ask for help in help section

clever wraith Jun 26, 2020, 7:54 AM

#

ok

green mesa Jun 26, 2020, 7:54 AM

#

This is dev contrib channel

clever wraith Jun 26, 2020, 7:54 AM

#

anyway, we're from same area, where coding isn't much know

#

lol

green mesa Jun 26, 2020, 7:54 AM

#

Plz read the topic

clever wraith Jun 26, 2020, 7:54 AM

#

yes

#

@green mesa DM me when free

gusty sonnet Jun 26, 2020, 9:42 AM

#

@clever wraith We don't encourage helping 1v1 via DM, you can definitely get one of the free help channel / ask in a topical chanel, that way others who have similar questions can benefit from the conversation as well

#

To grab a free help channel, you can check out #❓｜how-to-get-help for more information

clever wraith Jun 26, 2020, 9:43 AM

#

@gusty sonnet it's not for help, he's my friend

gusty sonnet Jun 26, 2020, 9:44 AM

#

I assumed that you needed help from your message. If you ever need help for specific python question, please do ask in the server instead

cold moon Jun 26, 2020, 11:16 AM

#

One more suggestion about GitHub bot. Not high-priority, but maybe good:

When user who don't have write access approve PR, bot should give approval too. Currently core devs have to force-merge PRs, because not enough review, but this will remove it. Also maybe this help to display better in GitHub UI.

patent pivot Jun 26, 2020, 11:29 AM

#

We don't need to force merge, another core dev adds an approval

split nexus Jun 26, 2020, 12:56 PM

#

Yes, I got the seasonalbot running on my Raspberry Pi. Took me 'only' two days...

green oriole Jun 26, 2020, 3:24 PM

#

Yeah, it is a bit hard to setup on arm devices

cold moon Jun 26, 2020, 3:53 PM

#

And Apple is moving computer to their own ARM processors...

green mesa Jun 26, 2020, 6:56 PM

#

One question y bot don't have discord module in eval

#

😅

cold moon Jun 26, 2020, 6:56 PM

#

!eval command have no external dependencies

brazen charm Jun 26, 2020, 6:57 PM

#

It does have some libs, but there wouldn't be much use from the discord package

patent pivot Jun 26, 2020, 6:58 PM

#

yeah it can't interact with discord so

patent pivot Jun 27, 2020, 2:36 AM

#

GitHub bot is up and running in Kubernetes now and has auto-deploy setup (I'll maybe open source the repo down the line)

📎 Screenshot_2020-06-27_at_03.36.23.png

green oriole Jun 27, 2020, 10:23 AM

#

!eval command have no external dependencies
@cold moon we so have some, on top of my head, I think they are numpy, scipy, networkx, pandas and forbiddenfruit available in the container

patent pivot Jun 27, 2020, 10:37 AM

#

yeah

cold moon Jun 27, 2020, 12:28 PM

#

Oh

patent pivot Jun 27, 2020, 12:31 PM

#

https://github.com/python-discord/snekbox/blob/master/Pipfile#L6-L26

GitHub

python-discord/snekbox

Easy, safe evaluation of arbitrary Python code. Contribute to python-discord/snekbox development by creating an account on GitHub.

cold moon Jun 27, 2020, 1:32 PM

#

I have currently some ideas about @stable mountain aliases (what is currently in Aliases cog) rework to custon decorators and I hope I can open issue later today.

tawdry vapor Jun 27, 2020, 7:57 PM

#

I think there's already a proposal

#

And an issue

brazen charm Jun 28, 2020, 10:31 PM

#

@patent pivot so for the doc stats, should it be package.symbol or just package ? You mentioned something about nesting problems but I'm not familiar with the stats to know what those could be

patent pivot Jun 28, 2020, 10:32 PM

#

package.symbol was dodgy yeah, just package will do

brazen charm Jun 28, 2020, 11:58 PM

#

Would that be a counter increment or a gauge?

patent pivot Jun 29, 2020, 12:02 AM

#

counter would probably be best

brazen charm Jun 29, 2020, 12:04 AM

#

Wasn't sure from the explanation here https://pythondiscord.com/pages/statistic-infrastructure/#counters where it's suggested counters are for the rate and gauges for precise numbers

#

Does the actual number matter here, or just their relative increases? Or did I misunderstand that

patent pivot Jun 29, 2020, 12:05 AM

#

I should probably reword that

#

In our case at least, I think counters can be thought of as things that will always increase, as opposed to gauges which fluctuate

#

counters can still be used to fetch totals by using the integral function in graphite, which is what I do for things like message count

#

accuracy is less important and it takes a bit less storage space

#

we use gauges for stuff like guild member counts or statuses

#

counters for pretty much everything else

#

Gauges are a constant data type. They are not subject to averaging, and they don’t change unless you change them. That is, once you set a gauge value, it will be a flat line on the graph until you change it again.

Gauges are useful for things that are already averaged, or don’t need to reset periodically. System load, for example, could be graphed with a gauge. You might use incr to count the number of logins to a system, but a gauge to track how many active WebSocket connections you have.

#

Counters are the most basic and default type. They are treated as a count of a type of event per second, and are, in Graphite, typically averaged over one minute. That is, when looking at a graph, you are usually seeing the average number of events per second during a one-minute period.

brazen charm Jun 29, 2020, 12:13 AM

#

are their names from the inventories fine or should it use the ones they have in the api?

In [2]: self.bot.get_cog("Doc").rs
Out[2]: 
{'Django', 'Flask', 'Kivy', 'Matplotlib', 'NetworkX',
 'NumPy', 'Pillow (PIL Fork)', 'PySide', 'Python',
 'Python Arcade Library', 'Requests', 'SciPy', 'aiohttp',
 'dateutil', 'discord.py', 'more-itertools', 'pandas',
 'urllib3'}

These are from the inventories I have locally

patent pivot Jun 29, 2020, 12:20 AM

#

hmmm

#

ideally they should be all lowercase, alphanumeric with _

brazen charm Jun 29, 2020, 12:21 AM

#

!d

#

right, can the names added by admins be assumed to not contain spaces etc.?

patent pivot Jun 29, 2020, 12:27 AM

#

I'll check

#

yeah

brazen charm Jun 29, 2020, 12:28 AM

#

alright I'll pass those lowercased then

patent pivot Jun 29, 2020, 12:29 AM

#

most of the time we use the import name

prisma path Jun 29, 2020, 1:00 AM

#

Joe, are you maintaining your own k8s cluster on bare metal?

patent pivot Jun 29, 2020, 1:06 AM

#

@prisma path for what? pydis or personal?

prisma path Jun 29, 2020, 1:06 AM

#

Well both, but I saw your screenshot from pydis :-)

patent pivot Jun 29, 2020, 1:07 AM

#

pydis does not use kubernetes, I use kubernetes personally but don't manage it, it's a Scaleway Kapsule https://www.scaleway.com/en/docs/get-started-with-scaleway-kubernetes-kapsule/

Scaleway

Scaleway Elements Kubernetes Kapsule

Discover how to get started with Scaleway Elements Kubernetes Kapsule

prisma path Jun 29, 2020, 1:07 AM

#

cooler

patent pivot Jun 29, 2020, 1:08 AM

#

this deploys dashboard, updates things and autoheals your nodes for you

prisma path Jun 29, 2020, 1:08 AM

#

Their prices are kinda reasonable actually.

#

I wanted to use k8s for my personal stuff too, but I only have 1 physical server 4Shrug

patent pivot Jun 29, 2020, 1:09 AM

#

Yeah, I get most of my stuff through them and have never had a bad experience. I pay €7.99 for my Kapsule & I think €2.99 for my VPS

#

monthly that is

#

yeah I just run a single node kubernetes

prisma path Jun 29, 2020, 1:09 AM

#

👍

clever wraith Jun 29, 2020, 5:35 AM

#

is there something I'm missing about the bot's in_whitelist check?

#

even copying it basically verbatim doesnt work

crude gyro Jun 29, 2020, 5:45 AM

#

gonna need more info than that, @clever wraith

#

but that check also had a decorator counterpart, and the deco is usually combined with certain constants so maybe those are the pieces missing

clever wraith Jun 29, 2020, 5:46 AM

#

no i-- i kinda forgot to load my error handler

crude gyro Jun 29, 2020, 5:46 AM

#

okay

clever wraith Jun 29, 2020, 5:46 AM

#

honestly im learning some decent thing from that bot's code ^.^

crude gyro Jun 29, 2020, 5:47 AM

#

good. that's a big part of the intention

neon phoenix Jun 29, 2020, 9:40 AM

#

okay, so, i'm creating a discord bot heavily inspired on @stable mountain, and i'd like to know how more or less you save infractions like tempbans and tempmutes

#

i know they go in a database, but, how they are more exactly organized?

exotic ember Jun 29, 2020, 9:48 AM

#

this might interest you:
https://github.com/python-discord/site/blob/master/pydis_site/apps/api/models/bot/infraction.py

GitHub

python-discord/site

pythondiscord.com - A Django and Bulma web application. - python-discord/site

neon phoenix Jun 29, 2020, 10:05 AM

#

oh thanks

#

i was diving into bot instead of site so i didn't notice it

#

well i think you didn't understood my question

#

imagine this is a table, right?

| ------ | ----- | ----- |
|        |       |       |
|--------|-------|-------|```

#

(sql)

#

how would be the infractions organized?

patent pivot Jun 29, 2020, 10:09 AM

#

                                       Table "public.api_infraction"
   Column    |           Type           | Collation | Nullable |                  Default                   
-------------+--------------------------+-----------+----------+--------------------------------------------
 id          | integer                  |           | not null | nextval('api_infraction_id_seq'::regclass)
 inserted_at | timestamp with time zone |           | not null | 
 expires_at  | timestamp with time zone |           |          | 
 active      | boolean                  |           | not null | 
 type        | character varying(9)     |           | not null | 
 reason      | text                     |           |          | 
 hidden      | boolean                  |           | not null | 
 actor_id    | bigint                   |           | not null | 
 user_id     | bigint                   |           | not null | 
Indexes:
    "api_infraction_pkey" PRIMARY KEY, btree (id)
    "unique_active_infraction_per_type_per_user" UNIQUE, btree (user_id, type) WHERE active = true
    "api_infraction_actor_id_ed96dde9" btree (actor_id)
    "api_infraction_user_id_8714e9f5" btree (user_id)
Foreign-key constraints:
    "api_infraction_actor_id_ed96dde9_fk_api_user_id" FOREIGN KEY (actor_id) REFERENCES api_user(id) DEFERRABLE INITIALLY DEFERRED
    "api_infraction_user_id_8714e9f5_fk_api_user_id" FOREIGN KEY (user_id) REFERENCES api_user(id) DEFERRABLE INITIALLY DEFERRED

neon phoenix Jun 29, 2020, 10:09 AM

#

thanks @patent pivot!!!

patent pivot Jun 29, 2020, 10:10 AM

#

np

neon phoenix Jun 29, 2020, 10:10 AM

#

so, as i see, basically each infraction is a table, right?

patent pivot Jun 29, 2020, 10:11 AM

#

each infraction is a row in the table

neon phoenix Jun 29, 2020, 10:11 AM

#

okay

patent pivot Jun 29, 2020, 10:13 AM

#

see https://paste.pythondiscord.com/ucunujitiq.rb

neon phoenix Jun 29, 2020, 10:13 AM

#

lol great example

#

well thanks @patent pivot!!! 😄

tawdry vapor Jun 29, 2020, 3:50 PM

#

I wouldn't really recommend that

#

I don't think the current system is particularly great

neon phoenix Jun 30, 2020, 1:18 PM

#

What's the hidden attribute on your infractions database?

#

I think it's set to True when you use shadow actions but I'm not sure

patent pivot Jun 30, 2020, 1:19 PM

#

yeah, shadow infractions

neon phoenix Jun 30, 2020, 1:19 PM

#

thanks joe sunglas

dull jetty Jul 1, 2020, 8:22 AM

#

#ask-joe

neon phoenix Jul 1, 2020, 10:35 AM

#

koolmeme

neon phoenix Jul 2, 2020, 5:46 AM

#

Where can I find the public eval command? I found so far the internal one, on bot/bot/cogs/eval.py

sullen phoenix Jul 2, 2020, 5:49 AM

#

it's in bot/bot/cogs/snekbox.py

brazen charm Jul 3, 2020, 11:43 AM

#

@patent pivot mind looking at https://github.com/python-discord/bot/issues/878#issuecomment-650816094 when you have the time?

patent pivot Jul 3, 2020, 11:44 AM

#

having a gander

#

@brazen charm 👍

#

we are more than okay for RAM though. We have an alert set at 60% RAM usage and haven't hit that yet

📎 unknown.png

#

last time we hit a RAM alert was when I started up a java application lol

subtle kraken Jul 3, 2020, 1:58 PM

#

is https://github.com/python-discord/bot/issues/1024 something we'd like to have in the bot?
I think I got solution however it works nearly completely in different way than current purge

GitHub

Purge messages up to given message · Issue #1024 · python-discord/b...

Problem: Currently the purge/clean command takes the number of messages to clean as the only way of specifying how far to clean, this can cause some difficulties when trying to clean lots of messag...

subtle kraken Jul 3, 2020, 2:14 PM

#

Actually its probably possible to do it same way, still interested in the issue itself

exotic ember Jul 3, 2020, 2:22 PM

#

if you have a solution proposal, it would be nice if you could comment on the issue itself

subtle kraken Jul 3, 2020, 2:23 PM

#

More or less I got whole idea of code, and somewhat prepared code ready

green oriole Jul 3, 2020, 3:09 PM

#

Oh hey, I've been doing the exact same functionality a few weeks ago for our kotlin bot

#

I've chosen to delete all the message posted between the clean invokation timestamp and the target timestamp

subtle kraken Jul 3, 2020, 4:20 PM

#

I did some eval testing found a more-or-less perfect way of cleaning all messages from invocation till message ID/URL

#

Had 3 ideas out of which 2 worked and 1 for some reason would result in python process to hang completely

timid pebble Jul 6, 2020, 5:49 AM

#

Hello guys

cold moon Jul 6, 2020, 6:40 AM

#

I think maybe should @stable mountain paginator to python package in PyPi. This will make possible to use it for other projects. Discord.py's own menus have one big design problem: This don't remove reactions after moving.

hardy gorge Jul 6, 2020, 7:07 AM

#

Our current paginator is a bit old as well and could use a redesign

scenic moth Jul 8, 2020, 4:15 PM

#

the re-running functionality on the code evaluator is great, gj developers

green oriole Jul 8, 2020, 4:16 PM

#

Glad you like it 😁

crude gyro Jul 8, 2020, 6:02 PM

#

<@&295488872404484098> Critical issue opened on the bot, in case someone wants it. If nobody grabs this in the next couple of days I'll probably do it myself. https://github.com/python-discord/bot/issues/1031

GitHub

Sanitize bot output · Issue #1031 · python-discord/bot

The problem Right now, it is possible to exploit certain parts of the bot in order to make the bot post things a regular member would normally not be allowed to post. These techniques can be used t...

#

please only take this if you can solve it quite quickly.

rocky bloom Jul 8, 2020, 6:15 PM

#

just to make sure, when !eval tries to circumvent filters, it sends a message to mods the same as regular filters do?

#

@crude gyro

brazen charm Jul 8, 2020, 6:17 PM

#

I'm not very familiar with the filtering cog but I'd assume that should notify the mods

rocky bloom Jul 8, 2020, 6:18 PM

#

yeah it does but like should it be the same message or a custom message saying that they tried to use !eval to circumvent it

crude gyro Jul 8, 2020, 6:24 PM

#

@rocky bloom maybe a custom one

#

would be nice to have that bit of context.

rocky bloom Jul 8, 2020, 6:24 PM

#

cool

crude gyro Jul 8, 2020, 6:24 PM

#

important thing is that we are notified.

rocky bloom Jul 8, 2020, 6:26 PM

#

also with the !raw command, discord.py's MessageConverter returns a BadArgument error with the error message containing the argument

#

so do i just use string formatting to format it out

woeful thorn Jul 8, 2020, 6:26 PM

#

Just remove the formatting

rocky bloom Jul 8, 2020, 6:28 PM

#

the formatting is currently await ctx.send(f"Bad argument: {e}\n") with e being the error text that the BadArgument is sent - changing that would involve changing all the BadArgument errors that are raised by other parts of the code

woeful thorn Jul 8, 2020, 6:28 PM

#

Yes

rocky bloom Jul 8, 2020, 6:28 PM

#

ok cool

crude gyro Jul 8, 2020, 6:42 PM

#

just replace it with something generic.

#

Bad argument: Please check your input arguments and try again or something.

rocky bloom Jul 8, 2020, 6:43 PM

#

ok cool

crude gyro Jul 8, 2020, 6:43 PM

#

easy and straight forward and completely fixes the problem

rocky bloom Jul 8, 2020, 6:48 PM

#

Also am I checking all !eval messages or just those from non-whitelisted channels/members?

crude gyro Jul 8, 2020, 6:49 PM

#

a fair question. I suppose you can check it for only non-staff

neon phoenix Jul 8, 2020, 7:36 PM

#

i'm implementing fetch & eval

#

but

#

there's a problem

#

you can only use fetch_message method on instances of discord.TextChannel

#

i need to crawl on all channels

hardy gorge Jul 8, 2020, 7:39 PM

#

Are you working on a specific issue?

#

One issue I see is this one: https://github.com/python-discord/bot/issues/1022

GitHub

Add way to get code block from another message in eval command · Is...

Proposal Eval command should support passing message or nothing instead code. When you pass the message, this should try parse code block from this message. This should be implemented that way that...

#

But it's not assigned to anyone yet and the labels say it's in the planning phase

neon phoenix Jul 8, 2020, 7:41 PM

#

yeah

#

that one

#

but considering that there are +100 channels here

#

wouldn't be a huge performance issue?

hardy gorge Jul 8, 2020, 7:42 PM

#

Alright, but you should first get yourself assigned to the issue and the issue should be fully approved/out of the planning phase

#

Do you have an outline of the implementation you have in mind to discuss in that issue?

neon phoenix Jul 8, 2020, 7:42 PM

#

well

hardy gorge Jul 8, 2020, 7:42 PM

#

I don't think the details as of yet are set in stone

neon phoenix Jul 8, 2020, 7:42 PM

#

i have a simple idea on mind

hardy gorge Jul 8, 2020, 7:43 PM

#

Yes, but you should probably get that idea into the issue first, before you start working on the implementation

neon phoenix Jul 8, 2020, 7:43 PM

#

okay

#

~~in what format do i write a comment to an issue, im not a very formal guy and i suck at essays~~

#

please dont assign me to nothing for now :p

hardy gorge Jul 8, 2020, 7:48 PM

#

We need to decide on an implementation before anyone can start working on it

#

So, if you have an idea for that, you should describe the idea and why you think it's a good idea to do it that way

neon phoenix Jul 8, 2020, 7:50 PM

#

well my implementation is like this:

convert code to an int
if it raises ValueError, it's not an ID (go to 5)
crawl on all channels to fetch the code using the message ID
if the message is not found, return (if its found convert it to a valid format)
execute it

#

i'm typing my implement here so we can discuss it better here

#

and it's a good idea my implementation because... there's no other way to do it meme

hardy gorge Jul 8, 2020, 7:52 PM

#

You should add your idea to the issue, so it's documented and other people can look at it

neon phoenix Jul 8, 2020, 7:52 PM

#

okay

stable mountainBOT Jul 9, 2020, 1:42 AM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

tawdry vapor Jul 9, 2020, 5:26 PM

#

@celest charm Hey, why did you close your generator tag PRs? Are you still interested in adding that tag? I was just looking at stale branches to clean up.

celest charm Jul 9, 2020, 5:29 PM

#

I don't remember. Probably I got something screwed up with git. Right now I'm busy, so I won't be able to work on it. But globally - yes.

tawdry vapor Jul 9, 2020, 5:30 PM

#

Alright, I'll keep the branches around for now then.

#

@exotic ember since ks129 has a PR open for the source command, can I delete your branch? Sorry I didn't realise you had a branch for it when I unassigned you. At the time, I just noticed you had self assigned 5 months ago without any word since.

exotic ember Jul 10, 2020, 2:14 AM

#

@tawdry vapor yaya go ahead, thats okay

vocal wolf Jul 13, 2020, 1:50 AM

#

I'm having a bit of trouble getting my instance of seasonalbot to find any channel, in this server or on my own test with bot.get_channel. I feed it an ID, it always seems to return None.

I've made small changes to a branch in an attempt to fix the exploit, I just can't test it since I haven't figured out why it's not detecting channels as of now.
Here's the changes I've made off of the main branch to the mentions-fix branch:
Allowing only certien pings: https://github.com/python-discord/seasonalbot/blob/mentions-fix/bot/exts/christmas/adventofcode.py#L121-L125
Kwarg when contructing the bot for allowed_mentions: https://github.com/python-discord/seasonalbot/blob/mentions-fix/bot/bot.py#L206-L211

brazen charm Jul 13, 2020, 1:54 AM

#

Assume you've changed the constants locally? You won't be able to get the channels from here unless you're working on the production instance

vocal wolf Jul 13, 2020, 2:08 AM

#

When I worked with the bot I changed them locally within constants.py on my own server, along with changing environment variables within docker-compose.yml

green mesa Jul 13, 2020, 2:22 AM

#

Hello coders
One question how mute or temp ban system work basically my question is about timing ,like timing is random or it decided through something?

#

Just a random question 😅

#

Or timing is upto staff to decide

tawdry vapor Jul 13, 2020, 2:24 AM

#

It's an argument passed to the command

#

The staff decide it when they invoke the command

sullen phoenix Jul 13, 2020, 2:24 AM

#

what good would it do if it was random lol

green mesa Jul 13, 2020, 2:24 AM

#

Lol

sullen phoenix Jul 13, 2020, 2:24 AM

#

but yeah, staff decides

green mesa Jul 13, 2020, 2:25 AM

#

Then it will luck

#

1 year or 1 minute if we import random module hehehehehe

#

Ok ty for your answer @sullen phoenix

sullen phoenix Jul 13, 2020, 2:26 AM

#

and Mark as well

green mesa Jul 13, 2020, 2:29 AM

#

Yes @tawdry vapor ty too

#

Ty both of you

green mesa Jul 13, 2020, 5:04 AM

#

Can we have channel for challenging question like we can participate there and py will give 10 random question which has to be solved in certain time duration

#

This will make beginners work in their basics

#

Bcz it's like a competition

#

We have almost everything in this server, if we have championship for coding it will boost interest of new coders

tawdry vapor Jul 13, 2020, 5:10 AM

#

This isn't the right channel. Please use #community-meta for community suggestions

green mesa Jul 13, 2020, 5:13 AM

#

Ooo sorry

#

Will I delete from here?

rocky bloom Jul 13, 2020, 2:12 PM

#

Hi - I'm working on the PR #1032 of the bot repo and I'm not the most familiar with unit tests and I've had to change a couple of the !eval ones because they now call the Filtering Cog and I was wondering how to replicate the filtering cog in the unit test

crude gyro Jul 13, 2020, 2:19 PM

#

how to mock it, you mean?

#

@rocky bloom

rocky bloom Jul 13, 2020, 2:20 PM

#

yeah

crude gyro Jul 13, 2020, 2:21 PM

#

so you need something Filtering-coglike for the test? Usually the easiest is for you to just create a MagicMock object

#

or, if possible, use the cog itself in the test.

#

that'll be most precise

#

but that's often wildly inconvenient

#

which tests are you changing?

rocky bloom Jul 13, 2020, 2:24 PM

#

snekbox tests

crude gyro Jul 13, 2020, 2:25 PM

#

yes. which ones.

#

give me something. an example of what you're trying to do

rocky bloom Jul 13, 2020, 2:25 PM

#

test_send_eval is the main one and the others need to be changed accordingly

crude gyro Jul 13, 2020, 2:26 PM

#

are you trying to change them so that they test if filters are run or what's the idea?

rocky bloom Jul 13, 2020, 2:27 PM

#

currently they give out the exception TypeError: object MagicMock can't be used in 'await' expression

#

uh lemme get the full traceback

hardy gorge Jul 13, 2020, 2:27 PM

#

If you want to mock a coroutine/awaitable, then there's an AsyncMock to use instead of a MagicMock

#

https://docs.python.org/3/library/unittest.mock.html#unittest.mock.AsyncMock

rocky bloom Jul 13, 2020, 2:28 PM

#

ah

#

i'll post the traceback too just in case but lemme see what i can do

#

ERROR: test_send_eval (tests.bot.cogs.test_snekbox.SnekboxTests)
Test the send_eval function.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\suhai\AppData\Local\Programs\Python\Python38\lib\unittest\async_case.py", line 65, in _callTestMethod
    self._callMaybeAsync(method)
  File "C:\Users\suhai\AppData\Local\Programs\Python\Python38\lib\unittest\async_case.py", line 88, in _callMaybeAsync
    return self._asyncioTestLoop.run_until_complete(fut)
  File "C:\Users\suhai\AppData\Local\Programs\Python\Python38\lib\asyncio\base_events.py", line 616, in run_until_complete
    return future.result()
  File "C:\Users\suhai\AppData\Local\Programs\Python\Python38\lib\unittest\async_case.py", line 102, in _asyncioLoopRunner
    ret = await awaitable
  File "D:\Suhail\Documents\Python Discord\bot\tests\bot\cogs\test_snekbox.py", line 240, in test_send_eval
    await self.cog.send_eval(ctx, 'MyAwesomeCode')
  File "D:\Suhail\Documents\Python Discord\bot\bot\cogs\snekbox.py", line 217, in send_eval
    filter_triggered = await filter_cog.filter_eval(msg, ctx.message)
TypeError: object MagicMock can't be used in 'await' expression```

crude gyro Jul 13, 2020, 2:31 PM

#

right, so you are changing this test to check if filters are triggered?

#

I would suggest you don't do that, and instead write an additional test or two for that

#

but yeah, the AsyncMock may be what you need

woeful thorn Jul 13, 2020, 2:32 PM

#

The changes broke the current tests

crude gyro Jul 13, 2020, 2:33 PM

#

right, the filter_eval call is from inside snekbox, not from the test

#

my bad

#

well that error seems to be because ctx.message is a MockMessage which is a MagicMock subclass

#

to which the easiest solution is probably just to make ctx.message an AsyncMock that contains whatever you need it to contain

tough imp Jul 13, 2020, 2:36 PM

#

it's not awaiting the message

#

looks like it's just trying to await some coro which is mocked with a MagicMock

#

maybe it wasn't a coro before? i haven't looked at the diff

rocky bloom Jul 13, 2020, 2:38 PM

#

it didn't exist beforehand

tough imp Jul 13, 2020, 2:38 PM

#

so to mock a coro you need to use AsyncMock, so that it can be awaited

crude gyro Jul 13, 2020, 2:39 PM

#

I don't get it, why would filter_cog.filter_eval possibly be a MagicMock

hardy gorge Jul 13, 2020, 2:41 PM

#

This is a newly written test, right?

woeful thorn Jul 13, 2020, 2:42 PM

#

No

crude gyro Jul 13, 2020, 2:42 PM

#

nope

hardy gorge Jul 13, 2020, 2:42 PM

#

something has changed in the test file, because the line numbers don't match up

rocky bloom Jul 13, 2020, 2:43 PM

#

i might have added an extra newline

#

by accident

hardy gorge Jul 13, 2020, 2:43 PM

#

The line that's in the traceback is on line 236 in the current master

rocky bloom Jul 13, 2020, 2:43 PM

#

lemme discard all changes and rerun it

woeful thorn Jul 13, 2020, 2:43 PM

#

You can just get the same error message from the Azure build log on the PR

#

Which hasn't touched the test file

hardy gorge Jul 13, 2020, 2:44 PM

#

Alright, I'm just trying to establish that I'm looking at the correct code

#

Okay

#

            filter_cog = self.bot.get_cog("Filtering")
            filter_triggered = await filter_cog._filter_eval(msg, ctx.message)

#

bot here is mocked by a MockBot, which is a subclass of MagicMock. That means that any attribute accessed on bot will be mocked by MagicMock as well (unless otherwise specified), including the get_cog attribute. When that attribute is called, it will return another MagicMock (it's magic mocks all the way down).

#

That means that filter_cog will be a MagicMock

#

When you then access an attribute on filter_cog, that will be a MagickMock as well, which means that the _filter_eval attribute will be a MagicMock as well

rocky bloom Jul 13, 2020, 2:49 PM

#

so shall i set get_cog's return_value to an AsyncMock?

hardy gorge Jul 13, 2020, 2:50 PM

#

That would work, although a Cog isn't awaitable itself, so it doesn't strictly fit.

#

You could do this to make it more precise:

mocked_filter_cog = MagicMock()
mocked_filter_cog._filter_eval = AsyncMock()
self.bot.get_cog.return_value = mocked_filter_cog

rocky bloom Jul 13, 2020, 2:53 PM

#

okay cool thanks :D

#

also this is a minor issue but whenever i run the pipenv run lint, i always get every file's line endings modified - is there any way to change that?

#

(since it causes all files to show up as modified in my git client)

crude gyro Jul 13, 2020, 3:11 PM

#

you on windows?

rocky bloom Jul 13, 2020, 3:11 PM

#

yep

crude gyro Jul 13, 2020, 3:12 PM

#

you may have cloned it with windows endings. the solution would be to tell git that you want Linux line endings on that repo

#

I thought we already did that though

#

with like a .gitattributes file or something

hardy gorge Jul 13, 2020, 3:15 PM

#

@rocky bloom Is the test issue solved?

rocky bloom Jul 13, 2020, 3:15 PM

#

yep solved!

#

thanks so much for your help! i just committed it and seems like the tests worked!

hardy gorge Jul 13, 2020, 3:22 PM

#

Oh, nice, good to hear.

brazen charm Jul 13, 2020, 5:24 PM

#

I've got a function in 927 that I'd like to use in an another branch, but the commit that added it contains done other things so it can't be cherry picked alone. Should I wait for it to get merged or is there an another way of going about this?
Let me know if it's be more fitting in #tools-and-devops

crude gyro Jul 13, 2020, 6:07 PM

#

@brazen charm one other way to go about it is to cherry pick it anyway and then write in the new pull request that #927 must be merged first, but it's a little messy

brazen charm Jul 13, 2020, 6:08 PM

#

Not sure if lint would pass if I only cherry picked that

crude gyro Jul 13, 2020, 6:08 PM

#

well, base yourself off that whole branch then

brazen charm Jul 13, 2020, 6:08 PM

#

But htinking about it lint doesn't really matter for a wip pr

brazen charm Jul 13, 2020, 10:27 PM

#

Could the current doc inventory names that use capital letters be changed to lowercase? joe mentioned that stats should be a-z_ and I'm logging the names lowercased, but that wouldn't change anything for digits etc. So I'm thinking of just restricting it when entered through the command

patent pivot Jul 13, 2020, 10:31 PM

#

on it

#

hmmmm

#

I can't change it

#

raw SQL time sunglas

brazen charm Jul 13, 2020, 10:32 PM

#

They're also addable through the site which doesn't seem to put in any restrictions, should I also look into changing that?

patent pivot Jul 13, 2020, 10:32 PM

#

I don't think we have ever added them through the site, it'd be nice to have a validation but not required

brazen charm Jul 13, 2020, 10:33 PM

#

I've never worked with django but I'll look at what I can do there

patent pivot Jul 13, 2020, 10:34 PM

#

all are lowercase now

#

!doc help

#

wrong way

#

!help doc

stable mountainBOT Jul 13, 2020, 10:34 PM

#

Command Help

!docs [symbol]
Can also use: doc, d

Lookup documentation for Python symbols.

Subcommands:

!docs delete <package_name>
Removes the specified package from the database.
!docs get [symbol]
Return a documentation embed for a given symbol.
!docs refresh
Refresh inventories and send differences to channel.
!docs set <package_name> <base_url> <inventory_url>
Adds a new documentation metadata object to the site's database.

patent pivot Jul 13, 2020, 10:34 PM

#

!doc refresh

stable mountainBOT Jul 13, 2020, 10:34 PM

#

Inventories refreshed

+ python, arcade
- Python, Arcade```

patent pivot Jul 13, 2020, 10:34 PM

#

excellent

brazen charm Jul 13, 2020, 10:34 PM

#

Thanks

tawdry vapor Jul 13, 2020, 10:50 PM

#

Do we really need to use the site

#

Is a move to redis possible, or are the models too complex?

patent pivot Jul 13, 2020, 10:58 PM

#

hmmmm

#

well

#

it's literally 3 columns

#

📎 Screenshot_2020-07-13_at_23.59.10.png

#

but I don't know how I feel about redis for persistence

green mesa Jul 14, 2020, 3:38 AM

#

Y py bot don't send .TXT file when it's output is long?

#

Py bot can add paginaton by breaking output in pages and then adding paginator to it

crude gyro Jul 14, 2020, 9:10 AM

#

Is a move to redis possible, or are the models too complex?
@tawdry vapor

no no, it's not about whether the models are too complex, it's about whether the data is disposable or not.

#

I don't think this data is disposable

#

we don't do backups of redis data, nor is restoring redis data from backup a good idea even if we did, because think about the help channels for example. We restore a redis snapshot and now suddenly we've time traveled back to a time where users are registered as claimants for channels they shouldn't actually own

#

if we keep using RedisCache for caching, the way we should, that means that the data often is tied to a particular point in time. It represents right now. And that's not compatible with a model of persistance and snapshots and backup restores. We'd have to start storing a bunch of timestamps and doing all sorts of integrity checks and so on, it's basically gross

#

so the easiest thing is to use Redis for temporarily caching disposable data, and use postgres for anything you care about persisting.

#

I think in time we should implement some sort of cache clearing strategy too, like if we have extended downtime (multiple hours), I think the cache should probably just be cleared when the bot comes back up for the sake of integrity.

green mesa Jul 14, 2020, 9:25 AM

#

hello i how bot convert ISO time to utc

#

i check pybot repo but havent able to find anywhere

#

just curious to know

crude gyro Jul 14, 2020, 9:31 AM

#

@green mesa for what command?

green mesa Jul 14, 2020, 9:31 AM

#

temp mute

#

how py bot sends user muted for 1day 23h

crude gyro Jul 14, 2020, 9:32 AM

#

check bot/utils/time.py

green mesa Jul 14, 2020, 9:32 AM

#

ok ty

crude gyro Jul 14, 2020, 9:33 AM

#

some of that also happens on the site side

#

... I think

#

might be wrong

#

hmm, actually maybe all of it happens on the site, lemme take a quick look

#

aha, right

#

we're doing it with the Duration converter in bot/converters.py. Most of the magic happens in its parent class, DurationDelta

#

essentially we have this regular expression:

duration_parser = re.compile(
    r"((?P<years>\d+?) ?(years|year|Y|y) ?)?"
    r"((?P<months>\d+?) ?(months|month|m) ?)?"
    r"((?P<weeks>\d+?) ?(weeks|week|W|w) ?)?"
    r"((?P<days>\d+?) ?(days|day|D|d) ?)?"
    r"((?P<hours>\d+?) ?(hours|hour|H|h) ?)?"
    r"((?P<minutes>\d+?) ?(minutes|minute|M) ?)?"
    r"((?P<seconds>\d+?) ?(seconds|second|S|s))?"
)

And then we feed that into a relativedelta.

#

@green mesa

hardy gorge Jul 14, 2020, 9:45 AM

#

It's beautiful

green mesa Jul 14, 2020, 10:07 AM

#

ohk

obsidian patio Jul 14, 2020, 1:20 PM

#

I'd like to contribute to the bot, but don't have any real experience with GitHub. Do you have any good resources to recommend and could you help me get started with it in some way? I'm still not quite sure about the workflow

crude gyro Jul 14, 2020, 1:21 PM

#

for learning the git cli, Corey Schafer has a great series https://www.youtube.com/watch?v=HVsySz-h9r4&list=PL-osiE80TeTuRUfjRe54Eea17-YfnOOAx

YouTube

Corey Schafer

Git Tutorial for Beginners: Command-Line Fundamentals

Git is the most popular version control system out there and for good reason. In this video, we'll go over the basics of what git is and how to use it within the command-line. There are several GUI tools out there to help you get started with git, but it can be extremely benef...

▶ Play video

#

for GitHub itself, well, all you need to learn is that workflow. Essentially to contribute to our bot you want to fork our repository, make a new branch on your fork to work in, and write your solution there.

#

then you open a pull request from that branch to our master branch

#

we have resources for the specific repos here: https://pythondiscord.com/pages/contributing/

Python Discord | Contributing

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

specifically for the bot here https://pythondiscord.com/pages/contributing/bot/

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

and more git resources here https://pythondiscord.com/pages/contributing/working-with-git/

Python Discord | Working with Git

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

brazen charm Jul 14, 2020, 1:25 PM

#

Are you using some kind of an editor with builtin version control tools? Most of the git(hub) stuff will be creating a new branch, switching around, commiting and pull/push

obsidian patio Jul 14, 2020, 1:27 PM

#

I'm using VS Code

#

Thanks, I'll keep learning about git. I've seen Corey Schafer's videos before, so that looks promising

#

I'll follow the steps laid out in the article quite soon then, but how do I know what to work on? Do I check the issues tab on GitHub and just start creating a solution or is there something else that I should know?

green mesa Jul 14, 2020, 1:31 PM

#

I have one question y we have ISO converter?

obsidian patio Jul 14, 2020, 1:31 PM

#

If you know any good article or video explaining how the collaboration part works, I'd love to read/watch

green mesa Jul 14, 2020, 1:31 PM

#

When we can easily use UTC one

#

Well u can fork and do a pull req

brazen charm Jul 14, 2020, 1:33 PM

#

There are some issues available on the bot repos, for a start you can try something with the beginner or good first issue tags. If there's something you'd like to work on from the current issues then you can comment there and you'll get assigned if possible

crude gyro Jul 14, 2020, 1:33 PM

#

I have one question y we have ISO converter?
@green mesa

if you're still referring to being able to do !tempmute 1H30M, why wouldn't we have that. it's easy and user friendly.

#

the alternative is to literally pass in an expiration datetime

#

otherwise I have no idea what you're asking.

obsidian patio Jul 14, 2020, 1:34 PM

#

So, I'll have a look in the issues and comment that I'm up for solving the issue?

crude gyro Jul 14, 2020, 1:34 PM

#

sounds good

#

there's like 150 open issues on bot, so I'm sure you can find something nice

green mesa Jul 14, 2020, 1:35 PM

#

I also wnt to contribute but I don't have much experience in py 😐

obsidian patio Jul 14, 2020, 1:36 PM

#

Perfect! And then, I'll fork the repo, develop a solution and create a pull request?

brazen charm Jul 14, 2020, 1:36 PM

#

I didn't have all that much experience myself when I started contributing here, there are simpler issues around and other contributors or people in help channels can help if you get stuck on something

#

You'll want to fork it before that, as the bot requires a bit of setup to work including the site for most features

obsidian patio Jul 14, 2020, 1:37 PM

#

Right. I read about that. Do I fork before I do the setup, or the other way around?

crude gyro Jul 14, 2020, 1:38 PM

#

fork first

#

then get it running locally

#

so you can test

obsidian patio Jul 14, 2020, 1:38 PM

#

Okay

crude gyro Jul 14, 2020, 1:38 PM

#

the contribution guide for the bot I linked above is important in getting it running

#

once you've got a copy of the bot running on a test server and the console output isn't full of errors, you can make yourself a branch and start writing your contribution

#

remember to keep your commits small and atomic, and the commit messages descriptive and clean. Follow the 7 rules of a good commit message (google this term).

#

make sure your branch passes lint and tests

#

when everything looks good, open a pull request to us

green mesa Jul 14, 2020, 1:40 PM

#

one question if I get stuck at somewhere while solving bot issue can I ask in helpchannel😊

crude gyro Jul 14, 2020, 1:40 PM

#

and we'll review

obsidian patio Jul 14, 2020, 1:41 PM

#

Thanks a lot. I'll take a closer look and get started

crude gyro Jul 14, 2020, 1:41 PM

#

@green mesa depends how you're stuck. if you're stuck on a Python problem, of course you can. If you're stuck on something that's specific to our repo, probably best to ask in here

green mesa Jul 14, 2020, 1:41 PM

#

Ok ty

brazen charm Jul 14, 2020, 3:17 PM

#

The blame may offer some insight

patent pivot Jul 14, 2020, 3:17 PM

#

yeah, checking it now

brazen charm Jul 14, 2020, 3:17 PM

#

But last time I checked the paginator could use a small rewrite, if it didn't get one since then

patent pivot Jul 14, 2020, 3:18 PM

#

https://github.com/python-discord/bot/commit/3a9b3b77fb350cdfd02970e6e00b1df383954b79

GitHub

Show active status in infraction list, fix Discord pagination rende...

…ng issue

near karma Jul 14, 2020, 3:19 PM

#

Going to copy pasta for relevance:
Sorry guys. I'm looking at @stable mountain 's code, and I stumbled upon this bit in the paginator code:

            # Magic happens here, after page and reaction_type is set
            embed.description = ""
            await message.edit(embed=embed)
            embed.description = paginator.pages[current_page]

            image = paginator.images[current_page]
            if image:
                embed.set_image(url=image)

            embed.set_footer(text=f"Page {current_page + 1}/{len(paginator.pages)}")
            log.debug(f"Got {reaction_type} page reaction - changing to page {current_page + 1}/{len(paginator.pages)}")

            await message.edit(embed=embed)

(sic. indentaton). My question is, why do you guys first clear the embed, update th emessage with the empy embed, and then update it again and re-edit it? Should I open a help channel?

#

Oh, did it rended the embed wrong if it did not clear it first?

patent pivot Jul 14, 2020, 3:21 PM

#

I guess so, but that was 2 years ago and it might be fixed now

near karma Jul 14, 2020, 3:22 PM

#

Mhm. I've taken the liberty of copying the core mechanism of the paginator for my own bot, and the rendering seems ok?

sullen phoenix Jul 14, 2020, 3:22 PM

#

@slow bone doesn’t seem to have this issue, we could probably update @stable mountain

patent pivot Jul 14, 2020, 3:23 PM

#

yeah

near karma Jul 14, 2020, 3:25 PM

#

\o/ Yay!

#

Thanks for your help guys

green mesa Jul 14, 2020, 6:19 PM

#

DO we have games in seasonal bot?

tawdry vapor Jul 14, 2020, 6:19 PM

#

Yes

green mesa Jul 14, 2020, 6:19 PM

#

Which ones

tawdry vapor Jul 14, 2020, 6:19 PM

#

Battleships and some quizzes

#

Maybe tic tac toe too. I don't remember

green mesa Jul 14, 2020, 6:20 PM

#

Wow havent tried yet

#

And I chek the links which lemon shared and I think I can contribute on tic tac toe

tough imp Jul 14, 2020, 6:20 PM

#

we have minesweeper

#

tic tac toe not merged yet

#

theres a PR for it

#

https://github.com/python-discord/seasonalbot/pull/397

green mesa Jul 14, 2020, 6:21 PM

#

I don't know what is PR new to GitHub 😐

#

Oonpull req

#

Oo pull req*

#

😅

#

Came to know by link

#

That guy made cool tic tac toe game

sullen phoenix Jul 14, 2020, 6:26 PM

#

did you just...

#

did you open #1048?

#

@green mesa

#

or was that someone else 🤔

green mesa Jul 14, 2020, 6:32 PM

#

No

#

I have a plan for bm command

#

We can do like this if we have a message like this

#

Hello h

#

How

#

R

#

U

#

Then if we do .bm no of message link of message to save as bookmark

#

Then it will be cool for bookmark

tawdry vapor Jul 14, 2020, 6:35 PM

#

We already have a bookmark command

green mesa Jul 14, 2020, 6:35 PM

#

Oo

#

@tawdry vapor working one?

#

Which things I can work on? Sorry new to git

tawdry vapor Jul 14, 2020, 6:36 PM

#

Yes of course. We wouldn't merge a broken feature.

#

The bot is just down right now

green mesa Jul 14, 2020, 6:37 PM

#

So how it's bookmark?

tawdry vapor Jul 14, 2020, 6:37 PM

#

Let me see if I can get the bot back up and you'll see for yourself

green mesa Jul 14, 2020, 6:37 PM

#

Ok ty

#

Well I scrolled up .bm works for only one line

#

What if user wnts to bookmark some code

#

Which is of 10 lines?

brazen charm Jul 14, 2020, 6:46 PM

#

you can bookmark the starting message

green mesa Jul 14, 2020, 6:48 PM

#

But isint it will be nice if .bm sends embed and at description it shows some code and in it

#

Not a single line

#

So like if I have list of 10 things I can bookmark it and it will show me in embed and add jump bck url also

sullen phoenix Jul 14, 2020, 6:51 PM

#

this is what a bookmark looks like

📎 unknown.png

green mesa Jul 14, 2020, 7:45 PM

#

Wow

#

This is what i am talking about

rocky bloom Jul 14, 2020, 7:49 PM

#

I don't know what's funnier

#

the fact that people bothered to troll in pr #1049

#

or the fact that the 3 lines they replaced every file with isn't actually python syntax

crude gyro Jul 14, 2020, 8:36 PM

#

@tawdry vapor you there? mind having another look at https://github.com/python-discord/django-crispy-bulma/pull/34 ?

GitHub

Move release pipeline to Github Actions. by scragly · Pull Request ...

To simplify some of our processes, and to bring this project in line with the release methods used by flake8-annotations, I've added a Github action for releases.
The azure config that prev...

#

I'm not 100% sure if it actually works, but it ought to. A little hard to test stuff like this without just pushing it to production

#

which is fine for this particular repo

tawdry vapor Jul 14, 2020, 8:39 PM

#

Yes, I'll have a look

#

Honestly I don't know anything about GH actions

#

What's the benefit of using a flake8 action?

#

Can't it just be invoked as a shell command?

#

It does fancy things like add annotations to your PRs inline.
Ok that's cool

crude gyro Jul 14, 2020, 8:48 PM

#

maybe we should just remove django-crispy-bulma from site altogether

#

and archive the whole repo

#

nobody is maintaining it, after all

tawdry vapor Jul 14, 2020, 8:48 PM

#

Perhaps

#

I think we only rely on it for the OAuth form on our site

crude gyro Jul 14, 2020, 8:49 PM

#

yeah, for the account deletion form

#

pretty sure I could get that working with just plain django forms, or at least with plain crispyforms

#

I'm having a go at that right now but I'm not really sure how to get to that page on the dev site

tawdry vapor Jul 14, 2020, 8:51 PM

#

I think OAuth is one of the things I couldn't get to work locally

crude gyro Jul 14, 2020, 8:51 PM

#

yeah

tawdry vapor Jul 14, 2020, 8:51 PM

#

Even on the master branch

crude gyro Jul 14, 2020, 8:51 PM

#

I wonder if it's somehow disabled

#

@molten bough might remember

molten bough Jul 14, 2020, 8:54 PM

#

I don't recall if I specifically used crispy for that

#

but it's a pretty simple form

crude gyro Jul 14, 2020, 8:54 PM

#

no no, the question is "how the fuck do you test this locally"

molten bough Jul 14, 2020, 8:55 PM

#

Oh, you want to test the oauth integration

crude gyro Jul 14, 2020, 8:55 PM

#

not really, I just want to see that account deletion screen

molten bough Jul 14, 2020, 8:55 PM

#

I made an oauth app on the discord developers site, you can have a redirect url under localhost

crude gyro Jul 14, 2020, 8:55 PM

#

so I can remove all the crispy-bulma from it

molten bough Jul 14, 2020, 8:55 PM

#

that's how I tested it locally

crude gyro Jul 14, 2020, 8:56 PM

#

maybe I can just log in via /admin/login ?

molten bough Jul 14, 2020, 8:56 PM

#

Yeah, that might work

#

it's been long enough that I can't remember if I checked for an oauth login specifically, but I highly doubt that I did

crude gyro Jul 14, 2020, 8:57 PM

#

aha, yes.

#

that did work

molten bough Jul 14, 2020, 8:58 PM

#

\o/

crude gyro Jul 14, 2020, 9:03 PM

#

@tawdry vapor Okay, I'm opening a PR to site to remove django-crispy-bulma as a dependency

#

feels more reliable

tawdry vapor Jul 14, 2020, 9:04 PM

#

Sounds good

crude gyro Jul 14, 2020, 9:06 PM

#

https://github.com/python-discord/site/pull/368/files

GitHub

Removes django-crispy-bulma as a dependency. by lemonsaurus · Pull ...

django-crispy-bulma is not being maintained, and looks like it has a bleak future. I'm considering just archiving it, to be honest.
As such, it has no place in our site. This PR removes it ...

#

once this is merged, we can probably go ahead with the Django 3.0 migration, right?

#

or are there any other blockers?

tawdry vapor Jul 14, 2020, 9:08 PM

#

Not really but I do have a couple concerns

#

First are these empty list bugs

#

I've fixed two so far.

#

The other concern is django-environ. Many people saying that it doesn't support Django 3.0 but it seems to work when I tried it. I tried to ask for clarification on what doesn't work but never got a response.

#

@crude gyro so how do I test this delete form?

#

I logged in with admin then tried to delete my account

#

I got

📎 unknown.png

crude gyro Jul 14, 2020, 9:16 PM

#

that is weird.

#

it worked fine on my end

#

but, hmm

#

okay, right, I think that's a bug

#

I will have to look at it tomorrow

#

feel free to leave a review, I think I might know why it's happening.

rocky bloom Jul 14, 2020, 9:43 PM

#

do y'all mind if i test !eval filtering? i just wanna see if it works

#

but i don't wanna get infractions

crude gyro Jul 14, 2020, 9:43 PM

#

has it been merged?

rocky bloom Jul 14, 2020, 9:43 PM

#

just now actually

crude gyro Jul 14, 2020, 9:44 PM

#

go ahead

rocky bloom Jul 14, 2020, 9:45 PM

#

seems to work!

#

https://discordapp.com/channels/267624335836053506/267659945086812160/732714349285867681

crude gyro Jul 14, 2020, 10:05 PM

#

@tawdry vapor I see now, it's because of django-crispy-forms itself. I'm getting rid of that dependency, too.

#

it's only used for account delete, so

#

kinda pointless

tawdry vapor Jul 14, 2020, 10:12 PM

#

Ok it looks fine now

#

Did you test that the delete actually goes through?

crude gyro Jul 14, 2020, 10:13 PM

#

yes

tawdry vapor Jul 14, 2020, 10:13 PM

#

I kinda dont want to delete my admin account

crude gyro Jul 14, 2020, 10:13 PM

#

it doesn't really delete the account

#

or, at least I don't think so.

#

I think it just deletes its connection to the discord user

tawdry vapor Jul 14, 2020, 10:14 PM

#

Yeah it does

#

I tried it

#

Whatever, I'll recreate the containers

crude gyro Jul 14, 2020, 10:14 PM

#

you're using docker-compose, right?

tawdry vapor Jul 14, 2020, 10:14 PM

#

Yes

crude gyro Jul 14, 2020, 10:14 PM

#

just docker-compose up --build should fix it then I suppose

tawdry vapor Jul 14, 2020, 10:15 PM

#

Ah yeah it recreates the user each time it restarts

#

cool

crude gyro Jul 14, 2020, 10:15 PM

#

oh yeah you don't even have to build

#

it's right there in manage.py

tawdry vapor Jul 14, 2020, 10:15 PM

#

Alright you have my approval

crude gyro Jul 14, 2020, 10:16 PM

#

isn't it just great to remove dependencies

#

such a relief

tawdry vapor Jul 14, 2020, 10:18 PM

#

Is the 0.0.0.0 thing safe?

crude gyro Jul 14, 2020, 10:18 PM

#

it's only there if DEBUG is enabled

#

so I would say yes

tawdry vapor Jul 14, 2020, 10:18 PM

#

ah ok

#

Can't see that in the diff

crude gyro Jul 14, 2020, 10:18 PM

#

yeah

#

it's convenient though, because when you spin up the containers via docker-compose it will link you to the site in the terminal output and it links to 0.0.0.0

#

so you can just click the link

#

<@&587606783669829632>

Easy review at https://github.com/python-discord/site/pull/368. This review gets us one important step closer to running Django 3.0 in production, which is a blocker for my whitelist PR, so I'd appreciate if someone has 3 minutes to spare for it

#

already tested by both me and Mark, so really just needs a sanity review

#

The other concern is django-environ. Many people saying that it doesn't support Django 3.0 but it seems to work when I tried it. I tried to ask for clarification on what doesn't work but never got a response.
@tawdry vapor

If you're worried about this, we could easily get rid of that dependency too

#

it's literally being used for 4 lines of code

#

env = environ.Env(
    DEBUG=(bool, False),
    SITE_SENTRY_DSN=(str, "")
)

#

that's all

tawdry vapor Jul 14, 2020, 10:24 PM

#

Well, less dependencies is better

crude gyro Jul 14, 2020, 10:25 PM

#

I don't fully understand this plugin but I suspect that's just default values

#

oh wait, it does something weird in addition to that. okay.

#

never mind

tawdry vapor Jul 14, 2020, 10:26 PM

#

I don't understand what this fixes but apparently 5 people agree https://github.com/joke2k/django-environ/issues/239#issuecomment-606245487

GitHub

Support Django 3.0 · Issue #239 · joke2k/django-environ

crude gyro Jul 14, 2020, 10:28 PM

#

wait.. pathlib support - 2 as a way of moving up two directory levels?

#

news to me

#

that's pretty hot

brazen charm Jul 14, 2020, 10:29 PM

#

I don't think that's from pathlib

crude gyro Jul 14, 2020, 10:29 PM

#

maybe it's an environ thing then

#

yeah pathlib does not

tawdry vapor Jul 14, 2020, 10:30 PM

#

I think it's broken if trying to read from a file

crude gyro Jul 14, 2020, 10:30 PM

#

yeah

#

which we don't.

tawdry vapor Jul 14, 2020, 10:30 PM

#

But we rely on pipenv to do this so we don't care

crude gyro Jul 14, 2020, 10:31 PM

#

well, I do actually set my DEBUG env var in a .env file

#

but you're saying that pipenv will load that into the environment anyway

#

so it doesn't matter

tawdry vapor Jul 14, 2020, 10:32 PM

#

Yeah pipenv reads .env

crude gyro Jul 14, 2020, 10:32 PM

#

yeah

#

okay

brazen charm Jul 14, 2020, 10:32 PM

#

The repos seem a bit more active lately, anyone mind also looking at https://github.com/python-discord/bot/pull/927 ?

crude gyro Jul 14, 2020, 10:32 PM

#

then this doesn't affect us, if that's the only problem

tawdry vapor Jul 14, 2020, 10:33 PM

#

I just realised how shit that issue is. Vague title, no description, no comment clarifies what's wrong

#

And just a bunch of thumbs up

crude gyro Jul 14, 2020, 10:33 PM

#

yes

#

I'll take a look now, @brazen charm

#

okay @tawdry vapor, so the django-crispy-bulma blocker is gonna be gone soon, we don't need to care about django-environ, your last concern was something to do with.. empty lists? can you elaborate on that?

tawdry vapor Jul 14, 2020, 10:48 PM

#

Some models that may need to allow empty lists might not allow them anymore

#

One of the commit messages had details

#

Need to go over and ensure FKs allow empty lists if they need to be allowed, since DRF fixed a big and now we have to be more explicit with allowing empty lists.

crude gyro Jul 14, 2020, 10:59 PM

#

right, I remember running into that when I was migrating to Django 3 myself

#

but I think that's a problem you'd see at startup

#

not 100% confident though

#

but when I migrated, I just tried to run the app and it kept crashing with all the stuff I needed to fix. So fix, run again, fix, run again, fix, everything was fine

tawdry vapor Jul 14, 2020, 11:05 PM

#

I don't think it'd be seen at start up

#

Not for our API at least

clever wraith Jul 15, 2020, 3:13 AM

#

how does the bot keep anchors in the YAML file?

#

im assuming the config can be modified within the bot, right?

tawdry vapor Jul 15, 2020, 3:14 AM

#

No, not really

#

It's technically possible with an eval but there's no "official" feature for modifying config values

#

Our config system is not that good. We want to re-do it

clever wraith Jul 15, 2020, 3:17 AM

#

ah, ok. i have a yaml file, that can be roundtripped (ruamel.yaml), but i also want to use it in a config object, but i have no clue how i'd save it

#

guess i'll stick with accessing config values as a dict then

green mesa Jul 15, 2020, 4:02 AM

#

Sorry if this is a stupid question I am new to git I am not able to find which issues are still open of seasonal bot I wnt to contribute to seasonal bot repo at beginner level

#

All issue seems to have been solved😅

tawdry vapor Jul 15, 2020, 4:13 AM

#

Anything without the WIP label and/or someone assigned should be available

green mesa Jul 15, 2020, 4:16 AM

#

Ok ty

neon phoenix Jul 15, 2020, 10:55 AM

#

quick question: are you using psycopg2 or asyncpg?

crude gyro Jul 15, 2020, 10:58 AM

#

for our site?

neon phoenix Jul 15, 2020, 11:01 AM

#

site and bot

hardy gorge Jul 15, 2020, 11:06 AM

#

Our bot does not communicate with the database directly

crude gyro Jul 15, 2020, 11:29 AM

#

the site does, and uses psycopg2

#

or, well, it uses Django's ORM, and Django uses psycopg2

#

with Django 3.x well on its way into asynchronicity, though, it's quite possible that it will support asyncpg in the future

#

in which case we'd be happy to make use of that.

#

but right now there's no support

cold moon Jul 15, 2020, 12:45 PM

#

This reminded me that Django will get async views support in this summer I think 🤩

green mesa Jul 16, 2020, 4:50 PM

#

it will be cool if in resource page exercises will be added

#

can we have some?

#

😄

patent pivot Jul 16, 2020, 4:53 PM

#

you can always propose them at https://github.com/python-discord/meta @green mesa

GitHub

python-discord/meta

Issue tracker for suggestions and other questions relating to our community - python-discord/meta

green mesa Jul 16, 2020, 4:53 PM

#

ok ty

clever wraith Jul 17, 2020, 3:47 AM

#

what's defcon and how is it used?

#

it looks like a server protection -- just autokicking new members?

patent pivot Jul 17, 2020, 3:47 AM

#

@clever wraith autokicking new users

#

defcon of 1 day means any account with age <1 day is kicked

clever wraith Jul 17, 2020, 3:48 AM

#

oh so thats all it is?

patent pivot Jul 17, 2020, 3:48 AM

#

yes

sullen phoenix Jul 17, 2020, 3:48 AM

#

soon™️ it will be much more

patent pivot Jul 17, 2020, 3:48 AM

#

yeah

clever wraith Jul 17, 2020, 3:49 AM

#

and i noticed its not normally supposed to be turned on manually ("only do this if you know what you are doing")

#

what triggers it?

patent pivot Jul 17, 2020, 3:49 AM

#

it is turned on manually

#

!defon

stable mountainBOT Jul 17, 2020, 3:49 AM

#

defconenabled DEFCON enabled.

patent pivot Jul 17, 2020, 3:49 AM

#

!defoff

stable mountainBOT Jul 17, 2020, 3:49 AM

#

defcondisabled DEFCON disabled.

patent pivot Jul 17, 2020, 3:49 AM

#

¯_(ツ)_/¯

clever wraith Jul 17, 2020, 3:50 AM

#

oogh

📎 unknown.png

#

that line seems to imply there's an automatic trigger, and the manual one isnt normally supposed to be used

patent pivot Jul 17, 2020, 3:53 AM

#

not sure how you are inferring that

#

the "be sure you know what you're doing!" is because it's... y'know... kicking our new users lol

clever wraith Jul 17, 2020, 3:54 AM

#

well i just interpreted it as "only manually do this if you know what you're doing, otherwise let someone else handle it"

#

but that was when i thought it was more than just kicking new people

tawdry vapor Jul 17, 2020, 5:33 AM

#

I need some advice on code I'm writing

#

I'm writing a decorator. It's meant to decorator instance methods.

#

The decorator relies on a dictionary existing in the instance. The dictionary is internal, as in, it's only meant to be used by the decorator.

#

What is a good design to ensure the dict will exist in the instance?

#

My first design is a mixin, but it feels clunky to have to subclass something. The decorator will also be misleading since it'll have to be a static method, but it would fail if ever called outside something that's subclassing the mixin.

#

My other idea is to "inject" the dict into the instance if it sees the attribute does not exist yet. However, I worry that being so inexplicit could lead to unexpected results for users unless they're familiar with the internals of the decorator.

#

I suppose it's not too much different than the mixin.

hardy gorge Jul 17, 2020, 5:49 AM

#

I take it you're planning to use the same decorator on multiple methods of the class and they should have access to the same shared dictionary within each instance

tawdry vapor Jul 17, 2020, 5:49 AM

#

Yes

#

It's basically going to be the locked decorator, but cross-function support

#

Locking by an ID

exotic ember Jul 17, 2020, 5:54 AM

#

have your decorator access a property? any dictionary injecting would then be in your class instead (I have no idea if I understand your problem)

tawdry vapor Jul 17, 2020, 5:55 AM

#

Sorry I don't understand the question

#

Here's the code, if it helps https://paste.pythondiscord.com/qufifotita.py

#

I'm considering create a dict of WeakValueDictionary as a module-scoped variable, rather than storing them in instances of classes. That way, this decorator could work across instances or even on normal functions.

#

Though I don't currently need it to support such feature

exotic ember Jul 17, 2020, 5:59 AM

#

I was thinking having your locks be accessible through a property, and have the property deal with whether or not the lock exists

tawdry vapor Jul 17, 2020, 6:01 AM

#

Doesn't the dict still need to exist though?

hardy gorge Jul 17, 2020, 6:03 AM

#

I've made something similar for Rattlesnake, but that had the advantage of being bound to a Redisobject instance

#

That means the lock can be part of the thing it's trying to lock and the methods are decorated by a method on the cache instance

tawdry vapor Jul 17, 2020, 6:14 AM

#

Do you all think having a dict of dicts is a good idea?

#

I'm playing with it right now

hardy gorge Jul 17, 2020, 6:26 AM

#

Looking at your function, the point is to just cancel anything else decorated with the same id_ while something is already running

tawdry vapor Jul 17, 2020, 6:35 AM

#

Yes

tawdry vapor Jul 17, 2020, 6:54 AM

#

This is what I have now. Haven't tested any of it.

#

https://paste.pythondiscord.com/bofifahota.py

#

Don't know if what I am doing is stupid

#

Will call it for the night though

green mesa Jul 17, 2020, 10:57 AM

#

How py checks for which lib we are trying to fetch docs?

#

Like it fetched !doc asyncio also

#

And !doc discord.ext.command also?

#

My question is how bot knows which tag belongs to which lib?

patent pivot Jul 17, 2020, 11:03 AM

#

@green mesa well, you are providing the name no?

#

we pull the docs from several packages such as the stdlib, discord.py, arcade and so on

#

they publish their contents like "my contents contain a symbol called asyncio.sleep"

green mesa Jul 17, 2020, 11:24 AM

#

Ok

brazen charm Jul 17, 2020, 6:29 PM

#

Would this channel be alright for some design questions around code for a feature, or should I get a help channel?

crude gyro Jul 17, 2020, 6:35 PM

#

no, that sounds fine for this channel provided it's a feature for one of our projects

brazen charm Jul 17, 2020, 6:46 PM

#

Not workign code since some uneeded parts were deleted and otehrs weren't working to begin with, but for this method here https://github.com/Numerlor/bot/blob/0f6172846f6b54dd39ef95a86495180ac1d5a4d7/bot/cogs/doc.py#L386-L414 does this look as a viable approach (not minding the long lines)?
What I needed is the same behaviour that's in find_elements_until_tag for those 4 bs4 methods so I was aiming for something that's wouldn't just be copying the body, and keeping the caller interface clearer without the need to pass the methods itself; later I'm planning to move this to a separate class that would just do the parsing after I figure hwo one other thing should behave

#

And also wondering if the BS4FindManyMethod callback protocol looks okay

#

Maybe a normal factory would be better at this point to get rid of some of the parials and staticmethod calls but then I'm not sure if it should stay in the class where the methods are defined

tawdry vapor Jul 17, 2020, 7:32 PM

#

This ultimately seems like a partial vs no partial question

#

The other way to do these is ```py
def find_next_children_until_tag(...):
stuff = find_all(...)
return find_next_children_until_tag(stuff, ...)

#

That's a bit more redundant but also more explicit than partials.

#

I think the partials are fine

#

Though the staticmethod stuff is a bit ugly

#

Not a big deal

#

I don't really know what BS4FindManyMethod is for.

#

That's kind of getting overkill for type annotations, considering this seems like an internal function currently

brazen charm Jul 17, 2020, 7:42 PM

#

I think this looks a bit better

    def find_elements_until_tag_factory(func: BS4FindManyMethod):
        def find_elements_until_tag(
                ...,
        ) -> t.Optional[str]:
            """
            ...
            """
            ...
            return elements
        return staticmethod(find_elements_until_tag)

    find_next_children_until_tag = find_elements_until_tag_factory(functools.partial(BeautifulSoup.find_all, recursive=False))
    find_previous_children_until_tag = find_elements_until_tag_factory(BeautifulSoup.find_all_previous)
    find_next_siblings_until_tag = find_elements_until_tag_factory(BeautifulSoup.find_next_siblings)
    find_previous_siblings_until_tag = find_elements_until_tag_factory(BeautifulSoup.find_previous_siblings)
    find_elements_until_tag_factory = staticmethod(find_elements_until_tag_factory)

But as I said I'm not sure if the factory staying in the class would be nice.

Do you think a Callable with an explanation in the docstring would be good for the typehint? I wanted something that'd be clear but I don't think it particularly matters to the static checkers with bs4 not doing hints anywhere so it can just be explained or an alaised typehint

tawdry vapor Jul 17, 2020, 7:44 PM

#

Yeah I think some documentation will be much clearer

brazen charm Jul 17, 2020, 7:44 PM

#

I started the typehint as for a method that accepts the args for the instance and a limit that are used, but then it turned into a whole hint for the methods

tawdry vapor Jul 17, 2020, 7:45 PM

#

It's a neat new feature but it seems overly verbose if you're not using static type checker tools

#

Well, technically your IDE is one but I mean something more like mypy

brazen charm Jul 17, 2020, 8:23 PM

#

Which of the definitions would you say is the best all things considered; partial, normal wrapped funcs or the factory? the normal functions would look a bit nicer decorated with static methods isntead of being normal calls to it, but still feels a bit redundant

tawdry vapor Jul 17, 2020, 8:25 PM

#

Why are the staticmethods needed?

#

Maybe you should just not define them in a class to begin with

#

Perhaps a separate module if it'd seem out of place

brazen charm Jul 17, 2020, 8:27 PM

#

I was planning a separate class for the parsing side of the things that'd accept html and return markdown, but a module doesn't sound so bad either considering I was thinking it'd just be class/static methods

tawdry vapor Jul 17, 2020, 8:28 PM

#

Then I don't think a factory is necessary

#

Also prefer the partials since it's less boilerplate

#

We're not writing a public library meant to be used by hundreds of people so it's acceptable to sacrifice docstrings for each partial

brazen charm Jul 17, 2020, 8:33 PM

#

Only thing I don't particularly like about decoupling it is that I'll have to pass the aiohttp session to the parser if I want to cache soups with a simple cache

tawdry vapor Jul 17, 2020, 8:35 PM

#

You could leave that one method that needs the session in the cog.

brazen charm Jul 17, 2020, 8:40 PM

#

I think the tradeoff of passing it would be worth it here, because leaving it in also means parsing the URL in both modules or passing it along for resolving links and finding the symbol by id in the parser. So, don't particularly like it but it's probably better. But I'll get to that after figuring out other things

#

Thanks for the help

tawdry vapor Jul 17, 2020, 8:42 PM

#

Np

hazy dune Jul 18, 2020, 8:38 AM

#

Some heavy refinements are overdue for whitelisted and blacklisted things. e.g. a few sites that should be blacklisted:

nsfwyoutube
adf.ly
xxxvideos
any links ending in .onion

Blacklisted words:

Sucide (A typo of one of the words up there)
The n word (Like cmon guys this one was obvious)
Spacing out the letters like t h i s

Thanks, Galaxy.

kind flower Jul 18, 2020, 8:39 AM

#

I am pretty sure the n word in there

📎 Screenshot_20200718-103913_GitHub.jpg

hazy dune Jul 18, 2020, 8:40 AM

#

I was about to say xD

#

Ok, then the names of some parts of the male and female body should very much be added

#

And the name of the action they can do... (I’m trying to get the point across whilst still keeping this PG)

#

DM me if this was unclear or you need more obscure words

#

I too have a blacklist of my own

#

*on my bot

#

Also different variations of “grape without the g” should be added, such as adding an r, ing, s, or d on the end

#

Trying to keep this as PG as I can

#

It’s not easy

molten bough Jul 18, 2020, 8:47 AM

#

Onion links shouldn't be banned wholesale imo

#

I mean sure there's some bad stuff on tor, but there's also Facebook and other legit sites

#

It'd be like banning .com

hazy dune Jul 18, 2020, 8:48 AM

#

True, but .onion is quite a bit sketchier

#

Only a select few know how to access them

molten bough Jul 18, 2020, 8:48 AM

#

It's mostly just hard to moderate I'd say

#

Yeah

#

Again, I'm not sure adf.ly is any sketchier than, say, bit.ly - it just also has an ad

#

And trying to maintain a comprehensive list of NSFW sites is.. well..

#

It's not gonna happen

crude gyro Jul 18, 2020, 8:50 AM

#

Ok, then the names of some parts of the male and female body should very much be added
@hazy dune

..why?

hazy dune Jul 18, 2020, 8:51 AM

#

Well, adf.ly is notorious for getting you to download viruses (it’s a common whole-screen pop up ads when you try downloading other things (most commonly seen when downloading OptiFine))

#

@hazy dune

..why?
@crude gyro they’re inappropriate

molten bough Jul 18, 2020, 8:51 AM

#

I know adfly, although they've gotten better lately

#

But you know adfly isn't the only one

#

There's hundreds of domains

crude gyro Jul 18, 2020, 8:51 AM

#

it's not our intention to moderate everything that's "inappropriate"

#

it's our intention to catch hateful interactions

hazy dune Jul 18, 2020, 8:52 AM

#

This is true, but do you really want people talking about it in public chat?

molten bough Jul 18, 2020, 8:52 AM

#

These lists already don't ban terms

#

They're alerts

crude gyro Jul 18, 2020, 8:52 AM

#

they ping all the mods

molten bough Jul 18, 2020, 8:52 AM

#

yeah

crude gyro Jul 18, 2020, 8:53 AM

#

so that we can have a look at the conversation and determine whether we need to take action.

hazy dune Jul 18, 2020, 8:53 AM

#

Well then I’m sure you would like (for moderation purposes) to be pinged when people start discussing it just to be sure.

crude gyro Jul 18, 2020, 8:54 AM

#

many words that describe human anatomy would produce far too many false positives to be worth it

#

how often do you think dick is used on this server to refer to penis versus how many times it's used to refer to a person who is a bit of a jerk?

#

the latter is fine

#

we've added cunt to the list because it's considered a really, really bad word in parts of the world, but then you get australians who just use it to more or less mean "mate"

hazy dune Jul 18, 2020, 8:56 AM

#

Oh.

molten bough Jul 18, 2020, 8:56 AM

#

there's also a billion euphemisms anyway

#

it'd be pretty easy to get around

crude gyro Jul 18, 2020, 8:56 AM

#

so, what we're interested in having on the list are words that are unequivocally bad

#

the n-word is a good example. We don't wanna see that in this community no matter what

#

unless you're posting kanye lyrics or something

hazy dune Jul 18, 2020, 8:58 AM

#

Ok, is the s p a c i n g and st*rr*ng of the words still a good idea to add?

#

Or too far?

molten bough Jul 18, 2020, 8:58 AM

#

I think the cog itself sanitises for that

hazy dune Jul 18, 2020, 8:59 AM

#

I’m tempted to try (as I enjoy finding glitches) but the better part of me says it’s a bad idea

rocky bloom Jul 18, 2020, 8:59 AM

#

plus in 99% of scenarios, a mod can make their own decision

molten bough Jul 18, 2020, 8:59 AM

#

I mean, it's open source

hazy dune Jul 18, 2020, 8:59 AM

#

https://www.github.com/python-discord/bot/tree/master/config-default.yml

GitHub

python-discord/bot

The community bot for the Python Discord community - python-discord/bot

#

Starts at line 263

#

Anyways

molten bough Jul 18, 2020, 9:00 AM

#

Looking at the source, they expand spoilers

crude gyro Jul 18, 2020, 9:00 AM

#

the word filter won't catch stuff that you've s p a c e d o u t, no.

#

we had an issue to do that at some point but I think we ran into more complications and edge cases than we thought were worth dealing with

molten bough Jul 18, 2020, 9:01 AM

#

it's surprisingly difficult to do

rocky bloom Jul 18, 2020, 9:01 AM

#

any word that bypasses the filters can be reported by others to moderators or even seen by one so it doesn't have to fit every scenario

crude gyro Jul 18, 2020, 9:02 AM

#

generally speaking, anything that isn't caught by our filters is reported to us pretty quickly via @slow bone or by a staff member

#

but still, having the filter catch obfuscated tokens isn't a bad idea necessarily

#

if someone opened a really good pull request for it, we'd probably be happy to accept it.

#

but it's not as trivial as it sounds

molten bough Jul 18, 2020, 9:03 AM

#

The kotdis bot just strips out markdown formatting chars, which seems to work fairly well

hazy dune Jul 18, 2020, 9:04 AM

#

I seriously got staff’s attention today xD

#

That’s like... #6?

crude gyro Jul 18, 2020, 9:04 AM

#

not that hard to get our attention

hazy dune Jul 18, 2020, 9:05 AM

#

This is true

#

Ves, why are you the only owner not boosting the server?

hardy gorge Jul 18, 2020, 9:05 AM

#

This is true, but do you really want people talking about it in public chat?
@hazy dune

I think our ideas of where the boundary of "appropriate" lies differs. We are a 13+ community, and parts of human anatomy, in either slang or a more conventional version, don't seem that inappropriate to me unless used very inappropriately.

crude gyro Jul 18, 2020, 9:06 AM

#

Ves, why are you the only owner not boosting the server?
@hazy dune

technically @patent pivot isn't boosting it either, he gets free nitro because he's our discord partnership contact.

#

so we get a free boost

#

besides, we don't need the entire staff to boost

#

we have everything we need

rocky bloom Jul 18, 2020, 9:07 AM

#

out of curiosity, who owns the server?

crude gyro Jul 18, 2020, 9:07 AM

#

we get most of the boost features just by being a partner

#

joseph is currently the registered owner.

hardy gorge Jul 18, 2020, 9:07 AM

#

And that goes for a few other suggestions as well: We're not trying to create an environment where everything is considered inappropriate and that's why we only filter very sensitive or inappropriate terms. In all other situations, it's up to a judgement of the situation. If something inappropriate happens, ping mods or report it to ModMail and we'll figure it out.

crude gyro Jul 18, 2020, 9:07 AM

#

but in every other way than on the paperwork, all three of us do

hazy dune Jul 18, 2020, 9:08 AM

#

Oh also happy Saturday

#

Wait hold on... when is the earliest time in the world right now?

#

Brb Google is calling to me

#

It’s hard to find because you don’t know if it’s 12 PM on Friday or Saturday

#

Ok so unless you live in Niue Time (GMT), then happy Saturday!

hazy dune Jul 18, 2020, 4:37 PM

#

How has no one talked in here for hours?

hardy gorge Jul 18, 2020, 4:37 PM

#

That looks like an astute observeration

hazy dune Jul 18, 2020, 4:45 PM

#

I was concerned Discord wasn’t loading properly

celest charm Jul 18, 2020, 6:34 PM

#

Is the None a known bug?

📎 unknown.png

#

Reconnecting doesn't solve the problem

#

I unlinked my discord account and linked it again, I got this

📎 unknown.png

molten bough Jul 18, 2020, 6:39 PM

#

hm, the None isn't something that showed up when I implemented this

#

but this would be difficult to debug without the database state, and I definitely should not have access to that

#

also, uh

#

how did you unlink your discord account?

#

that's not supposed to be possible without entirely deleting your account

#

📎 unknown.png

celest charm Jul 18, 2020, 6:42 PM

#

I meant that I logged out

molten bough Jul 18, 2020, 6:42 PM

#

that's what I get

#

Ah right

#

Do you have a real name set on GH?

celest charm Jul 18, 2020, 6:43 PM

#

nope

#

I am decorator-factory

molten bough Jul 18, 2020, 6:43 PM

#

that explains the None, then

#

yeah

#

hm

celest charm Jul 18, 2020, 6:44 PM

#

I don't see a reason to display the real name, just display the handle

#

(I remember how I'm called)

molten bough Jul 18, 2020, 6:44 PM

#

I don't recall why I display the real name

#

it might have been a library thing, I'm not sure

#

but that's cosmetic, I'm more concerned about that 500

celest charm Jul 18, 2020, 6:50 PM

#

Maybe there's some kind of error log?

hardy gorge Jul 18, 2020, 6:58 PM

#

I haven't found anything overly exciting in the logs yet

#

[pid: 37|app: 0|req: 41762/59713] 162.158.88.49 () {70 vars in 1744 bytes} [Sat Jul 18 18:35:16 2020] GET /accounts/discord/login/callback/?code=...&state=... => generated 145 bytes in 491 msecs (HTTP/1.1 500) 6 headers in 239 bytes (1 switches on core 0)
[pid: 37|app: 0|req: 41805/59756] 162.158.88.49 () {72 vars in 1528 bytes} [Sat Jul 18 18:35:59 2020] GET /accounts/discord/login/callback/?code=...&state=... => generated 145 bytes in 204 msecs (HTTP/1.1 500) 5 headers in 154 bytes (1 switches on core 0)

celest charm Jul 18, 2020, 7:02 PM

#

My IP starts with 178, if that matters

molten bough Jul 18, 2020, 7:07 PM

#

Weird, you'd think there'd be a traceback

celest charm Jul 18, 2020, 7:07 PM

#

maybe grep 178?

molten bough Jul 18, 2020, 7:09 PM

#

I think it probably gets cloudflare IPs

celest charm Jul 18, 2020, 7:24 PM

#

yep

hardy gorge Jul 18, 2020, 7:34 PM

#

These two entries have the same callback code that you had in the URL in the address bar of your screenshot

celest charm Jul 18, 2020, 7:40 PM

#

And there's no traceback?

tawdry vapor Jul 18, 2020, 7:43 PM

#

If you're looking in Sentry, the error may be ignored.

#

Though 500s are ignored more so for the bot than the site

hardy gorge Jul 18, 2020, 7:46 PM

#

There's nothing in Sentry, as far as I can tell, including ignored

#

The logs for site don't show a traceback to go with that 500

molten bough Jul 18, 2020, 8:23 PM

#

Very odd

#

Do you think allauth is intentionally returning a 500, maybe?

tawdry vapor Jul 18, 2020, 9:09 PM

#

Hey everyone. I implemented something to cancel other commands if a resource is already in-use. For example, it will cancel a delete if a reminder is in the middle of being sent or edited.

#

Should the commands be aborted silently?

#

Or should some message be sent e.g. "this resource is already in use; please try again later"

woeful thorn Jul 18, 2020, 11:53 PM

#

Probably not silently

green mesa Jul 19, 2020, 11:26 AM

#

c_time = datetime.utcnow()
print(c_time)
f_time = c_time+timedelta(minutes=mute_time)
print(f_time)

#

this is giving me current time in utc

#

but how py bot convert time in user timezone

patent pivot Jul 19, 2020, 11:27 AM

#

it doesn't

#

it gives it to discord in embed time stamps sometimes and discord does the conversion

green mesa Jul 19, 2020, 11:28 AM

#

but how it add time in description

#

📎 m.PNG

#

its in description

tough imp Jul 19, 2020, 11:39 AM

#

don't think thats in user timezone

subtle kraken Jul 19, 2020, 11:43 AM

#

pretty sure its UTC based

green mesa Jul 19, 2020, 11:51 AM

#

@subtle kraken thats in my timezone

#

IST

subtle kraken Jul 19, 2020, 11:51 AM

#

according to source code it uses UTC

#

there is no way of even knowing timezone of a user

green mesa Jul 19, 2020, 11:52 AM

#

i wnt to test again

#

can u mute me

#

and then unmute

#

i wnt to check once

subtle kraken Jul 19, 2020, 11:52 AM

#

You can set up test bot and do that yourself, I don't apply false infractions

green mesa Jul 19, 2020, 11:52 AM

#

well ok

#

i tried with bot

#

but that bot is giving time in utc

#

but embed.timestamp give time in user current timezone

subtle kraken Jul 19, 2020, 11:53 AM

#

because what you sent in the screenshot is UTC based

#

Embed.timestamp is something local client formats to its local time

green mesa Jul 19, 2020, 11:54 AM

#

so can i get time from this only

#

i dont wnt to add on embed

#

just time i need

tough imp Jul 19, 2020, 11:56 AM

#

I dont think its possible to get another user's timezone, if thats what you're after

#

the conversion in the embed footer is most likely done locally

#

either way, the API doesn't expose such information about users

crude gyro Jul 19, 2020, 12:17 PM

#

yeah, it's done locally

#

in the client

green mesa Jul 19, 2020, 3:34 PM

#

means py bot also sends time in utc only

#

ok got u

green oriole Jul 19, 2020, 4:57 PM

#

Seems like the cat n°418 is broken

#

.statuscat 418

#

Okay well, .statuscat 418 gaves an error, although this cat exists https://http.cat/418

brazen charm Jul 19, 2020, 5:00 PM

#

It's not in the http module which is used to validate the codes

green oriole Jul 19, 2020, 5:03 PM

#

That's a shame 😔

brazen charm Jul 19, 2020, 5:03 PM

#

3.9 adds it fwiw

green oriole Jul 19, 2020, 5:05 PM

#

Indeed https://docs.python.org/3.9/whatsnew/3.9.html#http

brazen charm Jul 20, 2020, 12:52 AM

#

How complete would you say commits should be? I'm reworking some of the main methods in a module. Replacing them all at once would be a big commit, although it would be still about one thing; but they also aren't really compatible with the new design so the code wouldn't work if I went in steps without introducing unrelated changes just for that

celest charm Jul 20, 2020, 12:55 AM

#

http.cat doesn't support 102 and 103

#

also 203

#

boy, that site is incomplete

tawdry vapor Jul 20, 2020, 1:39 AM

#

@brazen charm Speaking only for myself, I don't think it's necessary to ensure every commit works and runs. After all, you're in the middle of development. It's fine to commit incomplete work, as long as you could say some subset of that is complete for that commit.

#

Trying to make every commit work just adds too much overhead

#

Also, big commits are fine. Not everyone works incrementally. It just has to be within reason.

#

For example, I reviewed Lemon's PR today and he had a commit that added an entire cog with helper functions and some commands.

#

It could have been separate commits for each function, or maybe a separate one for all the commands, but ultimately, that doesn't have too much benefit and may be inconvenient for him to have worked like that.

brazen charm Jul 20, 2020, 1:46 AM

#

I do prefer them more separate when changing things instead of only adding new ones as it provides the opportunity to exaplin them a bit with the changes grouped with only the relevant commit message

#

I think almost every commit I've done so far would work when checked out, at least as code if not functionally, but that would be a bit of a pita in this case.

green mesa Jul 20, 2020, 4:57 AM

#

Can we have name of author who reply when modmail message bck

#

So we can know who replied to us

sullen phoenix Jul 20, 2020, 5:16 AM

#

you will know who replies, unless they use an anonymous reply

#

or it's a close message

green mesa Jul 20, 2020, 9:51 AM

#

i wnt to know of close message f1re

patent pivot Jul 20, 2020, 11:43 AM

#

@green mesa kind of irrelevant information

#

we don't write the modmail bot so if you want that you can PR it to https://GitHub.com/kyb3r/modmail

GitHub

kyb3r/modmail

A feature rich discord Modmail bot. Contribute to kyb3r/modmail development by creating an account on GitHub.

green mesa Jul 20, 2020, 11:44 AM

#

ok

#

i love this server and all bots this server got

#

i learnt py in this server only

subtle kraken Jul 20, 2020, 2:40 PM

#

@cold moon Hi, I've noticed that your PR for 1.3.0 functionality update is still open, however it has conflicts, do you think you could resolve those conflicts so the PR is merge-able?

timid sentinel Jul 20, 2020, 2:44 PM

#

I'm not sure why I am getting this error, Error: the command flake8 could not be found within PATH or Pipfile's [scripts]., when running the precommit hooks in pycharm for the bot

#

All the other checks pass, and everything else seems to work fine

brazen charm Jul 20, 2020, 2:46 PM

#

Do you have it on path?

timid sentinel Jul 20, 2020, 2:46 PM

#

running which flake8 in the pycharm terminal gives .../.local/share/virtualenvs/bot-r6FnQRJj/bin/flake8 So i'd assume that's what it should be using?

brazen charm Jul 20, 2020, 2:47 PM

#

does pipenv run flake8 work?

timid sentinel Jul 20, 2020, 2:48 PM

#

This is all it gives me```
$ pipenv run flake8
Courtesy Notice: Pipenv found itself running within a virtual environment, so it will automatically use that environment, instead of creating its own for any project. You can set PIPENV_IGNORE_VIRTUALENVS=1 to force pipenv to ignore that environment and create its own instead. You can set PIPENV_VERBOSITY=-1 to suppress this warning.
Loading .env environment variables…

brazen charm Jul 20, 2020, 2:50 PM

#

Is there a timeout after that where it's running flake8 or does it just stop at the .env?

#

Not sure what the issue could be, but maybe something with the virtualenv not being pipenv's environment that you got a notice for

timid sentinel Jul 20, 2020, 2:51 PM

#

It pauses for a few seconds after Loading .env environment variables… and then just goes back to the prompt.

#

I'll play around with it for a bit and see

tawdry vapor Jul 20, 2020, 2:56 PM

#

Yeah it's bugged for me and ves too at least

#

We had to edit the hook and set an env var

#

I think it was the ignore virtual envs one

#

It's cause pipenv fixed a bug we apparently relied on

timid sentinel Jul 20, 2020, 3:01 PM

#

Ha, well it's nice to know it isn't just me

#

What did you edit in the hook?

#

Actually I think I've managed to get something working

tawdry vapor Jul 20, 2020, 3:06 PM

#

I just did os.putenv to set that env var to 1

#

I think...

timid sentinel Jul 20, 2020, 3:17 PM

#

Ok, I made the pull request, and I think I did everything right 🤞

#

Here's hoping I didn't mess up

subtle kraken Jul 20, 2020, 3:24 PM

#

congrats on possibly having fastest approved PR

#

oh well https://github.com/python-discord/bot/pull/1060/checks?check_run_id=890483302

timid sentinel Jul 20, 2020, 3:25 PM

#

OH yeah, that's just testament to the extremely high quality of the code I wrote

subtle kraken Jul 20, 2020, 3:26 PM

#

@tawdry vapor just wanna confirm, ^ doesn't really matter does it?

timid sentinel Jul 20, 2020, 3:26 PM

#

What did I do...

subtle kraken Jul 20, 2020, 3:26 PM

#

missed analysis pithink

#

not exactly bad since github doesn't mark it as bad but it doesn't mark as good

tawdry vapor Jul 20, 2020, 3:26 PM

#

No

subtle kraken Jul 20, 2020, 3:27 PM

#

Will merge it then if thats okay by you

tawdry vapor Jul 20, 2020, 3:27 PM

#

sure

#

I wouldnt bother with the merge commits

#

Not for something like this at least

subtle kraken Jul 20, 2020, 3:28 PM

#

I like branches updated

tawdry vapor Jul 20, 2020, 3:28 PM

#

I don't

#

Messy commit history

subtle kraken Jul 20, 2020, 3:28 PM

#

so just merge it then in future?

tawdry vapor Jul 20, 2020, 3:28 PM

#

It's already a mess anyway though

#

Maybe

#

Use your discretion

subtle kraken Jul 20, 2020, 3:28 PM

#

will do so next time I suppose