#dev-contrib | Python | Page 31

hardy gorge Oct 22, 2019, 5:27 PM

#

pydis_site/settings.py:51:1: S105 Possible hardcoded password: 'yellow polkadot bikini'

#

that's probably why

green oriole Oct 22, 2019, 5:27 PM

#

Env?

hardy gorge Oct 22, 2019, 5:29 PM

#

Nah, I don't see any use in making this a required step in the set-up

#

(adding an environment key for that)

#

I'll just add a specific ignore

crude gyro Oct 22, 2019, 5:48 PM

#

ah yes that'll be why then.

hardy gorge Oct 22, 2019, 5:49 PM

#

There's now this: https://github.com/python-discord/site/pull/297

GitHub

Set SECRET_KEY to a constant in DEBUG mode by SebastiaanZ · Pull ...

The SECRET_KEY in debug mode was auto-generated each time the config file was loaded. This had the unwanted side-effect of requiring testers to login again after every change they made, since the a...

mellow hare Oct 22, 2019, 5:49 PM

#

~~🎶 That she wore for the first time today 🎶~~

last patio Oct 22, 2019, 5:59 PM

#

I think it would be preferable to keep the current behaviour as a fall back and use one in the env var if set

#

If we accidentally happen to enable debug in prod (or django-environ reads something wrongly, or salt messes up, or the if condition is wrong...) then we will still have a secure secret key, for one

#

That way people who want to preserve sessions can set it

#

or we have the debug setup write the randomly generated key somewhere on first start and then load from there, if you want full convenince

molten bough Oct 22, 2019, 6:10 PM

#

How does this look?

📎 unknown.png

green oriole Oct 22, 2019, 6:10 PM

#

Pinky?

molten bough Oct 22, 2019, 6:10 PM

#

that's the current danger colour

hardy gorge Oct 22, 2019, 6:10 PM

#

looks good to me

green oriole Oct 22, 2019, 6:11 PM

#

It look pretty good (appart from the pink)

molten bough Oct 22, 2019, 6:11 PM

#

the danger colour is based on bulma's red with a saturation of 80

#

it was very.. in your face before

brazen charm Oct 22, 2019, 6:11 PM

#

Maybe a tad more red

hardy gorge Oct 22, 2019, 6:11 PM

#

I think the color looks good

molten bough Oct 22, 2019, 6:11 PM

#

The colours were approved in an earlier PR

#

they affect a lot more than just buttons

green oriole Oct 22, 2019, 6:11 PM

#

That doesn't look.. Dangerous

hardy gorge Oct 22, 2019, 6:12 PM

#

it has an appropriate contrast the rest of the site

molten bough Oct 22, 2019, 6:12 PM

#

📎 unknown.png

#

anyway the colour is besides the point

hardy gorge Oct 22, 2019, 6:13 PM

#

yeah

molten bough Oct 22, 2019, 6:13 PM

#

Mobile view

📎 unknown.png

hardy gorge Oct 22, 2019, 6:13 PM

#

I think the lay-out looks good

molten bough Oct 22, 2019, 6:14 PM

#

Good stuff

#

just need to get that disconnection working

brazen charm Oct 22, 2019, 6:14 PM

#

any of the people that did the scraping stuff on the bot around?

#

bs4 is slowly making me lose my mind

green oriole Oct 22, 2019, 6:17 PM

#

Scraping stuff?

mellow hare Oct 22, 2019, 6:17 PM

#

The doc cog scrapes the python site's docs

green oriole Oct 22, 2019, 6:17 PM

#

Oh yeah

hardy gorge Oct 22, 2019, 6:17 PM

#

What's making you lose your mind, @brazen charm?

green oriole Oct 22, 2019, 6:18 PM

#

_It seem a bit against rule 5 😄 _

mellow hare Oct 22, 2019, 6:18 PM

#

Scraping itself isn't bad. It's a tool just like anything else

#

It's used all over

#

It's just when it's used on sites that don't allow it that it becomes a problem

hardy gorge Oct 22, 2019, 6:18 PM

#

We're using the intersphinx connections specifically meant for this

#

Anyway, what's driving you mad, @brazen charm?

#

oh wait, double ping

brazen charm Oct 22, 2019, 6:21 PM

#

soup.find_next("a", attrs={"class": "headerlink"})
getting different results than in terms of the tag hierarchy (or how to call it)
soup.find(id="module-numpy").find_next("a", attrs={"class": "headerlink"})
When there is only one headerlink in the doc

molten bough Oct 22, 2019, 6:22 PM

#

📎 settings.mp4

#

I fixed the disconnect message to make it consistent with allauth's connect message

#

Any thoughts? Is the GH button colour okay?

crude gyro Oct 22, 2019, 6:25 PM

#

I don't like the pink buttons very much

#

and for the connections, maybe icons and bold names?

#

although you got an icon on the connect button.. hmm.

molten bough Oct 22, 2019, 6:26 PM

#

Could do both

crude gyro Oct 22, 2019, 6:26 PM

#

not sure I like the idea of a disconnect discord button that is permanently unclickable

molten bough Oct 22, 2019, 6:26 PM

#

📎 unknown.png

crude gyro Oct 22, 2019, 6:27 PM

#

yeah that looks pretty good

#

but the delete account button, hm, I guess I think that button should probably white on traffic light red

#

pastels doesn't really communicate delete

molten bough Oct 22, 2019, 6:28 PM

#

That's basically the bulma default, yeah

crude gyro Oct 22, 2019, 6:28 PM

#

yeah and I know we redefined some of those.

#

or all of them.

#

which is nice for the notifications

#

but not sure it works for this.

molten bough Oct 22, 2019, 6:29 PM

#

📎 unknown.png

crude gyro Oct 22, 2019, 6:29 PM

#

@wild ridge @tough imp @glass pecan you guys have a good eye for design. chime in.

hardy gorge Oct 22, 2019, 6:30 PM

#

I personally think the pink colors are good enough in communicating what's going on + we have a special confirmation page with a type-over after it

#

I don't like those red colors in our design

molten bough Oct 22, 2019, 6:30 PM

#

well not for unlinking, but for deleting we do

#

these reds are super in your face imo

#

perhaps too much

#

but we could change the saturation of the pastel red

#

haha, I set it to 100 but now it just looks like the buttons are disabled

#

📎 unknown.png

crude gyro Oct 22, 2019, 6:31 PM

#

that's very bubblegum

tough imp Oct 22, 2019, 6:31 PM

#

I agree that the redest red communicates the intent a lot better

crude gyro Oct 22, 2019, 6:31 PM

#

go a little darker instead maybe

green oriole Oct 22, 2019, 6:32 PM

#

Can you try with a medium blue(ish) color too?

molten bough Oct 22, 2019, 6:32 PM

#

for danger?

glass pecan Oct 22, 2019, 6:32 PM

#

lol

crude gyro Oct 22, 2019, 6:32 PM

#

blue is a very strange choice for this that I don't really see a point in trying.

glass pecan Oct 22, 2019, 6:33 PM

#

https://discordapp.com/channels/267624335836053506/635950537262759947/636269822904238080

#

this isn't too bad

green oriole Oct 22, 2019, 6:33 PM

#

Oh yeah that's a special button

glass pecan Oct 22, 2019, 6:33 PM

#

saturated red makes sense

tough imp Oct 22, 2019, 6:33 PM

#

I agree with Scragly that is the best

glass pecan Oct 22, 2019, 6:33 PM

#

at least that's my feedback regarding the colour

molten bough Oct 22, 2019, 6:33 PM

#

📎 unknown.png

#

The default bulma red almost hurts my eyes in this setup

mellow hare Oct 22, 2019, 6:33 PM

#

@brazen charm I'm not sure if here is the best place to ask about beautifulsoup. Would probably still be better served in the main help channels

crude gyro Oct 22, 2019, 6:33 PM

#

how about a slightly darker version of the default bulma red

molten bough Oct 22, 2019, 6:33 PM

#

okay

crude gyro Oct 22, 2019, 6:33 PM

#

just to test it out

brazen charm Oct 22, 2019, 6:34 PM

#

Yeah wanted something about the style around it too but that's what's keeping me occupied now

molten bough Oct 22, 2019, 6:34 PM

#

Maybe that's a bit too far?

📎 unknown.png

glass pecan Oct 22, 2019, 6:34 PM

#

no that's good to me

crude gyro Oct 22, 2019, 6:35 PM

#

I like that

molten bough Oct 22, 2019, 6:35 PM

#

I kind of like it too

green oriole Oct 22, 2019, 6:35 PM

#

Yeah it seem pretty good

glass pecan Oct 22, 2019, 6:35 PM

#

can i give a little feedback on the page itself?

molten bough Oct 22, 2019, 6:35 PM

#

Of course

tough imp Oct 22, 2019, 6:35 PM

#

It helps a lot to see the page as a whole

molten bough Oct 22, 2019, 6:35 PM

#

📎 unknown.png

crude gyro Oct 22, 2019, 6:35 PM

#

hmm. that red really disagrees with the blurple nav. not sure what to do about that.

molten bough Oct 22, 2019, 6:36 PM

#

Bearing in mind, this will have changed the rest of the reds

#

📎 unknown.png

green oriole Oct 22, 2019, 6:36 PM

#

Maybe a bit more saturated red?

molten bough Oct 22, 2019, 6:36 PM

#

darker, but more saturated? okay..

#

📎 unknown.png

#

It's kind of a tomato colour

#

I don't hate it though

green oriole Oct 22, 2019, 6:38 PM

#

I prefer this one

brazen charm Oct 22, 2019, 6:38 PM

#

how does the tomato look outside of buttons?

green oriole Oct 22, 2019, 6:38 PM

#

It match more the pydis blue

molten bough Oct 22, 2019, 6:38 PM

#

📎 unknown.png

tough imp Oct 22, 2019, 6:38 PM

#

I still like this the most https://discordapp.com/channels/267624335836053506/635950537262759947/636269822904238080

molten bough Oct 22, 2019, 6:38 PM

#

I have a hard time seeing that on the page, honestly

#

my eyes don't like it

green oriole Oct 22, 2019, 6:39 PM

#

Which one they don't like?

molten bough Oct 22, 2019, 6:39 PM

#

the one kwzrd linked, the bulma default

#

let me make the tomato a bit brighter

#

📎 unknown.png

#

📎 unknown.png

#

I don't think that's half bad

green oriole Oct 22, 2019, 6:40 PM

#

Can you create a new color only for button and keep the old one for the rest?

molten bough Oct 22, 2019, 6:40 PM

#

I have to go help make dinner, but I'll be back after, will be on Discord either way

#

Not easily

glass pecan Oct 22, 2019, 6:42 PM

#

i like the latest one, but i also like rediculously strong reds

#

@crude gyro what do you think of that one?

crude gyro Oct 22, 2019, 6:43 PM

#

I'm thinking more like #D63852

#

and now I wish we had a function to display a hex

glass pecan Oct 22, 2019, 6:43 PM

#

.colour D63852

crude gyro Oct 22, 2019, 6:44 PM

#

yeah. that.

#

we don't have that, do we?

hardy gorge Oct 22, 2019, 6:44 PM

#

We don't

glass pecan Oct 22, 2019, 6:44 PM

#

its loading

crude gyro Oct 22, 2019, 6:44 PM

#

if it's loading

it's very slow
why didn't they put is typing...

glass pecan Oct 22, 2019, 6:44 PM

#

📎 unknown.png

#

there

#

lol

#

scragly bot wins again

brazen charm Oct 22, 2019, 6:45 PM

#

long response times, bad bot scargly

crude gyro Oct 22, 2019, 6:45 PM

#

context

glass pecan Oct 22, 2019, 6:45 PM

#

its doing more than seasonalbot for colour previews

crude gyro Oct 22, 2019, 6:45 PM

#

📎 unknown.png

glass pecan Oct 22, 2019, 6:45 PM

#

yes i like that

#

works well

#

groovy even

#

so did you just edit this in photoshop

crude gyro Oct 22, 2019, 6:46 PM

#

no. gpaint

#

so, even worse.

glass pecan Oct 22, 2019, 6:46 PM

#

never heard of it

#

so must have been enjoyable

woeful thorn Oct 22, 2019, 6:46 PM

#

the g stands for gpaint

glass pecan Oct 22, 2019, 6:46 PM

#

could be worse

molten bough Oct 22, 2019, 6:46 PM

#

Haha

glass pecan Oct 22, 2019, 6:46 PM

#

could be gimp

hardy gorge Oct 22, 2019, 6:46 PM

#

s/color 1/color 2

glass pecan Oct 22, 2019, 6:46 PM

#

we all know how much you love it

molten bough Oct 22, 2019, 6:46 PM

#

I'll do an actual test when I'm done in a couple hours

glass pecan Oct 22, 2019, 6:47 PM

#

sure, but i still kinda want to give feedback on the page when you're back

#

i suspect i'll be kinda sleepy though

molten bough Oct 22, 2019, 6:47 PM

#

I can take it now, if you like

#

:>

glass pecan Oct 22, 2019, 6:47 PM

#

if you're busy it's fine

molten bough Oct 22, 2019, 6:47 PM

#

I mean I can just screenshot it

glass pecan Oct 22, 2019, 6:47 PM

#

but i'll likely dump my suggestions here

molten bough Oct 22, 2019, 6:47 PM

#

I'm boiling berries

#

Haha

crude gyro Oct 22, 2019, 6:47 PM

#

making some jam?

glass pecan Oct 22, 2019, 6:47 PM

#

nah i want to change the structure

molten bough Oct 22, 2019, 6:48 PM

#

No, FSAI recommendation so I don't get hepatitis

crude gyro Oct 22, 2019, 6:49 PM

#

more like hepatightis

molten bough Oct 22, 2019, 6:49 PM

#

Haha

#

It's because lots of imported frozen berries over the years have been infected

glass pecan Oct 22, 2019, 6:49 PM

#

could you share the template file perhaps? i'm too used to tweaking via inspect

molten bough Oct 22, 2019, 6:49 PM

#

And that's what we have, so

#

Sorry, I'm on a separate floor

glass pecan Oct 22, 2019, 6:49 PM

#

all g

tawdry vapor Oct 22, 2019, 6:56 PM

#

@crude gyro I re-did them in SVG 🙂

📎 superstar_apply.png

#

I liked the look of 🌟 so I copied it

glass pecan Oct 22, 2019, 6:58 PM

#

noice

tawdry vapor Oct 22, 2019, 6:58 PM

#

here's the other, if you want to use it

📎 superstar_pardon.png

#

I'll just make a PR and you can tell me there if it needs to be adjusted

#

Like if the radius on the square is wrong or whatever

stable mountainBOT Oct 22, 2019, 7:03 PM

#

@molten bough, it looks like you tried to attach a file type we don't allow. Feel free to ask in #community-meta if you think this is a mistake.

molten bough Oct 22, 2019, 7:03 PM

#

oh well

#

no html file for you

crude gyro Oct 22, 2019, 7:03 PM

#

yeah man that looks great @tawdry vapor

molten bough Oct 22, 2019, 7:03 PM

#

I came up to get a stomach pill lol

crude gyro Oct 22, 2019, 7:05 PM

#

the only question is

#

superstar_apply

tawdry vapor Oct 22, 2019, 7:05 PM

#

yellow plus white dont work well 😄

crude gyro Oct 22, 2019, 7:05 PM

#

when it's this size, or even superstar_apply sized, how legible will it be?

hardy gorge Oct 22, 2019, 7:05 PM

#

The green one has more contrast, so it may look better when it's small

tawdry vapor Oct 22, 2019, 7:06 PM

#

it's displayed at 22x22

#

Well then I can ditch the gold and use red/green as the others do

crude gyro Oct 22, 2019, 7:06 PM

#

most of them we have in red, blue and green

tawdry vapor Oct 22, 2019, 7:06 PM

#

yeah it's just that the embed was gold so figured why not

#

but it's not very legible at that resolution

crude gyro Oct 22, 2019, 7:07 PM

#

superstar_pardon

#

this one is better superstar_pardon

tawdry vapor Oct 22, 2019, 7:07 PM

#

so red=apply green=pardon, as the others?

crude gyro Oct 22, 2019, 7:07 PM

#

but at the smallest size, I still think a star without the extra details might have had better legibility

green oriole Oct 22, 2019, 7:07 PM

#

(@molten bough change the extension)

molten bough Oct 22, 2019, 7:07 PM

#

I mean, I'd be breaking the rules if I did that

#

Haha

crude gyro Oct 22, 2019, 7:07 PM

#

question is - will we ever see it at the smallest size?

#

it's gonna be used in these embeds, and that's at least the slightly larger size, is it not?

#

maybe even larger than that

tawdry vapor Oct 22, 2019, 7:08 PM

#

Depends on where

#

I was talking about mod log

green oriole Oct 22, 2019, 7:08 PM

#

(@molten bough paste.pydis.com? 😄)

hardy gorge Oct 22, 2019, 7:08 PM

#

The respective contrast ratios are 1.53 (yellow) and 2.16 (green)

crude gyro Oct 22, 2019, 7:08 PM

#

yeah mod log

hardy gorge Oct 22, 2019, 7:08 PM

#

Which means it's low

molten bough Oct 22, 2019, 7:08 PM

#

Good point

tawdry vapor Oct 22, 2019, 7:09 PM

#

Mod log is actually 20x20, even smaller

crude gyro Oct 22, 2019, 7:09 PM

#

okay so then maybe just a ⭐ would be better than a 🌟 in terms of legibility.

#

yours looks nice large

#

but not sure it makes sense at 20x20

#

even at superstar_pardon size it's starting to get hard to see what it is

tawdry vapor Oct 22, 2019, 7:10 PM

#

📎 superstar_apply_20.png

#

📎 superstar_pardon_20.png

crude gyro Oct 22, 2019, 7:10 PM

#

right, while those are crystal clear.

#

so I think we should probably go for that

tawdry vapor Oct 22, 2019, 7:11 PM

#

Oh well I liked the sparkles but alas they must perish for the greater good

crude gyro Oct 22, 2019, 7:11 PM

#

yes. I liked them too

#

but you gotta suffer for fashion

#

https://www.youtube.com/watch?v=aBYGjC_hJ9A

YouTube

Polyvinyl Records

of Montreal - Suffer For Fashion [OFFICIAL MUSIC VIDEO]

Distributed by WMG From the album Hissing Fauna, Are You The Destroyer? Purchase CD / 2xLP / MP3 here: http://www.polyvinylrecords.com/store/index.php?id=36 ...

▶ Play video

tawdry vapor Oct 22, 2019, 7:13 PM

#

Anyone have ideas for warn/note icons btw? They are both a mail icon right now

#

At the least one of them should be different I think

green oriole Oct 22, 2019, 7:14 PM

#

🗒?

#

For the note

crude gyro Oct 22, 2019, 7:14 PM

#

hard to iconize in the style we got, would just look like a rectangle.

tawdry vapor Oct 22, 2019, 7:14 PM

#

Maybe, would need to look good at 20x20

crude gyro Oct 22, 2019, 7:14 PM

#

pencil maybe

tawdry vapor Oct 22, 2019, 7:14 PM

#

we already use a pencil for edited infractions

crude gyro Oct 22, 2019, 7:14 PM

#

right okay

#

fontawesome has a post-it one

#

📎 unknown.png

brazen charm Oct 22, 2019, 7:18 PM

#

should the source code paragraph be excluded when someone !d gets a module? Would need to be filtered out https://i.imgur.com/3staNvd.png

tawdry vapor Oct 22, 2019, 7:19 PM

#

It would probably just look like a square at 20x20 but I could try, easy to make a test

#

I made the PR, can you please double check the dimensions are correct since I did not use your PSD

#

https://github.com/python-discord/branding/pull/33

GitHub

Add superstar infraction icons by MarkKoz · Pull Request #33 · p...

Sparkles were left but commented out because they are not legible at the low resolutions (20x20) at which these icons are displayed

hardy gorge Oct 22, 2019, 7:19 PM

#

@brazen charm That's for module-level help, right?

tawdry vapor Oct 22, 2019, 7:19 PM

#

Mainly, it's 128x128, square is 100x100 with a radius of 10

brazen charm Oct 22, 2019, 7:19 PM

#

yep

hardy gorge Oct 22, 2019, 7:20 PM

#

I'd say it's part of the documentation for that module

#

It may be the thing you're interested in

#

Maybe I'm just weird, but for some things, I look at the source code

brazen charm Oct 22, 2019, 7:22 PM

#

I do too but not sure if people getting the docs like that would need it most of the time

hardy gorge Oct 22, 2019, 7:23 PM

#

I say leave it in. It's part of the documentation and it's not like it's decreasing the useful info in there by a lot

woeful thorn Oct 22, 2019, 7:23 PM

#

They're not really going to get much of value out of module-level help anyway, getting rid of the source makes it even less so

tawdry vapor Oct 22, 2019, 7:32 PM

#

Would it be better to move it to the footer?

#

Having it first may be too prominent

woeful thorn Oct 22, 2019, 7:33 PM

#

You can't put links in a footer

tawdry vapor Oct 22, 2019, 7:33 PM

#

😒 never mind then

hardy gorge Oct 22, 2019, 7:33 PM

#

I'd also like to keep the parser as general as possible, since it should work on any inventory link we add

#

If we add a lot of exceptions, it's going to be difficult to maintain

woeful thorn Oct 22, 2019, 7:34 PM

#

I don't really see the problem with the information presented in the image

hardy gorge Oct 22, 2019, 7:34 PM

#

Since we'd have to PR in changes anyway and we have this beautiful database-driven addition system to avoid that

#

Me neither, @woeful thorn, so let's just go with that.

tawdry vapor Oct 22, 2019, 7:37 PM

#

@crude gyro Thanks, can you upload those to the emote server and get me the IDs?

crude gyro Oct 22, 2019, 7:37 PM

#

am indisposed atm

#

maybe one of the other <@&267628507062992896> can?

tawdry vapor Oct 22, 2019, 7:38 PM

#

Ok, np

hardy gorge Oct 22, 2019, 7:40 PM

#

what would you like as logical names? I've got a headache and I can't think of anything.

#

ah

#

the filenames provide the solution

tawdry vapor Oct 22, 2019, 7:41 PM

#

sure

#

or superstar and unsuperstar

#

or superstarify and unsuperstarify

#

the bot wont use the emotes by those names anyway so it's not important

hardy gorge Oct 22, 2019, 7:41 PM

#

yeah, true

#

:superstarify: - 636288153044516874
:unsuperstarify: - 636288201258172446

#

@tawdry vapor this

tawdry vapor Oct 22, 2019, 7:45 PM

#

thanks

brazen charm Oct 22, 2019, 7:46 PM

#

Another things I wanted to ask, there are a few thousand symbols in the form reference/generated/numpy.nonzero in the inventory that point directly to pages (bot can't currently handle) but they all also have proper counterparts that point to a header link. Should they just be excluded with a check when building the inventory or keep them in?

hardy gorge Oct 22, 2019, 7:49 PM

#

That depends on your implementation, I think. I haven't looked at your commits yet, but the !docs commands are currently specifically meant to accept any inventory url we want to add, without having to also PR in changes to the codebase. Adding inventory-specific exceptions to processing rules kinda defeats that purpose and adds the requirement of per-inventory code maintainance.

brazen charm Oct 22, 2019, 7:55 PM

#

Those come from the intersphinx fetch function and are just added as normal, without any changes from me. But I'm not sure where they're coming from in the inventory (not that I looked at it)

molten bough Oct 22, 2019, 8:57 PM

#

Right then

glass pecan Oct 22, 2019, 8:57 PM

#

ya back?

molten bough Oct 22, 2019, 8:57 PM

#

Yup

glass pecan Oct 22, 2019, 8:57 PM

#

mind if i show a mockup of the idea i had then

molten bough Oct 22, 2019, 8:57 PM

#

Here is redmon:

📎 unknown.png

#

Sure thing, go for it

glass pecan Oct 22, 2019, 8:58 PM

#

ok first warning

#

i think we're fighting against the inevitable by trying to design a nice full page with such sparse content

#

so i figured, why not just use a modal

#

📎 unknown.png

molten bough Oct 22, 2019, 8:59 PM

#

Modal looks good

#

but

#

it does require javascript

#

and I feel like requiring that for essentially a GDPR function is a bad idea

glass pecan Oct 22, 2019, 9:00 PM

#

i don't really agree in that respect

#

if the argument was that implementing was a pain or something, then that would be fine

#

but requiring js in a website isn't unusual

molten bough Oct 22, 2019, 9:02 PM

#

I don't overall mind JS and such, that's all fine

#

it's just that we have to make sure this can be got at somehow

crude gyro Oct 22, 2019, 9:02 PM

#

yeah, it can

#

just by enabling JS

#

or not using your grandmas computer

#

not gonna limit our website by what you can do from netscape.

glass pecan Oct 22, 2019, 9:02 PM

#

if they are absolutely adament they don't want to enable scripts beacuse they're crazy people on tor who do illegal stuff, then they can just email us

molten bough Oct 22, 2019, 9:03 PM

#

Okay

#

secondly, where does the modal live? it's going to have to be on every page in some capacity, right?

glass pecan Oct 22, 2019, 9:04 PM

#

unless you load the modal only after clicking a button

molten bough Oct 22, 2019, 9:04 PM

#

(also, are those cards the same height when the Discord one doesn't have a button?)

glass pecan Oct 22, 2019, 9:04 PM

#

don't think so, lets try

molten bough Oct 22, 2019, 9:04 PM

#

I think that can be done with tiles

glass pecan Oct 22, 2019, 9:04 PM

#

but that's not much of an issue either as we can just leave a disabled button there

molten bough Oct 22, 2019, 9:04 PM

#

I'll have to poke it

glass pecan Oct 22, 2019, 9:05 PM

#

yeah it does not

molten bough Oct 22, 2019, 9:05 PM

#

right okay

#

also, where do we redirect to after GH has been linked?

#

or unlinked for that matter

glass pecan Oct 22, 2019, 9:06 PM

#

homepage maybe?

#

unless there's a way to go to the current page again

molten bough Oct 22, 2019, 9:06 PM

#

There might be

#

ah, wait, no

#

because after GH is linked, allauth redirects to socialaccount_connections

#

which I aliased to the account settings page

#

in theory that could be any particular page though, it just needs to be added to the urlconf a second time

crude gyro Oct 22, 2019, 9:08 PM

#

could it live in the nav?

glass pecan Oct 22, 2019, 9:09 PM

#

as a perma thing?

molten bough Oct 22, 2019, 9:09 PM

#

I mean, it could be in that template

glass pecan Oct 22, 2019, 9:09 PM

#

i dunno if that changes the redirect stuff

crude gyro Oct 22, 2019, 9:09 PM

#

nav is ever present when you click that button

#

no matter where you are.

#

just a thought

glass pecan Oct 22, 2019, 9:09 PM

#

but yeah obviously i didn't think of too much implementation details

#

the only thing i can contribute is the design idea

#

lol

molten bough Oct 22, 2019, 9:10 PM

#

I don't disagree with the modal idea

#

I would still like the pages to be usable without JS

#

but I could look past that for now

#

no reason there can't just be a <noscript> with an extra item

#

or even just leave the anchor as it is and cancel the click in JS

mellow hare Oct 22, 2019, 9:13 PM

#

The primary benefit of this being...

molten bough Oct 22, 2019, 9:13 PM

#

of which specifically

mellow hare Oct 22, 2019, 9:13 PM

#

Worrying about a noscript option

molten bough Oct 22, 2019, 9:13 PM

#

I'm just concerned about the accessibility of a GDPR tool

mellow hare Oct 22, 2019, 9:14 PM

#

We also have an email if people need to get it done

molten bough Oct 22, 2019, 9:14 PM

#

Do we have that on the site somewhere?

mellow hare Oct 22, 2019, 9:14 PM

#

We're not denying people access, we're just making it more accessible for the 99.99% of people who would worry about it

molten bough Oct 22, 2019, 9:14 PM

#

Oh sure, I'm just saying, it's easy to cater for both

#

just add a GET param to the current page to display a template without the bits and bobs that's usually there

#

use it to template the modal

#

well actually I guess it's more complex than that given the stuff in the header of the modal, but eh

crude gyro Oct 22, 2019, 9:16 PM

#

it's not something I'm particularly interested in

#

I do wonder, however, if it's possible to do the modal with pure css

molten bough Oct 22, 2019, 9:16 PM

#

that's a good question

mellow hare Oct 22, 2019, 9:17 PM

#

That feels... unwise

crude gyro Oct 22, 2019, 9:17 PM

#

why's that?

mellow hare Oct 22, 2019, 9:17 PM

#

It's a style sheet, not a language or even for hyper links

crude gyro Oct 22, 2019, 9:17 PM

#

we're just showing or hiding a modal. that's well inside the realm of a style change

#

the real problem is hooking it up to a click event with pure css

molten bough Oct 22, 2019, 9:18 PM

#

I mean, it is a style change, it's just the trigger

#

anyway, it is possible, but it's a hack

glass pecan Oct 22, 2019, 9:18 PM

#

lemon, it's actually possible

molten bough Oct 22, 2019, 9:18 PM

#

you do it using check states

mellow hare Oct 22, 2019, 9:18 PM

#

It feels really terrible

glass pecan Oct 22, 2019, 9:18 PM

#

zero js modals

#

https://codepen.io/Idered/pen/vytkH

molten bough Oct 22, 2019, 9:18 PM

#

that's the pen I'm on

glass pecan Oct 22, 2019, 9:18 PM

#

yeah google is good

mellow hare Oct 22, 2019, 9:19 PM

#

Wow

molten bough Oct 22, 2019, 9:19 PM

#

although I can't actually view it

mellow hare Oct 22, 2019, 9:19 PM

#

Okay, nevermind then, that's like magic to me

glass pecan Oct 22, 2019, 9:19 PM

#

thats some fancy css

molten bough Oct 22, 2019, 9:19 PM

#

📎 unknown.png

mellow hare Oct 22, 2019, 9:19 PM

#

When did they give css such power?

glass pecan Oct 22, 2019, 9:19 PM

#

probs css3

molten bough Oct 22, 2019, 9:19 PM

#

it's basically just

mellow hare Oct 22, 2019, 9:19 PM

#

I retract my statements then

crude gyro Oct 22, 2019, 9:19 PM

#

hmm.. is this a checkbox styled to look like a button?

molten bough Oct 22, 2019, 9:19 PM

#

.modal-state:checked + .modal {
  opacity: 1;
  visibility: visible;
}

crude gyro Oct 22, 2019, 9:19 PM

#

that's very clever.

molten bough Oct 22, 2019, 9:19 PM

#

it is, yeah

glass pecan Oct 22, 2019, 9:19 PM

#

yeah very neat

molten bough Oct 22, 2019, 9:20 PM

#

well it's more like

#

you have a label

glass pecan Oct 22, 2019, 9:20 PM

#

so html elements can have state i guess

molten bough Oct 22, 2019, 9:20 PM

#

and the checkbox is hidden

#

that said, how do you close the modal?

crude gyro Oct 22, 2019, 9:20 PM

#

but yeah, I mean, if we can do this it solves your absurd noscript worry and is simple and straight forward. no js is better than some js, if that's an option.

molten bough Oct 22, 2019, 9:20 PM

#

oh, more labels.

#

anyway, I don't think this will work

mellow hare Oct 22, 2019, 9:20 PM

#

Debatable

molten bough Oct 22, 2019, 9:20 PM

#

why? bulma

#

bulma's just not designed this way really

#

we'd have to duplicate tons of their CSS

crude gyro Oct 22, 2019, 9:21 PM

#

huh? why do you say that?

molten bough Oct 22, 2019, 9:21 PM

#

so the JS option is better imo

#

well, let me double check what they actually do

mellow hare Oct 22, 2019, 9:21 PM

#

What's your suggested alternative for the noscript crowd then?

#

I guess I misunderstood that bit

molten bough Oct 22, 2019, 9:22 PM

#

just also have an actual page

mellow hare Oct 22, 2019, 9:22 PM

#

I mean I feel like it'd make more sense to have one or the other

molten bough Oct 22, 2019, 9:22 PM

#

oh okay, their is-active is literally just display: flex;

#

I still think this breaks some behaviours, though

#

the entire background of the modal would have to be a label

crude gyro Oct 22, 2019, 9:23 PM

#

is that how the codepen did it?

molten bough Oct 22, 2019, 9:23 PM

#

well as I say, I can't actually view the codepen

crude gyro Oct 22, 2019, 9:23 PM

#

okay, well

#

maybe you should turn on JS

molten bough Oct 22, 2019, 9:24 PM

#

looking at.. yeah it looks like it from the code

#

we're using straight up ES6, I take it?

mellow hare Oct 22, 2019, 9:24 PM

#

I'd hope so

molten bough Oct 22, 2019, 9:24 PM

#

I don't think we have a linter

#

but I can just use jslint or something

mellow hare Oct 22, 2019, 9:25 PM

#

And 'use strict';

molten bough Oct 22, 2019, 9:25 PM

#

yep

crude gyro Oct 22, 2019, 9:26 PM

#

anyway, was just an idea

#

I don't actually mind the js solution

#

but I do mind having two solutions just because someone might not have js

#

I'm violently opposed.

molten bough Oct 22, 2019, 9:27 PM

#

okay

crude gyro Oct 22, 2019, 9:27 PM

#

so, solve it without js or solve it with js, but don't do both

glass pecan Oct 22, 2019, 9:27 PM

#

do you want the html i used

mellow hare Oct 22, 2019, 9:27 PM

#

And I'd heavily prefer the JS solution over a CSS hack, especially since we're already using a CSS framework, and that just feels like opening a pandora's box that isn't really worth messing with

molten bough Oct 22, 2019, 9:28 PM

#

I'm okay with the HTML, I do wanna change it a little

#

not a big fan of the cards on each connection but I feel like a divider between 'em might be nice

#

although I'm curious how you did the large icon with small text

glass pecan Oct 22, 2019, 9:28 PM

#

with cards

#

lol it's actually just the media objects

molten bough Oct 22, 2019, 9:29 PM

#

oh yeah, the media objects

#

you can just put an icon in the media-left? TIL

glass pecan Oct 22, 2019, 9:29 PM

#

https://mystb.in/quxacehera.html

molten bough Oct 22, 2019, 9:30 PM

#

that's amusing

glass pecan Oct 22, 2019, 9:30 PM

#

it's mostly laziness because mocking

#

but it's actually not a bad solution

molten bough Oct 22, 2019, 9:30 PM

#

It's not, yeah

glass pecan Oct 22, 2019, 9:31 PM

#

at any rate, i personally prefer the boxes over a divider, so i'd like to hear options on others too about that

molten bough Oct 22, 2019, 9:31 PM

#

image again since it's far enough up there https://media.discordapp.net/attachments/635950537262759947/636307598882242570/unknown.png

mellow hare Oct 22, 2019, 9:31 PM

#

I'd have to see the options before I can give an opinion

molten bough Oct 22, 2019, 9:31 PM

#

it'd be like that, but with a line down the middle instead of the boxes

crude gyro Oct 22, 2019, 9:32 PM

#

I like the boxes, I think.

glass pecan Oct 22, 2019, 9:32 PM

#

i like the boxes primarily because the ui is consistent when they no longer inline such as on mobile

mellow hare Oct 22, 2019, 9:32 PM

#

Kind of prefer the boxes, then. I thought you were thinking of having them in a column with horizontal dividing lines

molten bough Oct 22, 2019, 9:32 PM

#

The divider does automatically go horizonal on mobile

crude gyro Oct 22, 2019, 9:32 PM

#

or, cards I guess they are

mellow hare Oct 22, 2019, 9:32 PM

#

Yea but if they're the same size as the boxes, why not boxes

molten bough Oct 22, 2019, 9:33 PM

#

We could also use tiles

#

if we wanted a bit more colour

#

📎 unknown.png

glass pecan Oct 22, 2019, 9:34 PM

#

too much colour

molten bough Oct 22, 2019, 9:34 PM

#

I think they look like this without colour as well

📎 unknown.png

#

but that might be a bit 3D? I dunno

#

I just don't like plain boxes

glass pecan Oct 22, 2019, 9:35 PM

#

they're not plain

#

they have a border radius, they have a drop shadow, they're more distinct than the tiles edges

crude gyro Oct 22, 2019, 9:36 PM

#

I also think @mellow hare that you're grossly underestimating what CSS can (or is supposed to) do. you can use it for animations and transitions, it has state selectors for hooking up stuff like hover or focus events, this is all really performant and it's probably not fair to classify it as a hack. it's just modern.

molten bough Oct 22, 2019, 9:36 PM

#

okay

#

lemon, you still opposed to having a disabled button under the Discord entry?

crude gyro Oct 22, 2019, 9:36 PM

#

I think a button that will never be clickable is a little bit weird to have on a page but I don't have a very strong opinion about it

glass pecan Oct 22, 2019, 9:37 PM

#

i guess you wouldn't disconnect the discord account.

#

so that makes sense

molten bough Oct 22, 2019, 9:37 PM

#

we don't allow that, yeah

crude gyro Oct 22, 2019, 9:37 PM

#

if you guys like it for symmetry, it's fine I guess

molten bough Oct 22, 2019, 9:37 PM

#

well, that and keeping the cards the same height

mellow hare Oct 22, 2019, 9:37 PM

#

Fair enough. I do need to refresh myself on that

molten bough Oct 22, 2019, 9:37 PM

#

although some smartass with a big name is gonna come along and break it, but that's their own fault

crude gyro Oct 22, 2019, 9:38 PM

#

yeah it's really quite cool. I've built some pretty cool shit with only CSSs. I never use JS for dropdowns anymore, I think modals are a good candidate to join dropdowns there

#

same with elements doing minor "slides" or other nice polish

#

looks and works great in pure css

molten bough Oct 22, 2019, 9:38 PM

#

yeah, I did that with the messages

crude gyro Oct 22, 2019, 9:38 PM

#

anything more complex than that, time to break out the big guns and make a javascript file

#

don't get me wrong, I love JS and I use it for a lot of stuff, but I'd rather avoid it if it's something so simple that even CSS can solve it.

#

having a JS file that's just like.. making an element visible? seems pointless

glass pecan Oct 22, 2019, 9:39 PM

#

📎 unknown.png

crude gyro Oct 22, 2019, 9:39 PM

#

it's a style change. we should do it with our stylesheet.

glass pecan Oct 22, 2019, 9:39 PM

#

I kinda don't mind it

#

it shows the linked status i guess

crude gyro Oct 22, 2019, 9:39 PM

#

I'm fine with it

#

can we blurple the discord bubble?

glass pecan Oct 22, 2019, 9:39 PM

#

yeah

molten bough Oct 22, 2019, 9:39 PM

#

we can

glass pecan Oct 22, 2019, 9:39 PM

#

its text

crude gyro Oct 22, 2019, 9:40 PM

#

nice

glass pecan Oct 22, 2019, 9:40 PM

#

or rather, it's an icon

crude gyro Oct 22, 2019, 9:40 PM

#

I wasn't asking if it was possible

#

I was asking if you would mind doing it :D

molten bough Oct 22, 2019, 9:40 PM

#

pure CSS @mellow hare

📎 message.mp4

#

love me some animations

crude gyro Oct 22, 2019, 9:40 PM

#

yeah that's a great example

#

a lot of people would have thought you needed JS for that

molten bough Oct 22, 2019, 9:40 PM

#

that wasn't very 60fps of my 60fps setting

crude gyro Oct 22, 2019, 9:40 PM

#

and it's not even ugly

#

it looks quite nice in the CSS file

#

nice and logical

molten bough Oct 22, 2019, 9:41 PM

#

📎 unknown.png

glass pecan Oct 22, 2019, 9:41 PM

#

?

📎 unknown.png

molten bough Oct 22, 2019, 9:41 PM

#

That looks kinda weird with the blurple button

crude gyro Oct 22, 2019, 9:41 PM

#

looks nice, although now a straight cross symmetry has arisen between the discord icon and the blurple connect

glass pecan Oct 22, 2019, 9:42 PM

#

yep

#

that's why i kept both black originally

molten bough Oct 22, 2019, 9:42 PM

#

maybe is-light for the button?

crude gyro Oct 22, 2019, 9:42 PM

#

could make that button green, too

#

that's pretty connecty

molten bough Oct 22, 2019, 9:42 PM

#

yeah, could use success

#

the rare, lesser-spotted green on the site

glass pecan Oct 22, 2019, 9:43 PM

#

📎 unknown.png

#

i kinda don't like that the text is black

crude gyro Oct 22, 2019, 9:43 PM

#

yeah

#

I don't really like these pastel colors

molten bough Oct 22, 2019, 9:43 PM

#

it's kind of pastelly, yeah

crude gyro Oct 22, 2019, 9:43 PM

#

now that I'm seeing them in the wild

#

we switched them because we wanted less intensity for an older version of the notifications

#

but now I kinda wanna just set them back

#

because the bulma defaults are better

glass pecan Oct 22, 2019, 9:43 PM

#

📎 unknown.png

molten bough Oct 22, 2019, 9:43 PM

#

I dunno, I find them harder to read on a white background

#

the green is OK though

#

however there was another reason we didn't use that green

#

scragly picked a better one a while back

glass pecan Oct 22, 2019, 9:44 PM

#

thats not default, i just picked via colourpicker

molten bough Oct 22, 2019, 9:44 PM

#

Ah okay

glass pecan Oct 22, 2019, 9:45 PM

#

this is mainly as an idea of not-pastel i guess lol

#

or rather, not black text

crude gyro Oct 22, 2019, 9:45 PM

#

well it's better than blurple

molten bough Oct 22, 2019, 9:45 PM

#

If we're gonna start coming up with new colours we should probably be consistent about it

#

like that red that lemon made

#

📎 unknown.png

crude gyro Oct 22, 2019, 9:45 PM

#

wish we had someone who knew about colors who could do this stuff

#

I kinda like that red, though

glass pecan Oct 22, 2019, 9:46 PM

#

D63852

molten bough Oct 22, 2019, 9:46 PM

#

That's a nice red

#

yeah, that red is d63852

glass pecan Oct 22, 2019, 9:46 PM

#

copying back down here for my reference

#

sorry

crude gyro Oct 22, 2019, 9:46 PM

#

so you're saying, if we're gonna go green, we should maybe do a green that's sorta like pulling towards blue and a little darker?

#

so that we get a matching sort of color profile

molten bough Oct 22, 2019, 9:46 PM

#

well, maybe we should just apply the same transformative difference

crude gyro Oct 22, 2019, 9:47 PM

#

fancy

molten bough Oct 22, 2019, 9:47 PM

#

the left one here is the bulma default, right is lemon's

📎 unknown.png

crude gyro Oct 22, 2019, 9:47 PM

#

okay

glass pecan Oct 22, 2019, 9:47 PM

#

📎 unknown.png

#

yeah that red is nice

#

a lot better than current

molten bough Oct 22, 2019, 9:47 PM

#

actually that page is wrong

#

it's not uhh

#

granular enough

crude gyro Oct 22, 2019, 9:47 PM

#

so let's work out what the transformative difference equivalent for green is. that's a fun problem.

#

thing in rgb and just copy the integer difference

#

but switching primaries

#

so that whatever we did to red, we do to green

molten bough Oct 22, 2019, 9:48 PM

#

I like to do it with an actual colour picker

crude gyro Oct 22, 2019, 9:48 PM

#

how's that?

molten bough Oct 22, 2019, 9:48 PM

#

but yeah, basically

crude gyro Oct 22, 2019, 9:49 PM

#

gimme the hex for bulma green

#

I'll solve for x

molten bough Oct 22, 2019, 9:49 PM

#

48c774

#

should be 2db95e I think

#

📎 unknown.png

crude gyro Oct 22, 2019, 9:51 PM

#

I get #32AC66

mellow hare Oct 22, 2019, 9:51 PM

#

That's so bizarre. I'm behind the times I guess

molten bough Oct 22, 2019, 9:52 PM

#

📎 unknown.png

#

I dunno, maybe I did it wrong

glass pecan Oct 22, 2019, 9:52 PM

#

i gotta crash, so i'll see you guys tomorrow

molten bough Oct 22, 2019, 9:52 PM

#

📎 unknown.png

#

Later scrags o/

crude gyro Oct 22, 2019, 9:53 PM

#

or

#

#3AAC5E

molten bough Oct 22, 2019, 9:53 PM

#

📎 unknown.png

crude gyro Oct 22, 2019, 9:53 PM

#

they're both of exactly equal transformative difference

#

but pull to different sides

#

out of those, I think I like #32AC66

molten bough Oct 22, 2019, 9:55 PM

#

I'll check it out

#

📎 unknown.png

crude gyro Oct 22, 2019, 9:56 PM

#

yeah, those seem like they're in the same palette.

#

nice.

molten bough Oct 22, 2019, 9:56 PM

#

I think so, yeah

#

Should we do the other ones?

#

Here's how messages look, by the way, with that red

📎 unknown.png

#

I think that's alright

crude gyro Oct 22, 2019, 9:58 PM

#

yeah that looks alright

molten bough Oct 22, 2019, 9:58 PM

#

You wanna do the other colours?

#

actually there's really only two more, since the turquoise is replaced with blurple

#

the blue (#3298dc) and yellow (#ffdd57)

crude gyro Oct 22, 2019, 10:00 PM

#

okay, sec.

#

#2482c1 for the blue, I think

#

alternatively #1c8ac1

#

#e9cf3c for the yellow

molten bough Oct 22, 2019, 10:07 PM

#

📎 unknown.png

#

📎 unknown.png

crude gyro Oct 22, 2019, 10:07 PM

#

also possibly #f1c241

#

but that's a bit more gold

molten bough Oct 22, 2019, 10:08 PM

#

It is kinda gold, but I don't hate it

#

📎 unknown.png

crude gyro Oct 22, 2019, 10:08 PM

#

these are all just coming out of some code I wrote now

#

the first blue looks like a winner, and frankly, the first yellow too

#

imo

molten bough Oct 22, 2019, 10:08 PM

#

I think so too

crude gyro Oct 22, 2019, 10:09 PM

#

fun to use python for picking colors.

#

the code is very ugly

molten bough Oct 22, 2019, 10:09 PM

#

there are two other colours that are defined in bulma's sass

#

but they aren't used anywhere whatsoever

#

orange and purple

#

and they aren't documented either

crude gyro Oct 22, 2019, 10:09 PM

#

# Transform
rgb[primary] -= 27
rgb[secondary] -= 22
rgb[tertiary] -= 14

molten bough Oct 22, 2019, 10:09 PM

#

we can probably ignore them

#

Oh, nice

crude gyro Oct 22, 2019, 10:10 PM

#

then you manually set primary to match whatever color you feel is the primary color you're altering

#

so, blue for a blueish color and so on

molten bough Oct 22, 2019, 10:10 PM

#

oh, hng, I found a couple of uses of those too, as well as another blue

#

do we really need two blues..

#

probably not

#

I've not seen orange/purple anywhere on our pages but we can do them if you want

#

📎 unknown.png

crude gyro Oct 22, 2019, 10:13 PM

#

that yellow isn't very nice, but the blue looks great

molten bough Oct 22, 2019, 10:13 PM

#

yeah, I agree

#

gold isn't a ton better, it just looks out of place with black text

📎 unknown.png

#

but then, the bulma one would have that too

crude gyro Oct 22, 2019, 10:14 PM

#

that's the default one?

molten bough Oct 22, 2019, 10:14 PM

#

No, that's the other yellow you gave

crude gyro Oct 22, 2019, 10:14 PM

#

it's a tiny bit better.

molten bough Oct 22, 2019, 10:15 PM

#

This is the default one

📎 unknown.png

crude gyro Oct 22, 2019, 10:15 PM

#

that one is fine too

#

so let's just use that

molten bough Oct 22, 2019, 10:15 PM

#

Alright

crude gyro Oct 22, 2019, 10:15 PM

#

works well with the other colors

#

better than the one I transformed I think

molten bough Oct 22, 2019, 10:15 PM

#

I think it looks fine, yeah

crude gyro Oct 22, 2019, 10:15 PM

#

yeah. cool. nice.

#

good. great. I like it.

molten bough Oct 22, 2019, 10:16 PM

#

we could do orange/purple but honestly it's probably a waste of time

#

I haven't found a single use of it anywhere

crude gyro Oct 22, 2019, 10:16 PM

#

it's easy, I got a script for it now

molten bough Oct 22, 2019, 10:16 PM

#

they likely put them in as alternative primary colours

crude gyro Oct 22, 2019, 10:17 PM

#

can we see what they're set to currently first?

molten bough Oct 22, 2019, 10:17 PM

#

Sure

#

these are all the defaults for good measure

📎 unknown.png

#

orange is #ff470f

#

purple is #b86bff

crude gyro Oct 22, 2019, 10:18 PM

#

I like turquoise

#

that's a million dollar color, man.

molten bough Oct 22, 2019, 10:18 PM

#

the problem with turquoise is that it's the default primary colour

crude gyro Oct 22, 2019, 10:18 PM

#

I can see why

molten bough Oct 22, 2019, 10:18 PM

#

so if we don't set it to blurple a bunch of things will be turquoise

crude gyro Oct 22, 2019, 10:18 PM

#

good way to make a million dollars

molten bough Oct 22, 2019, 10:18 PM

#

even if we do set the primary to blurple

#

haha

crude gyro Oct 22, 2019, 10:18 PM

#

but yeah that's fine

molten bough Oct 22, 2019, 10:19 PM

#

that darker blue is #3273dc also but I just set it and cyan to the blue you came up with

crude gyro Oct 22, 2019, 10:20 PM

#

purp: #aa55e4
orange: #e43101

molten bough Oct 22, 2019, 10:21 PM

#

Changed the green and red to purple and orange so I could actually show them

📎 unknown.png

#

those are the ones you gave

crude gyro Oct 22, 2019, 10:21 PM

#

the orange sucks.

molten bough Oct 22, 2019, 10:21 PM

#

yeah

#

the purple isn't bad

crude gyro Oct 22, 2019, 10:22 PM

#

could be worse, how was it before?

molten bough Oct 22, 2019, 10:22 PM

#

default orange and purple

📎 unknown.png

crude gyro Oct 22, 2019, 10:23 PM

#

okay, so, keep the new purp, let's never talk about the new orange again

molten bough Oct 22, 2019, 10:23 PM

#

haha

#

keep the default orange then?

crude gyro Oct 22, 2019, 10:24 PM

#

yeah, it's fine

molten bough Oct 22, 2019, 10:24 PM

#

Alright

#

now that that's done..

#

modal

#

well actually it's 11:30 so it might not be done today, but I'll give it a go

#

modal JS can probably be put in simple-bulma

#

I'll just do it here first for the sake of time though

crude gyro Oct 22, 2019, 10:28 PM

#

yeah I think it'd be nice to have that in simple-bulma too

molten bough Oct 22, 2019, 10:32 PM

#

I did not miss JavaScript

📎 unknown.png

#

oh my god

📎 unknown.png

#

okay, come here MDN

crude gyro Oct 22, 2019, 10:34 PM

#

the second one is hilarious

molten bough Oct 22, 2019, 10:35 PM

#

I couldn't believe it, haha

molten bough Oct 22, 2019, 11:04 PM

#

hm

#

is it possible to actually like

#

insert a bunch of stuff into every template

#

because the page I wrote does need me to provide some variables to the template

#

I guess I could just keep the endpoint and load the template with JS

#

gah, that won't work either

#

unless the JS lib is loaded as part of that template

#

which I guess it could be

molten bough Oct 22, 2019, 11:35 PM

#

Lol, because of the notification stuff, the navbar is above the modal background

📎 unknown.png

#

not all of my JS is wiring stuff up correctly, but I'm getting there

molten bough Oct 22, 2019, 11:57 PM

#

alright, you beautiful people

📎 modal.mp4

#

I can't get the navbar to be behind the background

#

I have no idea why

#

even if the modal is the first element in the body

#

but otherwise, it's done

molten bough Oct 23, 2019, 12:36 AM

#

PR is no longer marked draft. I'm going to bed, haha.

green oriole Oct 23, 2019, 6:27 AM

#

That look awesome!

#

We got a PR from dependabot on seasonalbot about security issues with the version of pillow we are using (I got the same on a personal project) do you think it is worth investigating if there is really a security issue or we just ignore it?

crude gyro Oct 23, 2019, 6:30 AM

#

very nice, @molten bough

#

and @glass pecan for the design, too. this looks like an excellent implementation.

#

@green oriole I think we can assume that there definitely is one and we should probably just upgrade pillow after testing that things still work with that version.

#

I assume you're refering to https://nvd.nist.gov/vuln/detail/CVE-2019-16865

molten bough Oct 23, 2019, 7:03 AM

#

\o/

molten bough Oct 23, 2019, 7:21 AM

#

Oh I just realised there's one other thing I was gonna do

#

Add an API to get connections

tranquil topaz Oct 23, 2019, 7:37 AM

#

@green oriole https://github.com/python-discord/bot/issues/549

green oriole Oct 23, 2019, 7:42 AM

#

Okay thanks!

green oriole Oct 23, 2019, 8:48 AM

#

In the bot repo, if it in DEBUG_MODE, filtering is done only in a specific channel (here https://github.com/python-discord/bot/blob/master/bot/cogs/filtering.py#L139..L141) any special reason for that (according to git blame Ves reintroduced them in a commit)?

crude gyro Oct 23, 2019, 8:55 AM

#

you should probably ping @hardy gorge when you mention him, since he'd be the best person to answer that.

#

since #dev-test no longer exists, this is definitely a bug.

#

and should be sorted out.

#

we should remove any references to that channel while we're at it.

#

if you'd like to do it, you can.

green oriole Oct 23, 2019, 8:57 AM

#

Okay I'm doing a PR on message filtering, I can delete that too

crude gyro Oct 23, 2019, 8:57 AM

#

hmm.

#

yeah okay, I think that would be fine. make sure you mention that you'd made this change in the PR description, though

#

it should be a fairly minor change

green oriole Oct 23, 2019, 8:59 AM

#

Okay

crude gyro Oct 23, 2019, 8:59 AM

#

then again.. hmm.

#

no, make a second PR for that, please.

#

it should be tested seperately

molten bough Oct 23, 2019, 9:06 AM

#

Should I add that API for getting social connections for users in this PR?

#

it's already pretty big, but I don't mind if the reviewers don't

green oriole Oct 23, 2019, 9:08 AM

#

@crude gyro here it is https://github.com/python-discord/bot/pull/550

GitHub

Use standard filter conditions even if DEBUG_MODE is on. by Akarys...

Hi, the old method filtered only in #dev-test if DEBUG_MODE was on but this channel no longer exists.

crude gyro Oct 23, 2019, 9:09 AM

#

@molten bough you mean like allowing an api call to check what someones github is? no, don't add that to the same PR.

molten bough Oct 23, 2019, 9:09 AM

#

Okay

#

I think I'm happy with this PR then

crude gyro Oct 23, 2019, 9:10 AM

#

it is something we want, though. but I'm a little confused as to why we need a new API endpoint for it. we have APIs for the user table already, would that not contain this information?

molten bough Oct 23, 2019, 9:10 AM

#

It doesn't, no

hardy gorge Oct 23, 2019, 9:11 AM

#

@green oriole that condition has always been there, since it was needed in the past. The git blame comes from me first messing the condition up and then restoring it again. As lemon says, it's no longer needed since yesterday.

crude gyro Oct 23, 2019, 9:11 AM

#

wait, so how is this linked to the user then

molten bough Oct 23, 2019, 9:11 AM

#

connections are in the SocialAccounts table

crude gyro Oct 23, 2019, 9:11 AM

#

which has a relationship to the user?

molten bough Oct 23, 2019, 9:11 AM

#

Yep

crude gyro Oct 23, 2019, 9:11 AM

#

and when we make API requests to the user table, how are those relationships represented?

#

we don't get a copy of the relevant object data?

molten bough Oct 23, 2019, 9:12 AM

#

Well the user table hasn't been modified

#

so I don't think so

crude gyro Oct 23, 2019, 9:12 AM

#

hmm..

molten bough Oct 23, 2019, 9:12 AM

#

it's also not quite that simple

crude gyro Oct 23, 2019, 9:12 AM

#

I don't really understand the direction of that relationship then

molten bough Oct 23, 2019, 9:12 AM

#

it's a many to one relationship

#

Well, Allauth is split across a few tables

crude gyro Oct 23, 2019, 9:13 AM

#

the SocialAccounts have a user, but the user does not have a SocialAccount

molten bough Oct 23, 2019, 9:13 AM

#

you have social applications, which are the oauth providers

#

social logins, which are individual logins to those social applications

#

social accounts, which are like, Discord account, GitHub account

#

and of course there are tokens in there for making further OAuth requests

#

SocialAccount is part of Allauth and has a foreign key relationship to Django's User table

#

there is no direct relationship to the Discord User table

crude gyro Oct 23, 2019, 9:14 AM

#

okay okay but answer me this.

#

is this solved the same way as roles?

molten bough Oct 23, 2019, 9:14 AM

#

No

crude gyro Oct 23, 2019, 9:14 AM

#

so, why not? that's many-to-one too?

molten bough Oct 23, 2019, 9:14 AM

#

Yeah, but not all SocialAccounts are Discord accounts

#

You can't FK the UID because it won't work for GH accounts

crude gyro Oct 23, 2019, 9:15 AM

#

language

molten bough Oct 23, 2019, 9:15 AM

#

they are indexed on the UID though, so it's trivial to get what you want

#

the key is (uid, provider) I think

crude gyro Oct 23, 2019, 9:15 AM

#

well I'm just asking

#

does the User table have a column that contains the roles?

#

if so, I think it would be consistent if it had a column that contained the accounts

molten bough Oct 23, 2019, 9:16 AM

#

You can do user.roles, yeah

#

although

#

which User table do you mean?

#

there's two

crude gyro Oct 23, 2019, 9:16 AM

#

why are there two

#

I mean the ones that are synced from here

molten bough Oct 23, 2019, 9:16 AM

#

Django's one and the Discord API one

crude gyro Oct 23, 2019, 9:16 AM

#

right

molten bough Oct 23, 2019, 9:16 AM

#

ah okay, the Discord one

crude gyro Oct 23, 2019, 9:16 AM

#

they have different names?

molten bough Oct 23, 2019, 9:16 AM

#

yeah, that does have .roles

#

they're both User

crude gyro Oct 23, 2019, 9:16 AM

#

sorry, I'm not very familiar with the new database, I've barely touched it.

#

how the fuck can they both be User

molten bough Oct 23, 2019, 9:17 AM

#

because they're in different apps

crude gyro Oct 23, 2019, 9:17 AM

#

rrrr. Not a fan of that at all.

molten bough Oct 23, 2019, 9:17 AM

#

me neither, but it's a bit too late to change it

crude gyro Oct 23, 2019, 9:17 AM

#

why?

molten bough Oct 23, 2019, 9:17 AM

#

I've been using import x as WhateverUser

#

Well, you'd have to migrate the old data somehow

crude gyro Oct 23, 2019, 9:18 AM

#

why? it's just a name change. the data would stay where it was.

molten bough Oct 23, 2019, 9:18 AM

#

I mean, I don't think you can just rename a table?

#

can you?

crude gyro Oct 23, 2019, 9:19 AM

#

I have no idea why you shouldn't be able to do that

molten bough Oct 23, 2019, 9:19 AM

#

I dunno, I've never seen that

#

I'll google it

#

yup ALTER TABLE table_name RENAME TO new_table_name

#

okay, so I guess you could do that

crude gyro Oct 23, 2019, 9:20 AM

#

yeah, there seems to be a migrations.RenameModel

molten bough Oct 23, 2019, 9:20 AM

#

I will say, though

#

I'm not 100000% happy with this modal because I was unable to dynamically generate the cards

#

even using the code in the allauth templates, I couldn't get Django to iterate over the list of providers

#

because they.. appear to be falsey?

#

I dunno

crude gyro Oct 23, 2019, 9:21 AM

#

I'm not worried about that, we'll probably never add more providers.

molten bough Oct 23, 2019, 9:21 AM

#

Yeah, I figured, I just wanted to build in the possibility to expand

crude gyro Oct 23, 2019, 9:21 AM

#

yeah. and that's a good programmer instinct

#

but not a dealbreaker in this case.

molten bough Oct 23, 2019, 9:21 AM

#

yeah

#

It's in there basically everywhere else anyway

#

the connections API I'd try to make do something similar

#

but the data available for each type of account is different

#

it actually totally just stores a json blob in the database because it's so different, along with a small number of standard values

crude gyro Oct 23, 2019, 9:23 AM

#

sounds acceptable.

molten bough Oct 23, 2019, 9:23 AM

#

if you want to get the github account name

#

it's like

#

github_account.extra_data["name"]

#

but that could probably be standardised as needed in the api endpoint anyway

crude gyro Oct 23, 2019, 9:28 AM

#

gotta run now but excellent work so far anyway

molten bough Oct 23, 2019, 9:30 AM

#

Thanks \o/

exotic ember Oct 23, 2019, 12:34 PM

#

@green oriole hello, re: Ignore Draft PRs in .hackstats
can you show me the query_url you got that you say it work.? I am having trouble getting it to return the correct items

molten bough Oct 23, 2019, 12:35 PM

#

Does hacktoberfest ignore draft PRs? I didn't know that

#

indeed, my current PR was a draft until last night but it's been counted since I first submitted it

green oriole Oct 23, 2019, 12:37 PM

#

Something like this? https://api.github.com/search/issues?q=is:pr+-is:draft

#

Plus all the others args

exotic ember Oct 23, 2019, 12:39 PM

#

https://api.github.com/search/issues?q=-is:draft-label:invalid+type:pr+is:public+author:kosayoda+created:2019-10-01T00:00:00%2B14:00..2019-10-31T23:59:59-11:00&per_page=300

this does not exclude draft PRs

green oriole Oct 23, 2019, 12:40 PM

#

-is:draft+-label:invalid

#

You need a + between draft and label

exotic ember Oct 23, 2019, 12:41 PM

#

cool, that was weird

green oriole Oct 23, 2019, 12:42 PM

#

I suppose github is still parsing the request by splitting on + and then it check if there is a - at the beginning of the arg

molten bough Oct 23, 2019, 12:42 PM

#

you often see spaces in search queries replaced with a +

woeful thorn Oct 23, 2019, 3:34 PM

#

@molten bough where is the Discord oauth redirect uri stored/generated on site?

#

📎 unknown.png

molten bough Oct 23, 2019, 3:35 PM

#

@woeful thorn It's documented in the allauth docs, I can't remember what it is exactly

#

Each provider has their own one

#

You can't configure it

#

But you'll also see it in the oauth URL it takes you to when you try to login

exotic ember Oct 23, 2019, 3:43 PM

#

I pulled new site changes and now I get stuck at Pulling postgres (postgres:12-alpine)... again after running docker-compose up :C

#

restarting the docker service 13 times did the trick

woeful thorn Oct 23, 2019, 3:49 PM

#

Lucky 13

exotic ember Oct 23, 2019, 3:49 PM

#

ModuleNotFoundError: No module named 'allauth'

#

hmm

#

maybe I'll rethingamagick web

hardy gorge Oct 23, 2019, 3:50 PM

#

sync your pipenv

exotic ember Oct 23, 2019, 3:50 PM

#

ah

hardy gorge Oct 23, 2019, 3:50 PM

#

pipenv sync --dev

exotic ember Oct 23, 2019, 3:50 PM

#

yeppers

#

that did not do the job for some reason

hardy gorge Oct 23, 2019, 3:52 PM

#

now rebuild your container

#

I don't know why

#

Ohhh

#

Yes

#

Your container needs to be rebuild, obviously, that's the pipenv we're interested in

tawdry vapor Oct 23, 2019, 6:07 PM

#

I need opinions on the note infraction icon

#

📎 note_01_20.png

#

📎 note_02_20.png

#

📎 note_06_20.png

#

For the paperclip I have various thicknesses but I think that one is best

brazen charm Oct 23, 2019, 6:12 PM

#

can't really distinguish them from my normal viewing distance. The middle one is probably the most recognizable, the paper clip taking a bit more effort and the first is hard to pick up because it's almost all white

woeful thorn Oct 23, 2019, 6:57 PM

#

I like the first one

mellow hare Oct 23, 2019, 6:58 PM

#

I'm also partial to the first one

#

First or second for sure, the third one makes me think "attachment"

tawdry vapor Oct 23, 2019, 7:11 PM

#

A few more

#

📎 note_07_20.png

#

📎 note_08_20.png

#

📎 note_09_20.png

#

📎 note_10_20.png

#

the third is probably the most legible cause it's simple

#

but the question is if it makes sense

#

Maybe make an open envelope for warnings and a closed one for notes

mellow hare Oct 23, 2019, 7:13 PM

#

Ehh, I still think the warning sign triangle thing makes the most sense for a warn

#

And my vote is still for one of the first two you shared

tawdry vapor Oct 23, 2019, 7:14 PM

#

I was considering that, but we use an exclamation for other stuff

#

so it may clash with the meaning of "error"

#

📎 note_11_20.png

woeful thorn Oct 23, 2019, 7:16 PM

#

I think we'll be ok

tawdry vapor Oct 23, 2019, 7:17 PM

#

📎 note_12_20.png

stable mountainBOT Oct 23, 2019, 7:18 PM

#

@tawdry vapor, it looks like you tried to attach a file type we don't allow. Feel free to ask in #community-meta if you think this is a mistake.

tawdry vapor Oct 23, 2019, 7:19 PM

#

📎 note_13_20.png

woeful thorn Oct 23, 2019, 7:19 PM

#

lol

tawdry vapor Oct 23, 2019, 7:19 PM

#

accidentally sent the svg 😄

woeful thorn Oct 23, 2019, 7:19 PM

#

Hacker

green oriole Oct 23, 2019, 8:10 PM

#

Oh IOS client try to resize it, so it just end up being a pixels soup

exotic ember Oct 24, 2019, 3:26 AM

#

thoughts on trash as the message/embed deletion emoji?

#

📎 JPEG_20191024_112534.jpg

tawdry vapor Oct 24, 2019, 3:30 AM

#

I think general consensus is that a trash icon is good, but the twemoji style doesn't look too good

#

So we wanted to explore a custom icon

exotic ember Oct 24, 2019, 3:30 AM

#

that is a custom icon, tweemoji style though

#

.issue 514 bot

dusky shoreBOT Oct 24, 2019, 3:31 AM

#

GitHub

IssueOpen [bot] #514 Custom Trash can reaction to replace red X

exotic ember Oct 24, 2019, 3:31 AM

#

I followed @brazen charm and @crude gyro's suggestion of that tweemoji one with simpler lines

#

probably misread something tbh

#

if anyone of you can give a mockup on the style I can make more attempts

tawdry vapor Oct 24, 2019, 3:32 AM

#

Oh right

#

Honestly I am not the biggest fan, but it certainly does look like twemoji and it's decent enough

#

But the main concern is that it's not that clear to me at a small size

exotic ember Oct 24, 2019, 3:33 AM

#

what do you have in mind? a basket like 🗑 ?

tawdry vapor Oct 24, 2019, 3:33 AM

#

I think a metal trash can is fine

exotic ember Oct 24, 2019, 3:33 AM

#

that looks like a basketball hoop to me

tawdry vapor Oct 24, 2019, 3:33 AM

#

Maybe we can do like even simpler

#

Let me look at fontawesome

#

📎 unknown.png

#

need to get a smaller pic

#

I think the specific issue with yours is that there isn't enough contrast

exotic ember Oct 24, 2019, 3:36 AM

#

I could change the colors and see

tawdry vapor Oct 24, 2019, 3:36 AM

#

at the small size the two greys just blend together and the whole thing looks like a rectangle

#

doesn't help that I am using dark mode 😄

exotic ember Oct 24, 2019, 3:37 AM

#

for clarification, by contrast you mean the contrast between the trashcan and the lines on the trashcan, or the trashcan and discord's dark mode?

tawdry vapor Oct 24, 2019, 3:37 AM

#

Originally I meant the lines

#

but now I realise it's both

exotic ember Oct 24, 2019, 3:37 AM

#

I just realized while making any of my other emojis I neglected to check them out in light mode

wild ridge Oct 24, 2019, 4:49 AM

#

@exotic ember how's it look if you swap the colours?

crude gyro Oct 24, 2019, 5:38 AM

#

@exotic ember I, for one, quite like the one you made.

brazen charm Oct 24, 2019, 5:53 AM

#

Looks pretty good imo maybe a simpler handle and a bigger angle on the lid or bit taller can, but looks fine to me

exotic ember Oct 24, 2019, 7:09 AM

#

@wild ridge trashinverted

wild ridge Oct 24, 2019, 7:10 AM

#

I like the look of that one

#

Could you perhaps make it a tad lighter?

exotic ember Oct 24, 2019, 7:14 AM

#

trashlighter

wild ridge Oct 24, 2019, 7:15 AM

#

me likey

#

@crude gyro thoughts?

crude gyro Oct 24, 2019, 8:25 AM

#

yeah I like that

#

I like it 2000.

molten bough Oct 24, 2019, 8:30 AM

#

That's quite nice

#

Glad you guys are going with my idea like two years later :>

brazen charm Oct 24, 2019, 9:22 AM

#

You came up with it again :P

crude gyro Oct 24, 2019, 9:24 AM

#

yes, thank you @voodude, you are the trash can guy

#

that g is actually short for trash can guy

#

thank you

molten bough Oct 24, 2019, 9:46 AM

#

Haha

#

To be fair your argument was a good one

green oriole Oct 24, 2019, 3:29 PM

#

Oh guys

#

To find a message by id

#

you also need the id of the channel where is was sent

#

I need to go trough my model and add a new field

#

Great.

#

No other way around?

woeful thorn Oct 24, 2019, 3:32 PM

#

Why do you need a new field when you're storing the URL?

green oriole Oct 24, 2019, 3:32 PM

#

I don't store the url

#

I'm working on another thing

#

That's not about the reminder cog

woeful thorn Oct 24, 2019, 3:33 PM

#

Then context would be helpful

green oriole Oct 24, 2019, 3:33 PM

#

Yep

#

This one https://github.com/python-discord/bot/issues/364

GitHub

Offensive word filtering · Issue #364 · python-discord/bot

Once the bot's word filters are triggered, we will need to call a site endpoint to store the ID of the offending message, along with a "delete time" of one week after the ...

#

So for now I created a new model that store the message id and the deletion date

#

But if I want to delete it, I will need the channel ID too

woeful thorn Oct 24, 2019, 3:34 PM

#

Why not store the URL

green oriole Oct 24, 2019, 3:35 PM

#

You can delete a message with his URL?

woeful thorn Oct 24, 2019, 3:35 PM

#

No, but you can get a Message object from its URL

green oriole Oct 24, 2019, 3:36 PM

#

Or I could also loop through channels and try to find the message..

#

Well, I suppose let's go for the URL

#

How can I find a message by it URL?

#

I can't find any docs on it

woeful thorn Oct 24, 2019, 3:43 PM

#

https://discordpy.readthedocs.io/en/latest/ext/commands/api.html#discord.ext.commands.MessageConverter

green oriole Oct 24, 2019, 3:45 PM

#

How do you use that thing? It's a command?

tawdry vapor Oct 24, 2019, 3:46 PM

#

If discord.Message is used as the type annotation for a parameter, then that converter will be used

woeful thorn Oct 24, 2019, 3:46 PM

#

You can see an example in the fun cog: https://github.com/python-discord/seasonalbot/blob/master/bot/seasons/evergreen/fun.py#L117

green oriole Oct 24, 2019, 3:54 PM

#

Storing the URL wouldn't take more place in the database than storing the message ID and the channel ID?

woeful thorn Oct 24, 2019, 3:55 PM

#

I don't think we're doing this on a scale where it really matters either way

green oriole Oct 24, 2019, 4:26 PM

#

What should I pass as context? Because this is a background task, there is no context

#

Apparently it use ctx.bot and ctx.channel if it can't find the channel

#

So I should be able to construct an arbitrary context object right?

green oriole Oct 24, 2019, 5:39 PM

#

@tawdry vapor I don't understand.. If discord.Message is used as the type annotation for a parameter, then that converter will be used.. So I can just add an argument url: discord.Message and the url will be automatically converted to a message object?

tawdry vapor Oct 24, 2019, 5:40 PM

#

I think I misunderstood the context so perhaps ignore me

#

what I said applies when you're taking an argument for a command

green oriole Oct 24, 2019, 5:40 PM

#

Oh an argument for a command okay

#

BTW it turn out to be a bad idea to store the url because the converter want a context that I can't provide

#

I think I'm just going to store the two ids

jade tiger Oct 24, 2019, 8:17 PM

#

You can create a dummy ctx as long as it has the bot attribute if using a url

#

ctx = commands.Context(bot=self.bot)

#

Since MessageConverter will use

Bots message cache
Get channel id from url and use `ctx.bot.get_channel(id).
Get message with channel.fetch_message

#

The only caveat is if the channel doesn't exist (and bot.get_channel returns None) as it will fall back on ctx.channel which gets channel from ctx.message.channel which will raise an Attribute error since the message is None. A dirty fix for that would be to just set ctx.channel to be None manually too

#

Storing the 2 IDs may be easier and more efficient, especially if you're using .history() rather than fetch_message

split meadow Oct 24, 2019, 10:48 PM

#

.issue 299

dusky shoreBOT Oct 24, 2019, 10:48 PM

#

Not likely.

Sorry, but you may only use this command within #bot-commands, #sir-lancebot-playground, #ot0-psvm’s-eternal-disapproval, #ot1-perplexing-regexing, #ot2-never-nester’s-nightmare, #414574275865870337, #542272993192050698.

split meadow Oct 24, 2019, 10:49 PM

#

https://github.com/python-discord/seasonalbot/issues/299 - We may need to take a look at this before I start work on it considering gdude is working on something similar.

GitHub

[Feature Request] Link GH Account · Issue #299 · python-discord/...

The command lets people link their github to their discord. For example I wanted to see Icemans (Rohan's) PR's but couldn't remember his Github. If this command existed then...

molten bough Oct 24, 2019, 10:50 PM

#

The specific thing that's being thought about atm - my PR adds GH account linking to the site, and there was a discussion about adding that connection to the API to be exposed on the Discord API User objects

#

although I note that seasonalbot doesn't actually have API creds

#

so maybe we should talk about that at some point

split meadow Oct 24, 2019, 10:50 PM

#

Unless we integrate it into Python Bot?

molten bough Oct 24, 2019, 10:51 PM

#

hmm, I guess

crude gyro Oct 24, 2019, 11:16 PM

#

yeah we don't really wanna add the site dependency to seasonalbot.

#

but something like a !github command for bot might be fine.

molten bough Oct 24, 2019, 11:33 PM

#

That seems fair

split meadow Oct 24, 2019, 11:33 PM

#

I think that's a shout.

#

Maybe put the full functionality in the PR into the bot itself?

#

In that case what should I do with issue 299? Stall it or close?

exotic ember Oct 25, 2019, 1:28 AM

#

I've transferred it to bot based on new discussion, but we'd still have to wait for gdude's stuff before further implementation discussion

molten bough Oct 25, 2019, 7:11 AM

#

Once the current PR is reviewed and merged, I can start on making the connections available to the API

green oriole Oct 25, 2019, 7:32 AM

#

@jade tiger I tried creating a dummy context, but the code seem to get stuck when it reach it. Do you have a link to the doc for .history()? Ctrl + F doesn't work :)

gusty sonnet Oct 25, 2019, 7:32 AM

#

Are you trying to go through channel.history for a discord bot?

#

If you are @green oriole here's the doc for it - https://discordpy.readthedocs.io/en/latest/api.html#discord.TextChannel.history

#

Take note that this is classified as API abusing - it is requesting data from discord api

green oriole Oct 25, 2019, 7:35 AM

#

For now I just use fetch_channel and get_message

#

I think it will be faster

#

Because it doesn't loop over the history right?

gusty sonnet Oct 25, 2019, 7:35 AM

#

get_channel is faster

#

https://discordpy.readthedocs.io/en/latest/api.html#discord.Guild.get_channel vs https://discordpy.readthedocs.io/en/latest/api.html#discord.Guild.fetch_channels

#

the first is almost O(1) while the 2nd is asking discord api

#

It does not loop over history, yes

#

It'll try to get the object from the bot's current cache

green oriole Oct 25, 2019, 7:36 AM

#

Or it was fetch_message I can't remember

gusty sonnet Oct 25, 2019, 7:37 AM

#

fetch_message is targetting a specific message, it is an API too but yes it can be faster than asking for full history

hollow lichen Oct 25, 2019, 10:04 AM

#

What does return fetch_message when the message is deleted?

gusty sonnet Oct 25, 2019, 10:05 AM

#

Probably a None / it'll raise an Exception

hollow lichen Oct 25, 2019, 10:06 AM

#

I thought it could return the message object, because discord does store deleted messages I think

gusty sonnet Oct 25, 2019, 10:06 AM

#

Raises
--------
:exc:`~discord.NotFound`
    The specified message was not found.
:exc:`~discord.Forbidden`
    You do not have the permissions required to get a message.
:exc:`~discord.HTTPException`
    Retrieving the message failed.```

#

Yep it'll raise exception

hollow lichen Oct 25, 2019, 10:06 AM

#

ok ty

green oriole Oct 25, 2019, 10:22 AM

#

Yep it raise a NotFound

#

How do I calculate the coverage for the site repo?

#

(to make sure it's still 100%)

hardy gorge Oct 25, 2019, 10:23 AM

#

you can run the tests locally, but the best way to do that depends on your set-up

#

You're running it without docker right?

green oriole Oct 25, 2019, 10:24 AM

#

Yep

hardy gorge Oct 25, 2019, 10:24 AM

#

pipenv run coverage run manage.py test to run the tests
pipenv run coverage report -m to get the report after running the tests

molten bough Oct 25, 2019, 10:49 AM

#

holy issue spam batman

brazen charm Oct 25, 2019, 10:49 AM

#

seeing that there are going to be a couple issues for tests, how hard is it to make them? 😄 Could try something after I figure out the docs command properly

green oriole Oct 25, 2019, 10:59 AM

#

99% arg! 😄