#dev-log
1 messages ยท Page 13 of 1
Connected!
GitHub Actions run 5185102475 succeeded.
Connected!
6b1ca47 Bump sentry-sdk from 1.24.0 to 1.25.0 (#1288) - dependabot[bot]
LGTM as well. Thanks for the PR!
GitHub Actions run 5185506832 was cancelled.
GitHub Actions run 5185514152 was cancelled.
Connected!
GitHub Actions run 5196496668 failed.
GitHub Actions run 5197296969 failed.
GitHub Actions run 5197290175 failed.
GitHub Actions run 5197297806 succeeded.
GitHub Actions run 5200304948 succeeded.
GitHub Actions run 5200775415 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5202676817 succeeded.
GitHub Actions run 5207893128 succeeded.
GitHub Actions run 5207896854 succeeded.
GitHub Actions run 5207932171 succeeded.
GitHub Actions run 5208684636 was cancelled.
GitHub Actions run 5208694627 succeeded.
GitHub Actions run 5208726946 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5208738841 failed.
GitHub Actions run 5209166046 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5209335512 succeeded.
GitHub Actions run 5209468981 succeeded.
GitHub Actions run 5210402568 succeeded.
GitHub Actions run 5210416513 succeeded.
GitHub Actions run 5210431627 succeeded.
GitHub Actions run 5210450620 succeeded.
GitHub Actions run 5211545591 succeeded.
GitHub Actions run 5211569643 succeeded.
GitHub Actions run 5211593130 succeeded.
The help embed of the !code command needs to have a preview to be more descriptive, so I've added the colorful embed into the file
GitHub Actions run 5212163161 succeeded.
I'm pretty sure PRs have to have an issue that it addresses to prevent people from working on something that won't be merged anyway, is there an issue that approves this change? If you want to request this change, you can open an issue in python-discord/meta.
5dae506 build(deps): bump pydantic from 1.10.8 to 1.10.... - dependabot[bot]
3468325 Update base Python image - ChrisLovering
[python-discord/site] New branch created: ChrisLovering\-patch\-1
GitHub Actions run 5213923368 succeeded.
GitHub Actions run 5213938540 succeeded.
GitHub Actions run 5213941717 succeeded.
As per @janine9vn it's fine for us to remove the season lock on assigning the below roles:
- Advent of Code
- Lovefest
- Revival of Code
This will mean people can subscribe to the above 3 roles all year round.
Approved by @ChrisLovering during an admin meeting.
I'm fine with anyone implementing this.
[python-discord/bot] New branch created: shenanigansd\-patch\-1
fa014bb make all roles self-subscribable year round - shenanigansd
GitHub Actions run 5217957050 succeeded.
One question I have is whether we think that we'll want to lock roles like this at any point in the future?
If not, we could remove that code entirely, making it easier to maintain.
[python-discord/bot] New comment on pull request #2631: Make all roles self\-subscribable year round
Removed the link to https://github.com/python-discord/bot/issues/2630 that would mean the issue gets closed after this PR is merged, as there's more discussion happening in the issue.
GitHub Actions run 5226031016 succeeded.
7f71213 Make all roles self-subscribable year round (#2... - shenanigansd
[python-discord/bot] branch deleted: shenanigansd\-patch\-1
Connected!
Should we add the license that the package supports as well? I'm unsure how large we want the embed to be for any specific package.
For now, I think the original release date (when the package was created) and supported versions would be great to see.
At this rate, once this is closed, another version is going to be released immediately
I've forgotten that I'm not supposed to update branch, I am very sorry
GitHub Actions run 5229288584 succeeded.
GitHub Actions run 5229289827 succeeded.
GitHub Actions run 5229295825 succeeded.
Connected!
GitHub Actions run 5229308831 was cancelled.
GitHub Actions run 5229315300 succeeded.
Connected!
787ce83 Bump pytest-cov from 4.0.0 to 4.1.0 (#2616) - dependabot[bot]
0c7438a Bump coverage from 7.2.6 to 7.2.7 (#2619) - dependabot[bot]
Connected!
GitHub Actions run 5229334377 succeeded.
Connected!
GitHub Actions run 5229343370 succeeded.
Connected!
GitHub Actions run 5229400766 succeeded.
Two previously mentioned PRs have been merged, along with everything else listed in the main comment of this issue.
9dc4288 Add 'n' alias and 'nom' root alias to 'nominate... - TizzySaurus
[python-discord/bot] New branch created: add\-nom\-alias
About displaying the supported python versions, I think displaying it as a range (e.g. 3.8 - 3.11) would be nice, but the API only returns individual supported versions (under response["info"]["classifiers"], prefixed with "Programming Language :: Python ::"), which would mean some extra processing has to be done. It should also account for packages that don't have support for a version in-between (e.g. 3.8, 3.9 and 3.11), but I think falling back to listing individual versions would be...
This PR adds a !nom root-alias to the !talentpool nominate command, as well as a !talentpool nom and !talentpool n alias. This means staff can now nominate someone via !nom {userid} {reason}, as well as the old !nominate {userid} {reason} etc..
I figured since it's such a small change it doesn't need an issue.
GitHub Actions run 5229499702 succeeded.
[python-discord/bot-core] branch deleted: paste\-api
[bot-core] Branch add\-done\_callbacks\-to\-schedules was force-pushed to `952dc3e`
c57fae8 Handle discord.Forbidden 90001 errors by defaul... - TizzySaurus
[python-discord/bot-core] branch deleted: add\-done\_callbacks\-to\-schedules
[python-discord/bot-core] New tag created: v9\.7\.0
8d14eb4 Update the base image used for dev bot - ChrisLovering
Connected!
46c4966 Don't pin nomination review - vivekashok1221
[python-discord/bot] New branch created: vivek/dont\-pin\-nomination
p.s: bot.utils.messages.pin_no_system_message() isn't used anywhere anymore but I've not removed it.
GitHub Actions run 5231703543 succeeded.
[bot] Branch vivek/dont\-pin\-nomination was force-pushed to `2d5015d`
GitHub Actions run 5231733374 succeeded.
python-discord/bot-core#177 has now been merged, so will be continuing on with this.
371eaa8 Add on-message-event.md - n0Oo0Oo0b
5f83740 Update bot/resources/tags/on-message-event.md - n0Oo0Oo0b
97efc1c Update bot/resources/tags/on-message-event.md - n0Oo0Oo0b
9936d6f Update on-message-event.md - n0Oo0Oo0b
d0ca29e Apply suggestions from code review - n0Oo0Oo0b
This PR is now ready for review! :tada:
GitHub Actions run 5235798197 succeeded.
3096a38 Bump emoji from 2.4.0 to 2.5.0 (#1293) - dependabot[bot]
be9cf10 Bump rapidfuzz from 3.1.0 to 3.1.1 (#1291) - dependabot[bot]
Connected!
GitHub Actions run 5239646606 was cancelled.
Connected!
4d2537e Disable the r/python auto poster - ChrisLovering
[python-discord/sir-lancebot] New branch created: disbale\-reddit\-webhook
Otherwise this will error every morning while r/python isn't accessible
Relevant Issues
<!-- Link the issue by typing: "Closes #" (Closes #0 to close issue 0 for example). -->
Description
Did you:
- [ ] Join the Python Discord Community?
- [ ] Read all the comments in this template?
- [ ] Ensure there is an issue open, or link relevant discord discussions?
- [ ] Read and agree to the [contributing guidelines](https://python...
GitHub Actions run 5241278000 succeeded.
Since we're not starting the loop, do we also need to comment out the self.auto_poster_loop.cancel() call in cog_unload() (and anywhere else)?
No, cancel doesn't error if the task isn't running.
a5d9f4c Disable the r/python auto poster (#1296) - ChrisLovering
[python-discord/sir-lancebot] branch deleted: disbale\-reddit\-webhook
Connected!
GitHub Actions run 5242695842 succeeded.
Connected!
GitHub Actions run 5242795924 succeeded.
GitHub Actions run 5242803775 succeeded.
GitHub Actions run 5242813148 succeeded.
Connected!
GitHub Actions run 5242861157 succeeded.
GitHub Actions run 5242868288 succeeded.
Connected!
GitHub Actions run 5242890832 was cancelled.
792163e Add 'n' alias and 'nom' root alias to 'nominate... - TizzySaurus
[python-discord/bot] branch deleted: add\-nom\-alias
Connected!
Connected!
GitHub Actions run 5243876580 succeeded.
GitHub Actions run 5243888957 succeeded.
GitHub Actions run 5243901477 succeeded.
GitHub Actions run 5243918227 succeeded.
GitHub Actions run 5243933267 succeeded.
b37c18d Bump rapidfuzz from 3.0.0 to 3.1.1 (#2634) - dependabot[bot]
e9f178b Bump pydis-core from 9.5.1 to 9.6.0 (#50) - dependabot[bot]
Connected!
GitHub Actions run 5244032651 succeeded.
Connected!
GitHub Actions run 5244046883 was cancelled.
Connected!
Connected!
Connected!
GitHub Actions run 5246453225 succeeded.
792163e Add 'n' alias and 'nom' root alias to 'nominate... - TizzySaurus
b37c18d Bump rapidfuzz from 3.0.0 to 3.1.1 (#2634) - dependabot[bot]
a5ee8de Bump pydis-core from 9.6.0 to 9.7.0 (#2638) - dependabot[bot]
0091e1e Bump pytest from 7.3.1 to 7.3.2 (#2636) - dependabot[bot]
4b3e42c Bump pydantic from 1.10.8 to 1.10.9 (#2635) - dependabot[bot]
e466b45 Remove unnecessary pinning of nomination review... - vivekashok1221
[python-discord/bot] branch deleted: vivek/dont\-pin\-nomination
Connected!
This is something I forgot to include, or rather did not think of, in my previous PR (#2633)- please forgive.
Trying to unpin a message that's not already pinned does not create any errors, though, from my testing.
GitHub Actions run 5253283327 succeeded.
792163e Add 'n' alias and 'nom' root alias to 'nominate... - TizzySaurus
b37c18d Bump rapidfuzz from 3.0.0 to 3.1.1 (#2634) - dependabot[bot]
a5ee8de Bump pydis-core from 9.6.0 to 9.7.0 (#2638) - dependabot[bot]
0091e1e Bump pytest from 7.3.1 to 7.3.2 (#2636) - dependabot[bot]
4b3e42c Bump pydantic from 1.10.8 to 1.10.9 (#2635) - dependabot[bot]
[python-discord/bot] branch deleted: vivek/dont\-pin\-nomination
2e0f73b Fix missing message unpinning on adding ticket ... - vivekashok1221
GitHub Actions run 5253366949 succeeded.
Connected!
[python-discord/bot] New branch created: pre\-commit\-update\-2\.5\.0\-to\-4\.4\.0
838295d pre-commit-hooks 2.5.0 -> 4.4.0 - Xithrius
GitHub Actions run 5253409776 succeeded.
a7a4ea3 pre-commit-hooks 2.5.0 -> 4.4.0 - Xithrius
[python-discord/site] New branch created: pre\-commit\-update\-2\.5\.0\-to\-4\.4\.0
beff1bb Increase help thread timeout 30 -> 60 - swfarnsworth
[python-discord/bot] New branch created: swfarnsworth/help\-thread\-timeout
We decided after a staff meeting to have help threads time out after 60 minutes instead of 30, as the forum system allows us to have more concurrent help sessions than under the dynamic channel system.
GitHub Actions run 5261549069 succeeded.
GitHub Actions run 5263571675 succeeded.
GitHub Actions run 5266239567 succeeded.
Connected!
[python-discord/bot-core] branch deleted: bump\-d\.py
[python-discord/bot-core] New tag created: v9\.8\.0
GitHub Actions run 5268767381 succeeded.
This is purely a code review, will test later.
My "changes requested" are more of an attempt to make sure that I understand what's happening clearly.
I am not sure I understand the purpose of this statement because it looks like it's taken care of [here].(https://github.com/shtlrs/bot/blob/2226-track-old-votes/bot/exts/recruitment/talentpool/_cog.py#L683-L684) Is it here in case this method is used somewhere else in a different scenario?
I feel like it would be more accurate to use the term active reviews instead of active nominations because active nomination refers to candidates in the talentpool who may or may not be currently undrgoing review in #nominations-voting.
I very vaguely remember the discussion behind this feature so I just want to double check whether the issue has to be raised on the python-discord/mods repo or python-discord/admins (?) repo.
Whenever a vote has passed the upvote threshold, the admins add a ticket to the admin tasks tracker** and not python-discord/mods repo- which is why I'm asking for clarification on which repo stale reviews should be posted.
**I'm not actually sure what the "admin tasks tracker" is, I always...
Or at least that's how I heard the phrase "active nominations" being used.
Okay, admin tasks tracker is the admin-tasks repo.
Yeah, the issue is to be raised on python-discord/admin-tasks, Chris just confirmed.
[python-discord/bot] branch deleted: swfarnsworth/help\-thread\-timeout
c0fa123 Increase help thread timeout 30 -> 60 (#2641) - swfarnsworth
Connected!
GitHub Actions run 5277946857 succeeded.
GitHub Actions run 5289167372 succeeded.
GitHub Actions run 5289713196 succeeded.
Connected!
GitHub Actions run 5296706351 succeeded.
The bot should use new markdown features instead hard coded unordered lists for example:
uses โข it can be replaced by - and markdown would format it same way
# is used to provide additional context to an incident report without creating a new ticket. However, due to the new Discord markdown feature, the messages starting with # turns into heading text
and the messages end up looking huge.
We could use a different prefix or, as suggested by @import-pandas-as-numpy (sudorem on discord), use the message reply feature.
I personally prefer replacing # prefix with message replies.
I don't mind implementing this change myself, ty.
The message reply idea sounds good to me.
I would also say that it's good to keep this [line] (https://github.com/python-discord/bot/blob/main/bot/exts/moderation/incidents.py#L136) up until people get used to using the new way.
It should be as simple as checking whether the message has a resolved attribute or not IIRC.
242cf25 Add supported lexer validation to paste service... - ChrisLovering
[python-discord/bot-core] New branch created: lexer-validation
GitHub Actions run 5305466961 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
[python-discord/bot] New branch created: use-bot-core-paste-service
This is on top of https://github.com/python-discord/bot/pull/2642, so that will need reviewing, and merging first.
GitHub Actions run 5305540362 succeeded.
8d41c1d Added the option for registry_plugins_only (#3247) - sebkuip
1f3bd0e Update changelog and updated all the links to n... - Taaku18
960a36e Lints: update to setup Python v4 (#3243) - SpencerIsGiddy
e919304 Remove python 3.8 and windows/macos lint check.... - Taaku18
b21037c Reminder Plugin (#3254) - martinbndr
8d41c1d Added the option for registry_plugins_only (#3247) - sebkuip
1f3bd0e Update changelog and updated all the links to n... - Taaku18
960a36e Lints: update to setup Python v4 (#3243) - SpencerIsGiddy
e919304 Remove python 3.8 and windows/macos lint check.... - Taaku18
b21037c Reminder Plugin (#3254) - martinbndr
GitHub Actions run 5308336184 failed.
GitHub Actions run 5311015464 succeeded.
this will need rebasing before merging, added tag to make sure this doesn't get merged into feature branch.
GitHub Actions run 5313663378 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5314461218 succeeded.
Currently, it is mandatory for you to put the config file in the same folder as the code. This raises issues in environments such as Kubernetes. This commit allows the user to use CONFIG_LOCATION to change the location of that file, while keeping the current behavior as default.
GitHub Actions run 5319398975 succeeded.
I am interested in implementing this command.
Since we already use Postgres, and we need persistence, I guess we'll have to go with Postgres for the command queue- unless a better alternative is proposed.
Connected!
This raises issues in environments such as Kubernetes.
I'd be interested to know what these issued are, so [I've asked](#dev-contrib message) in Python Discord
1e589e6 Allow changing the config file location with CO... - Akarys42
[python-discord/bot] New branch created: simplify-subscribe
The first commit fixes a bug that would mean if two people run the command at the same time, only the first person will be able to interact with the buttons.
The second commit removes the logic around when a role is available, this was deemed not needed so removing it from the code makes the cog easier to read.
GitHub Actions run 5320464123 was cancelled.
GitHub Actions run 5320465895 succeeded.
d0aa5fa Use the same pride facts for each year - ChrisLovering
[python-discord/sir-lancebot] New branch created: fix-pride-facts
The command args have been changed to accept a number between 1 & 20, rather than a date, to make it easier to select which day of the week you want. This also updates the output of the command so that the selected day, or random is included in the title.
GitHub Actions run 5322031294 succeeded.
557cf80 Bump emoji from 2.5.0 to 2.5.1 (#1300) - dependabot[bot]
4470ccf Bump pydis-core from 9.8.0 to 9.9.0 (#1301) - dependabot[bot]
Connected!
GitHub Actions run 5322103376 was cancelled.
Connected!
GitHub Actions run 5322136030 succeeded.
Connected!
GitHub Actions run 5322154855 succeeded.
GitHub Actions run 5322164802 was cancelled.
Connected!
GitHub Actions run 5322187222 succeeded.
GitHub Actions run 5325041695 succeeded.
Would it be more robust+simpler to just always send the request to get the lexers and cache that, so we don't need to keep the list of supported lexers up to date here? I doubt the extra request would be noticeable.
Not related to this PR, but given the discussion about actual size including syntax highlighting, isn't this logic now not sufficient to catch all pastes that are too large?
Good point, added in this forcepush https://github.com/python-discord/bot-core/compare/ed2c2fad86b8083ce82d7ceee47b4b3e1e256242..240683b9a0b28ea44a05f2740af143a69cf4ac0c
yea true, I've added another check afterwards in this force push https://github.com/python-discord/bot-core/compare/240683b9a0b28ea44a05f2740af143a69cf4ac0c..61375a51ae7ef71ab8d50c380e72c38a820f455d
GitHub Actions run 5325728391 succeeded.
GitHub Actions run 5330611266 failed.
GitHub Actions run 5333236927 failed.
GitHub Actions run 5333395341 succeeded.
GitHub Actions run 5333934032 failed.
Haven't looked into it. This was specifically added in a separate PR here https://github.com/python-discord/infra/pull/20 AllowedIPs existed prior to this PR too.
GitHub Actions run 5334371725 failed.
bd7f838 Update code for new linter rules - ChrisLovering
Now we're using a forum channel, it's much easier to identify the help session you're looking for because they have user generated titles, the user's username, and a preview. I don't think this feature is worth implementing any more, so i'll close this.
If you have a new use case/still think it should be implemented feel free to reopen.
GitHub Actions run 5334950811 failed.
GitHub Actions run 5334992865 succeeded.
I'll close this issue for now, if anyone wants to pursue it further an issue in https://github.com/python-discord/meta first would probably be best so it can get more discussion.
Comment here suggests this may not be correct, and probably the same for some of the other changes (I assume discord.py treats | None the same way as Optional). Not sure exactly what the difference in behaviour would be though.
It probably would be nicer to do use the markdown, although it does look a bit different. It would probably be useful to see an example of how it would look with markdown so we can compare them - if we think it looks worse it's probably not worth changing.
GitHub Actions run 5335598905 succeeded.
The rule abbreviations are stored here https://github.com/python-discord/site/blob/3ee7d072b74b850f798dc19b0205f7073899ac21/pydis_site/apps/api/views.py#L133, so i'll move this to the site repo.
As for adding them, I don't really have an opinion either way, but it sounds fine.
I believe it would be beneficial to add two more shorthands for invoking the 'Rules' embed: "hw" and "eng". "hw" is a common shorthand for "homework", so it should be associated with the embed for rule 8. Likewise, "eng" is a common abbreviation for "English", so it can be linked with rule 4.
One of the changes in dpy 2.3 is
Update
__str__for User to drop discriminators if the user has been migrated.This will break this regex:
I think just removing
#\d{4}would fix it and also be backwards compatible.
Or we could make the digits a non mandator...
[python-discord/bot] New branch created: vivek/incidents-context
GitHub Actions run 5336927166 failed.
Closes #2647.
You can now include additional context to an incident reply by replying to a message and it will not be treated as a separate incident ticket.
I've not removed the previous method of adding additional context (iie, by prefixing # to the message) for now to make transition easier (reporter muscle memory and all that).
Howeverm , IMO, removing it immediately will not inconvenience helpers much and it may also assist in the discovery of this change.
Screenshot:
![imag...
GitHub Actions run 5337172708 succeeded.
7dadf5c Update NOMINATION_MESSAGE_REGEX for new discord... - ChrisLovering
One of the changes in dpy 2.3 is
Update
__str__for User to drop discriminators if the user has been migrated.This will break this regex:
I think just removing
#\d{4}would fix it and also be backwards compatible.
Added a fix for this, to make the #XXXX op...
GitHub Actions run 5337375443 succeeded.
I can reproduce this consistently by running
while True:
with run_gunicorn():
...
and waiting a bit. It seems like with run_gunicorn() can finish before the actual process is dead, allowing a new process to be created which causes an error as the port is still in use by the last process.
run_gunicorn() terminates the process here:
https://github.com/python-discord/snekbox/blob/9804a10a598b678225d299178113210f74a25392/tests/gunicorn_utils.py#L80
Addin...
GitHub Actions run 5337383903 succeeded.
I tested with a few commands, and it seemed to have the same behaviour. haven't tested all of the commands though, and I'm not aware of edge cases that might need changing. Can look further into this another day unless someone gets there first.
[python-discord/bot] New branch created: compf_pings
GitHub Actions run 5337442052 succeeded.
Connected!
I think it makes a difference with keyword only arguments: Without | None you will get an error for anything that doesn't match the converter, e.g. !clean bots 1121140691930726520 a b c says Channel "a" not found.. With | None it is just ignored so you don't get the error.
16d0dff Add supported lexer validation to paste service... - ChrisLovering
[python-discord/bot-core] branch deleted: lexer-validation
[python-discord/bot-core] New tag created: v9.9.0
[python-discord/bot] New branch created: fix_domain_filter
The extraction of domains from a message in the filterlist removes casing, but the checks of individual filters kept theirs, which led to some filters not working.
This assumes that two URLs that differ only by casing are identical, which isn't necessarily true, but a conflict is very unlikely.
Nice, I think it's fine to still allow a # for now personally.
GitHub Actions run 5337782341 succeeded.
[python-discord/bot] branch deleted: vivek/incidents-context
[bot] Branch dependabot/pip/ruff-0.0.274 was force-pushed to `a3b688b`
Ah, some more testing, it matters for any args, not just keyword only. If there's a convertor error it just gets ignored.
GitHub Actions run 5337808744 succeeded.
[bot] Branch dependabot/pip/ruff-0.0.274 was force-pushed to `1ed60bd`
[bot] Branch dependabot/pip/pydis-core-9.8.0 was force-pushed to `2e9c441`
GitHub Actions run 5337819027 was cancelled.
GitHub Actions run 5337823504 succeeded.
Connected!
Should domain be lowercased too, since it's derived from self.content?
Yeah you're right 743f2ce
GitHub Actions run 5337907663 succeeded.
[python-discord/bot] branch deleted: fix_domain_filter
[bot] Branch dependabot/pip/ruff-0.0.274 was force-pushed to `78a2ce3`
[bot] Branch dependabot/pip/pydis-core-9.8.0 was force-pushed to `0d104ae`
Connected!
GitHub Actions run 5338266940 succeeded.
Thank you for investigating this. We should have a timeout to prevent the test from running forever. What will happen if it times out and we do not raise an error (because we cannot determine whether it timed out)? Will it then fail with the original error described by this issue?
Summary
This PR fixes two broken links present in the contributing guide.
GitHub Actions run 5344080020 succeeded.
932f5aa Fix broken links in the contributing guide. (#1... - Qwerty-133
3e57861 Notify user leaves, kicks and joins in threads ... - Qwerty-133
[python-discord/modmail-plugins] branch deleted: notify-fix
I've looked into it a bit more and tried a few things. For each test i just ran
while True:
with run_gunicorn():
pass
Test 1 - just proc.join
proc.terminate()
s = time.time()
proc.join(40)
print(time.time() - s)
- The error never seems to appear.
proc.joinmostly takes less than 0.5s, but occasionally takes just over 30s, sometimes along with a warning saying a gunicorn worker was killed. [30s is the d...
[python-discord/snekbox] New branch created: fix-status-badge
Alternatively could use "https://img.shields.io/github/actions/workflow/status/python-discord/snekbox/main.yaml" if we want the label to be "build" (or something else) instead of just "main".
Running python -m unittest tests/test_integration.py gives this error
root@snekbox_dev:/snekbox# while true; do python -m unittest tests/test_integration.py; done
/root/.local/lib/python3.11/site-packages/falcon/media/__init__.py:4: DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13
from .handlers import Handlers
2023-06-22 11:59:55,203 | 8983 | gunicorn.error | ERROR | Exception in worker process
Traceback (most recent call last):
...
[python-discord/snekbox] branch deleted: fix-status-badge
GitHub Actions run 5345817536 succeeded.
[python-discord/snekbox] New branch created: fix-integration-tests
Closes #179
Closes #177
Open to trying a different approach if preferred.
9aabf20 Fix GitHub Actions status badges - wookie184
[python-discord/site] New branch created: fix-status-badges
GitHub Actions run 5346670481 succeeded.
A ducky with a skull :skull:
A small shade is added to the body to increase the contrast of the skull teeth. (otherwise you can't see them at all, especially in the small version)
GitHub Actions run 5347063321 succeeded.
3ab4808 New version to allow new changeset to be pushed... - ChrisLovering
[python-discord/bot-core] New branch created: patch
df15245 New version to allow new changeset to be pushed... - ChrisLovering
[python-discord/bot-core] branch deleted: patch
[python-discord/bot-core] New tag created: v9.9.1
GitHub Actions run 5347184175 failed.
17a82d9 Bump pydis-core from 9.7.0 to 9.8.0 - dependabot[bot]
c868811 Write custom get_role func for MockMember - ChrisLovering
5f182ed Update MockAttachment data with new expected fi... - ChrisLovering
0d104ae Update NOMINATION_MESSAGE_REGEX for new discord... - ChrisLovering
65f38f9 Merge pull request #2642 from python-discord/de... - shtlrs
GitHub Actions run 5347949334 succeeded.
Connected!
GitHub Actions run 5348312520 succeeded.
Can try to kill the process afterwards in case it timed out? So ultimately, we are first trying to gracefully stop it with terminate, and if that fails, we kill it.
GitHub Actions run 5350529642 was cancelled.
GitHub Actions run 5350534121 succeeded.
Connected!
[bot] Branch dependabot/pip/ruff-0.0.274 was force-pushed to `8b7ea6e`
1c2d03b Bump ruff from 0.0.274 to 0.0.275 (#1004) - dependabot[bot]
f54e6ab Bump sentry-sdk from 1.25.1 to 1.26.0 (#1005) - dependabot[bot]
GitHub Actions run 5354236816 succeeded.
GitHub Actions run 5354244400 was cancelled.
GitHub Actions run 5354249952 succeeded.
GitHub Actions run 5354260362 failed.
3a10f40 Kill process after waiting for it to terminate - wookie184
It looks like there are still some in clean.py, management.py and silence.py that need fixing.
GitHub Actions run 5355632228 failed.
GitHub Actions run 5355635789 succeeded.
GitHub Actions run 5355641728 succeeded.
GitHub Actions run 5356621071 succeeded.
[bot] Branch dependabot/pip/ruff-0.0.274 was force-pushed to `e865521`
[bot] Branch dependabot/pip/ruff-0.0.274 was force-pushed to `966c851`
Ah yea, those should be fixed now.
Thoughts on something like this instead? Front facing to keep the same :skull: style to avoid weird perspective issues, looks like its turning its head
I redid the skull to avoid licensing issues
Front facing to keep the same skull style
But all the other duckies are facing left. Not sure how to make it work with the skull
I redid the skull to avoid licensing issues
I though twemoji were under a creative commons license https://github.com/twitter/twemoji/blob/master/LICENSE-GRAPHICS
@kosayoda that looks pretty nice imo.
Also, we should be fine using Twemojis (like in a lot of our other assets). I'm under the impression that the way we're using it here is allowed, especially since we give credits in this repo.
But all the other duckies are facing left. Not sure how to make it work with the skull
I think facing it left makes it thematically different from :skull: (I'm assuming that's the reason for ducky_skull), also ducky_sphere isn't strictly left facing either
I though twemoji were under a creative commons license...
Also, we should be fine using Twemojis (like in a lot of our other assets)....
whoops, wasn't sure what license applied off the top of my head
I'm fine with ei...
GitHub Actions run 5358744917 failed.
But all the other duckies are facing left
Actually ducky_sphere is an exception
Connected!
GitHub Actions run 5363073338 was cancelled.
Connected!
GitHub Actions run 5363422587 succeeded.
[bot] Branch dependabot/pip/ruff-0.0.274 was force-pushed to `600e85e`
GitHub Actions run 5366116219 succeeded.
Since the migration of the help system to a forum channel, the question "Why are the help channels named after elements/food?" is obsolete now. This PR removes it from the FAQ page.
GitHub Actions run 5367427624 succeeded.
Connected!
[python-discord/site] New branch created: add-new-rule-aliases
See suggestion in #1001.
Closes #1001.
GitHub Actions run 5368447825 succeeded.
Merci, omelette au fromage.
- Reset the first_post_date when the event ends naturally, same as when it is stopped manually. Otherwise it's treated as preexisting configuration when the event is started the next year.
- Force-posting the last puzzle now doesn't attempt to start the event afterward. Just something I came across while testing.
GitHub Actions run 5372443059 succeeded.
GitHub Actions run 5373835218 succeeded.
dac3024 Don't have interaction_owner as a class var - ChrisLovering
eae9f4b Remove logic around when a role is available - ChrisLovering
b18570f Swap the order of interaction resposnes in sub cog - ChrisLovering
75f1bad Merge branch 'main' into simplify-subscribe - minalike
c8bcc63 Merge pull request #2650 from python-discord/si... - minalike
[python-discord/bot] branch deleted: simplify-subscribe
Connected!
Hi there @Canttuchdiz, are you still interested in writing this feature?
GitHub Actions run 5378524689 succeeded.
I realise I never responded to this. What I meant was we don't need this init function specifically, as there's no need to set confirmed to None.
when we wait for this view we can do timed_out = await confirmation_view.wait() then check if timed_out first, meaning that will cover the case where confirmed isn't set.
Connected!
Removed the unnecessary __init__ as per @ChrisLovering 's suggestion and made the bot delete the buttons after the timeout as per @wookie184 's suggestion. Thanks!
GitHub Actions run 5386343569 succeeded.
[python-discord/sir-lancebot] Pull request review submitted: #1223 Undeprecate bookmark text command
small change, otherwise looks good
permissions = target_message.channel.permissions_for(ctx.author)
We care about the channel the message the user is trying to bookmark, now the channel they're running the command in.
log.info(f"{ctx.author} tried to bookmark a message in #{target_message.channel} but has no permissions.")
Ah, this should be getting done by bot-core automatically, but I notice that it only gets done on timeout. I'll update bot-core so that it works on stop too, could you remove this line and the similar one in cancel()?
I don't think we need this message, since feedback is managed by the ban command itself.
d7eede3 Remove view from ViewWithUserAndRoleCheck.messa... - ChrisLovering
GitHub Actions run 5389029944 succeeded.
Connected!
Connected!
GitHub Actions run 5400282909 succeeded.
GitHub Actions run 5401361709 succeeded.
[python-discord/branding] New branch created: snake-day
Adds branding for Snake Day, July 16th. The snake assets are also included separately from the event branding, so if we'd like to use the snake icon or text in the future, they're all here ๐๐๐
Preview
_Fun fact: I had to create a custom font with the cha...
GitHub Actions run 5412779945 succeeded.
GitHub Actions run 5413422358 succeeded.
I don't fully understand this. Won't this hang the certbot hook forever? Do we not want this to push to the hosts instead of waiting them to pull?
like, I understand that rsync is started below in the hook - but do we actually have a guarantee that they will all be ran at the same time? If not, do we need the rsync server or can we just rely on rsync to start it over e.g. -e ssh?
GitHub Actions run 5419369719 failed.
I see no issues in this implementation. Very cool, thank you Chris.
0065fb7 Bump emoji from 2.5.1 to 2.6.0 (#1308) - dependabot[bot]
Connected!
GitHub Actions run 5425214488 succeeded.
Should this be moved to botcore? I see we do have a test suite there.
Yea, would likely make sense to live in there
Other than moving the tests, seems good to go
fc9cdea Update expiry label from 1 month to 30 days - ChrisLovering
[python-discord/bot-core] New branch created: expiry-label
Since there isn't 1 true answer to how many seconds are in 1 month, making it 30 days is just easier.
f80a263 Update expiry label from 1 month to 30 days (#185) - ChrisLovering
[python-discord/bot-core] branch deleted: expiry-label
[python-discord/bot-core] New tag created: v9.9.2
3717476 Bump bot-core to 9.9.2 - ChrisLovering
GitHub Actions run 5435507542 succeeded.
Description
Incorrect Type Annotations, in following lines:
- https://github.com/python-discord/sir-lancebot/blob/main/bot/utils/halloween/spookifications.py#L9
- https://github.com/python-discord/sir-lancebot/blob/main/bot/utils/halloween/spookifications.py#L20
- https://github.com/python-discord/sir-lancebot/blob/main/bot/utils/halloween/spookifications.py#L30
- https://github.com/python-discord/sir-lancebot/blob/main/bot/utils/halloween/spookifications.py#L52
- https://github.com/...
GitHub Actions run 5443330123 succeeded.
GitHub Actions run 5443333703 failed.
GitHub Actions run 5443338208 succeeded.
GitHub Actions run 5446575301 succeeded.
401ba37 Defer fetching webhooks for python news until f... - ChrisLovering
3f64185 Defer fetching webhook for buck pond until firs... - ChrisLovering
80c7bbc Use get_or_fetch channel for getting big brothe... - ChrisLovering
1b7a652 Defer fetching peps until first time command is... - ChrisLovering
a7beb67 Don't load extensions in a task - ChrisLovering
[python-discord/bot] New branch created: optimise-startup-time
The 4 cogs that I have modified here were taking ~1 second to load. As only so many tasks can run at once, this slowed down startup time by a decent amount.
GitHub Actions run 5448738168 succeeded.
GitHub Actions run 5448751276 succeeded.
If you wanted to raise a PR for this feel free to do so.
74303c4 Additional potential symbols in valid invites - mbaruh
[python-discord/bot] New branch created: invite-symbols
Add underscores and dashed as valid symbols in invite codes.
GitHub Actions run 5449618994 succeeded.
Connected!
GitHub Actions run 5450997111 failed.
GitHub Actions run 5451517589 succeeded.
Doc item doc_item.symbol_id='grammar-token-python-grammar-key_datum' present in loaded documentation inventories not found on site, inventories may need to be refreshed.
GitHub Actions run 5452787420 failed.
GitHub Actions run 5454888915 failed.
What are the issues with the first four links you gave?
Relevant Issues
Fixes #1309
Description
This PR is no code change. It fixes incorrect type annotations.
Did you:
- [x] Join the Python Discord Community?
- [x] Read all the comments in this template?
- [x] Ensure there is an issue open, or link relevant discord discussions?
- [x] Read and agree to the contributing guidelines?
from PIL import Image
...
def inversion(im: Image) -> Image:
...
Image is module here. The actual function is Image.Image
The correct annotation should be:-
from PIL import Image
...
def inversion(im: Image.Image) -> Image.Image:
...
GitHub Actions run 5456948342 succeeded.
GitHub Actions run 5463058785 failed.
GitHub Actions run 5464929494 failed.
GitHub Actions run 5464933804 failed.
GitHub Actions run 5464938598 succeeded.
[python-discord/bot] New branch created: phishing_button
Adds a button to the mod alert when there's a chance this is a phishing attempt. Pressing the button will compban the user and add the appropriate content as an autoban filter.
Additionally, when adding an invite filter, if the given content isn't in the discord.gg/ pattern, it will instead take it as the invite code itself as long as it doesn't contain spaces.
GitHub Actions run 5466510380 succeeded.
GitHub Actions run 5471713909 succeeded.
GitHub Actions run 5474322565 failed.
Connected!
GitHub Actions run 5475098102 succeeded.
Connected!
b44bbac Bump sentry-sdk from 1.26.0 to 1.27.0 (#1315) - dependabot[bot]
a9dd0d2 Bump sentry-sdk from 1.26.0 to 1.27.0 (#2664) - dependabot[bot]
GitHub Actions run 5475118080 failed.
GitHub Actions run 5475131486 failed.
GitHub Actions run 5475132985 succeeded.
GitHub Actions run 5475136773 succeeded.
[python-discord/bot] New branch created: undo-sentry-sdk-update
cbcfc61 Revert "Bump sentry-sdk from 1.26.0 to 1.27.0 (... - wookie184
[python-discord/sir-lancebot] New branch created: revert-1315-dependabot/pip/sentry-sdk-1.27.0
Reverts python-discord/sir-lancebot#1315
GitHub Actions run 5475248344 succeeded.
GitHub Actions run 5475273336 succeeded.
Connected!
Connected!
GitHub Actions run 5475471237 succeeded.
[python-discord/sir-lancebot] New branch created: upgrade-pydantic-2
Currently this doesn't work due to https://github.com/pydantic/pydantic-settings/issues/106. A PR fixing that was merged so just waiting for a release.
GitHub Actions run 5477691122 succeeded.
GitHub Actions run 5477983125 succeeded.
[bot] Branch dependabot/pip/ruff-0.0.277 was force-pushed to `cc12799`
b3ce995 Bump ruff from 0.0.275 to 0.0.277 (#2667) - dependabot[bot]
GitHub Actions run 5479895877 succeeded.
GitHub Actions run 5479921216 failed.
GitHub Actions run 5483248663 succeeded.
GitHub Actions run 5485482936 succeeded.
[python-discord/site] Issue opened: #1015 Discord Button Shifts Off-Page at 1024-1040px Screen Width
Summary: When the screen width is between 1024 and 1040 pixels, the Discord button shifts to the right beyond the edge of the main page.
Environment: win10, screen resolution 1024x768, browser: Chrome 114 latest
Step to reproduse: 1. Open a web browser.
2. Enter the URL https://www.pythondiscord.com/ in the address bar.
I've tried emulating this with a 1024x768 viewport on both chrome & firefox but could not reproduce. You mentioned that chrome is on the latest version, but i see that there is an Update message in the top right. Could you try updating and try again?
If that still doesn't work, could you open console and run console.log($(window).width(), $(window).height()) and send the results here?
Output from the console:
console.log($(window).width(), $(window).height())
VM308:1 Uncaught TypeError: Cannot read properties of undefined (reading 'width')
at <anonymous>:1:22
(anonymous) @ VM308:
1
The previous screenshot was taken in browserstack, and here is another one from my browser:
GitHub Actions run 5486513655 failed.
Connected!
Before: <img width="592" alt="image" src="https://github.com/python-discord/bot/assets/52790953/0bfe56af-d863-42be-a785-68a622d1e707">
After:
<img width="597" alt="image" src="https://github.com/python-discord/bot/assets/52790953/8718907d-ed4b-4d18-b9b2-fd66f2a491c7">
I want to do this issue, can I?
This makes the actor of the ban the bot, but I think it should be the moderator instead.
Looks good, had to double check that - wouldn't be interpreted as a range but seems to work fine since it's at the end.
I can also reproduce this. The main solutions I can think of are:
- Collapse to using a hamburger menu a bit sooner.
- Somehow reduce the padding on each of the navigation buttons when they don't fit. I don't think we want it to look different at larger sizes so they would need to only be closer when it doesn't fit.
The first sounds like it should be easier.
I'll also change it to use the class kwarg to set the env_prefix now that will be supported, since it looks pretty neat https://github.com/pydantic/pydantic-settings/issues/110
@vivekashok1221 Yeah I think Postgres is probably the way to go, I've assigned you ๐
@vivekashok1221 Are you still planning on working on this?
This needs to be before the previous check, otherwise .lower() will be called on the integer and cause an error.
Connected!
74e3e68 Use built in timeout handling for aiohttp inste... - wookie184
43cf31b Fix: stop using deprecated PIL .getsize method - wookie184
17303df Fix and simplify 'disambiguate' utility - wookie184
cb87d90 Type hint pagination as allowing float timeout - wookie184
d45356f Handle snakes without images - wookie184
[python-discord/sir-lancebot] New branch created: snakes-cleanup
Relevant Issues
None
Description
I was only planning on replacing async_timeout for aiohttp with ClientTimeout since it's now the preferred way, but accidentally found 3 bugs in the process:
.snakes carddidn't work any more due to a function being removed from PIL.snakes card(once fixed) sometimes fails due to an image not being found for the snake.snakes card(once fixed again) when passing an argument, it can ask you to select a number but it just... didn't...
Sentry Issue: SIR-LANCEBOT-A6
AttributeError: 'FreeTypeFont' object has no attribute 'getsize'
File "bot/exts/fun/snakes/_snakes_cog.py", line 1011, in card_command
final_buffer = await self.bot.loop.run_in_executor(None, func)
File "bot/exts/fun/snakes/_snakes_cog.py", line 245, in _generate_card
offset += CARD["font"].getsize(line)[1]
Unhandled command error: 'FreeTypeFont' object has no att...
GitHub Actions run 5494895253 succeeded.
discord.ext.tasks.loop automatically reruns tasks by default on some errors. The implementation doesn't seem great though because:
- The error is never logged.
- There is no limit on the number of times it will retry.
- The error may not be something that will be fixed by retrying.
A solution would be to default to not reconnecting. A util in botcore gives us more flexibility to change how things...
[python-discord/bot] New branch created: fix-test-warnings
Currently these warnings are raised when running tests:
tests/bot/exts/backend/test_logging.py::LoggingTests::test_debug_mode_false
tests/bot/exts/backend/test_logging.py::LoggingTests::test_debug_mode_true
C:\Users\wookie\Documents\GitHub\bot\bot\exts\backend\logging.py:18: RuntimeWarning: coroutine 'Logging.startup_greeting' was never awaited
scheduling.create_task(self.startup_greeting(), event_loop=self.bot.loop)
Enable tracemalloc to get traceback where the object...
GitHub Actions run 5495545983 succeeded.
Wow, blast from the past. Totally forgot about this one, sorry.
I can still work on this issue but not in the immediate future. Maybe I can give it a look after a few days.
Thank you Wookie.
Just letting you know, I'll need a few days to address this issue as I have some stuff going on right now.
GitHub Actions run 5496439006 failed.
We'll need to define exactly what we want to do with the exception.
The thing is, our error handler handles errors raised inside commands, which isn't the case for tasks.
We could generate a "fake context", but I'm unsure of how good of an idea that is.
What we also do is override the Loop class' on_error callback and define the "generic" exception handling there.
We'd then have, in pydis_core.ext.tasks
from discord.ext.tasks import Loop as BaseLoop, LF
from disco...
GitHub Actions run 5498248452 succeeded.
Connected!
GitHub Actions run 5498957725 was cancelled.
GitHub Actions run 5498959448 succeeded.
This is now available in the unban command, so I'll close this.
@MarkKoz Do we still want this now that the help system has been migrated to posts and there are no '' race conditions '' between users.
If not, we can close it as completed
The YAML config file has been deleted in favor of using Pydantic settings. Some unused variables have been deleted as well.
We also botstrap the config for users automatically now so it's not really daunting anymore.
That said, I think this issue is resolved so I'll be closing it
a3d2204 Drop redirect usage from URL references - jchristgit
[python-discord/site] New branch created: drop-redirect-url-refs
Just one separate, and present beforehand, broken link remains:
$ httrack -E --robots=0 --spider http://127.0.0.1:8000 -v | grep 404
20:18:51 Error: "Not Found" (404) at link 127.0.0.1:8000/events/game-jam-2020/technical-requirements/ (from 127.0.0.1:8000/events/game-jams/2020/judging/)
Closes #681.
GitHub Actions run 5501304870 succeeded.
3dfe02f Use the same pride facts for each year (#1302) - ChrisLovering
[python-discord/sir-lancebot] branch deleted: fix-pride-facts
Connected!
Prediction: One day our CI will show useful information.
[python-discord/site] New branch created: fix-postegresql-typo
GitHub Actions run 5501812169 succeeded.
GitHub Actions run 5502547652 succeeded.
Should I also remove the response that says "Cancelled infraction" if the invoker hits the "Cancel" button?
GitHub Actions run 5502661561 succeeded.
GitHub Actions run 5502752246 was cancelled.
GitHub Actions run 5502755275 succeeded.
GitHub Actions run 5502765527 succeeded.
Will the fact that this is async break any existing usage of this class? The regular discord.py discord.ui.View class's .stop() method is sync, so anything using this class's stop method before this change would be sync.
GitHub Actions run 5502906697 succeeded.
@ChrisLovering I've tested this locally with the changes from https://github.com/python-discord/bot-core/pull/184 and it works, save having to change the .stop to be asynchronous. Might the change in https://github.com/python-discord/bot-core/pull/184 break this functionality anywhere else in the codebase?
Nah, the cancel makes sense as it is, it was just eh double feedback message from the confirm that looks strange to me.
Good point. I've just updated that PR to make stop() synchronous to avoid this issue.
GitHub Actions run 5507132812 succeeded.
GitHub Actions run 5508373503 succeeded.
GitHub Actions run 5509902072 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5510097961 succeeded.
bedbf38 Fix broken link found by httrack - jchristgit
[python-discord/site] New branch created: fix-broken-link
GitHub Actions run 5510137983 succeeded.
GitHub Actions run 5510448771 succeeded.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5510460108 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
58a72c4 Fix broken link found by httrack (#1018) - jchristgit
[python-discord/site] branch deleted: fix-broken-link
GitHub Actions run 5511302591 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
[python-discord/bot] New branch created: remove-caching-util
The implementation of AsyncCache in bot and bot-core is the exact same.
This is a first step in cleaning up our projects & porting the commun utils in bot-core
GitHub Actions run 5511733681 succeeded.
f021fb8 delete duplicate services module - shtlrs
[python-discord/sir-robin] New branch created: remove-duplicate-services-module
We have the pastebin service module duplicated, one at root level & one at the utils package level.
This PR removes it.
GitHub Actions run 5511830933 succeeded.
The linter changes shouldn't be necessary if you have the latest version of ruff installed (and they are not correct as they change the behaviour of the converters, see https://github.com/python-discord/bot/pull/2651#discussion_r1237109667).
GitHub Actions run 5511872778 succeeded.
The linter changes shouldn't be necessary if you have the latest version of
ruffinstalled (and they are not correct as they change the behaviour of the converters, see #2651 (comment)).
Good catch red ranger, I've undone it.
