finite star
Auto sell feature doesn't pay you for the cards you're trying to sell. Rewarding only a portion if anything.
Additionally the option to remove some cards from your auto sell isn't availible and I have to hide them in decks so they don't get auto sold.
Additionally removing some cards from the deck has them show up in inventory but they dont have the option to put into auto sell or be sold
And upon entering and exiting the interface the card disappears
This is the save
quaint glacier
@spice pollen can you check this out? Looks like you changed some of the autosell logic recently
spice pollen
I'm out of town for a couple days but I might have some time to dig into it soon.
quaint glacier
I wasn't able to reproduce it with my save, but didn't try super hard to have autosell cards in decks or anything
spice pollen
Well, first weird observation - you have a bunch of cards in your "unsorted junk" deck that aren't considered part of your collection. I'm not sure how that happened.
Only ~183 cards actually are counted as part of your collection, which is confusing the hell out of other things when they're in your deck and auto-sell list but not in your collection.
The option to remove auto-sell cards apparently isn't showing up because of a bug where it's being bundled with the option to add more copies to the auto-sell list. And that option isn't showing up because you aren't supposed to be able to move a card to auto-sell if you have no "sellable" copies. Your sellable copies is the number of copies in your collection, minus the number in whichever needs the most copies of it.
So that's failing on two counts, one because you for whatever reason don't actually have copies of the card, and again because all your cards are in a giant deck with a couple thousand phantom cards in it.
Did you somehow mark cards as auto-sell while they were in a deck (or mark them as auto-sell then somehow move them to a deck), then sell them all without removing them from that deck?
Removing these phantom cards from the deck just loses them entirely because they are in the deck but not the collection.
Very weird situation. Cleaning up the auto-sell list is do-able but the main issue here is how your cards ended up like this to begin with.
I can experiment more later but if you have other info feel free to share it
finite star
how ive been playing this is that ive been marking them as auto sell but never actually selling them, and if i wanted to fish a card out of the "trash" so to speak I would unmark them.
I havent touched the sell all since i reloaded after i expected to get something like 12,000 gold and only got 2200
spice pollen
Did you move cards in the auto-sell into a deck?
finite star
Maybe im not sure. I havent needed to fish anything out of the bin for a while. Ive only put the cards there after the auto sell wouldnt give me anything, and Auto sell wont sell cards that are in decks
spice pollen
For whatever reason, you don't really own copies of most of the stuff in that deck. I'll need to check the code later but my current hypothesis is that [auto-]selling a card isn't removing it from its deck. But if you then remove it from the deck, it'll be interactable in the collection until you close and reopen the editor. Interacting with those ghost cards might have caused even more desyncs with the auto-sell list.
finite star
I see
well thats unintuitive
if they were sold i wonder why I didnt get any money for them
quaint glacier
It just sounds like a bug
spice pollen
Yes there's at least one bug at the root of all this. Need to figure out the exact cause and scope of its ramifications, then figure out what to do about people affected by it.
Safest is probably to just give everyone's collections the cards that their decks and auto-sell lists need. Shouldn't turn into an infinite money bug so long as we fix the original issue.
finite star
my best guess is that i had too many cards in the auto sell pile
and thats what caused the issue
also i seem to have persistent phantom cards just in my main collection
spice pollen
I was using the term phantom cards to mean cards that aren't in your main collection, but are in decks and auto-sell (which should be subsets of your collection).
spice pollen
What version of Forge are you using?
finite star
What version of Forge are you using?
Nightly
spice pollen
When was it updated last?
finite star
This morning
spice pollen
Is that the version the save comes from?
finite star
Yes
finite star
I guess when I say phantom i mean they show up in the collection but I can't sell them
No option to sell
spice pollen
That would happen if all copies of a card are used in a deck other than the one you're editing.
finite star
I only have the one deck
The other "deck" is everything that wouldn't come out of the auto sell
And i haven't touched that since i made it
spice pollen
As I recall, that "deck" has a copy of Death-Hood Cobra in its sideboard. So if you're editing "Green", you'll see the cobra in your collection, but you can't sell it because it's in use by the other deck. Can maybe look into adding more clarity there but that's what's going on.
spice pollen
Alright, PR's submitted. https://github.com/Card-Forge/forge/pull/7799
I'm not sure it's a complete fix for the root cause, but once its merged it should clean up your save when you load into it.
Once you do, I suggest deleting that unsorted junk deck so you can sell the cards in it.
finite star
Thanks
finite star
Has this nit been merged?
spice pollen
Not yet, no. Just guessing but I imagine the idea was to leave the PR until after the upcoming release since it modifies cards in players' adventure saves. If something goes wrong, damage is lessened if it's in a snapshot versus a full release.
finite star
Okay.