Can we talk about Roshan?

[ocean walrus]

With 7.33, Valve changed Rosh's implementation. Instead of only needing npc_dota_roshan_spawner, it now needs some info_player_start_dota Dota entities called roshan_location_1 and roshan_location_2. Even then, the client will crash when Roshan attempts to change locations unless there are two portals on the map. Even then even then, Roshan doesn't seem to know how to go through the portals properly and you get weird behaviour.

It looks like if you want to make a traditional Rosh pit, you need to handle the Roshan respawning yourself. This kind of sucks because it means the Roshan respawn timer for spectators and TA's innate won't work, but that's a minor issue. The other thing is that if you spawn Rosh with CreateUnitByName, then he won't have the correct AI. So fine, you also need to create a timer and do the AI yourself, whatever. The problem that I can't see a way to fix is that Roshan seems to be hard coded to not have any aggression when it turns to daytime. I guess Valve did this so that he wouldn't fight while he's travelling, but then they didn't give us any control to say whether he's travelling or not.

Is Roshan basically unusable now or is there something I'm missing?

(Even if not I thought it would be good to make this thread so anyone searching for Roshan in the future will see it's not just them.)

[languid valley]

what do you mean about "traditional roshan pit"?
behaviors like before 7.33 or after?

[ocean walrus]

Before 7.33, but after 7.33 is also complicated to replicate.

[wooden void]

I just recreated the old rosh pit.

I took the map from the old dota client (patch 7.28), restored the prefabs, and took from the prefab of the current dota (7.37) spawners. but to make them work correctly they need to be taken out of the prefabs.

[ocean walrus]

Whoa that's huge. That's really smart to just check the old map. I'm going to have to remind myself how to download that. I'll try it out when I get back today.

[ocean walrus]

Do you understand how you were able to make it not crash? When I have those info player_start_dota entities, my client crashes when it turns to daytime unless there are also the portals.

[wooden void]

Roshan's teleportation ability can't be removed, if your mode doesn't require him then just do so: ```txt
"DOTAAbilities"
{
"roshan_teleport"
{
"BaseClass" "ability_lua"
}
}

[ocean walrus]

What???? Thanks a lot, this works. But how did you find out about this? roshan_teleport is not in npc_abilities.txt

[wooden void]

But how did you find out about this?
from fear of god where they're trying to make patch 7.28.

roshan_teleport is not in npc_abilities.txt
It's there

[ocean walrus]

??????????? I'm so confused
Thanks so much though

[wooden void]

you may have an old file

[ocean walrus]

Oh maybe? I'll try deleting it and then verifying cache

[wooden void]

use Source2Viewer to look at the current Dota files.

[ocean walrus]

is that how you decompiled the 7.28 map?

That's probably useful

[wooden void]

No, I downloaded the old client from telegram channel and in the content folder there was a map, it just had to be restored)

[ocean walrus]

ah okay

There are all the old map files in game/dota/maps, but they're .vpk

[wooden void]

they don't work XD

[ocean walrus]

oh xd

[brave smelt]

@ocean walrus So have you solved your problem?

[ocean walrus]

Yes I think so, with this method you can make a Rosh pit without crashing

[brave smelt]

normal behavior at night and day

[ocean walrus]

Did you do this the same way with the info_player_start_dota spawners?

[brave smelt]

Im just used this shit.

[ocean walrus]

I see

[brave smelt]

So u dont want to use portals right?

[brave smelt]

This way realy works, thanks! But i changed to "ability_datadriven"

[ocean walrus]

yeah, with this way it works without the portal prefabs

[wooden void]

no problem)
maybe you could even do this: "roshan_teleport" "", but I haven't tested it and I'm afraid it might cause crashes.

in my mode, I just let it cooldown and froze it

via code

[brave smelt]

yeah, crashed when roshan spawned)

[wooden void]

dota))

[lunar anvil]

adding BaseClass line to vanilla ability is also risky. It can cause a crash in the future.

[ocean walrus]

well there will be a crash if the ability is allowed to execute as normal anyway

[wooden void]

then you can do as I did, freeze the ability cooldown (with cd set to greater than 0) when the roshan is spawned

[lunar anvil]

SetFrozenCooldown does nothing as far as I know

[ocean walrus]

oh cool, is this typescript?

It might be interesting to use roshan_teleport for something else. Maybe I'll try using findabilitybyname and modify it

[ocean walrus]

I guess one last question would be what determines the direction Roshan faces towards?

[void lodge]

it was fixed a few months ago, i use it