#npc_items_custom.txt crashes the game since last patch

1 messages · Page 1 of 1 (latest)

fluid stratus
#

SInce last patch, my game is currently unplayable as the game will always crash when loading (before team selection screen).
By removing and readding files 1 by 1 im now 99% sure the crash is caused by something in my npc_items_custom.txt file, but I haven't changed anything in that file for at least a month. I'm not sure what to do.
here is the file
https://pastebin.com/zs0S08X0
It's quite lengthy, the first 75% of it is in datadriven because thats what the person I took over the game from used, changes to item_lua later on.
Of course I'm not expecting anyone to actually proofread all of this, I'm just looking for ideas of what could cause a previously working item file to break between last patch and this one. Thanks

robust cliff
#

You have at least next issues (missing quotes):

"01" item_dominator_lua;item_reaver -> "01" "item_dominator_lua;item_reaver"
"01" item_lifesteal;item_helm_of_iron_will -> "01" "item_lifesteal;item_helm_of_iron_will"
"01" item_lifesteal -> "01" "item_lifesteal"

Basically copy paste your npc_items into this site http://arhowk.github.io/ and fix every error it reports

fluid stratus
#

well thats very helpful thank you

#

now I'm just a little confused as to how the game was even working before

robust cliff
#

dota_modding.png

fossil pond
#

It usually reads until it can't anymore

fluid stratus
#

and the game still crashes

fossil pond
#

Try commenting out all items (I would imagine it will stop crashing). Then uncomment a bunch of items at a time until it starts crashing again.

versed drift
#

I tested it and it was giving bracket error on some line that does not have any bracket error

#

so double check before editing I would say

fossil pond
#

to be fair that website was made by arhowk years and years ago

#

it's old

#

VSCode has extensions that help with this by the way

tight forum
fossil pond
#

oh, I meant in a different ton as in "it's old and has bugs" rather than "it's old and outdated"

#

I didn't phrase myself properly

fluid stratus
#

Solved

#

some blocks had 'IsPurchasable' instead of 'ItemPurchasable'

#

that was causing the crash

#

the consequences of copy and pasting

tight forum
#

thats... weird.
you should be able to have whatever keys you want and they just wont be read by valve unless its one of their reserved keys

fluid stratus
#

¯_(ツ)_/¯

#

I mean yeah it worked fine until last patch

fossil pond
#

indeed that's weird af

formal epoch
#

IsPurchasable could possibly be an old deprecated keyword they dropped from engine but is still being called somewhere

#

like the KV reader is still parsing IsPurchasable and attempting to call a method they recently deleted

fossil pond
#

Yeah, probably.

bitter gyro
#

@fluid stratus remove IDs from items, custom items don't need them anymore (since 2020 iirc)

#

game can crash when item ID is the same as a built-in (vanilla) item or ability