How to add custom fluids using datapacks?

[fading lance]

how to assign custom fluids for VS2?

[bold yew]

ngl I have no idea

[fading lance]

@sacred temple do you have any idea?

[bold yew]

no

tomato added the feature

ok so

looking at the code

[fading lance]

i tried to look in /data folder but i didn't find anything notable

[bold yew]

it appears that, if the block state is considered "liquid" (set by mods, not by your datapack), then specifying mass actually specifies fluid density, and specifying friction actually specifies drag coefficient

so you basically just do it like a normal block

[fading lance]

so i should add mass to a fluid to make my boats float?

[bold yew]

you want to do it for tfc fluids yes?

basically use uh

/setblock

[fading lance]

yes

[bold yew]

to see what the block id of the fluid is

[bold yew]

and specify its mass based on that

[fading lance]

it doesn't seem to work

[
{
"block": "tfc:river_water",
"mass": 1000,
},
{
"block": "tfc:spring_water",
"mass": 3920,
}
]

[bold yew]

did you enable the datapack?

[fading lance]

yes

[bold yew]

and restart your game?

[fading lance]

/reload

[fading lance]

lemme try

[fading lance]

i restarted it but it still doesn't float on river water

or mb i put it in wrong folder

also i tried to add it through fluid bc fill command shows fluid/

[
{
"block": "tfc:fluid/river_water",
"mass": 1000,
},
{
"block": "tfc:spring_water",
"mass": 3920,
}
]

[bold yew]

Yeah I’m not sure whatever moonlight global datapacks is will work

[bold yew]

Huh why is it different

I guess trust F3

[fading lance]

is water also assigned with mass and simmilar using datapacks or it's hardcoded?

[bold yew]

water is hardcoded

[fading lance]

where exacly

i think i can write a mixin to pass water tags to piece of code where it was hardcoded

[bold yew]

https://github.com/ValkyrienSkies/Valkyrien-Skies-2/blob/1.20.1/main/common/src/main/kotlin/org/valkyrienskies/mod/common/config/MassDatapackResolver.kt#L316

[bold yew]

or like

try and figure out why datapackable fluids aren't working

and try to fix it

[fading lance]

and make a pr, lol

[bold yew]

yeah

[fading lance]

🫡 imma try

[bold yew]

I'm sure if you step through the fluid block state registration with a breakpoint the reason its not working will become clear

these problems usually aren't too hard to spot if you've got an actual datapack to debug step by step

[fiery karma]

hello

:)

and how to add custom fluid?

[bold yew]

Same as a block

Well, if it’s working

[fiery karma]

So it might not work?

[bold yew]

It might be bugged I’m not sure

[fiery karma]

ok

ty

[fading lance]

I figureed out how to make it work

so you should create a datapack

put
[
{
"block": "tfc:river_water",
"mass": 1000.0,
"friction": 0.3
}
]

in this folder of your datapack
namespace/data/namespace/vs_mass/fluids/fluids.json

[bold yew]

Does it need to be in a fluids folder? Interesting

[fiery karma]

thx

but I already did it

[fiery karma]

no

[fiery karma]

They hid the datapack page well on their website.

https://wiki.valkyrienskies.org/wiki/Datapack_System

[bold yew]

I wrote most of that page I just wasn’t sure the fluid stuff worked

[fiery karma]

xD

[bold yew]

I need to make it so https://wiki.valkyrienskies.org/wiki/Modifying_Block_Properties and https://wiki.valkyrienskies.org/wiki/Shipyard_entities redirect to https://wiki.valkyrienskies.org/wiki/Datapack_System but every time I try the wiki blocks me for being a bot

[fiery karma]

hahaha

rude wiki