PMMO and VS bug when creating an airship. | Valkyrien Skies | Page 1

hidden quiver Sep 29, 2025, 6:18 AM

#

With the following mods:
Project MMO 1.20.1-1.7.38
Project MMO: Classes 1.20.1-1.0.0
Project MMO: Farmer's Delight Compat
Project MM: Iron's Spells & Spellbooks Compat
Project MMO: Skill Books

And the following VS related mods:
Valkrien Skies 1.20.1-forge-2.3.0-beta.10
VS Tournament 1.1.0_beta-5.3+af35b3821f
VS Additions vs_addition-1.20.1-0.0.10+47cd0cceb5
Valkrien Sails 1.20.1-0.2.1-forge
Valkrien Relogs 0.3.0
Clockwork 1.20.1-0.1.16
Clockwork Additions 1.20.1-0.0.7
Create: Interactive 1.1.1-beta.3

Plus pre-reqs for all of those mods.

Using Forge 47.4.0 (Dedicated server running on the same Forge build). I get the bug as noted in the image.
All players have their Building Skill level set to a ridiculous number, preventing using the skill.
Resetting it with admin mode is perfectly fine and doesn't appear to cause any issues, so far.

Using VS Sails Dedication Bottle to build the ships.

This doesn't crash the game at all.

#

Full mods list:

📎 message.txt

agile wharf Sep 29, 2025, 6:36 PM

#

is this happening when you assemble a ship?

hidden quiver Sep 29, 2025, 10:21 PM

#

Whenever anyone on the server assembles a ship, yes

#

It sets the building skill to a silly number.

#

It isn't causing huge issues, I just have to /pmmo admin to set it back for everyone who is online at the time.

But my concern is that this looks like two mods accessing the same memory pointer, which is potentially very bad.

#

My chief suspect is the VS Sails mod, but that is purely based on feels with zero evidence whatsoever. lol

agile wharf Sep 29, 2025, 10:35 PM

#

that is interesting

#

maybe it’s counting all of the blocks that are being placed as part of the ship and adding it to the player’s build skill?

#

actually, that is a negative number nvm

agile wharf Sep 30, 2025, 1:38 AM

#

hidden quiver Whenever anyone on the server assembles a ship, yes

so it sets everyone’s building skill to that?

hidden quiver Sep 30, 2025, 2:25 AM

#

Yep

agile wharf Sep 30, 2025, 2:35 AM

#

weird

#

I’ll let you know if I think of anything

agile wharf Sep 30, 2025, 8:58 PM

#

@odd spear do you have any idea what could be causing this?

odd spear Sep 30, 2025, 8:59 PM

#

Hmm lemme have a look

agile wharf Sep 30, 2025, 8:59 PM

#

I thought for a bit that each block in the ship could be being counted for all players when it assembles, but I doubt that would cause the score to become negative

#

unless maybe the skill levels are stored as shorts? 🤔

odd spear Sep 30, 2025, 9:01 PM

#

This is quite interesting

agile wharf Sep 30, 2025, 9:02 PM

#

agile wharf unless maybe the skill levels are stored as shorts? 🤔

nvm I am braindead—the screenshot literally shows it being bigger than a short

#

but it does look like it could be an overflow of some kind

#

I just have no idea why it would happen

#

@hidden quiver do you know how project mmo calculates its building skill?

hidden quiver Sep 30, 2025, 10:38 PM

#

agile wharf <@275827134398988288> do you know how project mmo calculates its building skill?

No sorry, I have no idea.

#

I just place blocks, and it gives skill points toward building skill

#

What I might do today is:

confirm it occurs in single player
try building a ship without the Sails dedication bottle
try it without the addon mods, so just VS, Clockwork and PMMO base mod.

odd spear Sep 30, 2025, 10:41 PM

#

That sounds like a great plan!

#

It could be that the way Sails (and VLib) assemble ships causes PMMO to think the player is manually placing all the blocks

hidden quiver Sep 30, 2025, 10:47 PM

#

ok happens in singleplayer

#

doesnt happen when using the clockwork infuser

#

So Sails and Vlib it looks like

#

Sadly, given the nature of the modpack, the dedication bottle is pretty important. Moreso than the sails.

agile wharf Oct 1, 2025, 7:13 AM

#

hidden quiver Sadly, given the nature of the modpack, the dedication bottle is pretty importan...

could you test to see if the same thing happens when you pick up and place a ship with the bottle from the ship in a bottle mod?

hidden quiver Oct 1, 2025, 9:41 AM

#

Assuming you mean this one
https://modrinth.com/mod/bottle-ship

Modrinth

Bottle Ship - Minecraft Mod

An addon mod for Valkyrien Skies 2, reforged from ship-in-a-bottle.

#

oh wait.. also this one..
https://modrinth.com/mod/vs-ship-in-a-bottle

Modrinth

Ship In A Bottle - Minecraft Mod

An addon for Valkyrien Skies which lets you put your ship in a bottle.

#

ok, first one, no issue

#

Second one, no issues

#

Adding VS Safe and Sound too to see if that tells me anything of use

#

ok, after adding safe and sound the dedication bottle no longer works..

#

Just.. nothing happens.

agile wharf Oct 1, 2025, 2:41 PM

#

weird

#

so it has to be the assembly itself that causes the issue

#

not sure why vs safe and sound would stop the assembly tho

hidden quiver Oct 1, 2025, 7:11 PM

#

It catches the errors right?
The only thing it seemed to have affected is the use of dedication bottles.

junior axle Oct 1, 2025, 7:55 PM

#

agile wharf so it has to be the assembly itself that causes the issue

doesn't vlib have it's own jank assembly

junior axle Oct 1, 2025, 7:57 PM

#

hidden quiver With the following mods: Project MMO 1.20.1-1.7.38 Project MMO: Classes 1.20.1-1...

I'm willing to bet it's something that is exclusively on their side

#

due to how crazy their issues tab is

hidden quiver Oct 1, 2025, 8:22 PM

#

Likely. It does seem to specifically be an issue between PMMO and VS Sails though

steel wadi Oct 1, 2025, 8:22 PM

#

junior axle I'm willing to bet it's something that is exclusively on their side

holup

hidden quiver Oct 1, 2025, 8:23 PM

#

Most of those are their 1.21.x builds it looks like though.
I'm on 1.20.1

steel wadi Oct 1, 2025, 8:23 PM

#

I gotta go see this source code

#

what the actual heck are they doing

#

those issues are wacky af

hidden quiver Oct 1, 2025, 8:23 PM

#

Swimming causes RAM spike. 😂

steel wadi Oct 1, 2025, 8:25 PM

#

they have their own scripting for datapacks??

#

never mind its kubejs stuff

#

idk the code base seems alright at a glance

#

but those are some very strange issues lmao clueless

junior axle Oct 1, 2025, 8:26 PM

#

i mean

#

those two issues

#

were quite literally the first few issues I saw

hidden quiver Oct 1, 2025, 8:27 PM

#

These are the issues for 1.20.x
https://github.com/Caltinor/Project-MMO-2.0/issues?q=is%3Aissue label%3A1-20 label%3Abug&page=1

GitHub

Caltinor/Project-MMO-2.0

A continuation of Harmony's Project MMO project. Contribute to Caltinor/Project-MMO-2.0 development by creating an account on GitHub.

#

I think it is more their 1.21.1 version has some issues.
1.20.1 seems very stable.

Not that it may not be their issue as well.
But it only happens with VS Sail dedication bottles.

#

I'll add this over there too, see what they say.
But the issue I run into with other Devs and anything related to VS is they just say "VS is crazy though" etc.
lol

#

There, threw this over there to see what they think.
https://github.com/Caltinor/Project-MMO-2.0/issues/736

GitHub

Using VS Sails Dedication Bottle Sets Building Skill to crazy numbe...

Describe the bug When using the Valkrien Skies Dedication Bottle to assemble a ship, the player Building skill is set to a huge negative number. Expected behavior A ship is assembled and skills are...

agile wharf Oct 1, 2025, 9:10 PM

#

junior axle doesn't vlib have it's own jank assembly

vlib’s assembly isn’t jank :(

junior axle Oct 1, 2025, 9:10 PM

#

agile wharf vlib’s assembly isn’t jank :(

doesn't it break when c2me is installed

#PMMO and VS bug when creating an airship.