FTB chunks protection

[wispy marlin]

Just a question. Was it ever supposed to protect ships?

[pearl cosmos]

Pretty sure it does? I know vs doesn't work with OPAC but I thought it works with this idk

[wispy marlin]

OPAC doesn't work at all. Wish it would

[pearl cosmos]

same, I think they were looking into it at one point but it was never done

[wispy marlin]

I tested it in my server, protection had no effect. Wonder if it is just not working config option

[pearl cosmos]

Hm, not sure tbh, haven't ever used FTB chunks really, but I thought I saw somewhere that it works

[thick garden]

@cursive bear Is there FTB compat?

[cursive bear]

There was but people disabled the Mixin and the maven changed,I had a Fix but its not targeting the 1.20.1/2.3 branch rn and would need a rebase

[cursive bear]

OPAC was more complex and went over my head with the amount of changes per method it would take to protect Ships, so I stopped working on it

In essence, there are a lot of methods calling other methods, some needing the Shipyard position and within those methods, other method calls needing the Worldspace position

[wispy marlin]

Thank you!

[cursive bear]

PR to fix FTB Chunks protection is up

i will say, there is a config for if flying above or below world height the chunks protection still effects the ship

[wispy marlin]

I'm sorry, what is PR? I barely speak english

[cursive bear]

Pull Request

its essentially letting a project know you want to change something and showing them the code you used so they can request changes and either accept it or close it

[wispy marlin]

Ah, got it. thank you!

[cursive bear]

Also, about FTB compat, here is the latest version (Forge and Fabric) with my FTB Chunks Mixin fixed

@wispy marlin

[steel oak]

and this also has the item dupe fix correct?

[cursive bear]

It has the fixes that are in latest rn

Plus the FTB Chunks protection

[cursive bear]

Please tell me if this patched version works

[wispy marlin]

It crashes the server. Here is the crash report

[cursive bear]

i see, making a fix now

ok, doesnt crash in testing, gonna toss you the JARs

@wispy marlin tell me if it works

[wispy marlin]

Yeah, one moment

[wispy marlin]

Works in singleplayer enviroment

[wispy marlin]

Works in server enviroment too