#Fixed VS addition fake air pockets!

1 messages · Page 1 of 1 (latest)

flint summit
#

Serialization now works! No more bricked worlds. Though it won't un-brick old worlds. Fabric no longer needs computer craft, forge shouldn't but I haven't tested that. (current vs addition accidentally requires computer craft or it crashes).

Steps to enable fake air pockets:

  • find config/valkyrien_skies folder
  • edit vs_addition_common.json and set "fakeAirPocket" : true
  • edit vs_addition_client.json and set "removeFogInFakeAirPocket" : true (otherwise air pockets will be very hard to see in)
  • restart your game
  • open world
  • use /fake-air-pocket add to make a new fake air pocket. Use shipyard coordinates.
  • run /fresh-fake-air-pockets to refresh air pockets client-side, otherwise new pockets won't show up
  • profit
📎 vs_addition-1.20.1-forge-0.0.102fafdfabbc.jar 📎 vs_addition-1.20.1-fabric-0.0.102fafdfabbc.jar
#

I have not made a PR to VS addition, because I had to do some git weirdness to get a branch that worked. If xwyz comes back, I can tell them the (pretty easy) steps I used to fix CC and air pockets

#

Now I really gotta get back to doing schoolwork lmao

fierce kernel
#

does it fix the flap problem ?

#

too ?

flint summit
#

uh no

#

what flap problem? thonk

fierce kernel
#

17:52

#

mre like 18:30

flint summit
#

the flaps uh

#

i think its because vs addition upgrades fkaos

#

makes it so the redstone links are built in

#

so he needes to use those instead of normal redstone links

fierce kernel
#

anyway

#

time to test the air pocket

fierce kernel
flint summit
#

vmod schem ship

#

paste ship

flint summit
fierce kernel
fierce kernel
# flint summit yes

question
does it take the literal coordinate to make the air pocket or does it change the air block to air pocket

flint summit
fierce kernel
# flint summit what?

what i mean is
does it change all the block in the selection box into air pocket or does it change only the air block that is in the selection box

flint summit
#

all blocks?

fierce kernel
#

ok

#

like i have a structure right there

image.png
#

did he do this

image.png
flint summit
#

yes

flint summit
fierce kernel
#

oh ok

modern hamlet
#

Zaaaaamn

#

Do they save after rejoining?

fierce kernel
flint summit
flint summit
modern hamlet
fierce kernel
#

but why it sak me the shipid then

flint summit
#

maybe that command is setup wrong

flint summit
#

Ok messing around with these air pockets

#

their best when its a simple cube

#

when you combine multiple air pockets they can get a little unreliable

#

I believe thats because the air pockets end up like this

#

but idk how to fix that

#

also the rendering could do with imrovements

#

such as rendering the fluid-top on fluid thats below the airpocket

#

but that i definetly don't know how to do

#

oh and you basically can't remove air pockets

#

because all the commands need a ship id instead of a ship slug for some reason

light axle
#

i was able to remove a pocket using the id it prints in the chat when you create it

flint summit
#

how did you get the ship id though?

flint summit
#

demo of airpockets :D

#

(not my sub, its from submarine MC on YT, modified slightly)

#

found out how to get ship id

#

/get-ship-id-and-slug or smthn

flint summit
#

hang on lemme get a not compressed to dirt vid

surreal owl
#

Does it will correspond to a sharder?

hard warren
#

I feel like I’m not going to be able to figure out the code stuff 😭

#

Looks to complicated for me to do on my own

icy gorge
#

Air pockets in space

hard warren
#

I hope someone will help me out sometime with it

stark ruin
flint summit
hard warren
#

That’s just my way of saying I don’t know how to do it

flint summit
#

You just use the .jar from here instead of modrinth, and run a few commands

flint summit
hard warren
flint summit
#

Yeah these

image0.jpg
hard warren
#

Ok

flint summit
#

What mod loader are you using? And what launcher?

hard warren
#

I’m using curse forge

flint summit
#

Ok so in Curseforge

#

Hit the 3 dots on your profile/modpack

#

Then hit “open folder”

hard warren
#

I know I put it in mods

#

Folder

#

Right

flint summit
#

Yeah

#

Make sure vs addition isn’t already in your modpack though

hard warren
#

Valarian skies it can’t be in there or it needs to be

#

What am I thinking it needs to be in there

flint summit
#

Valkyrien skies needs to be there

#

Just not “VS addition” since thats the file your adding

hard warren
#

I don’t know if I remember adding that but I don’t think I did

#

But I have everything required for the mod It’s just a coordinate thing I don’t know how to do.

#

And this

IMG_1417.png
flint summit
#

Where your mods folder is

#

Go back one folder

#

Then go into configs

#

(Or config I don’t remember)

#

Then go into the valkyrienskies folder

hard warren
#

lol I anit on my pc I just woke up in the middle of the night. I’m still in my bed. Lmao

stark ruin
flint summit
hard warren
flint summit
#

Find the config vs_addition_common.json

#

Open it in any text editor

#

(But a code editor like vs code will help spot mistakes you make)

hard warren
#

Uh I’m lost lmao

flint summit
#

Well uh

#

Your looking for a file

#

That’s located at (ur_modpack)/config/valkyrienskies/vs_addition_common.json

hard warren
#

ye I get that it’s the editor you’re talking about

flint summit
#

Ah so basically

#

A .json is technically the same as a .txt

#

So you can open it in notepad, or whatever (although you will need to tell windows to do that, at first it won’t know how to open it)

hard warren
#

Oki

#

How exactly I tell it to do it

flint summit
#

It’ll say when you try to open it

hard warren
#

K

flint summit
#

“Select an application to open this file” or smthn

hard warren
#

What next?

icy gorge
flint summit
flint summit
#

Right now anyway

hard warren
#

I was about to say what’s the point of this mod if you can’t breathe

#

lol

icy gorge
flint summit
#

Nope

icy gorge
#

Huh

flint summit
#

Survival stuff like breathing hasn’t been added to cosmic horizons yet

hard warren
#

What’s cosmic horizons

flint summit
#

Space mod

hard warren
#

Oh

#

Ok

icy gorge
#

And starlance is an addon which combines vs2 and ch

hard warren
#

Ch ?

flint summit
#

Cosmic Horizons

hard warren
#

Ahhhhhh so much info

#

Brain shutting down

#

lol

hard warren
flint summit
#

Alright 3dsmile

hard warren
#

Me

#

Now I have three things to look forward to

#

Air pocket mod space mod and other stuff lol

hard warren
flint summit
#

But there’s a mod that does it too

#

I’m just not sure if it’s released yet

hard warren
flint summit
#

#1357423180490477618 message

hard warren
#

Yeah, this is what I was thinking of

#

Be sick whenever I get to mess around with it

#

Well ima get my sleep now

#

We can continue talking about how set up air pockets later if you want to help me

low hearth
#

Are these air pockets only done via commands? Is there something like an airpocket wand or something?

flint summit
#

an item would be useful, its true

low hearth
#

alr ty. Will be waiting for an item, anything else would be very tedious on more complex builds which arent just a 3x3x3 cube 😄

flint summit
#

sure but...

#

you know this mod isn't actively being developed right? 3dsmile

low hearth
#

yep ik

flint summit
#

I just put together this one time fix since the dev is missing

#

and I can't promise anything more than that, but who knows

flint summit
low hearth
#

maybe i will add tool item myself. shouldnt be too hard to do ig.

flint summit
#

let me check something for you real quick

#

ok all commands for fake air pocket are permission level 1

#

so you can totally make a datapack/command block that uses /execute as <player> run fake-air-pocket ...

#

or a mod if you really want to

low hearth
#

thank you 🙂

flint summit
#

idk if I need a fabric jar, lemme know

rancid timber
#

Uh

#

What does this do exactly

sly hull
unborn quail
rancid timber
#

Am I supposed to know

unborn quail
#

Look at the name and give it a guess

sly hull
#

Even better, watch the video

rancid timber
rancid timber
#

No

sly hull
rancid timber
sly hull
rancid timber
sly hull
green mothBOT
#
__**.thetigerking**#0__ has been warned

Reason: can't watch a video

Strike 5
rancid timber
#

Breh

rancid timber
#

Where did i complain

#

See

#

You cant find it

sly hull
rancid timber
green mothBOT
#

Insufficient Permissions

flint summit
rancid timber
flint summit
rancid timber
flint summit
#

Sure I do trollface

rancid timber
#

Try it

#

@green moth wake up

flint summit
#

Already have clueless

rancid timber
#

No u haven't

sly hull
#

Brickyboy has been here before you, they already know the trick

green mothBOT
#

Insufficient Permissions

flint summit
#

Damn I can’t even do that

rancid timber
#

No they haven't

#

If i keep denying it it didn't happen

#

Trust

flint summit
#

Gaslight reality

rancid timber
flint summit
#

I’m rich

rancid timber
flint summit
#

I definitely am rich

#

Reality, I’m rich

rancid timber
flint summit
#

Ignore the deniers, universe I’m rich def

rancid timber
#

Mhm

#

If your rich then starlance has fuel

#

Working

flint summit
green mothBOT
#
__**Active Warns**__

@flint summit: Reason: actually fixed the issue (not allowed)
Severity: High
ID: a4684d2a9
By: @halcyon light

        [[Context]](#1356361789763354967 message)
        
        @flint summit: Reason: `you broke the 1984 movement speed rule`
        Severity: `High`
        ID: `e7f82fd5b`
        By: @flint summit
        
        [[Context]](#minecraft message)
#
__**Active Warns**__

@rancid timber: Reason: Jokes are not allowed, this is 1984
Severity: High
ID: b69252a73
By: @sly hull

        [[Context]](#minecraft message)
        
        @rancid timber: Reason: `1984`
        Severity: `Medium`
        ID: `79df87773`
        By: @sly hull
        
        [[Context]](#general message)
        
        @rancid timber: Reason: `i want warn perms!`
        Severity: `High`
        ID: `273950bdc`
        By: @rancid timber
        
        [[Context]](#general message)
        
        @rancid timber: Reason: `mean`
        Severity: `High`
        ID: `a06f464d5`
        By: @rancid timber
        
        [[Context]](#general message)
        
        @rancid timber: Reason: `can't watch a video`
        Severity: `Medium`
        ID: `2389c106a`
        By: @sly hull
        
        [[Context]](#1363915464165556455 message)
rancid timber
sly hull
rancid timber
#

Lmao

slim mirageBOT
#

@rancid timber has 228 karma ❤️. Next role upgrade after 272 more karma

#

@flint summit has 215 karma ❤️. Next role upgrade after 285 more karma

#

@sly hull has 7397 karma ❤️. Next role upgrade after 2603 more karma

sly hull
#

Low karma trolls 🥱

flint summit
#

Discord moderator 🥱

rancid timber
sly hull
flint summit
#

did you ever post stuff?

#

or was it just liking posts thonk

#

#1132060038651990136 message

#

huh yeah

#

truly a post

#

of all time

sly hull
#

And two or three technical VMod builds

unborn quail
#

lmao

flint summit
#

got around to making a PR

stark ruin
amber kraken
#

not sure why, but I'm getting some weird outlines when the airpockets appear.
I'd also suggest making the air pockets show the fog through glass, but You're not the actual dev of the addon, so, can't really complain to you

flint summit
flint summit
#

And yeah fog outside would be good but I have no idea how to do that 🤷

amber kraken
flint summit
#

well

#

water fog isn't connected to the blocks

#

its just

#

"is underwater = render fog"

#

(From whatt I know anyway, I could be wrong)

sly hull
#

As far as I remember there is no fog applied when you put glass against water in vanilla MC

amber kraken
#

anyway

sly hull
#

but you can make it show the water texture

#

like vanilla MC does

#

in that case

flint summit
#

oh yeah it just shows the texture doesn't it

sly hull
#

yep

#

the water flowing texture IIRC

#

mapping it to the air pocket might be tricky

flint summit
#

not sure how that would apply to ships yeah

amber kraken
#

I wanted to complain that whoever thought it would be a good idea to include copycat flap, and copycat wing, with omission of copycat propeller shouldl just fucking die

flint summit
#

thats clockwork addition

amber kraken
#

though, I suppose it is no appropriate place for such a complaint

flint summit
#

which isn't developed anymore anyway

sly hull
flint summit
#

?

#

wouldn't you want the UV to be relative to world

amber kraken
flint summit
#

idk what a UV is honestly

#

but the water flowing shouldn't rotate with the ship

#

which is probably what you said

amber kraken
#

actually

#

how come there are so many dead addons to vs?

flint summit
#

because consistenly developing a mod is hard 3dsad

#

I would know, I've abandoned many a mod in my time

#

well

#

like 2 mods

#

and I came back eventually

#

but still

sly hull
#

and I said that they should be fixed on the air pocket

#

so that they move with the ship

flint summit
#

wouldn't that look worse

#

like the water is moving with you

sly hull
#

the opposite would make it so that you see water scrolling on your glass when you move with your sub

#

which I think would look weird

flint summit
#

wouldn't that look more movement-like?

sly hull
#

Well I haven't tried, I say that mostly from picturing it clueless

#

also it should be a bit easier to code

flint summit
#

true clueless

sly hull
#

than making it world aligned

stark ruin
flint summit
craggy fiber
#

NO FUCKING WAY SUBMARINE FINALLY

#

add a block that allows you to go up and down underwater Eureka style then this mod would become really goated

#

"underwater balloon" filled with water of less density, same logic as Eureka lmao

true horizon
craggy fiber
#

which addon is it

true horizon
#

unreleased

#

it’s a little out of scope, but I already have different buoyancy blocks

#

might as well

craggy fiber
#

I think you could do something like buoyancy calc pretty easily

#

just have to take all blocks below sea level

true horizon
#

determining the water level is the hard part

#

but there is a vs api feature for setting buoyancy

craggy fiber
#

maybe someone could make a singular addon that adds natural buoyancy to the ship's buoyancy, but only for all blocks below global sea level as long as there is no hole (and maybe have compat with fake air pockets from vs additions)

#

so things like waterfalls? lakes you made? nah, no buoyancy calc there

#

it would be excusable i think because it's the bare minimum of redeeming the average VS player's dream and also in a separate addon (would look bad for a big addon to not have the courtesy of doing that)

#

you could also determine water level by seeing up to which Y level the ship is covered in water like:

# i'm assuming a two-dimensional grid
water_level = ship.y + ship.height # i'm assuming the ship's Y level starts from the top not bottom
layer_Y = 0
stop_calc = False
for layer in reversed(ship.outside_grid):
    if stop_calc: break
    for block in layer:
        if block.ID != water_ID:
            water_level += layer_Y
            stop_calc = True
            break
    layer_Y += 1
#

this might be a pretty expensive calc to do so maybe only do it every time the ship moves some 10 or so blocks or every n seconds?

true horizon
#

With all due respect, if you have an idea for how you want a mod to work, you should do it yourself and not try to tell existing devs what they should and shouldn't do.

craggy fiber
#

I didn't mean that the idea was hard, i was saying that that part was harder than the rest of the idea

#

and i'm sorry if i came across as telling you what you should do, i just had an idea so i suggested it

#

also i might actually try this mod some time later, i've been itching for something less complicated than Clockwork but with more control than Eureka, it's like a middle ground between either using Vulkan or a game engine

rare cape
true horizon
# rare cape do they have a discord?

I do have a discord with the other Valkyrien Pirates devs. It’s mostly for Pirates, rather than the sails addon, since I haven’t released it yet, but that message comes from said discord. You should be able to click on the bottom of the message there where the server icon is, but otherwise you can find the link on the Valkyrien Pirates CF/Modrinth

hard warren
#

how do you get shipID for the fake air pockets

hard warren
#

i cant figure this air pocket mod out

flint summit
#

Another vs addition command I think

flint summit
#

ok bad news

#

I fixed commands in latest VS

#

it broke VS additions

fierce kernel
flint summit
#

#vs-addition message

#

^ I fixed vs addition

sacred void
#

By that i mean is there something in this one that is fixed which isnt in the newer one?

flint summit
#

In the vs addition channel

#

Has this included

#

But this post was made before, when the air pocket fix wasn’t in any version yet

sacred void
#

oh

#

is there any reason to use this version?

#

compat or smth?

flint summit
#

But it does explain how to use the air pockets

sacred void
#

oh ight

#

thx