Crash when using with Supplementaries 3.0+

[oak tusk]

I have found that any version of Supplementaries 1.20-3.0.0 and above will prohibit a world from loading, and will result in a crash if the mod Eureka! Ships! (any version) is present.
When downgrading to Supplementaries 2.8.17, it works just fine.

[neon steppe]

Probably a supplementaries issue considering vs hasn’t changed

Unless vs has supplementary compat thats now outdated and broken

[oak tusk]

was wondering that. They just sent me back here.

The supplementaries folks

[neon steppe]

Can you send a screenshot or something of what they said?

[oak tusk]

so, I sent the log and am waiting on response from that

which, the latest is here as well

[neon steppe]

Vs just always throws cryptic errors, even when nothing goes wrong

[oak tusk]

I have noticed that, haha

[neon steppe]

Also

When does this crash happen?

[oak tusk]

only when loading a world (or booting up the server)

you get all teh way to loading terrain

[neon steppe]

Because normally this error message from VS is when a mod tries to make a new dimension at the wrong time (aka wrong tick phase)

But it might also happen with stuff other than dimensions I giess

[exotic prawn]

does this happen when creating new world?

[oak tusk]

new world, old world, new server, old server

the whole shebang

[exotic prawn]

and it also crashes if it's just supplementaries + VS?

[oak tusk]

o, let me actually see

I will disable eureka

my dev said he tested it with just VS and Sup, but I'll run it myself to generate a log

[oak tusk]

aha, so disabling Eureka does not fix it

disabling VS works

[exotic prawn]

well, no shit

[oak tusk]

hahaha

yeah fair

but yeah. it crashes when just VS+Sup

[exotic prawn]

make an issue on VS github ig

[oak tusk]

🫡 kk

[oak tusk]

this is what I was told from Sup

[neon steppe]

https://github.com/WhoCraft/TardisRefined/pull/362

https://github.com/ValkyrienSkies/Valkyrien-Skies-2/blob/a79885511ef04dcb69084bdc9cd57c587d1edaad/common/src/main/java/org/valkyrienskies/mod/mixin/client/MixinMinecraft.java#L121

This is the dimension cause of the crash tho

I haven’t seen this happen from any other source, but I suppose it’s possible

So for the supplementary devs, I recommend they look at what’s changed since the version that doesn’t crash and see if any of those changes might involve a tick phase that doesn’t comply with what vs expects

It’s maybe a lot of work, but I doubt vs will/can fix this any time soon (their busy with a big overhaul of the backend of vs)

[stable grail]

ohh

man

i gotta love when mods devs create dimensions in weird and incompatible ways that the game isn't made to handle

although

why is why Supplementaries even creating a dimension on 3.0.0?

i'm reading the change log

[neon steppe]

But I feel like supplementaries doesn’t have any dimensions? atleast not that I remember

[stable grail]

and i can't find any new dimensions in the features

[neon steppe]

So it must be something else vs doesn’t like?

[oak tusk]

actually. upon further testing, IF you get them both alone, SOMETIMES the world loads.

Its. really really bizzare

[stable grail]

that's what normally causes this

for tardis refined

the issue was that they were creating a dimension on block useOn

which has a chance of happening on a tick stage

where dimension creation should never happen

create tree fertilizer has the exact same problem

[oak tusk]

Ok, so. I found the fix

It is the combination of Universal Shops, Supplementaries and VS

all on latest version

IF Sup is above 3.0, it causes the interaction to crash. If it is below, it works.

It is such a wild scenario

disabling shops makes it all work with latest versions

so. Shops is the real villan

[neon steppe]

A triple incompatibility, that’s kinda rare

[oak tusk]

Well, I tried it with just Universal Shops and VS, and it worked fine. Introducing Sup makes it crash

removing any of the 3 in the list (or downgrading Sup) makes them work

[rose oxide]

Seeing this same issue with Supplementaries; althought I don't have Universal Shops, so maybe there's a more ominous incompatibility at play. Usually when this occurred it would kick me back to the main-menu, and I would be able to rejoin the world on the second try, but now when I try the world is hidden from the list in "Single Player". Also here's a related GH issue for VS2 that repro'd with just VS2 & Supplementaries (w/Moonlight Lib): https://github.com/ValkyrienSkies/Valkyrien-Skies-2/issues/1045

[rose oxide]

If the crash in Sup came from v3.0.0, then this is probably what's causing the issue: Added /supplementaries dimension command, allows to teleport to dimensions

@oak tusk could you link me the thread in the Supplementaries discord?

I think the issue is somehwere in here, but I'm not a java dev lol

[neon steppe]

why the heck does sup need a "fake level"

[rose oxide]

Lol no clue

[neon steppe]

yeah something related to that is most likely causing VS to freak out and crash

[rose oxide]

Here's the full stacktrace

[neon steppe]

Ah whats happening is:

net.mehvahdjukaar.moonlight.core.misc.FakeServerLevel.<init> (sup makes new fake level)
V
net.minecraft.class_3218.<init> (minecraft makes the level)
V
net.minecraft.class_3218.handler$pen023$valkyrienskies$onInit (valkyien skies mixin into minecraft detects the level being made)
V
org.valkyrienskies.core.impl.game.ships.ShipObjectServerWorld.addDimension (valkyrien skies tries to add the level as a dimension)
V
(this happens in the WRONG TICK PHASE, causing Valkyrien Skies to crash)

definitly should be fixed on supplementaries side, just only make the fake level in the right tick phase. If VS had to fix this, they would have to add some sort of extra check just to make sure its not supplementaries making a fake level

[rose oxide]

Gross 🤢

Cool; I reported it over there. Didn't feel like open a GH issue, so I dropped it in their discord

I ain't got time for their issue template 😂

Thanks for the 👀 @neon steppe! OOP confuses the heck out of me. I've been coddle with my use of functional languages forever and a day lol

[neon steppe]

yeah I learned Java right after Python, and man was it a jump

[rose oxide]

I had my algo class in uni with Java, and I didn't pay any attention lmao

Slept through it and ended up an Elixir dev

[summer relic]

Hello, i had this exact crash. But is not universal shops, it is the lib "polymer".
It is a incompatibility between Polymer, Supplementaries and Valkyrien Skies. If I take any of those 3, it doesn't crash
I created an issue in github: https://github.com/ValkyrienSkies/Valkyrien-Skies-2/issues/1225