Mod Release: Valkyrien Pirates 1.0.0

[sullen depot]

@raw rapids and I are very excited to finally unveil the official release for Valkyrien Pirates!

This mod adds pirate ships that generate in your world and sail by themselves. These ships come with a fearsome pirate crew, and cannons which will shoot at your ship. Killing the pirates will disarm the cannons, leaving the ship and its booty free for you to plunder!!

We hope you enjoy the mod :)

#1288351524342333503 message

https://modrinth.com/mod/valkyrien-pirates

[pliant vector]

I'm baratie-ing on this

[sullen depot]

Baratie: Meaning. In Hinduism, goddess of sacrifice. ??

[pliant vector]

No, lmao😭

[sullen depot]

Ohhh 😅

[split pond]

Nice mod! Any plans to make it forge?

[sullen depot]

Thanks! Currently, no, but you're welcome to make a port. Also it probably works with Connector

[feral fern]

Awesome! What kind of AI does the ship have? Is it being controlled by an onboard block or something? ... does it have a health bar? Does it keep moving until the ship is fully destroyed?

[sullen depot]

The ship is being controlled by an onboard block! It drives in a config-specified pattern, which defaults to a circle. Destroying the block will make it stop trying to drive itself but it keeps moving until you take the helm. The block will destroy itself if the captain is killed

[pliant vector]

Auto pilot lolz

[split pond]

Alright

[sleek birch]

Yarr

[hardy wigeon]

Forge?

[sullen depot]

Not right now, but might work with Connector

[dire relic]

do it on the real mod platform pls (forge)

[split pond]

I've tried with connector, if kotlin for forge is in the modpack it isn't gonna work but otherwise it should work

[sullen depot]

Doesn't VS depend on Kotlin for forge (if on forge)?

[split pond]

Yes

[sullen depot]

So how would you use this without kotlin for forge with connector? I don't understand

[split pond]

You wouldn't be able to, or I'm just a Little bit stupid and there's a way

[sullen depot]

Ok gotcha

[split pond]

Because it says valkyrien pirate needs kotlin for fabric and when I added it, it just crashed because of 2 kotlins

[sullen depot]

Ohh I see

Tbh you could probably override the kotlin for fabric requirement without issues

I might post a patch with that change

[split pond]

Please do! I would love to shell a pirate boat with the naval boat I am currently making

[hardy wigeon]

bummer

[sullen depot]

@split pond see if this works, it no longer checks for Kotlin Fabric

[split pond]

Ok give me a moment please

[sullen depot]

No worries!

[split pond]

I got minecraft to load successfully, it also depends on what mods your using in your modpack

[sullen depot]

Cool! Would you mind elaborating? (Which mods might be incompatible)

[split pond]

I had a lot of mods I tested it with so I couldn't say but I'll test it out later

[sullen depot]

Ok. Don’t feel like you need to go out of your way to test stuff, I just thought if you had specific mods in mind that this mod breaks with I would have liked to know

[split pond]

Also another thing is idk if its connector or it being with kotlin but the items are missing for the mod

[sullen depot]

Oh in creative inventory?

[split pond]

yes

[sullen depot]

We forgot to add them

You can use /give lmao

[split pond]

alright

just wanted to make sure

[sullen depot]

The items work fine, just absent from creative inventory. This is true on fabric too

[split pond]

Alright

One last thing, would you like to see the pirates get absolutely bombed by naval guns?

[sullen depot]

I would love to

I just realized discord supports videos, not just gifs (unlike modrinth )

Here's a better demo:

[ocean pumice]

are the muskets just retextured bows?

this is soo cool

[thin gust]

Would be awesome if it was possible to add custom ships with a datapack

[sullen depot]

It is possible! There are a couple extra steps, I’ll make a tutorial at some point but if you’re interested i can give you a quick and dirty explanation rn

[sullen depot]

Yeah, in the video I was playing with this resource pack https://modrinth.com/resourcepack/pirate

[ocean pumice]

aah, thats cool

[thin gust]

oh that's sick! Well I'm not in a rush to try it out yet but yeah I'm interested in that

[sullen depot]

Awesome :)

[quiet hatch]

Minecraft is litteraly From The Depths 2.0

Enemys, thrusters, armor, tanks, planes, helicopters

Mod is awesome

[sullen depot]

Thank you!

[sullen depot]

Ok, so first there’s this variable in the mod called PiratesIsLiveWorld that works sorta like a gamerule and probably should be turned into a gamerule. Lol. You can change it by right clicking the air with the testing stick item from this mod, if you run the game with the output log (can be enabled via setting in minecraft launcher) it’ll give an output. iirc shift right clicking with the stick at the air sets the variable to true, right clicking without shift sets it to false. Setting it to false will prevent the ship from trying to assemble itself while you’re trying to build it.

The testing stick has a different function if you right click at a ship, but i actually don’t know what it’s for and at some point I tried it and it crashed

Next, if you want cannons to shoot at you use a debug stick to set disarmed = false. Lastly (i think) place crew spawner blocks where you want pirates to spawn. Make sure they have conditional=true with F3 (unless you’re building a land structure instead of a ship). If you have cannons that auto fire, you will want a crew spawner block adjacent so that a pirate can crew the cannon and disable it when he dies. Motion block only works under a helm, put a crew block in front of the helm if you want a captain (to break the motion block when he dies). I think that’s it, aside from the above it just works like a regular structure

[thin gust]

So every crew spawner has to be touching a cannon, and one touching the helm to create a captain, is that right?

[sullen depot]

Kinda lol

You can have it out in the open, the spawned pirate just won’t interact with any motion block or cannon

Also the cannons can be adjacent or one block down from adjacent, there are 8 possible spots. Only 4 possible spots for the motion block, which is side+down (for each side)

        BlockPos blockResult = new BlockPos(0,0,0);

        if (world.getBlockState(origin.north()).isOf(Pirates.CANNON_PRIMING_BLOCK)) {
            blockResult = origin.north();
        } else if (world.getBlockState(origin.east()).isOf(Pirates.CANNON_PRIMING_BLOCK)) {
            blockResult = origin.east();
        } else if (world.getBlockState(origin.south()).isOf(Pirates.CANNON_PRIMING_BLOCK)) {
            blockResult = origin.south();
        } else if (world.getBlockState(origin.west()).isOf(Pirates.CANNON_PRIMING_BLOCK)) {
            blockResult = origin.west();
        }

        BlockPos origin1 = origin.down();

        if (world.getBlockState(origin1.north()).isOf(Pirates.MOTION_INVOKING_BLOCK) || (world.getBlockState(origin1.north()).isOf(Pirates.CANNON_PRIMING_BLOCK))) {
            blockResult = origin1.north();
        } else if (world.getBlockState(origin1.east()).isOf(Pirates.MOTION_INVOKING_BLOCK) || (world.getBlockState(origin1.east()).isOf(Pirates.CANNON_PRIMING_BLOCK))) {
            blockResult = origin1.east();
        } else if (world.getBlockState(origin1.south()).isOf(Pirates.MOTION_INVOKING_BLOCK) || (world.getBlockState(origin1.south()).isOf(Pirates.CANNON_PRIMING_BLOCK))) {
            blockResult = origin1.south();
        } else if (world.getBlockState(origin1.west()).isOf(Pirates.MOTION_INVOKING_BLOCK) || (world.getBlockState(origin1.west()).isOf(Pirates.CANNON_PRIMING_BLOCK))) {
            blockResult = origin1.west();
        }


        return blockResult;
    }```

Here is actual code for the crew spawner block

so it checks four sides for cannon priming block (cannon activator), then moves down 1 and checks four sides for either cannon or motion block

if nothing is found, it just spawns a pirate that mostly works like any old mob (tries to kill you, drops gold)

[thin gust]

alright, pretty easy to understand, thank you so much for explaining how it works! so after that i can just generate the structure anywhere. would be cool to split bigger ships into 2/3 slices and have jigsaws between them to have somewhat randomly generated interiors

Actually another thing, would mobs created with the structure itself work? Or are only the pirates specifically made for those ships

I assume the crew spawners spawn them after the ship gets assembled so they don't fall through the floor

[sullen depot]

Exactly

Also having a block on the ship to spawn the entity makes it way easier to detect where the cannons are and stuff

But the alpha version of the mod just used mob spawner blocks (vanilla) and including entities in the structure should work as normal

[thin gust]

Hm alright, Datapackable crew spawners when?

[sullen depot]

Hmmmm :) that’s a good idea, i hadn’t considered it. Next update mayyybe?

One thing I was considering was giving crew spawners an enum property (a blockstate with a number, like kelp age or something)

And making 0 spawn the pirates, and each other number have an empty method for addons to mixin to

Cuz then they could add their own spawn logic if they want

But maybe I can reserve a number for datapack makers? Or maybe creating a datapack for this mod doesn’t need more complexity lmao

I can’t wait to see what you make. While making this I built probably a dozen ships and the one in the mod is the only one I made that seemed well suited. It’ll be really cool to see more ships for the mod

[thin gust]

yea I think spawning a mob right at the spawner is good enough

[sullen depot]

Wdym lol

[thin gust]

Well you mentioned custom spawn logic, the spawner blocks spawn a crew member right where the block is, right?

or is it random

[sullen depot]

The crew spawner blocks do, yes. They have no hitbox and spawn the pirate right on top of itself, then delete itself

[thin gust]

Me and two friends had the idea of a pirate themed adventure modpack with vs2 since over a year now, but we had the problem of not having actual threats in the ocean for playing in singleplayer or co-op, this mod changes everything

[sullen depot]

That’s awesome

I tried making a pirate pack a few months ago but it seemed really bad how all the ship structures were static (like from Towns and Towers, ect)

[thin gust]

Yeah, same problem pretty much, the best mod we've found back then was one that allowed pillagers to use boats lol

[sullen depot]

If you make a datapack and need crew spawner blocks to spawn a certain entity, would you be opposed to packaging your datapack as a mod? For now it would probably be easiest to just make a new crew spawner block that spawns a different entity. I can do the last part for you, it’s pretty easy

Although I’ll note that most mobs in MC will fall off the ship pretty quickly, I gave my pirates custom AI changes to help them stay on the ship better

[raw rapids]

Wooh release.

You can also make custom boat patterns, they are a tad weird tho

[sullen depot]

True!!

If someone makes a figure 8 pattern that would be cool

[raw rapids]

yeah entities don't like VS ships much it messes up there AI hence G_Mungus's fix

[raw rapids]

the system is a bit weird as a series of pauses and turns (just because that's how eureka ships move):

But it is possible to do any shape, most of them will not be infinite but rather travel however

[thin gust]

Ah, well my first idea was just having villagers in jail cells, not sure if you mean them falling off as in phasing through the ship or walking off an edge, since if it's the latter it should be fine then

I haven't experimented much with mobs on ships

[raw rapids]

They typically stay still once you put them on and don't phase, but they struggle a lot with moving

[sullen depot]

I found that hostile mobs really like to chase you off the ship and drown

[raw rapids]

that was the original thing with teleporting the pirates to you, but that was more of a temporary fix lol

[tardy egret]

with the power of vs minecraft returns to its status of every game in existance with some mods

[wary meadow]

Sick bro, there some chance to make a compat with some of the 1 thousand one piece mods ?

[sullen depot]

Thanks! It should be compatible with most mods, although if you’re asking for integration it’s unlikely that I would make it. However, the mod is open source and MIT license so if you or someone else wants to make a mod to add integration with something, go ahead :)

[raw rapids]

not sure if any of the onepiece mods are on 1.20.1, I did actually work on one of them for a short while and I also did pirate ships lol. maybe ill see if there are any substatial ones on 1.20.1

[orchid iris]

Don Kreig is bouta get a free meal outta this one

[thin gust]

crew spawner blocks don't seem to exist neither in the creative menu nor /give, though they can be placed with /setblock

same for the other blocks

[sullen depot]

This is true. That was actually intentional, sorry I know it’s a bit annoying. Reason is because before I removed the items, with VS Crumbles, if the block got converted to a falling block then landed on a slab or something, the item would drop. I didn’t want it to be obtainable in survival and removing the item completely seemed like an easy fix lol

[thin gust]

can't you just replace the crew spawner with air once it spawned the mobs in

no reason for it to exist afterwards

[sullen depot]

That does happen

I mean that’s how it works already

My main concern was motion blocks dropping, since they aren’t removed right away, but I removed crew spawners too just in case

[thin gust]

then just

Make the blocks not drop themselves so it's only usable in creative that way

[sullen depot]

When building the structure, I found it easy enough to place orange wool or something everywhere I wanted a crew block, then do /fill (corner of ship) (opposite corner of ship) crewspawner replace orange_wool

[thin gust]

Im sure that's a thing right

[sullen depot]

Probably is

You’re right, it would have been better. I did it this way cuz I had been working on the update for almost a month and just wanted to get it released

[thin gust]

yea understandable, I'm just tryna help not criticize

[sullen depot]

All good!

I appreciate it

I’m sorry there’s jank, it’s on my list to fix alongside the PiratesIsLiveWorld thing lol

[thin gust]

no need to apologize, take your time 👍 it still works afterall

[sullen depot]

Thanks bro. Looking forward to seeing your datapack!

[storm aurora]

Do you have a command to make one spawn ? My server map is already fully generated with the old ones. Also I will made one that flies :}

[sullen depot]

The ships spawn in the same way regular structures are generated in the world. You can spawn them in with ‘/place structure pirates:ship’ or ‘/place template pirates:ship1’

[storm aurora]

Nice, thank you !

[sullen depot]

No problem! Note though that there are some pretty significant changes in this update and you might want to backup your world before updating the mod

More specifically, the old ship structure will probably have issues in the new version because the cannon priming block now faces a direction, meaning that the cannon priming blocks on the old ship will probably all face north and not work

[storm aurora]

Good to know ! I did the backup before testing the update. If the cannons are the only issue, it's all good !
So now they can avoid other structures, and chase you ? That is well what I've seen ? I am not halucianting it ? 😄

[sullen depot]

Right now the ships only drive in a circle, or otherwise in a preset pattern specified via config

Ships that avoid structures and chase after you would be immensely cool, maybe I’ll add that eventually but it sounds hard

[storm aurora]

Okay ! So I was hallucinating it lol. I might have been in the center of the patern.
Yeh that sound a bit tricky to do

I love the new details like the cannon fuse, neat

[sullen depot]

Thank you!!

[full swift]

I used my own cruiser with fire control and radar to attack the pirate. I think that's how valkyrien battles should be

[little bluff]

this is a cool mod, if there is a deck on your ship blow the water is it flooded, and further more if it's not flooded, having a cannon shoot a hole threw it, will the lower deck start flooding?

[sullen depot]

This does not change anything about how the water works in Valkyrien Skies. A deck below sea level will be flooded

[sullen depot]

These videos look so cool

[full swift]

I think I can change the structure and add cannons using datapack to make addon of the mod

Maybe possible to get the cannons work

[sullen depot]

@thin gust

Polishing some things up for you

[thin gust]

[sullen depot]

https://discord.com/channels/244934352092397568/1292609507679277107

[normal sand]

Will this mod release on forge too?

[sullen depot]

It is not planned

[normal sand]

Do you know if connector is working with this addon?

[pliant vector]

No

[sullen depot]

Yes, but only with later versions afaik

[pliant vector]

Wait

Wrong channel 😭

[sullen depot]

Scared me for a sec 😅

[raw rapids]

i have been tempted to port it to neforge but idk if that will happen whilst vs is still on 1.20

[normal sand]

Oh nicee thank you

[raw flame]

@sullen depot I just downloaded this mod, and my first reccomendation is to make the ships go in bigger circles instead of just circling around one anchor. You could have like a big circle and have it rotate there instead

[raw rapids]

the circles are actually based on the ships speed, so a small ship typically takes bigger circles. the programming doesnt actually define it as a circle, it just applies force forward and right (or left). so we are considering having a speed adjustment in the motion block so that all the circles are bigger

[raw flame]

I see now. That makes more sense however instead of increasing speed which would be a fast approach, consider making the ships sail a defined path with straight lines that turn 90 blocks before hitting land. Consider having them engage your ship and actually start moving toward it

[raw rapids]

Ship ai is planned but it's quite complicated for comparatively

[raw flame]

I understand that

also, if ramming and ship cleaving is ever added through addons, will you ever make greek ships with that?

[raw rapids]

i think there is suppose to be an update sometime for ship on ship event detection, and ship splitting, so perhaps that may happen soon

[raw flame]

perfect