#Eureka fails to load if running a self-compiled VS jar

1 messages · Page 1 of 1 (latest)

jade charm
#

I'm making a patch to VS to fix twilight forest compat and when i compile VS and load it up i can tell that the patch is working by using the shipifier stick, but Eureka refuses to load alongside the modified VS jar, giving me the error:
Exception message: java.lang.NoSuchMethodError: 'org.valkyrienskies.core.impl.util.events.EventEmitterImpl org.valkyrienskies.mod.common.hooks.VSGameEvents.getRegistriesCompleted()' while the stacktrace reports that it was running org.valkyrienskies.eureka.EurekaBlocks.register(EurekaBlocks.java:173) ~[eureka-1201-1.5.1-beta.3.jar%23136!/:?] {re:classloading}

So uhh am I compiling wrong? I'm pretty unfamiliar with gradle and intellij, admittedly.

frank palm
#

Sounds like in modifiying VS you've accidentally removed the getRegistriesCompleted() function that eureka needs?

#

Also, if you got the VS source from github, the newest source code doesn't work with addons since its gone through so many changes with the VS-api, so make sure your using a version of the source code that has been released as a proper version

jade charm
frank palm
#

Though I've never actually gotten the VS source myself, so I don't actually know how to get the "working" latest

jade charm
#

yep i copied my patch across to the source as it is in the 2.3.0-beta.5 release and it works. Thanks

frank palm
#

how did you fix it with twilight forest btw?

jade charm
#

turns out the only reason that ships in the TF were broken is because TF has its own version of the NoiseBasedChunkGenerator class that VS mixins into to cancel chunk generation, so it was bypassing VS's mixins

frank palm
#

ah

jade charm
#

TF's custom generator uses the same interface though so copying across the same mixins and pointing them to TF's custom class fixes it

frank palm
#

interesting

#

do you know if this patch has been implemented in the VS source?

#

(unreleased)

jade charm
#

i've seen no hints of TF compat in any of the sources i've seen

frank palm
#

Huh, well if your willing at some point you could do a pull request or whatever it is to try and add the fix yourself?

#

Idk actually if your allowed to on the VS github, but if you are that would be a good fix for the next VS version

jade charm
#

hopefully, just gotta organise my random splotches of code into an actual fork on GH then i'll definitly look to PR it back in