Health bar not moving | Brackeys Community | Page 1

fallen tendon Jun 14, 2023, 2:11 PM

#

I'm trying to fix a health bar and I forgot where it came from. The bar is not sliding in the unity editor. When damage is taken a red background bar should follow the front bar with some delay to cause a shrink effect, and when healed the back bar should set to what the new health is going to be and then the front bar slide up to the backbar (also, should be green when adding health)

    {
        float fillF = frontHungerBar.fillAmount;
        float fillB = backHungerBar.fillAmount;
        float hFraction = Hunger / 100;
        if (fillB > hFraction)
        {
            frontHungerBar.fillAmount = hFraction;
            backHungerBar.color = Color.red;
            HunlerpTimer += Time.deltaTime;
            float percentComplete = HunlerpTimer / chipSpeed;
            percentComplete = percentComplete * percentComplete;
            backHungerBar.fillAmount = Mathf.Lerp(fillB, hFraction, percentComplete);
        }

        if (fillF < hFraction)
        {
            backHungerBar.color = Color.green;
            backHungerBar.fillAmount = hFraction;
            HunlerpTimer += Time.deltaTime;
            float percentComplete = HunlerpTimer / chipSpeed;
            percentComplete = percentComplete * percentComplete;
            frontHungerBar.fillAmount = Mathf.Lerp(fillF, backHungerBar.fillAmount, percentComplete);
        }
    }```

oblique cave Jun 14, 2023, 2:18 PM

#

fallen tendon I'm trying to fix a health bar and I forgot where it came from. The bar is not s...

My first guess is that you are dividing two integers together

fallen tendon Jun 14, 2023, 2:20 PM

#

at percentComplete?

fossil egret Jun 14, 2023, 4:14 PM

#

oblique cave My first guess is that you are dividing two integers together

but HunlerpTimer is clearly a float, because OP is adding deltaTime

oblique cave Jun 14, 2023, 4:57 PM

#

I assumed Hunger / 100 would be the problem, didnt really read all of the code but thats very common problem when people do division to get number between 0 and 1

fossil egret Jun 14, 2023, 5:18 PM

#

ah I did not see that line

#

Yes if Hunger is an int that would certainly yield unexpected results

fallen tendon Jun 14, 2023, 5:30 PM

#

Hunger is a float

#

I believe the problem lies in the if statements but I honestly have no clue what fillB> hFraction and FillF < hFraction does

fossil egret Jun 14, 2023, 5:48 PM

#

Did you not write this code?

fallen tendon Jun 14, 2023, 5:52 PM

#

No I did not

#

It was a few years back so I have no idea where I got it from

fossil egret Jun 14, 2023, 5:53 PM

#

I see. Well, from the looks of the code, it appears to interpolate the fillAmount up or down based on the current fill and the desired fill

#

or rather, I should say, two different bars. front and back, whose current values are fillF and fillB respectively

fallen tendon Jun 14, 2023, 5:55 PM

#

I assume that fillF < hFraction is when it should be going down?

fossil egret Jun 14, 2023, 5:56 PM

#

I'm not sure why one is < and the other is >

fallen tendon Jun 14, 2023, 5:56 PM

#

And what about the Mathf.Lerp, what do the first 2 variables do? Im not sure when fillB, fillF, or hFraction should be used

fossil egret Jun 14, 2023, 5:57 PM

#

Well Lerp is just a formula

#Health bar not moving