Just looking to see if anyone have some good optimization tips

[dry wigeon]

private void OnTriggerEnter2D(Collider2D other)
    {
        if (other.CompareTag("Npc") && other.GetComponent<DialogueTrigger>().hasBeenTalkedTo == false)
        {
            myRigidBody.isKinematic = true;
            myRigidBody.velocity = Vector2.zero;
            insideDialogue = true;
            other.GetComponent<DialogueTrigger>().TriggerDialogue();
            other.GetComponent<DialogueTrigger>().hasBeenTalkedTo = true;
        }
    }

idk if this need optimization or not, cuz idk if getting the same component multiple times when entering a trigger is taxing on performance or not

[normal portal]

private void OnTriggerEnter2D(Collider2D other)
    {

if (other.CompareTag("Npc") 
{

if(other.TryGetComponent(out DialogueTirgger _dialoueTirgger))
{
if(_dialoueTirgger.hasBernTalkedTo)
return;

myRigidBody.isKinematic = true;
            myRigidBody.velocity = Vector2.zero;
            insideDialogue = true;
            
_dialoueTirgger.TriggerDialogue();
_dialoueTirgger.hasBeenTalkedTo = true;

}
}
}
      

I’m typing on phone. Idk work or not. You can use trygetcomponent to ref it

[polar iron]

Yes it is taxing performance, just get it once and cache it as zgbb shows. Using TryGetComponent isnt required to do that but gives nice syntax for that