Text above head [JAVA] | Minehut | Page 1

severe oar Dec 9, 2024, 5:44 PM

#

I'm making a plugin with the feature to display a player's chat messages above their head, but i only want one chat message displayed at a time. I have a HashMap that links a player to one armor stand, but multiple may exist at the same time regardless of the checks i have in place. I think it has something to do with these lines (INSIDE A FUNCTION WHICH IS CALLED ON PLAYERCHATEVENT).

        if (playerArmorStand.containsKey(p)) {
            ArmorStand existingStand = playerArmorStand.get(p);
            existingStand.remove();
            playerArmorStand.remove(p);
        }

        // Set variables to be used
        Location loc = p.getLocation();
        ArmorStand chat = p.getWorld().spawn(loc, ArmorStand.class);
        World world = p.getWorld();

        // Associate a specific armor stand with the player
        playerArmorStand.put(p, chat);

chilly pulsar Dec 9, 2024, 6:07 PM

#

just create 1 armor stand and rename it rather than creating a new one each time

severe oar Dec 9, 2024, 6:11 PM

#

chilly pulsar just create 1 armor stand and rename it rather than creating a new one each time

i still have to check if an armor stand exists for the player to determine if one should be spawned or not

#

and that check just doesnt work for some reason

chilly pulsar Dec 9, 2024, 6:12 PM

#

@EventHandler
    fun onChat(event: PlayerChatEvent) {
        val player = event.player
        val stand = armorStands[player]
        if (stand != null) {
            stand.customName = event.message
        } else {
            val created = player.world.spawn(player.location.add(0.0, 0.5, 0.0), ArmorStand::class.java)
            created.setGravity(false)
            created.isVisible = false
            created.customName = event.message
            created.isCustomNameVisible = true
            created.isInvulnerable = true
            armorStands[player] = created
        }
    }

this code worked fine for me.just convert it to java

severe oar Dec 9, 2024, 6:23 PM

#

chilly pulsar ```kt @EventHandler fun onChat(event: PlayerChatEvent) { val player ...

i have a lot more than just displaying the messgae

#

ill put the whole class here

#

i tried to implement a similar solution, bt didnt work

#

public class MessageHead {

    private final server plugin;

    public MessageHead(server plugin) {
        this.plugin = plugin;
    }

    public final Map<Player, Queue<String>> map = new HashMap<>();

    public final Map<Player, ArmorStand> playerArmorStand = new HashMap<>();

    public final Map<Player, Boolean> armorStandExists = new HashMap<>();

    public void messageDisplay(Player p, String m) {

        if (armorStandExists.get(p) != null) {
            return;
        }

        // Set variables to be used
        Location loc = p.getLocation();
        World world = p.getWorld();
        ArmorStand chat = world.spawn(loc, ArmorStand.class);

        // Associate a specific armor stand with the player
        playerArmorStand.put(p, chat);
        armorStandExists.put(p, true);

        // Set armor stand properties
        chat.setVisible(false);
        chat.setGravity(false);

        // Final shenanigans to make it work in the runnable
        final String[] chatMessage = {""};
        final int[] finalI = new int[1];

        // Repeating task instead of a loop, so I can add delay
        new BukkitRunnable() {
            @Override
            public void run() {

                // Display message character by character
                chatMessage[0] = chatMessage[0] + m.charAt(finalI[0]);
                chat.setCustomName(chatMessage[0]);
                chat.setCustomNameVisible(true);

                // Play sound as if player has a voice
                Location newloc = p.getLocation();
                world.playSound(newloc, Sound.BLOCK_STONE_BUTTON_CLICK_ON, 0.5F, 1);

                // Teleport armor stand to player
                messageTeleport(p);

                // When loop is finished
                if (finalI[0] + 1 >= m.length()) {

                    // Get rid of display
                    messageFade(chat, p);
                    cancel();
                }

                finalI[0]++;
            }
        }.runTaskTimer(plugin, 0, 1);
    }

    public void messageQueue(Player p, String m){

        // Create temp queue
        Queue<String> messageQ = new LinkedList<>();

        // If map doesn't have anything, add it
        if (!map.containsKey(p)){
            map.put(p, messageQ);
        }
        map.get(p).offer(m);
    }

    public void showNextMessage(Player p){

        Queue<String> messageQueue = map.get(p);
        if (messageQueue != null && !messageQueue.isEmpty()){
            String nextMessage = messageQueue.poll();
            messageDisplay(p, nextMessage);
        }
    }

    public void messageTeleport(Player p) {
        if (!(map.get(p) == null)){
            ArmorStand a = playerArmorStand.get(p);
            a.teleport(p);
        }
    }

    public void messageFade(ArmorStand a, Player p){
        BukkitTask balls = new BukkitRunnable(){
            @Override
            public void run(){
                messageTeleport(p);
            }
        }.runTaskTimer(plugin, 1, 1);
        new BukkitRunnable(){
            @Override
            public void run(){
                balls.cancel();
                a.remove();
                playerArmorStand.remove(p);
                armorStandExists.replace(p, null);
                showNextMessage(p);
            }
        }.runTaskLater(plugin, 80L);
    }
}

#

ignore bukkittask balls

#

was very tired last night

chilly pulsar Dec 9, 2024, 6:27 PM

#

so is the issue just that there are multiple armor stands for a player getting created?

severe oar Dec 9, 2024, 6:27 PM

#

on each chat message, yes

#

i want it to skip creation until the previous finishes displaying

#

but it doesnt want to do that

#

perhaps i can do stuff with the persistent data container

chilly pulsar Dec 9, 2024, 6:29 PM

#

try adding debug messages before and after each condition to see what part of the code it is reaching and where it stops

severe oar Dec 9, 2024, 6:29 PM

#

set it to 1 when there exists an armor stand, and

#

ok

severe oar Dec 9, 2024, 6:51 PM

#

so basically the maps are local variables

#

even though i declare ttthem outside the functions

#

if only i could store a queue inside tthe persistent data container

crystal carbon Dec 9, 2024, 7:21 PM

#

i saw a plugin like what you tryna make on spigotmcc, best of luck makin this

severe oar Dec 9, 2024, 7:39 PM

#

thanks

#

it's almost done i just don't know how to access a persistent queue

#

perhaps if i created a queue for the player when they joined

severe oar Dec 9, 2024, 8:09 PM

#

GOT IT TO WORK

#

i love the static modifier

#

crystal carbon Dec 10, 2024, 3:14 AM

#

severe oar

feels like the text could be more dynamic but sick 😄

severe oar Dec 10, 2024, 3:14 AM

#

wdym

crystal carbon Dec 10, 2024, 3:15 AM

#

what i mean for dynamic is like behind the text its like gray dark ish

#

idk how you would exactly do it but ik it's possible

severe oar Dec 10, 2024, 3:15 AM

#

i mean it's just vanilla nametag stuff with armor stands

crystal carbon Dec 10, 2024, 3:15 AM

#

severe oar

is this gonna be a public plugin or is it private?

severe oar Dec 10, 2024, 3:15 AM

#

private

crystal carbon Dec 10, 2024, 3:15 AM

#

aw

severe oar Dec 10, 2024, 3:16 AM

#

i mean i could make a seperate version that is public

crystal carbon Dec 10, 2024, 3:16 AM

#

😄

severe oar Dec 10, 2024, 3:16 AM

#

it also includes the ability to change your "voice" (sound effect used when a character is displayed) and voice pitch

#

im working on a reputation system for my plugin though

crystal carbon Dec 10, 2024, 3:17 AM

#

severe oar im working on a reputation system for my plugin though

wdym

severe oar Dec 10, 2024, 3:18 AM

#

player hits another player. if victim dies shortly after (like 30 seconds), the attacker's reputation value goes down

#

was thinking to color peoples' text based on their reputation value

#

so if they were really "bad players", their text would be red

#

and if they were really good, it would be light blue or something

crystal carbon Dec 10, 2024, 3:19 AM

#

severe oar so if they were really "bad players", their text would be red

could be easily abused but mm yea def a configurable option tho for public plugin

severe oar Dec 10, 2024, 3:19 AM

#

how would be easily abused

crystal carbon Dec 10, 2024, 3:20 AM

#

severe oar how would be easily abused

i can't pinpoint exactly but ppl will figue out how to abuse it

#

trust me

severe oar Dec 10, 2024, 3:21 AM

#

well its mostly to pinpoint people who often kill others compared to their playtime

#

they would get reputation points over time played, so if they killed people a lot they would have a relatively low reputation

crystal carbon Dec 10, 2024, 3:22 AM

#

reputation system has never worked out for anything in mc tbh

severe oar Dec 10, 2024, 3:23 AM

#

was also thinking about it being a ratio to like (((player kills * 20) + (damage to players))/2)/(time played in hrs/30)

severe oar Dec 10, 2024, 3:24 AM

#

crystal carbon reputation system has never worked out for anything in mc tbh

what do you mean

crystal carbon Dec 10, 2024, 3:25 AM

#

severe oar what do you mean

i remember i heard about how there was a plugin in older days of mc where if u got banned 3 times on ANY server with the plugin you would get perm banned on any with the plugin, so after a group of griefers got the 3 strikes they just made there own server server 3x and banned whoever banned them, a decent example of a reputation system not working

severe oar Dec 10, 2024, 3:26 AM

#

dang

#

that crazy but not really what im aiming for

#

more to allow the players to distinguish between friendlies and non-friendlies

#

though there could be someone that just runs around and breaks stuff and places blocks to grief that wouldn't be marked as unfriendly

#

and people would often try to kill them

#

so they would lose rep

#

hmmm

#

i have an idea

#

dont think its ever been done before

#Text above head [JAVA]