TEXTDRAW SIMPLE CLICK

[fathom ridge]

The purpose of this include is to simplify the creation of interactions with textdraws in SAMP. However, I had an unexpected result with this include as the responsiveness greatly improved. Now the click is extremely faster and smoother. If you encounter any problems, please report them to me privately, and I will fix or help. Thanks ♥️

Repository: https://github.com/devbluen/textdraw-simple-click

[true elbow]

mclovin

[grim badge]

You want to tell me your usage of hooks and als in the include is 200% faster than my usage of hooks

[fathom ridge]

Your clicks will be faster as there will be no need to check in all the hooks where the real click is.

[grim badge]

I’m afraid it was the code you were running if you encountered such performance issues mate
You should measure the speed difference and post the results with the test you made
I have strong doubts about those claims

Btw max symbol name has been increased in the 3.10.11 compiler to 63

[fathom ridge]

You can indeed run the tests on your own project and see for yourself. The response time can be observed with the naked eye. However, as soon as I have some free time, I will provide a metric in the repository, which I believe is valid.

Regarding the callback, open-mp does have a higher limit, but we must remember that there are still people using the native version. By default, it is advisable to set it to 32 to avoid issues. However, since the code is open-source, you can change it to the limit you desire.

[grim badge]

How can a hook in your include which executes CallLocalFunction be faster than a bare script hooking the same callback and running the code directly

Your end users should never be told to edit the include themselves, unless they want to contribute by making a PR

[fathom ridge]

Y_hooks is nothing more than, simply put, a loop going through multiple callbacks. OnPlayerClickPlayerTextDraw in the hook will go through several if statements until it finds your result, the same goes for ALS.

However, the created include will not go through this process of searching for the result; it will go directly to where you want. CallLocalRemoteFunction will call only one callback, and all your click logic will be within it. Yes, the include has a hook, but if you look closely at the code, it is called only once and is blocked from continuing if the specific textdraw has a registered interaction (click).

Regarding the callback length, as I mentioned before, not everyone feels confident using open-mp and prefer to stick with the native one. However, if someone happens to be using it and feels the need to use more than 30 characters in a callback, they can simply go to the include and increase the limit. Although I don’t believe this will occur, it is possible. 😊

[grim badge]

Ok my talking here is a bit pointless I see
Just mention me once you measure the performance gains 👍

[fathom ridge]

I will not return here to inform you about the performance improvement. If you are interested, follow the GitHub repository; as soon as I have time or another user wants to do it, of course, it will be available in the README publicly. 😊

[dense escarp]

This trades memory for processing a repetition structure when used in slots in an inventory for example, so I see a performance advantage on that side, but I've already made better inventories with global textdraws which is not supported by the include and was also made to those who like the easyDialog style, which is not my case because I like y_inline, although they are easy cases to solve.

As the use of the PlayerTextDrawSetClick function is optional, it may be that whoever uses it has other clickable textdraws without using this function, and if this is true, the include is break the OnPlayerClickPlayerTextDraw hook chain with ~1 which can harm whoever is using include. cpp if (!e_TextdrawData[playerid][playertextid][E_TEXTDRAW_DATA_VALIDA]) return Y_HOOKS_CONTINUE_RETURN_1; // Or 1

[fathom ridge]

This variable prevents the hook from being called if the textdraw is not valid, however it is always valid because the define macro is always working, it is possible that a future change will be made to this issue.
Thank you for your feedback and point of view ^^

[worthy dagger]

how does this include handle spam clicks from players, mate? Got any built-in system to stop 'em from abusing or spamming the textdraw clicks?

[fathom ridge]

At the moment there is no protection against spam, but it is interesting that later I add some protections to the include, so that whoever uses this include has the protection "natively". Thanks for the suggestion 😊

[worthy dagger]

so, what’s the next feature or improvement you’ve got planned for this include, mate?

u gonna keep developing this include or just hand it over to the community to update themselves? And is it alright if they go ahead and tweak it or make changes?

[fathom ridge]

I always keep my repositories updated as needed, but the entire community can contribute to the open-source project. They can create plugins or add to existing plugins. To be quite honest, it would be very interesting if it were someday added natively to open-mp.

[grim badge]

It can’t be added to open.mp as it doesn’t even bring performance improvements you think it does. The 200% improvement statement that’s in the readme is literally made up (╯°□°）╯︵ ┻━┻

[fathom ridge]

You're still talking nonsense, selfish. Add the include to your project, a consolidated project with many things, and test it. Otherwise, there's nothing I can do. Unfortunately, I didn't make it to please you, Lmao.

[grim badge]

Ok, enlighten everyone how did you figure your include makes things so fast if you haven’t benchmarked a single thing

[worthy dagger]

is it alright if me, or maybe someone else, tweaks/updates the include and adds in the Open-MP natives?

[fathom ridge]

Sure, feel free to add it wherever you want. If you do, please send it to me; I'd be happy to see it applied in more sophisticated features beyond a basic include.

[worthy dagger]

alr cheers mate, I will try to update the include ASAP

[shrewd plank]

┬─┬ノ( º _ ºノ)

[grim badge]

listen pal (╯°益°)╯彡┻━┻

[civic nebula]

🍿

https://github.com/guil2k7/samp-textdraw-streamer

[dense escarp]

Its a really strong quote and only with GetTickCount would not show this difference, but I thought the idea of ​​adding extra data to a textid was good, maybe I would use PawnPlus for that

stock TextDrawGetArrayData(Text:textid, data[], size = sizeof (data)) {
    pool_get_arr(gTextDrawData, _:textid, data, size);
}```

[fathom ridge]

The idea is really this, to simplify clicks as the include's name suggests. However, in my project, which is indeed quite large and with many layouts, I noticed a significant difference in response times because it doesn't need to go through all the checks before reaching my click target.

However, it is a versatile include and can be adapted to other things and tools, such as the PawnPlus you mentioned. In a Brazilian development community, they compared the system to easyDialog for its practicality and the cleanliness of the resulting code.

[fathom ridge]

As I mentioned, anyone can take over the project and create other directions like plugins or enhance existing plugins with the idea of the include as undefined did. It turned out really well even though I don't use the textdraw-streamer, I know its adaptation was good.

[pure swallow]

How to install textdraw?