Dialog Login Didn't Showing | The San Andreas Multiplayer SAMP open.mp Official Community 🐧 | Page 1

visual mango Jun 4, 2023, 10:09 AM

#

if(dialogid == DIALOG_VERIFYCODE)
    {
        if(response)
        {
            new str[200];
            if(isnull(inputtext))
            {
                format(str, sizeof(str), "UCP: {15D4ED}%s\n{ffffff}Silahkan masukkan PIN yang sudah di kirimkan oleh BOT", UcpData[playerid][uUsername]);
                return ShowPlayerDialog(playerid, DIALOG_VERIFYCODE, DIALOG_STYLE_INPUT, "Verify Account", str, "Input", "Cancel");
            }
            if(!IsNumeric(inputtext))
            {
                format(str, sizeof(str), "UCP: {15D4ED}%s\n{ffffff}Silahkan masukkan PIN yang sudah di kirimkan oleh BOT\n\n{FF0000}PIN hanya berisi 6 Digit angka bukan huruf", UcpData[playerid][uUsername]);
                return ShowPlayerDialog(playerid, DIALOG_VERIFYCODE, DIALOG_STYLE_INPUT, "Verify Account", str, "Input", "Cancel");    
            }
            if(strval(inputtext) == UcpData[playerid][uVerifyCode])
            {
                new lstring[512];
                format(lstring, sizeof lstring, "{ffffff}Welcome to {15D4ED}"SERVER_NAME"\n{ffffff}UCP: {15D4ED}%s\n{ffffff}Password: \nSilahkan buat password baru kamu!:", UcpData[playerid][uUsername]);
                ShowPlayerDialog(playerid, DIALOG_REGISTER, DIALOG_STYLE_PASSWORD, "Registration Great", lstring, "Register", "Quit");    
                return 1;
            }

            format(str, sizeof(str), "UCP: {15D4ED}%s\n{ffffff}Silahkan masukkan PIN yang sudah di kirimkan oleh BOT\n\n{FF0000}PIN salah!", UcpData[playerid][uUsername]);
            return ShowPlayerDialog(playerid, DIALOG_VERIFYCODE, DIALOG_STYLE_INPUT, "Verify Account", str, "Input", "Cancel");    
        }
        else 
        {
            KickEx(playerid);
        }
    }

hidden flax Jun 4, 2023, 10:22 AM

#

The code seems works fine to me make sure one of these conditions really meets with your data.

if(PlayerData[playerid][pPassword] > 10)
if(PlayerData[playerid][pPassword] > 1)

visual mango Jun 4, 2023, 10:22 AM

#

hidden flax The code seems works fine to me make sure one of these conditions really meets w...

im copying the verifycode script from another gamemode, but idk about this code

hidden flax Jun 4, 2023, 10:23 AM

#

Make a print statement inside the condition to check if it really meets it

visual mango Jun 4, 2023, 10:23 AM

#

if(PlayerData[playerid][pPassword] > 10)
if(PlayerData[playerid][pPassword] > 1)

How to read this

hidden flax Jun 4, 2023, 10:26 AM

#

visual mango if(PlayerData[playerid][pPassword] > 10) if(PlayerData[playerid][pPassword] > 1)...

I guess its checking if the pPassword value from the player is greater than 10 and if it is then go to the next condition which checks if its greater than 1 but I think not the best way to use pPassword name for integer values since we know that password is string

visual mango Jun 4, 2023, 10:29 AM

#

hidden flax I guess its checking if the pPassword value from the player is greater than 10 a...

should i change it?

hidden flax Jun 4, 2023, 10:29 AM

#

it depends on what you want to do with that code tbh I really don't know how your code works

#

For me this pPassword is checking for the password length?

visual mango Jun 4, 2023, 10:30 AM

#

hidden flax it depends on what you want to do with that code tbh I really don't know how you...

i want to let the script to check the pPassword is filled or no, i mean like, the player is new player, or no

#

if its new player, then the dialog verifycode showed

#

else, the dialog login showed

#

sorry for my bad english bro

hidden flax Jun 4, 2023, 10:31 AM

#

Where do you assign the value of this pPassword?

#

or how do you assign the value for this pPassword

hidden flax Jun 4, 2023, 10:33 AM

#

visual mango if its new player, then the dialog verifycode showed

You already did it with if cache_num_rows > 0

visual mango Jun 4, 2023, 10:34 AM

#

hidden flax or how do you assign the value for this pPassword

this?

visual mango Jun 4, 2023, 10:34 AM

#

hidden flax You already did it with ``if cache_num_rows > 0``

ah, let me send the original code before this

#

WRP::OnUCPLoaded(playerid, race_check)
{
    if (race_check != g_RaceCheck[playerid])
        return KickEx(playerid);

    new rows = cache_num_rows();
    new string[352];
    if (rows)
    {
        cache_get_value_name_int(0, "id", UcpData[playerid][uID]);
        cache_get_value_name_int(0, "admin", UcpData[playerid][uAdmin]);
        cache_get_value_name(0, "username", UcpData[playerid][uUsername], 64);
        
        format(string,sizeof(string),"{FFFFFF}Welcome back to {00FFFF}"SERVER_NAME"\n\n{FFFF00}UCP Account: %s\n{FFFFFF}Please input your password to login:",GetName(playerid));
        ShowPlayerDialog(playerid,DIALOG_LOGIN,DIALOG_STYLE_PASSWORD,"{FFFFFF}UCP Account Login",string,"Login","Cancel");
    }
    else
    {
        format(string,sizeof(string),"{FFFFFF}Welcome to {00FFFF}"SERVER_NAME"\n\n{FFFF00}UCP Account: %s\n{FFFFFF}Your UCP is doesn't exists\n{FFFFFF}Please input your Password for Register:",GetName(playerid));
        ShowPlayerDialog(playerid,DIALOG_REGISTER,DIALOG_STYLE_PASSWORD,"Account Register",string,"Register","Cancel");
    }
    return 1;
}

visual mango Jun 4, 2023, 10:35 AM

#

visual mango ```c WRP::OnUCPLoaded(playerid, race_check) { if (race_check != g_RaceCheck[...

this works fine

#

but the script not kicking the not registered player, it'll letting the player registering ingame

hidden flax Jun 4, 2023, 10:36 AM

#

visual mango this?

No I mean what values you assign to this pPassword

#

is it string?

visual mango Jun 4, 2023, 10:36 AM

#

hidden flax is it string?

yes

hidden flax Jun 4, 2023, 10:36 AM

#

Then you did a wrong check

visual mango Jun 4, 2023, 10:37 AM

#

hidden flax Then you did a wrong check

what should i do

#

sorry to bother you btw

hidden flax Jun 4, 2023, 10:37 AM

#

Go for strlen function

#

if strlen(pPassword) > 1
if strlen(pPassword) > 10

visual mango Jun 4, 2023, 10:38 AM

#

aight

hidden flax Jun 4, 2023, 10:39 AM

#

Ohh probably this pPassword value is not really a string

visual mango Jun 4, 2023, 10:39 AM

#

if strlen(PlayerData[playerid][pPassword] > 1)

hidden flax Jun 4, 2023, 10:40 AM

#

its supposed to give you an error when compiling tho if you compare a string with integer

visual mango Jun 4, 2023, 10:41 AM

#

i got invalid expression

hidden flax Jun 4, 2023, 10:41 AM

#

visual mango ```c if strlen(PlayerData[playerid][pPassword] > 1) ```

put ( before strlen

hidden flax Jun 4, 2023, 10:44 AM

#

visual mango ```c WRP::OnUCPLoaded(playerid, race_check) { if (race_check != g_RaceCheck[...

WRP::OnUCPLoaded(playerid, race_check)
{
    if (race_check != g_RaceCheck[playerid])
        return KickEx(playerid);

    new rows = cache_num_rows();
    new string[352];
    if (rows)
    {
        cache_get_value_name_int(0, "id", UcpData[playerid][uID]);
        cache_get_value_name_int(0, "admin", UcpData[playerid][uAdmin]);
        cache_get_value_name(0, "username", UcpData[playerid][uUsername], 64);
        
        format(string,sizeof(string),"{FFFFFF}Welcome back to {00FFFF}"SERVER_NAME"\n\n{FFFF00}UCP Account: %s\n{FFFFFF}Please input your password to login:",GetName(playerid));
        ShowPlayerDialog(playerid,DIALOG_LOGIN,DIALOG_STYLE_PASSWORD,"{FFFFFF}UCP Account Login",string,"Login","Cancel");
    }
    else
    {
    Kick(playerid);
    }
    return 1;
}

#

try this one if you really want to kick the player who is not registered

#

just fix the indentation I'm sorry I'm on mobile now

visual mango Jun 4, 2023, 10:57 AM

#

hidden flax put ( before strlen

idk why dialog_login still not showed

visual mango Jun 4, 2023, 10:59 AM

#

hidden flax try this one if you really want to kick the player who is not registered

yes, then i want to let the player that already have verifycode, to got the dialog_verifycode

#

like my example script

hidden flax Jun 4, 2023, 11:01 AM

#

visual mango if its new player, then the dialog verifycode showed

If you need something like this then the code you wrote above really wont work.

if cache_num_rows
it means the player account already exists
Show him this dialog login
else
Show him this verify code dialog

visual mango Jun 4, 2023, 11:03 AM

#

hidden flax If you need something like this then the code you wrote above really wont work. ...

i see

visual mango Jun 4, 2023, 11:05 AM

#

hidden flax If you need something like this then the code you wrote above really wont work. ...

then, if the player is not registered, and dont have verifycode also. How to kick it?

hidden flax Jun 4, 2023, 11:06 AM

#

what is the value of this verify code? I guess its Integer?

visual mango Jun 4, 2023, 11:07 AM

#

hidden flax what is the value of this verify code? I guess its Integer?

yes integer

hidden flax Jun 4, 2023, 11:09 AM

#

if it is then it should be something like this.

if cache_num_rows
it means the player account already exists
Show him this dialog login
else
if verifycode <= 0
kick him

Let's say this verify code invalid code is 0 or negative values then kicks him if it is less than or equal to 0

visual mango Jun 4, 2023, 11:15 AM

#

am i right?

visual mango Jun 4, 2023, 11:15 AM

#

hidden flax If you need something like this then the code you wrote above really wont work. ...

WRP::OnUCPLoaded(playerid, race_check)
{
    if (race_check != g_RaceCheck[playerid])
        return KickEx(playerid);

    new rows = cache_num_rows();
    new string[352];
    if (rows)
    {
        cache_get_value_name_int(0, "id", UcpData[playerid][uID]);
        cache_get_value_name_int(0, "admin", UcpData[playerid][uAdmin]);
        cache_get_value_name(0, "verifycode", UcpData[playerid][uVerifyCode], 64);
        cache_get_value_name(0, "username", UcpData[playerid][uUsername], 64);

        format(string, sizeof(string), "UCP: {15D4ED}%s\n{ffffff}Silahkan masukkan PIN yang sudah di kirimkan oleh BOT", GetName(playerid));
        ShowPlayerDialog(playerid, DIALOG_VERIFYCODE, DIALOG_STYLE_INPUT, "Verify Account", string, "Input", "Cancel");
    }
    else
    {
        ShowPlayerDialog(playerid, DIALOG_UNUSED, DIALOG_STYLE_MSGBOX,"Account Unregistered","{FFFF00}Nama Akun ini belum terdaftar!\n{ffffff}Silahkan daftar di Official Discord kami {15D4ED}"SERVER_NAME"\n{ffffff}Link Discord: {15D4ED}","Okay","");
        KickEx(playerid);
    }
    return 1;
}

hidden flax Jun 4, 2023, 11:16 AM

#

visual mango ```c WRP::OnUCPLoaded(playerid, race_check) { if (race_check != g_RaceCheck[...

yes I think

#

Give it a try

visual mango Jun 4, 2023, 11:19 AM

#

hidden flax yes I think

registered player still not getting dialog login, same with the unregistered player not getting dialog verifycode

hidden flax Jun 4, 2023, 11:21 AM

#

visual mango registered player still not getting dialog login, same with the unregistered pla...

show the code

visual mango Jun 4, 2023, 11:21 AM

#

visual mango ```c WRP::OnUCPLoaded(playerid, race_check) { if (race_check != g_RaceCheck[...

this

hidden flax Jun 4, 2023, 11:23 AM

#

visual mango ```c WRP::OnUCPLoaded(playerid, race_check) { if (race_check != g_RaceCheck[...

inside if rows means the player is already registered show him the login dialog not that DIALOG_VERIFYCODE

#

else
    {
        ShowPlayerDialog(playerid, DIALOG_UNUSED, DIALOG_STYLE_MSGBOX,"Account Unregistered","{FFFF00}Nama Akun ini belum terdaftar!\n{ffffff}Silahkan daftar di Official Discord kami {15D4ED}"SERVER_NAME"\n{ffffff}Link Discord: {15D4ED}","Okay","");
        KickEx(playerid);
    }```

And the code here really dont shows the verifycode dialog to the player it shows the dialog with the message and kicks the player probably that's not what you want

#

if rows
    show the login dialog
else
    show the verifycode dialog```

Probably this one is what you are looking for am I right?

visual mango Jun 4, 2023, 11:28 AM

#

WRP::OnUCPLoaded(playerid, race_check)
{
    if (race_check != g_RaceCheck[playerid])
        return KickEx(playerid);

    new rows = cache_num_rows();
    new string[352];
    if (rows)
    {
        cache_get_value_name_int(0, "id", UcpData[playerid][uID]);
        cache_get_value_name_int(0, "admin", UcpData[playerid][uAdmin]);
        cache_get_value_name(0, "verifycode", UcpData[playerid][uVerifyCode], 64);
        cache_get_value_name(0, "username", UcpData[playerid][uUsername], 64);

        format(string,sizeof(string),"{FFFFFF}Welcome back to {FF0000}"SERVER_NAME"\n\n{FFFFFF}UCP Account: {FF0000}%s\n{FFFFFF}Please input your password to login:",GetName(playerid));
        ShowPlayerDialog(playerid,DIALOG_LOGIN,DIALOG_STYLE_PASSWORD,"{FFFFFF}UCP Account Login",string,"Login","Cancel");
        
    }
    else
    {
        format(string, sizeof(string), "UCP: {15D4ED}%s\n{ffffff}Silahkan masukkan PIN yang sudah di kirimkan oleh BOT", GetName(playerid));
        ShowPlayerDialog(playerid, DIALOG_VERIFYCODE, DIALOG_STYLE_INPUT, "Verify Account", string, "Input", "Cancel");
    }
    return 1;
}

visual mango Jun 4, 2023, 11:29 AM

#

hidden flax ```c if rows show the login dialog else show the verifycode dialog``` P...

yes, edited, but still not showed

hidden flax Jun 4, 2023, 11:31 AM

#

put print statement inside if rows blocks and else blocks then check if it prints the statement to the console

#

if nothing prints probably the problem is somewhere from your code

visual mango Jun 4, 2023, 11:37 AM

#

hidden flax put print statement inside ``if rows`` blocks and ``else blocks`` then check if ...

you mean like, printf?

#

idk what should i write xd

#

printf("string: %s", string);

#

it's not printed to sampsvr

hidden flax Jun 4, 2023, 12:10 PM

#

then something's wrong in calling OnUCPLoaded

#

probably mysql error

#

check your logs it can help you solve your problems

visual mango Jun 5, 2023, 6:27 AM

#

hidden flax then something's wrong in calling OnUCPLoaded

any idea how to find the error? im new on scripting tbh

#

the logs showed nothing, im using crashdetect

hidden flax Jun 5, 2023, 6:45 AM

#

No crashdetect won't help your problem

hidden flax Jun 5, 2023, 6:46 AM

#

visual mango any idea how to find the error? im new on scripting tbh

show the code on how you call this OnUCPLoaded

visual mango Jun 5, 2023, 6:51 AM

#

hidden flax show the code on how you call this OnUCPLoaded

CheckAccount(playerid)
{
    
    new query[256];
    format(query, sizeof(query), "SELECT `username`, `verifycode` FROM `ucp` WHERE `username = '%s' LIMIT 1;", GetName(playerid));
    mysql_tquery(sqldata, query, "OnUCPLoaded", "dd", playerid, g_RaceCheck[playerid]);
    return 1;
}

hidden flax Jun 5, 2023, 6:52 AM

#

stop using this format function

visual mango Jun 5, 2023, 6:53 AM

#

visual mango ```c WRP::OnUCPLoaded(playerid, race_check) { if (race_check != g_RaceCheck[...

but it works fine before i replace this code

hidden flax Jun 5, 2023, 6:53 AM

#

change it to mysql_format

#

and dont use %s to avoid sql injection

#

use '%e' instead

#

Then to answer to your problem check your mysql logs if there are error when executing this query

visual mango Jun 5, 2023, 6:57 AM

#

hidden flax Then to answer to your problem check your mysql logs if there are error when exe...

where to check mysql log sir

#

then what's this mean

missing the connection handle

hidden flax Jun 5, 2023, 7:00 AM

#

show it here

visual mango Jun 5, 2023, 7:01 AM

#

hidden flax Jun 5, 2023, 7:05 AM

#

it means you didn't put your connection handle to the arguments before query

visual mango Jun 5, 2023, 7:08 AM

#

hidden flax it means you didn't put your connection handle to the arguments before ``query``

what's connection handle

hidden flax Jun 5, 2023, 7:09 AM

#

isn't it self explanatory?

#

its a variable to handle your mysql connection

visual mango Jun 5, 2023, 9:01 AM

#

CheckAccount(playerid)
{
    new query[256];
    mysql_format(sqldata, query, sizeof(query), "SELECT `username`, `verifycode` FROM `ucp` = '%e' LIMIT 1;", GetName(playerid));
    mysql_tquery(sqldata, query, "OnUCPLoaded", "dd", playerid, g_RaceCheck[playerid]);
    return 1;
}

#

Latest script, got no warning log, but still not showing the DIALOG_LOGIN or DIALOG_VERIFYCODE

hidden flax Jun 5, 2023, 9:03 AM

#

SELECT username, verifycode FROM ucp = '%e'

#

you did wrong here

#

The syntax is SELECT column(s) FROM table WHERE column

visual mango Jun 5, 2023, 9:05 AM

#

ah

hidden flax Jun 5, 2023, 9:05 AM

#

Do it then comeback here

visual mango Jun 5, 2023, 9:05 AM

#

CheckAccount(playerid)
{
    new query[256];
    mysql_format(sqldata, query, sizeof(query), "SELECT `username`, `verifycode` FROM `ucp` WHERE `username = '%e' LIMIT 1;", GetName(playerid));
    mysql_tquery(sqldata, query, "OnUCPLoaded", "dd", playerid, g_RaceCheck[playerid]);
    return 1;
}

hidden flax Jun 5, 2023, 9:06 AM

#

its supposed to give you an error in your logs since its not the right syntax

hidden flax Jun 5, 2023, 9:06 AM

#

visual mango ```c CheckAccount(playerid) { new query[256]; mysql_format(sqldata, quer...

yea give it a shot

visual mango Jun 5, 2023, 9:07 AM

#

hidden flax its supposed to give you an error in your logs since its not the right syntax

where to check mysql log btw

#

im using xampp

hidden flax Jun 5, 2023, 9:07 AM

#

visual mango where to check mysql log btw

in your directory find the folder named logs then find it here

hidden flax Jun 5, 2023, 9:08 AM

#

visual mango im using xampp

that's good

visual mango Jun 5, 2023, 9:17 AM

#

idk why its keep not showing up

#

the logs shows nothing abt the column, or the table that i set

#Dialog Login Didn't Showing