so that kind of just breaks your whole argument
#Guild Emojis
brisk void
@broken trellis ^
if there are already fields that can be changed at any time it wouldn’t hurt to add one more i suppose?
broken trellis
oh, so we have one thing, therefore we have to implement all other things now?
broken trellis
not quite how that works
brisk void
? lol
broken trellis
the fact that maximumBitrate in the library does not in any way change anything i said. It's still a value that can potentially change, it's still a value that is pretty much hardcoded, and it's still a value that will not change without a new release 🤷♀️
shrewd musk
The issue with this stuff is that the moment Discord updates a field due to a wonderful update, discord.js at that moment in time will be providing the incorrect returns for this data. To fix that it could be a patch... but since different return values are received, it could be a major update? If it is a major, you're probably going to be waiting a long time to wait for an update.
vs. If you create a function to do it yourself, you can update that in seconds.
That's the way I see it (and it's the danger that comes with all helpers like this)
elfin terrace
Yeah I think the concern is breaking changes here
brisk void
add a maximumEmojis field based on the premium level of the guild
eternal hollow
Given that maximumBitrate exists, it probably makes sense to have that too. also maximumStickers?
broken trellis
don't think that discord gives those values on the guild object
and while they do seem to include boost tier, we would have to have just random constants for the amounts, and then keep updating that whenever discord touches that
thorn shore
"premium_tier": 0,
"premium_subscription_count": 0,
```Discord does return these 2 propertiesyes, but like i said, these are only the boost tier
today there's x emotes on tier 1, y on 2 and z on 3, but this can easily change in the future
same way discord so far twice changed boosts needed for specific tiers
shrewd musk
Same way we added a maximum thread archive and removed it later lol too
eternal hollow
ok, then maximumBitrate should be removed too
crude maple
eternal hollow
IMO you either have both getters or none
eternal hollow
and while they do seem to include boost tier, we would have to have just random ...
And this describes the maximumBitrate getter
maiden matrix
if you really want to have workaround for that, here it is
${interaction.guild.premiumTier === 'NONE' ? '50' : (interaction.guild.premiumTier === 'TIER_1' ? '100' : (interaction.guild.premiumTier === 'TIER_2' ? '150' : '250'))}
Not sure if it's the best way possible to display it like that but works
it's fragment from my code tbh
urban forum
is it really an issue to have to keep constants for these? it's not like the values change often. sure the boosting levels changed twice but that was over a long period of time
brisk void
it’s not hard to implement it to your own code but would be easier if djs would just add it, it’s more useful then some stuff THEY (they as in djs) provide in a guild object.
broken trellis
and what happens when it gets changed by discord?
the library now provides incorrect data, and the only way to change it is to make a new release changing that. might not be that much of an issue for upcoming v14, (even though it would still potentially take days to release such change) but v13 would be in way more problematic position with such field.
if you manually set the constants, you know what the constants are, and you can change them in a matter of minutes or hours (depending on timezone, i suppose) in your code
urban forum
isn't maximumBitrate the same thing tho
broken trellis
yes