Voicechannel (solved) | discord.js - imagine an app | Page 1

queen marsh Jan 4, 2022, 12:50 PM

#

const Discord = require('discord.js');
require("@discordjs/voice")

module.exports = {
    name: 'voiceStateUpdate',
    once: true,
    execute(oldMember, newMember, client) {

        let oldVoice = oldMember.voice.channel;
        let newVoice = newMember.voice.channel;

        const joinvcEmbed = new Discord.MessageEmbed()
            .setColor('GREEN')
            .setDescription(`${newMember} tilsluttede til **${newVoice}**`)
            .setTimestamp()

        const leavevcEmbed = new Discord.MessageEmbed()
            .setColor('RED')
            .setDescription(`${oldMember} forlod **${oldVoice}**`)
            .setTimestamp()

        const movevcEmbed = new Discord.MessageEmbed()
            .setColor('ORANGE')
            .setDescription(`${newMember} flyttede fra **${oldVoice}** til **${newVoice}**`)
            .setTimestamp()

        if (oldVoice != newVoice) {
            if (oldVoice == null) {
                client.channels.get('927902267909230642').send(joinvcEmbed)
            } else if (newVoice == null) {
                client.channels.get('927902267909230642').send(leavevcEmbed)
            } else {
                client.channels.get('927902267909230642').send(movevcEmbed)
            }
        }

    }
}

#

My event handler looks like this: ```js
module.exports = (client) => {
client.handleEvents = async (eventFiles) => {
for (const file of eventFiles) {
const event = require(../events/${file});
if (event.once) {
client.once(event.name, (...args) => event.execute(...args, client));
} else {
client.on(event.name, (...args) => event.execute(...args, client));
}
}
};
}

zealous shuttle Jan 4, 2022, 12:51 PM

#

okay. so

amber flint Jan 4, 2022, 12:51 PM

#

Hmm

wide sorrel Jan 4, 2022, 12:52 PM

#

const gud = client.guilds.fetch('CHANNEL_ID_HERE')

zealous shuttle Jan 4, 2022, 12:52 PM

#

the behaviour of your event is handled by previous joined channel (which is fired after leaving) and the channel joined

wide sorrel Jan 4, 2022, 12:52 PM

#

fetch instead of cache.get

zealous shuttle Jan 4, 2022, 12:52 PM

#

i can rewrite it a bit for you in accordance to my statement

queen marsh Jan 4, 2022, 12:53 PM

#

Aha

zealous shuttle Jan 4, 2022, 12:53 PM

#

oldMember and newMember are going to be undefined to which event is fired

#

u can't join and leave a channel at the same time (sadly). so one of these events are going to be undefined

queen marsh Jan 4, 2022, 12:54 PM

#

Can I do ifs to check if they exist then?

zealous shuttle Jan 4, 2022, 12:54 PM

#

also. call these event args oldState and newState

#

less confusing hehe

queen marsh Jan 4, 2022, 12:55 PM

#

oldMember > oldState ?

zealous shuttle Jan 4, 2022, 12:55 PM

#

nono

#

const Discord = require('discord.js');
require("@discordjs/voice")

module.exports = {
    name: 'voiceStateUpdate',

    execute(client, oldState, newState) {
        if (newState) {
            // boop biep i fire when someone joins a vc
        }

        if (oldState) {
            // no
        }
    }
}

queen marsh Jan 4, 2022, 12:56 PM

#

zealous shuttle `oldMember` and `newMember` are going to be undefined to which event is fired

Can I do this then ```js
let oldVoice;
let newVoice;
if (oldMember) {
oldVoice = oldMember.voice.channel;
}
if (newMember) {
newVoice = newMember.voice.channel;
}

zealous shuttle Jan 4, 2022, 12:57 PM

#

basically. but i suggest not hoisting these values

#

let oldStateVC = oldState.voice.channel

#

inside of your if (oldState) {

#

u have to verify if they're falsey or not

#

omg istg

queen marsh Jan 4, 2022, 1:00 PM

#

Okay you want my code to look like this right ```js
const Discord = require('discord.js');
require("@discordjs/voice")

module.exports = {
name: 'voiceStateUpdate',
once: true,
execute(client, oldState, newState) {

    if (newState) {
        let newStateVC = newState.voice.channel
    }
    if (oldState) {
        let oldStateVC = oldState.voice.channel
    }

    const joinvcEmbed = new Discord.MessageEmbed()
        .setColor('GREEN')
        .setDescription(`${newMember} tilsluttede til **${newVoice}**`)
        .setTimestamp()

    const leavevcEmbed = new Discord.MessageEmbed()
        .setColor('RED')
        .setDescription(`${oldMember} forlod **${oldVoice}**`)
        .setTimestamp()

    const movevcEmbed = new Discord.MessageEmbed()
        .setColor('ORANGE')
        .setDescription(`${newMember} flyttede fra **${oldVoice}** til **${newVoice}**`)
        .setTimestamp()

    if (oldVoice != newVoice) {
        if (oldVoice == null) {
            client.channels.get('927902267909230642').send(joinvcEmbed)
        } else if (newVoice == null) {
            client.channels.get('927902267909230642').send(leavevcEmbed)
        } else {
            client.channels.get('927902267909230642').send(movevcEmbed)
        }
    }

}

}

zealous shuttle Jan 4, 2022, 1:00 PM

#

OKAY. WAIT

#

STAY HERE. DON'T MOVE

queen marsh Jan 4, 2022, 1:00 PM

#

I'm not moving

zealous shuttle Jan 4, 2022, 1:00 PM

#

I WILL BITE

queen marsh Jan 4, 2022, 1:03 PM

#

Hmm?

#

I'm gonna cramp soon if I don't move soon

zealous shuttle Jan 4, 2022, 1:06 PM

#

I KNOW

#

const Discord = require('discord.js');
require("@discordjs/voice");

module.exports = {
    name: 'voiceStateUpdate',
    once: true,

    execute(client, oldState, newState) {
        const logChannel = "805224882240749609";

        if (oldState.channel) {
            const leave = new Discord.MessageEmbed()
                .setColor('RED')
                .setDescription(`${oldState.member.user.tag} forlod **${oldState.channel}**`)
                .setTimestamp();

            oldState.guild.channels.cache.get(logChannel).send({ embeds: [leave] });

            return;
        }

        if (newState.channel) {
            const join = new Discord.MessageEmbed()
                .setColor('GREEN')
                .setDescription(`${newState.member.user.tag} tilsluttede til **${newState.channel}**`)
                .setTimestamp();

            newState.guild.channels.cache.get(logChannel).send({ embeds: [join] });

            return;
        }

        if (oldState.channel && newState.channel) {
            const move = new Discord.MessageEmbed()
                .setColor('ORANGE')
                .setDescription(`${newState.member.user.tag} flyttede fra **${oldState.channel}** til **${newState.channel}**`)
                .setTimestamp();

            newState.guild.channels.cache.get(logChannel).send({ embeds: [move] });
        }
    }
};

#

there u go. i'm going to go back to bed

#

🎉

queen marsh Jan 4, 2022, 1:14 PM

#

zealous shuttle ```js const Discord = require('discord.js'); require("@discordjs/voice"); modul...

It says TypeError: Cannot read properties of undefined (reading 'send') on this line ```js
oldState.guild.channels.cache.get(logChannel).send({ embeds: [leave] });

zealous shuttle Jan 4, 2022, 1:14 PM

#

because logChannel should be the channel u have to set it as

#

const logChannel = "805224882240749609"; this is a random channel id. change it :)

queen marsh Jan 4, 2022, 1:15 PM

#

OIh

zealous shuttle Jan 4, 2022, 1:15 PM

#

dummy

queen marsh Jan 4, 2022, 1:15 PM

#

Yee, whoops

zealous shuttle Jan 4, 2022, 1:15 PM

#

there u go!!

#

u should be good

queen marsh Jan 4, 2022, 1:16 PM

#

No actually you should have told me about that, that's your fault ahah

zealous shuttle Jan 4, 2022, 1:16 PM

#

smhh neverrr

#

OKAY THREAD CLOSE MODERATORS

#

THANK U FOR UR ATTENDANCE

queen marsh Jan 4, 2022, 1:16 PM

#

No not yet xd

zealous shuttle Jan 4, 2022, 1:16 PM

#

oh?

#

👀

queen marsh Jan 4, 2022, 1:17 PM

#

There's still a minor problem... When I join a voice channel it sends the leave embed and it sends nothing when I leave

zealous shuttle Jan 4, 2022, 1:17 PM

#

what..

queen marsh Jan 4, 2022, 1:18 PM

#

Mhm, I'm confused aswell

zealous shuttle Jan 4, 2022, 1:18 PM

#

can u check dms?

queen marsh Jan 4, 2022, 1:18 PM

#

Sure

#Voicechannel (solved)