thread archive timestamp | discord.js - imagine an app | Page 1

flat carbon Jan 2, 2022, 10:19 AM

#

huh, interesting, i thought... let me see real quick

toxic cargo Jan 2, 2022, 10:20 AM

#

https://discord.js.org/#/docs/main/stable/class/ThreadChannel?scrollTo=archiveTimestamp

Discord.js

Discord.js is a powerful node.js module that allows you to interact with the Discord API very easily. It takes a much more object-oriented approach than most other JS Discord libraries, making your bot's code significantly tidier and easier to comprehend.

#

flat carbon Jan 2, 2022, 10:23 AM

#

hm, i do wonder how that comes to be
we get the creation timestamp from the ID the channel is made with on discords end

#

the archive timestamp is from the API

whole furnace Jan 2, 2022, 10:23 AM

#

{
  id: '927142702292828170',
  guild_id: '222078108977594368',
  parent_id: '824411059443204127',
  owner_id: '83886770768314368',
  type: 11,
  name: 'thread archive timestamp',
  last_message_id: '927145147370713098',
  thread_metadata: [Object],
  message_count: 7,
  member_count: 3,
  rate_limit_per_user: 0
}
```• d.js 13.4.0 • Type: `object` • time taken: `186.756752ms`

#

{
  archived: false,
  archive_timestamp: '2022-01-02T10:19:24.883000+00:00',
  auto_archive_duration: 60,
  locked: false
}
```• d.js 13.4.0 • Type: `object` • time taken: `146.436063ms`

#

2022-01-02T10:14:05.705Z
```• d.js 13.4.0 • Type: `object` • time taken: `0.141826ms`

flat carbon Jan 2, 2022, 10:26 AM

#

that is indeed not exactly the creation timestamp, curious

#

well, seeing that it's the case with raw API data I don't really see how we could do it any different @toxic cargo

flat carbon Jan 2, 2022, 10:27 AM

#

whole furnace ```js 2022-01-02T10:14:05.705Z ```• d.js 13.4.0 • Type: `object` • time taken: `...

this is the timestamp from the snowflake of the channel id

toxic cargo Jan 2, 2022, 10:27 AM

#

I want to check if a thread has been archived before.

#

Where can i report this error in the docs?

flat carbon Jan 2, 2022, 10:29 AM

#

ah, i know why

#

if you start a thread on a message it will share it's id with said message

#

since i started this thread on a message you sent :14 the thread's creation (via our lib) will be at :14
where it really was created at :19 hence the archive timestamp being that

toxic cargo Jan 2, 2022, 10:30 AM

#

Oh.

flat carbon Jan 2, 2022, 10:31 AM

#

whole furnace ```js { id: '927142702292828170', guild_id: '222078108977594368', parent_i...

since this is the raw API data i don't see how we could get the true thread creation time shibaThinking

toxic cargo Jan 2, 2022, 10:31 AM

#

My threads arent created on any message tho.

#

Still shows another value.

flat carbon Jan 2, 2022, 10:33 AM

#

yup, less of a discrepancy, but there is one nonetheless

#

@green raven you implemented* threads, right? any idea what's going on here?
only idea i have atm is that the snowflake is generated before the thread is, and archive_timestamp is set to now() rather than the snowflake by discord?

green raven Jan 2, 2022, 10:37 AM

#

try it with a private thread, my guess is it should be identical then

#

since public threads send a message first

#

if one doesn't exist

#

I thought archive_timestamp wasn't supposed to be set on create though (null)

flat carbon Jan 2, 2022, 10:39 AM

#

flat carbon Jan 2, 2022, 10:40 AM

#

green raven I thought archive_timestamp wasn't supposed to be set on create though (null)

thought that too, yet there is even an info box on our docs that details it to be creation if the status never changed

flat carbon Jan 2, 2022, 10:40 AM

#

flat carbon

private thread, still not quite

green raven Jan 2, 2022, 10:41 AM

#

guess it utilizes a similar code path but just doesn't send the message

flat carbon Jan 2, 2022, 10:41 AM

#

i think the conclusion is still "no can do" then

green raven Jan 2, 2022, 10:42 AM

#

yeah, this is on discords end

flat carbon Jan 2, 2022, 10:43 AM

#

@toxic cargo thanks, that's a curious one, but we can't do anything to help you with determining if a thread has been archived prior
the best i can think of is a magic number margin at which you assume it's the same
(though true thread creation in case it was started on a message is also not available)

green raven Jan 2, 2022, 10:43 AM

#

(i might poke AJ to send it as null on create when Discord is back from break)

flat carbon Jan 2, 2022, 10:44 AM

#

and maybe send the actual creation timestamp, while you're at it
because for "created on messages" threads that's really a bit yuck

green raven Jan 2, 2022, 10:44 AM

#

...yeah

flat carbon Jan 2, 2022, 10:45 AM

#

we're currently suggesting wrong information there for thread creation times
because it's really the messages creation

green raven Jan 2, 2022, 10:45 AM

#

this isn't nullable in the docs but the description suggests it is dead

#

because the archive status was never changed

toxic cargo Jan 2, 2022, 10:45 AM

#

I will try to see if they timestambs are always the same number geater then the other one.

flat carbon Jan 2, 2022, 10:46 AM

#

presumably not, but i think a margin would make sense

#

though that's also not available if created on a message, because the message was obv. created way before

#

@green raven https://discord.js.org/#/docs/main/stable/class/ThreadChannel?scrollTo=createdAt and *Timestamp prob. need a disclaimer for that, don't you think?

green raven Jan 2, 2022, 10:49 AM

#

that's inherited from channel

flat carbon Jan 2, 2022, 10:49 AM

#

ah shit, so we can't even document that behaviour

green raven Jan 2, 2022, 10:49 AM

#

its also documented wrong on the api docs

flat carbon Jan 2, 2022, 10:49 AM

#

green raven Jan 2, 2022, 10:50 AM

#

we can override jsdoc with virtual jsdoc for our docs

flat carbon Jan 2, 2022, 10:50 AM

#

"If the channel is a thread channel created on a message this will reflect the creation of the message the thread was created on instead" moment

toxic cargo Jan 2, 2022, 10:50 AM

#

toxic cargo I will try to see if they timestambs are always the same number geater then the ...

They arent.

green raven Jan 2, 2022, 10:51 AM

#

flat carbon "If the channel is a thread channel created on a message this will reflect the c...

sec, I can test doc things very fast

flat carbon Jan 2, 2022, 10:51 AM

#

no need to hurry, but this is def. something we should somehow address

#

(and prob. something discord should look into as well, if they can. because ohboi is it confusing)

#

no idea why they didn't just send null to begin with...

a timestamp that reflects when XYZ was last changed
not null if never changed

like.. what even

#

at least we documented it as nullable, so IF they change we don't need to wait for a major release

green raven Jan 2, 2022, 10:56 AM

#

#

virtual jsdoc ftw, no code changes

flat carbon Jan 2, 2022, 10:57 AM

#

"can be"? is that also not a guarantee?

green raven Jan 2, 2022, 10:57 AM

#

well idk

toxic cargo Jan 2, 2022, 10:57 AM

#

You can create a thread with a starter message and not on a message.

green raven Jan 2, 2022, 10:57 AM

#

if the message is old enough it sends a new one to create the thread on

flat carbon Jan 2, 2022, 10:57 AM

#

o_O what

green raven Jan 2, 2022, 10:58 AM

#

#

lets se

#

this is an old message, wonder what the timestamp says

flat carbon Jan 2, 2022, 10:59 AM

#

#

third message in #app-commands kek

green raven Jan 2, 2022, 11:01 AM

#

well...Souji, here's the problem

#

discord doesn't generate that timestamp

flat carbon Jan 2, 2022, 11:02 AM

#

am aware, we get it from the snowflake

#

but discord doesn't send ANY timestamp either

green raven Jan 2, 2022, 11:02 AM

#

yeah

flat carbon Jan 2, 2022, 11:02 AM

#

yet they send the archived thing, which is something close to creation if it wasn't changed ever
which is still not the one they created the snowflake with

#

presumably because the snowflake creation is external code to the thread creation

#

and thread creation uses now() in some manner

green raven Jan 2, 2022, 11:03 AM

#

snowflake generation happens in isolated processes I believe (how they get their guaranteed unique structure)

flat carbon Jan 2, 2022, 11:03 AM

#

ye, that's what i meant to imply with "external code"

#

which also means that, once archive status has been changed once, there is no time to get the creation time
(even with that approximation)

green raven Jan 2, 2022, 11:04 AM

#

yeah, so...technically we just shouldn't have created* on threads it seems mmLol

flat carbon Jan 2, 2022, 11:04 AM

#

that is what i'm starting to think

green raven Jan 2, 2022, 11:07 AM

#

The only thing that we could maybe do is utilize the archive timestamp to fake created somehow, but that seems overly complex

flat carbon Jan 2, 2022, 11:08 AM

#

or for discord to just send a timestamp instead of having us deconstruct snowflakes

and then suddenly making a feature where that just doesn't hold true anymore

green raven Jan 2, 2022, 11:08 AM

#

mmLol

flat carbon Jan 2, 2022, 11:09 AM

#

the more this situation unfolded the more i realized how scuffed threads are implementation wise, in regards to the previous API

#

also opened a window into the assumptions we base our lib on, because that's the only choice we have

now if those assumptions don't hold true anymore... well.

green raven Jan 2, 2022, 11:12 AM

#

well, AJ isn't on the API team, so this is client-first but cater to bot devs, kinda like timeouts...where we get no event on expiry so we're still tracking it manually dead It's these little things that make you realize the teams don't collaborate as much as you would hope

flat carbon Jan 2, 2022, 11:13 AM

#

nkoSigh

#

anyways, i'm out
if you wanna bring this up in #archive-internal-lib-discussions do feel free (re: removal/documentation)
maybe something for v14 to consider, though i'm not sure how that works either, looking at the inheritance structure
unless "implements ChannelThatHasCreation" or some scuffed shit like that

green raven Jan 2, 2022, 11:15 AM

#

I really want to redo channel hiearchy at some point, because thread channel really wants to inherit from guild channel....it just doesn't share most of its properties, I smell more interfaces and I don't like that

flat carbon Jan 2, 2022, 11:16 AM

#

y...yeah. it's all a bit of a mess

#

thanks for jumping in on short notice shibaHeart

#thread archive timestamp