#Partial Messages for typescript — Page 1

earnest sigil Aug 11, 2021, 12:06 AM

Hi, i was wondering if it would be a good idea to change the <message>.partial property to a method <message>.isPartial() instead.
The reason for this is that as a typescript user, there seems to be no short way to identify a message as being partial. The only way i've found is with a double check instead of a single check since (message instanceof Message) will return true even if it's Partial. So i had to use if (message.partial && (message instanceof Message))

I can do a PR for it but needed to get some opinions on this.

I'm not an expert dev so maybe i tried the wrong way but i couldn't find a way to make public readonly partial: false; return this is PartialMessage at the same time. I Think it's only possible through public isPartial(): this is PartialMessage

Correct me if i'm wrong on anything!!

Made my first PR yesterday and looking to make more in the future when i'm able too 😛

dawn lichen Aug 11, 2021, 12:21 AM

Feel free to make a PR for it and let the other devs roll over it

And yes, you can only have type guards with methods, not getters or properties

earnest sigil Aug 11, 2021, 12:22 AM

Alright, thank you!!

spare bluff Aug 11, 2021, 10:26 AM

Actually it's a property because it's always false in a Message object. This is so in events where the message passed can be partial it's typed as Message | PartialMessage, where PartialMessage has a partial property of always false

So you can use if (message.partial) actually

earnest sigil Aug 11, 2021, 10:27 AM

spare bluff So you can use `if (message.partial)` actually

Finally, someone showed me that this works. Probably that i did something wrong when i made my tests. PR has been closed.

spare bluff Aug 11, 2021, 10:28 AM

👍