#Adding ComponentsV2 to the d.js guide

69 messages · Page 1 of 1 (latest)

terse moss
floral cradle
#

"Other Interactions" isn't affected by Components v2 at all. And "Message Components" currently also only talks about interactive components, which mostly are unaffected in how they work too.
So I'd rather say that Components v2 should be a topic under "Popular Topics" similar to how "Embeds" are currently. Not restructure all of the existing interaction focused guide pages

#

The page about Buttons would then need a bit about how they also can appear as accessories in sections with a link to that Popular Topic page

terse moss
#

Oh yeah I see that too now, indeed better to make a page under "Popular Topics" and on those pages of actions rows, buttons, etc having a link somewhere to the components v2 page

#

With "affected by CV2", I meant that the API docs now refers to all of them as components, while the section "Modals" belong to on the d.js guide is called "Other Interactions"

so that's why I suggested to rearrange them, but this would be a more efficient way to do

floral cradle
#

well, modals still cause ModalSubmitInteractions. and commands still aren't components. so I don't see what changes regarding modals would justify that restructure

#

TextInput always was called a component and always resided in an actionrow

terse moss
#

Either way, I will start writing the Components V2 page under the "Popular Topics" section and will make a PR soon too

terse moss
#

@discord-message-components/vue doesn't support the new components v2 yet (obviously), so for cv2 previews I think we have to stick to images instead (I don't think its allowed to use the images from the API docs)

distant grail
#

I believe the guide already uses its own examples for other stuff with djs images either way

floral cradle
terse moss
#

I have been busy quite some time so I havent finished it yet, but got quite far already

#

I think I can finish it this evening and will create a PR when done with the page (someone else has to check if its working properly because of the issue I mentioned before)

floral cradle
#

would be helpful if you opened it as draft PR already, so others could see the progress and maybe comment on it

terse moss
#

will do as soon as I’m back home

terse moss
tired horizon
terse moss
floral cradle
terse moss
distant grail
#

I feel it'd be nice if we could have previews

#

also I'm not sure if you can send a single separator

#

it'd surely look weird so I don't think discord would've allowed that

terse moss
#

it wasn't mentioned in the api docs so shrug

terse moss
distant grail
#

an image should be good enough imo

terse moss
#

alr will do that later

#

imma go sleep now (01:06am)

distant grail
#

gn blobreach, ty for the work

terse moss
#

ty

vivid sky
#

I have three comments but I was on sure if it should be commended on the PR.

  1. "content component" is used several times should that be labeled as "message component" as not to be confused with the content message filed
  2. I think the thumbnail component should come after the section component.
  3. The limitations section feels talked on to the end. I think edit/update should be its own section and the component limit should be in the overview
#

I think you did a great job 👍 cant wait to direct peopel to this page

terse moss
vivid sky
#

To elaborate on point 3 it feels just tacked on to the end. It is really two things
The section feels like is is just thrown at the end. And some information should like the component limit should be in an annotations in the first block of text explaining cv2
And second updating message to cv2 should be its own section

terse moss
#

but I understand your way of thinking too

vivid sky
#

I still think having the limitations called out is important but I think using a warning or danger annotation in context would be more useful than having them at the bottom of the page

terse moss
#

could state it twice on the page but idk what the d.js maintainers think abt that

vivid sky
#

Ya, I will defer to you and them. That was just my thoughts

terse moss
#

oh I will look at the review of monbrey in a sec, didnt see that notification ig

#

and how do you guys want the images

#

do you want me to make screenshots of a d.js webhook sending those messages or

astral remnant
#

That's probably the easiest way yeah

terse moss
#

alr did a commit with edits on all suggested stuff, now I think the only thing left to do is creating screenshots

#

will do that somewhat later today ig

#

do I need them to be added/uploaded within the repo or do I need to host the images somewhere else?

#

like this is the example image I want to use under the text display component code snippet

image.png
#

oh I see I forgot to remove the “new” from those too haha, will fix that soon as well

karmic marlin
terse moss
#

alr

stark latch
#

.

distant grail
stark latch
distant grail
#

you could also just right click on the thread and click on "Follow post"

stark latch
teal flax
#

AI
yeah, makes sense

floral cradle
terse moss
#

why is it failing lol

image.png
#

i cannot see the details/logs of the checks either as im unauthorized

#

ah looks like it only allows one uppercase letter in the image alt text

vivid sky
#

Just had a thought should their be an additional section to editing cv2 to show how to use <ContainerBuilder>#spliceComponents / <SectionBuilder>#spliceTextDisplayComponents / <MediaGalleryBuilder>#spliceItems
maybe it is not wort hit but I had the thought

karmic marlin
#

That behaves similarly to <Array>.splice, not much to explain there. One should already know that. Instead of modifying the element in an array, you are modifying components/items or whatever it is for here

vast pebble
terse moss
heady cobalt
#

a

distant grail
terse moss
#

Alright I pushed the in what looks to me the final commit (tiny spelling fix at "Container" section, added file component preview image and fixed the eslint warnings)

terse moss
#

This branch has been merged to the main branch of the guide