web support for @discordjs/collection

[zenith tusk]

You can't use a bundler like vite?

[icy sierra]

What about /collection isn’t web compatible?

[vestal tide]

personally, i have a /vendor folder for all third-party dependencies

[vestal tide]

developed on the node environment, not directly for web, we need to compile it

that's why i propose a .min.js on a cdn

[zenith tusk]

Out of curiousity what's a use case?

[icy sierra]

That’s not how that works. /collection is web compatible since it doesn’t rely on any node specific code

[vestal tide]

it's how that's work

web doesnt allow directly ts

we need to compile it

[icy sierra]

Yes and it ships the compiled js when installed

[zenith tusk]

https://cdn.jsdelivr.net/gh/discordjs/discord.js/packages/collection/src/index.ts

[vestal tide]

installed with node, npm

[icy sierra]

even if it didn’t it’s not the responsibility of the package maintainer but the web bundler

[vestal tide]

yes it's great but still in ts

i just a request a cdn js

[zenith tusk]

I wonder if there just is a cdn that compiles ts

[vestal tide]

i talked about github action

anyways it's not NEEDED but would be practical, i will do a pull request and i will see

[errant turtle]

wouldn't it be better to use the compiled version from npm? since that is js

[zenith tusk]

I still don't understand why you don't just use a bundler

[vestal tide]

because all my scripts are imported by script tags

[icy sierra]

There is no need for a pull request, as already stated the package is web compatible. I have used it in web environments and it works

[vestal tide]

no, you compiled it

what i ask is a precompilation

[icy sierra]

It comes compiled

[vestal tide]

like all other frameworks

[errant turtle]

so use the compiled version from npm, that's what is installed in nodejs anyway since it doesn't run ts directly either
https://cdn.jsdelivr.net/npm/@discordjs/[email protected]/dist/index.min.js

[icy sierra]

The package ships the compiled js

[vestal tide]

thanks

it's what i asked

i didn't know it was done

[icy sierra]

#1133153198132183130 message

[vestal tide]

subject resolved

[vestal tide]

yes but it wasn't on the github and i didnt find the jsdelivr one, pretty hidden

[icy sierra]

It’s not on the GitHub bc packages aren’t supposed to host build artifacts in source control

[vestal tide]

yes, i checked releases