Cannot rest.put my application guild commands? | discord.js - imagine an app | Page 1

eternal solar Mar 3, 2023, 1:46 AM

#

I am trying to deploy my bot commands when I'm getting the Invalid Form Body error?

// Send the commands to the specified guild to be deployed
        console.log(cmdsData);
        rest.put(
            Routes.applicationGuildCommands(
                process.env.CLIENT_ACTIVE_ID as string,
                process.env.GUILD_ACTIVE_ID as string
            ),
            { body: cmdsData }
        ).then(() => {
            UtilHelpers.success("Successfully deployed commands.");
        }).catch((err: any) => {
            UtilHelpers.error(err);
            reject(new Error("Unable to deploy commands."));
        });

The cmdsData is an array of the RESTPostAPIApplicationGuildCommandsJSONBody type

This is what I push to the cmdsData array

function RollOutCommand(cmdsData: RESTPostAPIApplicationGuildCommandsJSONBody[], cmd: Command) {
    try {
        cmdsData.push(cmd.data.toJSON());
        UtilHelpers.success(`Successfully rolled-out command with name: '${cmd.data.name}'`);
    } catch (reason: any) {
        UtilHelpers.error(reason);
        UtilHelpers.error(`Unable to deploy command with name: '${cmd.data.name}' as the command data is invalid.`);
    }
}

My example command

import { Client, SlashCommandBuilder, CommandInteraction } from "discord.js";
import { Command } from "../Interfaces/Command";

module.exports = {
    data: new SlashCommandBuilder()
    .setName("test")
    .setDescription("This is a test command which is used for testing the first command"),
    execute: async (interaction: CommandInteraction) => {
        await interaction.reply("Test command recieved!");
    }
};

#

The output I'm receiving

[ERROR]: Invalid Form Body
0.name[BASE_TYPE_REQUIRED]: This field is required
 DiscordAPIError[50035]: [ERROR]: Invalid Form Body
0.name[BASE_TYPE_REQUIRED]: This field is required
    at SequentialHandler.runRequest (E:\MyDev\_Projects\Discord\dscrd-TheDirector\node_modules\@discordjs\rest\dist\index.js:667:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async SequentialHandler.queueRequest (E:\MyDev\_Projects\Discord\dscrd-TheDirector\node_modules\@discordjs\rest\dist\index.js:464:14)
    at async REST.request (E:\MyDev\_Projects\Discord\dscrd-TheDirector\node_modules\@discordjs\rest\dist\index.js:910:22) {
  requestBody: { files: undefined, json: [ <1 empty item>, [Object] ] },
  rawError: {
    code: 50035,
    errors: { '0': [Object] },
    message: 'Invalid Form Body'
  },
  code: 50035,
  status: 400,
  method: 'PUT',
  url: 'https://discord.com/api/v10/applications/redacted/guilds/redacted/commands'
}

#

When I log the cmdsData this is what I get

[
  <1 empty item>,
  {
    options: [],
    name: 'test',
    name_localizations: undefined,
    description: 'This is a test command which is used for testing the first command',
    description_localizations: undefined,
    default_permission: undefined,
    default_member_permissions: undefined,
    dm_permission: undefined
  }
]

teal hawk Mar 3, 2023, 1:48 AM

#

eternal solar When I log the cmdsData this is what I get ``` [ <1 empty item>, { optio...

You have an undefined hole as the first item of the array you see

eternal solar Mar 3, 2023, 1:48 AM

#

Yeah I couldn't figure out where it was coming from

teal hawk Mar 3, 2023, 1:49 AM

#

If you use delete, or some function which leaves undefined holes it'll cause problem,
Instead use splice

eternal solar Mar 3, 2023, 1:49 AM

#

const cmdsData: RESTPostAPIApplicationGuildCommandsJSONBody[] = [];
        cmdsData.length = cmdsToDeploy.length;

        // Check if the first element of cmdsToDeploy is a wildcard '*'
        if (cmdsToDeploy[0] === "*") {
            // Load all commands
            UtilHelpers.log("Deploying all commands...\n");
            for (const cmd of CommandsList.values()) { RollOutCommand(cmdsData,cmd); }
        } else {
            // Verify the cmd data
            for (const cmdName of cmdsToDeploy) {
                // Try getting the command from the CommandList
                const cmd: Command | undefined = CommandsList.get(cmdName);
                if (cmd === undefined) {
                    UtilHelpers.log(`Command '${cmdName}' unable to be deployed, it is missing from the list of commands.`);
                    continue;
                }
                RollOutCommand(cmdsData,cmd);
            }
        }

I just create it here and start the process

teal hawk Mar 3, 2023, 1:50 AM

#

Could you stop spamming all of your codes

eternal solar Mar 3, 2023, 1:50 AM

#

Well I'm sending them so everyone can be aware of the context

#

if I'm missing code

teal hawk Mar 3, 2023, 1:50 AM

#

teal hawk If you use `delete`, or some function which leaves undefined holes it'll cause p...

Fix you handler and stuff and improve it,
We can clearly see there's an undefined hole at the first element of the array

eternal solar Mar 3, 2023, 1:51 AM

#

and I don't know exactly where the problem lies. I will try figuring out where the undefined is coming from.

teal hawk Mar 3, 2023, 1:51 AM

#

Check your command files properly

teal hawk Mar 3, 2023, 1:52 AM

#

eternal solar ```ts const cmdsData: RESTPostAPIApplicationGuildCommandsJSONBody[] = []; ...

You're using continue after getting a command which is undefined but why?
Use return

eternal solar Mar 3, 2023, 1:53 AM

#

I just started doing this you don't gonna be like that

teal hawk Mar 3, 2023, 1:53 AM

#

A fucked up cmd handler very bad logic

#

No

#

Delete it

frigid frost Mar 3, 2023, 1:53 AM

#

please don't spoonfeed code

teal hawk Mar 3, 2023, 1:53 AM

#

No spoonfeed

#

Delete

#

noSpoons kappapuff

#

I told what the error is, now it's upto them to fix it, they continue after getting the error instead of returning and it errors when putting the commands

eternal solar Mar 3, 2023, 1:55 AM

#

I'm continuing so that if one command did error I still wanted to deploy my other ones

#

it was the only reason

#

also you don't have to think everyone asking for help wants to be spoonfed

#

I have his code already copied just as a point but I still want to fix mine

#

that's not my point anyway

#

I do want to fix mine but I just regret asking tbh the way you guys went at me

teal hawk Mar 3, 2023, 1:59 AM

#

eternal solar I'm continuing so that if one command did error I still wanted to deploy my othe...

Then remove the undefined element, you're continuing with the undefined hole in your array which causes the error

eternal solar Mar 3, 2023, 2:00 AM

#

continue should go to the next iteration of the loop correct? Unless your saying it's different in js for some reason

#

All I'm trying to say is that if the cmd is undefined I never add it to the cmdsData

#

It gets added to cmdsData in RollOutCommand

#

also

if (cmd === undefined) {
                    UtilHelpers.log(`Command '${cmdName}' unable to be deployed, it is missing from the list of commands.`);
                    continue;
                }

That isn't even entering scope since I am not receiving Command '${cmdName}' unable to be deployed, it is missing from the list of commands. in my output.

teal hawk Mar 3, 2023, 2:11 AM

#

Show your first file of your commands

#

What's that logic?? ```js
if (firstCommand === "*") {
//You're deploying all the commands including the undefined ones
}

#

Improve your logic

eternal solar Mar 3, 2023, 2:13 AM

#

well no because that would deploy all the commands in my commands list

#

which is what loads the command files

#

and stores them with their names

#

const CommandsList: Collection<string,Command> = new Collection();

#

So with that it loops through the values in the collection and rolls out those commands

#

but I'm not deploying with an asterisk

#

only 'test' right now

teal hawk Mar 3, 2023, 2:15 AM

#

I didn't say you're deploying your asterisk OMEGAlul
You're deploying all of your commands including the undefined ones

eternal solar Mar 3, 2023, 2:16 AM

#

Ok the thing is, is that I've only shown code relevant to my issue with my current conditions

npm run start -- -develop -- -deploy-commands=test

#

That's what I mean when I say I'm not deploying with an asterisk

#

meaning only this block of code is running

else {
            // Verify the cmd data
            for (const cmdName of cmdsToDeploy) {
                // Try getting the command from the CommandList
                const cmd: Command | undefined = CommandsList.get(cmdName);
                if (cmd === undefined) {
                    UtilHelpers.log(`Command '${cmdName}' unable to be deployed, it is missing from the list of commands.`);
                    continue;
                }
                RollOutCommand(cmdsData,cmd);
            }
        }

#

the first element in that loop should be 'test'

#

which it would find in my command list otherwise I would get the log

#

then it goes on to RollOutCommand

#

which just pushes the cmd.data.toJSON to the cmdsData array

teal hawk Mar 3, 2023, 2:18 AM

#

Why are you making your handler so complex OMEGAlul
Just create a simple and clean handler

eternal solar Mar 3, 2023, 2:19 AM

#

I can respectfully consider that but I don't see this as complex I'm just having troubles with the undefined in the array

#

but as of now if I went and removed everything I had I would of wasted a bunch of time

#

while this way allows me when I run my bot to deploy certain commands of choice or even all if needed

#

because I have experimental commands which I only want to deploy when I'm ready to use them

#

to test them before use

#

I guess using would fall under normal deployment

#

Plus later I want to make something that will track when they were last deployed so I'm only deploying commands that need to be and I will base that time around the modified date on the command files

#

I'm not saying I won't modify and improve this code later but all the code I provided is still part of testing you know like you guys criticized and joked about me starting my first bot all these things I learn as I do

#

no one just knows how to write perfect code and handlers until you've done it.

eternal solar Mar 3, 2023, 4:23 AM

#

My problem all along was since I pre-allocated the array length push was being placed after the undefined

cmdsData.push(cmd.data.toJSON());

#

nothing was wrong with handler or the logic just a miss understanding of the push method.

#

You guys were the worst I won't ask for help here again my mistake.

#

part of the problem arose from the undefined so Shadow gets a point

#Cannot rest.put my application guild commands?