New select menus

[gusty osprey]

Is anyone already working on adding https://github.com/discordjs/discord-api-types/pull/602 to d.js or can I do this?

[coral prawn]

I think u can do it

and just make draft pr btw to don't confuse others

[gusty osprey]

yea i just dont want to do it if anyone else has already started

[coral prawn]

probably not
but maybe

[coral prawn]

so are u doing it?
https://github.com/jaw0r3k/discord.js/commit/c31cb23d984676d0f11f4a1515eac49b7d332b1c if u need some idea

[gusty osprey]

Oh so you're doing it now?

[coral prawn]

idk handling it will be diffucult

maybe mutual contribution?

@gusty osprey?

[split swan]

@coral prawn I have a question

Have you implemented everything?

[split swan]

and how can i install it?

[coral prawn]

most of things yes

but better ask RedGuy

[gusty osprey]

I believe we just need manual, functionality, and typing tests

[split swan]

Oh okay

[coral prawn]

yeah typings

[barren palm]

can i help with typing tests somehow?

[coral prawn]

idk

[gusty osprey]

uh sure if you want ig

[barren palm]

i mean yeah i do want but my question was in which way i could help 😅

[crimson berry]

Reviewing, proposing ideias (good ones), talk to Maintainers of the branch to allow you to PR/commit stuff

[crimson berry]

But a better way would be to look for issues without a PR tied to them and try to solve/implement the issue

[split swan]

Any progress?

[cosmic belfry]

#8775 in discordjs/discord.js by jaw0r3k opened <t:1666362502:R> (review required)
New select menus

[lunar ledge]

Is this being backported to v13?

[coral prawn]

maybe it can

idk

[kind pumice]

This can't be even in v14 due to breaking changes

[gusty osprey]

what

[kind pumice]

You have removed the SelectMenuBuilder class

[kind pumice]

Also <Interaction>.isSelectMenu() now returns true not only for string select menus

[gusty osprey]

that isn't breaking...

[kind pumice]

Users expect it to be true only for a string select menu in v14

[gusty osprey]

hm

[coral prawn]

dont think

also isContextMenu exists with the same idea

[kind pumice]

It was only for string select menu so users expect it to be true only for a string select menu

[kind pumice]

@old geyser is that a breaking change?

[coral prawn]

it looks the same

so peoples expect to work with all select menus

[kind pumice]

For example

if (interaction.isSelectMenu() && !interaction.values.includes('someValue')) {
  // do something
}

If the interaction will be an UserSelectMenu the code won't work correctly

The user expect that the interaction is an instance of StringSelectMenu, but received UserSelectMenu

[coral prawn]

why it wont work?

[kind pumice]

User expect that do something will be executed if the interaction is an instance of StringSelectMenu (old one is SelectMenu)

Yes, the user can change it to interaction.isStringSelcetMenu(), but it should change it on update to major version with breaking changes

[coral prawn]

[kind pumice]

Also SelectMenuComponent represents not only the StringSelectMenu
Btw you forgot to separate it by types

[coral prawn]

ah yeah
i should change it

[coral prawn]

where it represents only the StringSelectMenu

[grand acorn]

the new select menus have added onto the latest release: https://github.com/discordjs/discord-api-types/releases/tag/0.37.15

[coral prawn]

nice

will be added soon

[barren palm]

yeah and it also made using awaitMessageComponents a pain to use