Property messages does not exist on type | discord.js - imagine an app | Page 1

short condor Sep 8, 2022, 3:52 PM

#

Can't really help because the "awaits" inside brackets are awfully hard to read 😅

#

The nested ifs aren't very helpful either

#

Don't take it as a criticism, please. I just wanted to provide feedback. Clean code makes it easier for others and for you, cause you'll get the answer quicker

royal creek Sep 8, 2022, 3:54 PM

#

short condor Can't really help because the "awaits" inside brackets are awfully hard to read ...

I can't really remove those. Keyv usually fails to get data when I'm not using await

#

oh wait I can set variables

#

whoops

short condor Sep 8, 2022, 3:56 PM

#

Yup, that's what I meant - use variables

#

The await is fine. Just put it in a different place

warped timber Sep 8, 2022, 3:56 PM

#

you need to typeguard the channel
either check <Channel>.type or use <Channel>.isTextBased()

#

I see you have ?.isTextBased but don't call it

#

also I don't believe typescript will typeguard like that

royal creek Sep 8, 2022, 3:59 PM

#

warped timber you need to typeguard the channel either check `<Channel>.type` or use `<Channel...

?

#

oh wait here's a better image

warped timber Sep 8, 2022, 4:00 PM

#

you should store it in a variable first before typeguarding it

#

isTextBased() would be fine as well

royal creek Sep 8, 2022, 4:02 PM

#

warped timber `isTextBased()` would be fine as well

Like this?

warped timber Sep 8, 2022, 4:02 PM

#

yes

#

wait

#

why do you get from the cache again

royal creek Sep 8, 2022, 4:03 PM

#

warped timber yes

Still says that message isn't a property of channel

warped timber Sep 8, 2022, 4:03 PM

#

use the one you stored and typeguarded

royal creek Sep 8, 2022, 4:03 PM

#

oh oops

short condor Sep 8, 2022, 4:04 PM

#

Why do you use an exclamation mark at the end of Client. channels.cache.get (channeldata)!?

warped timber Sep 8, 2022, 4:05 PM

#

it's a non-null assertion
~~I assume that means either they know the channel will be there, or they want it to error if it's not~~
nevermind

royal creek Sep 8, 2022, 4:23 PM

#

warped timber use the one you stored and typeguarded

Thanks! It doesn't give me any errors!

#

Which is a bad thing

#

because it doesn't remove the message either 😅

warped timber Sep 8, 2022, 4:23 PM

#

that'd be because fetch is asynchronous, so you're comparing <Promise>.author to a User object

#

consider awaiting that promise too and also comparing ids rather than User objects

royal creek Sep 8, 2022, 4:25 PM

#

warped timber that'd be because `fetch` is asynchronous, so you're comparing `<Promise>.author...

So I'll have to await the author?

warped timber Sep 8, 2022, 4:25 PM

#

no await the fetch

#

the thing that's asynchronous

royal creek Sep 8, 2022, 4:25 PM

#

already did that

warped timber Sep 8, 2022, 4:26 PM

#

then that's fine
but again compare the ids instead of the User objects

royal creek Sep 8, 2022, 4:27 PM

#

warped timber then that's fine but again compare the ids instead of the User objects

so author.id == interaction.user.id?

warped timber Sep 8, 2022, 4:27 PM

#

ye

royal creek Sep 8, 2022, 4:27 PM

#

warped timber ye

Slash commands senders have authors, right?

warped timber Sep 8, 2022, 4:28 PM

#

wdym?

royal creek Sep 8, 2022, 4:28 PM

#

warped timber wdym?

this refferal message has an author, right?

warped timber Sep 8, 2022, 4:29 PM

#

well that's not a referenced message

#

and no I don't believe you can access that

royal creek Sep 8, 2022, 4:39 PM

#

warped timber well that's not a referenced message

Oh well I'm stupid

#

Time to think of a way to get the author ig

#Property messages does not exist on type