nimble flare
This thread is NOT to be confused with #1001614734203834499, it's about a different issue
So this PR https://github.com/discordjs/discord.js/pull/8369 introduced a breaking change since it changes the length of the resulting string, shouldn't there have been a warning about this? A command in my bot broke because of this
I agree with the change in the PR as it does fix an issue, I just think this shouldn't have gone in v14 or at least it should've gotten a warning
uncut rune
sounds to me like your code was relying on a bug
nova remnant
We don't do semver-major for bugfixes, we already talked about this with other maintainers in #1000674404029698108
nimble flare
sounds to me like your code was relying on a bug
not really, it was just relying on the length of the output which changed
nimble flare
We don't do semver-major for bugfixes, we already talked about this with other m...
in deleted-channel I see
well didn't know that, but it's a bit annoying
uncut rune
what were you even relying on it for
truncating input?
and how would a length change break that
nimble flare
truncating input?
yes, putting a big string into an embed field value and truncating to the maximum amount of characters allowed
uncut rune
yea so just dont write bad code then
nimble flare
bruh?
uncut rune
make a general purpose function that takes an input string and the max length
and stop relying on a library to always output predictable string length
end of story
nimble flare
not everything in life needs to be a function
uncut rune
ok