#archive-library-discussion — Page 9

outer raven Jun 23, 2021, 8:21 PM

#

Because they never had null to begin with for some reason

#

Which is actually how I found the bug

copper laurel Jun 23, 2021, 8:21 PM

#

But it's a getter so it should have always been nullable

#

Yeah weird

outer raven Jun 23, 2021, 8:21 PM

#

Yeah exactly but you can add it to that PR

vivid field Jun 23, 2021, 8:23 PM

#

But it does include null?

#

Or am I missing something

slate nacelle Jun 23, 2021, 8:30 PM

#

This is probably about CommandInteraction which narrows the type down to the text based channels:
https://github.com/discordjs/discord.js/blob/master/typings/index.d.ts#L506
| PartialDMChannel | null probably needs to be added.

wicked rain Jun 23, 2021, 8:39 PM

#

Whats the new activity type competing ?

clever spoke Jun 23, 2021, 8:40 PM

#

competing in (whatever)

wicked rain Jun 23, 2021, 8:40 PM

#

Nice that, ok bro

outer raven Jun 23, 2021, 9:34 PM

#

vivid field But it does include null?

I was looking at the CommandInteraction types like space said ^^

#

btw why is it readonly?

ornate topaz Jun 23, 2021, 10:06 PM

#

getter

copper laurel Jun 23, 2021, 10:47 PM

#

Was there a reason we didnt make ApplicationCommand an extendable structure?

oak quail Jun 23, 2021, 10:52 PM

#

soo does anyone have an opinion on this

winged dust Jun 23, 2021, 11:00 PM

#

Is this in the works? https://github.com/discordjs/discord.js/issues/5855 If I recall correctly it also happens on v13

#

or is this feature discontinued

ornate topaz Jun 23, 2021, 11:01 PM

#

https://github.com/discordjs/discord.js/pull/5807 (PR to v12)

loud jayBOT Jun 23, 2021, 11:01 PM

#

pr_open #5886 in discordjs/discord.js by monbrey opened 3 days ago (approved)
fix(Message): flags not being parsed on some edits
📥 npm i monbrey/discord.js#fix-message-manager

copper laurel Jun 23, 2021, 11:01 PM

#

This one also

#

Is the v13 fix

winged dust Jun 23, 2021, 11:02 PM

#

will the fix come to v12 master?

clever spoke Jun 23, 2021, 11:02 PM

#

v12 master?

copper laurel Jun 23, 2021, 11:02 PM

#

v12 isnt master

#

It will come to master

#

Its up to the maintainers if we continue patching v12 or not

winged dust Jun 23, 2021, 11:02 PM

#

ignore the "master" part of the question xd

copper laurel Jun 23, 2021, 11:03 PM

#

lol, Crawl just merged the v13 fix

winged dust Jun 23, 2021, 11:05 PM

#

niceee. is it also a v12 fix?

ornate topaz Jun 23, 2021, 11:05 PM

#

ornate topaz <https://github.com/discordjs/discord.js/pull/5807> (PR to v12)

this is a separate PR

winged dust Jun 23, 2021, 11:06 PM

#

oh 😔

copper laurel Jun 23, 2021, 11:06 PM

#

Theres different bugs and different reasons they happen in each version

#

The suppressEmbeds one is not related to editing out embeds

sharp wigeon Jun 24, 2021, 12:39 AM

#

For discord js -next

#

Since I know it’s supposed to be vastly different from discord js

#

What are some ways it could be different? Like how could we create a new instance of client and stuff? I know kyra had some good ideas

ornate topaz Jun 24, 2021, 1:04 AM

#

afaik -next doesn't even have any shape or form yet

copper laurel Jun 24, 2021, 1:11 AM

#

sharp wigeon What are some ways it could be different? Like how could we create a new instanc...

No, it wont be significantly different for the end user as far as Im aware. The intention is to rebuild the internals, not the externals

kindred yoke Jun 24, 2021, 1:23 AM

#

its going to be completely written in ts right?

#

nvm pins

sharp wigeon Jun 24, 2021, 2:10 AM

#

ornate topaz afaik -next doesn't even have any shape or form yet

That’s why I was hoping to spark some sort of discussion where others could pitch in ideas

copper laurel Jun 24, 2021, 3:56 AM

#

But its not going to be "vastly different"

outer raven Jun 24, 2021, 10:56 AM

#

getting back to this, is it worth opening a PR to fix this?

wild flax Jun 24, 2021, 8:54 PM

#

@outer raven not sure what that thing has to do in your PR https://github.com/discordjs/discord.js/commit/e0efcc6ab0e3f060e30438c0d990c9465c6134df#diff-86252c6a5caa00d9f8fb12018a8cf70659bc19a5fc2a95f9944c7a2c3e781d96L215-R215

#

but we all missed it, and it pretty much broke all bots

#

lol

outer raven Jun 24, 2021, 8:55 PM

#

oh shit

wild flax Jun 24, 2021, 8:55 PM

#

No unrelated changes in PRs please, even if they seem like a no-brainer next time

#

👀

outer raven Jun 24, 2021, 8:55 PM

#

yeah noted, sorry

#

I thought that was transforming the type into a string, not the other way around

copper laurel Jun 24, 2021, 9:01 PM

#

That method is for getting the data to send to the API, so needs to be an int

outer raven Jun 24, 2021, 9:03 PM

#

yeye got it now

#

On a completely unrelated note though: what do you guys think of merging sub command options into the main interaction's options? Let me explain:
When you run a command with a subcommand or subcommand group, the only option in the main collection will be the sub command that you ran, so if we manage to merge them all into the first there should be no issue (unless an option has the same name as one of the sub commands, which i don't know if it's possible)

copper laurel Jun 24, 2021, 9:41 PM

#

merge how?

#

you still need to know which subcommand was run, are you proposing moving that property up to CommandInteraction#subcommandName or something

outer raven Jun 24, 2021, 9:49 PM

#

copper laurel you still need to know which subcommand was run, are you proposing moving that p...

no, the subcommands would be kept. What I'm suggesting is adding the options that would otherwise be nested in the subcommand to interaction.options

copper laurel Jun 24, 2021, 9:49 PM

#

I dont like the idea of breaking the hierarchy, no

outer raven Jun 24, 2021, 10:00 PM

#

imo it made sense since you'll never have more than 1 option with sub commands and groups but sure then

copper laurel Jun 24, 2021, 10:10 PM

#

hmmm actually yeah maybe

#

I think the part I'd find awkward is that if the subcommand is kept, you'd be getting it essentially like a boolean option I guess? Just checking that its... there, and then you know what the other options are?

outer raven Jun 24, 2021, 10:12 PM

#

When you have multiple subcommands you'd be checking which one the user ran. I usually do this with interaction.options.find(o => o.type === "SUB_COMMAND")

honest barn Jun 24, 2021, 10:13 PM

#

why is code option in #5918 being removed? there's no other clean way to do it without manually writing it into the string

outer raven Jun 24, 2021, 10:15 PM

#

this seems clean enough to me

#

although you need a bunch of \ there

honest barn Jun 24, 2021, 10:16 PM

#

yeah thats why code was very useful for me

outer raven Jun 24, 2021, 10:16 PM

#

but why is adding \ an issue?

honest barn Jun 24, 2021, 10:17 PM

#

its an issue when you're using the `` type of string

#

too many \ affects readability

outer raven Jun 24, 2021, 10:21 PM

#

not that you would need to read a lot from a bunch of slashes

#

you can even put that in multiple lines if you prefer

ornate topaz Jun 24, 2021, 10:38 PM

#

for the codeblock to be formatted properly, you need a single newline after language. no matter if you use ` or ', it has to be there

#

however, template strings (`) have a bonus of being able to be multiline themselves

wild flax Jun 24, 2021, 10:43 PM

#

honest barn why is code option in #5918 being removed? there's no other clean way to do it w...

We'll have a util available for it

#

It just wont be a message option anymore

honest barn Jun 24, 2021, 10:59 PM

#

oh then it's a good change

#

that would be allowed for any string right?

wild flax Jun 24, 2021, 11:00 PM

#

yeah it will just be a function you wrap your string with

outer raven Jun 24, 2021, 11:01 PM

#

will that be included in that PR?

wild flax Jun 24, 2021, 11:02 PM

#

no

solemn oyster Jun 24, 2021, 11:02 PM

#

We talked about adding that in /builders and then re-exporting in d.js

outer raven Jun 24, 2021, 11:02 PM

#

outer raven When you have multiple subcommands you'd be checking which one the user ran. I u...

getting back to this, can I open the PR?

wild flax Jun 24, 2021, 11:03 PM

#

just open it if you think its useful

#

doesnt mean well accept it

outer raven Jun 24, 2021, 11:05 PM

#

alright

copper laurel Jun 24, 2021, 11:15 PM

#

If there's only one possible sub-command at a time, why make people find it as an option when it could be bumped up to a property though

#

I feel like you could have
interaction#commandName
interaction#subcommand
interaction#subcommandGroup
and then just the options or something

outer raven Jun 24, 2021, 11:19 PM

#

copper laurel I feel like you could have `interaction#commandName` `interaction#subcommand` `i...

yeah that could work
I'm actually having a hard time figuring out a smart way to merge the two collections since the main interaction.options is only built after the inner options are

#

so maybe remove it all together would be a good idea and much easier

#

actually nah even then I have no clue how to do this in a smart way since I'm not familiar with the way djs patches stuff, could you try to do this?

winged dust Jun 25, 2021, 4:00 AM

#

https://github.com/discordjs/discord.js/issues/5855 this issue is closed. Is it fixed for v12? If so, do I just update discordjs or are there extra steps?

frank turret Jun 25, 2021, 4:06 AM

#

AFAIK, there are no additional releases for v12, so you'd have to install from dev. npm i discord.js@dev

copper laurel Jun 25, 2021, 4:07 AM

#

Not fixed in v12, no

#

I dont think that issue relates to v12

oak quail Jun 25, 2021, 4:09 AM

#

thats due to sending embeds

#

https://github.com/discordjs/discord.js/pull/5807

#

lol https://advaith.is-in-hyper.space/8c27d9c4d3.png

copper laurel Jun 25, 2021, 4:14 AM

#

The suppressEmbeds bug is different to the empty embeds bug

#

sort of

#

It probably shouldnt be closed though

wild flax Jun 25, 2021, 7:16 AM

#

Yeah we have no more releases for v12 planned.

solemn oyster Jun 25, 2021, 11:30 AM

#

@vernal atlas what are your plans on https://github.com/discordjs/discord.js/pull/5132?

#

Are you gonna do the largest rebase ever before continuing a lot further? Or split the changes in smaller PRs?

vernal atlas Jun 25, 2021, 11:33 AM

#

well i was at first going to rebase and continue, but now im thinking that splitting the changes is a good idea

wild flax Jun 25, 2021, 11:34 AM

#

Yeah, smaller ones are also easier to review and merge

outer raven Jun 25, 2021, 2:04 PM

#

@slate nacelle why the confused emoji? https://github.com/discordjs/discord.js/pull/5923#issuecomment-868373891

slate nacelle Jun 25, 2021, 2:38 PM

#

I wouldn't call the bot property being invalid expected behaivor.
Or at least hope it's not.

outer raven Jun 25, 2021, 3:25 PM

#

slate nacelle I wouldn't call the bot property being invalid expected behaivor. Or at least ho...

Well yeah but the user object I got from fetching an audit log had every property it should and thus it wasn’t classified as a partial so I don’t know any other way to get this information, unless we check for all properties inside the object to determine if its a partial or not

slate nacelle Jun 25, 2021, 3:26 PM

#

Patching with partial data should not invalidate the state of the object.

#

If you are not sure a change has to be made, make none.

outer raven Jun 25, 2021, 3:44 PM

#

slate nacelle Patching with partial data should not invalidate the state of the object.

alright I did a few more tests and I found a solution that worked for me, let me know if there are any other issues

copper laurel Jun 26, 2021, 11:24 AM

#

I think I'm missing exactly what you think is incorrect here. You kinda lost me right from the start when you told me you were re-assigning properties to things they aren't meant to be. The identifier on a custom emoji will be its name:id format, while on a unicode emoji, it will be the unicode. It's not ever meant to be the id, which yes, will be null on unicode emojis.

#

The ReactionEmoji class is kinda like a partial guild emoji, eg when the reaction came from a guild the bot isn't in so it can't get full data I think

#

yes, but it wont have an id if its unicode

#

If you need to store them in a database for whatever reason, const unique = emoji.id ?? emoji.identifier

#

Because it is the identifer at the time

#

Youre just misusing the property

#

Its not supposed to be a primary key for a database

loud jayBOT Jun 26, 2021, 12:44 PM

#

pr_open #5929 in discordjs/discord.js by SkyFlags opened 1 hour ago (review required)
fix(Message): Make author of referenced message nullable
📥 npm i SkyFlags/discord.js#master

wintry karma Jun 26, 2021, 4:47 PM

#

Is there a reason for skipLibCheck being set to true in the tsconfig.json?
Would it make more sense to set that to false to catch errors in the typings?

solemn oyster Jun 26, 2021, 4:50 PM

#

I have never tried but... I suppose we could add a stub augment

#

Something likets module '@discordjs/voice' { interface TheInterfaceWeRequireFromIt {} }

#

If the module is installed, then it'd merge an empty interface with the full one

#

That way we can use that interface from a module that's otherwise missing, without getting compiler errors

#

That must be inside declare module 'discord.js' {}, btw

#

cc: @tacit crypt @fringe temple

vivid field Jun 26, 2021, 4:57 PM

#

Why do we even have @types/ws and discord-api-types as dependencies now, but not @discordjs/voice?

wintry karma Jun 26, 2021, 5:05 PM

#

Typings are currently broken on master because there are interfaces imported, that don't exist in the used discord-api-types version.
And with skipLibCheck: true that could easily be missed.

vivid field Jun 26, 2021, 5:06 PM

#

What interfaces exactly?

wintry karma Jun 26, 2021, 5:07 PM

#

typings/index.d.ts(142,5): error TS2305: Module '"discord-api-types/v8"' has no exported member 'APIActionRowComponent'.
typings/index.d.ts(147,5): error TS2305: Module '"discord-api-types/v8"' has no exported member 'APIMessageComponent'.
typings/index.d.ts(1634,12): error TS2416: Property 'options' in type 'ReactionCollector' is not assignable to the same property in base type 'Collector<string | `${bigint}`, MessageReaction>'.
  Type 'ReactionCollectorOptions' is not assignable to type 'CollectorOptions<[MessageReaction]>'.
    Types of property 'filter' are incompatible.
      Type 'CollectorFilter<[MessageReaction, User]> | undefined' is not assignable to type 'CollectorFilter<[MessageReaction]> | undefined'.
        Type 'CollectorFilter<[MessageReaction, User]>' is not assignable to type 'CollectorFilter<[MessageReaction]>'.
typings/index.d.ts(1640,12): error TS2416: Property 'collect' in type 'ReactionCollector' is not assignable to the same property in base type 'Collector<string | `${bigint}`, MessageReaction>'.
  Type '(reaction: MessageReaction) => Promise<string | `${bigint}`>' is not assignable to type '(...args: any[]) => string | `${bigint}`'.
    Type 'Promise<string | `${bigint}`>' is not assignable to type 'string | `${bigint}`'.
      Type 'Promise<string | `${bigint}`>' is not assignable to type '`${bigint}`'.

vivid field Jun 26, 2021, 5:08 PM

#

Oh that's intentional I think, it's going to be released with the next version

wintry karma Jun 26, 2021, 5:11 PM

#

They exist on discord-api-types main so probably.
But I personally think that they shouldn't be ignored in the CI, like they are now, so they don't get missed.

copper laurel Jun 26, 2021, 9:13 PM

#

Not on main, on next

#

I think

flint zephyr Jun 27, 2021, 3:52 PM

#

Please add better documentation for FriendlyError and CommandFormatError in Commando 😦
I really want to use something that lets me customize the command format error but there is no clear documentation

#

Like add use cases and examples

wild flax Jun 27, 2021, 3:56 PM

#

Commando is currently unmaintained

rough roost Jun 27, 2021, 7:09 PM

#

why are snowflakes not just bigints?

cloud kraken Jun 27, 2021, 7:13 PM

#

Because that's how the api sends them

wild flax Jun 27, 2021, 7:14 PM

#

you can't serialize bigints

rough roost Jun 27, 2021, 7:22 PM

#

that's unfortunate

ebon radish Jun 27, 2021, 8:59 PM

#

How does Discord.js achieve seamless ESM-CommonJS interop?

vivid field Jun 27, 2021, 9:02 PM

#

Using https://npm.im/gen-esm-wrapper

#

It's not 100% seamless either, as explained in https://github.com/discordjs/discord.js/issues/4670

ebon radish Jun 27, 2021, 9:29 PM

#

vivid field It's not 100% seamless either, as explained in <https://github.com/discordjs/dis...

thanks for this. I think I'll be fine if all issues are that obscure. have you ever considered just dropping CommonJS support?

oak quail Jun 27, 2021, 9:31 PM

#

pretty much everyone uses commonjs though?

ebon radish Jun 27, 2021, 9:31 PM

#

but why? I guess that's my real question. why have we not fully embraced ESM?

#

we meaning the node.js ecosystem

wild flax Jun 27, 2021, 9:33 PM

#

Because requiring cjs inside of mjs is problematic

#

Or rather the other way around

#

So our lib couldnt be used outside of mjs anymore

#

Which is rather problematic

#

We would have to supply cjs builds

#

And lets just assume we have a big typescript userbase, the standard tsconfig.json tsc generates does not set the compilation target to ESNext by default either

#

So we would get daily questions about that 100%

#

Thats not to mention all glitch/replit users

ebon radish Jun 27, 2021, 9:36 PM

#

is it problematic for reasons other than that?

oak quail Jun 27, 2021, 9:36 PM

#

node esm doesn't support json

wild flax Jun 27, 2021, 9:36 PM

#

No, but I would argue this is a big problem indeed

ebon radish Jun 27, 2021, 9:37 PM

#

other than users not knowing how to switch, I mean

oak quail Jun 27, 2021, 9:37 PM

#

which is why I've tried esm multiple times and have had to go back to cjs

vivid field Jun 27, 2021, 9:37 PM

#

Yeah, some things are still experimental

ebon radish Jun 27, 2021, 9:37 PM

#

hmm can't you read the json the normal way

vivid field Jun 27, 2021, 9:37 PM

#

JSON modules are stage 3 but node doesnt have them yet

wild flax Jun 27, 2021, 9:38 PM

#

theres a lot more cons here: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

#

Its a lot of work honestly that is not very clear

ebon radish Jun 27, 2021, 9:54 PM

#

wild flax theres a lot more cons here: <https://gist.github.com/sindresorhus/a39789f98801d...

tempted to copy this readme

ebon radish Jun 27, 2021, 9:56 PM

#

oak quail node esm doesn't support json

I don't understand this. you can read json files. you just can't abuse import to do it. the normal way is not significantly more work

copper laurel Jun 27, 2021, 9:58 PM

#

I still really dont see any reason to just drop support for something that is still in such widespread use

ebon radish Jun 28, 2021, 1:33 AM

#

thanks for your answers, my questions were not rhetorical

oak quail Jun 28, 2021, 3:12 AM

#

since discord deprecated Message.stickers and is switching to Message.sticker_items (presumably to not break .stickers), should d.js keep using Message#stickers (with the .sticker_items data) or use Message#stickerItems or similar? (sticker_items contains partial sticker objects)

#

(personally I like Message#stickers and think Message#stickerItems sounds dumb)

copper laurel Jun 28, 2021, 3:28 AM

#

Agreed, we can still make breaking changes to Message#stickers so go for it

oak quail Jun 28, 2021, 3:32 AM

#

also unfortunately the Sticker#fetch discussion is still happening
re https://github.com/discordjs/discord.js/pull/5867#discussion_r658874457
if there's gonna be Sticker#fetchUser to get the user if it's a guild emoji, then what should Sticker#fetch do (since it'll be needed for the partial sticker objects)

#

vlad says that if it knows that the sticker is in a guild, it should try to fetch with the guild route (which will only work if the bot is in the guild) to try to get sticker.user
I say that it should just run Client#fetchSticker, and people can use Sticker#fetchUser (or GuildStickerManager when that's added) if they want the user

copper laurel Jun 28, 2021, 3:41 AM

#

Is it possible for the bot to have/receive a sticker without being in the guild

oak quail Jun 28, 2021, 3:43 AM

#

yes

#

in messages

#

or by fetching with the non-guild route (which works for all existing stickers)

#

itll probably not be in the sticker's guild most of the time

#

and I think Sticker#fetch should work in that situation

copper laurel Jun 28, 2021, 3:45 AM

#

what message would it receive if its not in the guild? or are they like emojis and can be used globally?

oak quail Jun 28, 2021, 3:46 AM

#

latter, if the user has nitro

copper laurel Jun 28, 2021, 3:46 AM

#

right

oak quail Jun 28, 2021, 3:46 AM

#

u can already use them if u have android alpha

copper laurel Jun 28, 2021, 3:46 AM

#

yeah while it might be nice to be able to have it know where to fetch from I think that would introduce inconsistency in the expected behaviour

#

Since people will need to call fetchUser anyway?

oak quail Jun 28, 2021, 3:49 AM

#

well if the bot is in the guild and it did the check, you could just do (await sticker.fetch()).user and it would work

#

but the sticker.fetch() would error if the bot isnt in the server

copper laurel Jun 28, 2021, 3:51 AM

#

but it should fallback to the other fetch right?

oak quail Jun 28, 2021, 3:58 AM

#

vlad seemed to want it to let it just throw the DiscordAPIError

#

but ig we could fallback

outer raven Jun 28, 2021, 11:27 AM

#

Is there a difference between using the @readonly tag or making a type Readonly<> in the docs?

zenith oracle Jun 28, 2021, 11:32 AM

#

I think only with the tag @readonly this can be showed

copper laurel Jun 28, 2021, 11:51 AM

#

Readonly is a typescript type, not something jsdocs would understand

vernal atlas Jun 28, 2021, 12:15 PM

#

Readonly<T> means that all the properties in T are read-only, but the object can still be 'overwritten' to put it simply

surreal geode Jun 28, 2021, 12:47 PM

#

Should this be changed from Record<string, string> to

interface RequestData {
  // ..
  headers?: {
    [K in keyof RequestHeaders]?: RequestHeaders[K];
  }
}

https://github.com/discordjs/discord.js-next/blob/6ebe80f1d3f72c6d66e515620c590d4cd6398a15/packages/rest/src/lib/RequestManager.ts#L47

wild flax Jun 28, 2021, 12:48 PM

#

No

#

Why?

#

Also non-standard headers

surreal geode Jun 28, 2021, 12:49 PM

#

I thought for type safety/intellisense. What additional headers are used other than these three?

wild flax Jun 28, 2021, 12:49 PM

#

anything can be a header

#

as long as the server on the other end handles/implements it

surreal geode Jun 28, 2021, 12:51 PM

#

Makes sense, thanks

outer raven Jun 28, 2021, 2:22 PM

#

copper laurel Readonly is a typescript type, not something jsdocs would understand

the thing is some types in the jsdoc comments have Readonly<> instead of @readonly, should I open a PR to fix this?

vivid field Jun 28, 2021, 2:30 PM

#

As sugden pointed out, @readonly means that the property on the class can't be overwritten, Readonly<T> means that the returned object itself is frozen

#

So they're not the same

outer raven Jun 28, 2021, 2:30 PM

#

and how can we tell those two apart in the code?

vivid field Jun 28, 2021, 2:32 PM

#

Tell apart where exactly?

outer raven Jun 28, 2021, 2:33 PM

#

Which ones should have @readonly, Readonly<T> or both

vivid field Jun 28, 2021, 2:38 PM

#

Readonly<T> when you use Object.freeze() or a similar method
@readonly usually when you have a getter without a setter

outer raven Jun 28, 2021, 2:44 PM

#

Alright. I just found this odd because Readonly seems to be the only thing the docs don't link

#

is it worth linking this to ts docs maybe?

flint zephyr Jun 28, 2021, 2:51 PM

#

wild flax Commando is currently unmaintained

😦

sharp wigeon Jun 28, 2021, 3:02 PM

#

Why don’t I get the proper intellisense for ColorResolvable

#


type ColorResolvable =
    | 'DEFAULT'
    | 'WHITE'
    | 'AQUA'
    | 'GREEN'
    | 'BLUE'
    | 'YELLOW'
    | 'PURPLE'
    | 'LUMINOUS_VIVID_PINK'
    | 'FUCHSIA'
    | 'GOLD'
    | 'ORANGE'
    | 'RED'
    | 'GREY'
    | 'DARKER_GREY'
    | 'NAVY'
    | 'DARK_AQUA'
    | 'DARK_GREEN'
    | 'DARK_BLUE'
    | 'DARK_PURPLE'
    | 'DARK_VIVID_PINK'
    | 'DARK_GOLD'
    | 'DARK_ORANGE'
    | 'DARK_RED'
    | 'DARK_GREY'
    | 'LIGHT_GREY'
    | 'DARK_NAVY'
    | 'BLURPLE'
    | 'GREYPLE'
    | 'DARK_BUT_NOT_BLACK'
    | 'NOT_QUITE_BLACK'
    | 'RANDOM'
    | [number, number, number]
    | number
    | string;
``` it doesn’t show these color names with intellisense, maybe it’s just a problem on my end

fallow crater Jun 28, 2021, 3:05 PM

#

had a similar issue before, I think it's bc of the | string. Not sure tho

solemn oyster Jun 28, 2021, 3:06 PM

#

It is

sharp wigeon Jun 28, 2021, 3:07 PM

#

Yeah that’s what I was thinking too

solemn oyster Jun 28, 2021, 3:10 PM

#

Fixing that rn

loud jayBOT Jun 28, 2021, 3:16 PM

#

pr_open #5950 in discordjs/discord.js by kyranet opened 19 seconds ago (review required)
types(ColorResolvable): change string to #${string}
📥 npm i kyranet/discord.js#typings/strict-type-string-color

solemn oyster Jun 28, 2021, 3:17 PM

#

@sharp wigeon @fallow crater ^

sharp wigeon Jun 28, 2021, 3:17 PM

#

thank you

solemn oyster Jun 28, 2021, 3:17 PM

#

np meowthumbsup

vernal atlas Jun 28, 2021, 3:31 PM

#

outer raven Alright. I just found this odd because Readonly seems to be the only thing the d...

perhaps something similar to https://github.com/discordjs/discord.js/pull/5144/files#diff-9c03fb4d8c1b03db876641d3900a9c08f5a3a30be8d8a3b9840018507243c284R1477 would be an idea

outer raven Jun 28, 2021, 3:31 PM

#

Why can’t we just link it like a promise or an object?

vernal atlas Jun 28, 2021, 3:46 PM

#

rafShrug i guess so

outer raven Jun 28, 2021, 4:06 PM

#

although im not sure because most people don't use typescript (mostly beginners) so it might confuse them

#

and readonly is pretty self-explanatory by itself

#

so ill let that be for now

#

but for future reference this would be the link https://www.typescriptlang.org/docs/handbook/utility-types.html#readonlytype

glass cypress Jun 28, 2021, 7:02 PM

#

there should be a way to view the old design of the website

#

I find it easier to navigate

wild flax Jun 28, 2021, 7:05 PM

#

Won’t be a thing

oak quail Jun 28, 2021, 11:48 PM

#

for threads

Error [GUILD_CHANNEL_RESOLVE]: Could not resolve channel to a guild channel.
at GuildMember.permissionsIn
i sent this to ckohen over a month ago, looks like its still unfixed in master?

copper laurel Jun 28, 2021, 11:57 PM

#

Assuming this happens when you pass a ThreadChannel?

wild flax Jun 29, 2021, 12:11 AM

#

Yeah this needs a bit more info

ruby terrace Jun 29, 2021, 1:28 AM

#

oak quail for threads > Error [GUILD_CHANNEL_RESOLVE]: Could not resolve channel to a guil...

totally forgot you sent me this, I'll fix it in a thread fixup PR that I'm making now

outer raven Jun 29, 2021, 1:56 PM

#

Why was it decided to create the thread channel types with _ instead of the camel casing that is used basically all across the library?

#

Talking about public_thread, private_thread and news_thread which could be publicThread, privateThread and newsThread

#

the only places I see _ being used are in full caps names that usually come from Discord's docs

solemn oyster Jun 29, 2021, 4:14 PM

#

cc: @ruby terrace ^

outer raven Jun 29, 2021, 4:52 PM

#

Also it would be relatively easy to switch to a date-based version number for dev releases. Can I open a PR to change this so that dependabot starts working again and people stop getting confused when they install an old version with npm up? @wild flax

#

this is my proposal (YYYYmmddHHMM)

solemn oyster Jun 29, 2021, 5:14 PM

#

No

#

The hash is handy because it prevents duplicated releases (aka releasing the same commit twice)

#

And it also helps identifying the commit in GitHub as well

outer raven Jun 29, 2021, 5:19 PM

#

solemn oyster And it also helps identifying the commit in GitHub as well

Github tells you on which commit the action ran though

solemn oyster Jun 29, 2021, 5:19 PM

#

It's extra steps, and also refer to the first point

outer raven Jun 29, 2021, 5:20 PM

#

Ye I know but that doesn’t happen very often since a PR is usually merged every x hours

#

And even if it does it’ll be once and doesn’t hurt that much

#

It’s just that I’ve seen way too many people in #djs-help-v14 saying they have the latest version when they don’t because they used npm up

vivid field Jun 29, 2021, 5:22 PM

#

That could also be fixed by deprecating outdated dev versions automatically

wild flax Jun 29, 2021, 5:23 PM

#

Which they are

vivid field Jun 29, 2021, 5:23 PM

#

Oh they are now?

#

I thought you just did it manually once

outer raven Jun 29, 2021, 5:23 PM

#

Are they?

wild flax Jun 29, 2021, 5:23 PM

#

I still do but it should only have 1 not deprecated

vivid field Jun 29, 2021, 5:24 PM

#

At the moment yes

solemn oyster Jun 29, 2021, 5:24 PM

#

outer raven Jun 29, 2021, 5:24 PM

#

Well yeah but that doesn’t seem to fix the npm up issue unfortunately

#

Nor dependabot

vivid field Jun 29, 2021, 5:25 PM

#

~~It did work for me in a test environment~~ Nvm, installing an outdated version and then running npm update won't update to the latest commit

outer raven Jun 29, 2021, 5:29 PM

#

ah ok cuz I was testing and it wasn't working for me

#

is it really that big of an issue if a "duplicated" version is released? Imo the pros outweigh the cons here

#

Its also easier for the user to know when the version they have is from

tacit crypt Jun 29, 2021, 5:32 PM

#

outer raven Its also easier for the user to know when the version they have is from

Which they can get from the commit

outer raven Jun 29, 2021, 5:32 PM

#

They have to go on GitHub and find the commit

solemn oyster Jun 29, 2021, 5:32 PM

#

No, just paste the hash

outer raven Jun 29, 2021, 5:33 PM

#

Way more complicated than looking at a number and getting the day from it

solemn oyster Jun 29, 2021, 5:33 PM

#

e.g. https://github.com/discordjs/discord.js/commit/5ad83a6a65e5944ceb3a41fee2df40ba1f5b03e4

outer raven Jun 29, 2021, 5:33 PM

#

Yeah it’s still more complicated than looking at a date

solemn oyster Jun 29, 2021, 5:33 PM

#

Looking at a date is unreliable because GH shows local time while GHA uses another when releasing

obtuse hazel Jun 29, 2021, 5:33 PM

#

There can be several commits on the same date so it won't be unique too

outer raven Jun 29, 2021, 5:33 PM

#

Only 2 unless it’s manually ran

#

And the date is the least relevant, the day is enough and accurate enough as well

solemn oyster Jun 29, 2021, 5:34 PM

#

We do multiple releases a day sometimes, tho

outer raven Jun 29, 2021, 5:34 PM

#

The CI runs twice and Crawl sometimes runs it manually. I’ve never seen more than 3 releases in a day

wild flax Jun 29, 2021, 5:34 PM

#

make it 7 SHA and a unix timestamp and I accept it

solemn oyster Jun 29, 2021, 5:35 PM

#

But that doesn't offer de-duplication, Crawl

wild flax Jun 29, 2021, 5:35 PM

#

13.0.0-dev.7_SHA.UNIX

outer raven Jun 29, 2021, 5:35 PM

#

Fine by me

wild flax Jun 29, 2021, 5:35 PM

#

thats fine, don't care enough, as long as this whining stops

solemn oyster Jun 29, 2021, 5:35 PM

#

And not like the UNIX timestamp is readable at all

#

I could find the date a commit's from faster than getting the full date from the timestamp

outer raven Jun 29, 2021, 5:36 PM

#

Wait yeah why not a date

wild flax Jun 29, 2021, 5:36 PM

#

because dates suck

#

honestly

solemn oyster Jun 29, 2021, 5:36 PM

#

I prefer keeping the system as-is, maybe reduce sha to 7, but that's all

wild flax Jun 29, 2021, 5:36 PM

#

Dot seperation is nice

#

- separation is not

outer raven Jun 29, 2021, 5:36 PM

#

But you can have both

#

Or none

#

My proposal was YYYYmmddHHDD but you can add dots in between

wild flax Jun 29, 2021, 5:37 PM

#

yeah but if you do 20200628 you might as well do a unix timestamp

#

its not for the user anyway

outer raven Jun 29, 2021, 5:37 PM

#

Why not?

wild flax Jun 29, 2021, 5:37 PM

#

its to fix npm

#

I really don't want to discuss this, its a temporary thing anyway until we have proper pre-releases

outer raven Jun 29, 2021, 5:38 PM

#

Will there be dev releases after v13?

wild flax Jun 29, 2021, 5:38 PM

#

I'm not going to heavily invest into a system thats gone in less than 6 months

outer raven Jun 29, 2021, 5:38 PM

#

Possibly for v14

outer raven Jun 29, 2021, 5:38 PM

#

wild flax I'm not going to heavily invest into a system thats gone in less than 6 months

It’s not a hard fix tbh, just trying to make it more readable I guess

wild flax Jun 29, 2021, 5:40 PM

#

I just don't like it

#

As much as you don't like the current system

outer raven Jun 29, 2021, 5:44 PM

#

Fine then, I’ll try to find a way to get the unix timestamp and PR

#

So this is good right

wild flax Jun 29, 2021, 5:55 PM

#

sure

outer raven Jun 29, 2021, 5:55 PM

#

aight, will open rn

wild flax Jun 29, 2021, 6:14 PM

#

Actually, now that I think about it, --short might be better

#

but it doesn't matter

outer raven Jun 29, 2021, 6:15 PM

#

with the 8 chars?

#

sure

wild flax Jun 29, 2021, 6:15 PM

#

it won't be staying "alive" for too long

#

its mainly to guard against collisions

outer raven Jun 29, 2021, 6:15 PM

#

so should I change it

wild flax Jun 29, 2021, 6:15 PM

#

but we arent a repo like the unix kernel lol

#

nah just keep things as is

outer raven Jun 29, 2021, 6:15 PM

#

aight

wild flax Jun 29, 2021, 6:16 PM

#

ah, vaporox brings up a good point

#

so I guess you might as well commit his change

outer raven Jun 29, 2021, 6:16 PM

#

what does --verify do?

wild flax Jun 29, 2021, 6:16 PM

#

https://git-scm.com/docs/git-rev-parse#Documentation/git-rev-parse.txt---verify

outer raven Jun 29, 2021, 6:17 PM

#

alright, will commit then

real jetty Jun 29, 2021, 6:58 PM

#

wouldn't it be a good idea to create some guild webhook manager in master, just like how <Guild>.fetchBans() and BanInfo were removed and replaced with a GuildBanManager in v13?
maybe same for invites, integrations, templates, etc?

wild flax Jun 29, 2021, 6:59 PM

#

We don't put managers everywhere on purpose

#

Only if it adds a real benefit

wild flax Jun 29, 2021, 7:49 PM

#

A new dev version has been released with the changes.

outer raven Jun 29, 2021, 7:52 PM

#

hmm npm up doesn't seem to be picking up on it but it doesn't downgrade either, lemme try dependabot

#

alright can confirm dependabot is working again, thank you!

remote wasp Jun 29, 2021, 8:25 PM

#

@ruby terrace The example doesn't seem to match with what is documented above it here: https://github.com/discordjs/discord.js/blob/3174507d57d9f6011e97b4f3209f42179e050f9b/src/managers/ThreadManager.js#L89
The example says it will create a public thread but it is missing the startMessage param, which according to the docs above means that the thread will be private

ruby terrace Jun 29, 2021, 9:29 PM

#

outer raven Why was it decided to create the thread channel types with _ instead of the came...

I have no choice in this matter, the channel types are lower cased at creation of the channel and constants are UPPER_CASED

ruby terrace Jun 29, 2021, 9:29 PM

#

remote wasp <@!140214425276776449> The example doesn't seem to match with what is documented...

Forgot to remove the extra tidbit yeah

#

only docs for startMessage need to be changed

outer raven Jun 29, 2021, 11:53 PM

#

ruby terrace I have no choice in this matter, the channel types are lower cased at creation ...

But this isn't determined by Discord. In fact, channel types in Discord are UPPER_CASED so I think we could change that just to be more consistent across the whole library

#

there are not many places that I'm aware of where lower_casing is used

ruby terrace Jun 30, 2021, 12:33 AM

#

We're fighting two different library conventions, parameters are typically camelCased, whereas Constants are UPPER_CASED. I think the lowercaseing of channel types may have been an interesting (unsuccessful) attempt at ensuring camelCase for the properties. Not opposed to changing it, its just a very large whole library refactor

ornate topaz Jun 30, 2021, 12:37 AM

#

Wait, where are we using lower_case instead of camelCase?

outer raven Jun 30, 2021, 12:40 AM

#

ornate topaz Wait, where are we using lower_case instead of camelCase?

channel types

#

more specifically news_thread, public_thread and private_thread

ruby terrace Jun 30, 2021, 12:40 AM

#

channel types get .toLowerCased so I used that for all _thread types everywhere

outer raven Jun 30, 2021, 12:41 AM

#

Yeah I don't blame you and I know it's a large change but so was changing to camelCasing in v10 or whatever it was so, for the sake of consistency, I think we should go for it

ruby terrace Jun 30, 2021, 1:10 AM

#

just so you know, I'm going to do something about this, don't know what yet though, should have a PR within a day though

lone vector Jun 30, 2021, 1:18 AM

#

Moving here from #archive-interactions since it's probably more relevant, it looks like the typings for followUp on CommandInteraction was removed in https://github.com/discordjs/discord.js/pull/5831, I can't tell if this is intentional or not but I would assume it wasn't?

ruby terrace Jun 30, 2021, 1:21 AM

#

Looks like it got removed accidentally in the last rebase

lone vector Jun 30, 2021, 1:42 AM

#

Seems like the changes in that PR weren't applied to that function too, unless that function wouldn't need them, I could potentially PR a fix though it may be easier for someone who already has an environment set up

copper laurel Jun 30, 2021, 2:35 AM

#

I just fucked up a rebase there and deleted an extra line. Add the type back

#

That function doesnt need the changes

lone vector Jun 30, 2021, 2:45 AM

#

Alright, will do

tender field Jun 30, 2021, 8:07 AM

#

can't you simplify that https://github.com/discordjs/discord.js/pull/5976/files#diff-d6774c7fcd0485bec7c183ecf1749f65eea85a05999935ddf4aa7b331ddb4826
with ```js
exports = { ...exports, ...require('@discordjs/builders') };

solemn oyster Jun 30, 2021, 8:15 AM

#

Not really, because we're exporting ButtonBuilder, EmbedBuilder, MessageBuilder, and a few more, in later PRs to /builders

#

Which we'd like to expose separately (and outside Formatters, as they're different things)

#

An alternative, though, is to namespace them in /builders

#

But that might be bothersome if you use it directly

remote wasp Jun 30, 2021, 8:22 AM

#

I was testing thread creation to decide how to document the params and believe me I had to bring out my notebook to write down all the possible ways in which startMessage and type param can be combined. I would share it but it looks horrible. This mess can lead to a lot of potential issues in the support. The solution I want to propose is to have two seperate methods for thread creation just like there are two seperate endpoints for them. For eg: ThreadManager#create and ThreadManager#createFromMessage or something along that line. This will remove all the issues that arise due to possible combinations of startMessage and type param.

ruby terrace Jun 30, 2021, 8:31 AM

#

It could work, I highly anticipate people to never start a thread from a message using that function, instead using Message#startThread(). That paremeter exists so that can work.

all the possible ways in which startMessage and type param can be combined.
What do you mean by this though? They can't?

remote wasp Jun 30, 2021, 8:38 AM

#

Yes correct, they don't as passing one specific param will do nothing in a particular case as it acts like a noop because something else will get passed no matter what you pass as value for that param. Which is where the issue is. The behaviour is weird because that params will matter sometimes and won't sometimes. We are mixing two endpoints into a single method and hence why this behaviour. I know I'm not making much sense here so I'll make a table to clear what I'm trying to say.

remote wasp Jun 30, 2021, 9:26 AM

#

https://i.imgur.com/J4mfNr5.png
As you can see in the table the type param only matters when startMessage isn't provided. This means that type affects nothing in the other three cases. As you pointed out Message#startThread doesn't even talk about type because it takes the type from the message there and that's why it is much more clean. I was thinking about doing the same for manager. A method that creates threads from message and another that creates using type (just like the endpoints). This will seperate these two params into two different methods where their presence/absence does affect the result.

ruby terrace Jun 30, 2021, 10:16 AM

#

The news _ + type column is wrong, its always news thread

remote wasp Jun 30, 2021, 10:20 AM

#

right, my bad

ruby terrace Jun 30, 2021, 10:23 AM

#

you see the problem here? type really only matters if provided on a text channels thread manager, and technically news_thread is an invalid parameter.
If you create a new function, createWithMessaage for example (cause I think it would be the less used one, called internally mostly) then you still have much of the same issue with create, always creates news in a news channel, but can have errors etc in text

#

Technically speaking doing this could make it much more type safe for ts users though since news doesn't extend text in that case. You just can't separate it in the actual code

#

With that, I say do it, adding something like

export class ThreadManager<AllowedThreadType> ... {
  public create(options: { ... type?: AllowedThreadType };
}
export class NewsChannel {
  public threads: ThreadManager<'news_thread' | 10>;
}
export class TextChannel {
  public threads: ThreadManager<'public_thread' | 'private_thread' | 11 | 12>;
}

#

to make it very type safe

#

it'll be hard to do for docs, but for ts users? worth it

remote wasp Jun 30, 2021, 10:35 AM

#

So, just to be clear you want to:
Restrict values for type depending on type of channel the ThreadManager is on ✅
Want to divide the thread creation on manager into two methods redcross
Is that correct?

wild flax Jun 30, 2021, 10:39 AM

#

I’m against 2 methods too

#

It kinda of goes against libraries design

#

We tried so hard going in a direction where we have a nice single method style

#

Throwing that overboard seems like a bad thing here

remote wasp Jun 30, 2021, 10:41 AM

#

All right then restricting the values for type is what we are going to do

ruby terrace Jun 30, 2021, 10:42 AM

#

By all means, give a shot to making the docs more clear too, I definitely understand it being confusing but I couldn't think of a better way to document it, the warnings being my best attempt.

remote wasp Jun 30, 2021, 10:43 AM

#

meowthumbsup

sharp wigeon Jun 30, 2021, 3:09 PM

#

shouldnt locked be optional as well (typings)

strange igloo Jun 30, 2021, 3:16 PM

#

sharp wigeon

I don't remember who exactly but I recall a dev who said that setStatus Status whatever action you want must have their "status" boolean required
So here setLocked needs at least the boolean
Which means JSDoc is probably wrong instead

#

Discussion happened around MessageButton#setDisabled iirc

wild flax Jun 30, 2021, 3:23 PM

#

@oak quail in fact, both do not work:

#

Also we don't do it anywhere else in the typings lol

oak quail Jun 30, 2021, 3:25 PM

#

wild flax Jun 30, 2021, 3:25 PM

#

TS is complaining about something

#

So I expect it to be this, but even then, we don't use it anywhere else, so we shouldnt here

#

Its introducing inconsistency

oak quail Jun 30, 2021, 3:27 PM

#

hmm it worked until the latest commit which didn't even edit typings

tacit crypt Jun 30, 2021, 3:46 PM

#

Ah, this explains

wild flax Jun 30, 2021, 3:47 PM

#

yes

loud jayBOT Jun 30, 2021, 3:53 PM

#

pr_open #5980 in discordjs/discord.js by DTrombett opened 54 seconds ago (review required)
types(ThreadChannel): make locked and archived param optional
📥 npm i DTrombett/discord.js#locked-patch

zenith oracle Jun 30, 2021, 3:53 PM

#

@sharp wigeon ^^

sharp wigeon Jun 30, 2021, 3:59 PM

#

beat me to the pr 😂

wild flax Jun 30, 2021, 4:17 PM

#

@remote wasp is 5971 done

remote wasp Jun 30, 2021, 4:18 PM

#

yeah, I'll make the changes to docs in the typings PR

wild flax Jun 30, 2021, 4:18 PM

#

Please resolve conversations then

#

We can't merge if they aren't

remote wasp Jun 30, 2021, 4:19 PM

#

okay

#

done

oak quail Jun 30, 2021, 4:23 PM

#

tacit crypt Ah, this explains

🤔 shouldn't it error for me too then? are you on an older version or something

wild flax Jun 30, 2021, 4:34 PM

#

our CI is on 4.3

tacit crypt Jun 30, 2021, 4:57 PM

#

oak quail 🤔 shouldn't it error for me too then? are you on an older version or something

i'm on typescript@next

vernal atlas Jun 30, 2021, 5:51 PM

#

i can't find these conversations to resolve (#5132)

#

🤷‍♂️

solemn oyster Jun 30, 2021, 5:52 PM

#

Same

outer raven Jun 30, 2021, 8:06 PM

#

I'm waiting on #5979 to fix an issue with my bot, will it be on this night's dev release?

loud jayBOT Jun 30, 2021, 9:03 PM

#

pr_open #5979 in discordjs/discord.js by ckohen opened 9 hours ago (approved)
types(ApplicationCommandPermissionsManager): fix types
📥 npm i ckohen/discord.js#permissions-manager-types

solemn oyster Jun 30, 2021, 9:04 PM

#

Are you going to add type tests? @ruby terrace

ruby terrace Jun 30, 2021, 9:04 PM

#

want a separate PR for that or in that one?

solemn oyster Jun 30, 2021, 9:04 PM

#

idm

#

We usually include tests in the same PR that adds the code

#

Because how software is usually tested

ruby terrace Jun 30, 2021, 9:08 PM

#

okie

outer raven Jun 30, 2021, 9:33 PM

#

Will https://www.npmjs.com/package/@discordjs/collection ever be published as just "collection"? I feel like this can be used in many places other than Discord.js and it's overall a good QOL package

slate nacelle Jun 30, 2021, 9:34 PM

#

Nothing is stopping you from using it outside of discordjs DjeetaPeek

outer raven Jun 30, 2021, 9:35 PM

#

Yeah I know but the name makes it seem like it's not intended to be used outside of it. You can still do it but a better name and README would probably reach a broader audience

copper laurel Jun 30, 2021, 9:36 PM

#

I don't think anybody cares how wide an audience it reaches, and installing things from a particular organisation is very common

#

@material-ui/core, @typescript-eslint/parser are a couple of examples that come to mind

#

Besides

#

https://www.npmjs.com/package/collection

#

Name is already taken

outer raven Jun 30, 2021, 9:38 PM

#

hm yeah and it seems to be similar

#

Yeah nvm then, didn't think the name could be taken lol

zenith oracle Jul 1, 2021, 9:56 AM

#

Wouldn't it be good to have a function for hyperlinks in the builders module?

rough glacier Jul 1, 2021, 10:17 AM

#

~~and to take it one step further, it could return a HyperlinkString type acceptable only in embed description and field values~~ not worth it and perhaps impossible

solemn oyster Jul 1, 2021, 10:34 AM

#

rough glacier ~~and to take it one step further, it could return a `HyperlinkString` type acce...

... how?

#

Also, webhooks (and interactions) can send masked urls

loud jayBOT Jul 1, 2021, 10:34 AM

#

pr_open #3 in discordjs/builders by vladfrangu opened 15 hours ago (changes requested)
feat(SlashCommands): add slash command builders
📥 npm i discordjs/builders#feat/slash-commands

solemn oyster Jul 1, 2021, 10:34 AM

#

For example ^

solemn oyster Jul 1, 2021, 10:35 AM

#

zenith oracle Wouldn't it be good to have a function for hyperlinks in the `builders` module?

I could add them

#

Do you want to make the PR? Or do you not mind?

zenith oracle Jul 1, 2021, 10:50 AM

#

It's the same 👍

loud jayBOT Jul 1, 2021, 11:18 AM

#

pr_open #4 in discordjs/builders by kyranet opened 46 seconds ago (review required)
feat(Formatters): added hyperlink and maskLink
📥 npm i kyranet/builders#feat/added-escaped-link-and-masked-link

solemn oyster Jul 1, 2021, 11:18 AM

#

Done, @zenith oracle ^

zenith oracle Jul 1, 2021, 11:20 AM

#

Nice! 👍

wild flax Jul 1, 2021, 12:32 PM

#

@outer raven you’ll have to use ~ not > preferably

#

And we usually just have “no longer supported” as a message

#

Also npm deprecate is very prone to failure, so best case you should attach a || true

outer raven Jul 1, 2021, 12:40 PM

#

wild flax And we usually just have “no longer supported” as a message

I tried to find the message but they’re all set to “no” xD, will fix

#

Also what’s the difference between > and ~?

wild flax Jul 1, 2021, 12:50 PM

#

It just fails most of the time that’s what

#

Lol

#

No idea why

#

Npm isn’t giving helpful errors

ornate topaz Jul 1, 2021, 12:50 PM

#

is > even valid?

outer raven Jul 1, 2021, 1:24 PM

#

it was in the website I used to test and was in one of the examples

#

Of course I couldn't actually test the command

outer raven Jul 1, 2021, 1:25 PM

#

wild flax Also npm deprecate is very prone to failure, so best case you should attach a `|...

btw shouldn't the || true be removed from publish so that you know when it fails?

wild flax Jul 1, 2021, 1:25 PM

#

No

#

I don’t care if it fails

#

And CI being red just because a dev publish failed is kinda dumb

outer raven Jul 1, 2021, 1:26 PM

#

fair enough, will commit now

outer raven Jul 1, 2021, 5:21 PM

#

Why is there no getter for the owner of a guild in the guild object?

solemn oyster Jul 1, 2021, 5:21 PM

#

We replaced it with the more reliable fetchOwner, since intents

loud jayBOT Jul 1, 2021, 5:22 PM

#

pr_merge #5480 in discordjs/discord.js by advaith1 merged 2 months ago
feat(Guild): replace owner with fetchOwner

outer raven Jul 1, 2021, 5:22 PM

#

ahhh alright

rough glacier Jul 1, 2021, 6:26 PM

#

right now ApplicationCommandPermissionsManager#fetch() returns ApplicationCommandPermissions[] with the existing registered command permissions but it throws DiscordAPIError: Unknown application command permissions if no permissions are set, probably because that scenario is not handled. Wouldn't an empty array make more sense?

oak quail Jul 1, 2021, 7:01 PM

#

if discord throws an error shouldn't djs throw an error

rough glacier Jul 1, 2021, 7:19 PM

#

fair enough

wild flax Jul 1, 2021, 10:03 PM

#

@oak quail whats with the 2 comments from sugden, are they even still relevant

oak quail Jul 1, 2021, 10:05 PM

#

honestly idk

wild flax Jul 1, 2021, 10:05 PM

#

Oh nvm I see

#

He wants you to make a typedef

#

And link it to the discord docs

#

But they arent merged yet

oak quail Jul 1, 2021, 10:05 PM

#

yeah

wild flax Jul 1, 2021, 10:06 PM

#

Also can you confirm a thing for me, I saw MANAGE_EMOJI_AND_STICKERS somewhere thrown around

oak quail Jul 1, 2021, 10:06 PM

#

well just a link I think?

wild flax Jul 1, 2021, 10:06 PM

#

Emoji not Emojis

#

Which one is correct here

#

Thonkang

oak quail Jul 1, 2021, 10:06 PM

#

talked to Jethro for a bit

#

he said use emojis to be consistent with the old name

wild flax Jul 1, 2021, 10:06 PM

#

aight

wild flax Jul 1, 2021, 10:07 PM

#

oak quail well just a link I think?

yeah it would look like this https://github.com/discordjs/discord.js/pull/5862/files#diff-b97d4bfeac08633cd0023be34abf0cb35caf36ddf4d1d3430e944bfa858137efR329-R349

#

nothing too fancy

oak quail Jul 1, 2021, 10:07 PM

#

ah I see

#

I mean

ruby terrace Jul 1, 2021, 10:07 PM

#

isn't emoji the plural of emote though?

oak quail Jul 1, 2021, 10:07 PM

#

I can see if I can get the docs pr merged today or tomorrow

#

I wanna add the gw event tho, and test the endpoints

wild flax Jul 1, 2021, 10:08 PM

#

we can't merge stickers without the docs pr anyway, so no rush

oak quail Jul 1, 2021, 10:08 PM

#

also should I add guild sticker manager and the event to this pr? or a new one later

#

GSM shouldn't be breaking

#

but I think the intent is getting renamed bc of the new event, so that is breaking

wild flax Jul 1, 2021, 10:09 PM

#

Id say keep it in this PR

#

and just let us know when you added the stuff

#

so we know what to look at

oak quail Jul 1, 2021, 10:09 PM

#

BlobThumbsUp

zenith oracle Jul 2, 2021, 9:32 AM

#

About Typings, I think string types can be more specific. For example Channel#toString() returns string for types but it actually returns <#${bigint}>, I think it would be great to have these specific types, especially for TS users...

empty viper Jul 2, 2021, 9:56 AM

#

Maybe we should have multiple Snowflake types so ?

zenith oracle Jul 2, 2021, 9:56 AM

#

Why?

empty viper Jul 2, 2021, 9:58 AM

#

One for users, one for channels, one for roles etc

Oh I'm dumb these are not IDs, but maybe UserString, ChannelString etc ?

zenith oracle Jul 2, 2021, 9:58 AM

#

Yeah lol

#

Maybe something like ChannelMention would be better

wild flax Jul 2, 2021, 9:58 AM

#

What

#

Oh their mentions

zenith oracle Jul 2, 2021, 9:59 AM

#

Yep

empty viper Jul 2, 2021, 9:59 AM

#

Yes

#

And it could be used for Revolvers types

empty viper Jul 2, 2021, 10:00 AM

#

zenith oracle About Typings, I think string types can be more specific. For example `Channel#t...

Maybe <#${Snowflake}> no ?

zenith oracle Jul 2, 2021, 10:03 AM

#

not bad too

#

bur missing a $ lol

#

also a thing about activities

#

This is the activity of my bot logged in the console but there are some difference between this and what docs and typings show. First of all createdTimestamp is NaN and createdAt invalid date, then id is undefined while it should be a Snowflake and also presence is not documented as a property at all.

#

Debugging the data received only this is shown and there are no properties about id, createdAt etc...

#

Is this because the activity is a bot activity?

#

and should we handle the missing properties?

#

Ohh wait is this because of intents?

wild flax Jul 2, 2021, 10:32 AM

#

Enable them and check again

zenith oracle Jul 2, 2021, 10:45 AM

#

What's that

wild flax Jul 2, 2021, 10:55 AM

#

NPM being shit

zenith oracle Jul 2, 2021, 10:56 AM

#

wild flax Enable them and check again

It worked for my presence but not for the bot's presence, where the result is still the same

outer raven Jul 2, 2021, 11:30 AM

#

Will guild avatars be on the initial release of v13? I know they're not available to everyone yet but they're on the API so everyone should be able to use them with no problems

zenith oracle Jul 2, 2021, 11:31 AM

#

Iirc guild avatars are already in the Dev version

#

Oh ig the pr is not merged yet

outer raven Jul 2, 2021, 11:32 AM

#

yeah it isn't merged

#

I made it a draft because the api docs arent merged either so I assumed it would need to wait for that

#

but then again selects were merged without even a PR on the dapi docs so idrk

zenith oracle Jul 2, 2021, 11:34 AM

#

Well however it's a semver minor so I don't think they'll wait for that if v13 is ready

outer raven Jul 2, 2021, 11:34 AM

#

yeah but the PR is ready so it could just be merged even if its not out for everyone the same way it was done with selects and threads i guess

zenith oracle Jul 2, 2021, 11:34 AM

#

Same as user banners

outer raven Jul 2, 2021, 11:36 AM

#

well but banners arent on the api yet

wild flax Jul 2, 2021, 11:36 AM

#

Can’t do

#

If we merge it. We’d have to wait

#

Because things might change

outer raven Jul 2, 2021, 11:37 AM

#

if they change I think it'll only be on the user's side. The avatar is just a hash similarly to the user avatar

#

and they have been changing the user interface for guild avatars but that's it

wild flax Jul 2, 2021, 11:37 AM

#

It’s just not how we do things

#

And I don’t want this to be a reference case

#

Selects and Threads were different because we are in direct contact with those respective devs

#

And we wouldn’t release v13 without them either

outer raven Jul 2, 2021, 11:38 AM

#

Ah so you don't know when guild avatars will come?

wild flax Jul 2, 2021, 11:39 AM

#

No

outer raven Jul 2, 2021, 11:39 AM

#

alright that makes more sense

outer raven Jul 2, 2021, 12:06 PM

#

This MessageActionRowOptions interface is causing a false positive that happens when sending an array with one button/select in a message's components. Is it safe to remove or is this covering some edge case?

copper laurel Jul 2, 2021, 12:09 PM

#

dont remove it?

#

unless resolvable covers it

#

I'd rather you figured out why [button] is assignable to that

outer raven Jul 2, 2021, 12:17 PM

#

yeah I tried but I don't really know since that interface is an object with a components property so it doesn't make much sense

copper laurel Jul 2, 2021, 12:34 PM

#

I mean the answer is definitely not removing the type that supports the object format

outer raven Jul 2, 2021, 12:57 PM

#

well then in that case I have no clue how to fix it. It seems like it's completely ignoring the array part in MessageActionRowComponentResolvable

copper laurel Jul 2, 2021, 1:15 PM

#

Maybe because it's optional

#

Can you make components required and see if it still happens?

outer raven Jul 2, 2021, 1:20 PM

#

copper laurel Can you make components required and see if it still happens?

that does fix it but i wonder if it breaks anything else

#

but it makes sense that MessageActionRowOptions would require components so I guess that's the fix

zenith oracle Jul 2, 2021, 1:30 PM

#

MessageActionRowOptions should be like a MessageActionRow without needing to instantiate the class but a MessageActionRow always has a components property, which is an empty array by default.

#

The problem is that MessageActionRowOptions is the parameter to create a MessageActionRow too, that, as I said, doesn't require to set the components property as it's an empty array by default and that's why that components property is optional

outer raven Jul 2, 2021, 1:33 PM

#

well it's used in the constructor but if you're constructing an action row like that you need to specify some components, otherwise it's a pointless row

zenith oracle Jul 2, 2021, 1:35 PM

#

You can always add components later with .addComponents

outer raven Jul 2, 2021, 1:36 PM

#

yeah but if you're doing that then you'd just not pass a data object

#

and that is still fine because data is marked as optional

zenith oracle Jul 2, 2021, 1:38 PM

#

Making that required means that these are accepted:

new MessageActionRow ();
new MessageActionRow({ components: new MessageButton() });

But not these:

new MessageActionRow({});
message.channel.send({ content, components: [new MessageButton()] })

Which is completely fine in my opinion

zenith oracle Jul 2, 2021, 1:38 PM

#

outer raven and that is still fine because data is marked as optional

Yeah right

#

Maybe this should be tested a bit more but I think this is the correct solution

outer raven Jul 2, 2021, 1:39 PM

#

yeah those are the only scenarios where this interface is used so i think its fine

#

great now i cant commit 😐

zenith oracle Jul 2, 2021, 1:40 PM

#

Oof

outer raven Jul 2, 2021, 1:41 PM

#

got it in another way no worries

loud jayBOT Jul 2, 2021, 1:52 PM

#

pr_open #6005 in discordjs/discord.js by ImRodry opened 6 minutes ago (review required)
types(MessageOptions): fix components being optional
📥 npm i ImRodry/discord.js#fix-components-type

outer raven Jul 2, 2021, 1:52 PM

#

there we go

zenith oracle Jul 2, 2021, 2:02 PM

#

👍

#

Whoops sorry, this should be an array

outer raven Jul 2, 2021, 2:11 PM

#

oh

#

btw @zenith oracle I meant sorting them alphabetically within the region, not within those 4 types

zenith oracle Jul 2, 2021, 2:14 PM

#

Uhm yeah makes sense...

#

Should be done. However there are a lot of types without lines and not sorted between the region, but yeah, I think it's better to sort them for consistency

outer raven Jul 2, 2021, 2:38 PM

#

zenith oracle Should be done. However there are a lot of types without lines and not sorted be...

if you want you can probably add those lines, doesn't rly justify a separate PR imo if you're literally just adding empty lines

#

Why was this removed from README in master?

tacit crypt Jul 2, 2021, 2:46 PM

#

Probably cause it was either super redundant or super broken

wild flax Jul 2, 2021, 3:37 PM

#

Took too much space

#

For no reason

outer raven Jul 2, 2021, 9:32 PM

#

is anyone able to re-run the CI on https://github.com/discordjs/discord.js/pull/6005 ? I think it got stuck

tacit crypt Jul 2, 2021, 9:35 PM

#

Done

outer raven Jul 2, 2021, 9:38 PM

#

ty

oak quail Jul 3, 2021, 2:32 AM

#

@ruby terrace if a thread is archived when the bot starts, it does not get cached (if it is unarchived) until the bot is restarted

oak quail Jul 3, 2021, 3:06 AM

#

ThreadChannel#sendable is incorrect: it returns true even if it is a private thread that the bot isn't in and the bot doesn't have manage threads

#

there prob should just be a helper property that returns whether the bot is in the thread

ruby terrace Jul 3, 2021, 3:30 AM

#

….how do you have that thread in cache then?

ruby terrace Jul 3, 2021, 3:30 AM

#

oak quail <@!140214425276776449> if a thread is archived when the bot starts, it does not ...

I think I did .add on the wrong manager probably, is it in any of the caches? (My hunch is that it’s only in the .threads cache)

#

Or actually, not, because that’s not how that .add works

#

I’ll look into it in a bit

oak quail Jul 3, 2021, 3:40 AM

#

ruby terrace I think I did .add on the wrong manager probably, is it in any of the caches? (M...

not sure but its not in the channel cache

oak quail Jul 3, 2021, 3:41 AM

#

ruby terrace ….how do you have that thread in cache then?

the channel stays cached if the bot was in it earlier

#

if the bot wasnt in it after starting then interaction.channel is null

ruby terrace Jul 3, 2021, 3:45 AM

#

oak quail the channel stays cached if the bot was in it earlier

Oh, didn’t consider being removed. (Can you tell I ddi most of my testing before permissions were released lol)

#

I’ll definitely add a getter

oak quail Jul 3, 2021, 3:45 AM

#

tbh i might ask them to just add bots to the thread when a slash command is used

#

at least for private threads

#

the bot can just add itself by pinging itself but its annoying to handle

ruby terrace Jul 3, 2021, 3:47 AM

#

That does kinda make sense, if bot exists in guild add it, don’t know if it’s work for very old bots though (where client is is not the same as application

oak quail Jul 3, 2021, 3:47 AM

#

im sure they can make it work bloblul

#

they have it working in dms

#

with /applications/bots/:id or whatever

ruby terrace Jul 3, 2021, 3:47 AM

#

Oh true

#

I’ll still fix that perm check though

oak quail Jul 3, 2021, 4:56 AM

#

why does Formatters.time use Math.floor instead of Math.round?

solemn oyster Jul 3, 2021, 6:26 AM

#

oak quail why does Formatters.time use Math.floor instead of Math.round?

I was considering using Math.trunc tbh

#

But at the end of the day, it matters nothing because Discord's time syntax isn't precise

ruby terrace Jul 3, 2021, 7:34 AM

#

oak quail <@!140214425276776449> if a thread is archived when the bot starts, it does not ...

Looking at this, this probably happens with normal channels too, but you wouldn't ever encounter it unless you manually removed channels from cache

ruby terrace Jul 3, 2021, 8:41 AM

#

All fixed here

loud jayBOT Jul 3, 2021, 8:41 AM

#

pr_open #6015 in discordjs/discord.js by ckohen opened 19 seconds ago (review required)
fix: correct permissions checks and cache on update
📥 npm i ckohen/discord.js#threads-fixup-2

outer raven Jul 3, 2021, 2:04 PM

#

Can we get a release since there were many breaking changes in the recent commits?

quiet viper Jul 3, 2021, 2:53 PM

#

Is Custom Caching planned in Discord-next?

loud jayBOT Jul 3, 2021, 2:59 PM

#

pr_open #6013 in discordjs/discord.js by 1Computer1 opened 13 hours ago (changes requested)
feat(Managers): add customizable caching for managers
📥 npm i 1Computer1/discord.js#cachedi

outer raven Jul 3, 2021, 3:00 PM

#

think this is what this PR is trying to achieve

quiet viper Jul 3, 2021, 3:12 PM

#

outer raven think this is what this PR is trying to achieve

it currently just have cacheManaging for Messages and Presences,is custom prop caching in plan?

outer raven Jul 3, 2021, 3:12 PM

#

im not sure I didn't look much into it, you can see the PR yourself

wild flax Jul 3, 2021, 3:13 PM

#

Not sure what you mean by “custom prop caching”

quiet viper Jul 3, 2021, 3:14 PM

#

wild flax Not sure what you mean by “custom prop caching”

custom property caching, cache just ids and names, but not colors or....

wild flax Jul 3, 2021, 3:14 PM

#

Unlikely

#

Not anytime soon

#

This would require a heavy rewrite

quiet viper Jul 3, 2021, 3:16 PM

#

wild flax This would require a heavy rewrite

and discord.js-next, they are doing the rewrite right?

wild flax Jul 3, 2021, 3:16 PM

#

That’s still very far into the future

#

I can’t say anything specific about it yet

real jetty Jul 3, 2021, 4:32 PM

#

Some properties of the Client class are nullable because instanciated only after the call to the "login" function or there is other reason ?

outer raven Jul 3, 2021, 4:32 PM

#

there could be multiple reasons, depends on what you're talking about

real jetty Jul 3, 2021, 4:43 PM

#

For example "user".
If the Client class has no use without the login function (for the moment I haven't seen any without calling the login function) maybe it would be interesting to make a static function mixing the arguments of the constructor and the arguments of the login function so that some properties are no longer indicated as "nullable" (the user property for)

outer raven Jul 3, 2021, 4:44 PM

#

not sure if that's possible but if you know how to then you can open a PR. The only reason that's nullable is because of the login indeed

real jetty Jul 3, 2021, 4:46 PM

#

I'm not at home, but if this is the only reason, then creating a static method that does both would surely be the best solution.
I'll see if I can make a PR as soon as I get back from vacations

zenith oracle Jul 3, 2021, 4:56 PM

#

What should this method do?

#

Like a isLogged()?

#

And if so what should be return value?

real jetty Jul 3, 2021, 5:07 PM

#

I don't know what to call it but it could be a method named "createInstance(options)". The "options" argument would be the same as the current constructor with the addition of the "token" property which would be mandatory.
Within this function, we would do what the login function does and then we would call the constructor of the class (from now on "private") passing it all the information to create an instance of the Client class which would contain directly the "user" properties (and the other properties depending on the login class).
It is this instance that the static function would return.

To create an instance, users will have to do :
const client = Client.createInstance({ intents: [....], token: "...." })

#

I don't know if I'm clear or even if it's possible (haven't looked at the code of the client class yet) but if it is, it can be a better method. It would avoid some properties to be nullable

strange igloo Jul 3, 2021, 5:13 PM

#

You may want to instantiate a client, but not to login yet (probably to pass your instance reference to your own structures).

This looks more like unsolvable typings issues as this would require TypeScript/your IDE to detect whether Client#login resolved at that particular point of your code, which is likely not possible due to way of code is analyzed and also because that method can fail (invalid token).

You can still "extend" the typings to force certain properties to exist, make a method that would instantiate + login and return that freshly logged in client as that extended type.

real jetty Jul 3, 2021, 5:20 PM

#

You may want to instantiate a client, but not to login yet (probably to pass your instance reference to your own structures).

In this case it is necessary to keep a separate login method but in the opposite case (use of the Client class only after a call to the login method) I don't think it is useful and using a static method will resolved this "unsolvable typings issues". In fact, I have not seen anyone using the Client class without having called the login class 🤷

You can still "extend" the typings to force certain properties to exist, make a method that would instantiate + login and return that freshly logged in client as that extended type.
This is what I do actually. but I thought that if everyone called the login method before doing anything with the client instance the static function was better suited for typing

vivid field Jul 3, 2021, 5:22 PM

#

But the login method is asynchronous, so unless everyone switches to esm to make use of top-level await I think hardly anyone will use that static method

neat bolt Jul 3, 2021, 5:26 PM

#

quiet viper it currently just have cacheManaging for Messages and Presences,is custom prop c...

the makeCache option supports changing cache based on manager class name and hold class name
so you can customize all the caches

#

you cannot customize properties

real jetty Jul 3, 2021, 5:29 PM

#

vivid field But the login method is asynchronous, so unless everyone switches to esm to make...

Hummm if the only way to login is this static method they will use it, no ?

quiet viper Jul 3, 2021, 5:30 PM

#

neat bolt you cannot customize properties

but yeah, thats the problem, you often just need the guild id and not the guild name, guild features, banner url, splashurl.... They are rarely used.

neat bolt Jul 3, 2021, 5:30 PM

#

not doable currently

#

and maybe never

vivid field Jul 3, 2021, 5:30 PM

#

So what do you expect users to do?

Client.createInstance(...).then(client => {
  client.on('interactionCreate', ...)
});
```isn't really good user experience

quiet viper Jul 3, 2021, 5:33 PM

#

neat bolt and maybe never

yeah, I played a little bit around with the Library. Disabled all caches and added custom property caching and setted the properties to null, which should be removed.
But the key uses itself memory, so it did not had so a big effect.

The only solution would be do modify the internal Classes, through deleting some keys, when caching them. But I think this will never happen, bc there will be a lot of breaking changes....

neat bolt Jul 3, 2021, 5:34 PM

#

that'll save you like 5 megabytes

#

dont bother meguFace

quiet viper Jul 3, 2021, 5:35 PM

#

neat bolt that'll save you like 5 megabytes

10mb on 140k channels, when setting 60% of the properties to null

#

you have to delete the key itself

neat bolt Jul 3, 2021, 5:35 PM

#

you buy ram in multiples of 4gb

#

you know that right

real jetty Jul 3, 2021, 5:36 PM

#

vivid field So what do you expect users to do? ```js Client.createInstance(...).then(client ...

Yeah, I don't really see what it changes since, currently, you have to call the login method before you can receive the events.

Actually we do

const client = new Client(.....);
client.on(........)
client.login(token)

With the static we will have

const client = await Client.createInstance(....)
client.on(.......)

vivid field Jul 3, 2021, 5:37 PM

#

If you're able to use await in that context, sure

#

But you aren't in 99% of examples

quiet viper Jul 3, 2021, 5:37 PM

#

neat bolt you know that right

I am a minimalistic Person

neat bolt Jul 3, 2021, 5:37 PM

#

removing keys will turn that into 795mb

#

not worth

strange igloo Jul 3, 2021, 5:38 PM

#

node does not support top-level-await yet, will it even do at some point lol
so you'd need to wrap this into an self-called async function

vivid field Jul 3, 2021, 5:38 PM

#

It does when using ESM

#

And commonjs will never have it

strange igloo Jul 3, 2021, 5:39 PM

#

Oh right

quiet viper Jul 3, 2021, 5:39 PM

#

neat bolt removing keys will turn that into 795mb

I just cache Guilds and Roles |channels and emojis, members, precences are not cached

quiet viper Jul 3, 2021, 5:39 PM

#

neat bolt removing keys will turn that into 795mb

removing the keys changes it to 400mb , setting them to null uses 700mb

real jetty Jul 3, 2021, 5:42 PM

#

vivid field But you aren't in 99% of examples

Indeed, this can be a problem and the use of "then" can be disturbing
After if you find it disturbing we can stay like that

unique axle Jul 3, 2021, 5:44 PM

#

nkoHmm is this just so you don't have to put a ! after Client#user to assure it's there after login?

real jetty Jul 3, 2021, 5:45 PM

#

unique axle <:nkoHmm:585927115011129505> is this just so you don't have to put a `!` after C...

Indeed it is to avoid some properties to be marked as nullable 😂
If the majority prefers the current method to the method of the static function we keep the current method.

unique axle Jul 3, 2021, 5:50 PM

#

if you know they're not null at a certain point, just assert nkoHmm
to keep with the example
Client#user will never be null in any event callback, so you just assert it to not be null and move on with your life

zenith oracle Jul 3, 2021, 6:14 PM

#

Uh what about making an interface LoggedClient which is just an extension of Client with properties like user not nullable so that we can use a function isX() (like isText() for channels) which returns this is LoggedClient

bitter peak Jul 3, 2021, 6:44 PM

#

vivid field If you're able to use await in that context, sure

Many projects I know of use a top level async function, immediate async function, or custom classes/methods to handle awaiting on client login. Passing a logged in client to such custom classes would not be an issue

ruby terrace Jul 3, 2021, 8:04 PM

#

quiet viper yeah, I played a little bit around with the Library. Disabled all caches and add...

With the custom caching you could technically make a collection that auto removed the properties you don’t want. I highly recommend against doing this however, it seems like a lot of extra overhead for not much gain. You’d be much better off using intents to reduce the amount of events received (inherently reducing cache size) and after that PR adding noop caches to the things you still get and don’t want to cache.

quiet viper Jul 3, 2021, 8:10 PM

#

ruby terrace With the custom caching you could technically make a collection that auto remove...

yeah, that was my Idea, I did it for the ChannelCache and it works fine.
It saves the Discord Rawdata, where some keys will be deleted and sets them in a map and when the get function is called it refills the object with a example Data-set and transforms it to a Discord.js Structure.

ruby terrace Jul 3, 2021, 8:11 PM

#

That's perfectly fine to do, just know you won't get much support here doing it that way

quiet viper Jul 3, 2021, 8:15 PM

#

ruby terrace That's perfectly fine to do, just know you won't get much support here doing it ...

ik, it breaks some discord.js functionalities, some api methods requires some more data than just a Id

outer raven Jul 3, 2021, 11:39 PM

#

@wild flax since im not adding a function, what exactly do I need to test? https://github.com/discordjs/builders/pull/5#pullrequestreview-698625375

wild flax Jul 3, 2021, 11:40 PM

#

just making sure they return what they should return

outer raven Jul 3, 2021, 11:40 PM

#

that wasn't done for TimestampStyles though ?

wild flax Jul 3, 2021, 11:42 PM

#

But we are losing 6.67% coverage if we don't

outer raven Jul 3, 2021, 11:47 PM

#

I have no clue how to work with jest, specially when not using functions, are there docs that I can check or something?

copper laurel Jul 3, 2021, 11:48 PM

#

would it just be expect(Faces.Shrug).toBe('¯\\_(ツ)_/¯')

outer raven Jul 3, 2021, 11:49 PM

#

but what do I put in the test function?

#

the string that is

oak quail Jul 4, 2021, 5:51 AM

#

https://advaith.is-in-hyper.space/d617ac5fce.png

#

is options supposed to be optional

#

ig it technically works as a fetch

remote wasp Jul 4, 2021, 6:48 AM

#

why is it marked optional when the options param for MessagePayload#create is required? thinkO___O

oak quail Jul 4, 2021, 10:04 AM

#

https://advaith.is-in-hyper.space/7015dc2157.png

#

isnt this type (FileOptions[]|BufferResolvable[]|MessageAttachment[]) kinda misleading

#

(in BaseMessageOptions)

#

#

each file is resolved individually

copper laurel Jul 4, 2021, 10:47 AM

#

yeah theres been a few union types like that to be fixed

oak quail Jul 4, 2021, 11:00 AM

#

in APIRequest.make():

      body = new FormData();
      for (const file of this.options.files) if (file && file.file) body.append(file.name, file.file, file.name);
      if (typeof this.options.data !== 'undefined') body.append('payload_json', JSON.stringify(this.options.data));

#

should i add a dontUsePayloadJSON field to override it and add each data field separately

#

or just abuse files instead of using data

copper laurel Jul 4, 2021, 11:38 AM

#

Isn't it fine how it is? I thought you were just changing a docstring

oak quail Jul 4, 2021, 11:43 AM

#

no this is for stickers impl

#

the docs thing is just something i noticed lol

#

anyway ive been working on it and

#

trying to force it into files is way too much trouble ```js
DiscordAPIError: The browser (or proxy) sent a request that this server could not understand.

quiet viper Jul 4, 2021, 3:32 PM

#

Okay, I tested the new CacheFactory/Cache Manager
and what I can say that they are some Problems, which should be fixed.

When capping the Collections to a specific limit, some Problems are created
In less words: You wont receive Events for the uncached Structures

I capped the cache of the ChannelManager to 10
This caused, that I didnt recieve this Events:

MessageCreate
ChannelUpdate
-> Nearly every Channel related Event, which requires the Cache...
When uncapping the Collection or trying it on a cached Structure, you receive the Events as usual.

raven juniper Jul 4, 2021, 5:02 PM

#

it's generally not recommended to limit the guild or channel cache because of how d.js works

#

keeping them cached is not heavy on memory usage, that's stuff like messages/presences/etc

stray delta Jul 4, 2021, 5:14 PM

#

Not receiving events for uncached structures is definitely intended, which is also why partials exist

wild flax Jul 4, 2021, 6:03 PM

#

@outer raven Uniform Resource Locator (URL)

#

Identifier (Id)

outer raven Jul 4, 2021, 6:08 PM

#

ahhh

#

right that makes sense

#

Wait but Discord uses ID

wild flax Jul 4, 2021, 6:12 PM

#

Yeah for Interfaces and user facing text it’s probably better

outer raven Jul 4, 2021, 6:13 PM

#

Discord's API docs also use a mixture of ID and id but never Id from what i can see

quiet viper Jul 4, 2021, 6:13 PM

#

stray delta Not receiving events for uncached structures is definitely intended, which is al...

Enabled all Partials , but not receiving the Events, when the Collection is capped. When uncapped => works

const {token} = require('./config.json')
const Discord = require('discord.js');
const client = new Discord.Client({
  intents: ["GUILDS","GUILD_MESSAGES", "GUILD_MESSAGE_REACTIONS"],
  partials: ['MESSAGE', 'CHANNEL', 'REACTION', 'USER', 'GUILD_MEMBER'] ,
    makeCache: Discord.Options.cacheWithLimits({
        ChannelManager: 1, // 
    }),
});

client.on('ready', ()=>{
  console.log(client.channels.cache.size)
})

client.on('messageCreate', (message) => {console.log(message.channel)})
client.login(token);

wild flax Jul 4, 2021, 6:13 PM

#

It’s not like we orientate our code standard based on discord’s :P

outer raven Jul 4, 2021, 6:14 PM

#

thought you did ¯_(ツ)_/¯

wild flax Jul 4, 2021, 6:15 PM

#

Hell naw

#

We don’t even know what they use internally

#

And we surely won’t start using snake case just because their API is in python/flask

#

OMEGALUL

outer raven Jul 4, 2021, 6:17 PM

#

yeah thats true but I think the public stuff should serve as reference
And you still based your names based off of theirs for example I asked for ephemeral (which is the worse name they've come up with) to be changed and I was told it wouldn't because that's what Discord uses

solemn oyster Jul 4, 2021, 6:17 PM

#

(btw Rodry, I updated my comment about URL's casing)

outer raven Jul 4, 2021, 6:18 PM

#

ah I didn't see it, lemme look

#

I see but why is that the case on that specific scenario?

#

like for example, doesn't displayAvatarURL fall under the "joined with other words" category?

#

or does that only apply to interfaces and classes

#

@solemn oyster ^^

solemn oyster Jul 4, 2021, 6:21 PM

#

I'm a bit mixed in that regard

#

I agree displayAvatarURL looks good, the problem comes when it's an <Acronym><Word>, like URLIdentifier

outer raven Jul 4, 2021, 6:22 PM

#

is that used anywhere? Never seen it

solemn oyster Jul 4, 2021, 6:22 PM

#

Either way it's a different issue, and 6036 will exclusively change the casing of ID, and nothing else

#

It's an example

outer raven Jul 4, 2021, 6:23 PM

#

ah I see

solemn oyster Jul 4, 2021, 6:23 PM

#

There's StaticImageURLOptions tho

#

And Guild#vanityURLUses

outer raven Jul 4, 2021, 6:23 PM

#

tbh im not against nor in favor of this change, it just seems like something so small that's gonna require so many changes that it's barely worth it imo

solemn oyster Jul 4, 2021, 6:24 PM

#

The URL or the ID one?

outer raven Jul 4, 2021, 6:24 PM

#

ID

solemn oyster Jul 4, 2021, 6:25 PM

#

If you ask me, this was the best moment to do it

#

We haven't been below 15 PRs for 3 years or so, and we had plans to change ID to Id with the TypeScript rewrite

#

Tracking the breaking changes in the TS rewrite with that mixed in... ablobsweats

outer raven Jul 4, 2021, 6:26 PM

#

ah well in that case then yeah sure

#

and this change isn't as controversial as structures (which tbh i was surprised with the backlash, i didn't even know they existed) but yeah if you were planning on doing this anyway, v13 is the best time to do so

#

We're getting closer to the release right? I saw some pinned issues be closed the other day so i thought it could be near 👀

solemn oyster Jul 4, 2021, 6:27 PM

#

We'll probably link this comment if somebody complains about the [Structures] change https://github.com/discordjs/discord.js/issues/6039#issuecomment-873621116

outer raven Jul 4, 2021, 6:27 PM

#

christ that's huge, lemme look

stray delta Jul 4, 2021, 6:43 PM

#

quiet viper Enabled all Partials , but not receiving the Events, when the Collection is capp...

I guess message partials are more unique, you need the channel cached in order to even get them

rough roost Jul 4, 2021, 6:45 PM

#

imo URL should be changed along with ID, both are always spelled in uppercase, one being an acronym doesn't seem that relevant

#

google style guide for java/js specifies it should be userId, iconUrl

quiet viper Jul 4, 2021, 6:45 PM

#

stray delta I guess message partials are more unique, you **need** the channel cached in ord...

yeah, that means that the new Cache Manager is nearly useless. (Except on Messages & Precenses)

wild flax Jul 4, 2021, 6:46 PM

#

It's not really

#

Your case is just obscenely obscure

#

Because at this point why do you even use a library at all?

quiet viper Jul 4, 2021, 6:51 PM

#

wild flax Your case is just obscenely obscure

sorry, when I sound rude.
But could I/someone do a Pull Request on the Guide and make a big Note, that Capping Channels, Roles, Guilds will break the whole Library?

wild flax Jul 4, 2021, 6:53 PM

#

We already have this issue pinned: https://github.com/discordjs/discord.js/issues/3924

#

It could probably be extended to mention caches

stray delta Jul 4, 2021, 6:56 PM

#

Is there going to be an alternative explanation for what to use in place of structures? Seems like there's going to be a lot more complaints

neat bolt Jul 4, 2021, 7:00 PM

#

my PR has what's recommended
otherwise, defineProperty

sharp wigeon Jul 4, 2021, 7:18 PM

#

Is there a reason why to the xID is being changed

#

I mean obviously there is lol

sly ridge Jul 4, 2021, 7:18 PM

#

https://github.com/discordjs/discord.js/issues/3924#issuecomment-656429545

Are there any proposals in this comment that have not been made?

outer raven Jul 4, 2021, 7:22 PM

#

customId and options shouldn't be optional, any reason why they are marked as such here?

wild flax Jul 4, 2021, 7:23 PM

#

sly ridge https://github.com/discordjs/discord.js/issues/3924#issuecomment-656429545 Are ...

If anything the first point.

sly ridge Jul 4, 2021, 7:27 PM

#

quiet viper sorry, when I sound rude. But could I/someone do a Pull Request on the Guide and...

I think this is better, I don't know if it would be possible but something like this in the documentation specifying in each event which intent and cache is required and necessary to work would be great

sly ridge Jul 4, 2021, 7:39 PM

#

wild flax If anything the first point.

I'm thinking of doing that and making a pr, but I'm not sure whether to add something like <info> This event requires the GUILD_MEMBERS intent.</info> or just add it to the jsdoc description without <info>

zenith oracle Jul 4, 2021, 8:11 PM

#

outer raven customId and options shouldn't be optional, any reason why they are marked as su...

Because it's used in the constructor of MessageSelectMenu where you don't need to set all the properties. You can set something in the constructor and then use method later to assign other properties

outer raven Jul 4, 2021, 8:12 PM

#

ah true I guess, but then the docs become misleading on the typedef

copper laurel Jul 4, 2021, 10:26 PM

#

Docs dont need to perfectly represent the types

#

Those structures will probably move to /builders anyway

bitter peak Jul 5, 2021, 12:57 AM

#

Would conditional nulling types be beneficial? If so, I could open a pull request...

copper laurel Jul 5, 2021, 1:03 AM

#

Definitely could be, though that seems like a huge undertaking to apply across the lib

#

I can find docs on the Ternary type modifier, do you have information for it?

bitter peak Jul 5, 2021, 1:16 AM

#

copper laurel I can find docs on the Ternary type modifier, do you have information for it?

Ah, right, sorry. That's custom. Here's the impl:

/**
 * Conditional typing extension helper.
 *
 * 1. If `T extends SUPERTRUTHY`, then `TRUTHY`
 *
 * 2. If `T extends SUPERFALSY`, then `FALSY`
 *
 * 3. Else `FALLBACK`
 */
export type ExtendConditional<T, SUPERTRUTHY, TRUTHY, SUPERFALSY, FALSY, FALLBACK = never> = T extends SUPERTRUTHY
  ? TRUTHY
  : T extends SUPERFALSY
  ? FALSY
  : FALLBACK;

/**
 * Ternary helper function for typing.
 */
export type Ternary<FLAG extends boolean, TRUTHY, FALSY> = ExtendConditional<FLAG, true, TRUTHY, false, FALSY>;

#

Could be changed around, etc. to be easier to include in djs

bitter peak Jul 5, 2021, 1:23 AM

#

real jetty Yeah, I don't really see what it changes since, currently, you have to call the ...

Would also resolve issues such as this, by defining type Client<LOGGED_IN> = Ternary<LOGGED_IN, LoggedInClient, BaseClient>, etc.

ornate topaz Jul 5, 2021, 1:24 AM

#

! solves that as well

copper laurel Jul 5, 2021, 1:24 AM

#

I mean there's some styling inconsistencies here but that's easily fixed, I think this is more about if we would want to do this in the current version (which is just JS + a typings file) vs leaving it for the TypeScript rewrite

copper laurel Jul 5, 2021, 1:24 AM

#

ornate topaz `!` solves that as well

no, bad

ornate topaz Jul 5, 2021, 1:25 AM

#

client.user will be there in the events though (obviously assuming that there is client at all, but in such case it would never be there anyway)

copper laurel Jul 5, 2021, 1:25 AM

#

optional chaining is preferred over not-null assertions

bitter peak Jul 5, 2021, 1:26 AM

#

copper laurel I mean there's some styling inconsistencies here but that's easily fixed, I thin...

I'm new to this project; what's the plan for a ts rewrite?

copper laurel Jul 5, 2021, 1:26 AM

#

https://github.com/discordjs/discord.js-modules

#

Modular, written in TypeScript

bitter peak Jul 5, 2021, 1:27 AM

#

Ah I see

bitter peak Jul 5, 2021, 1:42 AM

#

@copper laurel What about something like this?

type Ternary<V extends boolean, T, F> = V extends true ? T : V extends false ? F : never;
type Nullify<T> = { [P in keyof T]: null };
type ConditionallyNull<T, V extends boolean = boolean> = Ternary<V, T, Nullify<T>>;

class BaseClient {
  foo: number;
}

interface LoggedInClient {
  user: object;
}

export type Client<LoggedIn extends boolean = boolean> = BaseClient & ConditionallyNull<LoggedInClient, LoggedIn>;

copper laurel Jul 5, 2021, 1:43 AM

#

LoggedIn extends boolean would match our casing conventions unless theres a need for that format?

#

Otherwise yeah that looks in line with our style

bitter peak Jul 5, 2021, 1:44 AM

#

no = boolean?

copper laurel Jul 5, 2021, 1:44 AM

#

Oh yeah thats fine

#

I'm only picking on styling, not functionality

#

@wild flax @tacit crypt @slate nacelle @solemn oyster is this sort of conditional typing something you want to go for?

#

Probably also @neat bolt because typings wizardry

neat bolt Jul 5, 2021, 1:57 AM

#

is this the thing where you do the thing

#

with the null stuff after login

#

i'd rather just this if at all

class Client<LoggedIn extends boolean> {
  always: number;
  sometimes: LoggedIn extends true ? number : null;
}

bitter peak Jul 5, 2021, 2:21 AM

#

neat bolt with the null stuff after login

also would apply to a lot of other objects as well such as messages (guild/dm) and interactions (guild/dm)

neat bolt Jul 5, 2021, 6:16 AM

#

seems like theres two different proposals here then

a generic that changes the type based on the state of the object in time
a generic that chooses which variant of some concept to use
im ok with the former, though it will require very careful consideration that the typestate is valid
im against the latter, those should just be two separate declarations, or if applicable, inheritance
its just error prone due to the type machinery you have to do, bad for documentation for similar reasons, and is just laziness over explicitness for not much gain

#

@bitter peak @copper laurel

tacit crypt Jul 5, 2021, 6:38 AM

#

neat bolt i'd rather just this if at all ```ts class Client<LoggedIn extends boolean> { ...

This is how prisma does some of its typings, especially related to rejectOnNotFound. We could possibly look into that maybe?

neat bolt Jul 5, 2021, 6:39 AM

#

above comment yeptune

vernal charm Jul 5, 2021, 12:12 PM

#

Question: If in https://discord.com/developers/docs/resources/user there is a way to get the nitro subscription, why don't you put it in user object? Or it isn't possible?

outer magnet Jul 5, 2021, 12:13 PM

#

isn't interaction.guildID just a shortcut method for interaction.guild.id?

strange igloo Jul 5, 2021, 12:13 PM

#

vernal charm Question: If in https://discord.com/developers/docs/resources/user there is a wa...

That property is only provided through OAuth2, not to regular bots
Which is why discord.js does not support it

outer magnet Jul 5, 2021, 12:13 PM

#

Coz if so, i dont see why it would be needed

vernal charm Jul 5, 2021, 12:13 PM

#

strange igloo That property is only provided through OAuth2, not to regular bots Which is why ...

Ah alr thanks

strange igloo Jul 5, 2021, 12:14 PM

#

outer magnet isn't `interaction.guildID` just a shortcut method for `interaction.guild.id`?

Interaction#guildID is a property that holds the interaction guild ID
Interaction#guild is a getter that relies on the first property (equivalent to <Client>.guilds.resolve(<Interaction>.guildID)

#

The two properties exist because you may get a guild interaction from an uncached guild
Leading guildID to hold the correct guild ID... but guild to be null
Should not happen as long as the client user is in the target guild, and you enabled the GUILDS intent, and not messing with cache but you shouldn't do it in anyway

outer magnet Jul 5, 2021, 12:17 PM

#

ah i see

vernal charm Jul 5, 2021, 12:17 PM

#

vernal charm Ah alr thanks

In OAuth2 that isn't very useful, at least in my opinion. If I was discord I would add it to the api it self not to OAuth2

outer magnet Jul 5, 2021, 12:17 PM

#

thanks fot the explanation

strange igloo Jul 5, 2021, 12:19 PM

#

vernal charm In OAuth2 that isn't very useful, at least in my opinion. If I was discord I wou...

They purposefully did it so we can't get that information without explicit consent from the user
OAuth2 requires the target user to say "Yes I want to give my profile information to that thing" while regular API doesn't
It won't happen, at least not in a near future, it already took a while for badges & co. to be available to bots

The original reason was to prevent "nitro-only" features that would break equality between regular and Nitro users for non-Discord related stuff

vernal charm Jul 5, 2021, 12:20 PM

#

strange igloo They purposefully did it so we can't get that information without explicit conse...

I see, thanks for your detailed explanation in this topic.

outer raven Jul 5, 2021, 12:28 PM

#

I know this change was made long ago but why don't ClientUser#setActivity , ClientUser#setAFK, ClientUser#setPresence and ClientUser#setStatus return promises anymore?

strange igloo Jul 5, 2021, 12:29 PM

#

Because they are gateway commands and I don't think there is anything async in these

wild flax Jul 5, 2021, 12:30 PM

#

^

outer raven Jul 5, 2021, 12:30 PM

#

Maybe that should be mentioned in the v13 changes guide?

copper laurel Jul 5, 2021, 12:32 PM

#

It is

#

Unless you mean the why?

fickle burrow Jul 5, 2021, 12:36 PM

#

wait i'm confused
would't the custom / commands be a thing at v13 ?
if so why do i already see /commands at the https://discord.js.org/#/ and in the server here aswell ?

not sure if this is the right channel

outer raven Jul 5, 2021, 12:37 PM

#

copper laurel Unless you mean the why?

yeah thats what i mean

wild flax Jul 5, 2021, 12:37 PM

#

I don't think anyone benefits from knowing "why" is isnt a promise anymore

outer raven Jul 5, 2021, 12:37 PM

#

Some people might be interested

outer raven Jul 5, 2021, 12:38 PM

#

fickle burrow wait i'm confused would't the custom `/` commands be a thing at v13 ? if so why ...

yeah idk where that comes from but it won't be incorrect for too long I think

strange igloo Jul 5, 2021, 12:38 PM

#

fickle burrow wait i'm confused would't the custom `/` commands be a thing at v13 ? if so why ...

Because the home page has been updated ahead of 13.0 release (since the documentation revamp)
And some bots here use the development version

outer raven Jul 5, 2021, 12:39 PM

#

Is this still true? (v13 changes guide)

fickle burrow Jul 5, 2021, 12:39 PM

#

strange igloo Because the home page has been updated ahead of 13.0 release (since the document...

wierd, wonder why, anyways thx

strange igloo Jul 5, 2021, 12:40 PM

#

outer raven Is this still true? (v13 changes guide)

Looks like it falls back to a function always returning true
https://github.com/discordjs/discord.js/blob/master/src/structures/interfaces/Collector.js#L46

outer raven Jul 5, 2021, 12:43 PM

#

yeah so it wouldn't return a type error since the whole point of moving the filter to the options object was to make it optional right?

nocturne glen Jul 5, 2021, 3:37 PM

#

Hello fellow developers OMEGAlul
If I want to contribute to developing discord.js, where should I start?

zenith oracle Jul 5, 2021, 3:41 PM

#

Probably here https://github.com/discordjs/discord.js/blob/master/.github/CONTRIBUTING.md

nocturne glen Jul 5, 2021, 3:43 PM

#

🙏

broken abyss Jul 5, 2021, 4:06 PM

#

Since Structures are removed from djs v13, how can I get the raw API response data (e.g. guild avatar for GuildMember) from Discord API?

unique axle Jul 5, 2021, 4:07 PM

#

by waiting for guild avatars to be merged

wild flax Jul 5, 2021, 4:08 PM

#

OMEGALUL

#

or just use client.api or something

broken abyss Jul 5, 2021, 4:09 PM

#

wild flax or just use client.api or something

Thanks, I just needed a direction to extend.

wild flax Jul 5, 2021, 4:09 PM

#

oh, thats not extending anything

#

you just make the raw api call

broken abyss Jul 5, 2021, 4:11 PM

#

wild flax you just make the raw api call

Yeah, I got it. I used client.api before. I forgot about it. I used Structures for all new APIs like buttons/select menus etc in djs v12 so I got used to it. Thanks for the help!

bitter peak Jul 5, 2021, 4:48 PM

#

tacit crypt This is how prisma does some of its typings, especially related to rejectOnNotFo...

I could get started on a PR for this if wanted, then

real jetty Jul 5, 2021, 5:07 PM

#

bitter peak I could get started on a PR for this if wanted, then

In my opinion this can be a very good addition to improve the typing. It would solve some problems.

zenith oracle Jul 5, 2021, 5:13 PM

#

Yeah. I think there are still some things about Typings that can improved and this is one of them

upper moss Jul 5, 2021, 5:17 PM

#

After v13 finishes what do you plan on current library because of discordjs-modules what will be the priority like is major semver prs gonna get accepted in current lib

outer raven Jul 5, 2021, 5:19 PM

#

@vivid field after the typings rewrite, calling .send on a PartialDMChannel throws an error saying the function can be null on typescript when it shouldn't, do you know how to fix this or why this is happening?

vivid field Jul 5, 2021, 5:25 PM

#

Oh come on ts

#

Probably an any -> unknown change that broke something somewhere

real jetty Jul 5, 2021, 5:32 PM

#

Do you think it's possible to change the property partial to function isPartial(): this is Partial... (for example <User>.isPartial(): this is PartialUser) to improve typings ?

outer raven Jul 5, 2021, 6:00 PM

#

vivid field Probably an `any` -> `unknown` change that broke something somewhere

would that really make send become null?

#

i searched through the entire file and i could not find a reason as to why that is because its all the same as it was before

vivid field Jul 5, 2021, 6:00 PM

#

Yeah

outer raven Jul 5, 2021, 6:00 PM

#

also why change from any to unknown?

wild flax Jul 5, 2021, 6:01 PM

#

because its generally better to use unknown

vivid field Jul 5, 2021, 6:01 PM

#

https://github.com/discordjs/discord.js/blob/master/typings/index.d.ts#L3919 to be more exact

outer raven Jul 5, 2021, 6:01 PM

#

but you can't reassign a type to an unknown value

wild flax Jul 5, 2021, 6:01 PM

#

spread function annotations shouldn't be switched though, so that was just a mistake

outer raven Jul 5, 2021, 6:02 PM

#

so all spread functions should be any?

#

ill open the PR

vivid field Jul 5, 2021, 6:08 PM

#

I'm going through it already, except if you got the PR ready now

outer raven Jul 5, 2021, 6:08 PM

#

i think i got it all ready

#

only had to replace all ...args: unknown with ...args: any

#

and hasParams i think too

neat bolt Jul 5, 2021, 6:09 PM

#

gotta be careful with that unknown/any change

vivid field Jul 5, 2021, 6:09 PM

#

Single args break that too, so basically any callback parameter

neat bolt Jul 5, 2021, 6:09 PM

#

always think about subtyping and variance yeptune

outer raven Jul 5, 2021, 6:10 PM

#

so like this too?

vivid field Jul 5, 2021, 6:10 PM

#

That no

#

e.g. when you got public method(callback: (arg: unknown) => void): void;

outer raven Jul 5, 2021, 6:10 PM

#

actually those shouldn't even be unknown, doesn't discord-api-types have those?

neat bolt Jul 5, 2021, 6:10 PM

#

generally if it produces a value, you want unknown, if it consumes a value you want any

#

and also because nothing extends unknown, any time you do a conditional with unknown itll always be false

neat bolt Jul 5, 2021, 6:13 PM

#

vivid field e.g. when you got `public method(callback: (arg: unknown) => void): void;`

this can be correct sometimes, whats the function KasenPeek

outer raven Jul 5, 2021, 6:14 PM

#

that doesn't actually appear anywhere tho so its just the ...args change

vivid field Jul 5, 2021, 6:14 PM

#

There's no actual function for that, just an example I tested

neat bolt Jul 5, 2021, 6:14 PM

#

oh

neat bolt Jul 5, 2021, 6:15 PM

#

neat bolt generally if it produces a value, you want unknown, if it consumes a value you w...

but yeah just follow this yeptune

vivid field Jul 5, 2021, 6:15 PM

#

Same error as with rest parameters

neat bolt Jul 5, 2021, 6:15 PM

#

well yea, thats def wrong

#

youre basically assuming an unknown is Message

#

which is kinda against the whole point of it

#

im kinda surprised that works with any tbh

#

they should both fail

vivid field Jul 5, 2021, 6:17 PM

#

Well yea because any disables practically all type checking

#

So anything is assignable to it and any is assignable to everything

wild flax Jul 5, 2021, 6:17 PM

#

everything is any in TS until you explicitly type it

neat bolt Jul 5, 2021, 6:17 PM

#

yep, if you want to be completely correct there, as in cb can be called with anything, then unknown is actually correct

wild flax Jul 5, 2021, 6:17 PM

#

so it makes sense that it works

neat bolt Jul 5, 2021, 6:18 PM

#

i should write a blog on subtyping and variance in ts

broken abyss Jul 5, 2021, 6:22 PM

#

vivid field Same error as with rest parameters

Use generics:

declare function fn<T>(cb: (args: T) => void): void;

fn((message: string) => null);

neat bolt Jul 5, 2021, 6:22 PM

#

thats actually the same as any

#

or rather, its the same as nothing at all

#

fn can't produce a value of T because it doesnt know what T is

#

so cb can't be called, ever

broken abyss Jul 5, 2021, 6:23 PM

#

neat bolt `fn` can't produce a value of T because it doesnt know what T is

fn knows its string from inferring

neat bolt Jul 5, 2021, 6:23 PM

#

no it doesnt

loud jayBOT Jul 5, 2021, 6:23 PM

#

pr_open #6057 in discordjs/discord.js by ImRodry opened 13 seconds ago (review required)
types(*): change spread function args to any
📥 npm i ImRodry/discord.js#types-any-spread

outer raven Jul 5, 2021, 6:24 PM

#

i think that's all right?

neat bolt Jul 5, 2021, 6:24 PM

#

the caller specifies that it is string, but at the body of fn, all it knows is T

#

go and try to implement that function yourself and you'll see

#

@outer raven i'll leave some comments

outer raven Jul 5, 2021, 6:25 PM

#

alright ty

neat bolt Jul 5, 2021, 6:27 PM

#

bleh, easier here

#

for the setInterval and stuffs, do something like

foo<T extends any[]>(f: (...args: T) => void, ...args: T)

outer raven Jul 5, 2021, 6:29 PM

#

what difference does it make?

#

i actually had the last args as any[] but changed last minute cuz i thought they were wrong lol

neat bolt Jul 5, 2021, 6:29 PM

#

the difference is the generic

#

now the stuff you receive in the callback is the same as the stuff you pass to the function

broken abyss Jul 5, 2021, 6:30 PM

#

that was my initial thought. you can handle that T in your fn body

outer raven Jul 5, 2021, 6:30 PM

#

true

#

its just these 3 right?

neat bolt Jul 5, 2021, 6:30 PM

#

broken abyss that was my initial thought. you can handle that T in your fn body

are you talking about the setInterval or the stuff earlier

outer raven Jul 5, 2021, 6:31 PM

#

pushed

broken abyss Jul 5, 2021, 6:31 PM

#

neat bolt are you talking about the setInterval or the stuff earlier

maybe i misunderstood. i came later and just commented on the screenshot only without readin' above.

neat bolt Jul 5, 2021, 6:31 PM

#

vivid field Same error as with rest parameters

ya this thing?

broken abyss Jul 5, 2021, 6:31 PM

#

neat bolt ya this thing?

yeah

neat bolt Jul 5, 2021, 6:31 PM

#

a generic doesnt work there as i said earlier

#

yeptune

#

very simply:

function fn<T>(cb: (args: T) => void): void {
  cb(???);
}```

#

so the type makes no sense

broken abyss Jul 5, 2021, 6:34 PM

#

yeah

vivid field Jul 5, 2021, 6:36 PM

#

outer raven that doesn't actually appear anywhere tho so its just the ...args change

It does, L1403, L1409, L1820 and L1821

#

There's also a last unknown at L4312 that I think also needs to be changed

neat bolt Jul 5, 2021, 6:40 PM

#

are the first four actually any or should they be unknown, like i said earlier

#

4312 needs to be changed yea

vivid field Jul 5, 2021, 6:41 PM

#

The first four are what I showed above

neat bolt Jul 5, 2021, 6:41 PM

#

you want the user to be able to assume the type?

vivid field Jul 5, 2021, 6:41 PM

#

With the single unknown param in the callback

#

It should be treated the same as unknown rest params in a callback, no?

neat bolt Jul 5, 2021, 6:42 PM

#

no

#

if its any, any function type works

#

if its unknown, they have to type it as unknown and cast explicitly

vivid field Jul 5, 2021, 6:42 PM

#

(arg: unknown) => void and (...args: unknown[]) => void should both be any from what I can see

neat bolt Jul 5, 2021, 6:42 PM

#

not always

vivid field Jul 5, 2021, 6:42 PM

#

Thonk

neat bolt Jul 5, 2021, 6:42 PM

#

it depends on what theyre used for

#

for example to check if something is a function, T extends (...args: any[]) => void is correct

#

to say that a function can be called with unknown value(s), cb: (...args: unknown[]) => void is correct

vivid field Jul 5, 2021, 6:44 PM

#

But most of the changed stuff is the latter example

#

Because unknown[] doesn't seem to work for callback parameters

neat bolt Jul 5, 2021, 6:44 PM

#

how so?

#

function f(c: (a: unknown) => void): void;
f((x: unknown) => typeof x === 'string' ? ... : ...);

#

if you mean to say that the user knows what the type is and they can assume their types are correct then a: any

vivid field Jul 5, 2021, 6:46 PM

#

If we were to fix only the extends issue, that would be maybe 3 changed lines, the rest is just so you can do f((x: Message) => ...)

neat bolt Jul 5, 2021, 6:47 PM

#

neat bolt if you mean to say that the user knows what the type is and they can assume thei...

so yes?

vivid field Jul 5, 2021, 6:47 PM

#

I.. think so yea

neat bolt Jul 5, 2021, 6:48 PM

#

depends what yall wanna do theCutest

vivid field Jul 5, 2021, 6:49 PM

#

I'm not really opposed to keeping that as unknown there, just saw some people having problems with it

#

i.e. <#djs-help-v14 message>

neat bolt Jul 5, 2021, 6:49 PM

#

it looks like those might be served better by generics?

analog oyster Jul 5, 2021, 6:50 PM

#

there are plenty of breaking changes already, why make the message listener deprecated instead of just removing it altogether PES_Think

neat bolt Jul 5, 2021, 6:51 PM

#

oh, is there not a type for message collector? @vivid field

vivid field Jul 5, 2021, 6:51 PM

#

There should be

neat bolt Jul 5, 2021, 6:51 PM

#

ah

#

there is, but the events arent overloaded

#

theres your actual problem

solemn oyster Jul 5, 2021, 6:52 PM

#

analog oyster there are plenty of breaking changes already, why make the message listener depr...

Because it breaks the 100% of bots

vivid field Jul 5, 2021, 6:52 PM

#

Oh yea

#

There are overloads missing

outer raven Jul 5, 2021, 6:52 PM

#

vivid field It does, L1403, L1409, L1820 and L1821

Oopsie i swear i went through all unknowns and didn’t notice, will fix

neat bolt Jul 5, 2021, 6:53 PM

#

i'd say for events and such, you should go with unknown

#

users can augment the interface to add their own events

#

and if they use a non-literal event name string, they should get unknown

#

but depends on what the other guys think

vivid field Jul 5, 2021, 6:54 PM

#

Sounds good to me

neat bolt Jul 5, 2021, 6:55 PM

#

@vivid field thats your cue to @ everyone related btw

#

theCutest

#

fine i'll do it angeryCat

vivid field Jul 5, 2021, 6:59 PM

#

I can't decide that tho meguFace

#

It's just my opinion

neat bolt Jul 5, 2021, 6:59 PM

#

@wild flax what do about unknown/any in callbacks

wild flax Jul 5, 2021, 6:59 PM

#

just keep any

neat bolt Jul 5, 2021, 6:59 PM

#

you heard the man yeptune

wild flax Jul 5, 2021, 6:59 PM

#

less of a headache

#

and with the TS rewrite we can do it better anyway

vivid field Jul 5, 2021, 7:00 PM

#

Then the PR should be fine as-is I think

neat bolt Jul 5, 2021, 7:00 PM

#

you gotta make a new pr for messagecollector

vivid field Jul 5, 2021, 7:01 PM

#

Couldn't that also be handled by the collector generics?

neat bolt Jul 5, 2021, 7:01 PM

#

i dunno

vivid field Jul 5, 2021, 7:01 PM

#

Or is there none for that

neat bolt Jul 5, 2021, 7:01 PM

#

i didnt read the whole thing meguFace

vivid field Jul 5, 2021, 7:01 PM

#

Same tbh

#

Yeah the params for the collect/dispose events seem to be the same as the ones passed to the filter

neat bolt Jul 5, 2021, 7:03 PM

#

@zenith oracle read this whole channel meguFace

vivid field Jul 5, 2021, 7:03 PM

#

So I can probably just do the same thing there

zenith oracle Jul 5, 2021, 7:04 PM

#

meguFace

outer raven Jul 5, 2021, 7:04 PM

#

meguFace

#

does @discordjs/the-big-3 actually do anything on github?

#

also who are the big 3 I thought there were 4 lol

wild flax Jul 5, 2021, 7:07 PM

#

early responders, which is usually kyra, me and vlad

outer raven Jul 5, 2021, 7:08 PM

#

but will it tag you?

wild flax Jul 5, 2021, 7:09 PM

#

yeah

neat bolt Jul 5, 2021, 7:09 PM

#

space is emergency responder yeptune

outer raven Jul 5, 2021, 7:09 PM

#

aight

#

cries in not blue text swagcat_cry

#

bitter peak Jul 5, 2021, 7:14 PM

#

I'm working on separating Interaction into Interaction and GuildInteraction for typings; where the latter has the guildId and guild properties always set, and the channel is a GuildChannel. Is this pattern okay and how should this be inherited by subclasses of Interaction?

surreal hollow Jul 5, 2021, 7:16 PM

#

Where/who do I complain to about all the dumb changes v13 has?

neat bolt Jul 5, 2021, 7:16 PM

#

me

#

ReimuHammer

bitter peak Jul 5, 2021, 7:16 PM

#

bitter peak I'm working on separating `Interaction` into `Interaction` and `GuildInteraction...

@neat bolt

neat bolt Jul 5, 2021, 7:17 PM

#

oh uh

#

i think we should let typings somewhat reflect the actual code

#

dunno, can you give a sample

real jetty Jul 5, 2021, 7:18 PM

#

real jetty Do you think it's possible to change the property ``partial`` to function ``isPa...

I didn't see a response during the discussion so I'm reposting my message XD

neat bolt Jul 5, 2021, 7:19 PM

#

sounds reasonable at a glance

bitter peak Jul 5, 2021, 7:24 PM

#

hm, maybe in that case would a generic to modify the properties be okay in this case? I know you said you were somewhat against it, but what about this:

type If<T extends boolean, A, B> = T extends true ? A : B;

export class Interaction<InGuild extends boolean = boolean> {
  public readonly channel: If<InGuild, Channel, PartialDMChannel | null>;
  public channelId: If<InGuild, Snowflake, Snowflake | null>;
  public readonly guild: If<InGuild, Guild, null>;
  public guildId: If<InGuild, Snowflake, null>;
  // ...
  public inGuild(): InGuild;
}

export class CommandInteraction<InGuild extends boolean = boolean> extends Interaction<InGuild> {
  public readonly command: If<InGuild, ApplicationCommand<{ guild: GuildResolvable }>, ApplicationCommand | null>;
  public readonly channel: If<InGuild, TextChannel | NewsChannel  | ThreadChannel, DMChannel | PartialDMChannel | null>;
  // ...
}

@neat bolt

neat bolt Jul 5, 2021, 7:27 PM

#

uhh

#

maybe, maybe not

#

needs more thinking about

#

here's one improvement though, type If<T extends boolean, A, B> = T extends true ? A : T extends false ? B : A | B since the last case is T = true | false

bitter peak Jul 5, 2021, 7:29 PM

#

ah right ty

neat bolt Jul 5, 2021, 7:42 PM

#

@tacit crypt we had a whole discussion on why things should be any in certain places beeproll

solemn oyster Jul 5, 2021, 7:43 PM

#

Can't be unknown*