#Modernizing the main toolbar

1 messages · Page 1 of 1 (latest)

spark vessel
#

Discussion around #5261. Please forward any points that you feel are important to the discussion.

Related discussion: #dev-support message

Adding @inner rain @pulsar oxide @fervent ocean @quasi moat @plain thicket

hazy starBOT
fervent ocean
#

i will be removing the oscilloscope from the toolbar, and anybody who disagrees with me must face me in a duel

spark vessel
#

Easter-egg that bitch and draw it behind the entire display.

#

Seriously speaking, the oscilloscope is really nice when the CPU is spiking. Even if the one we have is bad, the idea of it is very nice IMO.

#

Nevermind, we have a CPU meter.

#

Is that staying?

plain thicket
#

if so, I'd gladly test that and we can remove the oscilloscope altogether, since we'd have a viable replacement

fervent ocean
plain thicket
#

in that case, please look at #7460

fervent ocean
#

i just think the oscilloscope doesn’t deserve to be where it currently is

spark vessel
plain thicket
#

basically, I've worked this out a long time ago, we'd need these UI elements:

  • window size knob
  • pause button
  • display field
#

I tried fixing IanCaino's oscilloscope but failed to fix the discontinuation happening in the middle of the display

#

(khm even though I know exactly what's causing it khm)

#

the code is pretty old and out new amplifier boilerplate is much better, so it's unironically smarter to just make it from scratch

#

I believe there's a new circle buffer implementation available in LMMS? that's basically all one would need

#

the size of the buffer is the window size, you populate it with frames, then in the next cycle you move the buffer 256 frames ahead and populate it with the new 256 frames, etc

#

since there's some static around it now, I could pick it back up?

fervent ocean
#

if you want to that would be great

#

i am willing to contribute however you are comfortable with

plain thicket
#

Sure, I could spin it up again and see where I end up

quasi moat
#

like water in some games, for some reason

#

what about using EQ visualisation?

#

but in lower resolution

#

EQ or spectrum analyser

#

it could be more useful that oscillator

plain thicket
#

nah

#

if we're kicking the oscilloscope out, we should kick everything out

#

you want it? put it on the master

quasi moat
#

well, it is useless

#

at this moment

#

what kind of viable feedback it provide in its current state?

plain thicket
#

yeah, on that being about the oscilloscope, I agree

quasi moat
#

the same kind of feedback is basically in mixer already

plain thicket
#

I don't think the oscilloscope being useless is a reason to swap it out for a spectrum analyzer

#

the name of the game is uniformity, the user should need to learn exceptions

quasi moat
#

and we should force users to use mixer to, well, mix and watch if signal levels are nice

plain thicket
#

I disagree

#

the mixer is for mixing

#

the new mixer comes with a wonderful dB peak display number field

#

making mixing even easier in terms of catching spikes in dynamics, reading the average level of your mix on a dB level, etc

#

the user should mix his tracks

#

how would he know their level if not by seeing them

#

the existence of the waveform display ("oscilloscope") plugin would be great since you can put it on any track and follow along

pulsar oxide
plain thicket
pulsar oxide
plain thicket
#

to me it's eye candy

quasi moat
#

there is no point of oscilloscope in toolbar, when mixer have more than enough tools to show signal levels already

plain thicket
#

to me, focusing on the toolbar having cool visual pieces is doing the windowsills before the foundation

fervent ocean
#

This channel is not about whether or not an oscilloscope is useful or not, it’s about rearranging the toolbar. There will be an oscilloscope in some form for those who want it

plain thicket
#

dynamics displaying, for one

#

you can visualize how much you're limiting or clipping with your plugins now

#

visually, again

inner rain
#

These are the possible outcomes as I see them

#

some points regarding FL's implementation

#

FL also allows entering an edit mode where you can put whatever wherever you want, but that is probably wildly out of scope for us, forever

fervent ocean
#

forever? maybe not. for what i’m willing to do? yeah LOL

inner rain
#

I would think for our purposes we would categorize it like power supplies: not modular, semi modular, full modular. FL is full modular, and we are currently not modular, but semi modular could be possible

#

I'm mostly interested in the applications of some of FL's toolbar modules (like click to toggle on the track time/measure widget)

quasi moat
#

could be possible to move play, stop, record and zoom controls from editors into toolbar?

pulsar oxide
#

Let's leave modularity once the foundations are made solid imo

quasi moat
#

well, song editor use different zoom than automation and pianoroll, so it would be an issue

inner rain
#

we would still have toolbars on them

pulsar oxide
# quasi moat could be possible to move play, stop, record and zoom controls from editors into...

Some people are against it, as they feel like it's more intuitive to have per editor controls instead that a switch on the topbar from song editor to B/B (either spekular or secondflight, i can't remember where they wrote this down)
I'm in favour of it personally, it's very FL like but it's the only way to deal with 2 editors play in a single place, and it would make the play controls always visible which is good for accessibility in workflow

I'm wondering what would happen to the pianoroll play controls tho, fl doesn't have them for example, but it also mean that the workflow gets longer to play a single clip as you have to set it solo in the editor (and it wouldn't loop either unless you add a loop to the editor)

inner rain
#

they just would not have the play button "widget", i guess. this does seem in line with the recent global spacebar play PR

#

my opinion is out of scope. transport controls being global is confusing in an MDI workspace

pulsar oxide
#

If there's any way to keep the pianoroll one, song editor and B/B could be unified in the main toolbar

quasi moat
pulsar oxide
#

But it can definitely be done as a separate step after the toolbar modernization

pulsar oxide
inner rain
#

it does not fit with people that have all windows visible because multimonitor/big viewport

#

(side note this is why i'm a huge proponent of floating windows with modern snap)

quasi moat