I know there are a couple of older posts | Unreal Source | Page 1

crude glacier May 29, 2024, 7:00 AM

#

Figure a thread might be easier to follow with multiple conversations going @mellow shard


AAstralPlayerState::AAstralPlayerState(const FObjectInitializer& ObjectInitializer)
    : Super(ObjectInitializer)
{
PrimaryActorTick.bCanEverTick = true;
    PrimaryActorTick.bStartWithTickEnabled = true;

    AbilitySystemComponent = ObjectInitializer.CreateDefaultSubobject<UAstralAbilitySystemComponent>(this, TEXT("AbilitySystemComponent"));
    AbilitySystemComponent->SetIsReplicated(true);
    AbilitySystemComponent->SetReplicationMode(EGameplayEffectReplicationMode::Full); //Unless we enable multiplayer full replication is the best bet

    StatsSet = CreateDefaultSubobject<UDefaultAttributeSet>(TEXT("StatsSet"));
}

brazen dome May 29, 2024, 7:01 AM

#

what's AstralPlayerState.h line 45?

mellow shard May 29, 2024, 7:01 AM

#

whats AbilitySystemComponent in header

crude glacier May 29, 2024, 7:01 AM

#

The core implementation here is very similar to Lyra, if not the exact same in many cases.

#

Oh my mistake, I'll grab the header

crude glacier May 29, 2024, 7:02 AM

#

brazen dome what's AstralPlayerState.h line 45?

Line 45 is:

// Gets the ability system component used for game wide things
UFUNCTION(BlueprintCallable, Category = "Astral|PlayerState")
UAstralAbilitySystemComponent* GetAstralAbilitySystemComponent() const { return AbilitySystemComponent; }

brazen dome May 29, 2024, 7:02 AM

#

seems loke UAstralPawnExtensionComponent::HandleChangeInitState is trying to call GetAstralAbilitySystemComponent on a nullptr

#

so the UAstralAbilitySystemComponent you store and use there is invalid?

#

run with debugger attached to crash and go up in callstack

mellow shard May 29, 2024, 7:03 AM

#

crude glacier Line 45 is: ```c++ // Gets the ability system component used for game wide thin...

how AbilitySystemComponent uprop declared as?

crude glacier May 29, 2024, 7:03 AM

#

UPROPERTY(VisibleAnywhere, Category = "Astral|PlayerState")
TObjectPtr<UAstralAbilitySystemComponent> AbilitySystemComponent;

mellow shard May 29, 2024, 7:04 AM

#

then your problem somewhere is missing check in AstralPawnExtensionComponent.cpp:280

brazen dome May 29, 2024, 7:04 AM

#

it's crashing in the get, so I can only assume that the this at that point is invalid

brazen dome May 29, 2024, 7:04 AM

#

brazen dome seems loke UAstralPawnExtensionComponent::HandleChangeInitState is trying to cal...

so this

crude glacier May 29, 2024, 7:05 AM

#

I'll see if I can backtrack in the debugger 👍

mellow shard May 29, 2024, 7:05 AM

#

just switch frames in call stack

brazen dome May 29, 2024, 7:05 AM

#

in case you don't know how to debug, check this https://tackytortoise.github.io/2022/06/24/common-slacker-issues.html#basic-debugging

crude glacier May 29, 2024, 7:06 AM

#

That's a great resource, I don't use the debugger very often so I'm not super well verse with all its tools.

mellow shard May 29, 2024, 7:07 AM

#

another person who likes to suffer

crude glacier May 29, 2024, 7:07 AM

#

Sure do, that's the game dev way!

brazen dome May 29, 2024, 7:07 AM

#

in short, select DebugGame Editor configuration and press f5 to launch

#

when the crash occurs your IDE will break and you get all the info

crude glacier May 29, 2024, 7:15 AM

#

So based on the debugger it looks like GetAstralAbilitySystemComponent() is null, so when HandleChangeInitState() tries to reference it, it breaks.

#

The ASC, however, should exist -- or at least I'd think it does considering I can interact with it in editor before PIE.

Is there an easy way to see where the ASC may have been changed to become null after PIE begins within the debugger?

mellow shard May 29, 2024, 7:17 AM

#

show code of HandleChangeInitState

crude glacier May 29, 2024, 7:18 AM

#

Sorry for the ignorance, what does "in handle" mean?

mellow shard May 29, 2024, 7:18 AM

#

HandleChangeInitState

crude glacier May 29, 2024, 7:19 AM

#

Probably not much help but here ya go

void UAstralPawnExtensionComponent::HandleChangeInitState(UGameFrameworkComponentManager* Manager, FGameplayTag CurrentState, FGameplayTag DesiredState)
{
if (DesiredState == AstralGameplayTags::InitState_DataInitialized)
    {
        // This is currently all handled by other components listening to this state change
    }

    InitializeAbilitySystem(GetPlayerState<AAstralPlayerState>()->GetAstralAbilitySystemComponent(),GetPlayerState<AAstralPlayerState>());
}

mellow shard May 29, 2024, 7:19 AM

#

oh. you do not check for null

if (CurrentState == LyraGameplayTags::InitState_DataAvailable && DesiredState == LyraGameplayTags::InitState_DataInitialized) 

       APawn* Pawn = GetPawn<APawn>();
        ALyraPlayerState* LyraPS = GetPlayerState<ALyraPlayerState>();
        if (!ensure(Pawn && LyraPS))
        {
            return;
        }

#

also you do the thing outside of state check

#

meaning it may be called at any state and not only when available/initialized

#

https://github.com/EpicGames/UnrealEngine/blob/16dc333db3d6439c7f2886cf89db8907846c0e8a/Samples/Games/Lyra/Source/LyraGame/Character/LyraHeroComponent.cpp#L146

#


void ULyraHeroComponent::HandleChangeInitState(UGameFrameworkComponentManager* Manager, FGameplayTag CurrentState, FGameplayTag DesiredState)
{
    if (CurrentState == LyraGameplayTags::InitState_DataAvailable && DesiredState == LyraGameplayTags::InitState_DataInitialized)
    {
        APawn* Pawn = GetPawn<APawn>();
        ALyraPlayerState* LyraPS = GetPlayerState<ALyraPlayerState>();
        if (!ensure(Pawn && LyraPS))
        {
            return;
        }

        const ULyraPawnData* PawnData = nullptr;

        if (ULyraPawnExtensionComponent* PawnExtComp = ULyraPawnExtensionComponent::FindPawnExtensionComponent(Pawn))
        {
            PawnData = PawnExtComp->GetPawnData<ULyraPawnData>();

            // The player state holds the persistent data for this player (state that persists across deaths and multiple pawns).
            // The ability system component and attribute sets live on the player state.
            PawnExtComp->InitializeAbilitySystem(LyraPS->GetLyraAbilitySystemComponent(), LyraPS);
        }

        if (ALyraPlayerController* LyraPC = GetController<ALyraPlayerController>())
        {
            if (Pawn->InputComponent != nullptr)
            {
                InitializePlayerInput(Pawn->InputComponent);
            }
        }

        // Hook up the delegate for all pawns, in case we spectate later
        if (PawnData)
        {
            if (ULyraCameraComponent* CameraComponent = ULyraCameraComponent::FindCameraComponent(Pawn))
            {
                CameraComponent->DetermineCameraModeDelegate.BindUObject(this, &ThisClass::DetermineCameraMode);
            }
        }
    }
}

crude glacier May 29, 2024, 7:23 AM

#

mellow shard ``` void ULyraHeroComponent::HandleChangeInitState(UGameFrameworkComponentManag...

That's a different script though, the Hero component and the Extension component.

Also my implementation (naming aside) is the same

//(I just called it CharacterGameplayComponent rather than "hero")
void UAstralCharacterGameplayComponent::HandleChangeInitState(UGameFrameworkComponentManager* Manager, FGameplayTag CurrentState, FGameplayTag DesiredState)
{
    if (CurrentState == AstralGameplayTags::InitState_DataAvailable && DesiredState == AstralGameplayTags::InitState_DataInitialized)
    {
        APawn* Pawn = GetPawn<APawn>();
        AAstralPlayerState* AstralPS = GetPlayerState<AAstralPlayerState>();
        if (!ensure(Pawn && AstralPS))
        {
            return;
        }

        const UAstralPawnData* PawnData = nullptr;

        if (UAstralPawnExtensionComponent* PawnExtComp = UAstralPawnExtensionComponent::FindPawnExtensionComponent(Pawn))
        {
            PawnData = PawnExtComp->GetPawnData<UAstralPawnData>();

            // The player state holds the persistent data for this player (state that persists across deaths and multiple pawns).
            // The ability system component and attribute sets live on the player state.
            PawnExtComp->InitializeAbilitySystem(AstralPS->GetAstralAbilitySystemComponent(), AstralPS);
        }

        if (AAstralPlayerController* AstralPC = GetController<AAstralPlayerController>())
        {
            if (Pawn->InputComponent != nullptr)
            {
                InitializePlayerInput(Pawn->InputComponent);
            }
        }

        // Hook up the delegate for all pawns, in case we spectate later
        if (PawnData)
        {
            if (UAstralCameraComponent* CameraComponent = UAstralCameraComponent::FindCameraComponent(Pawn))
            {
                CameraComponent->DetermineCameraModeDelegate.BindUObject(this, &ThisClass::DetermineCameraMode);
            }
        }
    }
}

mellow shard May 29, 2024, 7:24 AM

#

wait, so what you have.
this #1245269803460067348 message
or #1245269803460067348 message

#

first is wrong - it does not check for PS or State

#

second is correct - it does check for State and PS

crude glacier May 29, 2024, 7:25 AM

#

Both exist within Lyra's implementation https://github.com/EpicGames/UnrealEngine/blob/16dc333db3d6439c7f2886cf89db8907846c0e8a/Samples/Games/Lyra/Source/LyraGame/Character/LyraPawnExtensionComponent.cpp

mellow shard May 29, 2024, 7:26 AM

#

anyway

#

you must check for state and PS not being null

#

like herocomp does

crude glacier May 29, 2024, 7:27 AM

#

The implementation for each is the same, in my version and Lyra's. Now I change some of the other stuff in each of these classes, but these functions at least are identical.

Yeah helpful advice regardless, especially since I've unlocked the debugger (feels like an item upgrade)

#

Ah, it looks Lyra changed HandleChangeInitState to no longer call InitializeAbilitySystem. Not sure whether the GIT version or UE marketplace version is correct, but I'll try removing that line and see if it works

#I know there are a couple of older posts