Roguelike Dungeon Structure Improvements

[rare ledge]

Rework roguelike dungeon structures in a few key ways to make them more interesting and varied to explore.
Starting ideas:

• Add new biomes that the dungeons can spawn in, and fix oddities in biome placement for existing roguelike dungeons
• Enhance the "themes" of dungeons to offer much more variety depending on where the dungeon spawned. Many unused themes exist, and new ones could also be made
• Add new rooms that cater to the theme more heavily. New rooms and unused rooms could be used
• Potentially support other dimensions as well

Full info: https://docs.google.com/document/d/1mocQjOAz3eqM3ABk3ohwiP7sSasHn_bDJQ687Wcx1mM/edit?tab=t.0

This is NOT planned for GTNH 2.8, instead targeting 2.9. Please feel free to discuss any new ideas or enhancements to existing ideas

@fierce ocean

[red ginkgo]

That End themed dungeon will be perfect for shulkers

Nerf idea: Surround dungeons with dungeon walls that are unbreakable

[sand smelt]

considering how expansive they are, that will undoubtedly impact miners

[fierce ocean]

Thanks @rare ledge !

[rare ledge]

sorry for the delay, still settling in from the move

[red ginkgo]

miners need ot be updated to not acutally place and then break mining pipes. Have it render a fake one with the TESR

[fierce ocean]

@wintry dagger

[sand smelt]

that'd be dope, but then would it still stop on bedrock or warded glass, for example?

[red ginkgo]

that would be up to discussion

[wintry dagger]

I think a vex like mob

Would stop cheese

And be non intrusive

The vanilla anti cheese method

Essentially a mob that can hit through blocks or move through blocks

On the lower levels

I think the less intrusive option is better

Even if it is slightly worse anti cheese

It doesnt have to be as fast and annoying as the vex

But a slower ghost mob

Or mob that can break blocks

I would be very annoyed if the build im doing gets cut off by a bedrock roguleike dungeon build

Another thing is being able to see the surrounding cave while your inside is nice

Find ore veins/geodes while exploring

Or other vanilla dungeons

[novel olive]

Is there actually much benefit to an anticheese box here? If you really want to cheese there's vanilla bedrock breaking techniques that would be available.

[fierce ocean]

The main idea is the less cheese-friendly the dungeons are, the more they can have interesting loot.

[sand smelt]

dark oak for example is beyond simple

[sand smelt]

i think at that point, cordoning it off by dimension would be more likely ot anti-cheese it, and make better loot available

like, TF gets lv loot, end gets mv/hv, Moon gets hv, etc.

[fierce ocean]

That's definitely part of the solution yes

[wintry dagger]

I think the current loot for overworld is fine to cheese

It intentionally does not contain much progression items

Also the trial spawner thing works

For anti cheese

[fierce ocean]

Yup I'd like to backport those things to hold the better dungeon loot https://minecraft.wiki/w/Ominous_Trial_Spawner

[wintry dagger]

Adding the snow dungeon is easy

So ill do a pr for that

And looks cool

[potent geode]

An improvement I see from gt6 is that, with gt6, loots are not generated until opened, and if player mines them up without looting the chest, the chest has an nbt of what kind of loot it has, for example:"lich tower loot 1" and player can get it back home to open them, I love this change and hope we can implement this into dungeons, lootgames, twilight, and maybe other places.

And opening chest also gives some xp, which is nice

[wintry dagger]

part of exploration is inventory management

[potent geode]

sure

[sand smelt]

theres also a mod, im not sure which, in modern versions which has an instance of loot per player

and each palyer cna loot it once

[wintry dagger]

lootr

if the trial spawners get implemented

it would work similarly

[wintry dagger]

tried to add a new dungeon

and got a crash on world creation

I added these 4 files to the config

it might be the syntax error in dungeon ice

but even then it never crashed when there was a syntax error before

yeah it is fixed

when i fixed the config, but it never crashed when the json was incorrect in earlier versions

[fierce ocean]

That doesn't seem to be the full crash log

[wintry dagger]

How do you view full logs

[fierce ocean]

Double click the instance in prism

[fierce ocean]

@wintry dagger Let's make it a standard that when making a RLD PR that adds a new dungeon type, we should attach a seed to that PR that proves the dungeon does spawn

I'm spending a lot of review time just trying to find one in the wilds

Oh wow I didn't know the Nature's Compass let you teleport to arbitrary biomes, handy for testing.

okay got one for snow dungeon:
seed: 8
x: 1677, z: -718, y: 71

[fierce ocean]

By the way @wintry dagger I would strongly encourage you to give your commits proper name that reflect the changes you're making in them.

[wintry dagger]

Ok

Ill add some better custom themes

[fierce ocean]

Awesome.

Probably not in scope for 2.8 but I wonder if we could make some ice mobs spawn there

[sand smelt]

there are certain structure-specific spwans,yeah

like maze crabs/armour knights/living armour spirit things in TF

and wither skeletons

[wintry dagger]

You can override the spawners

In the dungeon configs

[abstract bear]

How is this going? Since some players are finding out shulkers doesn't spawn anywhere and well it was discussed in here to add them into dungeons

[wintry dagger]

been workin on other projects recently

i might start this back up in a bit

[primal nacelle]

I rather not see them in Roguelike, Some people do disable these including me. To make them became a must have for the pack meh. They really should also spawn in the end. It does sound like end cities will become a thing in the long run with that whole project anyways so it's more of a waiting game.

just my 2 cents ❤️

[wintry dagger]

i wouldnt consider

shulkers to be a very annoying enemy

especially in low cieling dungeons

[wintry dagger]

alright ill start working on this again soon

i think the biome changes are quick and make sense

[wintry dagger]

ok figured out how to add modded blocks to custom rooms without disturbing other rooms

[wintry dagger]

just gona improve each dungeon 1 at a time, starting with forest
1st floor:
Theme: Carpeted house with wooded walls
Rooms:
Bteam room
Kitchenete room
bedroom

2nd floor:
Theme: Modern style house with hempcrete walls
library
bathroom
pool table room

3rd floor:
theme: Complete basement
storage room
utility room
bathroom

4th floor:
theme: incomplete basement
lab
crypts
ossuary

5th floor:
theme: backrooms
long hallways
netherfort
slime
music

now time to go through the long process of making custom rooms

[wintry dagger]

if anyone has good mob ideas for spawners

that would be nice

[abstract bear]

TForest mobs ( there are many skeletons), Futurum husk, it could be nice to have dirt/gravel creepers in dungeons, if it explode they are going to be very annoying

[primal nacelle]

bedrock all of the underground structures so people can't dig around them muhaha??? nah I will keep removing the mod instead 😛

[wintry dagger]

Dont want to disrupt the world so dont want to add unbreakable blocks

[abstract bear]

You can add very hard ones, like the ones used in TForest dungeons

[sand smelt]

unbreakable blocks arent even a fix, considering how many ways there are to phase trhough blocks

especialy if you ahve the inviniciblity ring on and dont have to worry about suffocation

[idle wyvern]

Trying to locate chests and phasing through walls/breaking bedrock doesnt require pretty much the same efforth a few torch runs after setting your spawn near the dungeon do?

[low ermine]

bteam room? like decade ago bteam from the mindcrack trial?

[wintry dagger]

Hmm

the issue i am seeing is dungeons are op with one ring

and useless without

it is literaly impossible to beat rld without cheese

something is more important than structure changes

no matter what structure changes i do

rld will be bad as long as infernal mobs exist in the dungeon

[low ermine]

speed potion and torch spam is usually sufficient in my experience
and/or strategic tunnelling
likelihood of an infernal also being fireproof is p low, so lava gloves can do fine

[wintry dagger]

yeah the only way to beat it is to cheese

[low ermine]

the problem imo is infernal mobs themselves, bc... cheese is all, exaclt

[wintry dagger]

yeah infernal mobs is the problem

[low ermine]

can you take a hit from a zombie or does it have armor pen plus strength.
can you be seen by a mob or is it going to suffocate you.
things like this are... annoying, and not particularly engaging

Its funny. mobs can be basically solved as early as day 1 if you get a bed, moreso with creosote. OP swords and crossbows are mainstays of most players.

but straight up engaging in a fight is so discouraged by the mechanics provided that cheese dominates
im even in favor of mobs still ruining our day earlygame thats part of the fabric of the game by now, just...

now that engaging with the dungeons sincerely is becoming more fun the other flaws are more apparent?

(sidenote: the Mighty Zombie Pigman is a thing to be feared. RIP hardcore runs 2 and 7.
i wish thaumcraft bosses were more apparent from range.)

[wintry dagger]

I think they should atleast not be abled to be spawned it by mob spawner

as both rld and lich tower

greatly suffer bc of that

or just make custom entities

that cant be inferno

[idle wyvern]

I wonder if adding other kind of threats in roguelike dungeons could be a solution

es: adding a gun turret to a floor 4 treasure room actived by a redstone signal

this would solve the torch cheese problem but could still be cheesed by tunneling above or under it

traps in general are bad design in minecraft as long as you can just dig them out

[atomic fractal]

Worldgen in general has been really bothering me for months, so I decided to make a proof-of-concept for a declarative structure generator. This one is a (badly made ) tower with a variable number of staircases down, though I could've done anything.

This might be useful if anyone wants to make their own dungeons, though it'll need a lot of polish to make it production ready.

If I have time I want to make a terrain sculptor that will automatically fix the stupid terrain around structures by flattening it out and getting rid of other worldgen features like trees.

https://github.com/RecursivePineapple/MagicMod/blob/master/src/main/java/magicmod/common/worldgen/structure/test/TestStructurePieceGenerator.java

https://github.com/RecursivePineapple/MagicMod/blob/master/src/main/resources/assets/magicmod/structures/dungeon/stone-brick-tower.json
https://github.com/RecursivePineapple/MagicMod/blob/master/src/main/resources/assets/magicmod/structures/dungeon/stone-brick-stairs.json

Ideally I'd also integrate it with the block state system I made for the matter manipulator, but I'd only bother doing that if I was going to implement this seriously

[wintry dagger]

Interesting

It would take a lota effort to port every rld feature to this

But would probably make new room creation slightly easier

Roguelike dungeon can prob be modified to create most types of desirable dungeon structures

[atomic fractal]

Yeah, it probably isn't worth the effort to port existing dungeons to it. It would be useful for new ones though.

[wintry dagger]

is there any features for modded blocks, loot, or connected structures, like a village

might allow for some cool space worldgen

[atomic fractal]

I haven't added loot chests but those would be pretty easy to add, I'd either have to add a hook for when a block is placed or add a field in the block palette for it. Maybe a combination of the two.

You can already use modded blocks, it just stores the block with its ID and its meta. I'm not sure what you mean by connected structures.

[wintry dagger]

like a cluster of structures

liek a village is a cluster of village houses

uless vilages are randomized in some other way

[atomic fractal]

Doing a village the same way that vanilla does it would be tricky because it doesn't use prefabs, but you could make some road pieces and house pieces with the proper sockets and it should just work.

Each piece in this system is just a collection of blocks with some connector points. It'll stitch pieces together based on whether the connector points match. To limit the size there's a budget system, so you'd make a village-size budget category with a random amount initially and each road/house would consume some of the budget.

[wintry dagger]

ok

[wintry dagger]

I think some planets can be improved with this but deserves a different aoi

[wintry dagger]

Is this ready to be used, i am thinking about designing better space dungeons

[atomic fractal]

Yes but it's very finicky, so be prepared for a lot of headaches. It's very unpolished currently, and I'm sure there are lots of bugs.

This is the main way you create structure pieces. It won't add sockets or budget operations, but it'll generate everything else. It'll print the path where the files are, but it's under the minecraft working directory in a folder called structure-pieces.
You just copy these files into somewhere in the resources folder and put the full resource path in the load call (it has to be in the same jar as the world generator because it isn't an MC resource, it's loaded from the jar directly).
For now I'd just write everything in this mod and add GC deps, but I can pull the generator code out into another mod later. Or you can copy it, it's pretty self-contained.
https://github.com/RecursivePineapple/MagicMod/blob/master/src/main/java/magicmod/common/worldgen/structure/core/StructurePieceCommand.java

[wintry dagger]

Has this worldgen structure thing been worked on