Hekili WA Broken TWW Launch Patch | WeakAuras Community | Page 1

whole fulcrum Aug 13, 2024, 11:15 PM

#

I'm not sure if this is WA or Hekili issue honestly - Not savvy enough to tell. 😦 With the updates today it broke the Hekili WA I've been using, rather simple code, but it ties into specific functions from the Hekili addon so I'm unsure if that's what the issue is perhaps.

`function()
local Ability_ID = Hekili_GetRecommendedAbility("Primary")
local icon, _ = nil, nil

if Ability_ID ~= nil then
    Ability_ID = Hekili.Class.abilities[Ability_ID].item
    icon = C_Item.GetItemIconByID(Ability_ID)
else
    _, _, icon, _, _, _  = C_Spell.GetSpellInfo(Ability_ID)
end
return icon

end`

vital maple Aug 13, 2024, 11:42 PM

#

you get the icon with C_Spell.GetSpellInfo(Ability_ID).iconI now, not like that

#

but besides that, this error looks like ability_id isn't exactly a spell Id before that

#

since it says "bad argument to ..."

#

check if Hekili.Class.abilities[Ability_ID].item is still the proper way (and Ability_ID is actually an id)

whole fulcrum Aug 13, 2024, 11:43 PM

#

Yep getting this on a dump value for that.. It's returning in a table now?

#

The spell ID is there just have to somehow pull it out

vital maple Aug 13, 2024, 11:46 PM

#

local Ability_ID = Hekili_GetRecommendedAbility("Primary")[1]

whole fulcrum Aug 13, 2024, 11:49 PM

#

So now since it's a number it can't be indexed, trying to resolve..

vital maple Aug 14, 2024, 12:01 AM

#

wait, actually I think that's how it's displayed on /dump when it returns multiple things

#

the way it was should've been fine then

#

then it comes doesn to Hekili.Class.abilities[Ability_ID].item being wrong in some way

#

get devtool and look at the hekili table

#

!vdt

jade sierraBOT Aug 14, 2024, 12:02 AM

#

https://github.com/brittyazel/DevTool
Dump tables there with DevTool:AddData(table, "title")

vital maple Aug 14, 2024, 12:03 AM

#

/run DevTool:AddData(Hekili) and see if it's still the same makeup (-> class -> abilities -> id -> item)

whole fulcrum Aug 14, 2024, 12:13 AM

#

Not seeing anything for ID under abilities - There are plenty of abilities there though, and items..

#

vital maple Aug 14, 2024, 12:15 AM

#

I have no clue about Hekili or even less about how it's internally made

#

But yes that doesn't look like ability IDs to me there

#

Either ask Hekili, or the author of that aura

whole fulcrum Aug 14, 2024, 12:17 AM

#

It does have ability ID's listed there, for example, Bestial Wrath

#

But yeah - Thank you for trying to assist

vital maple Aug 14, 2024, 12:24 AM

#

whole fulcrum It does have ability ID's listed there, for example, Bestial Wrath

Ok, but that doesn't have an item value

#

Hekili.Class.abilities[Ability_ID].item is what you're trying to access in your code there

#

And it's not there

#

Do Hekili.Class.abilities[Ability_ID].id instead I guess

#

That would at least be a valid spell id for C_Spell.GetItemIconByID which is what the error complains about

whole fulcrum Aug 14, 2024, 12:33 AM

#

Trying to simplify this.. I've gotten it to return the icon associated with the itemID using the above, but trying to get it to return the spell icon now.. you'd think that would be simple

function()
icon = C_Spell.GetSpellInfo(Hekili.Class.abilities[Hekili_GetRecommendedAbility("Primary")].id).iconID
return icon
end

All this code needs to do is read the icon from Hekili_GetRecommendedAbility("Primary") and translate that to the icon variable.. You'd think this would be simple. 😦

Edit: Simplified to the above, works fine, just doesn't check for items only abilities

#Hekili WA Broken TWW Launch Patch