Execute as GM in midiQOL in macros | Foundry VTT | Page 1

crude citrus Jul 19, 2022, 8:07 AM

#

#macro-polo message for the options. Continue your questions about this process here.

next mural Jul 19, 2022, 8:07 AM

#

Okay thanks a lot

crude citrus Jul 19, 2022, 8:08 AM

#

should have done this a bit sooner, always forgot we helpers can create threads 🙂

next mural Jul 19, 2022, 8:08 AM

#

That's cool ahah

wise hornet Jul 19, 2022, 8:09 AM

#

My main suggestion when writing Midi and DAE macros is,...
DAE args to Midi args ❌
Midi args to DAE args 🆗

#

because they both use args[0]

crude citrus Jul 19, 2022, 8:10 AM

#

if you have a question on this topic i think you can ping us here and the thread will appear in the side bar for the pinged user, right?

next mural Jul 19, 2022, 8:10 AM

#

Yes

next mural Jul 19, 2022, 8:10 AM

#

wise hornet My main suggestion when writing Midi and DAE macros is,... DAE args to Midi args...

Sorry I don't think I understand the difference

wise hornet Jul 19, 2022, 8:11 AM

#

so you're using macro.execute launched from which source? Dae?

#

DAE > launches on the target
On Use Midi > launches on the caster

next mural Jul 19, 2022, 8:12 AM

#

from ... I can't remember let me check

wise hornet Jul 19, 2022, 8:12 AM

#

both have different provided variables

next mural Jul 19, 2022, 8:12 AM

#

So your rule for macro.executes is?

wise hornet Jul 19, 2022, 8:13 AM

#

usually when called in an active effect it's launched through DAE

#

so all your midi args won't work in it

next mural Jul 19, 2022, 8:13 AM

#

next mural from ... I can't remember let me check

Okay in truth it's a bit weird

#

So I use OnUse ItemMacro, then from the ItemMacro I create and item (with margeObject) that has a dae with macro.execute in it

wise hornet Jul 19, 2022, 8:14 AM

#

yeah then you step into DAE at that point

next mural Jul 19, 2022, 8:15 AM

#

yep

wise hornet Jul 19, 2022, 8:15 AM

#

You could technically run both an on use and dae macro on top of it eachother, but you have to start from on use

next mural Jul 19, 2022, 8:15 AM

#

In the macro.execute I use lastArg does that change anything?

wise hornet Jul 19, 2022, 8:16 AM

#

everything, the variables are different

next mural Jul 19, 2022, 8:16 AM

#

So I have no way of fixing the code?

#

I have do redo part of it?

wise hornet Jul 19, 2022, 8:17 AM

#

You can piggy back and transfer over variables from On use into the active effect you're creating if you want

#

I stuff in all sorts of data

#

You can either create your own midi flag, or toss it in under dae flags

next mural Jul 19, 2022, 8:18 AM

#

I actually already doing that, I create an Active Effect from the ItemMacro OnUse and then what?

wise hornet Jul 19, 2022, 8:18 AM

#

depends what you're end result is

#

like do you need to refer to back to the caster?

#

do you need to refer to one of the casters stats?

next mural Jul 19, 2022, 8:19 AM

#

Okay so, the end result for this specific thing is to deal additional damage based on data on the original item

#

It's an infusion of ammunition so I have to "mark" the target so it takes more damage from the ammunition

wise hornet Jul 19, 2022, 8:20 AM

#

You could just write a DamageBonus macro

#

apply an active effect to the target with nothing special on it

next mural Jul 19, 2022, 8:21 AM

#

Yeah I didn't know of its existence at the time

#

Maybe I should just re-write it

wise hornet Jul 19, 2022, 8:21 AM

#

on the DamageBonus macro you check for the effect, check if they have that ammo equipped on the weapon

next mural Jul 19, 2022, 8:21 AM

#

it was junky as heck

wise hornet Jul 19, 2022, 8:22 AM

#

it's just a bunch of filtering

next mural Jul 19, 2022, 8:22 AM

#

Yeah

#

It's doable

#

Okay yeah I'll re-write it

#

But not now my brain hurts I have like 2 hours of sleep at best right now

#

Thank you so much, I'll come back later when I had a bit of sleep

wise hornet Jul 19, 2022, 8:24 AM

#

sure have a good night

next mural Jul 19, 2022, 8:25 AM

#

Sadly it's morning ahaha I'll try to rest a bit, see you later!

burnt slate Jul 19, 2022, 12:35 PM

#

next mural Okay so, the end result for this specific thing is to deal additional damage bas...

I would hate to throw another wrench into this, but creating a temporary item on an unowned actor is a prime application for warp gate

#

In fact, you use the exact same syntax regardless of ownership

next mural Jul 19, 2022, 1:11 PM

#

burnt slate I would hate to throw another wrench into this, but creating a temporary item on...

Ahah don't worry, I needed to redo it regardless that one was a bit junk from the beginning

#

After a bit of work and a close inspection I have the last two items that don't work

#

But I'm a bit stuck

next mural Jul 19, 2022, 1:45 PM

#

I have this macro that throws this error: dae | Error evaluating macro for onUpdateActor ReferenceError: targetActor is not defined

📎 message.txt

#

The macro is a macro.execute called form dae => flags.dae.onUpdateTarget

next mural Jul 19, 2022, 2:14 PM

#

Okay found the problem it was a small silly thing

next mural Jul 19, 2022, 2:27 PM

#

burnt slate I would hate to throw another wrench into this, but creating a temporary item on...

Btw since I always wanted to use warpgate I saw that there's a readme on the project page but I wonder is there others official documents that I can read about to learn all things I can do with warpgate?

burnt slate Jul 19, 2022, 2:29 PM

#

the readme is the official API documentation, the wiki has examples and discussion of its use

next mural Jul 19, 2022, 2:48 PM

#

So in the read me I find everything I need correct?

burnt slate Jul 19, 2022, 3:40 PM

#

next mural So in the read me I find everything I need correct?

that's my hope! 🙂

next mural Jul 19, 2022, 3:58 PM

#

burnt slate that's my hope! 🙂

Grazie!

next mural Jul 19, 2022, 4:28 PM

#

wise hornet on the DamageBonus macro you check for the effect, check if they have that ammo ...

Ah now I remember why I didn't do the flags.dnd5e.DamageBonusMacro, it's because since the item can be handed to other players and it's supposed to work but damageBonusMacro works only on the source of the dae

#

So I opted for a super convoluted solution

#

Which works even tho it's super ugly in my opinion

#

But now that I think about it maybe there's a way to make that also work

#

If I modify the item so the effects is on transfer and on it

wise hornet Jul 19, 2022, 5:11 PM

#

next mural Ah now I remember why I didn't do the flags.dnd5e.DamageBonusMacro, it's because...

When you unequip the item, it should remove the active effect. So when the new player equips it, it should place the active effect on them.

next mural Jul 19, 2022, 5:12 PM

#

Yeah

#

I'm trying to rewrite it right now

#

How do I save a previous item effect when I mergeObject to create the new one with the new effect?

#

Like if the item before had an active effect I don't want to overwrite it

#

But how do I save the one there was before?

wise hornet Jul 19, 2022, 5:16 PM

#

well it's only going to apply it when transfer to equipped is checked

next mural Jul 19, 2022, 5:16 PM

#

Sorry I don't understand

wise hornet Jul 19, 2022, 5:18 PM

#

next mural Jul 19, 2022, 5:18 PM

#

I'm doing a mergeObject to overwrite the old item to give it the new infusion active effect that deals the additional damage under the right conditions, and I want to save the old active effect that the item could have had

wise hornet Jul 19, 2022, 5:18 PM

#

You can just use duplicate

next mural Jul 19, 2022, 5:19 PM

#

wise hornet You can just use `duplicate`

And the new effect?

wise hornet Jul 19, 2022, 5:19 PM

#

then update the duplicant and update the active effect, if you want to modify it on the fly

#

although it depends, is this a permanent change?

next mural Jul 19, 2022, 5:20 PM

#

like in concept what I want to do is: new_effect = new_effect + old_effect (if present);

next mural Jul 19, 2022, 5:20 PM

#

wise hornet although it depends, is this a permanent change?

No

wise hornet Jul 19, 2022, 5:21 PM

#

you could use warpgate and modify the flags

next mural Jul 19, 2022, 5:21 PM

#

next mural No

But that's already sorted out as a problem

next mural Jul 19, 2022, 5:22 PM

#

wise hornet you could use warpgate and modify the flags

At the very moment I do not know how to use Warpgate, I do not need to modify the flags, I'm trying to add the old active effect into the new one

#

Like a c++ list if you know what I mean

wise hornet Jul 19, 2022, 5:23 PM

#

active effects just flags

next mural Jul 19, 2022, 5:23 PM

#

[old_data] ---pointer--->[new_data]

next mural Jul 19, 2022, 5:23 PM

#

wise hornet active effects just flags

Okay didn't know that one

wise hornet Jul 19, 2022, 5:25 PM

#

if you don't want to use warpgate, then you'll need to look up the active effect, duplicate it to a temporary object. Make the changes to that object, then update the main active effect with those changes.

next mural Jul 19, 2022, 5:26 PM

#

I just did this:
let old_effect = duplicate(weaponItem.data.effects);

bla bla stuff stuff
effects: [new_effect, old_effect]

next mural Jul 19, 2022, 5:26 PM

#

wise hornet if you don't want to use warpgate, then you'll need to look up the active effect...

I would love to use warpgate I just need to study it a bit

wise hornet Jul 19, 2022, 5:26 PM

#

https://github.com/trioderegion/warpgate/wiki

next mural Jul 19, 2022, 5:27 PM

#

next mural I just did this: let old_effect = duplicate(weaponItem.data.effects); bla bla s...

I feel like this would not work or does it?

wise hornet Jul 19, 2022, 5:28 PM

#

it wouldn't be that way, you would need to push in the new flags

#

if new effects were being added

next mural Jul 19, 2022, 5:29 PM

#

What if all this is in a margeObject?

#

Shouldn't that do exactly that?

wise hornet Jul 19, 2022, 5:30 PM

#

so lets say.. this is our primary effect..

let effectData = [{
            changes: [
                { key: `flags.midi-qol.disadvantage.attack.all`, mode: CONST.ACTIVE_EFFECT_MODES.CUSTOM, value: 1, priority: 20 },
                { key: `flags.midi-qol.grants.advantage.attack.mwak`, mode: CONST.ACTIVE_EFFECT_MODES.CUSTOM, value: 1, priority: 20 },
                { key: `flags.midi-qol.grants.advantage.attack.msak`, mode: CONST.ACTIVE_EFFECT_MODES.CUSTOM, value: 1, priority: 20 },
                { key: `flags.midi-qol.grants.disadvantage.attack.rwak`, mode: CONST.ACTIVE_EFFECT_MODES.CUSTOM, value: 1, priority: 20 },
                { key: `flags.midi-qol.grants.disadvantage.attack.rsak`, mode: CONST.ACTIVE_EFFECT_MODES.CUSTOM, value: 1, priority: 20 },
                { key: `data.attributes.movement.walk`, mode: CONST.ACTIVE_EFFECT_MODES.OVERRIDE, value: Math.floor(target.actor.data.data.attributes.movement.walk / 3), priority: 20 }
            ],
            origin: itemUuid,
            disabled: false,
            flags: conditionFlags,
            duration: { rounds: 10, startRound: gameRound, startTime: game.time.worldTime },
            icon: conditionIcon,
            label: condition
        }];
        let prone = target.actor.effects.find(i => i.data.label === condition);
        if (!prone) await MidiQOL.socket().executeAsGM("createEffects", { actorUuid: target.actor.uuid, effects: effectData });

next mural Jul 19, 2022, 5:30 PM

#

This is a portion of the macro in question

📎 message.txt

burnt slate Jul 19, 2022, 5:31 PM

#

arrays are merged as atomic values, btw

#

if there are two changes array, they will not be concatenated

next mural Jul 19, 2022, 5:32 PM

#

ehm yes I totally know what that means, totallyyyy ahaha sorry I'm kinda new to Javascript

burnt slate Jul 19, 2022, 5:32 PM

#

you also wont be able to update the embedded ActiveEffect collection of an owned item

next mural Jul 19, 2022, 5:33 PM

#

burnt slate you also wont be able to update the embedded ActiveEffect collection of an owned...

Why is that?

burnt slate Jul 19, 2022, 5:33 PM

#

well....i guess this way you can, but its a bit dangerous. Typically you do not update collections by updating its parent embedded array directly

wise hornet Jul 19, 2022, 5:33 PM

#

then you'd need to find it..

let effect = token.actor.effects.find(i=> i.data.label === "prone");
let updates = duplicate(effect.changes);
await updates.push({ key: "flags.dnd5e.meleeCriticalDamageDice", mode: CONST.ACTIVE_EFFECT_MODES.ADD, value: 1, priority: 20 });
effect.update([updates]);

haven't actually tested this, paths are probably wrong to changes

next mural Jul 19, 2022, 5:35 PM

#

uhmmmm I'm gonna be honest here, I'm understanding little of this, I'll try and test all this stuff to try and make the end of it

wise hornet Jul 19, 2022, 5:35 PM

#

Actually i think theres a much easier method with SetProperty, oh wait that's for updating

burnt slate Jul 19, 2022, 5:35 PM

#

what's the overall goal again?

next mural Jul 19, 2022, 5:36 PM

#

The overall goal is to infuse a weapon or ammunition in order to make it deal more damage (damage depends on the item that "summons" the infusion)

#

With a save and stuff

wise hornet Jul 19, 2022, 5:36 PM

#

why not just warpgate the item?

#

instead of messing with the AE

next mural Jul 19, 2022, 5:37 PM

#

I have the code for it and it works I'm just trying to clean it up using DamageBonusMacro

burnt slate Jul 19, 2022, 5:37 PM

#

yea, the number of hoops you will need to jump through for this operation in core is...as you can tell...a bit much

next mural Jul 19, 2022, 5:37 PM

#

Okay I'll go and study Warpgate ahah

wise hornet Jul 19, 2022, 5:37 PM

#

AE is great for duration effects

next mural Jul 19, 2022, 5:37 PM

#

Ah yes this is a duration effect

#

After a minute it vanishes

#

Again I actually made it work, I just wanted to make it look prettier

wise hornet Jul 19, 2022, 5:38 PM

#

I mean you could add additional active effects.. but i think in this case, warpgate might just be easier

burnt slate Jul 19, 2022, 5:39 PM

#

next mural Again I actually made it work, I just wanted to make it look prettier

if you have something working, go with it, maybe revisit wg in the future -- one of its main features is a highly abstracted API for modifying tokens/actors/items/AEs/etc (anything associated with an actor)

next mural Jul 19, 2022, 5:40 PM

#

Okay so I should just leave it be for the moment you think?

#

I'm actually a bit proud of it, it's just doesn't look super good

wise hornet Jul 19, 2022, 5:41 PM

#

oh anything you don't need in your active effect, don't include it

burnt slate Jul 19, 2022, 5:42 PM

#

for example, this will make the target's Longsword a +1 weapon

const updates = {
  embedded: { Item: {
    'Longsword':
      'data.attackBonus': '+1',
      'data.damage.parts': [['1d8 + @mod + 1', 'slashing']],
      'name': 'Longsword +1'
  }}}

await warpgate.mutate(game.user.targets.first(), updates, {}, {name: 'Magical Weapon'});

#

and thats all you need!

burnt slate Jul 19, 2022, 5:43 PM

#

next mural Okay so I should just leave it be for the moment you think?

i think so, soak up your success before bashing your face more 🙂

wise hornet Jul 19, 2022, 5:43 PM

#

I remade Shillelagh in warpgate, made things a lot of easier

burnt slate Jul 19, 2022, 5:43 PM

#

i just did Magic Stone as well

next mural Jul 19, 2022, 5:44 PM

#

Thank you all!

wise hornet Jul 19, 2022, 5:44 PM

#

let itemId = html.find('[name=weapons]')[0].value;
                        let weaponItem = tactor.items.get(itemId);
                        let weaponName = weaponItem.name;
                        let weaponDamage = weaponItem.data.data.damage.parts[0][0];
                        let adjustedDamage = weaponDamage.replace(/1d(4|6)/g, "1d8");
                        let itemUpdates = {
                            "data": {
                                "ability": tactor.data.data.attributes.spellcasting,
                                "properties.mgc": true,
                                "damage": { "parts": [[adjustedDamage, "bludgeoning"]] }
                            }
                        };
                        let updates = { embedded: { Item: { [weaponItem.name]: itemUpdates } } };
                        await warpgate.mutate(target.document, updates, {}, { name: itemName });

burnt slate Jul 19, 2022, 5:45 PM

#

lovely, even going as far as modifying the actual damage die portion, rather than just flat replacing it!

wise hornet Jul 19, 2022, 5:45 PM

#

theres a ton more logic before that hehe

#

but that's the main guts after all the filtering

next mural Jul 19, 2022, 5:50 PM

#

wise hornet ```js let itemId = html.find('[name=weapons]')[0].value; ...

?

wise hornet Jul 19, 2022, 5:50 PM

#

Shillelagh in warpgate

#

well a snippet from my macro of it

#

I get the weapon from a list of available weapons on the actor, then pass that through a dialog which the player selects. Then you get the weapon properties and make the changes needed. then you use warpgate to apply those changes

#

#

next mural Jul 19, 2022, 5:56 PM

#

Ah yes I did something similar just with macros

#

Warpgate seems really really cool I'm sure I'll look into it soon enough!

#

Probably tomorrow morning or something

crude citrus Jul 19, 2022, 5:58 PM

#

warpgate is the bomb

next mural Jul 19, 2022, 6:00 PM

#

I am biased to favourite midi but just because tposney is basically my teacher at this point

#

But yes Warpgate seems like an extremely powerful tool

burnt slate Jul 19, 2022, 6:01 PM

#

(its about to get twice as powerful in the near future, too)

next mural Jul 19, 2022, 6:02 PM

#

Ahaha yeah I like foundry for the freedom I have as a programmer

#

Tbh it's pretty straightforward too since it's been like, how much? A month at best that I started programming in it and I'm already doing some interesting stuff in it

#

I don't even care to do insane things with it, just practical stuff

wise hornet Jul 19, 2022, 9:42 PM

#

Yeah I often revise my stuff all the time after I've learned better techniques when writings things

#Execute as GM in midiQOL in macros