#Adventure Card Feedback
1 messages ยท Page 1 of 1 (latest)
I noticed that if a hand gives another player observer permission, the actions for the card are still available to click even though they should be hidden ideally. This means a player can play a card from another's hand. The script does fail when it attempts to delete the card.
I also suggest the setup script add observer permissions to all players which makes reviewing cards for trading easier.
A player who has a role of None still gets a hand created for them. I suggest the script also check for u.role > 0.
The How To JE is marked up as an unordered list, but I'm not sure why. If it's necessary to keep it as a ul element, I'd add list-style-type: none; to its styles.
The How To JE still has some german in the credits. Maybe that's intentional though.
All in all, awesome job! I am loving it!
I also love that I can rename "Destiny's Child" to "Child of the Prophecy" for my Eberron games.
Another minor detail, capitalization of card titles is inconsistent. That's really nitpicking though.
Thanks. I will find the gitlab service desk email
These are good clean ups
Meh link looks broken
Added a note about having the setup script add observer permissions to all hands for all players.
OK, submitted them all
I just picked up my copy and will be using in tonight's Legend of the Ramblehouse Saint recording. I am sure that I will have something to add after tonight.
Are you able to verify that they all went through? I only got a Gitlab bot reply for one of them.
Only one
Dangit!
Maybe it added them as comments to the same one for some reason?
I submitted 5. ๐ฆ
Huh. Wonder if it's because I replied to my sent email and edited the subject.
most likely
many ticket systems would group those
Yeah, I thought it would behave similar to Gmail where changing the subject creates a new "conversation"
Any thoughts on how to show a bigger card image on click?
I think @night oar figured this out in Monarch
Should I resubmit those other ones?
What are we asking me?
Clicking on the image of a card to open it in the core image viewer
The ImagePoput (I think that's the name) class is pretty easy to use.
You just need to pass it the path of the image, a title, and tell it whether or not to allow sharing.
Cool, can you take a look at our card sheet in the Adventure deck to see if that can get worked into the next version?
I think @violet urchin does this for showing character art from the Actor context menu as well
Do you think I should resubmit these or will the team handle creating the separate issues?
I think the team can handle it
Alright. Played with them last night. I couldn't find anything additional to add, I think Kristian hit all the points needed.
Thanks, I'll take that as a "good overall" evaluation
Absolutely. My players loved it. We don't use any other Mods for it, and it worked smoothly.
Glad to hear. I know most of the team is busy on getting the other product lines fixed up for v9/bug fixes but will try to get a patch for this done too.
Thank the team for us, please. This is an awesome addition to the SWADE Foundry experience.
Hi @narrow wolf . I bought the adventure card deck tonight and I have a request to improve the experience. It is about the size of the cards. It's a little small especially on small screens or for people who are getting to be old like my ๐ the Monarch module has an option to change the size. Is possible to implemented?
Of course tell the team that it greatly enhances the experience with the cards.
๐
Thanks, we are working on an option to make the cards bigger when you click on them
Also the developer of Monarch is working to make it compatible with adventure cards. So both options should help you
awesome! Great news!
is there is a way (even macro commands) to have quick access to the hand (without going to the deck panel and clicking on the hand item) ?
Yes, you can write a macro to loop through all hands associated with that group and give them default permissions for observer
Unfortunately I'm on my phone and at MACE West and can't write it up, but #macro-polo might be of help.
and if it is only for the owner of the hand ?
Oh you mean open the hand!
Sorry I thought you meant permission to view it
I have no idea honestly
Probably a macro but also check keybinding
Might be as simple as assigning a key like opening a character sheet
const hand = game.cards.getName(<name here>);
hand.sheet.render(true);
name is Name of the hand, eg "Arnok's Adventure Hand"
thanks a lot !
This one works assuming they only have one hand
game.cards.contents.find(d=>d.data.permission[game.user.id]===3 && d.data.type==="hand").sheet.render(true)
it will just open the first hand the user has permission to view
Reusing the first feedback thread.
OK, so Deal Adventure Cards is strictly for start of session, not mid-session drawing of additional cards. That seems obvious now.
I guess I was surprised that it shuffled it at all, but that's a decent convenience feature. I would have imagined it would draw from whatever current state the deck was in.
AUto shuffle is nice since most decks come sequenced by default
True
When you reset it, it returns to the original order, and if the GM doesn't shuffle, they'd draw the same cards every time.
happens to me more than I care to admit with the Action Deck ๐
why is everyone getting clubs?
At first I thought it was shuffling for each player, but it was for each deal to all players.
I think because it refreshed the deck sheet, and I thought it changed the order.
@narrow wolf do you want me to send an email about the setup script not setting observer permissions?
no need, one step ahead of you :D
yeah I already merged in the fix
not sure when we can get a hotfix pushed
but it'll get solved whenever the next update happens
It's not exactly an emergency. ๐