Token Says LocaleCompare error | Foundry VTT | Page 1

lilac furnace Feb 9, 2022, 7:51 PM

#

@hallow kettle I created a thread so as not to clutter the main chat. Can you please see if this error occurs when colorsettings is disabled? Also, if you can run game.settings.get('token-says', 'rules') in you console and paste here the result that will also help (I'm guessing you can't export your sayings if you can't open the form). Sorry to put work onto you but I cannot recreate or see an obvious culprit.

hallow kettle Feb 9, 2022, 7:59 PM

#

you mean the module, lib - color settings? Or there a colorsettings somewhere else I'm not seeing?

lilac furnace Feb 9, 2022, 7:59 PM

#

lib - color settings. It is called out in the console error so just want to avoid that as some type of conflict

#

(its not a conflict on my end but I'm also not on the Forge so difficult to know if it is coming into play here in that set up)

hallow kettle Feb 9, 2022, 8:03 PM

#

disabling color settings didn't help, but I'll post the console log of that game settings

#

#

i imagine it might be the one missing a name title, though it wouldnt let me save any without a name so I'm not sure how one doesnt have one

lilac furnace Feb 9, 2022, 8:08 PM

#

Yes, the label - it requires a title but when a saying is originally created it won't have one. Sorry, I thought you only had one saying 🙂 so I limited my testing there. I'll push out a candidate fix and let you know when it is available. Likely not for another hour or so. Sorry for the bother on this and thank you for your help in troubleshooting

hallow kettle Feb 9, 2022, 8:08 PM

#

is there a console command i could use to delete that object from the list in the mean time? since i now have the id of it

lilac furnace Feb 9, 2022, 8:17 PM

#

There is, I can draft up something for you if it comes down to it but I wouldn't want to rush it. I pushed out a quick release to see if this does anything. If not, I will have more time in about an hour. This is a candidate release but can be installed in the Foundry installer by putting in a manifest link here (copy this and paste into the manifest link area): https://github.com/napolitanod/Token-Says/releases/download/1.8.1/module.json

hallow kettle Feb 9, 2022, 8:48 PM

#

sorry, just saw this, but this update works. however, there is one saying that seems to be broken... it won't delete, won't toggle active and can't be changed (if you edit it and save, it won't save). It's the one on the previous screenshot with the id of "8ygifylk5j4389nh", the "Owl test" label. Doesn't show the label/token name, any of it's stuff in the menu or when editting it

#

a player created this saying, if it changes anything

lilac furnace Feb 9, 2022, 8:51 PM

#

Yes, I saw that in the data that you pasted. The official push I do will address that I think. Somehow you have a saying without a file type. It's as if one was split into 2 somehow. I'll have a release out today and will tag you in the releases channel

hallow kettle Feb 9, 2022, 8:51 PM

#

okay, cool. if it helps, it doesn't throw a console error when trying to delete, but this is what the console says when you try to save over it

lilac furnace Feb 9, 2022, 8:52 PM

#

Wait, a player created it?

hallow kettle Feb 9, 2022, 8:52 PM

#

Yes

lilac furnace Feb 9, 2022, 8:52 PM

#

Oh whoa. Ok. I didn't think players could. Jeez.. I'll dig into this more.

hallow kettle Feb 9, 2022, 8:53 PM

#

I thought that was by design, so they could create sayings for their own actors! Well, now you know I guess

lilac furnace Feb 9, 2022, 8:53 PM

#

Lol, maybe it is. It's been some time since I looked at that part.

hallow kettle Feb 9, 2022, 8:56 PM

#

yeah, only GMs can see it via the token's menu, but from the module settings where it brings up the menu, they can

lilac furnace Feb 9, 2022, 10:33 PM

#

hallow kettle yeah, only GMs can see it via the token's menu, but from the module settings whe...

Ok, I pushed out 1.8.2 which might now allow you to edit and save that saying that was erroring. If it doesn't then I also expanded the API so that you can delete a saying via that. I can walk you through that if you have to do it that way.

I checked out the setting for that form within the Foundry Configure Settings. It is set to restricted, which means that only GMs should be able to access that form. In my testing I couldn't see the button to launch the form unless I was assistant GM or higher on permissions. Is it possible the player has those permissions in this world?

hallow kettle Feb 9, 2022, 10:35 PM

#

the player is a Trusted Player, which in the settings i have as the same things checked as assistant GM. I assume it gives them access from the "Modify Configuration Settings" option

lilac furnace Feb 9, 2022, 10:37 PM

#

Ahhh, maybe that's it. Restricted is just a foundry toggle on off that I can set, I don't believe i have more control than that from with config. However, they should be able to add stuff without error anyway so hopefully this is a one off issue

hallow kettle Feb 9, 2022, 10:39 PM

#

my temp workaround was to just create some generic sayings and let them edit them, since that didn't cause issues

#

hmm, the 1.8.2 doesn't seem to let me get rid of the bugged saying

lilac furnace Feb 9, 2022, 10:43 PM

#

that's the "Owl Test", right?

hallow kettle Feb 9, 2022, 10:43 PM

#

yeah

lilac furnace Feb 9, 2022, 10:46 PM

#

Using the id you provided above, here is an API call that you can make in console that should delete it tokenSays.deleteSaying("8ygifylk5j4389nh")

#

I added that API call in 1.8.2

hallow kettle Feb 9, 2022, 10:46 PM

#

yep that worked, thanks

lilac furnace Feb 9, 2022, 10:48 PM

#

No idea how or what could have caused that, but feel free to ping me directly if it happens again. The error is caused by a type enforcement that I have when merging the update data with the existing data, but the data types looked fine in the screenshots you provided.

hallow kettle Feb 9, 2022, 10:48 PM

#

no problem, I had my player test making a new one and it worked fine

#Token Says LocaleCompare error