When I targeted an enemy and clicked

[viscid halo]

Uh, there's a lot going on in that error message. Can you use the mod Find the Culprit, and tell it to leave Roll Bonuses enabled, and see if the error happens with only my mod.

And if it doesn't happen with only my mod, then find out which other mod is causing it?

@lethal stratus It looks like a roll parsing issue -- if it is, is there any way to get the original formula that it's complaining about?

[lethal stratus]

Uh, if I'm not mistaken there should be a warning alongside the error that contains the formula

https://github.com/KitCat420/foundryvtt-better-roll-formulas/blob/main/modules/dice/rollParse.mjs#L26

[versed cosmos]

I can try to do that or have the game's GM do that a bit later, sure!

[versed cosmos]

That something I can find in the console?

[viscid halo]

Yes, that would be yellow text in the console

[versed cosmos]

This warning is nearby but not sure it's related:

Deprecated since Version PF1 v10
Backwards-compatible support will be removed in Version PF1 v12
    logCompatibilityWarning foundry-esm.js:4609
    get spellArea action.mjs:2399
    fillTooltip spell-tooltips.mjs:131
    addSpellTooltips spell-tooltips.mjs:209
    addSpellTooltips spell-tooltips.mjs:209
    addSpellTooltips spell-tooltips.mjs:201
    addSpellTooltips spell-tooltips.mjs:198
    #call ancillary.mjs:91
    #call foundry.js:632
    callAll foundry.js:589
    _callHooks foundry.js:5918
    _render foundry.js:5879
    _render foundry.js:6572
    _render foundry.js:7158
    _render actor-sheet.mjs:4238
    render foundry.js:5793
    call_wrapped libWrapper-wrapper.js:511
    registerLibwrappers libwrapper.js:50
    call_wrapper libWrapper-wrapper.js:639
    render#0 libWrapper-wrapper.js:193
    render foundry.js:10871
    _onUpdateDescendantDocuments foundry.js:11239
    _onUpdateDescendantDocuments foundry.js:16128
    _dispatchDescendantDocumentEvents foundry.js:11159
    #handleUpdateDocuments foundry-esm.js:56595
    _updateDocuments foundry-esm.js:56473
    update foundry-esm.js:12329
    updateDocuments foundry-esm.js:11473
    update foundry-esm.js:11584
    update item-pf.mjs:1145
    _updateObject foundry.js:7340
    _onSubmit foundry.js:6665
    _activateCoreListeners foundry.js:6600
    _activateCoreListeners foundry.js:7121
    _render foundry.js:5866
    _render foundry.js:6572
    _render foundry.js:7158
    render foundry.js:5793
    showBonusPicker bonus-picker.mjs:144
    addSettingsHandler add-bonus-to-item-sheet.mjs:38
    addSettingsHandler add-bonus-to-item-sheet.mjs:36
    addSettingsHandler add-bonus-to-item-sheet.mjs:34
    addNodeToRollBonus add-bonus-to-item-sheet.mjs:59
    <anonymous> init.mjs:12
    #call foundry.js:632
    callAll foundry.js:589
    _callHooks foundry.js:5918
    _render foundry.js:5879```

Otherwise the error is just by itself

[versed cosmos]

If you can point me to where I'm looking, I don't see a nearby warning

[viscid halo]

The top of that yellow part

[versed cosmos]

That's what I included above in the code block

That warning seems to repeat

[viscid halo]

Ok that's not it then. I think using Find the Culprit will help here. You'll have to ask the GM to do that, or you'll need elevated permissions to do that yourself

[versed cosmos]

We are playing soon so will have to do it later

[versed cosmos]

Does this help?

It won't let me remove those, and the problem still persisted.

If there are other Roll Bonus scenarios you'd like me to check I can

[viscid halo]

Can you show me again how it's configured?

[versed cosmos]

Hmm could it be the name that the ability is on? Could the parentheses or brackets be causing a parse error?

[viscid halo]

Oh yup that's definitely it. Remove the square brackets

[versed cosmos]

Yeah that worked

[viscid halo]

I wouldn't use square brackets on any can't. I'd also say it's unnecessary to include "gestalt" in the name as it's just white noise (same for "mag" but that's a bit more acceptable)

Sorry I didn't notice that the first time you posted

[versed cosmos]

Now that it works, I see it automatically applies the -2 always. I'll have to check the documentation to see how I can make that an "option" or check the status of a buff to apply it

[viscid halo]

It would've saved you a lot of heartache

[versed cosmos]

There were reasons for that on the sheet, but I can remove them

I don't always want attacks of spells to get a -2, just if I've activated Spell Combat

[viscid halo]

Use a "Conditional Modifier Bonus" instead of an attack bonus

[versed cosmos]

Thanks, will do!

[viscid halo]

It's not just my mod that will use the item name in a label, so it's possible it could break other stuff too

You can still keep some kind of "gestalt" in the item name, just don't use square brackets

[versed cosmos]

Yeah I'm seeing that now! I'll be removing them hehe

Thanks!

[versed cosmos]

Loving this mod now that I have things named right

[viscid halo]

Glad it's working out for you now 😅

[versed cosmos]

One thing that just came up. I don't see a way to have a Skill Check target type. Am I missing that?

Say I get a conditional +1 on "Bluff" checks sometime after identifying a certain monster (It's not always the same type and there's nothing on the target to check for)

[viscid halo]

There would have to be different kinds of skill actions to be able to do that. Untill the system gives a way to differentiate what an individual skill is used for I can't do anything for that

You could put a buff on the target and then you could create a "target has buff" and "skill bonus"

[versed cosmos]

Oh you can't key it off of 'rolling a skill' like you can a spell? Becuase it's not an item?

[versed cosmos]

That could work.

[viscid halo]

Well sure, but how would I know why you're rolling a skill. What's going to tell Roll Bonuses you're rolling bluff against something you've identified vs something you haven't?

[versed cosmos]

Oh I was going to use it with conditional modifiers, since there's no other way to do conditional modifiers on a skill roll

So that there was a checkbox on "Bluff" that said [ ] Studied Target

and would add +1 to the roll if checked

So consider that a feature request for me 😉

[versed cosmos]

I don't see a "Target has buff" conditional target. I see "Target has condition" but that only has built in conditions that i can see in the dropdown.

[viscid halo]

If you're talking about studied targets then just do Token Target. I think I was misremembering about the target has buff

[versed cosmos]

Actually it seems to work with "Target has Boolean Flag" and then we put a buff on the target that adds a boolean flag.

[viscid halo]

Token Target was basically made for features like Studied Target or a paladin's smite. It's easier for you because you have complete control over it instead of the GM having to apply a buff on the npc

[versed cosmos]

I'll try it out also