#Gyr's SBC issues
lost shuttle
@severe loom When you have a moment, can you try importing the Hound Archon again and getting to the point in this screenshot in the console?
If you can, I'd appreciate it if you could expand each of the sections here that SBC parsed and look for red error messages. I'd expect you'll find them in the Statistics section.
high osprey
I will say, if they have trouble loading menus, can't get to settings, etc, they have some bigger problems. They need to start with launching in safe mode
severe loom
<@754129832794783764> When you have a moment, can you try importing the Hound Ar...
I will try again tonight. I haven't tried d logging into Foundry again since yesterday, and I'm going to reboot first, and then try and see if it makes a difference.
severe loom
lost shuttle
@severe loom Can you try screenshotting just the Statistics section for me?
deft inlet
@severe loom You might want to disable scene packer module if you aren't actually using it. It's nowadays not needed because of adventure documents, tho I dunno if everything has been converted to use those. Not sure if it's influencing this, but it is injecting itself into the workflow there.
severe loom
<@754129832794783764> You might want to disable scene packer module if you aren'...
I disabled Scene Packer but it didn't fix the problem.
severe loom
<@754129832794783764> Can you try screenshotting just the Statistics section for...
I see a few other errors. One seems to say "ItemChange" error from "Athletic", which is a feat.
high osprey
You have old formulas and aren't using better roll formulas mod
Also might have an old version of pf1 content mod?
severe loom
was PF1 content mod......was that the one that had the original bestiaries etc. Beforee switching to SBC?
if I remove PF1 content mod, won't all the class abilities, traits, magic items and all that stuff vanish?
high osprey
No, it didn't have bestiaries
It has feats and items and stuff that the system doesn't have
I said you might have an outdated version that still has old formulas in it
There is an updated version with updated formulas
It has in it, for instance, skill focus (perception), which I see in one error
severe loom
oh....ok. I'll check that. Thank you. I was sure everything was updated as I updated all modules after updating Foundry and the PF1 ruleset.
high osprey
They might just be old copies on things
Like I said, you should also get better roll formulas mod
To fix things you have that have old formulas so they don't break
severe loom
I've installed Better Roll Formulas mod....just did it now.
I'm getting an error on Warpgate. No package found. Has that been turfed? Wasn't it necessary for the Mighty Morphin Mod?
severe loom
ok, I'll remove. I think PF1 automate damage is one that hasn't been updated, so I've got it deactivated..
high osprey
Roll bonuses and advanced templates are the big ones for pf1
severe loom
So, Advanced Templates PF1 doesn't appear to be updated to the current version of PF. It shows as yellow. I think I have it deactivated right now because it's yellow.
is it ok to turn on?
high osprey
No, I just said that and roll bonuses are the big outdated ones
severe loom
oh.....ok, sorry, I thought you were saying the opposeite.
OK, so I'll deactivate Roll Bonuses PF1 also..
lost shuttle
With all that done, then we can see if the error still happens.
The concerning one is the e.normalize isn't a function one, which comes into play with creating tags to try to find matching items.
deft inlet
PF1 itself changed createTag() to no longer pretend you gave it valid input when you didn't. So that would've passed without issue in older system versions.
Looks like it's handling user tags with that? Kinda weird they'd have something unexpected?
deft inlet
With all that done, then we can see if the error still happens.
The concerning ...
It might be an idea to wrap this in try-catch to print erroring items out and the data being read, and/or to ignore them:
https://gitlab.com/foundryvtt_pathfinder1e/pf1-statblock-converter/-/blob/master/scripts/sbcCompendium.js#L178-194
Considering this is not the first time createTag() has broken something for some reason.
lost shuttle
Aye, that's gonna be a good idea.
lost shuttle
No, that comment was more directed at me for how to try to future-proof this.
For now, the current request is for you to try to import the statblock again and see if the error is still there. If it is, then I can try to guide you towards getting me a bit more info.
deft inlet
From all the evidence it seems it's breaking on some compendium item with unexpected data
severe loom
ok, so the error is still there. I just got it again
lost shuttle
Alright. Looking into this, it's trying to use the existing classes on the actor to try to filter the results when it matters.
If you click the sbcCompendium.js:182:84 link in this pic, you can go to the source code. On the left is the line numbers. If you click on line 182, it should change colors to show it's "active". Trying to import again will still fail, but the browser/foundry will walk through the code.
When it stops here and it's looking at "Improved Initiative", please screenshot what it's showing please.
For some reason, it might not have the Outsider class correct.
deft inlet
ok, so the error is still there. I just got it again
If you don't mind using dev tools console (F12, console tab), you could try this little script:
for (let pack of game.packs) {
console.log("Checking", game.i18n.localize(pack.metadata.label));
for (let entry of pack.index) {
if (entry.system?.tags?.some(t => typeof t !== "string")) {
console.log("- Error:", entry.name, entry.system.tags)
}
}
}
console.log("Done!");
It should produce something like this, but with errors.
severe loom
Alright. Looking into this, it's trying to use the existing classes on the actor...
OK.....so when I look at sbcCompendium.js:182:84 in your message, I can't click on it. It's just text. Unless I'm misinterpreting what you're asking me to do.
lost shuttle
OK.....so when I look at sbcCompendium.js:182:84 in your message, I can't click ...
The line number on the far left, where it says "182". If you click on it, it should change color and not look like the other line numbers.
severe loom
Alright. Looking into this, it's trying to use the existing classes on the actor...
Is this what you're looking for?
lost shuttle
Now if you try importing the statblock again, it's going to "debug" and pause at that line whenever it gets used. Try it and you'll see some information pop up in the lower-right.
I know this is slow, but it's not happening on our ends, so we're limited to your machine.
severe loom
No. Don't apologize. I appreciate so much what you're doing to help me with this.
OK, so in the panel to the right in console, it's got a yellow message "Paused on breakpoint", and then lots of notes below that.
is that what you want?
lost shuttle
Aye. In the lower-right when it pauses, it should have some bits of information. If you grab a screenshot, I can show you what I mean.
deft inlet
Honestly one option all along was to add a login to the world and give Fair Strides info to come in and wiggle things around. Tho that is not always welcome (I never want to go into other people's servers myself to debug things).
deft inlet
Is this what you're looking for?
Oh, it was the classes rather than tags? Huh.
lost shuttle
I actually hadn't even considered the login.
severe loom
oh, geeze. I'm totally willing to do that. Sorry, I hadn't even considered that.
Do you need me to add you as a gamemaster or anything?
lost shuttle
Oh, it was the classes rather than tags? Huh.
The "class -> tag" thing is because the classes big on the items are the class tags instead of class names, but I might be able to do some refactoring herre.
lost shuttle
Do you need me to add you as a gamemaster or anything?
gamemaster would be best if that's alright.
You can DM me the link.
deft inlet
GM is the only one with SBC access, IIRC
lost shuttle
Aye
severe loom
deft inlet
I think the relevant data is in the Scope -> Local -> o bit
lost shuttle
You're close. But I can check it out if I'm in the world.
deft inlet
But what little is visible it is pointing to PF content item
Actually, if that was a breakpoint, that's just the first item being searched, not (necessarily) what it broke on.
lost shuttle
Aye. It's breaking on the class name -> tag creation, so even the first item should work to see what was in o.classes.
I swear there was a reason why I didn't just grab the tag off of the class item itself, but I can't recall. I know there's some fuzzyness because of archetype names and deity-worshipping.
lost shuttle
Update: Gyr is rolling back and going through some prep steps to re-upgrade to PF1E v11.2, and then we'll see the state of their world before I worry about SBC's issues in it.
From what I could see, all of the actions and changes were having issues that likely had a faulty migration because of potential module and formula instabilities.
severe loom
I've just finished backing up all unused actors to compendiums, deleted everything that was backed up and not needed in immediate terms.
I've also backed up and then deleted all unused scenes.
And deactivated all modules.
I'll tell Four to go ahead with backing it up and then upgrade to v. 12.