#Roll Bonus error on open

1 messages · Page 1 of 1 (latest)

rigid pike
#

I'm going to move any further talk here to not clutter up the channel.

edit: Spoiler for anyone curious. Short answer - the system wasn't prepping items within containers via the expected manner. The fix is scheduled for pf1 v10.5

gentle zodiac
#

No problem, thanks for the help btw, appreciate it

rigid pike
#

Just to confirm, this breaks only when your player opens? You (the GM) can open it just fine?

gentle zodiac
#

No I can't open it either

rigid pike
#

Ok cool, that'll make it slightly easier for me then 😅

gentle zodiac
#

as far as I can tell he only has two features that actually use roll bonuses, which are spell focus and his harrow chosen trait, if that helps

rigid pike
#

Something isn't being prepped correctly. It's not specifically that updating ownership fixes it. It's that updating anything fixes it. That's just one of the easier things to update (when you can't access the actor sheet) that's forcing data prep for the actor. But I don't know why the data isn't being prepped for that actor on startup

gentle zodiac
#

I'm not even sure what caused it to start happening, it was fine opening the world the first few times then suddenly it just wasn't

#

I could try removing testing each bonus on their own, see if there's any that's specifically causing the issue

rigid pike
#

That's not the root cause though, that's just a result of data prep not happening

gentle zodiac
#

ah ok

rigid pike
#

Quick clarification, I said "actor data isn't being prepped". It's likely it's item data for a particular item on the actor. I'll need to look into which item though

gentle zodiac
#

ah

#

I found the issue

rigid pike
#

oh?

gentle zodiac
#

I didn't notice at first, he has a load of items in a backpack which are all using roll bonuses

#

moving them from the backpack to his inventory makes it work

#

seems like it can't load while they're in the backpack or something

rigid pike
#

@tall kite
Is prepareItemData not called for Items in a container?

#

(specifically while calling final = true)

tall kite
#

I have no clue.

rigid pike
#

Yeah I see the problem. I'll submit a fix for it shortly

gentle zodiac
#

awesome, glad we could get to the bottom of it at least. Thanks for your time!

rigid pike
#

@tall kite
Fix for the system is here https://gitlab.com/foundryvtt_pathfinder1e/foundryvtt-pathfinder1/-/merge_requests/3323/diffs

@gentle zodiac
There's not much I can do to fix this in Roll Bonuses. The fix should be available once pf1 v10.5 is live (assuming the fix is accepted, that's not up to me). If the fix is not included with 10.5 then I can make something work around it, but hopefully that won't be necessary.

As a bandaid until then, just tell your player to update the actor after world loads. The easiest way to do that is to just change the token's hp and hit enter (then you can change it back immediately after)

gentle zodiac
#

Yeah not a problem, thanks again.

rigid pike