Drag ruler problem

[vivid veldt]

How can I assist?

[minor galleon]

currently im just trying to see if i can manage to replicate the issue

....actually, just to make sure, the combt tracker says "Round X" right?

because i have noticed it doesn't track historical movement when in the "not started" mode, but does show distances on single drag

as in, this is how it looks when combat is "Not Started"

compared to "round 1" or any round really

[vivid veldt]

Yeah, that was it

How can I remove the status in the next round?

That does not work. Dont know if it is a bug

It does not add the modifier. So maybe something in the effect is wrong too

[minor galleon]

it auto-applies it when over the movement, so just picking the token up and placing it down when in the green region (for example, because next combat round) should just remove it

as to why it doesn't apply, good question. i haven't actually checked if just setting those values works since the effect re-work

[vivid veldt]

It also seems that the status is set as soon as the remaining green movement is 0

So not when starting to use yellow movement

[minor galleon]

...ohhh! i think i know why it doesn't apply the modifier, downgrade might be messing with it. certainly upgrade just selects either base or the new, whatever's highter

[vivid veldt]

https://github.com/Tnoin/shadowrun-drag-ruler-integration/issues/3

[vivid veldt]

Well upgrade also does not apply

So the whole thing is not working

[minor galleon]

appologies for the delay, it does seem to apply for me (or rather, it the pool for the meele-attack goes up by 2 effectivly by giving +4 to the skill)

does it show up in the effects tab would be the first thing i can think of

[vivid veldt]

Shows up with no issue

[minor galleon]

huh, strange.

don't really have an idea what might cause that, considering my code doesn't touch the effect beyond telling condition lab to apply it

[vivid veldt]

Thats the result. So it picks it up

I am on 18.4

[minor galleon]

same, altough for me it applies just fine

atleast the "triggers a meter to early" issue was quick to solve

now to find out if the "doesn't apply" thing is something i can solve

[vivid veldt]

@elfin zealot do you have any idea why the effect is not working?

[vivid veldt]

Do you prepare a new release? 😄

[minor galleon]

i shall once i have time to sit down and find my logins for the foundry admin panel thing

currently trying to get today's work done instead of procastinating like monday 😄

[vivid veldt]

admin panel is gone. It is now under your normal account

[elfin zealot]

If it's about this one, it should apply just fine, so long as it's applyTo 'actor' and is enabled, as it is in the screenshot above.
Also you shouldn't need the .mod. A simple system.skills.active.blades (as well as the others with .mod) works fine with mode Modify.

[vivid veldt]

I tried both to be sure 😁 when I am back at the PC I check the apply to again. Tried a lot of stuff

[elfin zealot]

Send me over the exported actor then. If that works on my end, it's likely to do with some module

[elfin zealot]

The screenshot says it is 'actor'

Also any module created effects will always be 'actor' as well as that is the default fallback

[vivid veldt]

Any idea what could be wrong? Do you want an export of the actor to maybe see the error?

[vivid veldt]

I tried creating a new effect from scratch and it does not apply too

[elfin zealot]

No idea at the moment. You can send the actor export over. Though I won't be able to look into it today / tomorrow.

There are some issues with item effects not (maybe only visually) applying, however I also couln't reproduce that (https://github.com/SR5-FoundryVTT/SR5-FoundryVTT/issues/1089)

[vivid veldt]

It applies to all actors with all effects I tested. So there might be something wrong with my install. Could try re-installing if you find nothing

[vivid veldt]

I re-installed, but its still not working

[vivid veldt]

Could be solved. I had a typo in a path which lead to the whole effect not working